On 04/25/2013 06:36 AM, Luiz Capitulino wrote:
>>> One other concern - you document that if a flag parameter is omitted,
>>> then it defaults to 1. Is that really true?
>>
>>
>> I'm wrong. If it's omitted in cmdline, we will give it a default value.
>>
>> This kind of default info is only added
On Thu, 25 Apr 2013 11:52:58 +0800
Amos Kong wrote:
> On Wed, Apr 24, 2013 at 01:39:08PM -0600, Eric Blake wrote:
> > On 04/24/2013 12:20 PM, Luiz Capitulino wrote:
> > > On Thu, 25 Apr 2013 01:33:24 +0800
> > > Amos Kong wrote:
> > >
> > >> Libvirt has no way to probe if an option or property
On Thu, Apr 25, 2013 at 12:27:16PM +0800, Osier Yang wrote:
> On 25/04/13 11:52, Amos Kong wrote:
> >On Wed, Apr 24, 2013 at 01:39:08PM -0600, Eric Blake wrote:
> >>On 04/24/2013 12:20 PM, Luiz Capitulino wrote:
> >>>On Thu, 25 Apr 2013 01:33:24 +0800
> >>>Amos Kong wrote:
> >>>
> Libvirt has
On 25/04/13 11:52, Amos Kong wrote:
On Wed, Apr 24, 2013 at 01:39:08PM -0600, Eric Blake wrote:
On 04/24/2013 12:20 PM, Luiz Capitulino wrote:
On Thu, 25 Apr 2013 01:33:24 +0800
Amos Kong wrote:
Libvirt has no way to probe if an option or property is supported,
This patch introdues a new qmp
On Wed, Apr 24, 2013 at 01:39:08PM -0600, Eric Blake wrote:
> On 04/24/2013 12:20 PM, Luiz Capitulino wrote:
> > On Thu, 25 Apr 2013 01:33:24 +0800
> > Amos Kong wrote:
> >
> >> Libvirt has no way to probe if an option or property is supported,
> >> This patch introdues a new qmp command to query
On 25/04/13 09:14, Amos Kong wrote:
On Wed, Apr 24, 2013 at 02:20:20PM -0400, Luiz Capitulino wrote:
On Thu, 25 Apr 2013 01:33:24 +0800
Amos Kong wrote:
Libvirt has no way to probe if an option or property is supported,
This patch introdues a new qmp command to query configuration schema
info
On Wed, 24 Apr 2013 19:44:37 -0600
Eric Blake wrote:
> On 04/24/2013 07:35 PM, Luiz Capitulino wrote:
>
> >> case QEMU_OPT_SIZE:
> >>
> >> param_info->type = CONFIG_PARAM_TYPE_SIZE;
> >>
On Wed, Apr 24, 2013 at 07:44:37PM -0600, Eric Blake wrote:
> On 04/24/2013 07:35 PM, Luiz Capitulino wrote:
>
> >> case QEMU_OPT_SIZE:
> >>
> >> param_info->type = CONFIG_PARAM_TYPE_SIZE;
>
On 04/24/2013 07:35 PM, Luiz Capitulino wrote:
>> case QEMU_OPT_SIZE:
>>
>> param_info->type = CONFIG_PARAM_TYPE_SIZE;
>>
>> break;
>>
On 04/24/2013 07:14 PM, Amos Kong wrote:
>>> +##
>>> +{'command': 'query-config-schema', 'data': {'*option': 'str'},
>>
>> Please, let's not make option optional. It makes the code slightly more
>> complex for no good reason.
>
> For the human, if they don't know the detail name of one option, the
On Thu, 25 Apr 2013 09:14:51 +0800
Amos Kong wrote:
> On Wed, Apr 24, 2013 at 02:20:20PM -0400, Luiz Capitulino wrote:
> > On Thu, 25 Apr 2013 01:33:24 +0800
> > Amos Kong wrote:
> >
> > > Libvirt has no way to probe if an option or property is supported,
> > > This patch introdues a new qmp co
On Wed, Apr 24, 2013 at 02:20:20PM -0400, Luiz Capitulino wrote:
> On Thu, 25 Apr 2013 01:33:24 +0800
> Amos Kong wrote:
>
> > Libvirt has no way to probe if an option or property is supported,
> > This patch introdues a new qmp command to query configuration schema
> > information. hmp command i
On 04/24/2013 01:39 PM, Eric Blake wrote:
> On 04/24/2013 12:20 PM, Luiz Capitulino wrote:
>> On Thu, 25 Apr 2013 01:33:24 +0800
>> Amos Kong wrote:
>>
>>> Libvirt has no way to probe if an option or property is supported,
>>> This patch introdues a new qmp command to query configuration schema
>>
On 04/24/2013 12:20 PM, Luiz Capitulino wrote:
> On Thu, 25 Apr 2013 01:33:24 +0800
> Amos Kong wrote:
>
>> Libvirt has no way to probe if an option or property is supported,
>> This patch introdues a new qmp command to query configuration schema
>> information. hmp command isn't added because it
On Thu, 25 Apr 2013 01:33:24 +0800
Amos Kong wrote:
> Libvirt has no way to probe if an option or property is supported,
> This patch introdues a new qmp command to query configuration schema
> information. hmp command isn't added because it's not needed.
>
> V2: fix jaso schema and comments (Er
Libvirt has no way to probe if an option or property is supported,
This patch introdues a new qmp command to query configuration schema
information. hmp command isn't added because it's not needed.
V2: fix jaso schema and comments (Eric)
Signed-off-by: Amos Kong
CC: Osier Yang
CC: Anthony Liguo
16 matches
Mail list logo
