Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-30 Thread Fam Zheng
On Mon, Jan 29, 2018 at 6:36 PM, Alex Bennée wrote: > Fam Zheng writes: >> +Prerequisites >> +- >> + >> +Install "docker" with the system package manager and start the Docker >> service >> +on your development machine, then make sure you have the privilege to run >> +Docker commands.

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-30 Thread Fam Zheng
On Mon, Jan 29, 2018 at 7:04 PM, Stefan Hajnoczi wrote: > On Mon, Jan 29, 2018 at 11:31:33AM +0800, Fam Zheng wrote: > > Thanks for writing this! > > I have only reviewed some parts in detail. Thanks for the review! I've made all the fixes (except for the buses spelling. :). Fam

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-30 Thread Fam Zheng
On Mon, Jan 29, 2018 at 10:51 PM, Eric Blake wrote: > On 01/28/2018 09:31 PM, Fam Zheng wrote: >> To make our efforts on QEMU testing easier to consume by contributors, >> let's add a document. For example, Patchew reports build errors on >> patches that should be relativly easy to reproduce with

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180129033133.31288-1-f...@redhat.com Subject: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-29 Thread Eric Blake
On 01/29/2018 10:10 AM, Stefan Hajnoczi wrote: > On Mon, Jan 29, 2018 at 08:38:29AM -0600, Eric Blake wrote: >> On 01/29/2018 05:04 AM, Stefan Hajnoczi wrote: >>> On Mon, Jan 29, 2018 at 11:31:33AM +0800, Fam Zheng wrote: >>> >>> Thanks for writing this! >>> >>> I have only reviewed some parts in d

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-29 Thread Stefan Hajnoczi
On Mon, Jan 29, 2018 at 08:38:29AM -0600, Eric Blake wrote: > On 01/29/2018 05:04 AM, Stefan Hajnoczi wrote: > > On Mon, Jan 29, 2018 at 11:31:33AM +0800, Fam Zheng wrote: > > > > Thanks for writing this! > > > > I have only reviewed some parts in detail. > > > > >> + > >> +On top of libqtest,

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-29 Thread Thomas Huth
On 29.01.2018 15:36, Eric Blake wrote: > On 01/29/2018 01:42 AM, Fam Zheng wrote: >> On Mon, Jan 29, 2018 at 2:56 PM, Thomas Huth wrote: >>> On 29.01.2018 04:31, Fam Zheng wrote: >>> [...] +1. Create a new source file. For example, ``tests/test-foo.c``. >>> [...] +1. Create a new source

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-29 Thread Eric Blake
On 01/28/2018 09:31 PM, Fam Zheng wrote: > To make our efforts on QEMU testing easier to consume by contributors, > let's add a document. For example, Patchew reports build errors on > patches that should be relativly easy to reproduce with a few steps, and s/relativly/relatively/ > it is much ni

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-29 Thread Eric Blake
On 01/29/2018 05:04 AM, Stefan Hajnoczi wrote: > On Mon, Jan 29, 2018 at 11:31:33AM +0800, Fam Zheng wrote: > > Thanks for writing this! > > I have only reviewed some parts in detail. > >> + >> +On top of libqtest, a higher level library, ``libqos``, was created to >> +encapsulate common tasks

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-29 Thread Eric Blake
On 01/29/2018 01:42 AM, Fam Zheng wrote: > On Mon, Jan 29, 2018 at 2:56 PM, Thomas Huth wrote: >> On 29.01.2018 04:31, Fam Zheng wrote: >> [...] >>> +1. Create a new source file. For example, ``tests/test-foo.c``. >> [...] >>> +1. Create a new source file for the test. (More than one file can be a

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-29 Thread Stefan Hajnoczi
On Mon, Jan 29, 2018 at 11:31:33AM +0800, Fam Zheng wrote: Thanks for writing this! I have only reviewed some parts in detail. > +"Make check" testings > += > + > +The "make check" testing family includes most of the C based tests in QEMU. > For > +a quick help, run ``make c

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-29 Thread Alex Bennée
Fam Zheng writes: > To make our efforts on QEMU testing easier to consume by contributors, > let's add a document. For example, Patchew reports build errors on > patches that should be relativly easy to reproduce with a few steps, and > it is much nicer if there is such a documentation that it c

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-28 Thread Fam Zheng
On Mon, Jan 29, 2018 at 2:56 PM, Thomas Huth wrote: > On 29.01.2018 04:31, Fam Zheng wrote: > [...] >> +1. Create a new source file. For example, ``tests/test-foo.c``. > [...] >> +1. Create a new source file for the test. (More than one file can be added >> as >> + necessary.) For example, ``te

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-28 Thread Thomas Huth
On 29.01.2018 04:31, Fam Zheng wrote: [...] > +1. Create a new source file. For example, ``tests/test-foo.c``. [...] > +1. Create a new source file for the test. (More than one file can be added as > + necessary.) For example, ``tests/test-foo-device.c``. 2. Write the test > + code with the gl

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-28 Thread Fam Zheng
On Mon, Jan 29, 2018 at 11:31 AM, Fam Zheng wrote: > +VM testing > +== I should have noted that this section is not new but an md->rst convert of ./tests/vm/README. The latter should be made a pointer to this one once it is merged. Fam

[Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-28 Thread Fam Zheng
To make our efforts on QEMU testing easier to consume by contributors, let's add a document. For example, Patchew reports build errors on patches that should be relativly easy to reproduce with a few steps, and it is much nicer if there is such a documentation that it can refer to. This focues on