On 29.01.2018 15:36, Eric Blake wrote: > On 01/29/2018 01:42 AM, Fam Zheng wrote: >> On Mon, Jan 29, 2018 at 2:56 PM, Thomas Huth <th...@redhat.com> wrote: >>> On 29.01.2018 04:31, Fam Zheng wrote: >>> [...] >>>> +1. Create a new source file. For example, ``tests/test-foo.c``. >>> [...] >>>> +1. Create a new source file for the test. (More than one file can be >>>> added as >>>> + necessary.) For example, ``tests/test-foo-device.c``. 2. Write the >>>> test >>>> + code with the glib and libqtest/libqos API. See also existing tests >>>> and the >>>> + library headers for reference. >>> >>> Can you please name the examples tests/foo-test.c and >>> tests/foo-device-test.c instead? Then the binaries will be covered by >>> the wildcard in tests/.gitignore automatically. Otherwise the list in >>> that gitignore file will grow and grow... Maybe it's also worth to >>> mention the naming scheme in this doc file? >> >> Yeah, I can do it. It's just I fail to find a definitive guideline on >> test-* vs *-test for the names, and the numbers are neck-and-neck: >> >> fam@lemon:~/work/qemu [master]$ ls tests/*test.c | wc -l >> 67 >> fam@lemon:~/work/qemu [master]$ ls tests/test-*.c | wc -l >> 68 > > I'm all for a mass rename to the suffix style (as it is easier to write > a gitignore suffix), if no one can provide a good reason for the naming > difference.
Good idea. And while we're at it, I think we should also sort the tests into subfolders, e.g. tests/qtest/ and tests/unit/ etc. Thomas
signature.asc
Description: OpenPGP digital signature
