Re: [PULL 16/45] vl: Add option to avoid stopping VM upon guest panic

2021-01-20 Thread Paolo Bonzini
On 20/01/21 14:54, Daniel P. Berrangé wrote: Why would pause be immediately followed by poweroff ? These are independant actions, and the mgmt app should be deciding what todo next after the pause action. It may wish to capture a guest crash image before poweroff. That's exactly why -action was

Re: [PULL 16/45] vl: Add option to avoid stopping VM upon guest panic

2021-01-20 Thread Paolo Bonzini
On 19/01/21 22:34, Peter Maydell wrote: We used to default to 'pause' and now we default to 'poweroff'. We noticed this because it broke an in-flight test case for the pvpanic-pci device from Mihai (which was expecting to see the device in 'pause' state and found it was now in 'poweroff'). Test

Re: [PULL 16/45] vl: Add option to avoid stopping VM upon guest panic

2021-01-20 Thread Daniel P . Berrangé
On Wed, Jan 20, 2021 at 12:28:14AM -0500, Alejandro Jimenez wrote: > > > On 1/19/2021 4:34 PM, Peter Maydell wrote: > > On Tue, 15 Dec 2020 at 18:11, Paolo Bonzini wrote: > > > From: Alejandro Jimenez > > > > > > The current default action of pausing a guest after a panic event > > > is receiv

Re: [PULL 16/45] vl: Add option to avoid stopping VM upon guest panic

2021-01-20 Thread Peter Maydell
On Wed, 20 Jan 2021 at 05:28, Alejandro Jimenez wrote: > On 1/19/2021 4:34 PM, Peter Maydell wrote: > > Test cases aren't very exciting, but was it really intentional > > to change the default behaviour? > My intention was to preserve the default behavior. Perhaps Paolo wanted > to reduce the numb

Re: [PULL 16/45] vl: Add option to avoid stopping VM upon guest panic

2021-01-19 Thread Alejandro Jimenez
On 1/19/2021 4:34 PM, Peter Maydell wrote: On Tue, 15 Dec 2020 at 18:11, Paolo Bonzini wrote: From: Alejandro Jimenez The current default action of pausing a guest after a panic event is received leaves the responsibility to resume guest execution to the management layer. The reasons for t

Re: [PULL 16/45] vl: Add option to avoid stopping VM upon guest panic

2021-01-19 Thread Peter Maydell
On Tue, 15 Dec 2020 at 18:11, Paolo Bonzini wrote: > > From: Alejandro Jimenez > > The current default action of pausing a guest after a panic event > is received leaves the responsibility to resume guest execution to the > management layer. The reasons for this behavior are discussed here: > htt

[PULL 16/45] vl: Add option to avoid stopping VM upon guest panic

2020-12-15 Thread Paolo Bonzini
From: Alejandro Jimenez The current default action of pausing a guest after a panic event is received leaves the responsibility to resume guest execution to the management layer. The reasons for this behavior are discussed here: https://lore.kernel.org/qemu-devel/52148f88.5000...@redhat.com/ How