Re: [PATCH v8 44/45] target/arm: Add allocation tag storage for system mode

2020-06-25 Thread Richard Henderson
On 6/25/20 10:09 AM, Peter Maydell wrote: >>> Comment says we're checking a memory attribute, but the code >>> is checking for TLB_MMIO, which isn't the same thing. >> >> Comment is not trying to allude to Normal vs Device, but "ram" vs "mmio" in >> the >> qemu sense. > > Oh, I see: maybe "if not

Re: [PATCH v8 44/45] target/arm: Add allocation tag storage for system mode

2020-06-25 Thread Peter Maydell
On Thu, 25 Jun 2020 at 18:02, Richard Henderson wrote: > > On 6/25/20 6:03 AM, Peter Maydell wrote: > > On Tue, 23 Jun 2020 at 20:38, Richard Henderson > > wrote: > >> > >> Look up the physical address for the given virtual address, > >> convert that to a tag physical address, and finally return

Re: [PATCH v8 44/45] target/arm: Add allocation tag storage for system mode

2020-06-25 Thread Richard Henderson
On 6/25/20 6:03 AM, Peter Maydell wrote: > On Tue, 23 Jun 2020 at 20:38, Richard Henderson > wrote: >> >> Look up the physical address for the given virtual address, >> convert that to a tag physical address, and finally return >> the host address that backs it. >> >> Signed-off-by: Richard Hender

Re: [PATCH v8 44/45] target/arm: Add allocation tag storage for system mode

2020-06-25 Thread Peter Maydell
On Tue, 23 Jun 2020 at 20:38, Richard Henderson wrote: > > Look up the physical address for the given virtual address, > convert that to a tag physical address, and finally return > the host address that backs it. > > Signed-off-by: Richard Henderson > --- > target/arm/mte_helper.c | 126 +++

[PATCH v8 44/45] target/arm: Add allocation tag storage for system mode

2020-06-23 Thread Richard Henderson
Look up the physical address for the given virtual address, convert that to a tag physical address, and finally return the host address that backs it. Signed-off-by: Richard Henderson --- target/arm/mte_helper.c | 126 1 file changed, 126 insertions(+) d