Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass

2021-02-01 Thread Claudio Fontana
On 2/1/21 10:15 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 1/30/21 12:53 AM, Claudio Fontana wrote: >>> To summarize: >>> >>> 1) accel->cpu_realizefn extends the current cpu target-specific realize >>> functions with accelerator-specific code, >>>which currently does not m

Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass

2021-02-01 Thread Alex Bennée
Richard Henderson writes: > On 1/30/21 12:53 AM, Claudio Fontana wrote: >> To summarize: >> >> 1) accel->cpu_realizefn extends the current cpu target-specific realize >> functions with accelerator-specific code, >>which currently does not make use of errp at all (thus, the temptation to

Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass

2021-01-30 Thread Richard Henderson
On 1/30/21 12:53 AM, Claudio Fontana wrote: > To summarize: > > 1) accel->cpu_realizefn extends the current cpu target-specific realize > functions with accelerator-specific code, >which currently does not make use of errp at all (thus, the temptation to > remove errp from the interface unti

Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass

2021-01-30 Thread Claudio Fontana
On 1/29/21 1:13 AM, Richard Henderson wrote: > On 1/28/21 6:29 AM, Philippe Mathieu-Daudé wrote: >> On 1/28/21 5:08 PM, Alex Bennée wrote: >>> >>> Claudio Fontana writes: >>> On 1/28/21 2:03 PM, Philippe Mathieu-Daudé wrote: > On 1/28/21 10:28 AM, Claudio Fontana wrote: >>> >> +

Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass

2021-01-28 Thread Richard Henderson
On 1/28/21 6:29 AM, Philippe Mathieu-Daudé wrote: > On 1/28/21 5:08 PM, Alex Bennée wrote: >> >> Claudio Fontana writes: >> >>> On 1/28/21 2:03 PM, Philippe Mathieu-Daudé wrote: On 1/28/21 10:28 AM, Claudio Fontana wrote: >> > + > +#define TYPE_ACCEL_CPU "accel-" CPU_RESOLVING_TYPE >

Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass

2021-01-28 Thread Philippe Mathieu-Daudé
On 1/28/21 5:08 PM, Alex Bennée wrote: > > Claudio Fontana writes: > >> On 1/28/21 2:03 PM, Philippe Mathieu-Daudé wrote: >>> On 1/28/21 10:28 AM, Claudio Fontana wrote: > + +#define TYPE_ACCEL_CPU "accel-" CPU_RESOLVING_TYPE +#define ACCEL_CPU_NAME(name) (name "-" TYPE_ACCEL_CPU

Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass

2021-01-28 Thread Alex Bennée
Claudio Fontana writes: > On 1/28/21 2:03 PM, Philippe Mathieu-Daudé wrote: >> On 1/28/21 10:28 AM, Claudio Fontana wrote: >>> + >>> +#define TYPE_ACCEL_CPU "accel-" CPU_RESOLVING_TYPE >>> +#define ACCEL_CPU_NAME(name) (name "-" TYPE_ACCEL_CPU) >>> +typedef struct AccelCPUClass AccelCPUClass;

Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass

2021-01-28 Thread Claudio Fontana
On 1/28/21 2:03 PM, Philippe Mathieu-Daudé wrote: > On 1/28/21 10:28 AM, Claudio Fontana wrote: >> add a new optional interface to CPUClass, >> which allows accelerators to extend the CPUClass >> with additional accelerator-specific initializations. >> >> Add the field before tcg_ops, and mark tcg_

Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass

2021-01-28 Thread Philippe Mathieu-Daudé
On 1/28/21 10:28 AM, Claudio Fontana wrote: > add a new optional interface to CPUClass, > which allows accelerators to extend the CPUClass > with additional accelerator-specific initializations. > > Add the field before tcg_ops, and mark tcg_ops as > needing to be last in the struct until we rewor

[PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass

2021-01-28 Thread Claudio Fontana
add a new optional interface to CPUClass, which allows accelerators to extend the CPUClass with additional accelerator-specific initializations. Add the field before tcg_ops, and mark tcg_ops as needing to be last in the struct until we rework this further in a later patch. Signed-off-by: Claudio