Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table

On 9/26/20 7:31 AM, Helio Loureiro wrote: On Fri, Sep 25, 2020, 16:16 John Snow > wrote: On 9/25/20 2:03 AM, Helio Loureiro wrote: > Hi, > > I would replace the word variable "kind" by "category". > Hi, welcome to the list! Tkz! Fo

Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table

On Fri, Sep 25, 2020, 16:16 John Snow wrote: > On 9/25/20 2:03 AM, Helio Loureiro wrote: > > Hi, > > > > I would replace the word variable "kind" by "category". > > > > Hi, welcome to the list! > Tkz! > For patch reviews, we try to reply in-line, below the original post. > I realized that lat

Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table

On 9/25/20 12:38 PM, Cleber Rosa wrote: On Thu, Sep 24, 2020 at 09:32:05PM -0400, John Snow wrote: On 9/24/20 9:18 PM, Cleber Rosa wrote: I have to say the style of this line bothers me, but it's just that, style. So, What don't you like? It's the sum of the "private" + "global dictionary"

Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table

On Thu, Sep 24, 2020 at 09:32:05PM -0400, John Snow wrote: > On 9/24/20 9:18 PM, Cleber Rosa wrote: > > I have to say the style of this line bothers me, but it's just that, > > style. So, > > What don't you like? It's the sum of the "private" + "global dictionary" + "its item being called directl

Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table

On 9/25/20 2:03 AM, Helio Loureiro wrote: Hi, I would replace the word variable "kind" by "category". Hi, welcome to the list! For patch reviews, we try to reply in-line, below the original post. I'm not attached to 'kind', but 'category' is perhaps too broad. Category in this particular d

Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table

Hi, I would replace the word variable "kind" by "category". ./helio On Fri, Sep 25, 2020, 03:32 John Snow wrote: > On 9/24/20 9:18 PM, Cleber Rosa wrote: > > I have to say the style of this line bothers me, but it's just that, > > style. So, > > What don't you like? > > >

Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table

On 9/24/20 9:18 PM, Cleber Rosa wrote: I have to say the style of this line bothers me, but it's just that, style. So, What don't you like?

Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table

On Tue, Sep 22, 2020 at 05:13:13PM -0400, John Snow wrote: > This enforces a type signature against all of the top-level expression > check routines without necessarily needing to create some > overcomplicated class hierarchy for them. > > Signed-off-by: John Snow > --- > scripts/qapi/expr.py |

Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table

On 9/23/20 4:36 PM, Eduardo Habkost wrote: I see lots of meta.value expressions below. Maybe setting meta = kind.value will make the code more readable? I can do that. I don't think this should block an obvious improvement to the code, so: Reviewed-by: Eduardo Habkost Thanks! --js

Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table

On Tue, Sep 22, 2020 at 05:13:13PM -0400, John Snow wrote: > This enforces a type signature against all of the top-level expression > check routines without necessarily needing to create some > overcomplicated class hierarchy for them. > > Signed-off-by: John Snow > --- > scripts/qapi/expr.py |

[PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table

This enforces a type signature against all of the top-level expression check routines without necessarily needing to create some overcomplicated class hierarchy for them. Signed-off-by: John Snow --- scripts/qapi/expr.py | 69 ++-- 1 file changed, 35 inser