Re: [PATCH] hw/display/tcx: Drop unnecessary code for handling BGR format outputs

2021-02-16 Thread Mark Cave-Ayland
On 16/02/2021 10:11, Peter Maydell wrote: Would you like this to go via a qemu-sparc PR or is it easier to go as part of a group alongside your other display surface patches via target-arm.next? I'm happy either way -- if you don't happen to have anything else queued up for sparc I can just pu

Re: [PATCH] hw/display/tcx: Drop unnecessary code for handling BGR format outputs

2021-02-16 Thread Peter Maydell
On Mon, 15 Feb 2021 at 22:41, Mark Cave-Ayland wrote: > > On 15/02/2021 10:21, Peter Maydell wrote: > > > For a long time now the UI layer has guaranteed that the console > > surface is always 32 bits per pixel, RGB. The TCX code already > > assumes 32bpp, but it still has some checks of is_surfac

Re: [PATCH] hw/display/tcx: Drop unnecessary code for handling BGR format outputs

2021-02-15 Thread Richard Henderson
On 2/15/21 2:21 AM, Peter Maydell wrote: > For a long time now the UI layer has guaranteed that the console > surface is always 32 bits per pixel, RGB. The TCX code already > assumes 32bpp, but it still has some checks of is_surface_bgr() > in an attempt to support 32bpp BGR. is_surface_bgr() will

Re: [PATCH] hw/display/tcx: Drop unnecessary code for handling BGR format outputs

2021-02-15 Thread Mark Cave-Ayland
On 15/02/2021 10:21, Peter Maydell wrote: For a long time now the UI layer has guaranteed that the console surface is always 32 bits per pixel, RGB. The TCX code already assumes 32bpp, but it still has some checks of is_surface_bgr() in an attempt to support 32bpp BGR. is_surface_bgr() will alwa

[PATCH] hw/display/tcx: Drop unnecessary code for handling BGR format outputs

2021-02-15 Thread Peter Maydell
For a long time now the UI layer has guaranteed that the console surface is always 32 bits per pixel, RGB. The TCX code already assumes 32bpp, but it still has some checks of is_surface_bgr() in an attempt to support 32bpp BGR. is_surface_bgr() will always return false for the qemu_console_surface(