On 2/15/21 2:21 AM, Peter Maydell wrote: > For a long time now the UI layer has guaranteed that the console > surface is always 32 bits per pixel, RGB. The TCX code already > assumes 32bpp, but it still has some checks of is_surface_bgr() > in an attempt to support 32bpp BGR. is_surface_bgr() will always > return false for the qemu_console_surface(), unless the display > device itself has deliberately created an alternate-format > surface via a function like qemu_create_displaysurface_from(). > > Drop the never-used BGR-handling code, and assert that we have > a 32-bit surface rather than just doing nothing if it isn't. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > Tested by booting Linux on an SS-5. > --- > hw/display/tcx.c | 31 ++++++++----------------------- > 1 file changed, 8 insertions(+), 23 deletions(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~
