On Mon, 15 Feb 2021 at 22:41, Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> wrote: > > On 15/02/2021 10:21, Peter Maydell wrote: > > > For a long time now the UI layer has guaranteed that the console > > surface is always 32 bits per pixel, RGB. The TCX code already > > assumes 32bpp, but it still has some checks of is_surface_bgr() > > in an attempt to support 32bpp BGR. is_surface_bgr() will always > > return false for the qemu_console_surface(), unless the display > > device itself has deliberately created an alternate-format > > surface via a function like qemu_create_displaysurface_from(). > > > > Drop the never-used BGR-handling code, and assert that we have > > a 32-bit surface rather than just doing nothing if it isn't. > > > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
> Thanks Peter - looks good to me. > > Reviewed-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> > > Would you like this to go via a qemu-sparc PR or is it easier to go as part > of a > group alongside your other display surface patches via target-arm.next? I'm happy either way -- if you don't happen to have anything else queued up for sparc I can just put it in with the arm queue. thanks -- PMM
