Re: [PATCH for v10.1] i386/cpu: Move addressable ID encoding out of compat property in CPUID[0x1]

2025-08-03 Thread Michael Tokarev
s the similar issues as well. Then the compat property is not needed any more since all stable QEMUs will follow the same encoding way. So, in CPUID[0x1], move addressable ID encoding out of compat property. Reported-by: Michael Tokarev Inspired-by: Chuang Xu Fixes: commit f985a1195ba2 ("i386/c

Re: [PATCH v7 09/36] hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method

2025-08-03 Thread Michael Tokarev
On 03.08.2025 19:49, Eric Auger wrote: ... I have not proposed anything ;-) - sorry I am on vacation - I was trying to enumerate the various config settings and to me dependencies should be resolved so I fail to understand. Unfortunately I cannot test because the problem happens with a custom mic

[PATCH v2 1/2] virtio-net: make VirtIONet.vlans an array instead of a pointer

2025-08-03 Thread Michael Tokarev
This field is a fixed-size buffer (number of elements is MAX_VLAN, known at build time). There's no need to allocate it dynamically, it can be made an integral part of VirtIONet structure. This field is the only user of VMSTATE_BUFFER_POINTER_UNSAFE() macro. Signed-off-by: Michael To

Re: [PATCH 1/2] virtio-net: make VirtIONet.vlans an array instead of a pointer

2025-08-02 Thread Michael Tokarev
On 02.08.2025 17:21, Michael Tokarev wrote: This field is a fixed-size buffer (number of elements is MAX_VLAN, known at build time). There's no need to allocate it dynamically, it can be made an integral part of VirtIONet structure. This field is the only user of VMSTATE_BUFFER_POINTER_U

[PATCH 1/2] virtio-net: make VirtIONet.vlans an array instead of a pointer

2025-08-02 Thread Michael Tokarev
This field is a fixed-size buffer (number of elements is MAX_VLAN, known at build time). There's no need to allocate it dynamically, it can be made an integral part of VirtIONet structure. This field is the only user of VMSTATE_BUFFER_POINTER_UNSAFE() macro. Signed-off-by: Michael To

[PATCH 2/2] migration/vmstate: remove VMSTATE_BUFFER_POINTER_UNSAFE macro

2025-08-02 Thread Michael Tokarev
The only user of this macro was VirtIONet.vlans, which has been converted to regular VMSTATE_BUFFER. Signed-off-by: Michael Tokarev --- include/migration/vmstate.h | 9 - 1 file changed, 9 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index

Re: [PATCH v3] virtio-net: Fix VLAN filter table reset timing

2025-08-02 Thread Michael Tokarev
On 27.07.2025 09:22, Akihiko Odaki wrote: ... @@ -3942,6 +3943,7 @@ static void virtio_net_device_realize(DeviceState *dev, Error **errp) n->mac_table.macs = g_malloc0(MAC_TABLE_ENTRIES * ETH_ALEN); n->vlans = g_malloc0(MAX_VLAN >> 3); +memset(n->vlans, 0xff, MAX_VLAN >> 3);

Re: [PATCH] scripts/make-release: Go back to cloning all the EDK2 submodules

2025-08-02 Thread Michael Tokarev
ch will break without our noticing it. This increases the size of the QEMU tarball .tar.xz file from 133M to 139M in my testing. Cc: qemu-sta...@nongnu.org Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3041 Signed-off-by: Peter Maydell Reviewed-by: Michael Tokarev Let's fix

Re: [PATCH 0/2] Do not abort on log-start/stop errors

2025-08-01 Thread Michael Tokarev
On 24.07.2025 15:59, Hanna Czenczek wrote: Hi, vhost_log_global_start() and vhost_log_global_stop() abort the whole qemu process on error. Not least because vhost devices are generally outside of qemu (i.e. use a foreign code base), that is not great, as we can basically be forced to abort beca

Re: [PATCH v3 0/6] hw/i386/amd_iommu: Cleanups and fixes

2025-08-01 Thread Michael Tokarev
On 01.08.2025 09:05, Sairaj Kodilkar wrote: This series provides few cleanups and fixes for the amd iommu Changes since v2: - Used VMSTATE_UNUSED() to maintain migration compatibility when ats_enabled flag is removed [Phil]. - Simplified the amdvi_writew [Phil]. v2: https://lore.kernel.org/q

Re: [PATCH v2] intel_iommu: Allow both Status Write and Interrupt Flag in QI wait

2025-08-01 Thread Michael Tokarev
On 14.07.2025 11:00, David Woodhouse wrote: From: David Woodhouse FreeBSD does both, and this appears to be perfectly valid. The VT-d spec even talks about the ordering (the status write should be done first, unsurprisingly). We certainly shouldn't assert() and abort QEMU if the guest asks for

Re: [PATCH] virtio: fix off-by-one and invalid access in virtqueue_ordered_fill

2025-08-01 Thread Michael S. Tsirkin
On Fri, Aug 01, 2025 at 06:46:09PM +0300, Michael Tokarev wrote: > On 21.07.2025 18:02, Jonah Palmer wrote: > > Commit b44135daa372 introduced virtqueue_ordered_fill for > > VIRTIO_F_IN_ORDER support but had a few issues: > > > > * Conditional while loop used 's

Re: [PATCH] virtio: fix off-by-one and invalid access in virtqueue_ordered_fill

2025-08-01 Thread Michael Tokarev
On 21.07.2025 18:02, Jonah Palmer wrote: Commit b44135daa372 introduced virtqueue_ordered_fill for VIRTIO_F_IN_ORDER support but had a few issues: * Conditional while loop used 'steps <= max_steps' but should've been 'steps < max_steps' since reaching steps == max_steps would indicate that

[PULL 04/17] virtio-net: Fix VLAN filter table reset timing

2025-08-01 Thread Michael S. Tsirkin
e2ad ("virtio-net: do not reset vlan filtering at set_features") Cc: qemu-sta...@nongnu.org Reported-by: Konstantin Shkolnyy Signed-off-by: Akihiko Odaki Tested-by: Konstantin Shkolnyy Tested-by: Lei Yang Message-Id: <20250727-vlan-v3-1-bbee73861...@rsg.ci.i.u-tokyo.ac.jp> Tested-by:

[PULL 08/17] hw/i386/amd_iommu: Move IOAPIC memory region initialization to the end

2025-08-01 Thread Michael S. Tsirkin
to the end in order to use the mr_sys and mr_ir regions after they are fully initialized. Fixes: 577c470f4326 ("x86_iommu/amd: Prepare for interrupt remap support") Signed-off-by: Sairaj Kodilkar Reviewed-by: Vasant Hegde Message-Id: <20250801060507.3382-4-sarun...@amd.com> Review

[PULL 10/17] hw/i386/amd_iommu: Support MMIO writes to the status register

2025-08-01 Thread Michael S. Tsirkin
com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/amd_iommu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index c9c32cf7b0..6925085d29 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -862,6

[PULL 09/17] hw/i386/amd_iommu: Fix amdvi_write*()

2025-08-01 Thread Michael S. Tsirkin
: d29a09ca68428 ("hw/i386: Introduce AMD IOMMU") Suggested-by: Ethan MILON Signed-off-by: Sairaj Kodilkar Message-Id: <20250801060507.3382-5-sarun...@amd.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/amd_iommu.c | 21 ++--- 1

[PULL 11/17] hw/i386/amd_iommu: Fix event log generation

2025-08-01 Thread Michael S. Tsirkin
Message-Id: <20250801060507.3382-7-sarun...@amd.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/amd_iommu.h | 1 + hw/i386/amd_iommu.c | 44 +++- 2 files changed, 36 insertions(+), 9 deletions(-) diff --git a/hw/i386

[PULL 00/17] virtio,pci,pc: bugfixes

2025-08-01 Thread Michael S. Tsirkin
l over the place. Signed-off-by: Michael S. Tsirkin Akihiko Odaki (2): virtio-net: Fix VLAN filter table reset timing pcie_sriov: Fix configuration and state synchronization David Woodhouse (1): intel_iommu: Allow b

[PULL 01/17] virtio: fix off-by-one and invalid access in virtqueue_ordered_fill

2025-08-01 Thread Michael S. Tsirkin
") Reported-by: terrynini Signed-off-by: Jonah Palmer Message-Id: <20250721150208.2409779-1-jonah.pal...@oracle.com> Reviewed-by: Si-Wei Liu Acked-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio.c | 22 -- 1 file changed,

[PULL 16/17] MAINTAINERS: add net/vhost* files under `vhost`

2025-08-01 Thread Michael S. Tsirkin
From: Stefano Garzarella net/vhost* files should be interesting for vhost maintainers/reviewers. Suggested-by: Peter Maydell Signed-off-by: Stefano Garzarella Message-Id: <20250714102626.34431-1-sgarz...@redhat.com> Reviewed-by: Manos Pitsidianakis Reviewed-by: Michael S. Tsirkin Sign

[PULL 14/17] tests/acpi: virt: update HEST file with its current data

2025-08-01 Thread Michael S. Tsirkin
From: Mauro Carvalho Chehab Now that HEST table is checked for aarch64, add the current firmware file. Signed-off-by: Mauro Carvalho Chehab Acked-by: Igor Mammedov Reviewed-by: Jonathan Cameron Message-Id: --- tests/qtest/bios-tables-test-allowed-diff.h | 1 - tests/data/acpi/aarch64/vir

[PULL 03/17] vhost: Do not abort on log-stop error

2025-08-01 Thread Michael S. Tsirkin
Manos Pitsidianakis Reviewed-by: Stefano Garzarella Tested-by: Lei Yang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 05ad5de629..6557c58d12 100644

[PULL 15/17] intel_iommu: Allow both Status Write and Interrupt Flag in QI wait

2025-08-01 Thread Michael S. Tsirkin
ntel-iommu: add supports for queued invalidation interface") Closes: https://gitlab.com/qemu-project/qemu/-/issues/3028 Signed-off-by: David Woodhouse Message-Id: <0122cbabc0adcc3cf878f5fd7834d8f258c7a2f2.ca...@infradead.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[PULL 13/17] tests/qtest/bios-tables-test: extend to also check HEST table

2025-08-01 Thread Michael S. Tsirkin
From: Mauro Carvalho Chehab Currently, aarch64 can generate a HEST table when loaded with -machine ras=on. Add support for it. Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Igor Mammedov Reviewed-by: Jonathan Cameron Message-Id: <9ce77140500ef68cc939d63952c25579f711ea52.1749741085.git.mc

[PULL 02/17] vhost: Do not abort on log-start error

2025-08-01 Thread Michael S. Tsirkin
..@redhat.com> Reviewed-by: Manos Pitsidianakis Reviewed-by: Stefano Garzarella Tested-by: Lei Yang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c

[PULL 17/17] net/vdpa: fix potential fd leak in net_init_vhost_vdpa()

2025-08-01 Thread Michael S. Tsirkin
From: Stefano Garzarella Coverity reported a file descriptor leak (CID 1490785) that happens if `vhost_vdpa_get_max_queue_pairs()` returns 0, since in that case net_host_vdpa_init(), which should take ownership of the fd, is never called. vhost_vdpa_get_max_queue_pairs() returns 1 if VIRTIO_NET_

[PULL 12/17] tests/acpi: virt: add an empty HEST file

2025-08-01 Thread Michael S. Tsirkin
From: Mauro Carvalho Chehab Such file will be used to track HEST table changes. For now, disallow HEST table check until we update it to the current data. Signed-off-by: Mauro Carvalho Chehab Acked-by: Igor Mammedov Reviewed-by: Jonathan Cameron Message-Id: --- tests/qtest/bios-tables-tes

[PULL 07/17] hw/i386/amd_iommu: Remove unused and wrongly set ats_enabled field

2025-08-01 Thread Michael S. Tsirkin
sant Hegde Message-Id: <20250801060507.3382-3-sarun...@amd.com> Message-ID: <948a6ac3-ded9-475b-8c45-9d36220b4...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/amd_iommu.h | 1 - hw/i386/amd_iommu.c | 5 ++-

[PULL 05/17] pcie_sriov: Fix configuration and state synchronization

2025-08-01 Thread Michael S. Tsirkin
iovPF") Fixes: f9efcd47110d ("pcie_sriov: Register VFs after migration") Fixes: CVE-2025-54566 Fixes: CVE-2025-54567 Cc: qemu-sta...@nongnu.org Reported-by: Corentin BAYET Signed-off-by: Akihiko Odaki Message-Id: <20250727-wmask-v2-1-394910b1c...@rsg.ci.i.u-tokyo.ac.jp> Revie

[PULL 06/17] hw/i386/amd_iommu: Fix MMIO register write tracing

2025-08-01 Thread Michael S. Tsirkin
com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/amd_iommu.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index 5a24c17548..7fb0bb68f0 100644 --- a/hw/i386/amd_iommu.c ++

[PATCH trivial] tests/qemu-iotests/tests/mirror-sparse: skip if O_DIRECT is not supported

2025-08-01 Thread Michael Tokarev
urs at the very beginning when we're checking for sanity. Fixes: c0ddcb2cbc146e "tests: Add iotest mirror-sparse for recent patches" Signed-off-by: Michael Tokarev --- tests/qemu-iotests/tests/mirror-sparse | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/tes

Re: [PATCH v7 09/36] hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method

2025-08-01 Thread Michael S. Tsirkin
On Mon, Jul 28, 2025 at 04:56:37PM +0200, Eric Auger wrote: > Hi Michael, > > On 7/28/25 11:07 AM, Michael Tokarev wrote: > > On 27.07.2025 14:48, Michael Tokarev wrote: > >> On 14.07.2025 11:04, Eric Auger wrote: > >>> gpex build_

Re: [PATCH] hw/i386/pc: Avoid overlap between CXL window and PCI 64bit BARs in QEMU

2025-08-01 Thread Michael S. Tsirkin
On Fri, Jul 18, 2025 at 09:35:45PM +0800, peng guo wrote: > When using a CXL Type 3 device together with a virtio 9p device in QEMU, the > 9p device fails to initialize properly. The kernel reports the following: > > virtio: device uses modern interface but does not have VIRTIO_F_VERSION_1 >

[PATCH trivial] qga: correctly write to /sys/power/state on linux

2025-08-01 Thread Michael Tokarev
ction. Fixes: 2048129625 "qga/commands-posix: don't do fork()/exec() when suspending via sysfs" Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3057 Signed-off-by: Michael Tokarev --- qga/commands-linux.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff

Re: [PATCH v3 10/11] tests: Add iotest mirror-sparse for recent patches

2025-08-01 Thread Michael Tokarev
On 25.04.2025 03:52, Eric Blake wrote: Prove that blockdev-mirror can now result in sparse raw destination files, regardless of whether the source is raw or qcow2. By making this a separate test, it was possible to test effects of individual patches for the various pieces that all have to work t

Re: [PULL 00/11] riscv-to-apply queue

2025-07-30 Thread Michael Tokarev
On 31.07.2025 07:36, Alistair Francis wrote: .. Urgh, sorry I forgot to CC qemu-stable. This is okay :) .. Are all good candidates for back porting as well And thank you for the good work! I've picked these up for 10.0 (for 7.2 it's more difficult, and riscv support there is significantly

[ANNOUNCE] QEMU 10.1.0-rc1 is now available

2025-07-30 Thread Michael Roth
arkus Armbruster) d4d91ed42e: qapi: Add more cross-references (Markus Armbruster) 67e4808403: hw/display/sm501: fix missing error-report.h (Clément Chigot) 653a75a9d7: roms/Makefile: fix npcmNxx_bootrom build rules (Michael Tokarev) 2865bf1c57: system/physmem: fix use-after-free with dispatch (Pierrick Bo

Re: [PULL 00/11] riscv-to-apply queue

2025-07-30 Thread Michael Tokarev
On 30.07.2025 04:01, alistai...@gmail.com wrote: From: Alistair Francis The following changes since commit 9b80226ece693197af8a981b424391b68b5bc38e: Update version for the v10.1.0-rc1 release (2025-07-29 13:00:41 -0400) are available in the Git repository at: https://github.com/alistai

Re: [PATCH v3 3/3] pc-bios: Update vbootrom image to commit 183c9ff8056b

2025-07-30 Thread Michael Tokarev
viewed-by: Michael Tokarev Thank you! It'd be very nice to get an ACK from Hao Wu too. /mjt

Re: [PATCH v2 3/3] pc-bios: Update vbootrom image to commit 183c9ff8056b

2025-07-29 Thread Michael Tokarev
On 29.07.2025 20:42, Cédric Le Goater wrote: Full changelog since last update (d6e3386709b3) : Jamin Lin (3): ast27x0: Initialize and enable SSP/TSP using SCU with reserved-memory from DTB ast27x0: Fix missing SCU module reset for SSP and TSP initialization ast27x0: Fix Mak

Re: [PATCH 0/3] aspeed: Update vbootrom image

2025-07-29 Thread Michael Tokarev
On 29.07.2025 20:07, Cédric Le Goater wrote: Hello ! Michael provided changes to fix the build of the vbootrom image of the AST2700 SoC machine in [1]. However, a workaound in roms/Makefile was still necessary to build ast27x0_bootrom.bin correctly. This was later fixed in [2]. This series is

Re: [PATCH stable-7.2 0/9] linux-user/aarch64: Backport TPIDR2_EL0 fixes

2025-07-28 Thread Michael Tokarev
On 28.07.2025 21:16, Richard Henderson wrote: Hi Michael, Here's the aarch64-linux-user TPIDR2_EL0 fixes backported to the stable-7.2 branch. Including all of the aarch64_set_svcr cleanups is probably overkill, but I think it was clearer that way. This is a good set. What was missing

Re: [PATCH 4/9] target/arm/sme: Reset SVE state in aarch64_set_svcr()

2025-07-28 Thread Michael Tokarev
On 28.07.2025 21:16, Richard Henderson wrote: Move arm_reset_sve_state() calls to aarch64_set_svcr(). (cherry picked from commit 7f2a01e7368f960fadea38f437d0f6de7f249686) +/* ResetSVEState */ +static void arm_reset_sve_state(CPUARMState *env) +{ +memset(env->vfp.zregs, 0, sizeof(env->vfp.z

Re: [PATCH] hw/display/qxl-render.c: fix qxl_unpack_chunks() chunk size calculation

2025-07-28 Thread Michael Tokarev
On 28.07.2025 14:06, Philippe Mathieu-Daudé wrote: On 21/2/25 14:48, Michael Tokarev wrote: In case of multiple chunks, code in qxl_unpack_chunks() takes size of the wrong (next in the chain) chunk, instead of using current chunk size. This leads to wrong number of bytes being copied, and to

Re: [PATCH v2 for-10.1 1/3] linux-user/aarch64: Clear TPIDR2_EL0 when delivering signals

2025-07-28 Thread Michael Tokarev
On 25.07.2025 20:55, Peter Maydell wrote: A recent change to the kernel (Linux commit b376108e1f88 "arm64/fpsimd: signal: Clear TPIDR2 when delivering signals") updated the signal-handler entry code to always clear TPIDR2_EL0. This is necessary for the userspace ZA lazy saving scheme to work cor

Re: [PATCH v7 09/36] hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method

2025-07-28 Thread Michael Tokarev
On 28.07.2025 18:17, Michael Tokarev wrote: I think it should be "select" not "imply", which seems to be stricter. With a devices file like I'm using - it looks like - only things which are selected gets enabled.  But this commit brings hard dependency between the bridg

[PATCH for 10.1] hw/pci-host/gpex-acpi: PCI_EXPRESS_GENERIC_BRIDGE: select ACPI_PCI instead of imply'ing it

2025-07-28 Thread Michael Tokarev
it. Fixes: af151d50eac24 "hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method" Signed-off-by: Michael Tokarev --- hw/pci-host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig index 9824fa188d..19b6605c7f 10

Re: [PATCH v7 09/36] hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method

2025-07-28 Thread Michael Tokarev
On 28.07.2025 17:56, Eric Auger wrote: Hi Michael, Hi! This commit added an imply ACPI_PCI to the PCI_EXPRESS_GENERIC_BRIDGE config in hw/pci-host/Kconfig: config PCI_EXPRESS_GENERIC_BRIDGE     bool     select PCI_EXPRESS  -> selects PCI     imply ACPI_PCI In hw/acpi/Kconfig we h

Re: [PATCH-for-10.1? v2] pcie_sriov: Fix configuration and state synchronization

2025-07-28 Thread Michael S. Tsirkin
On Mon, Jul 28, 2025 at 12:09:34PM +0200, Philippe Mathieu-Daudé wrote: > Hi Akihiko, Michael, > > On 27/7/25 08:50, Akihiko Odaki wrote: > > Fix issues in PCIe SR-IOV configuration register handling that caused > > inconsistent internal state due to improper write mask handl

Re: [PATCH v7 09/36] hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method

2025-07-28 Thread Michael Tokarev
On 27.07.2025 14:48, Michael Tokarev wrote: On 14.07.2025 11:04, Eric Auger wrote: gpex build_host_bridge_osc() and x86 originated build_pci_host_bridge_osc_method() are mostly identical. In GPEX, SUPP is set to CDW2 but is not further used. CTRL is same as Local0. So let gpex code reuse

Re: [PATCH trivial for 10.1] roms/Makefile: fix npcmNxx_bootrom build rules

2025-07-28 Thread Michael Tokarev
On 28.07.2025 00:55, Michael Tokarev wrote: Since commit 70ce076fa6dff60, the actual rom source dirs are subdirs of vbootrom/ submodule, not in top-level of it. Fixes: 70ce076fa6dff60 "roms: Update vbootrom to 1287b6e" Signed-off-by: Michael Tokarev Cc: qemu-stable@ (for 10.0.x) /mjt

Re: [PATCH v1 19/21] pc-bios: Update AST27x0 vBootrom with SSP/TSP SCU initialization support

2025-07-28 Thread Michael Tokarev
On 28.07.2025 09:49, Cédric Le Goater wrote: Please add build instructions to roms/Makefile.  I dunno how this one is related to roms/vbootrom which is already used for npcmxxx_bootrom.bin files - maybe all the 3 bootroms should be kept in sync. I think they are relatively independent. Each ha

Re: [PATCH v1 19/21] pc-bios: Update AST27x0 vBootrom with SSP/TSP SCU initialization support

2025-07-28 Thread Michael Tokarev
On 28.07.2025 10:02, Jamin Lin wrote: It seems this patch fix this issue, https://patchwork.kernel.org/project/qemu-devel/patch/607a943a587248fbe0ff0897de80aee98a093caa.1753654515.git@tls.msk.ru/ Yeah, I posted that patch yesterday after realizing our roms/vbootrom submodule is outdated.

[PATCH for 10.1 2/2] roms/Makefile: build ast27x0_bootrom

2025-07-27 Thread Michael Tokarev
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3052 Signed-off-by: Michael Tokarev --- roms/Makefile | 5 + 1 file changed, 5 insertions(+) diff --git a/roms/Makefile b/roms/Makefile index 6af68a922f..2691b935c4 100644 --- a/roms/Makefile +++ b/roms/Makefile @@ -68,6 +68,7

[PATCH for 10.1 1/2] roms/vbootrom: update to 601d410

2025-07-27 Thread Michael Tokarev
NPCM8XX UBOOT destination and size. 4f54dfc Automatically search for UBOOT location for NPCM8xx images. The actual bootroms are not updated yet. Signed-off-by: Michael Tokarev --- Mjt: this is just the submodule update, not the actual ROM file(s) update. There are at least 2 commits in there wich

[PATCH trivial for 10.1] roms/Makefile: fix npcmNxx_bootrom build rules

2025-07-27 Thread Michael Tokarev
Since commit 70ce076fa6dff60, the actual rom source dirs are subdirs of vbootrom/ submodule, not in top-level of it. Fixes: 70ce076fa6dff60 "roms: Update vbootrom to 1287b6e" Signed-off-by: Michael Tokarev --- roms/Makefile | 8 1 file changed, 4 insertions(+), 4 deletion

Re: [PATCH v1 19/21] pc-bios: Update AST27x0 vBootrom with SSP/TSP SCU initialization support

2025-07-27 Thread Michael Tokarev
On 17.07.2025 06:40, Jamin Lin via wrote: The updated boot ROM includes logic to initialize and enable SSP/TSP using SCU registers, based on reserved-memory regions defined in the device tree. Its source code is available at: https://github.com/google/vbootrom/commit/f9eb0bb57decbab860a81712c561

Re: [PATCH v7 09/36] hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method

2025-07-27 Thread Michael Tokarev
On 14.07.2025 11:04, Eric Auger wrote: gpex build_host_bridge_osc() and x86 originated build_pci_host_bridge_osc_method() are mostly identical. In GPEX, SUPP is set to CDW2 but is not further used. CTRL is same as Local0. So let gpex code reuse build_pci_host_bridge_osc_method() and remove buil

Re: [PATCH 0/4] migration: workaround GNUTLS live migration crashes

2025-07-25 Thread Michael Tokarev
On 18.07.2025 18:05, Daniel P. Berrangé wrote: TL:DR: GNUTLS is liable to crash QEMU when live migration is run with TLS enabled and a return path channel is present, if approx 64 GB of data is transferred. This is easily triggered in a 16 GB VM with 4 CPUs, by running 'stress-ng --vm 4 --vm-byte

[PULL for-10.1 0/1] Trivial patches for 2025-07-25

2025-07-25 Thread Michael Tokarev
g bug in qxl. The change, while isn't exactly trivial, is clear enough, hopefully, to go through trivial-patches. This area in qemu is basically unmaintained. -------- Michael Tokarev (1): hw/display/qxl-render.c: fix qxl_unp

[PULL 1/1] hw/display/qxl-render.c: fix qxl_unpack_chunks() chunk size calculation

2025-07-25 Thread Michael Tokarev
. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1628 Signed-off-by: Michael Tokarev Reviewed-by: Thomas Huth --- hw/display/qxl-render.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c index eda6d3de37

Re: [PATCH v2] hw/smbios: allow clearing the VM bit in SMBIOS table 0

2025-07-25 Thread Michael S. Tsirkin
t the VM bit, whereas QEMU sets it unconditionally. > > Allowing to clear it also seems useful if we want to hide the fact that > the guest system is running inside a virtual machine. > > Signed-off-by: Daniil Tatianin > --- > > After talking to Michael: > Supersedes: <

Re: [PATCH] pcie_sriov: Fix configuration and state synchronization

2025-07-25 Thread Michael S. Tsirkin
On Fri, Jul 25, 2025 at 02:27:59PM +0300, Michael Tokarev wrote: > On 13.07.2025 12:27, Akihiko Odaki wrote: > > Fix issues in PCIe SR-IOV configuration register handling that caused > > inconsistent internal state due to improper write mask handling and > > incorre

Re: [PATCH] pcie_sriov: Fix configuration and state synchronization

2025-07-25 Thread Michael Tokarev
On 13.07.2025 12:27, Akihiko Odaki wrote: Fix issues in PCIe SR-IOV configuration register handling that caused inconsistent internal state due to improper write mask handling and incorrect migration behavior. Two main problems were identified: 1. VF Enable bit write mask handling: pcie_sri

Re: [RFC 0/6] virtio-net: initial iterative live migration support

2025-07-25 Thread Michael S. Tsirkin
On Thu, Jul 24, 2025 at 05:59:20PM -0400, Jonah Palmer wrote: > > > On 7/23/25 1:51 AM, Jason Wang wrote: > > On Tue, Jul 22, 2025 at 8:41 PM Jonah Palmer > > wrote: > > > > > > This series is an RFC initial implementation of iterative live > > > migration for virtio-net devices. > > > > > >

Re: [RFC 4/6] virtio-net: iter live migration - migrate vmstate

2025-07-25 Thread Michael S. Tsirkin
On Thu, Jul 24, 2025 at 10:45:34AM -0400, Jonah Palmer wrote: > > > On 7/23/25 2:51 AM, Michael S. Tsirkin wrote: > > On Tue, Jul 22, 2025 at 12:41:25PM +, Jonah Palmer wrote: > > > Lays out the initial groundwork for iteratively migrating the state of a > >

Re: [ANNOUNCE] QEMU 10.0.3 Stable released

2025-07-24 Thread Michael Tokarev
On 24.07.2025 17:31, Helge Konetzka wrote: Hi Micheal, trying to download results in: curl https://download.qemu.org/qemu-10.0.3.tar.xz 404 Not Found Yup, we forgot to perform the actual upload of 10.0.3 (but uploaded 7.2.19). It should be there now. Thanks, /mjt

Re: [PATCH] system/physmem: fix use-after-free with dispatch

2025-07-24 Thread Michael Tokarev
emu/-/issues/3040 Signed-off-by: Pierrick Bouvier Reviewed-by: Michael Tokarev Tested-by: Michael Tokarev Thank you for this work! /mjt

Re: [PATCH 0/3] RISC-V: ACPI: Update FADT and MADT versions

2025-07-24 Thread Michael S. Tsirkin
On Wed, Jul 16, 2025 at 08:11:37PM +0530, Sunil V L wrote: > Since RISC-V support is added only in ACPI 6.6, it should adhere to the > expected FADT and MADT versions. Update them. Seems legit Acked-by: Michael S. Tsirkin Risc maintainers, any feedback? > Sunil V L (3): > bios

Re: [PATCH] hw/i386/pc: Avoid overlap between CXL window and PCI 64bit BARs in QEMU

2025-07-24 Thread Michael S. Tsirkin
On Fri, Jul 18, 2025 at 09:35:45PM +0800, peng guo wrote: > When using a CXL Type 3 device together with a virtio 9p device in QEMU, the > 9p device fails to initialize properly. The kernel reports the following: > > virtio: device uses modern interface but does not have VIRTIO_F_VERSION_1 >

[ANNOUNCE] QEMU 7.2.19 Stable released

2025-07-23 Thread Michael Tokarev
Changelog (stable-7.2-hash master-hash Author Name: Commmit-Subject): 5a6481389d Michael Tokarev: Update version for 7.2.19 release 196137c1c6 aef22331b5 Akihiko Odaki: ui/vnc: Do not copy z_stream 385eb77f60 5788929e05 Ethan Milon: amd_iommu: Fix truncation of oldval in amdvi_writeq cae7315f45

[ANNOUNCE] QEMU 10.0.3 Stable released

2025-07-23 Thread Michael Tokarev
Changelog (stable-10.0-hash master-hash Author Name: Commmit-Subject): 66d21643c2 Michael Tokarev: Update version for 10.0.3 release a5ac9803d5 e6da704b71 Zenghui Yu: hvf: arm: Emulate ICC_RPR_EL1 accesses properly 3341f5cd5c 655659a74a Peter Maydell: target/arm: Correct encoding of Debug

[ANNOUNCE] QEMU 10.1.0-rc0 is now available

2025-07-23 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 10.1 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu.org/qemu-10.1.0-rc0.tar.xz http://download.qem

Re: [PATCH] hw/smbios: add an ability to set extension bytes in the type0 table

2025-07-23 Thread Michael S. Tsirkin
On Wed, Jul 23, 2025 at 12:16:08PM +0300, Daniil Tatianin wrote: > > On 7/23/25 12:14 PM, Michael S. Tsirkin wrote: > > On Wed, Jul 23, 2025 at 12:01:28PM +0300, Daniil Tatianin wrote: > > > This is useful to be able to indicate various supported features to the > > &g

Re: [PATCH] hw/smbios: add an ability to set extension bytes in the type0 table

2025-07-23 Thread Michael S. Tsirkin
On Wed, Jul 23, 2025 at 12:01:28PM +0300, Daniil Tatianin wrote: > This is useful to be able to indicate various supported features to the > guest, or freeze a specific version of SeaBIOS to prevent guest visible > changes between BIOS updates. This is currently not possible since the > extension b

Re: [PATCH] hw/i386: Fix 'use-legacy-x86-rom' property compatibility

2025-07-23 Thread Michael S. Tsirkin
Add the ramfb romfile compatibility") > Cc: Gerd Hoffmann > Cc: Shaoqin Huang > Signed-off-by: Cédric Le Goater Acked-by: Michael S. Tsirkin > --- > hw/vfio/types.h | 2 ++ > hw/core/machine.c | 2 +- > hw/i386/microvm.c | 2 +- > hw/i386/pc_piix.c | 2 +- >

Re: [RFC 4/6] virtio-net: iter live migration - migrate vmstate

2025-07-22 Thread Michael S. Tsirkin
On Tue, Jul 22, 2025 at 12:41:25PM +, Jonah Palmer wrote: > Lays out the initial groundwork for iteratively migrating the state of a > virtio-net device, starting with its vmstate (via vmstate_save_state & > vmstate_load_state). > > The original non-iterative vmstate framework still runs durin

Re: apparent race condition in mttcg memory handling

2025-07-22 Thread Michael Tokarev
On 22.07.2025 23:11, Gustavo Romero wrote: ... The reproducer I was using - it was just booting kernel, no user- space is needed. Qemu crashes during kernel init, or it runs fine. I used regular kernel from debian sid:   http://deb.debian.org/debian/pool/main/l/linux-signed-amd64/linux- image-a

Re: [PULL 00/50] ppc queue

2025-07-22 Thread Michael Tokarev
On 22.07.2025 16:37, Cédric Le Goater wrote: + Glenn, Michael, Caleb, Gautam On 7/22/25 13:44, Michael Tokarev wrote: 21.07.2025 19:21, Cédric Le Goater wrote: ppc/xive queue: * Various bug fixes around lost interrupts

Re: [PULL 00/50] ppc queue

2025-07-22 Thread Michael Tokarev
s ctx pull Michael Kowal (4): ppc/xive2: Remote VSDs need to match on forwarding address ppc/xive2: Reset Generation Flipped bit on END Cache Watch pnv/xive2: Print value in invalid register write logging pnv/xive2: Permit valid writes to VC/PC Flush Control registers Nicho

[Stable-10.0.3 70/70] hvf: arm: Emulate ICC_RPR_EL1 accesses properly

2025-07-21 Thread Michael Tokarev
pport for GICv3") Signed-off-by: Zenghui Yu Reviewed-by: Philippe Mathieu-Daudé Message-id: 20250714160139.10404-3-zenghui...@linux.dev Signed-off-by: Peter Maydell (cherry picked from commit e6da704b711d5d731e4d933ad56cbbc25ee0a825) Signed-off-by: Michael Tokarev diff --git a/target/arm/hv

[Stable-10.0.3 68/70] ui: fix setting client_endian field defaults

2025-07-21 Thread Michael Tokarev
ge so aren't exposed to any problems, but the classical 'vncviewer' app will show the problem easily. Fixes: 7ed96710e82c385c6cfc3d064eec7dde20f0f3fd Reported-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau Signed-off-by: Daniel P. Berrangé (cherr

[Stable-10.0.3 69/70] target/arm: Correct encoding of Debug Communications Channel registers

2025-07-21 Thread Michael Tokarev
rom commit 655659a74a36b63e33d2dc969d3c44beb1b008b3) Signed-off-by: Michael Tokarev diff --git a/target/arm/debug_helper.c b/target/arm/debug_helper.c index a9a619ba6b..79c0e8eaff 100644 --- a/target/arm/debug_helper.c +++ b/target/arm/debug_helper.c @@ -986,11 +986,20 @@ static const ARMCPRegInfo debug_cp_reginfo[] = { .opc0

[Stable-10.0.3 66/70] target/i386: do not expose ARCH_CAPABILITIES on AMD CPU

2025-07-21 Thread Michael Tokarev
ed-by: Daniel P. Berrangé Reviewed-by: Xiaoyao Li Signed-off-by: Paolo Bonzini (cherry picked from commit d3a24134e37d57abd3e7445842cda2717f49e96d) Signed-off-by: Michael Tokarev diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 6c749d4ee8..141694f803 100644 --- a/target/i386/kvm/kv

[Stable-10.0.3 v3 00/70] Patch Round-up for stable 10.0.3, freeze on 2025-07-21 (frozen)

2025-07-21 Thread Michael Tokarev
ppa-firmware* 61* 9f749129e262 David Hildenbrand: vhost: Fix used memslot tracking when destroying a vhost device 62* aef22331b5a4 Akihiko Odaki: ui/vnc: Do not copy z_stream 63* a62fef582995 Michael Tokarev: i386/cpu: Fix cpu number overflow in CPUID.01H.EBX[23:16] 64* 3e86124e7cb9 Qian Wen

[Stable-10.0.3 67/70] hw/net/npcm_gmac.c: Send the right data for second packet in a row

2025-07-21 Thread Michael Tokarev
the beginning of the buffer. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Maydell Signed-off-by: Jason Wang (cherry picked from commit 871a6e5b339f0b5e71925ec7d3f452944a1c82d3) Signed-off-by: Michael Tokarev diff --git a/hw/net/npcm_gmac.c b/hw/net/npcm_gmac.c index e1fb383772..d4dba630ac

Re: apparent race condition in mttcg memory handling

2025-07-21 Thread Michael Tokarev
On 21.07.2025 19:29, Pierrick Bouvier wrote: On 7/21/25 9:23 AM, Pierrick Bouvier wrote: .. looks like a good target for TSAN, which might expose the race without really having to trigger it. https://www.qemu.org/docs/master/devel/testing/main.html#building-and- testing-with-tsan I think I t

Re: [PATCH] scripts/make-release: Go back to cloning all the EDK2 submodules

2025-07-21 Thread Michael Tokarev
On 21.07.2025 18:41, Peter Maydell wrote: To quantify "huge amount": a 10.0.0 tarball uncompresses to 911MB; of that, 445MB is roms/edk2. Another 156MB is roms/u-boot, and 48MB is roms/u-boot-sam460ex. roms/ overall is 743MB. So 80% of our source tarball release is ROM blob source, and 48% of o

Re: [PULL 1/6] target/i386: do not expose ARCH_CAPABILITIES on AMD CPU

2025-07-18 Thread Michael Tokarev
On 17.07.2025 18:23, Paolo Bonzini wrote: KVM emulates the ARCH_CAPABILITIES on x86 for both Intel and AMD cpus, although the IA32_ARCH_CAPABILITIES MSR is an Intel-specific MSR and it makes no sense to emulate it on AMD. As a consequence, VMs created on AMD with qemu -cpu host and using KVM wil

[Stable-7.2.19 17/26] migration: Don't sync volatile memory after migration completes

2025-07-17 Thread Michael Tokarev
ram block writeback) Link: https://lore.kernel.org/r/1cc43f59-336f-4a12-84ad-db89e0a17...@akamai.com Signed-off-by: Peter Xu (cherry picked from commit 983899eab4939dc4dff67fa4d822c5b4df7eae21) Signed-off-by: Michael Tokarev diff --git a/migration/ram.c b/migration/ram.c index f25ebd9620..e3ab67a

[Stable-7.2.19 24/26] amd_iommu: Remove duplicated definitions

2025-07-17 Thread Michael Tokarev
From: Alejandro Jimenez No functional change. Signed-off-by: Alejandro Jimenez Reviewed-by: Vasant Hegde Message-Id: <20250617150427.20585-8-alejandro.j.jime...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin (cherry picked from

[Stable-7.2.19 22/26] amd_iommu: Fix mask to retrieve Interrupt Table Root Pointer from DTE

2025-07-17 Thread Michael Tokarev
Message-Id: <20250617150427.20585-6-alejandro.j.jime...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin (cherry picked from commit 123cf4bdd378f746dfa2f5415ba084148dded3e3) Signed-off-by: Michael Tokarev diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h index bc3a6eaa6d..1

[Stable-7.2.19 26/26] ui/vnc: Do not copy z_stream

2025-07-17 Thread Michael Tokarev
cked from commit aef22331b5a4670f42638a5f63a26e93bf779aae) Signed-off-by: Michael Tokarev diff --git a/ui/vnc-enc-zlib.c b/ui/vnc-enc-zlib.c index 900ae5b30f..52e9193eab 100644 --- a/ui/vnc-enc-zlib.c +++ b/ui/vnc-enc-zlib.c @@ -48,21 +48,21 @@ void vnc_zlib_zfree(void *x, void *addr) static voi

[Stable-7.2.19 19/26] amd_iommu: Fix Device ID decoding for INVALIDATE_IOTLB_PAGES command

2025-07-17 Thread Michael Tokarev
IOMMU") Signed-off-by: Alejandro Jimenez Reviewed-by: Vasant Hegde Message-Id: <20250617150427.20585-3-alejandro.j.jime...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin (cherry picked from commit c63b8d1425ba8b3b08ee4f7346457fd8a7f12a24) Signed-off-by: Michae

[Stable-7.2.19 25/26] amd_iommu: Fix truncation of oldval in amdvi_writeq

2025-07-17 Thread Michael Tokarev
: d29a09ca6842 ("hw/i386: Introduce AMD IOMMU") Signed-off-by: Ethan Milon Message-Id: <20250617150427.20585-9-alejandro.j.jime...@oracle.com> Reviewed-by: Vasant Hegde Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin (cherry pi

[Stable-7.2.19 23/26] amd_iommu: Fix the calculation for Device Table size

2025-07-17 Thread Michael Tokarev
sant Hegde Message-Id: <20250617150427.20585-7-alejandro.j.jime...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin (cherry picked from commit 67d3077ee403472d45794399e97c9f329242fce9) Signed-off-by: Michael Tokarev diff --git a/hw/i386/amd_iommu.c b/hw/i386/a

[Stable-7.2.19 18/26] amd_iommu: Fix Miscellaneous Information Register 0 encoding

2025-07-17 Thread Michael Tokarev
. Cc: qemu-sta...@nongnu.org Fixes: d29a09ca6842 ("hw/i386: Introduce AMD IOMMU") Co-developed-by: Ethan MILON Signed-off-by: Ethan MILON Signed-off-by: Alejandro Jimenez Message-Id: <20250617150427.20585-2-alejandro.j.jime...@oracle.com> Reviewed-by: Vasant Hegde Reviewed-by: Mi

[Stable-7.2.19 20/26] amd_iommu: Update bitmasks representing DTE reserved fields

2025-07-17 Thread Michael Tokarev
special conditions are not yet implemented. Cc: qemu-sta...@nongnu.org Signed-off-by: Alejandro Jimenez Reviewed-by: Vasant Hegde Message-Id: <20250617150427.20585-4-alejandro.j.jime...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin (cherry picked from

[Stable-7.2.19 v2 00/26] Patch Round-up for stable 7.2.19, freeze on 2025-07-21

2025-07-17 Thread Michael Tokarev
The following patches are queued for QEMU stable v7.2.19: https://gitlab.com/qemu-project/qemu/-/commits/staging-7.2 Patch freeze is 2025-07-21, and the release is planned for 2025-07-23: https://wiki.qemu.org/Planning/7.2 Please respond here or CC qemu-sta...@nongnu.org on any additional p

  1   2   3   4   5   6   7   8   9   10   >