[PATCH] vvfat: create_long_filename(): refresh

2025-01-19 Thread Michael Tokarev
add comments explaining what is going on (since long file names are really weird), rewrite the second loop to do one UTF16 char at a time instead of byte, and fix coding style. Signed-off-by: Michael Tokarev --- block/vvfat.c | 54 +-- 1 file

[PATCH] vvfat: create_long_filename: fix out-of-bounds array access

2025-01-19 Thread Michael Tokarev
nto several parts within the entry, not just in regular 8+3 name field. Treat the entry as array of bytes instead. This fixes the OOB access from the compiler/tools PoV, but does not change the resulting code in any way. Keep the existing code style. Signed-off-by: Michael Tokarev --- bl

[PATCH v3, do not apply] vvfat: refresh writing long filename

2025-01-19 Thread Michael Tokarev
ys. A directory entry for a long FAT file name is significantly different from a directory entry for a regular FAT file name. This change makes whole logic dealing with the long filenames a bit more clear (hopefully). Based on ideas by Volker Rümelin. Signed-off-by: Michael Tokarev --- block/vvfat.c

[PATCH v2] vvfat: refresh writing long filename

2025-01-18 Thread Michael Tokarev
ys. A directory entry for a long FAT file name is significantly different from a directory entry for a regular FAT file name. This change makes whole logic dealing with the long filenames a bit more clear (hopefully). Based on ideas by Volker Rümelin. Signed-off-by: Michael Tokarev --- block/vvfat.c

Re: [PATCH v2] vvfat: refresh writing long filename

2025-01-18 Thread Michael Tokarev
19.01.2025 00:26, Michael Tokarev wrote: +static unsigned write_lfn_part(uint8_t *dest, unsigned dsize, + const gunichar2 *lptr, const gunichar2 *lend) +{ +unsigned i = 0; +for (; i < dsize / 2 && lptr + i <= lend; ++i) { /* incl. t

Re: [PATCH] vvfat: refresh writing long filename

2025-01-18 Thread Michael Tokarev
18.01.2025 23:54, BALATON Zoltan wrote: +typedef struct lfn_direntry_t { +    uint8_t sequence; +    uint8_t name01[10]; +    uint8_t attributes; +    uint8_t direntry_type; +    uint8_t sfn_checksum; +    uint8_t name0e[12]; +    uint16_t begin; +    uint8_t name1c[4]; +} QEMU_PACKED lfn_dirent

Re: [PATCH] vvfat: refresh writing long filename

2025-01-18 Thread Michael Tokarev
18.01.2025 23:32, Volker Rümelin wrote: The rules are: If the file name length in characters is a multiple of 13 you are done. Otherwise the remaining unused LFN direntry name array elements have to be filled with one 0x (a 16 bit 0) and the rest with 0x. BTW, are we really okay with a

Re: [PATCH] vvfat: refresh writing long filename

2025-01-18 Thread Michael Tokarev
+ 0] = lptr[i] & 0xff; +dest[i / 2 + 1] = lptr[i] >> 8; +} Hi Michael, this is not right. It's necessary to initialize the remaining elements of the name arrays. The rules are: If the file name length in characters is a multiple of 13 you are done. Otherwise the remai

Re: [PATCH 0/2] net: Fix announce_self with vhost

2025-01-18 Thread Michael Tokarev
This series fix a problem with this flag in filter-dump and in qemu_deliver_packet_iov(). Laurent Vivier (2): net: Fix announce_self net/dump: Correctly compute Ethernet packet offset net/dump.c | 3 ++- net/net.c | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Mi

Re: [PATCH] gdbstub/user-target: fix gdbserver int format (%d -> %x)

2025-01-18 Thread Michael Tokarev
e of which can be seen here [0]. [0] https://github.com/bminor/binutils-gdb/blob/e65a355022d0dc6b5707310876a72b5693ec0aa5/gdbserver/hostio.cc#L196-L213 Reviewed-by: Michael Tokarev Unfortunately we can't apply this one without Signed-off-by: tag from you, and maybe without fixing the f

[PATCH] vvfat: refresh writing long filename

2025-01-18 Thread Michael Tokarev
ys. A directory entry for a long FAT file name is significantly different from a directory entry for a regular FAT file name. This change makes whole logic dealing with the long filenames a bit more clear (hopefully). Based on ideas by Volker Rümelin. Signed-off-by: Michael Tokarev --- block/vvfat.c

Re: [PATCH] vvfat: fix out of bounds array write

2025-01-18 Thread Michael Tokarev
05.01.2025 16:59, Volker Rümelin wrote: In function create_long_filname(), the array name[8 + 3] in struct direntry_t is used as if it were defined as name[32]. This is intentional and works. It's nevertheless an out of bounds array access. To avoid this problem, this patch adds a struct lfn_dire

Re: [PATCH 00/21] hw/i386/pc: Remove deprecated 2.4 and 2.5 PC machines

2025-01-17 Thread Michael S. Tsirkin
On Thu, Jan 16, 2025 at 12:22:26AM +0100, Philippe Mathieu-Daudé wrote: > The versioned 'pc' and 'q35' machines up to 2.12 been marked > as deprecated two releases ago, and are older than 6 years, > so according to our support policy we can remove them. > > This series only includes the 2.4 and 2.

Re: [PATCH v3] hw/cxl: Fix msix_notify: Assertion `vector < dev->msix_entries_nr`

2025-01-16 Thread Michael Tokarev
15.01.2025 10:58, Li Zhijian via wrote: This assertion always happens when we sanitize the CXL memory device. $ echo 1 > /sys/bus/cxl/devices/mem0/security/sanitize It is incorrect to register an MSIX number beyond the device's capability. Increase the device's MSIX number to cover the mailbox

Re: [PATCH v2 01/13] hw/sd/sdhci: Set SDHC_NIS_DMA bit when appropriate

2025-01-16 Thread Michael Tokarev
17.01.2025 02:39, Bernhard Beschow wrote: Am 15. Januar 2025 12:55:29 UTC schrieb Michael Tokarev : Is this a qemu-stable material? Good question. Given that this part of the code has some further issues [1] I'd rather not alter stable behavior because we might just trade one bu

Re: [PATCH 2/3] pci: acpi: Windows 'PCI Label Id' bug workaround

2025-01-16 Thread Michael Tokarev
15.01.2025 15:53, Igor Mammedov wrote: Current versions of Windows call _DSM(func=7) regardless of whether it is supported or not. It leads to NICs having bogus 'PCI Label Id = 0', where none should be set at all. Also presence of 'PCI Label Id' triggers another Windows bug on localized versions

Re: [PATCH] pci/msix: Fix msix pba read vector poll end calculation

2025-01-16 Thread Michael Tokarev
12.12.2024 15:04, Nicholas Piggin wrote: The end vector calculation has a bug that results in polling fewer than required vectors when reading at a non-zero offset in PBA memory. Fixes: bbef882cc193 ("msi: add API to get notified about pending bit poll") Signed-off-by: Nicholas Piggin This sm

Re: [PATCH v2] pci: ensure valid link status bits for downstream ports

2025-01-16 Thread Michael Tokarev
03.12.2024 15:19, Sebastian Ott wrote: PCI hotplug for downstream endpoints on arm fails because Linux' PCIe hotplug driver doesn't like the QEMU provided LNKSTA: pcieport :08:01.0: pciehp: Slot(2): Card present pcieport :08:01.0: pciehp: Slot(2): Link Up pcieport :08:01.0:

Re: [PATCH v7 0/3] hw/acpi: Add vmclock device

2025-01-16 Thread Michael S. Tsirkin
at's being shipped in certain > commercial hypervisors. > > Linux guest support was merged into the 6.13-rc1 kernel: > https://git.kernel.org/torvalds/c/205032724226 Reviewed-by: Michael S. Tsirkin feel free to merge. > --- > v7: > • Split update-kernel-headers.

Re: [PATCH] firmware: qemu_fw_cfg: constify 'struct bin_attribute'

2025-01-16 Thread Michael S. Tsirkin
homas Weißschuh why not Acked-by: Michael S. Tsirkin > --- > drivers/firmware/qemu_fw_cfg.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c > index

Re: [PULL 00/48] virtio,pc,pci: features, fixes, cleanups

2025-01-15 Thread Michael S. Tsirkin
On Wed, Jan 15, 2025 at 01:08:28PM -0500, Michael S. Tsirkin wrote: > The following changes since commit 7433709a147706ad7d1956b15669279933d0f82b: > > Merge tag 'hw-misc-20250113' of https://github.com/philmd/qemu into staging > (2025-01-14 12:46:56 -0500) > &

Re: [PULL 00/48] virtio,pc,pci: features, fixes, cleanups

2025-01-15 Thread Michael S. Tsirkin
On Thu, Jan 16, 2025 at 12:05:59AM +0100, David Woodhouse wrote: > On 15 January 2025 23:42:41 CET, "Michael S. Tsirkin" wrote: > >On Wed, Jan 15, 2025 at 07:15:18PM +0100, David Woodhouse wrote: > >> On Wed, 2025-01-15 at 13:08 -0500, Michael S. Tsirkin wrote: > &

Re: [PULL 00/48] virtio,pc,pci: features, fixes, cleanups

2025-01-15 Thread Michael S. Tsirkin
On Wed, Jan 15, 2025 at 07:15:18PM +0100, David Woodhouse wrote: > On Wed, 2025-01-15 at 13:08 -0500, Michael S. Tsirkin wrote: > > The following changes since commit 7433709a147706ad7d1956b15669279933d0f82b: > > > >   Merge tag 'hw-misc-20250113' of http

[PULL 29/48] acpi/ghes: simplify the per-arch caller to build HEST table

2025-01-15 Thread Michael S. Tsirkin
valho Chehab Reviewed-by: Jonathan Cameron Reviewed-by: Igor Mammedov Message-Id: <9584bb8953385e165681d5d185c503f8df8ef42f.1736945236.git.mchehab+hua...@kernel.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/ghes.h | 4 ++-- hw/acpi/ghes.c

[PULL 36/48] acpi/ghes: better name GHES memory error function

2025-01-15 Thread Michael S. Tsirkin
: <35b59121129d5e99cb5062cc3d775594bbb0905b.1736945236.git.mchehab+hua...@kernel.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/ghes.h | 4 ++-- hw/acpi/ghes-stub.c| 2 +- hw/acpi/ghes.c | 2 +- target/arm/kvm.c | 2 +- 4 files chan

[PULL 19/48] intel_iommu: piotlb invalidation should notify unmap

2025-01-15 Thread Michael S. Tsirkin
-by: Jason Wang Reviewed-by: Clément Mathieu--Drif Message-Id: <20241212083757.605022-15-zhenzhong.d...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/intel_iommu.c | 43 ++- 1 file changed, 34 insertions

[PULL 05/48] tests: acpi: update expected blobs

2025-01-15 Thread Michael S. Tsirkin
, 0x03) +\_SB.PCI0.PRES.CSEL = Local3 +\_SB.PCI0.PRES.CRMV = One +Local2++ + } } Release (\_SB.PCI0.PRES.CPLK) Signed-off-by: Igor Mammedov Message-Id: <20241210163945.34226

[PULL 34/48] acpi/ghes: don't check if physical_address is not zero

2025-01-15 Thread Michael S. Tsirkin
From: Mauro Carvalho Chehab The 'physical_address' value is a faulty page. As such, 0 is as valid as any other value. Suggested-by: Igor Mammedov Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Igor Mammedov Reviewed-by: Jonathan Cameron Message-Id: Reviewed-by: Michael

[PULL 26/48] pci/msix: Fix msix pba read vector poll end calculation

2025-01-15 Thread Michael S. Tsirkin
Message-Id: <20241212120402.1475053-1-npig...@gmail.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci/msix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/msix.c b/hw/pci/msix.c index d8a55a6474..57ec7084a4 100

[PULL 22/48] tests/acpi: q35: Update host address width in DMAR

2025-01-15 Thread Michael S. Tsirkin
2] Reserved : [044h 0068 1] Enumeration ID : 00 [045h 0069 1] PCI Bus Number : FF Signed-off-by: Zhenzhong Duan Acked-by: Clément Mathieu--Drif Message-Id: <20241212083757.605022-18-zhenzhong.d...@intel.com> Reviewed-by: Michael

[PULL 44/48] pci: acpi: Windows 'PCI Label Id' bug workaround

2025-01-15 Thread Michael S. Tsirkin
code. Smoke tested with WinXP and WS2022 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/774 Signed-off-by: Igor Mammedov Message-Id: <20250115125342.3883374-3-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 33 +

[PULL 23/48] intel_iommu: Introduce a property x-flts for stage-1 translation

2025-01-15 Thread Michael S. Tsirkin
eviewed-by: Clément Mathieu--Drif Message-Id: <20241212083757.605022-19-zhenzhong.d...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/intel_iommu_internal.h | 2 ++ hw/i386/intel_iommu.c | 28 +++- 2 files changed, 21

[PULL 35/48] acpi/ghes: make the GHES record generation more generic

2025-01-15 Thread Michael S. Tsirkin
Mammedov Reviewed-by: Jonathan Cameron Message-Id: <68d9f787d8c4fc8d1dbc227d6902fe801e42dea9.1736945236.git.mchehab+hua...@kernel.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/ghes.h | 3 ++ hw/acpi/ghes.c

[PULL 47/48] vhost: Add stubs for the migration state transfer interface

2025-01-15 Thread Michael S. Tsirkin
stub functions for vhost_supports_device_state(), vhost_save_backend_state() and vhost_load_backend_state(). Cc: Hanna Czenczek Signed-off-by: Laurent Vivier Message-Id: <20250115135044.799698-2-lviv...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- incl

[PULL 21/48] intel_iommu: Set default aw_bits to 48 starting from QEMU 9.2

2025-01-15 Thread Michael S. Tsirkin
: Zhenzhong Duan Reviewed-by: Clément Mathieu--Drif Reviewed-by: Yi Liu Acked-by: Jason Wang Message-Id: <20241212083757.605022-17-zhenzhong.d...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i386/intel_iommu.h | 2 +- hw/i38

[PULL 48/48] virtio-net: vhost-user: Implement internal migration

2025-01-15 Thread Michael S. Tsirkin
From: Laurent Vivier Add support of VHOST_USER_PROTOCOL_F_DEVICE_STATE in virtio-net with vhost-user backend. Cc: Hanna Czenczek Signed-off-by: Laurent Vivier Message-Id: <20250115135044.799698-3-lviv...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin -

[PULL 37/48] acpi/ghes: don't crash QEMU if ghes GED is not found

2025-01-15 Thread Michael S. Tsirkin
From: Mauro Carvalho Chehab Make error handling within ghes_record_cper_errors() consistent, i.e. instead abort just print a error in case ghes GED is not found. Reviewed-by: Jonathan Cameron Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Igor Mammedov Message-Id: Reviewed-by: Michael S

[PULL 39/48] acpi/ghes: better name the offset of the hardware error firmware

2025-01-15 Thread Michael S. Tsirkin
Reviewed-by: Igor Mammedov Message-Id: Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/ghes.h | 2 +- hw/acpi/generic_event_device.c | 4 ++-- hw/acpi/ghes.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a

[PULL 14/48] intel_iommu: Set accessed and dirty bits during stage-1 translation

2025-01-15 Thread Michael S. Tsirkin
From: Clément Mathieu--Drif Signed-off-by: Clément Mathieu--Drif Signed-off-by: Zhenzhong Duan Reviewed-by: Yi Liu Acked-by: Jason Wang Message-Id: <20241212083757.605022-10-zhenzhong.d...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- h

[PULL 31/48] acpi/ghes: Fix acpi_ghes_record_errors() argument

2025-01-15 Thread Michael S. Tsirkin
From: Mauro Carvalho Chehab Align the header file with the actual implementation of this function, as the first argument is source ID and not notification type. Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Jonathan Cameron Reviewed-by: Igor Mammedov Message-Id: Reviewed-by: Michael S

[PULL 40/48] acpi/ghes: move offset calculus to a separate function

2025-01-15 Thread Michael S. Tsirkin
: <60fdd1bf379ba1db3099710868802aa49a27febb.1736945236.git.mchehab+hua...@kernel.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/ghes.c | 40 +++- 1 file changed, 31 insertions(+), 9 deletions(-) diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c

[PULL 32/48] acpi/ghes: Remove a duplicated out of bounds check

2025-01-15 Thread Michael S. Tsirkin
: Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/ghes.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c index 29cd7e4d81..5f67322bf0 100644 --- a/hw/acpi/ghes.c +++ b/hw/acpi/ghes.c @@ -404,9 +404,7 @@ int

[PULL 45/48] tests: acpi: update expected blobs

2025-01-15 Thread Michael S. Tsirkin
cal0 [Zero] = Local2 +Local0 [One] = "" +} + Return (Local0) } } Signed-off-by: Igor Mammedov Message-Id: <20250115125342.3883374-4-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-

[PULL 33/48] acpi/ghes: Change the type for source_id

2025-01-15 Thread Michael S. Tsirkin
: Jonathan Cameron Reviewed-by: Igor Mammedov Message-Id: <0e83ba548c1aedd1299fe387b94db78986590a34.1736945236.git.mchehab+hua...@kernel.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/ghes.h | 2 +- hw/acpi/ghes-stub.c| 2 +- hw/acpi/ghes.c

[PULL 30/48] acpi/ghes: better handle source_id and notification

2025-01-15 Thread Michael S. Tsirkin
independent parameters, allowing the caller function to fill both. Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Jonathan Cameron Reviewed-by: Igor Mammedov Message-Id: <133ff72ea1041fed7dbcf97b7a2b0f4dfacde31a.1736945236.git.mchehab+hua...@kernel.org> Reviewed-by: Michael S. Tsirkin Sign

[PULL 25/48] tests/qtest: Add intel-iommu test

2025-01-15 Thread Michael S. Tsirkin
: Clément Mathieu--Drif Acked-by: Jason Wang Message-Id: <20241212083757.605022-21-zhenzhong.d...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i386/intel_iommu.h | 1 + tests/qtest/intel-iommu-test.c | 64 ++ MAINT

[PULL 42/48] docs: acpi_hest_ghes: fix documentation for CPER size

2025-01-15 Thread Michael S. Tsirkin
Reviewed-by: Igor Mammedov Message-Id: Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- docs/specs/acpi_hest_ghes.rst | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/specs/acpi_hest_ghes.rst b/docs/specs/acpi_hest_ghes.rst index 68f1fbe0a4

[PULL 08/48] intel_iommu: Add a placeholder variable for scalable mode stage-1 translation

2025-01-15 Thread Michael S. Tsirkin
evice passthrough until nesting is supported. Signed-off-by: Yi Liu Signed-off-by: Zhenzhong Duan Acked-by: Jason Wang Reviewed-by: Clément Mathieu--Drif Reviewed-by: Yi Liu Message-Id: <20241212083757.605022-4-zhenzhong.d...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael

[PULL 24/48] intel_iommu: Introduce a property to control FS1GP cap bit setting

2025-01-15 Thread Michael S. Tsirkin
when vIOMMU is in legacy mode or x-flts=off in scalable modme. Signed-off-by: Zhenzhong Duan Reviewed-by: Clément Mathieu--Drif Reviewed-by: Yi Liu Acked-by: Jason Wang Message-Id: <20241212083757.605022-20-zhenzhong.d...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael

[PULL 46/48] hw/cxl: Fix msix_notify: Assertion `vector < dev->msix_entries_nr`

2025-01-15 Thread Michael S. Tsirkin
er(9). Fixes: 43efb0bfad2b ("hw/cxl/mbox: Wire up interrupts for background completion") Signed-off-by: Li Zhijian Message-Id: <20250115075834.167504-1-lizhij...@fujitsu.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/mem/cxl_type3.c | 2 +- 1 fi

[PULL 17/48] intel_iommu: Add an internal API to find an address space with PASID

2025-01-15 Thread Michael S. Tsirkin
From: Clément Mathieu--Drif This will be used to implement the device IOTLB invalidation Signed-off-by: Clément Mathieu--Drif Signed-off-by: Zhenzhong Duan Acked-by: Jason Wang Reviewed-by: Yi Liu Message-Id: <20241212083757.605022-13-zhenzhong.d...@intel.com> Reviewed-by: Mic

[PULL 41/48] acpi/ghes: Change ghes fill logic to work with only one source

2025-01-15 Thread Michael S. Tsirkin
Reviewed-by: Jonathan Cameron Reviewed-by: Igor Mammedov Message-Id: <66bddd42a64c8515ad98b9975d953b4a70ffcc6d.1736945236.git.mchehab+hua...@kernel.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/ghes.c | 12 1 file changed, 4 insertions

[PULL 38/48] acpi/ghes: rename etc/hardware_error file macros

2025-01-15 Thread Michael S. Tsirkin
-Id: Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/ghes.c | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c index 6843ddf64b..3f94a5542b 100644 --- a/hw/acpi/ghes.c +++ b/hw

[PULL 15/48] intel_iommu: Flush stage-1 cache in iotlb invalidation

2025-01-15 Thread Michael S. Tsirkin
y: Yi Liu Message-Id: <20241212083757.605022-11-zhenzhong.d...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i386/intel_iommu.h | 1 + hw/i386/intel_iommu.c | 27 +-- 2 files changed, 22 insertions(+), 6 deletio

[PULL 43/48] tests: acpi: whitelist expected blobs

2025-01-15 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <20250115125342.3883374-2-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 40 + 1 file changed, 40 insertions(+)

[PULL 18/48] intel_iommu: Add support for PASID-based device IOTLB invalidation

2025-01-15 Thread Michael S. Tsirkin
From: Clément Mathieu--Drif Signed-off-by: Clément Mathieu--Drif Signed-off-by: Zhenzhong Duan Acked-by: Jason Wang Message-Id: <20241212083757.605022-14-zhenzhong.d...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/intel_iommu_internal.

[PULL 16/48] intel_iommu: Process PASID-based iotlb invalidation

2025-01-15 Thread Michael S. Tsirkin
: Clément Mathieu--Drif Acked-by: Jason Wang Reviewed-by: Yi Liu Message-Id: <20241212083757.605022-12-zhenzhong.d...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/intel_iommu_internal.h | 3 +++ hw/i386/intel_iommu.c

[PULL 01/48] virtio-gpu: Add definition for resource_uuid feature

2025-01-15 Thread Michael S. Tsirkin
From: Dorinda Bassey Add the VIRTIO_GPU_F_RESOURCE_UUID feature to enable the assignment of resources UUIDs for export to other virtio devices. Signed-off-by: Dorinda Bassey Message-Id: <20241007070013.3350752-1-dbas...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Mic

[PULL 10/48] intel_iommu: Rename slpte to pte

2025-01-15 Thread Michael S. Tsirkin
: Clément Mathieu--Drif Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan Acked-by: Jason Wang Reviewed-by: Yi Liu Message-Id: <20241212083757.605022-6-zhenzhong.d...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/intel_iommu_internal.h

[PULL 07/48] intel_iommu: Make pasid entry type check accurate

2025-01-15 Thread Michael S. Tsirkin
uggested-by: Yi Liu Signed-off-by: Zhenzhong Duan Reviewed-by: Clément Mathieu--Drif Reviewed-by: Yi Liu Acked-by: Jason Wang Message-Id: <20241212083757.605022-3-zhenzhong.d...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/intel_iommu.c | 12

[PULL 13/48] intel_iommu: Check stage-1 translation result with interrupt range

2025-01-15 Thread Michael S. Tsirkin
3757.605022-9-zhenzhong.d...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/intel_iommu.c | 48 ++- 1 file changed, 25 insertions(+), 23 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c

[PULL 20/48] tests/acpi: q35: allow DMAR acpi table changes

2025-01-15 Thread Michael S. Tsirkin
From: Zhenzhong Duan Signed-off-by: Zhenzhong Duan Acked-by: Jason Wang Message-Id: <20241212083757.605022-16-zhenzhong.d...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 ins

[PULL 27/48] acpi/ghes: get rid of ACPI_HEST_SRC_ID_RESERVED

2025-01-15 Thread Michael S. Tsirkin
87b.1736945236.git.mchehab+hua...@kernel.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/ghes.h | 3 ++- hw/acpi/ghes.c | 7 ++- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/include/hw/acpi/ghes.h b/include/hw/acpi/ghes.h

[PULL 28/48] acpi/ghes: simplify acpi_ghes_record_errors() code

2025-01-15 Thread Michael S. Tsirkin
236.git.mchehab+hua...@kernel.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/ghes.c | 56 ++ 1 file changed, 29 insertions(+), 27 deletions(-) diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c index dc217694de..e66f3be150

[PULL 06/48] intel_iommu: Use the latest fault reasons defined by spec

2025-01-15 Thread Michael S. Tsirkin
are supported. Instead cap/ecap bits should be checked. Signed-off-by: Yu Zhang Signed-off-by: Zhenzhong Duan Reviewed-by: Clément Mathieu--Drif Reviewed-by: Yi Liu Acked-by: Jason Wang Message-Id: <20241212083757.605022-2-zhenzhong.d...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-

[PULL 03/48] tests: acpi: whitelist expected blobs

2025-01-15 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Message-Id: <20241210163945.3422623-2-imamm...@redhat.com> Tested-by: Eric Mackay Acked-by: Ani Sinha Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.

[PULL 12/48] intel_iommu: Check if the input address is canonical

2025-01-15 Thread Michael S. Tsirkin
wed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/intel_iommu_internal.h | 1 + hw/i386/intel_iommu.c | 23 +++ 2 files changed, 24 insertions(+) diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h index 86d3354198..3e73

[PULL 11/48] intel_iommu: Implement stage-1 translation

2025-01-15 Thread Michael S. Tsirkin
: <20241212083757.605022-7-zhenzhong.d...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/intel_iommu_internal.h | 34 +++ hw/i386/intel_iommu.c | 158 - 2 files changed, 188 insertions(+), 4 deletions(-)

[PULL 02/48] pci: ensure valid link status bits for downstream ports

2025-01-15 Thread Michael S. Tsirkin
ide of the branch to make sure downstream ports always have a valid LNKSTA. Signed-off-by: Sebastian Ott Tested-by: Zhenyu Zhang Message-Id: <20241203121928.14861-1-seb...@redhat.com> Reviewed-by: Alex Williamson Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/

[PULL 04/48] cpuhp: make sure that remove events are handled within the same SCI

2025-01-15 Thread Michael S. Tsirkin
e guest bug and should be fixed there. Signed-off-by: Igor Mammedov Reported-by: Eric Mackay Message-Id: <20241210163945.3422623-3-imamm...@redhat.com> Tested-by: Eric Mackay Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/cpu.c | 43

[PULL 09/48] intel_iommu: Flush stage-2 cache in PASID-selective PASID-based iotlb invalidation

2025-01-15 Thread Michael S. Tsirkin
> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/intel_iommu_internal.h | 14 -- hw/i386/intel_iommu.c | 85 +- 2 files changed, 93 insertions(+), 6 deletions(-) diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_

[PULL 00/48] virtio,pc,pci: features, fixes, cleanups

2025-01-15 Thread Michael S. Tsirkin
e: stage-1 translation in vtd internal migration in vhost-user ghes driver preparation for error injection new resource uuid feature in virtio gpu And as usual, fixes and cleanups. Signed-off-by: Michael S. Tsirkin Clément Mathie

Re: [PATCH v17 00/11] New vmapple machine type and xhci fixes

2025-01-15 Thread Michael S. Tsirkin
On Wed, Jan 15, 2025 at 04:33:45PM +0100, Phil Dennis-Jordan wrote: > > > On Wed, 15 Jan 2025 at 16:08, Michael S. Tsirkin wrote: > > On Sun, Jan 12, 2025 at 10:00:45PM +0100, Phil Dennis-Jordan wrote: > > This patch set introduces a new ARM and macOS HVF

Re: [PATCH v17 00/11] New vmapple machine type and xhci fixes

2025-01-15 Thread Michael S. Tsirkin
On Sun, Jan 12, 2025 at 10:00:45PM +0100, Phil Dennis-Jordan wrote: > This patch set introduces a new ARM and macOS HVF specific machine type > called "vmapple". There are also some patches for fixing XHCI spec > compliance issues and adding a workaround to a quirk in the macOS guest's > XHCI drive

Re: [PATCH v2] hw/i386/cpu: remove default_cpu_version and simplify

2025-01-15 Thread Michael S. Tsirkin
On Wed, Jan 15, 2025 at 11:33:10AM +0530, Ani Sinha wrote: > On Thu, Dec 12, 2024 at 8:19 PM Ani Sinha wrote: > > > > commit 0788a56bd1ae3 ("i386: Make unversioned CPU models be aliases") > > introduced 'default_cpu_version' for PCMachineClass. This created three > > categories of CPU models: > >

Re: [PATCH v2 01/13] hw/sd/sdhci: Set SDHC_NIS_DMA bit when appropriate

2025-01-15 Thread Michael Tokarev
11.01.2025 21:36, Bernhard Beschow wrote: In U-Boot, the fsl_esdhc[_imx] driver waits for both "transmit completed" and "DMA" bits in esdhc_send_cmd_common() by means of DATA_COMPLETE constant. QEMU currently misses to set the DMA bit which causes the driver to loop forever. Fix that by setting t

Re: [PATCH v17 00/11] New vmapple machine type and xhci fixes

2025-01-15 Thread Michael Tokarev
13.01.2025 00:00, Phil Dennis-Jordan wrote: This patch set introduces a new ARM and macOS HVF specific machine type called "vmapple". There are also some patches for fixing XHCI spec compliance issues and adding a workaround to a quirk in the macOS guest's XHCI driver. The vmapple machine type a

Re: [PATCH v2] backends/cryptodev-vhost-user: Fix local_error leaks

2025-01-15 Thread Michael Tokarev
28.12.2024 04:16, Gabriel Barrantes wrote: From 532af9eecee4695abb02b40f2c18b711370aa7d2 Mon Sep 17 00:00:00 2001 From: Gabriel Barrantes Date: Fri, 27 Dec 2024 18:02:32 -0600 Subject: [PATCH v2] backends/cryptodev-vhost-user: Fix local_error leaks Do not propagate error to the upper, directly

Re: [PATCH v2] hw/ufs: Adjust value to match CPU's endian format

2025-01-15 Thread Michael Tokarev
07.01.2025 11:43, Keoseong Park wrote: In ufs_write_attr_value(), the value parameter is handled in the CPU's endian format but provided in big-endian format by the caller. Thus, it is converted to the CPU's endian format. The related test code is also fixed to reflect this change. Fixes: 7c8533

Re: [PATCH v6 00/16] Prepare GHES driver to support error injection

2025-01-15 Thread Michael S. Tsirkin
On Sat, Dec 07, 2024 at 09:54:06AM +0100, Mauro Carvalho Chehab wrote: > Hi Michael, > > Please ignore the patch series I sent yesterday: > https://lore.kernel.org/qemu-devel/20241207093922.1efa0...@foz.lan/T/#t > > The git range was wrong, and it was supposed to be v6.

Re: [PATCH v6 09/16] acpi/ghes: make the GHES record generation more generic

2025-01-15 Thread Michael S. Tsirkin
On Sat, Dec 07, 2024 at 09:54:15AM +0100, Mauro Carvalho Chehab wrote: > Split the code into separate functions to allow using the > common CPER filling code by different error sources. > > The generic code was moved to ghes_record_cper_errors(), > and ghes_gen_err_data_uncorrectable_recoverable()

Re: [PATCH] virtio-net: vhost-user: Implement internal migration

2025-01-15 Thread Michael S. Tsirkin
On Wed, Dec 18, 2024 at 03:34:53PM +0100, Laurent Vivier wrote: > Add support of VHOST_USER_PROTOCOL_F_DEVICE_STATE in virtio-net > with vhost-user backend. > > Cc: Hanna Czenczek > Signed-off-by: Laurent Vivier Breaks windows builds: https://gitlab.com/mstredhat/qemu/-/jobs/8855973625 > ---

Re: [PATCH] virtio-balloon-pci: Allow setting nvectors, so we can use MSI-X

2025-01-15 Thread Michael S. Tsirkin
On Wed, Jan 08, 2025 at 09:14:35AM -0600, Reza Arbab wrote: > On Wed, Dec 18, 2024 at 11:37:05AM +0100, David Hildenbrand wrote: > > No expert on any of that MSi-X / PCI magic, but LGTM > > > > Acked-by: David Hildenbrand > > Thanks David! > > Did anyone else have any comments? Just want to mak

Re: [PATCH v7 RESEND 0/5] i386: Support SMP Cache Topology

2025-01-15 Thread Michael S. Tsirkin
there is a clear demand for this feature, the correct > approach would be to add a new control field in MachineClass.smp_props > and enable it only for the machines that require it. > > > This series is based on the master branch at commit aa3a285b5bc5 ("Merge > tag 'mem-2024-12-21

Re: [PATCH 0/3] cpuhp: ensure that cpu hotremove works the 1st time

2025-01-14 Thread Michael S. Tsirkin
On Tue, Jan 14, 2025 at 11:20:54AM +0100, Igor Mammedov wrote: > On Tue, 10 Dec 2024 17:39:42 +0100 > Igor Mammedov wrote: > > > CPU hotremove event is not delivered to OSPM if the CPU > > has been hotplugged before OS has booted. > > For details see [2/3]. > &

Re: [PATCH v4 1/3] win32: remove usage of attribute gcc_struct

2025-01-13 Thread Michael S. Tsirkin
1 100644 > --- a/subprojects/libvhost-user/libvhost-user.h > +++ b/subprojects/libvhost-user/libvhost-user.h > @@ -186,11 +186,7 @@ typedef struct VhostUserShared { > unsigned char uuid[UUID_LEN]; > } VhostUserShared; > > -#if defined(_WIN32) && (defined(__x86_64__) || defined(__i386__)) > -# define VU_PACKED __attribute__((gcc_struct, packed)) > -#else > -# define VU_PACKED __attribute__((packed)) > -#endif > +#define VU_PACKED __attribute__((packed)) > > typedef struct VhostUserMsg { > int request; Acked-by: Michael S. Tsirkin > -- > 2.39.5

Re: [PATCH v4 17/32] system/qtest: properly feedback results of clock_[step|set]

2025-01-13 Thread Michael Tokarev
13.01.2025 19:26, Alex Bennée wrote: Michael Tokarev writes: Ghrm. 46 recipients seems to be quite a bit too aggressive.. I think git-publish just accumulates Cc's from each run for a given branch. While I can reset the version counter I'm not sure where I can reset the Cc list

Re: [PATCH v4 17/32] system/qtest: properly feedback results of clock_[step|set]

2025-01-13 Thread Michael Tokarev
Ghrm. 46 recipients seems to be quite a bit too aggressive.. 08.01.2025 15:10, Alex Bennée wrote: Time will not advance if the system is paused or there are no timer events set for the future. In absence of pending timer events advancing time would make no difference the system state. Attempting

Re: [PATCH v3 3/7] migration: Fix parsing of s390 stream

2025-01-13 Thread Michael Tokarev
13.01.2025 16:03, Fabiano Rosas wrote: Michael Tokarev writes: 13.01.2025 11:19, Thomas Huth wrote: On 13/01/2025 08.51, Michael Tokarev wrote: Picked up:   1/7 migration: Add more error handling to analyze-migration.py   3/7 migration: Fix parsing of s390 stream   7/7 s390x: Fix CSS

Re: [PATCH v3 3/7] migration: Fix parsing of s390 stream

2025-01-13 Thread Michael Tokarev
13.01.2025 11:19, Thomas Huth wrote: On 13/01/2025 08.51, Michael Tokarev wrote: Picked up:   1/7 migration: Add more error handling to analyze-migration.py   3/7 migration: Fix parsing of s390 stream   7/7 s390x: Fix CSS migration but still getting the same error:   https://gitlab.com

Re: [PATCH v3 3/7] migration: Fix parsing of s390 stream

2025-01-12 Thread Michael Tokarev
13.01.2025 09:39, Thomas Huth wrote: On 12/01/2025 15.29, Michael Tokarev wrote: # starting QEMU: exec ./qemu-system-s390x -qtest unix:/tmp/ qtest-1137270.sock -qtest-log /dev/null -chardev socket,path=/tmp/ qtest-1137270.qmp,id=char0 -mon chardev=char0,mode=control -display none - audio none

Re: [PATCH v3 7/7] s390x: Fix CSS migration

2025-01-12 Thread Michael Tokarev
09.01.2025 21:52, Fabiano Rosas wrote: Commit a55ae46683 ("s390: move css_migration_enabled from machine to css.c") disabled CSS migration globally instead of doing it per-instance. CC: Paolo Bonzini CC: qemu-sta...@nongnu.org #9.1 Or should it be applied to 9.1 ONLY, but not to 9.2? /mjt

Re: [PATCH v3 7/7] s390x: Fix CSS migration

2025-01-12 Thread Michael Tokarev
09.01.2025 21:52, Fabiano Rosas wrote: Commit a55ae46683 ("s390: move css_migration_enabled from machine to css.c") disabled CSS migration globally instead of doing it per-instance. CC: Paolo Bonzini CC: qemu-sta...@nongnu.org #9.1 Fixes: a55ae46683 ("s390: move css_migration_enabled from machi

Re: [PATCH v3 3/7] migration: Fix parsing of s390 stream

2025-01-12 Thread Michael Tokarev
12.01.2025 16:06, Michael Tokarev wrote: 09.01.2025 21:52, Fabiano Rosas wrote: The parsing for the S390StorageAttributes section is currently leaving an unconsumed token that is later interpreted by the generic code as QEMU_VM_EOF, cutting the parsing short. The migration will issue a

Re: [PATCH 0/3] bugfixes for migration using compression methods

2025-01-12 Thread Michael Tokarev
18.12.2024 12:14, Yuan Liu wrote: This set of patches is used to fix the bugs of incorrect migration memory data when compression is enabled. The method to reproduce this bug is as follows 1. Run "stress-ng --class memory --all 1" in the source side, the stress-ng tool comes from https://github.

Re: [PATCH v3 3/7] migration: Fix parsing of s390 stream

2025-01-12 Thread Michael Tokarev
09.01.2025 21:52, Fabiano Rosas wrote: The parsing for the S390StorageAttributes section is currently leaving an unconsumed token that is later interpreted by the generic code as QEMU_VM_EOF, cutting the parsing short. The migration will issue a STATTR_FLAG_DONE between iterations, which the scr

Re: [PATCH] migration/multifd: Fix compile error caused by page_size usage

2025-01-12 Thread Michael Tokarev
03.12.2024 15:49, Shameer Kolothum via wrote: From Commit 90fa121c6c07 ("migration/multifd: Inline page_size and page_count") onwards page_size is not part of MutiFD*Params but uses an inline constant instead. However, it missed updating an old usage, causing a compile error. Fixes: 90fa121c6c

Re: [RFC]: port of embedded x86-mini disassembler to QEMU

2025-01-10 Thread Michael Clark
On 1/11/25 05:05, Paolo Bonzini wrote: Il ven 10 gen 2025, 14:03 Michael Clark ha scritto: On 1/11/25 00:07, Paolo Bonzini wrote: Il ven 10 gen 2025, 10:52 Michael Clark ha scritto: a note to announce a port of the x86-mini disassembler to QEMU. -https://github.com/michaeljclark/qemu/tree

Re: [RFC]: port of embedded x86-mini disassembler to QEMU

2025-01-10 Thread Michael Clark
On 1/11/25 05:05, Paolo Bonzini wrote: Il ven 10 gen 2025, 14:03 Michael Clark ha scritto: On 1/11/25 00:07, Paolo Bonzini wrote: Il ven 10 gen 2025, 10:52 Michael Clark ha scritto: a note to announce a port of the x86-mini disassembler to QEMU. - https://github.com/michaeljclark/qemu

Re: [RFC]: port of embedded x86-mini disassembler to QEMU

2025-01-10 Thread Michael Clark
On 1/11/25 00:07, Paolo Bonzini wrote: Il ven 10 gen 2025, 10:52 Michael Clark ha scritto: a note to announce a port of the x86-mini disassembler to QEMU. - https://github.com/michaeljclark/qemu/tree/x86-mini I assume the huge .h files are autogenerated? If so, QEMU cannot use them without

  1   2   3   4   5   6   7   8   9   10   >