Re: [PATCH] pc-bios/s390-ccw: link statically

2025-06-10 Thread Michael Tokarev
On 10.06.2025 23:36, Sertonix wrote: On Tue Jun 10, 2025 at 10:32 PM CEST, Michael Tokarev wrote: On 10.06.2025 20:58, Sertonix wrote: Adding -pie to LDFLAGS caused s390-ccw.img to become dynamically linked. Why do you think -pie causes it to become dynamically linked? /mjt The

Re: [PATCH] pc-bios/s390-ccw: link statically

2025-06-10 Thread Michael Tokarev
On 10.06.2025 20:58, Sertonix wrote: Adding -pie to LDFLAGS caused s390-ccw.img to become dynamically linked. Why do you think -pie causes it to become dynamically linked? /mjt

Re: [PATCH V5.1] pci: skip reset during cpr

2025-06-10 Thread Michael S. Tsirkin
On Tue, Jun 10, 2025 at 10:26:43AM -0700, Steve Sistare wrote: > Do not reset a vfio-pci device during CPR. > > Signed-off-by: Steve Sistare Acked-by: Michael S. Tsirkin > --- > hw/pci/pci.c | 5 + > hw/vfio/pci.c| 7 +++ > include/hw/pci/pc

Re: [PATCH v5 2/7] ui/spice: Add an option for users to provide a preferred codec

2025-06-10 Thread Michael Scherle
s the standard mjpeg encoder ? Alternatively we could just go with mjpeg, vp8, vp9, h264 and in the unlikely event we need to be able to skip the built-in mjpeg, we could add a boolean 'prefer-gstreamer=on|off' With regards, Daniel Greetings, Michael

Re: [PATCH V4 16/43] pci: skip reset during cpr

2025-06-10 Thread Michael S. Tsirkin
; > pci_dev->cap_present can be modified at realize time. skip_reset_on_cpr > is a constant, for which a class attribute are more appropriate. > This is minor. > > Michael, > > Are you ok with the 'skip_reset_on_cpr' bool ? Generally yes, b

Re: [PATCH] virtio: avoid cost of -ftrivial-auto-var-init in hot path

2025-06-10 Thread Michael S. Tsirkin
On Wed, Jun 04, 2025 at 03:18:43PM -0400, Stefan Hajnoczi wrote: > Since commit 7ff9ff039380 ("meson: mitigate against use of uninitialize > stack for exploits") the -ftrivial-auto-var-init=zero compiler option is > used to zero local variables. While this reduces security risks > associated with u

Re: [PATCH 1/1] vhost: do not reset used_memslots when destroying vhost dev

2025-06-10 Thread Michael S. Tsirkin
On Tue, Jun 03, 2025 at 11:15:18AM +0200, David Hildenbrand wrote: > On 30.05.25 13:36, Michael S. Tsirkin wrote: > > On Fri, May 30, 2025 at 01:28:58PM +0200, David Hildenbrand wrote: > > > On 30.05.25 13:18, Michael S. Tsirkin wrote: > > > > On Wed, May 14, 2

Re: [PATCH v2 0/7] audio related fixes for 10.1

2025-06-05 Thread Michael Tokarev
On 29.05.2025 10:26, Michael Tokarev wrote: On 15.05.2025 08:42, Volker Rümelin wrote: A few audio related fixes for 10.1. The virtio-sound device is the first QEMU audio front end that supports floating point samples. The audio subsystem is only partially prepared for this. The commit

ppc kvm: support of 64K guest page size with 4K host pagesize?

2025-06-04 Thread Michael Tokarev
There's a bug report filed in debian against qemu, https://bugs.debian.org/1107288 - saying kvm on ppc does not work on debian (anymore) due to qemu requesting unrealistic (non-existing) page size of 64K on a host which only has 4K. I don't know much about PPC, - what's the issue here? Should qem

Re: [PATCH v5] target/loongarch: fix vldi/xvldi raise wrong error

2025-06-04 Thread Michael Tokarev
On 04.06.2025 11:40, Song Gao wrote: +static bool check_vldi_mode(arg_vldi *a) +{ + return (a->imm >>8 & 0xf) <= 12; +} static bool gen_vldi(DisasContext *ctx, arg_vldi *a, uint32_t oprsz) { An empty line can be added here between two functions during patch apply ;) /mjt

Re: apparent race condition in mttcg memory handling

2025-06-04 Thread Michael Tokarev
Here's a typical output with ASan enabled, fwiw: $ ./qemu-system-x86_64 -smp 16 -m 256 -vga none -display none -kernel /boot/vmlinuz-6.12.29-amd64 -append "console=ttyS0" -serial file:/dev/tty -monitor stdio -initrd ~/debvm/initrd ==368707==WARNING: ASan doesn't fully support makecontext/swapco

Re: [PATCH 0/2] hw/nvme: stable fixes

2025-06-04 Thread Michael Tokarev
On 03.06.2025 15:59, Klaus Jensen wrote: Two fixes for stable. See commits. What do you mean "for stable"? Are these not for master but for stable *only*? Usually changes for qemu-stable are picked up *from* master branch, unless there are major changes in stable already. Thanks, /mjt

Re: [PATCH v4] target/loongarch: fix vldi/xvldi raise wrong error

2025-06-03 Thread Michael Tokarev
03.06.2025 11:25, Song Gao wrote: on qemu we got an aborted error ** ERROR:../target/loongarch/tcg/insn_trans/trans_vec.c.inc:3574:vldi_get_value: code should not be reached Bail out! ERROR:../target/loongarch/tcg/insn_trans/trans_vec.c.inc:3574:vldi_get_value: code should not be reached Abort

Re: [PULL 00/31] virtio,pci,pc: features, fixes, tests

2025-06-02 Thread Michael S. Tsirkin
On Mon, Jun 02, 2025 at 02:31:19PM -0400, Michael S. Tsirkin wrote: > On Mon, Jun 02, 2025 at 02:25:48PM -0400, Stefan Hajnoczi wrote: > > On Mon, Jun 2, 2025 at 1:54 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Jun 02, 2025 at 12:39:17PM -0400, Stefan Hajnoczi w

Re: [PATCH v3 0/2] amd_iommu: Fixes

2025-06-02 Thread Michael Tokarev
On 16.05.2025 13:05, Sairaj Kodilkar wrote: Fix following two issues in the amd viommu 1. The guest fails to setup the passthrough device when for following setup because amd iommu enables the no DMA memory region even when guest is using DMA remapping mode. -device amd-iommu,intrem

Re: [PULL 00/31] virtio,pci,pc: features, fixes, tests

2025-06-02 Thread Michael S. Tsirkin
On Mon, Jun 02, 2025 at 02:25:48PM -0400, Stefan Hajnoczi wrote: > On Mon, Jun 2, 2025 at 1:54 PM Michael S. Tsirkin wrote: > > > > On Mon, Jun 02, 2025 at 12:39:17PM -0400, Stefan Hajnoczi wrote: > > > On Sun, Jun 1, 2025 at 11:34 AM Michael S. Tsirkin > >

Re: [PULL 00/31] virtio,pci,pc: features, fixes, tests

2025-06-02 Thread Michael S. Tsirkin
On Mon, Jun 02, 2025 at 12:39:17PM -0400, Stefan Hajnoczi wrote: > On Sun, Jun 1, 2025 at 11:34 AM Michael S. Tsirkin wrote: > > > > The following changes since commit d2e9b78162e31b1eaf20f3a4f563da82da56908d: > > > > Merge tag 'pull-qapi-2025-05-28' o

Re: [PULL 00/31] virtio,pci,pc: features, fixes, tests

2025-06-02 Thread Michael S. Tsirkin
On Sun, Jun 01, 2025 at 11:24:45AM -0400, Michael S. Tsirkin wrote: > The following changes since commit d2e9b78162e31b1eaf20f3a4f563da82da56908d: > > Merge tag 'pull-qapi-2025-05-28' of https://repo.or.cz/qemu/armbru into > staging (2025-05-29 08:36:01 -0400) > &

Re: [PATCH V4 16/43] pci: skip reset during cpr

2025-06-01 Thread Michael S. Tsirkin
On Sun, Jun 01, 2025 at 06:38:43PM +0200, Cédric Le Goater wrote: > On 5/29/25 21:24, Steve Sistare wrote: > > Do not reset a vfio-pci device during CPR. > > > > Signed-off-by: Steve Sistare > > --- > > include/hw/pci/pci_device.h | 3 +++ > > hw/pci/pci.c| 5 + > > hw/vfi

[PULL 15/31] uefi-test-tools:: Add LoongArch64 support

2025-06-01 Thread Michael S. Tsirkin
From: Bibo Mao Add support to build bios-tables-test iso image for LoongArch system. Signed-off-by: Bibo Mao Acked-by: Gerd Hoffmann Message-Id: <20250520130158.767083-2-maob...@loongson.cn> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/uefi-test

[PULL 20/31] rebuild-expected-aml.sh: Add support for LoongArch

2025-06-01 Thread Michael S. Tsirkin
From: Bibo Mao Update the list of supported architectures to include LoongArch. Signed-off-by: Bibo Mao Message-Id: <20250520130158.767083-7-maob...@loongson.cn> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/data/acpi/rebuild-expected-aml.sh | 4 ++--

[PULL 14/31] pci: Add a PCI-level API for PRI

2025-06-01 Thread Michael S. Tsirkin
Message-Id: <20250520071823.764266-12-clement.mathieu--d...@eviden.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pci.h | 130 +++ hw/pci/pci.c | 66 ++ 2 files changed, 196 inse

[PULL 13/31] pci: Add a pci-level API for ATS

2025-06-01 Thread Michael S. Tsirkin
: Clement Mathieu--Drif Co-authored-by: Ethan Milon Message-Id: <20250520071823.764266-11-clement.mathieu--d...@eviden.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pci.h | 126 +++ hw/pci/pci.c

[PULL 08/31] pcie: Helper functions to check to check if PRI is enabled

2025-06-01 Thread Michael S. Tsirkin
From: CLEMENT MATHIEU--DRIF pri_enabled can be used to check whether the capability is present and enabled on a PCIe device Signed-off-by: Clement Mathieu--Drif Message-Id: <20250520071823.764266-6-clement.mathieu--d...@eviden.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Mic

[PULL 01/31] virtio: check for validity of indirect descriptors

2025-06-01 Thread Michael S. Tsirkin
From: Yuri Benditovich virtio processes indirect descriptors even if the respected feature VIRTIO_RING_F_INDIRECT_DESC was not negotiated. If qemu is used with reduced set of features to emulate the hardware device that does not support indirect descriptors, the will probably trigger problematic

[PULL 06/31] pcie: Helper function to check if ATS is enabled

2025-06-01 Thread Michael S. Tsirkin
com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie.h | 1 + hw/pci/pcie.c | 9 + 2 files changed, 10 insertions(+) diff --git a/include/hw/pci/pcie.h b/include/hw/pci/pcie.h index dff98ff2c6..497d0bc2d2 100644 --- a/include/hw/pci/pcie.h

[PULL 04/31] pcie: Add helper to declare PASID capability for a pcie device

2025-06-01 Thread Michael S. Tsirkin
From: CLEMENT MATHIEU--DRIF Signed-off-by: Clement Mathieu--Drif Message-Id: <20250520071823.764266-2-clement.mathieu--d...@eviden.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie.h | 6 +- include/hw/pci/pcie_regs.h | 5 +

[PULL 05/31] pcie: Helper functions to check if PASID is enabled

2025-06-01 Thread Michael S. Tsirkin
com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie.h | 2 ++ hw/pci/pcie.c | 9 + 2 files changed, 11 insertions(+) diff --git a/include/hw/pci/pcie.h b/include/hw/pci/pcie.h index fe82e0a915..dff98ff2c6 100644 --- a/include/hw/pci/pcie.h

[PULL 07/31] pcie: Add a helper to declare the PRI capability for a pcie device

2025-06-01 Thread Michael S. Tsirkin
From: CLEMENT MATHIEU--DRIF Signed-off-by: Clement Mathieu--Drif Message-Id: <20250520071823.764266-5-clement.mathieu--d...@eviden.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie.h | 5 - include/hw/pci/pcie_regs.h | 3 +++

[PULL 21/31] tests/acpi: Fill acpi table data for LoongArch

2025-06-01 Thread Michael S. Tsirkin
From: Bibo Mao The acpi table data is filled for LoongArch virt machine with the following command: tests/data/acpi/rebuild-expected-aml.sh Signed-off-by: Bibo Mao Message-Id: <20250520130806.767181-1-maob...@loongson.cn> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. T

[PULL 03/31] hw/i386/amd_iommu: Fix xtsup when vcpus < 255

2025-06-01 Thread Michael S. Tsirkin
From: Vasant Hegde If vCPUs > 255 then x86 common code (x86_cpus_init()) call kvm_enable_x2apic(). But if vCPUs <= 255 then the common code won't calls kvm_enable_x2apic(). This is because commit 8c6619f3e692 ("hw/i386/amd_iommu: Simplify non-KVM checks on XTSup feature") removed the call to kvm

[PULL 09/31] pci: Cache the bus mastering status in the device

2025-06-01 Thread Michael S. Tsirkin
ieu--d...@eviden.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pci_device.h | 1 + hw/pci/pci.c| 23 +-- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/include/hw/pci/pci_device.h b/include/

[PULL 24/31] vdpa: check for iova tree initialized at net_client_start

2025-06-01 Thread Michael S. Tsirkin
pal...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- net/vhost-vdpa.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 7ca8b46eee..decb826868 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -366,7

[PULL 00/31] virtio,pci,pc: features, fixes, tests

2025-06-01 Thread Michael S. Tsirkin
no longer set a call notifier if unused loongarch gained acpi tests based on bios-tables-test some core pci work for SVM support in vtd vhost vdpa init has been optimized for response time to QMP A couple more fixes Signed-off-by: Michael

[PULL 30/31] vdpa: move memory listener register to vhost_vdpa_init

2025-06-01 Thread Michael S. Tsirkin
nt) - 128G VM: 14.72s -> 5.83s (-8.89s, ~60% improvement) Tested-by: Lei Yang Reviewed-by: Si-Wei Liu Acked-by: Jason Wang Signed-off-by: Eugenio Pérez Signed-off-by: Jonah Palmer Message-Id: <20250522145839.59974-8-jonah.pal...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-

[PULL 31/31] hw/i386/pc_piix: Fix RTC ISA IRQ wiring of isapc machine

2025-06-01 Thread Michael S. Tsirkin
the isapc machine. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2961 Fixes: 56b1f50e3c10 ("hw/i386/pc: Wire RTC ISA IRQs in south bridges") cc: qemu-stable Signed-off-by: Bernhard Beschow Reviewed-by: Mark Cave-Ayland Message-Id: <20250526203820.1853-1-shen...@gmail.com&

[PULL 28/31] vdpa: reorder listener assignment

2025-06-01 Thread Michael S. Tsirkin
y: Jason Wang Signed-off-by: Eugenio Pérez Signed-off-by: Jonah Palmer Message-Id: <20250522145839.59974-6-jonah.pal...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost-vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PULL 12/31] pci: Add a pci-level initialization function for IOMMU notifiers

2025-06-01 Thread Michael S. Tsirkin
From: CLEMENT MATHIEU--DRIF This is meant to be used by ATS-capable devices. Signed-off-by: Clement Mathieu--Drif Message-Id: <20250520071823.764266-10-clement.mathieu--d...@eviden.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pci.

[PULL 26/31] vdpa: set backend capabilities at vhost_vdpa_init

2025-06-01 Thread Michael S. Tsirkin
Acked-by: Jason Wang Signed-off-by: Eugenio Pérez Signed-off-by: Jonah Palmer Message-Id: <20250522145839.59974-4-jonah.pal...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost-vdpa.c | 7 ++- 1 file changed, 6 insertions(+), 1 de

[PULL 18/31] tests/acpi: Add empty ACPI data files for LoongArch

2025-06-01 Thread Michael S. Tsirkin
From: Bibo Mao Add empty acpi table for LoongArch virt machine, it is only empty file and there is no data in these files. Signed-off-by: Bibo Mao Message-Id: <20250520130158.767083-5-maob...@loongson.cn> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtes

[PULL 29/31] vdpa: move iova_tree allocation to net_vhost_vdpa_init

2025-06-01 Thread Michael S. Tsirkin
: <20250522145839.59974-7-jonah.pal...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/vhost-vdpa.h | 16 ++- net/vhost-vdpa.c | 36 +++--- 2 files changed, 18 insertions(+), 34 deletions(-) diff -

[PULL 17/31] tests/qtest/bios-tables-test: Use MiB macro rather hardcode value

2025-06-01 Thread Michael S. Tsirkin
From: Bibo Mao Replace 1024 * 1024 with MiB macro. Signed-off-by: Bibo Mao Message-Id: <20250520130158.767083-4-maob...@loongson.cn> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test.c | 20 ++-- 1 file changed, 10 inse

[PULL 10/31] pci: Add an API to get IOMMU's min page size and virtual address width

2025-06-01 Thread Michael S. Tsirkin
From: CLEMENT MATHIEU--DRIF This kind of information is needed by devices implementing ATS in order to initialize their translation cache. Signed-off-by: Clement Mathieu--Drif Message-Id: <20250520071823.764266-8-clement.mathieu--d...@eviden.com> Reviewed-by: Michael S. Tsirkin Signed-

[PULL 27/31] vdpa: add listener_registered

2025-06-01 Thread Michael S. Tsirkin
pal...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/vhost-vdpa.h | 6 ++ hw/virtio/vhost-vdpa.c | 7 ++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h

[PULL 23/31] vhost: Don't set vring call if guest notifier is unused

2025-06-01 Thread Michael S. Tsirkin
upt handling. Fixes: 96a3d98d2c("vhost: don't set vring call if no vector") Reported-by: Zhiyuan Yuan Signed-off-by: Jidong Xia Signed-off-by: Huaitong Han Message-Id: <20250522100548.212740-1-han...@chinatelecom.cn> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[PULL 22/31] tests/acpi: Remove stale allowed tables

2025-06-01 Thread Michael S. Tsirkin
From: Bibo Mao Remove stale allowed tables for LoongArch virt machine. Signed-off-by: Bibo Mao Message-Id: <20250520130806.767181-2-maob...@loongson.cn> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 8

[PULL 25/31] vdpa: reorder vhost_vdpa_set_backend_cap

2025-06-01 Thread Michael S. Tsirkin
From: Eugenio Pérez It will be used directly by vhost_vdpa_init. Tested-by: Lei Yang Reviewed-by: Si-Wei Liu Acked-by: Jason Wang Signed-off-by: Eugenio Pérez Signed-off-by: Jonah Palmer Message-Id: <20250522145839.59974-3-jonah.pal...@oracle.com> Reviewed-by: Michael S. Tsirkin

[PULL 19/31] tests/qtest/bios-tables-test: Add basic testing for LoongArch

2025-06-01 Thread Michael S. Tsirkin
From: Bibo Mao Add basic ACPI table test case for LoongArch, including cpu topology, numa memory, memory hotplug and oem-id test cases. Signed-off-by: Bibo Mao Message-Id: <20250520130158.767083-6-maob...@loongson.cn> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. T

[PULL 11/31] memory: Store user data pointer in the IOMMU notifiers

2025-06-01 Thread Michael S. Tsirkin
From: CLEMENT MATHIEU--DRIF This will help developers of ATS-capable devices to track a state. Signed-off-by: Clement Mathieu--Drif Message-Id: <20250520071823.764266-9-clement.mathieu--d...@eviden.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/

[PULL 16/31] tests/data/uefi-boot-images: Add ISO image for LoongArch system

2025-06-01 Thread Michael S. Tsirkin
Message-Id: <20250520130158.767083-3-maob...@loongson.cn> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- .../bios-tables-test.loongarch64.iso.qcow2 | Bin 0 -> 12800 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 tests/data/uefi-boot-im

[PULL 02/31] hw/i386/amd_iommu: Fix device setup failure when PT is on.

2025-06-01 Thread Michael S. Tsirkin
From: Sairaj Kodilkar Commit c1f46999ef506 ("amd_iommu: Add support for pass though mode") introduces the support for "pt" flag by enabling nodma memory when "pt=off". This allowed VFIO devices to successfully register notifiers by using nodma region. But, This also broke things when guest is bo

Re: [PATCH v5 0/4] Building PPTT with root node and identical implementation flag

2025-06-01 Thread Michael S. Tsirkin
On Fri, May 23, 2025 at 11:26:50AM +0100, Alireza Sanaee wrote: > OS like Linux is using PPTT processor node's identical implementation > flag [1] to infer whether the whole system or a certain CPU cluster is > homogeneous or not [2]. QEMU currently only support building homogeneous > system, set t

Re: [PATCH v2] virtio-net: Fix the interpretation of max_tx_vq

2025-06-01 Thread Michael S. Tsirkin
On Sat, Mar 22, 2025 at 03:47:17PM +0900, Akihiko Odaki wrote: > virtio-net uses the max_tx_vq field of struct virtio_net_rss_config to > determine the number of queue pairs and emits an error message saying > "Can't get queue_pairs". However, the field tells only about tx. > > Examine unclassifie

[PATCH 04/27] qemu-img: pass current cmd info into command handlers

2025-05-31 Thread Michael Tokarev
This info will be used to generate --help output. Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé Reviewed-by: Kevin Wolf --- qemu-img.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index

[PATCH 20/27] qemu-img: resize: refresh options/--help

2025-05-31 Thread Michael Tokarev
Add missing long options and --help output, reorder options for consistency. Signed-off-by: Michael Tokarev --- qemu-img.c | 52 1 file changed, 36 insertions(+), 16 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index f655c301af

Re: [PATCH 0/9] qom: Consolidate OBJECT_{DEFINE|DECLARE}_SIMPLE_TYPE*

2025-05-31 Thread Michael Tokarev
On 14.05.2025 11:49, Zhao Liu wrote: Hi, When I read the qom doc (qom.rst) about OBJECT_DECLARE_SIMPLE_TYPE, I found there's the wrong example. So I tried to fix the doc and cleaned up the relevant code case to correctly show that for simple type, the class definition is not needed. This series

Re: [PATCH v3 0/4] qapi: add auto-generated return docs

2025-05-31 Thread Michael Tokarev
On 23.05.2025 21:24, John Snow wrote: v3: rebased on top of python-qapi-linting (v4) pull request; removed commits that are no longer needed. Markus: I forget where we left off... shall we refresh? v2: fix multi-return-sections bug :( John Snow (4): docs/qapi-domain: add return-nod

[PATCH 25/27] qemu-img: measure: refresh options/--help

2025-05-31 Thread Michael Tokarev
Add missing long options and --help output, reorder options for consistency. Also add -s short option for --size (and remove OPTION_SIZE). Signed-off-by: Michael Tokarev --- qemu-img.c | 89 +- 1 file changed, 62 insertions(+), 27 deletions

[PATCH 09/27] qemu-img: commit: refresh options/--help

2025-05-31 Thread Michael Tokarev
Add missing long options and --help output, reorder options for consistency. Signed-off-by: Michael Tokarev --- qemu-img.c | 68 ++ 1 file changed, 48 insertions(+), 20 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index c8ce206b73

[PATCH 03/27] qemu-img: global option processing and error printing

2025-05-31 Thread Michael Tokarev
sequent changes command by command, with main() done last. unrecognized_option() and missing_argument() functions prototypes aren't changed by this patch, since they're called from many places and will be removed a few patches later. Only

[PATCH 17/27] qemu-img: snapshot: refresh options/--help

2025-05-31 Thread Michael Tokarev
Add missing long options and --help output, reorder options for consistency. Signed-off-by: Michael Tokarev --- qemu-img.c | 60 +++--- 1 file changed, 44 insertions(+), 16 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 8fbf0c67a7

[PATCH 02/27] qemu-img: create: convert img_size to signed, simplify handling

2025-05-31 Thread Michael Tokarev
Initializing an unsigned as -1, or using temporary sval for conversion is awkward. Since we don't allow other "negative" values anyway, use signed value and pass it to bdrv_img_create() (where it is properly converted to unsigned), simplifying code. Signed-off-by: Michael Tokar

[PATCH 06/27] qemu-img: factor out parse_output_format() and use it in the code

2025-05-31 Thread Michael Tokarev
Use common code and simplify error message Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé Reviewed-by: Kevin Wolf --- qemu-img.c | 63 -- 1 file changed, 18 insertions(+), 45 deletions(-) diff --git a/qemu-img.c b/qemu-img.c

[PATCH 08/27] qemu-img: simplify --repair error message

2025-05-31 Thread Michael Tokarev
Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- qemu-img.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 2129158c13..c8ce206b73 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -864,8 +864,9 @@ static int img_check(const

[PATCH 26/27] qemu-img: implement short --help, remove global help() function

2025-05-31 Thread Michael Tokarev
unrecognized_option() are now unused, remove them. Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- qemu-img.c | 210 ++--- 1 file changed, 72 insertions(+), 138 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 44212de3f6..18f7ba07c9

[PATCH 24/27] qemu-img: dd: refresh options/--help

2025-05-31 Thread Michael Tokarev
Add missing long options and --help output, reorder options for consistency. Signed-off-by: Michael Tokarev --- qemu-img.c | 50 -- 1 file changed, 36 insertions(+), 14 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 97ce51a1c3

[PATCH 22/27] qemu-img: bench: refresh options/--help

2025-05-31 Thread Michael Tokarev
Add missing long options and --help output, reorder options for consistency. Add missing --object option. Signed-off-by: Michael Tokarev --- qemu-img.c | 112 +++-- 1 file changed, 84 insertions(+), 28 deletions(-) diff --git a/qemu-img.c b/qemu

[PATCH 18/27] qemu-img: rebase: refresh options/--help (short option change)

2025-05-31 Thread Michael Tokarev
file (was eg CACHE vs SRC_CACHE, which is unclear). Probably should rename local variables. Signed-off-by: Michael Tokarev --- docs/tools/qemu-img.rst | 2 +- qemu-img.c | 88 + 2 files changed, 64 insertions(+), 26 deletions(-) diff --git a

[PATCH 19/27] qemu-img: resize: do not always eat last argument

2025-05-31 Thread Michael Tokarev
is not handled right is when there's an option between filename and size, and size is given as decrement, - in this case -size will be treated as option, not as size. Signed-off-by: Michael Tokarev --- qemu-img.c | 41 +++-- 1 file changed, 27 insertions(

[PATCH 10/27] qemu-img: compare: use helper function for --object

2025-05-31 Thread Michael Tokarev
Use the same function to parse --object as used by all other qemu-img subcommands. Signed-off-by: Michael Tokarev --- qemu-img.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 5e651e8089..c24e1fb455 100644 --- a/qemu-img.c

[PATCH 14/27] qemu-img: map: refresh options/--help

2025-05-31 Thread Michael Tokarev
Add missing long options and --help output, reorder options for consistency. While at it, remove unused option_index variable. Signed-off-by: Michael Tokarev --- qemu-img.c | 57 ++ 1 file changed, 36 insertions(+), 21 deletions(-) diff

[PATCH 23/27] qemu-img: bitmap: refresh options/--help

2025-05-31 Thread Michael Tokarev
Add missing long options and --help output, reorder options for consistency. Signed-off-by: Michael Tokarev --- qemu-img.c | 80 ++ 1 file changed, 56 insertions(+), 24 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 5011ec5fce

[PATCH 27/27] qemu-img: extend cvtnum() and use it in more places

2025-05-31 Thread Michael Tokarev
ve allowed size suffixes from the error message as it makes no sense most of the time (should be in help instead). Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- qemu-img.c | 111 + tests/qemu-iotests/049.out | 9 +-

[PATCH 07/27] qemu-img: check: refresh options/--help

2025-05-31 Thread Michael Tokarev
Add missing long options and --help output, reorder options for consistency. Signed-off-by: Michael Tokarev --- qemu-img.c | 60 +- 1 file changed, 41 insertions(+), 19 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index a26498a4e8

[PATCH 11/27] qemu-img: compare: refresh options/--help

2025-05-31 Thread Michael Tokarev
Add long options, add help, reorder options for consistency. Signed-off-by: Michael Tokarev --- qemu-img.c | 64 +++--- 1 file changed, 46 insertions(+), 18 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index c24e1fb455..70573b79b5 100644

[PATCH 01/27] qemu-img: measure: convert img_size to signed, simplify handling

2025-05-31 Thread Michael Tokarev
qemu_opt_set_number() expects signed int64_t. Use int64_t instead of uint64_t for img_size, use -1 as "unset" value instead of UINT64_MAX, and do not require temporary sval for conversion from string. Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé Reviewed-by:

[PATCH 21/27] qemu-img: amend: refresh options/--help

2025-05-31 Thread Michael Tokarev
Add missing long options and --help output, reorder options for consistency. Signed-off-by: Michael Tokarev --- qemu-img.c | 54 +++--- 1 file changed, 39 insertions(+), 15 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 3dbfce527b

[PATCH 13/27] qemu-img: info: refresh options/--help

2025-05-31 Thread Michael Tokarev
Add missing long options and --help output. Also add -b short option for --backing-chain, and remove now-unused OPTION_BACKING_CHAIN. Reorder options for consistency. While at it, remove unused option_index variable. Signed-off-by: Michael Tokarev --- qemu-img.c | 54

[PATCH 12/27] qemu-img: convert: refresh options/--help (short option change)

2025-05-31 Thread Michael Tokarev
Add missing long options and --help output. Reorder options for consistency. Use -b for --backing, and recognize -B for backwards compatibility. Unfortunately we can't use -B to specify backing format. Signed-off-by: Michael Tokarev --- docs/tools/qemu-img.rst | 2 +- qemu-

[PATCH 16/27] qemu-img: snapshot: make -l (list) the default, simplify option handling

2025-05-31 Thread Michael Tokarev
-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- docs/tools/qemu-img.rst | 2 +- qemu-img.c | 52 ++--- 2 files changed, 19 insertions(+), 35 deletions(-) diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst index 935f28bbc5

[PATCH 15/27] qemu-img: snapshot: allow specifying -f fmt

2025-05-31 Thread Michael Tokarev
For consistency with other commands, and since it already accepts --image-opts, allow specifying -f fmt too. Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- docs/tools/qemu-img.rst | 2 +- qemu-img-cmds.hx| 4 ++-- qemu-img.c | 9 ++--- 3 files

[PATCH 05/27] qemu-img: create: refresh options/--help (short option change)

2025-05-31 Thread Michael Tokarev
onsistency. Remove usage of missing_argument()/unrecognized_option() in img_create(). Signed-off-by: Michael Tokarev --- docs/tools/qemu-img.rst | 10 ++--- qemu-img.c | 84 + 2 files changed, 73 insertions(+), 21 deletions(-) diff --git a/docs/

[PATCH v4 00/27] refresh qemu-img options handling

2025-05-31 Thread Michael Tokarev
t to the common (before-subcomman) place, document it there, and remove the --object mentions from individual commands --help output. Thanks, /mjt Michael Tokarev (27): qemu-img: measure: convert img_size to signed, simplify handling qemu-img: create: convert img_size to signed, simplify handl

Re: [PATCH 07/27] qemu-img: check: refresh options/--help

2025-05-31 Thread Michael Tokarev
On 13.05.2025 18:54, Kevin Wolf wrote: Am 27.09.2024 um 08:11 hat Michael Tokarev geschrieben: Add missing long options and --help output. ... +" --image-opts\n" +" indicates that FILENAME is a complete image specification\n" +" instead of a file name (inco

apparent race condition in mttcg memory handling

2025-05-30 Thread Michael Tokarev
Hi! For quite some time (almost whole day yesterday) I'm trying to find out what's going on with mmtcg in qemu. There's apparently a race condition somewhere, like a use-after-free or something. It started as an incarnation of https://gitlab.com/qemu-project/qemu/-/issues/1921 -- the same asser

Re: [PATCH v3 0/4] qapi: add auto-generated return docs

2025-05-30 Thread Michael S. Tsirkin
My bits: Acked-by: Michael S. Tsirkin feel free to merge > John Snow (4): > docs/qapi-domain: add return-nodesc > docs, qapi: generate undocumented return sections > qapi: remove trivial "Returns:" sections > qapi: rephrase return docs to avoid type na

Re: [PATCH 0/9] ui: Improve scale handling

2025-05-30 Thread Michael Tokarev
Hi! Thank you for your attention! On 30.05.2025 09:39, Weifeng Liu wrote: On Thu, 2025-05-29 at 10:23 +0300, Michael Tokarev wrote: Is there anything here which should be picked up for qemu-stable (current active branches: 7.2 and 10.0)? I think the first five patches are good candidates

Re: [PATCH REPOST v4 0/4] acpi: Add machine option to disable SPCR table

2025-05-30 Thread Michael S. Tsirkin
the first patch and > fix style issue. > > Changes since v1: > - Add bios-tables-test for RISC-V and ARM as suggested by > - Add Acked-by from Michael S. Tsirkin for the first patch > - Add Reviewed-by from Bibo Mao for the first patch > > Li Chen (4): > acpi: Add

Re: [PATCH v9 12/20] acpi/generic_event_device: add logic to detect if HEST addr is available

2025-05-30 Thread Michael S. Tsirkin
On Wed, May 28, 2025 at 05:42:12PM +0200, Igor Mammedov wrote: > On Tue, 20 May 2025 08:41:31 +0200 > Mauro Carvalho Chehab wrote: > > > Create a new property (x-has-hest-addr) and use it to detect if > > the GHES table offsets can be calculated from the HEST address > > (qemu 10.0 and upper) or

Re: [PATCH v11 0/6] Specifying cache topology on ARM

2025-05-30 Thread Michael S. Tsirkin
On Mon, May 19, 2025 at 04:36:26PM +0100, Alireza Sanaee wrote: > Specifying the cache layout in virtual machines is useful for > applications and operating systems to fetch accurate information about > the cache structure and make appropriate adjustments. Enforcing correct > sharing information ca

Re: [PATCH v4 00/19] hw/i386/pc: Remove deprecated 2.4 and 2.5 PC machines

2025-05-30 Thread Michael S. Tsirkin
On Mon, May 12, 2025 at 10:39:29AM +0200, Philippe Mathieu-Daudé wrote: > (series reviewed) Reviewed-by: Michael S. Tsirkin Thomas, since you wanted to do it, pls feel free to merge. > Since v3: > - Fixed 2 issues noticed by Thomas (floppy fallback, e1000) > > Since v2: >

Re: [PATCH v4 13/19] hw/block/fdc-isa: Remove 'fallback' property

2025-05-30 Thread Michael S. Tsirkin
On Wed, May 28, 2025 at 10:30:17AM +0200, Thomas Huth wrote: > On 27/05/2025 19.20, Thomas Huth wrote: > > On 12/05/2025 10.39, Philippe Mathieu-Daudé wrote: > > > The "fallback" property was only used by the hw_compat_2_5[] array, > > > as 'fallback=144'. We removed all machines using that array,

Re: [PATCH v2 00/20] AMD vIOMMU: DMA remapping support for VFIO devices

2025-05-30 Thread Michael S. Tsirkin
On Fri, May 02, 2025 at 02:15:45AM +, Alejandro Jimenez wrote: > This series adds support for guests using the AMD vIOMMU to enable DMA > remapping for VFIO devices. In addition to the currently supported > passthrough (PT) mode, guest kernels are now able to to provide DMA > address translatio

Re: [PATCH 1/1] vhost: do not reset used_memslots when destroying vhost dev

2025-05-30 Thread Michael S. Tsirkin
On Fri, May 30, 2025 at 01:28:58PM +0200, David Hildenbrand wrote: > On 30.05.25 13:18, Michael S. Tsirkin wrote: > > On Wed, May 14, 2025 at 11:26:05AM +0200, David Hildenbrand wrote: > > > On 14.05.25 11:12, Igor Mammedov wrote: > > > > On Tue, 13 May 202

Re: [PATCH v4 00/27] hw/i386/pc: Remove deprecated 2.6 and 2.7 PC machines

2025-05-30 Thread Michael S. Tsirkin
On Tue, May 13, 2025 at 01:23:38PM +0200, Igor Mammedov wrote: > On Thu, 8 May 2025 15:35:23 +0200 > Philippe Mathieu-Daudé wrote: > > > Since v3: > > - Addressed Thomas and Zhao review comments > > - Rename fw_cfg_init_mem_[no]dma() helpers > > - Remove unused CPU properties > > - Remove {multi

Re: [PATCH 1/1] vhost: do not reset used_memslots when destroying vhost dev

2025-05-30 Thread Michael S. Tsirkin
On Wed, May 14, 2025 at 11:26:05AM +0200, David Hildenbrand wrote: > On 14.05.25 11:12, Igor Mammedov wrote: > > On Tue, 13 May 2025 15:12:11 +0200 > > David Hildenbrand wrote: > > > > > On 13.05.25 14:13, Igor Mammedov wrote: > > > > On Mon, 3 Mar 2025 13:02:17 -0500 > > > > yuanminghao wrote:

Re: [PATCH 0/9] ui: Improve scale handling

2025-05-30 Thread Michael Tokarev
On 30.05.2025 09:39, Weifeng Liu wrote: On Thu, 2025-05-29 at 10:23 +0300, Michael Tokarev wrote: PATCH 3 - 5 fix bugs in mouse position calculation due to not handling scale properly, for both gtk and sdl. PATCH 6 align scale update logic in gtk-egl with other implementations. PATCH 7 fix

Re: [Qemu PATCH v2] hw/cxl: fix DC extent capacity tracking

2025-05-29 Thread Michael S. Tsirkin
to include > > both accepted and pending extents counting. > > > > Signed-off-by: Fan Ni > > Reviewed-by: Jonathan Cameron > > Thanks. Michael, would you mind picking this up directly if > you are happy with it? sure > It is an esoteric corner case but &g

Re: [PATCH] virtio: check for validity of indirect descriptors

2025-05-29 Thread Michael S. Tsirkin
On Thu, May 29, 2025 at 11:12:17AM +0300, Yuri Benditovich wrote: > ping thanks, it's tagged, will be in the next pull.

Re: [PATCH 0/9] ui: Improve scale handling

2025-05-29 Thread Michael Tokarev
On 11.05.2025 10:33, Weifeng Liu wrote: Hi all, Now we have quite a lot of display backends for different use cases. Even in the context of gtk, we have various implementations (e.g., gl=on vs gl=off, X11 vs Wayland). However, behaviors to users are not aligned across the backends, especially in

  1   2   3   4   5   6   7   8   9   10   >