Re: [PATCH v2 00/20] Add Multi-Core Debug (MCD) API support

2025-05-20 Thread Mario Fleischmann
On 20.05.2025 09:36, Markus Armbruster wrote: > Mario Fleischmann writes: > >> This patch series introduces support for the Multi-Core Debug (MCD) API, a >> commonly used debug interface by emulators. The MCD API, defined through a >> header file, consists of 54 function

Re: [PATCH v2 12/20] gdbstub: Expose GDBRegisterState

2025-05-19 Thread Mario Fleischmann
On 19.05.2025 10:42, Manos Pitsidianakis wrote: > On Wed, 30 Apr 2025 08:27, Mario Fleischmann > wrote: >> Signed-off-by: Mario Fleischmann >> --- >> gdbstub/gdbstub.c | 7 --- >> include/exec/gdbstub.h | 8 +++- >> 2 files changed, 7 insertions(+

Re: [PATCH v2 11/20] mcd: Implement memory space query

2025-05-19 Thread Mario Fleischmann
Thank you for taking the time to review this patch! On 19.05.2025 12:00, Manos Pitsidianakis wrote: > On Wed, 30 Apr 2025 08:27, Mario Fleischmann > wrote: >> Support three main memory space types: >> >> * Physical memory >> * Logical memory (MMU) >> * GDB Re

Re: [PATCH v2 08/20] mcd: Implement server connection API

2025-05-19 Thread Mario Fleischmann
On 15.05.2025 11:58, Daniel P. Berrangé wrote: > On Wed, Apr 30, 2025 at 07:27:29AM +0200, Mario Fleischmann wrote: >> This commit implements the necessary operations required to establish >> a connection with the MCD server: >> >> * query information about

Re: [PATCH v2 07/20] mcd: Implement target initialization API

2025-05-19 Thread Mario Fleischmann
On 15.05.2025 15:02, Markus Armbruster wrote: > Mario Fleischmann writes: > >> The target initialization API ensures that the requested and provided >> MCD versions are compatible. >> >> * implement mcd_initialize_f and mcd_qry_error_info_f in mcdserver >>

Re: [PATCH v2 0/2] migration: Some fix and enhancements to HMP "info migrate"

2025-05-19 Thread Mario Casquero
Sizes (KB): psize=4, total=16798280 transferred=426629, remain=6121884, precopy=426752, multifd=0, postcopy=0 Pages: normal=105457, zero=466489, rate_per_sec=28728 Others: dirty_syncs=1 Tested-by: Mario Casquero On Wed, May 14, 2025 at 10:03 PM Peter Xu wrote: > > v2: > - Drop

Re: [PATCH v2 07/20] mcd: Implement target initialization API

2025-05-14 Thread Mario Fleischmann
Thank you very much for the review! On 08.05.2025 14:04, Markus Armbruster wrote: > Mario Fleischmann writes: > >> The target initialization API ensures that the requested and provided >> MCD versions are compatible. >> >> * implement mcd_initialize_f and mcd

Re: [PATCH v2 00/20] Add Multi-Core Debug (MCD) API support

2025-05-14 Thread Mario Fleischmann
On 08.05.2025 13:38, Markus Armbruster wrote: > Mario Fleischmann writes: > >> This patch series introduces support for the Multi-Core Debug (MCD) API, a >> commonly used debug interface by emulators. The MCD API, defined through a >> header file, consists of 54 function

Re: [PATCH v3 1/1] system: optimizing info mtree printing for monitors

2025-05-05 Thread Mario Casquero
│ │ ├── -bfff (prio 0, ram): alias ram-below-4g @pc.ram -bfff │ │ ├── - (prio -1, i/o): pci ... Tested-by: Mario Casquero On Wed, Apr 30, 2025 at 11:08 AM Chao Liu wrote: > > Make the hierar

Re: [PATCH v2 01/20] mcd: Introduce Multi-Core Debug (MCD) API

2025-04-30 Thread Mario Fleischmann
On 30.04.2025 14:56, Daniel P. Berrangé wrote: > On Wed, Apr 30, 2025 at 02:47:07PM +0200, Mario Fleischmann wrote: >> On 30.04.2025 10:20, Daniel P. Berrangé wrote: >>> On Wed, Apr 30, 2025 at 07:27:22AM +0200, Mario Fleischmann wrote: [...] >>>> diff --git a

Re: [PATCH v2 01/20] mcd: Introduce Multi-Core Debug (MCD) API

2025-04-30 Thread Mario Fleischmann
On 30.04.2025 10:20, Daniel P. Berrangé wrote: > On Wed, Apr 30, 2025 at 07:27:22AM +0200, Mario Fleischmann wrote: >> Formatting changes to mcd_api.h to compily with QEMU's coding style >> guidelines: >> >> * limit line width to 80 >> * convert Dox

[PATCH v2 20/20] mcd: Implement reset control

2025-04-29 Thread Mario Fleischmann
found at https://gitlab.com/lauterbach/mcdrefsrv) Signed-off-by: Mario Fleischmann --- mcd/mcd_qapi.c | 12 + mcd/mcd_qapi.h | 2 + mcd/mcd_server.c | 98 +-- mcd/mcd_stub.c | 61 ++ qapi/mcd.json

[PATCH v2 14/20] mcd: Implement runstate control

2025-04-29 Thread Mario Fleischmann
Currently, only global stop is implemented Signed-off-by: Mario Fleischmann --- mcd/mcd_server.c | 74 +-- mcd/mcd_stub.c | 52 qapi/mcd.json| 100 +++ 3 files changed, 222 insertions

[PATCH v2 12/20] gdbstub: Expose GDBRegisterState

2025-04-29 Thread Mario Fleischmann
Signed-off-by: Mario Fleischmann --- gdbstub/gdbstub.c | 7 --- include/exec/gdbstub.h | 8 +++- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 565f6b3..291ac55 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c

[PATCH v2 08/20] mcd: Implement server connection API

2025-04-29 Thread Mario Fleischmann
This commit implements the necessary operations required to establish a connection with the MCD server: * query information about the server * connect to " * disconnect from " Signed-off-by: Mario Fleischmann --- mcd/mcd_qapi.c | 13 +++ mcd/mcd_qapi.h |

[PATCH v2 10/20] mcd: Implement core connection control

2025-04-29 Thread Mario Fleischmann
In MCD, core-specific operations require an open connection to the core. This commit implements the necessary operations to open and close the connection to cores. Signed-off-by: Mario Fleischmann --- mcd/mcd_server.c | 176 +++--- mcd/mcd_stub.c | 129

[PATCH v2 15/20] mcd test: Implement core state query

2025-04-29 Thread Mario Fleischmann
Depending on the VM and CPU state, core states can be queried: * MCD_CORE_STATE_DEBUG: VM halted or CPU artifically stopped * MCD_CORE_STATE_RUNNING: VM and CPU running * MCD_CORE_STATE_HALTED: CPU suspended Signed-off-by: Mario Fleischmann --- mcd/mcd_qapi.c | 16 ++ mcd

[PATCH v2 06/20] qtest: Introduce MCD test suite

2025-04-29 Thread Mario Fleischmann
tocol. Signed-off-by: Mario Fleischmann --- MAINTAINERS | 1 + tests/qtest/mcd-test.c | 82 + tests/qtest/mcd-util.h | 21 +++ tests/qtest/meson.build | 5 +++ 4 files changed, 109 insertions(+) create mode 100644 tests/qtest/mcd-test.c c

[PATCH v2 09/20] mcd: Implement target system query

2025-04-29 Thread Mario Fleischmann
In MCD, the target system is divided into system, devices and cores: [ system ] 1-* [ devices ] 1-* [cores] This commit implements the necessary functions to query information about the target system. Signed-off-by: Mario Fleischmann --- mcd/mcd_qapi.c | 48 ++ mcd/mcd_qapi.h

[PATCH v2 04/20] qapi: Introduce MCD schema

2025-04-29 Thread Mario Fleischmann
The MCD implementation follows a remote procedure call approach: Each function from mcd_api.h will correspond to one command in mcd.json. Signed-off-by: Mario Fleischmann --- MAINTAINERS | 1 + docs/interop/mcd.rst | 13 + mcd/meson.build | 27

[PATCH v2 07/20] mcd: Implement target initialization API

2025-04-29 Thread Mario Fleischmann
)serialized automatically. Signed-off-by: Mario Fleischmann --- mcd/mcd_qapi.c | 66 +++ mcd/mcd_qapi.h | 26 ++ mcd/mcd_server.c| 44 +- mcd/mcd_stub.c | 35 mcd/meson.build | 49 +++ qapi/mcd.json

[PATCH v2 13/20] mcd: Implement register query

2025-04-29 Thread Mario Fleischmann
Directly map MCD register groups to GDB features lists Signed-off-by: Mario Fleischmann --- mcd/mcd_qapi.c | 48 +++ mcd/mcd_qapi.h | 8 ++ mcd/mcd_server.c | 237 +++-- mcd/mcd_stub.c | 93 + qapi/mcd.json

[PATCH v2 00/20] Add Multi-Core Debug (MCD) API support

2025-04-29 Thread Mario Fleischmann
can be found at https://gitlab.com/lauterbach/mcdrefsrv Mario Fleischmann (20): mcd: Introduce Multi-Core Debug (MCD) API meson: Add --enable-mcd option mcd: Introduce MCD server qapi: Introduce MCD schema mcd: Introduce MCD server stub qtest: Introduce MCD test suite mcd: Implement target

[PATCH v2 19/20] mcd: Implement trigger control

2025-04-29 Thread Mario Fleischmann
-core * mcd_trig_complex_core_st: mcd-trig-complex-core Signed-off-by: Mario Fleischmann --- mcd/mcd_qapi.c | 152 mcd/mcd_qapi.h | 21 ++ mcd/mcd_server.c | 586 -- mcd/mcd_stub.c | 290 +++ qapi/mcd.json

[PATCH v2 03/20] mcd: Introduce MCD server

2025-04-29 Thread Mario Fleischmann
-off-by: Mario Fleischmann --- mcd/mcd_server.c | 431 +++ mcd/meson.build | 14 ++ meson.build | 4 + 3 files changed, 449 insertions(+) create mode 100644 mcd/mcd_server.c create mode 100644 mcd/meson.build diff --git a/mcd/mcd_server.c b

[PATCH v2 18/20] mcd: Implement single stepping

2025-04-29 Thread Mario Fleischmann
gdbstub: abort gdb_set_stop_cpu when step is issued by mcdserver Signed-off-by: Mario Fleischmann --- gdbstub/gdbstub.c | 6 ++- mcd/mcd_server.c | 115 ++ mcd/mcd_stub.c| 18 qapi/mcd.json | 38 ++- 4 files changed

[PATCH v2 05/20] mcd: Introduce MCD server stub

2025-04-29 Thread Mario Fleischmann
the corresponding server functions. To start the MCD monitor, configure QEMU with --enable-mcd and start it with the -mcd option. Signed-off-by: Mario Fleischmann --- MAINTAINERS| 1 + docs/interop/mcd.rst | 2 + include/exec/mcdstub.h | 17 mcd/mcd_monitor.c | 89

[PATCH v2 16/20] gdbstub: Expose gdb_write_register

2025-04-29 Thread Mario Fleischmann
Signed-off-by: Mario Fleischmann --- gdbstub/gdbstub.c | 2 +- include/exec/gdbstub.h | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 291ac55..6ace944 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c

[PATCH v2 17/20] mcd: Implement register/memory access

2025-04-29 Thread Mario Fleischmann
ccess width for memory transactions. Signed-off-by: Mario Fleischmann --- mcd/mcd_qapi.c | 128 + mcd/mcd_qapi.h | 14 mcd/mcd_server.c | 207 ++- mcd/mcd_stub.c | 26 ++ qapi/mcd.json

[PATCH v2 11/20] mcd: Implement memory space query

2025-04-29 Thread Mario Fleischmann
Support three main memory space types: * Physical memory * Logical memory (MMU) * GDB Registers Use custom memory type to mark memory spaces as secure V=1 QTEST_QEMU_BINARY="./qemu-system-arm -M virt,secure=on -cpu cortex-a15" tests/qtest/mcd-test Signed-off-by: Mario Fleischmann

[PATCH v2 02/20] meson: Add --enable-mcd option

2025-04-29 Thread Mario Fleischmann
Signed-off-by: Mario Fleischmann --- docs/interop/mcd.rst | 6 ++ meson.build | 1 + meson_options.txt | 3 +++ scripts/meson-buildoptions.sh | 3 +++ 4 files changed, 13 insertions(+) diff --git a/docs/interop/mcd.rst b/docs/interop/mcd.rst index

Re: [PATCH 00/16] Add Multi-Core Debug (MCD) API support

2025-04-15 Thread Mario Fleischmann
On 09.04.2025 13:37, Markus Armbruster wrote: > Alex Bennée writes: > >> Mario Fleischmann writes: >> >>> On 08.04.2025 16:37, Markus Armbruster wrote: > > [...] > >>>> Use of QAPI/QMP does not imply use of the QMP monitor. We can keep the &

Re: [PATCH 13/16] mcd: Implement register/memory access

2025-04-09 Thread Mario Fleischmann
se byte accesses, or not") and therefore the gdbstub couldn't make advantage of that. MCD does have the field tx->access_width, so a v2 of this patch will call the memory access functions repeatedly, with len = tx->access_width (if set) On 10.03.2025 16:11, Mario Fleischmann wrote:

Re: [PATCH 00/16] Add Multi-Core Debug (MCD) API support

2025-04-09 Thread Mario Fleischmann
On 08.04.2025 16:37, Markus Armbruster wrote: > Alex Bennée writes: > >> Markus Armbruster writes: >> >>> Alex Bennée writes: >>> >>>> Markus Armbruster writes: >>>> >>>>> Mario Fleischmann writes: >>

Re: [PATCH 00/16] Add Multi-Core Debug (MCD) API support

2025-04-08 Thread Mario Fleischmann
Apologies for the line wrapping in yesterday's answer. Should be fixed now. On 08.04.2025 09:00, Markus Armbruster wrote: > Mario Fleischmann writes: > >> Thanks a lot for the response, I really appreciate your time. >> >> On 07.04.2025 14:33, Markus Armbruster wr

Re: [PATCH 00/16] Add Multi-Core Debug (MCD) API support

2025-04-07 Thread Mario Fleischmann
Thanks a lot for the response, I really appreciate your time. On 07.04.2025 14:33, Markus Armbruster wrote: Mario Fleischmann writes: This patch series introduces support for the Multi-Core Debug (MCD) API, a commonly used debug interface by emulators. The MCD API, defined through a header

[PATCH 00/16] Add Multi-Core Debug (MCD) API support

2025-03-15 Thread Mario Fleischmann
t;./qemu-system- [options]" tests/qtest/mcd-test * Architecture-specific tests can be found at the client stub Mario Fleischmann (16): mcd: Introduce Multi-Core Debug (MCD) API mcd: Introduce MCD server mcd: Implement target initialization API mcd: Implement server connection API m

[PATCH 11/16] mcd test: Implement core state query

2025-03-15 Thread Mario Fleischmann
Depending on the VM and CPU state, core states can be queried: * MCD_CORE_STATE_DEBUG: VM halted or CPU artifically stopped * MCD_CORE_STATE_RUNNING: VM and CPU running * MCD_CORE_STATE_HALTED: CPU suspended Signed-off-by: Mario Fleischmann --- mcd/libmcd_qapi.c | 16 + mcd

[PATCH 15/16] mcd: Implement trigger control

2025-03-15 Thread Mario Fleischmann
-core * mcd_trig_complex_core_st: mcd-trig-complex-core Signed-off-by: Mario Fleischmann --- mcd/libmcd_qapi.c | 155 +++- mcd/libmcd_qapi.h | 21 ++ mcd/mcdserver.c| 585 ++-- mcd/mcdstub_qapi.c | 290 ++ qapi/mcd

[PATCH 02/16] mcd: Introduce MCD server

2025-03-15 Thread Mario Fleischmann
/mcdrefsrv Signed-off-by: Mario Fleischmann --- MAINTAINERS | 1 + docs/interop/mcd.rst | 14 ++ mcd/mcdserver.c | 431 ++ mcd/mcdstub_qapi.c| 13 ++ mcd/meson.build | 12 ++ meson.build | 1 + qapi/mcd.json | 6

[PATCH 06/16] mcd: Implement core connection control

2025-03-11 Thread Mario Fleischmann
In MCD, core-specific operations require an open connection to the core. This commit implements the necessary operations to open and close the connection to cores. Signed-off-by: Mario Fleischmann --- mcd/mcdserver.c | 176 --- mcd/mcdstub_qapi.c

[PATCH 13/16] mcd: Implement register/memory access

2025-03-11 Thread Mario Fleischmann
In MCD, all accesses to register or memory are issued over transaction lists. This commit implements three types of transactions: * register access * logical memory access (with MMU) * physical memory access (no MMU) Signed-off-by: Mario Fleischmann --- mcd/libmcd_qapi.c | 128

[PATCH 08/16] gdbstub: Expose GDBRegisterState

2025-03-11 Thread Mario Fleischmann
Signed-off-by: Mario Fleischmann --- gdbstub/gdbstub.c | 7 --- include/exec/gdbstub.h | 8 +++- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 282e13e163..8166510f06 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c

[PATCH 16/16] mcd: Implement reset control

2025-03-11 Thread Mario Fleischmann
found at https://gitlab.com/lauterbach/mcdrefsrv) Signed-off-by: Mario Fleischmann --- mcd/libmcd_qapi.c | 12 + mcd/libmcd_qapi.h | 2 + mcd/mcdserver.c| 98 -- mcd/mcdstub_qapi.c | 61 + qapi/mcd.json

[PATCH 07/16] mcd: Implement memory space query

2025-03-11 Thread Mario Fleischmann
Support three main memory space types: * Physical memory * Logical memory (MMU) * GDB Registers Use custom memory type to mark memory spaces as secure V=1 QTEST_QEMU_BINARY="./qemu-system-arm -M virt,secure=on -cpu cortex-a15" tests/qtest/mcd-test Signed-off-by: Mario Fleischmann

[PATCH 09/16] mcd: Implement register query

2025-03-11 Thread Mario Fleischmann
Directly map MCD register groups to GDB features lists Signed-off-by: Mario Fleischmann --- mcd/libmcd_qapi.c | 48 +++ mcd/libmcd_qapi.h | 8 ++ mcd/mcdserver.c | 237 -- mcd/mcdstub_qapi.c| 93 qapi/mcd.json

[PATCH 04/16] mcd: Implement server connection API

2025-03-11 Thread Mario Fleischmann
This commit implements the necessary operations required to establish a connection with the MCD server: * query information about the server * connect to " * disconnect from " Signed-off-by: Mario Fleischmann --- mcd/libmcd_qapi.c | 13 +++ mcd/libmcd_qapi.h |

[PATCH 03/16] mcd: Implement target initialization API

2025-03-10 Thread Mario Fleischmann
)serialized automatically. Signed-off-by: Mario Fleischmann --- MAINTAINERS | 2 + mcd/libmcd_qapi.c | 66 ++ mcd/libmcd_qapi.h | 26 ++ mcd/mcdserver.c | 44 - mcd/mcdstub_qapi.c| 35 mcd/meson.build

[PATCH 05/16] mcd: Implement target system query

2025-03-10 Thread Mario Fleischmann
In MCD, the target system is divided into system, devices and cores: [ system ] 1-* [ devices ] 1-* [cores] This commit implements the necessary functions to query information about the target system. Signed-off-by: Mario Fleischmann --- mcd/libmcd_qapi.c | 48 + mcd

[PATCH 10/16] mcd: Implement runstate control

2025-03-10 Thread Mario Fleischmann
Currently, only global stop is implemented Signed-off-by: Mario Fleischmann --- mcd/mcdserver.c| 74 +++-- mcd/mcdstub_qapi.c | 52 +++ qapi/mcd.json | 100 + 3 files changed, 222 insertions

[PATCH 12/16] gdbstub: Expose gdb_write_register

2025-03-10 Thread Mario Fleischmann
Signed-off-by: Mario Fleischmann --- gdbstub/gdbstub.c | 2 +- include/exec/gdbstub.h | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 8166510f06..830854ef72 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c

[PATCH 14/16] mcd: Implement single stepping

2025-03-10 Thread Mario Fleischmann
gdbstub: abort gdb_set_stop_cpu when step is issued by mcdserver Signed-off-by: Mario Fleischmann --- gdbstub/gdbstub.c | 6 ++- mcd/mcdserver.c| 115 + mcd/mcdstub_qapi.c | 17 +++ qapi/mcd.json | 38 ++- 4 files changed

Re: [PATCH v2 0/2] s390x: support virtio-mem-pci

2025-01-30 Thread Mario Casquero
em0 requested-size 0 (qemu) device_del vmem0 Tested-by: Mario Casquero On Tue, Jan 28, 2025 at 7:57 PM David Hildenbrand wrote: > > This is based-on [1], which adds MSI-X support to virtio-balloon-pci, > but can be applied independently. > > Turns out it is fairly easy to get

Re: [PATCH v2] virtio-balloon-pci: Allow setting nvectors, so we can use MSI-X

2025-01-28 Thread Mario Casquero
: [70] Vendor Specific Information: VirtIO: Notify Capabilities: [60] Vendor Specific Information: VirtIO: DeviceCfg Capabilities: [50] Vendor Specific Information: VirtIO: ISR Capabilities: [40] Vendor Specific Information: VirtIO: CommonCfg Kernel driver in use: virtio-pci Tested-by: Mario

Re: [PATCH v4] riscv/gdbstub: add V bit to priv reg

2024-12-16 Thread Mario Fleischmann
On 15.12.2024 22:37, Yanfeng Liu wrote: This adds virtualization mode (V bit) as bit(2) of register `priv` per RiscV debug spec v1.0.0-rc4. Checked with gdb-multiarch v12.1. Note that GDB may display `INVALID` tag for `priv` reg when V bit is set, this doesn't affect actual access to the bit

Re: [PATCH v3] riscv/gdb: add V bit to priv register

2024-12-13 Thread Mario Fleischmann
Hi, apologies for the delayed review; I've just gotten to it now. On 06.12.2024 01:14, Yanfeng Liu wrote: This adds virtualization mode (V bit) as bit(2) of register `priv` per RiscV debug spec v1.0.0-rc3. Checked with gdb-multiarch v12.1. Note that GDB may display `INVALID` tag for the value

Re: [PATCH v2] riscv/gdb: add virt mode debug interface

2024-12-04 Thread Mario Fleischmann
Hi everyone, I'd like to chime in here because we are sitting on a similar patch which I wanted to send to the mailing list as soon as riscv-debug-spec v1.0.0 becomes ratified. For hypervisor support, `(qemu) info registers` isn't enough. We need to have both read and write access to the V-b

Re: [PATCH v2 00/14] s390x: virtio-mem support

2024-10-10 Thread Mario Casquero
0- Tested-by: Mario Casquero On Tue, Oct 8, 2024 at 12:57 PM David Hildenbrand wrote: > > Based on current master. > > There is really not much left to do on s390x, because virtio-mem already > implements most things we need today (e.g., early-migration, > u

Re: [PATCH] qtest/x86/numa-test: do not use the obsolete 'pentium' cpu

2024-06-11 Thread Mario Casquero
-id=1,core-id=0 -numa cpu,node-id=0,socket-id=1,core-id=1,thread-id=0 -numa cpu,node-id=1,socket-id=1,core-id=1,thread-id=1 -accel qtest Tested-by: Mario Casquero On Tue, Jun 4, 2024 at 8:24 AM Ani Sinha wrote: > > 'pentium' cpu is old and obsolete and should be avoided for

Re: [PATCH v4 5/5] backends/hostmem: Report error when memory size is unaligned

2024-06-05 Thread Mario Casquero
Tested-by: Mario Casquero On Wed, Jun 5, 2024 at 12:45 PM Michal Privoznik wrote: > > If memory-backend-{file,ram} has a size that's not aligned to > underlying page size it is not only wasteful, but also may lead > to hard to debug behaviour. For instance, in case > memory-backe

Re: [PATCH v2 4/4] backends/hostmem: Report error when memory size is unaligned

2024-06-05 Thread Mario Casquero
This patch has been successfully tested by QE. After allocating some hugepages in the host, try to boot up a VM with the memory backed by a file and the size unaligned, check now the message displayed by QEMU: qemu-system-x86_64: backend memory size must be multiple of 0x20 Tested-by: Mario

Re: [PATCH 0/3] Remove useless architecture prefix from the CPU list

2024-04-26 Thread Mario Casquero
This series has been successfully tested in x86. Execute the cpu help command and check in the list the x86 prefix is no longer present. Tested-by: Mario Casquero On Sat, Apr 20, 2024 at 7:47 AM Thomas Huth wrote: > > Printing an architecture prefix in front of each CPU name is not h

Re: [PATCH v1] virtio-mem: improve error message when unplug of device fails due to plugged memory

2024-04-26 Thread Mario Casquero
plugged Tested-by: Mario Casquero On Tue, Apr 16, 2024 at 4:14 PM David Hildenbrand wrote: > > The error message is actually expressive, considering QEMU only. But > when called from Libvirt, talking about "size" can be confusing, because > in Libvirt "size" translat

Re: [PATCH v2 00/14] libvhost-user: support more memslots and cleanup memslot handling code

2024-03-11 Thread Mario Casquero
e memslots. Tested-by: Mario Casquero On Mon, Mar 11, 2024 at 9:00 PM Mario Casquero wrote: > > This series has been successfully tested by QE. Start the > qemu-storage-daemon in the background with a rhel 9.5 image and > vhost-user-blk. After that, boot up a VM with virtio-mem and >

Re: [PATCH v2 00/14] libvhost-user: support more memslots and cleanup memslot handling code

2024-03-11 Thread Mario Casquero
This series has been successfully tested by QE. Start the qemu-storage-daemon in the background with a rhel 9.5 image and vhost-user-blk. After that, boot up a VM with virtio-mem and vhost-user-blk-pci. Check with the HMP command 'info mtree' that virtio-mem is making use of multiple memslots. On

Re: [PATCH v4 1/1] oslib-posix: initialize backend memory objects in parallel

2024-02-02 Thread Mario Casquero
aphic -monitor stdio QEMU 8.2.50 monitor - type 'help' for more information qemu-system-x86_64: cannot use stdio by multiple character devices qemu-system-x86_64: could not connect serial device to character backend 'stdio' real 0m0.012s user 0m0.006s sys 0m0.007s Tested-by: Mar

Re: [PATCH v1 2/2] memory-device: reintroduce memory region size check

2024-01-19 Thread Mario Casquero
This series has also been successfully tested in x86_64. Tested-by: Mario Casquero On Thu, Jan 18, 2024 at 4:08 AM Zhenyu Zhang wrote: > > [PATCH v1 2/2] memory-device: reintroduce memory region size check > > Test on 64k basic page size aarch64 > The patches work well on my Amp

Re: [PATCH 6/7] balloon: Fix a misleading error message

2023-11-01 Thread Mario Casquero
This patch has been successfully tested by QE. Start a VM with a virtio-balloon device and resize it to an invalid value. Check in the expected error message that now makes reference to 'value' instead of 'target'. Tested-by: Mario Casquero On Tue, Oct 31, 2023 at 12:12 

Re: [PATCH v1] virtio-mem: fix division by zero in virtio_mem_activate_memslots_to_plug()

2023-10-23 Thread Mario Casquero
This patch has been successfully tested by QE. With a debug QEMU build, start a VM with a virtio-mem device and 'dynamic-memslots=off', this one can be resized seamlessly, no floating point exception found. Tested-by: Mario Casquero On Mon, Oct 23, 2023 at 1:13 PM David Hildenbr

Re: [PATCH v4 07/11] softmmu/physmem: Never return directories from file_ram_open()

2023-09-07 Thread Mario Casquero
This series has been successfully tested by QE. Specify a directory for the mem-path of a memory-backend-file object. Check the error message has been improved without referring to a device, which can lead to confusion. Tested-by: Mario Casquero On Wed, Sep 6, 2023 at 2:07 PM David

Re: [PATCH v3 11/11] machine: Improve error message when using default RAM backend id

2023-08-29 Thread Mario Casquero
This series has been successfully tested by QE. Start a vm using pc.ram id but specifying a different memory-backend from the default one. Check the error message has been improved. Tested-by: Mario Casquero On Wed, Aug 23, 2023 at 5:38 PM David Hildenbrand wrote: > > For migration pu

Re: [PATCH v3 0/7] virtio-mem: Device unplug support

2023-07-11 Thread Mario Casquero
This series has been successfully tested by QE. Start a VM, plug a virtio-mem device, resize the device (adding memory) and verify that the virtio-mem device cannot be unplugged. Finally, resize the device (removing all the memory) and check that it can be unplugged seamlessly. Tested-by: Mario

Re: [PATCH v1 0/4] virtio-mem: Support "x-ignore-shared" migration

2023-07-05 Thread Mario Casquero
This series has been tested successfully by QE. Start a VM with a 8G virtio-mem device and start memtester on it. Enable x-ignore-shared capability and then do migration. Migration was successful and virtio-mem can be resized as usual. Tested-by: Mario Casquero BR, Mario On Tue, Jun 20

Re: Prefetches in buffer_zero_*

2021-07-23 Thread Joe Mario
On Thu, Jul 22, 2021 at 3:14 PM Dr. David Alan Gilbert wrote: > * Richard Henderson (richard.hender...@linaro.org) wrote: > > On 7/22/21 12:02 AM, Dr. David Alan Gilbert wrote: > > > Hi Richard, > > >I think you were the last person to fiddle with the prefetching > > > in buffer_zero_avx2 and

[Bug 1674114] Re: Bad sectors when using MS-DOS 6.22

2020-12-07 Thread Mario
The issue is resolved in the current release C:\tmp>"C:\Program Files\qemu\\qemu-system-i386.exe" --version QEMU emulator version 5.1.92 (v5.2.0-rc2-11843-gf571c4ffb5-dirty) Copyright (c) 2003-2020 Fabrice Bellard and the QEMU Project developers ** Changed in: qemu Status: Incomplete => Fi

[PATCH] util/qemu-error: prepend guest name to error message to identify affected VM owner

2020-06-26 Thread Mario Smarduch
having the guest name enables identify of owner and customer. Signed-off-by: Mario Smarduch --- Test verification summary: a) qemu-system-x86_64 -msg help guest-name= - Prepends guest name for error messages but only if -name is set otherwise option is ignored timestamp= b) qemu-system-x86_64

Re: [PATCHv2 0/2] log guest name and memory error type AO, AR for MCEs

2019-10-09 Thread Mario Smarduch
On 10/09/2019 02:19 PM, Paolo Bonzini wrote: > On 09/10/19 18:44, Mario Smarduch wrote: >> In a large VPC environment we want to log memory error occurrences >> and log them with guest name and type - there are few use cases >> >> >> - if VM crashes on AR mce

[PATCHv2 2/2] target/i386: log MCE guest and host addresses

2019-10-09 Thread Mario Smarduch
3d6f5000 addr of type BUS_MCEERR_AR injected qemu-system-x86_64 amsNams3node The first log had a corresponding mce log entry, the second didnt (logging thresholds) we can infer from second entry same PA and mce type. Signed-off-by: Mario Smarduch --- target/i386/kvm.c | 29

[PATCHv2 1/2] util/qemu-error: add guest name helper with -msg options

2019-10-09 Thread Mario Smarduch
Signed-off-by: Mario Smarduch --- include/qemu/error-report.h | 1 + qemu-options.hx | 10 ++ util/qemu-error.c | 31 +++ vl.c| 5 + 4 files changed, 43 insertions(+), 4 deletions(-) diff --git a/include/qemu

[PATCHv2 0/2] log guest name and memory error type AO, AR for MCEs

2019-10-09 Thread Mario Smarduch
type BUS_MCEERR_AR injected with enterprise logging environment we can to take further actions. v1 -> v2: - split into two patches one to get the gustname second to log MCEs - addressed comments for MCE logging Mario Smarduch (2): util/qemu-error: add guest name helper with -msg opti

Re: [PATCH] target/i386: log guest name and memory error type AO, AR for MCEs

2019-10-07 Thread Mario Smarduch
On 10/07/2019 03:27 AM, Philippe Mathieu-Daudé wrote: > Hi Mario, > > On 10/5/19 1:53 AM, Mario Smarduch wrote: >> In a large VPC environment we want to log memory error occurrences >> and log them with guest name and type - there are few use cases >> >> >&g

Re: [PATCH] target/i386: log guest name and memory error type AO, AR for MCEs

2019-10-06 Thread Mario Smarduch
On 10/06/2019 09:11 AM, Paolo Bonzini wrote: > On 05/10/19 01:53, Mario Smarduch wrote: >> Guest [Droplet-12345678] 2019-08-02T05:00:11.940270Z qemu-system-x86_64: >> Guest MCE Memory Error at qemu addr 0x7f3c7622f000 and guest 78e42f000 >> addr of type BUS_MCEERR_A

[PATCH] target/i386: log guest name and memory error type AO, AR for MCEs

2019-10-04 Thread Mario Smarduch
type BUS_MCEERR_AR injected with enterprise logging environment we can to take further actions. Signed-off-by: Mario Smarduch --- target/i386/kvm.c | 27 ++- util/qemu-error.c | 24 2 files changed, 46 insertions(+), 5 deletions(-) diff --git a

[Qemu-devel] Request for comment - dynamic VNC keyboard mapping

2019-05-03 Thread Mario
o have a reference implmentation for the integrated keyboard layout switching. What are your thoughts about this kind of improvement? Thanks, Mario

[Qemu-devel] [Bug 1794202] Re: Trying to install Mac OS X 10.5, it gives this error, "Mac OS X cannot be installed on your computer."

2018-09-24 Thread Mario
Fixed issue by switching boot from d to c. I found the solution by just seeing if it would work, and it does. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.ne

[Qemu-devel] [Bug 1794202] [NEW] Trying to install Mac OS X 10.5, it gives this error, "Mac OS X cannot be installed on your computer."

2018-09-24 Thread Mario
Public bug reported: When I try to install Mac OS X 10.5, it gives this error, "Mac OS X cannot be installed on your computer." Command ran in the command-line: "C:\Program Files\qemu\qemu-system-ppc" -L pc-bios -boot d -M mac99,via=pmu -m 512 -hda "C:\Users\*\Downloads\macosx105\MacOSHDD.qcow

[Qemu-devel] [Bug 1745312] Re: Regression report: Disk subsystem I/O failures/issues surfacing in DOS/early Windows [two separate issues: one bisected, one root-caused]

2018-04-30 Thread Mario
I have a similar bug: 1674114 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1745312 Title: Regression report: Disk subsystem I/O failures/issues surfacing in DOS/early Windows [two separate issue

[Qemu-devel] [Bug 1674114] Re: Bad sectors when using MS-DOS 6.22

2017-03-19 Thread Mario
It is working now without the parameters "-machine isapc" and "-cpu 486". -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1674114 Title: Bad sectors when using MS-DOS 6.22 Status in QEMU: New Bug

[Qemu-devel] [Bug 1674114] [NEW] Bad sectors when using MS-DOS 6.22

2017-03-19 Thread Mario
Public bug reported: When I try to install DOS 6.22 in QEMU, I get many disk errors when the virtual disk is beeing partionized and formatted. When I later do a SCANDISK, I can see many bad sectors and file errors. I have tested this with the following disk formats: qcow2, vmdk, raw. I tested th

Re: [Qemu-devel] [RFC/RFT PATCH v2 1/3] arm/arm64: pageattr: add set_memory_nc

2015-05-26 Thread Mario Smarduch
On 05/25/2015 10:11 AM, Andrew Jones wrote: > On Fri, May 22, 2015 at 06:08:30PM -0700, Mario Smarduch wrote: >> On 05/18/2015 08:53 AM, Catalin Marinas wrote: >>> On Thu, May 14, 2015 at 02:46:44PM +0100, Andrew Jones wrote: >>>> On Thu, May 14, 2015 at 01:05:09PM

Re: [Qemu-devel] [RFC/RFT PATCH v2 1/3] arm/arm64: pageattr: add set_memory_nc

2015-05-22 Thread Mario Smarduch
asic loadable driver that allocates non-cachable/pinned pages for QEMU to mmap() may provide a reference point to build on. If that covers all the cases then perhaps move to more generic solution. This should be quicker to implement and test. I wonder if kernel mm will ever have a reason to create

Re: [Qemu-devel] [RFC/RFT PATCH v2 3/3] arm/arm64: KVM: implement 'uncached' mem coherency

2015-05-20 Thread Mario Smarduch
_region_set_uncached() added to QEMU, and if it does not, some >> vague idea why that falls outside of the scope of this patch set. After >> all, adding a USB controller to a VM is not that an esoteric use case, >> is it? > > I'll pull together a new version addressing all your comments, and also > put some more time into making sure it'll work... > > Jeremy, can you give me the qemu command line you're using for your tests? > I'll do some experimenting with it. > > Thanks, > drew > Hi Drew, I just recently looked at these patches and little confused. Where or how are the QEMU page tables changed to non-cacheable? I noticed the logical pfn is changed to non-cacheable. - Mario

[Qemu-devel] Qemu support with rbd in Centos7

2014-12-18 Thread Mario Codeniera
erates error on the following: ./configure --enable-rbd > ERROR: User requested feature rados block device >configure was not able to find it. >Install librbd/ceph devel which I don't know what to do as i could not able to find librbd library. Hope someone can helps. Thanks, Mario

[Qemu-devel] [Bug 1025244] Re: qcow2 image increasing disk size above the virtual limit

2014-12-16 Thread Mario
@serge, what version would I need to upgrade to be able to use the external snapshots? that sounds like it would solve my problems -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1025244 Title: qcow2

[Qemu-devel] [Bug 1025244] Re: qcow2 image increasing disk size above the virtual limit

2014-12-15 Thread Mario
@michael, so you do that once, after some time the machine keeps growing, and growing and growing... and you have to redo that every so often... I have a machine that should be taking up 30 gb yet is taking 600+ GB with 4 snapshots... but yeah... I'll just plug in another 1tb hard drive so that i

[Qemu-devel] [Bug 1025244] Re: qcow2 image increasing disk size above the virtual limit

2014-12-12 Thread Mario
Is anyone even looking at this? been years and the problem still persists! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1025244 Title: qcow2 image increasing disk size above the virtual limit Sta

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fix return check for KVM_GET_DIRTY_LOG ioctl

2014-03-20 Thread Mario Smarduch
you may see issues like that. - Mario On 03/20/2014 08:45 AM, Michael Tokarev wrote: > 19.03.2014 21:24, Mario Smarduch wrote: >> >> Fix return condition check from kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) to >> handle internal failures or no support for memory slot dirty

[Qemu-devel] [PATCH] fix return check for KVM_GET_DIRTY_LOG ioctl

2014-03-19 Thread Mario Smarduch
Fix return condition check from kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) to handle internal failures or no support for memory slot dirty bitmap. Otherwise the ioctl succeeds and continues with migration. Addresses BUG# 1294227 Signed-off-by: Mario Smarduch --- kvm-all.c |2 +- 1 file cha

[Qemu-devel] [Bug 1294227] [NEW] migration wrong handling of KVM_GET_DIRTY_LOG ioctl

2014-03-18 Thread Mario Smarduch
Public bug reported: In the code below kvm_vm_ioctl(...) can return --errno != -1 from ioctl call, but return only checks for -1. Found during KVM-ARM migration which apperead to go through but was actually failing getting memslot dirty bitmap. static int kvm_physical_sync_dirty_bitmap()

Re: [Qemu-devel] [Bug 1286253] [NEW] virtio-net acceleration features not set when plugged into backend dynamically

2014-03-03 Thread Mario Smarduch
evice' option and see what happens. Yes I did check the options on host after device is plugged and guest after features are probed, only the MAC feature is set. Thanks, - Mario -Original Message- From: qemu-devel-bounces+m.smarduch=samsung@nongnu.org [mailto:qemu-devel-bounc

  1   2   >