On 19.05.2025 10:42, Manos Pitsidianakis wrote:
> On Wed, 30 Apr 2025 08:27, Mario Fleischmann
> <mario.fleischm...@lauterbach.com> wrote:
>> Signed-off-by: Mario Fleischmann <mario.fleischm...@lauterbach.com>
>> ---
>> gdbstub/gdbstub.c | 7 -------
>> include/exec/gdbstub.h | 8 +++++++-
>> 2 files changed, 7 insertions(+), 8 deletions(-)
>>
>> diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c
>> index 565f6b3..291ac55 100644
>> --- a/gdbstub/gdbstub.c
>> +++ b/gdbstub/gdbstub.c
>> @@ -48,13 +48,6 @@
>>
>> #include "internals.h"
>>
>> -typedef struct GDBRegisterState {
>> - int base_reg;
>> - gdb_get_reg_cb get_reg;
>> - gdb_set_reg_cb set_reg;
>> - const GDBFeature *feature;
>> -} GDBRegisterState;
>> -
>> GDBState gdbserver_state;
>>
>> void gdb_init_gdbserver_state(void)
>> diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h
>> index 0675b0b..c2941e5 100644
>> --- a/include/exec/gdbstub.h
>> +++ b/include/exec/gdbstub.h
>> @@ -16,11 +16,17 @@ typedef struct GDBFeatureBuilder {
>> int base_reg;
>> } GDBFeatureBuilder;
>>
>> -
>
> Accidental line deletion here?
>
> With that fixed,
>
> Reviewed-by: Manos Pitsidianakis <manos.pitsidiana...@linaro.org>
Yes, thanks for pointing it out!
