This patch has been successfully tested by QE. Start a VM with a
virtio-balloon device and resize it to an invalid value. Check in the
expected error message that now makes reference to 'value' instead of
'target'.
Tested-by: Mario Casquero <mcasq...@redhat.com>
On Tue, Oct 31, 2023 at 12:12 PM Markus Armbruster <arm...@redhat.com> wrote:
>
> The error message
>
> {"execute": "balloon", "arguments":{"value": -1}}
> {"error": {"class": "GenericError", "desc": "Parameter 'target' expects a
> size"}}
>
> points to 'target' instead of 'value'. Fix:
>
> {"error": {"class": "GenericError", "desc": "Parameter 'value' expects a
> size"}}
>
> Root cause: qmp_balloon()'s parameter is named @target. Rename it to
> @value to match the QAPI schema.
>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
> ---
> system/balloon.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/system/balloon.c b/system/balloon.c
> index e0e8969a4b..fda7af832e 100644
> --- a/system/balloon.c
> +++ b/system/balloon.c
> @@ -90,17 +90,17 @@ BalloonInfo *qmp_query_balloon(Error **errp)
> return info;
> }
>
> -void qmp_balloon(int64_t target, Error **errp)
> +void qmp_balloon(int64_t value, Error **errp)
> {
> if (!have_balloon(errp)) {
> return;
> }
>
> - if (target <= 0) {
> - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "target", "a size");
> + if (value <= 0) {
> + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "value", "a size");
> return;
> }
>
> - trace_balloon_event(balloon_opaque, target);
> - balloon_event_fn(balloon_opaque, target);
> + trace_balloon_event(balloon_opaque, value);
> + balloon_event_fn(balloon_opaque, value);
> }
> --
> 2.41.0
>
>
