of_dpa_cmd_add_acl_ip(OfDpaFlowKey *key, OfDpaFlowKey *mask,
RockerTlv **flow_tlvs)
The second line is misalgined.
{
key->width = FLOW_KEY_WIDTH(ip.tos);
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Monday in 2024, Michal Privoznik wrote:
Current logic on return value ('ret' variable) in main() is error
prone. The variable is initialized to EXIT_SUCCESS and then set
to EXIT_FAILURE on error paths. This makes it very easy to forget
to set the variable to indicate error when adding new er
agent_once() return no value
qga/main.c | 52 +---
1 file changed, 25 insertions(+), 27 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
--
3 files changed, 38 insertions(+), 74 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
7;''''''''''''''''''''
+
+Backend ``memory`` (since 9.0)
+^^
+
+``memory`` is a deprecated synonym for ``ringbuf``.
+
For libvirt:
Reviewed-by: Ján Tomko
(We don't support either of those)
Jano
signature.asc
Description: PGP signature
qemu-options.hx | 18 +-
4 files changed, 52 insertions(+), 27 deletions(-)
For libvirt:
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Friday in 2023, Markus Armbruster wrote:
{ "sandbox", NULL, QEMU_CAPS_SECCOMP_SANDBOX },
Does option -sandbox exist?
It does since v1.2. If CONFIG_SECCOMP is off, actually using it is a
fatal error. Compiling out the option entirely would be more useful, I
guess.
Is this probe stil
obe for the property .
docs/about/deprecated.rst | 6 ++
softmmu/vl.c | 1 +
qemu-options.hx | 2 +-
3 files changed, 8 insertions(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
From: Joelle van Dyne
Run state is also in RUN_STATE_PRELAUNCH while "-S" is used.
This reverts commit 0631d4b448454ae8a1ab091c447e3f71ab6e088a
Signed-off-by: Joelle van Dyne
Reviewed-by: Ján Tomko
The original commit broke the usage of usbredir with libvirt, which
starts every d
eviewed-by: Ján Tomko
This fixes usb redirect on VM startup for VMs started by libvirt, which
uses -S:
https://bugzilla.redhat.com/show_bug.cgi?id=2144436
Jano
signature.asc
Description: PGP signature
its introduction in 409437e16df273fc5f78f6cd1cb53023eaeb9b72
Reviewed-by: Ján Tomko
Jano
files changed, 26 insertions(+), 2 deletions(-)
Tested-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Friday in 2021, Alex Bennée wrote:
Experience has shown that getting new functionality up-streamed can be
a somewhat painful process. Lets see if we can collect some of our
community knowledge into a blog post describing some best practices
for getting code accepted.
[AJB: obviously RFC for
On a Friday in 2021, Paolo Bonzini wrote:
Signed-off-by: Paolo Bonzini
---
configure | 5 -
1 file changed, 5 deletions(-)
Reviewed-by: Ján Tomko
$supported_os is unused since
commit f9332757898a764d85e19d339ec421236e885b68
meson: move summary to meson.build
$haiku is unused since
chine-qmp-cmds.c | 28 +++
include/hw/core/cpu.h | 13 +-
monitor/misc.c | 25 ++-
qapi/machine.json | 37
target/i386/cpu-dump.c | 325 +++-
target/i386/cpu.c | 2 +-
target/i386/cpu.h
On a Wednesday in 2021, Daniel P. Berrangé wrote:
Signed-off-by: Daniel P. Berrangé
---
target/i386/cpu-dump.c | 325 ++---
target/i386/cpu.c | 2 +-
target/i386/cpu.h | 2 +-
3 files changed, 174 insertions(+), 155 deletions(-)
diff --git a/target
| 2 --
3 files changed, 7 insertions(+), 9 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
ranslate-all.c | 2 +-
softmmu/vl.c | 8
qemu-options.hx| 8
4 files changed, 6 insertions(+), 24 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
ion policy, we could have removed it for QEMU 5.2
already. Do it now ; since ppc_cpu_parse_featurestr() now just calls the
generic parent_parse_features handler, drop it as well.
Users are supposed to use the "max-cpu-compat" property of the pseries
machine type instead.
For libvirt:
Revie
ombines what could be separate client and server
+rules into a single 'all' rule, matching 'security.' in either
+client arguments or lists returned from the host. This stops
+the client seeing any 'security.' attributes on the server and
+stops it setting any.
extra space.
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Thursday in 2020, Dr. David Alan Gilbert (git) wrote:
From: "Dr. David Alan Gilbert"
Add an option to define mappings of xattr names so that
the client and server filesystems see different views.
This can be used to have different SELinux mappings as
seen by the guest, to run the virtiofsd
f-by: Dr. David Alan Gilbert
---
tools/virtiofsd/passthrough_ll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Monday in 2020, Daniel P. Berrangé wrote:
On Mon, May 18, 2020 at 12:16:28PM +0200, Gerd Hoffmann wrote:
On Fri, May 15, 2020 at 05:08:23PM +0200, Ján Tomko wrote:
> On a Friday in 2020, Gerd Hoffmann wrote:
> > Add deprecation message to the audio init function.
> >
>
On a Friday in 2020, Gerd Hoffmann wrote:
Add deprecation message to the audio init function.
Factor out audio initialization and call that from
both audio init and realize, so setting audiodev via
-global is enough to properly initialize pcspk.
Signed-off-by: Gerd Hoffmann
---
hw/audio/pcspk.
On a Thursday in 2020, Christian Schoenebeck wrote:
On Donnerstag, 19. März 2020 14:10:26 CET Ján Tomko wrote:
On a Tuesday in 2020, Christian Schoenebeck wrote:
>Introduce new 'multidevs' option for filesystem.
>
>
I don't like the 'multidevs' name,
On a Tuesday in 2020, Christian Schoenebeck wrote:
Introduce new 'multidevs' option for filesystem.
I don't like the 'multidevs' name, but cannot think of anything
beter.
'collisions' maybe?
This option prevents misbheaviours on guest if a 9pfs export
contains multiple devices,
On a Thursday in 2020, Jingqi Liu wrote:
The CONFIG_LINUX symbol is always not defined in this file.
This fixes that "config-host.h" header file is not included
for getting macros.
Signed-off-by: Jingqi Liu
---
util/mmap-alloc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/util/mmap-all
sting
bug. Let's fix it. This is to be a new base of zstd series.
block/qcow2-threads.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Sunday in 2020, Nick Erdmann wrote:
error_setg_errno takes a positive error number, so we should not invert
errno's sign.
Signed-off-by: Nick Erdmann
---
hw/virtio/vhost-vsock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signatur
On a Thursday in 2020, Daniel P. Berrangé wrote:
On Thu, Feb 27, 2020 at 11:06:21AM +0100, Philippe Mathieu-Daudé wrote:
Use GLib g_file_open_tmp() instead of getenv + snprintf + mkstemp.
Signed-off-by: Philippe Mathieu-Daudé
---
RFC because I'm not sure g_autoptr(GError) works this way.
It
On a Wednesday in 2020, Eric Blake wrote:
Creating an image that requires format probing of the backing image is
inherently unsafe (we've had several CVEs over the years based on
probes leaking information to the guest on a subsequent boot). If our
probing algorithm ever changes, or if other too
--
block.c | 13 ++---
block/qcow2.c | 2 +-
block/stream.c| 2 +-
blockdev.c| 3 ++-
qemu-img.c| 4 ++--
6 files changed, 18 insertions(+), 10 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
'-f', iotests.imgfmt,
+ '-o', 'backing_file=%s' % mid_img,
+ '-F', iotests.imgfmt, test_img)
Consider not mixing shortcuts with -o options.
qemu_io('-f', 'raw', '-c', 'write -P 0x1 0 512', backing_img)
qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0x1 524288 512', mid_img)
self.vm = iotests.VM().add_drive("blkdebug::" + test_img,
With test #225 fixed:
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Thursday in 2020, Peter Krempa wrote:
On Wed, Feb 26, 2020 at 20:39:26 -0600, Eric Blake wrote:
There are many existing qcow2 images that specify a backing file but
no format. This has been the source of CVEs in the past, but has
become more prominent of a problem now that libvirt has swit
2 +-
hw/pci/pcie.c | 11 +++
hw/pci/pcie_port.c | 1 +
include/hw/pci/pcie.h | 2 +-
include/hw/pci/pcie_port.h | 3 +++
6 files changed, 14 insertions(+), 7 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
ions(+), 7 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On Tue, Feb 18, 2020 at 05:17:17PM +0100, Julia Suvorova wrote:
Make hot-plug/hot-unplug on PCIe Root Ports optional to allow libvirt
to manage it and restrict unplug for the entire machine. This is going
to prevent user-initiated unplug in guests (Windows mostly).
Usage:
-device pcie-root-por
---
tools/virtiofsd/passthrough_ll.c | 2 --
1 file changed, 2 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
n the BLOCK_JOB_ERROR QMP event.
Signed-off-by: Kevin Wolf
---
block/commit.c | 28 ++--
1 file changed, 6 insertions(+), 22 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
ction made,
even if a bit later than expected: "This will be part of the QMP
command, if/when the BlockdevOnError change for blkmirror makes it in".
Signed-off-by: Kevin Wolf
---
qapi/block-core.json | 4
blockdev.c | 8
2 files changed, 8 insertions(+), 4 deletions(-)
mmit.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
#x27;ae586d6158': unknown revision or path not in the
working tree.
introduced later and use the same model as mirror.
Signed-off-by: Kevin Wolf
---
qapi/block-core.json | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
changed, 2 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
patch.)
Signed-off-by: Kevin Wolf
---
block/commit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
= -ERANGE;
^ ~~~
Fixes: 2de121f01e
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé
---
RFC because untested
---
tools/virtiofsd/fuse_lowlevel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On Sat, Feb 15, 2020 at 05:07:15PM +0100, Philippe Mathieu-Daudé wrote:
Fix warning reported by Clang static code analyzer:
CC tools/virtiofsd/passthrough_ll.o
tools/virtiofsd/passthrough_ll.c:925:9: warning: Value stored to 'newfd' is
never read
newfd = -1;
^ ~
r = ENOMEM;
^~~
Fixes: 7c6b66027
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé
---
tools/virtiofsd/passthrough_ll.c | 2 --
1 file changed, 2 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
ang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé
---
block/qcow2-bitmap.c | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Ján Tomko
Unused since its introduction in 88ddffae8fc1e30cc907c2dbb989b7eba9e62319
Jano
signature.asc
Description: PGP signature
://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg03623.html
diff to v1:
- Change error reporting in vfio_dma_unmap() too as I missed it in v1.
hw/vfio/common.c| 4 ++--
util/vfio-helpers.c | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
/vfio-helpers.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
ash directly through JSON even without
this patch.
Signed-off-by: Eric Blake
---
block/nbd.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
sTime
so I'm hoping I can get the QEMU documentation updated and then just
merge back the changes.
qapi/misc.json | 34 +++---
1 file changed, 23 insertions(+), 11 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
| 16
vl.c| 16 ++--
qapi/ui.json| 3 +++
qemu-deprecated.texi| 5 +
ui/cocoa.m | 4
7 files changed, 40 insertions(+), 13 deletions(-)
Series:
Reviewed-by: Ján Tomko
Jano
signature.asc
Description
On Wed, Feb 05, 2020 at 12:03:53PM +0100, Gerd Hoffmann wrote:
Signed-off-by: Gerd Hoffmann
---
ui/gtk.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On Wed, Feb 05, 2020 at 12:03:54PM +0100, Gerd Hoffmann wrote:
Signed-off-by: Gerd Hoffmann
---
ui/sdl2.c | 28
1 file changed, 20 insertions(+), 8 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On Wed, Feb 05, 2020 at 12:03:52PM +0100, Gerd Hoffmann wrote:
When enabled forces showing a the mouse cursor, i.e. do
nowallow the guest to hide it. Defaults to off.
Signed-off-by: Gerd Hoffmann
---
qapi/ui.json | 2 ++
1 file changed, 2 insertions(+)
Reviewed-by: Ján Tomko
Jano
On Wed, Feb 05, 2020 at 12:03:55PM +0100, Gerd Hoffmann wrote:
Signed-off-by: Gerd Hoffmann
---
include/sysemu/sysemu.h | 1 -
vl.c| 4 ++--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/vl.c b/vl.c
index 24951b51a94b..0db0aa0fa040 100644
--- a/vl.c
+++ b/vl
.texi | 49 ++
qemu-nbd.c| 133 +-
3 files changed, 24 insertions(+), 173 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
d-off-by: Eric Blake
---
qemu-deprecated.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On Wed, Feb 05, 2020 at 12:03:56PM +0100, Gerd Hoffmann wrote:
Signed-off-by: Gerd Hoffmann
---
vl.c | 2 ++
qemu-deprecated.texi | 5 +
2 files changed, 7 insertions(+)
libvirt does not use -show-cursor
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP
On Mon, Jan 27, 2020 at 04:01:31PM -0500, John Snow wrote:
On 1/27/20 3:43 PM, Peter Krempa wrote:
On Mon, Jan 27, 2020 at 14:39:02 -0500, John Snow wrote:
On 1/27/20 5:36 AM, Maxim Levitsky wrote:
This patch series is bunch of cleanups
to the hmp monitor code.
This series only touched bl
s changed, 8651 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
sb/Kconfig | 5 -
hw/usb/Makefile.objs | 1 -
hw/usb/dev-bluetooth.c | 581 -
qemu-doc.texi | 15 --
4 files changed, 602 deletions(-)
delete mode 100644 hw/usb/dev-bluetooth.c
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On Wed, Mar 06, 2019 at 08:41:48AM +0100, Peter Krempa wrote:
On Tue, Mar 05, 2019 at 16:56:43 +0100, Andrea Bolognani wrote:
On Tue, 2019-03-05 at 15:38 +0100, Gerd Hoffmann wrote:
[...]
So I agree neither scenario is exactly perfect, but I still think
adding non-transitional alias devices
On Fri, Sep 14, 2018 at 05:52:30PM +0400, Marc-André Lureau wrote:
As discussed during "[PATCH v4 00/29] vhost-user for input & GPU"
review, let's define a common set of backend conventions to help with
management layer implementation, and interoperability.
v2:
- drop --pidfile
- add some notes
On Mon, Aug 27, 2018 at 05:08:45PM +0200, Peter Krempa wrote:
On Mon, Aug 27, 2018 at 16:54:08 +0200, Thomas Huth wrote:
These options are deprecated since at least two releases, and nobody
complained. Time to remove them now.
(I'm sending these patches as a series since Paolo asked me to send
On Wed, Jun 06, 2018 at 11:17:36AM -0700, Samudrala, Sridhar wrote:
On 6/4/2018 7:06 PM, Jason Wang wrote:
On 2018年06月05日 09:41, Samudrala, Sridhar wrote:
Ping on this patch now that the kernel patches are accepted into
davem's net-next tree.
https://patchwork.ozlabs.org/cover/920005/
On 5/
nged, 124 insertions(+), 118 deletions(-)
Reviewed-by: Ján Tomko
Tested-by: Ján Tomko
Jano
signature.asc
Description: Digital signature
On Fri, May 25, 2018 at 05:36:09PM +0200, Marc-André Lureau wrote:
Signed-off-by: Marc-André Lureau
---
configure | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: Digital signature
On Fri, May 25, 2018 at 06:53:44AM +0200, Gerd Hoffmann wrote:
Fixes: CID 1391291
Signed-off-by: Gerd Hoffmann
---
hw/display/bochs-display.c | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: Digital signature
Signed-off-by: Peter Xu
---
migration/ram.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: Digital signature
On Sat, May 19, 2018 at 04:20:37PM +0800, Yi Min Zhao wrote:
在 2018/5/18 下午9:07, Ján Tomko 写道:
On Fri, May 18, 2018 at 11:19:16AM +0200, Eduardo Otubo wrote:
On 18/05/2018 - 09:52:12, Ján Tomko wrote:
But now libvirt requires QEMU >= 1.5.0 which already supports
query-command-line-opti
On Fri, May 18, 2018 at 11:19:16AM +0200, Eduardo Otubo wrote:
On 18/05/2018 - 09:52:12, Ján Tomko wrote:
On Thu, May 17, 2018 at 02:41:09PM +0200, Eduardo Otubo wrote:
> On 15/05/2018 - 19:33:48, Yi Min Zhao wrote:
> > If CONFIG_SECCOMP is undefined, the option 'elevateprivi
On Thu, May 17, 2018 at 02:41:09PM +0200, Eduardo Otubo wrote:
On 15/05/2018 - 19:33:48, Yi Min Zhao wrote:
If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains
compiled. This would make libvirt set the corresponding capability and
then trigger the guest startup fails. So this
On Mon, May 07, 2018 at 01:04:17PM -0500, Eric Blake wrote:
On 05/06/2018 10:32 PM, Yi Min Zhao wrote:
In the subject line: s/avoid to compile/avoid compiling/
If CONFIG_SECCOMP is undefined, the option 'elevatorprivileges' remains
s/elevator/elevate/
complied. This would make libvirt set
On Mon, May 07, 2018 at 12:33:20PM +0200, Eduardo Otubo wrote:
On 07/05/2018 - 11:29:57, Christian Borntraeger wrote:
On 05/07/2018 05:32 AM, Yi Min Zhao wrote:
> 1. Problem Description
> ==
> If QEMU is built without seccomp support, 'elevatorprivileges' remains
compiled.
>
Eduardo Habkost
---
target-i386/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Tested-by: Ján Tomko
signature.asc
Description: Digital signature
On Mon, Feb 29, 2016 at 11:17:25AM +0100, Paolo Bonzini wrote:
>
>
> On 29/02/2016 11:04, Ján Tomko wrote:
> > On Mon, Feb 29, 2016 at 10:07:47AM +0100, Paolo Bonzini wrote:
> >>
> >>
> >> On 29/02/2016 09:57, Ján Tomko wrote:
> >>> qemu-syst
On Mon, Feb 29, 2016 at 10:07:47AM +0100, Paolo Bonzini wrote:
>
>
> On 29/02/2016 09:57, Ján Tomko wrote:
> > qemu-system-x86_64 -S -no-user-config -nodefaults -nographic -M none
> > -qmp unix:/var/lib/libvirt/qemu/capabilities.monitor.sock,server,nowait
> > -pi
On Wed, Feb 24, 2016 at 02:27:36PM +0100, Paolo Bonzini wrote:
> From: Dimitris Aragiorgis
>
> In case of daemonize, use the logfile passed with the -D option in
> order to redirect stderr to it instead of /dev/null.
>
> Also remove some unused code in log.h.
>
> Signed-off-by: Dimitris Aragior
> ---
> docs/tracing.txt | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Ján Tomko
signature.asc
Description: Digital signature
On Tue, Jun 23, 2015 at 06:58:41PM +0200, Laszlo Ersek wrote:
> This is (again) for the other pc-q35-2.4 ISA-FDC problem reported by
> Jan. Addressing comments from Markus.
>
> Jan, can you give it another try please? I realize this is getting old
> pretty quick, so don't bother if you don't want
On Sat, Jun 20, 2015 at 04:43:46AM +0200, Laszlo Ersek wrote:
> This is for the other pc-q35-2.4 ISA-FDC problem reported by Jan.
>
> Jan, can you give it a try pls?
>
Works for me.
I tried the following command line with a Fedora 21 guest:
-device isa-fdc,driveA=drive-fdc0-0-0
-drive file=/var
Hello,
commit ea96bc629cbd52be98b2967a4b4f72e91dfc3ee4
i386: drop FDC in pc-q35-2.4+ if neither it nor floppy drives are wanted
dropped the controller for older machine types too, despite the commit
message.
It seems the logic in the merged commit does not match the original patch:
http://thre
known
Strip the brackets to make it work again.
Signed-off-by: Ján Tomko
Reviewed-by: Eric Blake
---
v2: Fixed spacing around operators
cc'd qemu-stable
ui/vnc.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index cffb5b7..f989dfb 10064
known
Strip the brackets to make it work again.
Signed-off-by: Ján Tomko
---
ui/vnc.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index cffb5b7..49af7c7 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3482,7 +3482,14 @@ void vnc_display_open(const cha
On 05/15/2014 11:19 PM, Eric Blake wrote:
> On 05/15/2014 01:22 AM, Ján Tomko wrote:
>> If virDomainMemoryStats is called too soon after domain startup,
>> QEMU returns:
>> "error":{"class":"GenericError","desc":"guest ha
hives/libvir-list/2014-May/msg00460.html
Tested against current upstream libvirt - stat reporting works and
it no longer logs errors when the stats are queried on domain startup.
(Note: libvirt doesn't use the last-update field for anything yet)
Signed-off-by: Ján Tomko
---
v1: https://lists
On 05/16/2014 03:13 PM, Luiz Capitulino wrote:
> On Fri, 16 May 2014 00:11:24 -0600
> Eric Blake wrote:
>
>>> Is "no stats yet" really an error?
>
> This is a special case where the guest hasn't ever filled QEMU with balloon
> stats. There are two possible cases. Either the guest hasn't done it
hives/libvir-list/2014-May/msg00460.html
Signed-off-by: Ján Tomko
---
hw/virtio/virtio-balloon.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 971a921..6661c53 100644
--- a/hw/virtio/virtio-balloon
On 05/06/2014 03:39 PM, Stefan Hajnoczi wrote:
> On Tue, Apr 01, 2014 at 02:34:58PM -0600, Chris Friesen wrote:
>> When running qemu with something like this
>>
>> -device virtio-serial \
>> -chardev socket,path=/tmp/foo,server,nowait,id=foo \
>> -device virtserialport,chardev=foo,name=host.port.0
On 05/07/2014 01:13 AM, Mike Perez wrote:
> Hi everyone,
>
> I would like be able to configure virtio-scsi options num_queues, max_sectors,
> and cmd_per_lun via libvirt. Are there any plans to have this support?
>
num_queues is supported for virtio-scsi controllers since libvirt 1.0.5:
On 04/10/2014 02:46 PM, Alexander Graf wrote:
>
> On 10.04.2014, at 14:44, Eric Blake wrote:
>
>> On 04/10/2014 05:17 AM, Peter Maydell wrote:
>>> So far I know of at least three fixes which should probably
>>> go into 2.0:
>>> * my fix for the configure stack-protector checks on MacOSX
>>> * MS
On 08/19/2013 11:25 AM, Kevin Wolf wrote:
> By the time that qemu 1.7 will be released, enough time will has passed
> since qemu 1.1, which is the first version to understand version 3
> images, that changing the default shouldn't hurt many people any more
> and the benefits of using the new format
On 06/18/2013 11:42 AM, Paolo Bonzini wrote:
> Il 03/06/2013 17:54, Ján Tomko ha scritto:
>> According to RFC 1123 [1], hostnames can start with a digit too.
>>
>> [1] http://tools.ietf.org/html/rfc1123#page-13
>>
>> Signed-off-by: Ján Tomko
>> ---
&
On 06/04/2013 11:27 PM, Paolo Bonzini wrote:
> Il 03/06/2013 17:54, Ján Tomko ha scritto:
>> Otherwise they would get passed to getaddrinfo and fail with:
>> address resolution failed for [::1]:1234: Name or service not known
>
> Hmm... Hai Huang found a similar problem:
On 06/04/2013 02:19 PM, Stefan Hajnoczi wrote:
>
> CCing Kevin who authored v1.4.0-736-gf17c90b.
>
> Stefan
>
I've already posted patches for both issues:
http://lists.nongnu.org/archive/html/qemu-devel/2013-06/msg00227.html
Jan
According to RFC 1123 [1], hostnames can start with a digit too.
[1] http://tools.ietf.org/html/rfc1123#page-13
Signed-off-by: Ján Tomko
---
util/qemu-sockets.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index
Otherwise they would get passed to getaddrinfo and fail with:
address resolution failed for [::1]:1234: Name or service not known
(Broken by commit v1.4.0-736-gf17c90b)
Signed-off-by: Ján Tomko
---
block/nbd.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a
Fix parsing of NBD URIs with IPv6 addresses, broken by v1.4.0-736-gf17c90b
and fix parsing of NBD filenames with hostnames starting with a digit (fixed
by the same commit, but only for NBD URIs):
https://lists.gnu.org/archive/html/qemu-devel/2013-05/msg04719.html
Ján Tomko (2):
qemu-socket
1 - 100 of 105 matches
Mail list logo
