Re: [Qemu-devel] [PATCH] migration: use g_free for ram load bitmap

[Ján Tomko]

On Fri, May 25, 2018 at 09:50:42AM +0800, Peter Xu wrote:

Buffers allocated with bitmap_new() should be freed with g_free().

Both reported by Coverity:

*** CID 1391300:  API usage errors  (ALLOC_FREE_MISMATCH)
/migration/ram.c: 3517 in ram_dirty_bitmap_reload()
3511          * the last one to sync, we need to notify the main send thread.
3512          */
3513         ram_dirty_bitmap_reload_notify(s);
3514
3515         ret = 0;
3516     out:

    CID 1391300:  API usage errors  (ALLOC_FREE_MISMATCH)
    Calling "free" frees "le_bitmap" using "free" but it should have been freed using 
"g_free".

3517         free(le_bitmap);
3518         return ret;
3519     }
3520
3521     static int ram_resume_prepare(MigrationState *s, void *opaque)
3522     {

*** CID 1391292:  API usage errors  (ALLOC_FREE_MISMATCH)
/migration/ram.c: 249 in ramblock_recv_bitmap_send()
243          * Mark as an end, in case the middle part is screwed up due to
244          * some "misterious" reason.
245          */
246         qemu_put_be64(file, RAMBLOCK_RECV_BITMAP_ENDING);
247         qemu_fflush(file);
248

    CID 1391292:  API usage errors  (ALLOC_FREE_MISMATCH)
    Calling "free" frees "le_bitmap" using "free" but it should have been freed using 
"g_free".

249         free(le_bitmap);
250
251         if (qemu_file_get_error(file)) {
252             return qemu_file_get_error(file);
253         }
254

Signed-off-by: Peter Xu <pet...@redhat.com>
---
migration/ram.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Ján Tomko <jto...@redhat.com>

Jano

signature.asc
Description: Digital signature