* Peter Xu (pet...@redhat.com) wrote:
> On Tue, Jun 10, 2025 at 12:08:23AM +, Dr. David Alan Gilbert wrote:
> > > diff --git a/qapi/migration.json b/qapi/migration.json
> > > index 4963f6ca12..e95b7402cb 100644
> > > --- a/qapi/migration.json
> > > ++
262 ms ]: 0
> [ 262 ms - 524 ms ]: 0
> [ 524 ms -1 sec ]: 0
> [1 sec -2 sec ]: 0
> [2 sec -4 sec ]: 0
> [4 sec -8 sec ]: 0
> [8 sec - 16 sec ]: 0
>
> Cc: Dr. David
doc that this is not the real average
> fault latency, but only the ones that was requested for a remote fault.
>
> Unwrap get_vcpu_blocktime_list() so we don't need to walk the list twice,
> meanwhile add the entry checks in qtests for all postcopy tests.
>
> Cc: Markus Ar
_0021_EAX_NULL_SEL_CLR_BASE(1U << 6)
> /* Automatic IBRS */
> #define CPUID_8000_0021_EAX_AUTO_IBRS(1U << 8)
> +/* Indicates support for IC prefetch */
> +#define CPUID_8000_0021_EAX_PREFETCHI(1U << 20)
> /* Enhanc
where this was only set if an nvme-subsys device was explicitly
created (to configure a subsystem with multiple controllers/namespaces).
Revert the behavior to only set CMIC.MCTRS if an nvme-subsys device is
created explicitly.
Reported-by: Alan Adamson
Fixes: cd59f50ab017 ("hw/nvme: alwa
not subject to partial updates, thereby
improving
the robustness of atomic operations across boundaries.
See the NVMe Specification for more information.
Alan Adamson (2):
hw/nvme: enable ns atomic writes
hw/nvme: add atomic boundary support
hw/nv
NVMe Specification for more information.
Signed-off-by: Alan Adamson
---
hw/nvme/ctrl.c | 23 +++
hw/nvme/ns.c | 38 ++
hw/nvme/nvme.h | 6 ++
3 files changed, 67 insertions(+)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index fd935507
=UINT16 (default: 0)
See the NVMe Specification for more information.
Signed-off-by: Alan Adamson
---
hw/nvme/ctrl.c | 53 ++
hw/nvme/ns.c | 36 ++
hw/nvme/nvme.h | 8
3 files changed, 97 insertions(+)
diff
elements and also sort them.
> >
> > To fix it, simply loop over the uint32List manually. Now it looks like:
> >
> > Postcopy vCPU Blocktime (ms):
> >[15, 0, 0, 43, 29, 34, 36, 29, 37, 41,
> > 33, 37, 45, 52, 50, 38, 40, 37, 40, 49,
> > 40, 35, 3
the QMP interface
> when necessary.
>
> - Sub-grouping for "Transfers" ("Channels" and "Page Types").
>
> - Better indentations
Thanks,
Acked-by: Dr. David Alan Gilbert
> Sample output:
>
> (qemu) info migrate
> Status:
it is for those humans find easiest - that's the H in HMP!
(Those AIs can parse Json way easier than I can read Json!)
Of course you don't need to reorg it all at once again, if someone finds
one section hard, then reorg the way that people find it easy.
> It's already in a pull, let's revisit whenever necessary. Thanks for the
> input!
>
Nod.
Dave
> --
> Peter Xu
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
Reposting.
Alan
On 5/1/25 11:45 AM, Alan Adamson wrote:
If there are multiple controllers in a subsystem, CMIC.MCTRS should be set to on
for all controllers. For single controller subsystems, CMIC.MCTRS will be off by
default. A new subsystem specific parameter will allow setting CMIC.MCTRS
* Peter Xu (pet...@redhat.com) wrote:
> On Wed, May 14, 2025 at 08:29:53PM +, Dr. David Alan Gilbert wrote:
> > * Peter Xu (pet...@redhat.com) wrote:
> > > A new parameter "-a" is added to "info migrate" to dump all info, while
> > > when not sp
normal" pages)
> - Regroup things, so that related fields will show together
> - etc.
Thanks for the update,
Reviewed-by: Dr. David Alan Gilbert
Note that you did miss the change (which would be fine as a follow up)
where I point out that I think your unit abbreviations are sl
+migration_global_dump(mon);
> +
> params = qmp_query_migrate_parameters(NULL);
>
> if (params) {
> --
> 2.49.0
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
s->mbps = ((double) bytes * 8.0) / transfer_time / 1000;
> Sizes (KB): psize=4, total=16777992
and I think that is actually (KiB) i.e. 2^10 bytes
Other than those,
Reviewed-by: Dr. David Alan Gilbert
> transferred=15697718, remain=12383520,
> precopy=2, multifd=156977
t
> before incoming")
> Signed-off-by: Peter Xu
Reviewed-by: Dr. David Alan Gilbert
> ---
> migration/options.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/migration/options.c b/migration/options.c
> index 3fcd577cd7..162c72cda4 1006
Parameter (See NVMe Specification for details):
,cmic-mctrs=BOOLEAN (default: off)
Signed-off-by: Alan Adamson
---
hw/nvme/ctrl.c | 15 ++-
hw/nvme/nvme.h | 2 ++
hw/nvme/subsys.c | 1 +
3 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/hw/nvme/ctrl.c b/hw/nvme
systems.
,cmic-mctrs=BOOLEAN (default: off)
Example:
-device nvme-subsys,id=subsys0,cmic-mctrs=on \
-device
nvme,serial=deadbeef,id=nvme0,subsys=subsys0,atomic.dn=off,atomic.awun=31,atomic.awupf=15
\
-drive id=ns1,file=/dev/nullb0,if=none \
-device nvme-ns,drive=ns1,bus=nvm
* Dongli Zhang (dongli.zh...@oracle.com) wrote:
>
>
> On 4/21/25 6:38 AM, Dr. David Alan Gilbert wrote:
> > Hi Steve,
> > I've just had a go with cpr-transfer, it's quite interesting.
> > I was just trying it on my (AMD) desktop.
> >
> > *
, "addr": { "transport":
"socket", "type": "unix", "path": "cpr.sock"}}'
Dave
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
v2: - Change the parameter name from "cmic" to "cmic-mctrs".
- If there is more than 1 controller in a subsystem, set CMIC.MCTRS
for each controller whether or not the cmic-mctrs parameter is set.
While testing Linux atomic writes with qemu-nvme v10.0.0-rc1, Linux was
incorrectly displa
Parameter (See NVMe Specification for details):
,cmic-mctrs=BOOLEAN (default: off)
Signed-off-by: Alan Adamson
---
hw/nvme/ctrl.c | 15 ++-
hw/nvme/nvme.h | 2 ++
hw/nvme/subsys.c | 1 +
3 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/hw/nvme/ctrl.c b/hw/nvme
On 4/8/25 11:47 PM, Klaus Jensen wrote:
On Apr 8 15:56, Alan Adamson wrote:
While testing Linux atomic writes with qemu-nvme v10.0.0-rc1, Linux was
incorrectly displaying atomic_write_max_bytes
# cat /sys/block/nvme0n1/queue/atomic_write_max_bytes
0
# nvme id-ctrl /dev/nvme0n1 | grep awupf
Allow the value of CMIC to to be set via a new subsystem specific parameter.
This removes the requirement that all subsystems must have the CMIC bit enabled.
New NVMe Subsystem QEMU Parameter (See NVMe Specification for details):
,cmic=BOOLEAN (default: off)
Signed-off-by: Alan Adamson
le:
-device nvme-subsys,id=subsys0,cmic=on \
-device
nvme,serial=deadbeef,id=nvme0,subsys=subsys0,atomic.dn=off,atomic.awun=31,atomic.awupf=15
\
-drive id=ns1,file=/dev/nullb3,if=none \
-device nvme-ns,drive=ns1,bus=nvme0,nsid=1,shared=false
Alan Adamson (1):
hw/nvme: create
Tested-by: Alan Adamson
Reviewed-by: Alan Adamson
llers.
I'm sending out diffs that resolve the problem but would like to get
some feedback before sending a formal patch.
See below.
Thanks,
Alan Adamson
[root@localhost qemu-subsys]# git describe
v10.0.0-rc2
[root@localhost qemu-subsys]#
QEMU NVMe Config
-device n
eries to rename *all* of them and
> deprecate the previous names, I don't see the point why changing just one
> single s390x command is necessary.
I'd probably agree; mind you, it wouldn't be a bad convention to
adopt in general.
For HMP, since there's no need to have a fixed schema for a command,
it would be fine to have a generic command for all architectures
that have a similar idea even if their data is very different.
Dave
> Thomas
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
* Maciej S. Szmigiero (m...@maciej.szmigiero.name) wrote:
> On 2.02.2025 03:06, Dr. David Alan Gilbert wrote:
> > * Maciej S. Szmigiero (m...@maciej.szmigiero.name) wrote:
> > > From: "Maciej S. Szmigiero"
> > >
> > > postcopy_ram_listen_thr
rcu_unregister_thread();
> mis->have_listen_thread = false;
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
dsa-accel
> dsa-accel-path="dsa: dsa:[dsa_dev_path2] ..."
oops, commit message needs updating, but other than that,
for HMP:
Acked-by: Dr. David Alan Gilbert
Thanks for making the changes,
Dave
> This feature is turned off by default.
>
> Signed-off-by: Hao Xiang
nt, int
> > format, int wsize,
> > case 8:
> > v = ldq_p(buf + i);
> > break;
> > +default:
> > +v = ldub_p(buf + i);
> > +break;
> > }
> >
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Thu, Sep 19, 2024 at 12:26:33AM +0100, d...@treblig.org wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > socket_remote_address hasn't been used since it was added in
> > 17c55decec ("sockets
* Yichen Wang (yichen.w...@bytedance.com) wrote:
> On Fri, Oct 11, 2024 at 10:14 AM Dr. David Alan Gilbert
> wrote:
> >
> > * Yichen Wang (yichen.w...@bytedance.com) wrote:
> > > From: Hao Xiang
> >
> > Please split the cpuid stuff out into a separate p
ationThread, 1);
> - thread->name = name;
> -thread->thread_id = thread_id;
> -
> -WITH_QEMU_LOCK_GUARD(&migration_threads_lock) {
> -QLIST_INSERT_HEAD(&migration_threads, thread, node);
> -}
> -
> -return thread;
> -}
> -
> -void migration_threads_remove(MigrationThread *thread)
> -{
> -QEMU_LOCK_GUARD(&migration_threads_lock);
> -if (thread) {
> -QLIST_REMOVE(thread, node);
> -g_free(thread);
> -}
> -}
> -
> -MigrationThreadInfoList *qmp_query_migrationthreads(Error **errp)
> -{
> -MigrationThreadInfoList *head = NULL;
> -MigrationThreadInfoList **tail = &head;
> -MigrationThread *thread = NULL;
> -
> -QEMU_LOCK_GUARD(&migration_threads_lock);
> -QLIST_FOREACH(thread, &migration_threads, node) {
> -MigrationThreadInfo *info = g_new0(MigrationThreadInfo, 1);
> -info->name = g_strdup(thread->name);
> -info->thread_id = thread->thread_id;
> -
> -QAPI_LIST_APPEND(tail, info);
> -}
> -
> -return head;
> -}
> diff --git a/migration/meson.build b/migration/meson.build
> index 66d3de86f0..28a680e5e2 100644
> --- a/migration/meson.build
> +++ b/migration/meson.build
> @@ -29,7 +29,6 @@ system_ss.add(files(
>'savevm.c',
>'socket.c',
>'tls.c',
> - 'threadinfo.c',
> ), gnutls, zlib)
>
> if get_option('replication').allowed()
> --
> 2.45.0
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
only has effect if the @mapped-ram capability is enabled.
> # (Since 9.1)
> @@ -1270,7 +1293,8 @@
> '*vcpu-dirty-limit': 'uint64',
> '*mode': 'MigMode',
> '*zero-page-detection':
d having this much extra code for each one?
Dave
>
> Thanks,
>
> --
> Peter Xu
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
> build currently breaks when compiling with "--enable-werror". Remove
> the unused functions to get it going again.
>
> Fixes: 95b9c27c81 ("linux-user: Remove unused handle_vm86_fault")
> Signed-off-by: Thomas Huth
Sorry about that - thanks for the f
* Michael Tokarev (m...@tls.msk.ru) wrote:
> 19.09.2024 01:51, d...@treblig.org wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > net_rx_pkt_get_l3_hdr_offset and net_rx_pkt_get_iovec_len haven't
> > been used since they were added.
> >
> >
r = qdict_haskey(qdict, "virt") ? &filter_addr : NULL;
> +
I'm a bit confused about the format of the parameter you're trying to use;
can you add an example in the commit message please.
> env = mon_get_cpu_env(mon);
> if (!env) {
> moni
* Peter Xu (pet...@redhat.com) wrote:
> The QMP command was added in 671326201d ("migration: Introduce interface
> query-migrationthreads", v8.0). Add the HMP version of it.
>
> Cc: Markus Armbruster
> Cc: Dr. David Alan Gilbert
> Signed-off-by: Peter Xu
&g
* Peter Xu (pet...@redhat.com) wrote:
> On Thu, Sep 19, 2024 at 02:46:25PM +0100, d...@treblig.org wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > Use the uffd_copy_page, uffd_zero_page and uffd_wakeup helpers
> > rather than calling ioctl ourselves.
>
.
Signed-off-by: Alan Adamson
Reviewed-by: Klaus Jensen
---
hw/nvme/ctrl.c | 157 -
hw/nvme/nvme.h | 11
2 files changed, 167 insertions(+), 1 deletion(-)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 9e94a2405407..c8346709a20d 100644
--- a
536
(requested block: offset=347799552, length=65536, flags=88)
Expected CRC: d54d5f50d2569c94
Received CRC: 691e1aed4669ba33
Future Work
---
- Namespace support (NAWUN, NAWUPF and NACWU)
- Namespace Boundary support (NABSN, NABO, and NABSPF)
- Atomic Compare and Write Unit
On 9/24/24 5:15 AM, Klaus Jensen wrote:
On Sep 19 17:07, Alan Adamson wrote:
Adds support for the controller atomic parameters: AWUN and AWUPF. Atomic
Compare and Write Unit (ACWU) is not currently supported.
Writes that adhere to the ACWU and AWUPF parameters are guaranteed to be atomic
.
Signed-off-by: Alan Adamson
Reviewed-by: Klaus Jensen
---
hw/nvme/ctrl.c | 164 -
hw/nvme/nvme.h | 12
2 files changed, 175 insertions(+), 1 deletion(-)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 9e94a2405407..0af46c57ee86 100644
--- a
- Atomic Compare and Write Unit (ACWU)
Alan Adamson (1):
hw/nvme: add atomic write support
hw/nvme/ctrl.c | 164 -
hw/nvme/nvme.h | 12
2 files changed, 175 insertions(+), 1 deletion(-)
--
2.43.5
* Bernhard Beschow (shen...@gmail.com) wrote:
>
>
> Am 18. September 2024 00:51:32 UTC schrieb d...@treblig.org:
> >From: "Dr. David Alan Gilbert"
> >
> >mch_mcfg_base has been unused since it was added by
> > 6f1426ab0f ("ich9: APIs
; Jag
>
> > On Sep 18, 2024, at 1:00 PM, Dr. David Alan Gilbert
> > wrote:
> >
> > Hi Jag,
> > One of my scripts noticed that 'remote_iohub_finalize' in
> > hw/remote/iohub.c is unused; before I go and delete it as deadcode,
> > is that actu
* d...@treblig.org (d...@treblig.org) wrote:
> From: "Dr. David Alan Gilbert"
>
> qemu_clock_get_main_loop_timerlist has been unused since it was
> originally added in
> ff83c66ecc ("aio / timers: Split QEMUClock into QEMUClock and
> QEMUTimerList")
* Fabiano Rosas (faro...@suse.de) wrote:
> Markus Armbruster writes:
>
> > Peter Xu writes:
> >
> >> On Wed, Sep 18, 2024 at 07:52:56AM +0200, Markus Armbruster wrote:
> >>> d...@treblig.org writes:
> >>>
> >>> > From: "
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Thu, Sep 19, 2024 at 01:00:34AM +0100, d...@treblig.org wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > qio_channel_socket_dgram_async has been unused since it was originally
> > added in 2015.
> &
Hi Jag,
One of my scripts noticed that 'remote_iohub_finalize' in
hw/remote/iohub.c is unused; before I go and delete it as deadcode,
is that actually just a missing call somewhere?
Dave
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Al
On 9/17/24 9:21 AM, alan.adam...@oracle.com wrote:
On 9/17/24 12:59 AM, Klaus Jensen wrote:
On Aug 20 09:11, Alan Adamson wrote:
Since there is work in the Linux NVMe Driver community to add Atomic
Write
support, it would be desirable to be able to test it with qemu nvme
emulation.
This
On 9/17/24 12:59 AM, Klaus Jensen wrote:
On Aug 20 09:11, Alan Adamson wrote:
Since there is work in the Linux NVMe Driver community to add Atomic Write
support, it would be desirable to be able to test it with qemu nvme emulation.
This patch will focus on supporting NVMe controller atomic
ite support, this error no longer happens.
Future Work
---
- Namespace support (NAWUN, NAWUPF and NACWU)
- Namespace Boundary support (NABSN, NABO, and NABSPF)
- Atomic Compare and Write Unit (ACWU)
Alan Adamson (1):
hw/nvme: add atomic write support
hw/nvme/c
.
Signed-off-by: Alan Adamson
---
hw/nvme/ctrl.c | 161 +
hw/nvme/nvme.h | 12
2 files changed, 173 insertions(+)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index c6d4f61a47f9..ac0efa95588d 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
l;
> +}
> +
> /**
> * qdict_get_try_bool(): Try to get a bool mapped by 'key'
> *
> diff --git a/system/cpus.c b/system/cpus.c
> index 5e3a988a0a..25d7d7c93f 100644
> --- a/system/cpus.c
> +++ b/system/cpus.c
> @@ -792,7 +792,34 @@ int vm_stop_fo
;
> +bool nested;
>
> -env = mon_get_cpu_env(mon);
> -if (!env) {
> -monitor_printf(mon, "No CPU available\n");
> +if (!cs) {
> +monitor_printf(mon, "Unable to get CPUState. Internal error\n");
I wouldn't bother saying &
malloc_trim() you propose interact with this one?
>
> The above usage is automatic, while this proposal requires that
> an external mgmt app monitor QEMU and tell it to free memory.
> I'm wondering if the latter is really desirable, or whether QEMU
> can call this itself when reasonable ?
>
>
> With regards,
> Daniel
> --
> |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o-https://fstop138.berrange.com :|
> |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
ector;
> +u16 guest_intr_status;
> +u16 host_es_selector;
> +u16 host_cs_selector;
> +u16 host_ss_selector;
> +u16 host_ds_selector;
> + u16 host_fs_selector;
> +u16 host_gs_selector;
> +u16 ho
* Markus Armbruster (arm...@redhat.com) wrote:
> "Dr. David Alan Gilbert" writes:
>
> > * Markus Armbruster (arm...@redhat.com) wrote:
> >> Philippe Mathieu-Daudé writes:
> >>
> >> > Hi Daniel, Dave, Markus & Thomas.
> >> >
* Pierrick Bouvier (pierrick.bouv...@linaro.org) wrote:
> On 6/17/24 13:56, Dr. David Alan Gilbert wrote:
> > * Pierrick Bouvier (pierrick.bouv...@linaro.org) wrote:
> > > On 6/14/24 15:00, Dr. David Alan Gilbert wrote:
> > > > * Pierrick Bouvier (pierrick.bouv...@l
* Pierrick Bouvier (pierrick.bouv...@linaro.org) wrote:
> On 6/14/24 15:00, Dr. David Alan Gilbert wrote:
> > * Pierrick Bouvier (pierrick.bouv...@linaro.org) wrote:
> > > Hi Dave,
> > >
> > > On 6/12/24 14:02, Dr. David Alan Gilbert wrote:
> > > &
* Martin Joerg (martin.jo...@gmail.com) wrote:
> Signed-off-by: Martin Joerg
Thanks!
(Trivial please take that).
Reviewed-by: Dr. David Alan Gilbert
> ---
> hmp-commands-info.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hmp-commands-info
* Pierrick Bouvier (pierrick.bouv...@linaro.org) wrote:
> Hi Dave,
>
> On 6/12/24 14:02, Dr. David Alan Gilbert wrote:
> > * Alex Bennée (alex.ben...@linaro.org) wrote:
> > > From: Pierrick Bouvier
> > >
> > > This plugin uses the new time control i
> +time_handle = qemu_plugin_request_time_control();
> +g_assert(time_handle);
> +
> +qemu_plugin_register_vcpu_tb_trans_cb(id, vcpu_tb_trans);
> +qemu_plugin_register_vcpu_init_cb(id, vcpu_init);
> +qemu_plugin_register_vcpu_exit_cb(id, vcpu_exit);
> +qemu_plugin_register_atexit_cb(id, plugin_exit, NULL);
> +
> +return 0;
> +}
> diff --git a/contrib/plugins/Makefile b/contrib/plugins/Makefile
> index 0b64d2c1e3..449ead1130 100644
> --- a/contrib/plugins/Makefile
> +++ b/contrib/plugins/Makefile
> @@ -27,6 +27,7 @@ endif
> NAMES += hwprofile
> NAMES += cache
> NAMES += drcov
> +NAMES += ips
>
> ifeq ($(CONFIG_WIN32),y)
> SO_SUFFIX := .dll
> --
> 2.39.2
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
or host memory addresses).
It's also hopelessly cryptic.
From an HMP point, a 'info debug ' seems good to me,
possibly with some options as to whether to recurse or perhaps
add flags to 'info qtree' to also call it.
Dave
> -- PMM
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
mp-target.c
> index 1eb72ac1bf..0466474354 100644
> --- a/monitor/hmp-target.c
> +++ b/monitor/hmp-target.c
> @@ -36,11 +36,6 @@
> #include "qapi/error.h"
> #include "qemu/cutils.h"
>
> -#if defined(TARGET_S390X)
> -#include "hw/s390x/storage-keys.h"
> -#include "hw/s390x/storage-attributes.h"
> -#endif
> -
> /* Make devices configuration available for use in hmp-commands*.hx
> templates */
> #include CONFIG_DEVICES
>
> --
> 2.41.0
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
fo_ramblock() in commit ca411b7c8a ("qapi: introduce
> x-query-ramblock QMP command")
>
> and hmp_info_irq() in commit 91f2fa7045 ("qapi: introduce
> x-query-irq QMP command").
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Dr. David Alan Gilbert
* Dr. David Alan Gilbert (d...@treblig.org) wrote:
> A bunch of structs that are currently unused,
> found with a simple script and a bit of eyeballing.
>
> The only one I'm that suspicious of is the SPARC
> one, where the patch which removed the use is a bit
> confu
* Peter Xu (pet...@redhat.com) wrote:
> Hey, Dave!
Hey!
> On Wed, Jun 05, 2024 at 12:31:56AM +, Dr. David Alan Gilbert wrote:
> > * Michael Galaxy (mgal...@akamai.com) wrote:
> > > One thing to keep in mind here (despite me not having any hardware to
> > > t
* Markus Armbruster (arm...@redhat.com) wrote:
> Philippe Mathieu-Daudé writes:
>
> > Hi Daniel, Dave, Markus & Thomas.
> >
> > On 4/6/24 06:58, Markus Armbruster wrote:
> >> "Dr. David Alan Gilbert" writes:
> >>> * Daniel P. Berrangé
provide good support and work together.
> > > > >
> > > > We are happy to provide the necessary review and maintenance work for
> > > > RDMA
> > > > if the community needs it.
> > > >
> > > > CC'ing Chuan Zheng.
r/monitor-internal.h
> >> @@ -168,7 +168,6 @@ extern bool qmp_dispatcher_co_shutdown;
> >> extern QmpCommandList qmp_commands, qmp_cap_negotiation_commands;
> >> extern QemuMutex monitor_lock;
> >> extern MonitorList mon_list;
> >> -ext
ckr.com/photos/dberrange :|
> |: https://libvirt.org -o-https://fstop138.berrange.com :|
> |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
* Thomas Huth (th...@redhat.com) wrote:
> On 31/05/2024 16.02, Dr. David Alan Gilbert wrote:
> > * Thomas Huth (th...@redhat.com) wrote:
> > > On 30/05/2024 09.45, Philippe Mathieu-Daudé wrote:
> > > > We are trying to unify all qemu-system-FOO to a single binary.
>
> -env = mon_get_cpu_env(mon);
> -if (!env) {
> -monitor_printf(mon, "No CPU available\n");
> +CPUState *cs = mon_get_cpu(mon);
> +if (!cs) {
> +monitor_printf(mon, "Unable to get CPUState. Internal error\n");
> return;
> }
>
> -if (!(env->cr[0] & CR0_PG_MASK)) {
> -monitor_printf(mon, "PG disabled\n");
> +if (!init_iterator(mon, &state)) {
> return;
> }
> -if (env->cr[4] & CR4_PAE_MASK) {
> -#ifdef TARGET_X86_64
> -if (env->hflags & HF_LMA_MASK) {
> -if (env->cr[4] & CR4_LA57_MASK) {
> -tlb_info_la57(mon, env);
> -} else {
> -tlb_info_la48(mon, env, 0, env->cr[3] & 0x3f000ULL);
> -}
> -} else
> -#endif
> -{
> -tlb_info_pae32(mon, env);
> -}
> -} else {
> -tlb_info_32(mon, env);
> -}
> +
> +/**
> + * 'info tlb' visits only leaf PTEs marked present.
> + * It does not check other protection bits.
> + */
> +for_each_pte(cs, &mem_print_tlb, &state, false, false);
> }
>
> static void mem_print(Monitor *mon, CPUArchState *env,
> --
> 2.34.1
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
&& ent2prot(state->ent[height]) == prot
> + && (((state->last_offset[height] + 1) % entries_per_node)
> + == offset)
> + && ((!is_leaf)
> + || (!state->requi
al address
and then use that to associate some security; I think that's closer
to what MTE is isn't it?
I'm not sure the two fit in the same command.
Dave
> Or should it maybe rather be an option to the existing "dump-guest-memory"
> command i
; limited shm size under Gitlab CI. Now that it uses /tmp, enable it.
If it does fail, lets see if we can figure out how, i.e. whether it's the
shm size or something else.
Reviewed-by: Dr. David Alan Gilbert
> Cc: Yury Kotov
> Cc: Dr. David Alan Gilbert
> Signed-off-by: Nicho
* Dr. David Alan Gilbert (d...@treblig.org) wrote:
> This struct is unused since Peter's
> Commit b8ae597f0e6d ("linux-user/sparc: Fix errors in target_ucontext
> structures")
>
> However, hmm, I'm a bit confused since that commit modifies the
> structure and
* BALATON Zoltan (bala...@eik.bme.hu) wrote:
> On Sun, 5 May 2024, BALATON Zoltan wrote:
> > On Sun, 5 May 2024, Dr. David Alan Gilbert wrote:
> > > I think it's use was removed by
> > > Commit 5883d8b296 ("mmu-hash*: Don't use full ppc_hash{32,
> >
* Richard Henderson (richard.hender...@linaro.org) wrote:
> On 5/5/24 10:14, Dr. David Alan Gilbert wrote:
> > The structs 'target_fpxreg' and 'target_xmmreg' are unused since
> > Paolo's:
> >
> > Commit 2796f290b546 ("linux-user: i3
This struct is unused since Peter's
Commit b8ae597f0e6d ("linux-user/sparc: Fix errors in target_ucontext
structures")
However, hmm, I'm a bit confused since that commit modifies the
structure and then removes it, was that intentional?
Signed-off-by: Dr. David Alan Gilbert
-
The structs 'target_fpxreg' and 'target_xmmreg' are unused since
Paolo's:
Commit 2796f290b546 ("linux-user: i386/signal: support FXSAVE fpstate on
32-bit emulation")
Signed-off-by: Dr. David Alan Gilbert
---
linux-user/i386/signal.c | 10 --
1 file c
Since 'setup_rt_frame' has never been implemented, this struct
is unused.
Signed-off-by: Dr. David Alan Gilbert
---
linux-user/cris/signal.c | 8
1 file changed, 8 deletions(-)
diff --git a/linux-user/cris/signal.c b/linux-user/cris/signal.c
index 4f532b2903..10948bcf30 10
u,arm-softmmu,aarch64-softmmu,cris-linux-user,i386-linux-user,sparc-linux-user
and 'make check' on x86 linux.
Dave
Dr. David Alan Gilbert (7):
linux-user: cris: Remove unused struct 'rt_signal_frame'
linux-user: i386/signal: Remove unused fp structs
linux-user: sp
As far as I can tell this struct has never been used in this
file (it is used in can_core.c).
Signed-off-by: Dr. David Alan Gilbert
---
net/can/can_host.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/net/can/can_host.c b/net/can/can_host.c
index a3c84028c6..b2fe553f91 100644
--- a
This struct has been unused since
Commit f932093ae165 ("hw/arm/bcm2836: Split out common part of BCM283X
classes")
Signed-off-by: Dr. David Alan Gilbert
---
hw/arm/bcm2836.c | 12
1 file changed, 12 deletions(-)
diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c
index
I think it's use was removed by
Commit 5883d8b296 ("mmu-hash*: Don't use full ppc_hash{32,
64}_translate() path for get_phys_page_debug()")
Signed-off-by: Dr. David Alan Gilbert
---
target/ppc/mmu-hash32.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/target/ppc/m
As far as I can tell it was never used.
Signed-off-by: Dr. David Alan Gilbert
---
hw/usb/dev-network.c | 8
1 file changed, 8 deletions(-)
diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c
index 2c33e36cad..d00d68b21d 100644
--- a/hw/usb/dev-network.c
+++ b/hw/usb/dev-network.c
ri*
> > +``migrate [-d]`` *uri*
> >Migrate to *uri* (using -d to not wait for completion).
> > -
> > - ``-b``
> > -for migration with full copy of disk
> > ERST
>
> Not this patch's fault, but here goes anyway: -r is undocumented here.
Probably one for Peter I guess.
Dave
> >
> > {
>
> [...]
>
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\dave @ treblig.org | | In Hex /
\ _|_ http://www.treblig.org |___/
On Tue, Apr 23, 2024 at 02:10:13PM -0700, Guenter Roeck wrote:
> Hi Alan,
>
> On 4/23/24 10:30, Alan Stern wrote:
> > On Tue, Apr 23, 2024 at 10:04:17AM -0700, Guenter Roeck wrote:
> > > Hi,
> > >
> > > when testing usb-ohci
> >
> > What
gt;
> Question is: What is actually wrong ? Something in the generic interrupt
> handling code in Linux, something in the Linux usb-ohci driver, or
> something in qemu ? Any idea how a proper fix might look like ?
To answer these questions we need more information.
Alan Stern
r basically legacy reasons. And for the
> human monitor (HMP) we don't need to keep things around
> for backwards compatibility.
I'm not sure what happens for the (MIPS/SPARC ?) where it's not
a traditional table hierarchy.
The other thing you might want (and I'm
ory_mapping
>
> * tcg/sysemu/excp_helper.c: implements mmu_translate() and
> get_physical_address()
One thing to keep in mind (although I don't know the x86 code) is that
you want the monitor command not to change any state, nor to fail if
there's a particularly scre
=UINT16 (default: 0)
Signed-off-by: Alan Adamson
---
hw/nvme/ctrl.c | 147 -
hw/nvme/nvme.h | 17 ++
2 files changed, 163 insertions(+), 1 deletion(-)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 127c3d238346..5d19965122d0 100644
--- a/hw
as the max atomic write size.
Future Work
---
- Namespace support (NAWUN, NAWUPF and NACWU)
- Namespace Boundary support (NABSN, NABO, and NABSPF)
- Atomic Compare and Write Unit (ACWU)
Alan Adamson (1):
nvme: add atomic write support
hw
1 - 100 of 3088 matches
Mail list logo
