NULL dereference.
Signed-off-by: Akihiko Odaki
---
include/qapi/error.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/include/qapi/error.h b/include/qapi/error.h
index
41e38163804904874e5d114b699a3e2a93d3fc6d..4fa04980c2fd110aa68ced020dd1ec8a83d7d957
100644
-
On 2025/08/02 23:21, Michael Tokarev wrote:
The only user of this macro was VirtIONet.vlans, which has been
converted to regular VMSTATE_BUFFER.
Signed-off-by: Michael Tokarev
Nice cleanup.
Reviewed-by: Akihiko Odaki
NSAFE() macro.
Signed-off-by: Michael Tokarev
Reviewed-by: Akihiko Odaki
On 2025/08/02 23:45, Michael Tokarev wrote:
On 02.08.2025 17:21, Michael Tokarev wrote:
This field is a fixed-size buffer (number of elements is MAX_VLAN,
known at build time). There's no need to allocate it dynamically,
it can be made an integral part of VirtIONet structure.
This field is the
On 2025/08/02 2:27, Arun Menon wrote:
Hi Akihiko,
Thanks for the review.
On Fri, Aug 01, 2025 at 04:35:34PM +0900, Akihiko Odaki wrote:
On 2025/07/31 22:21, Arun Menon wrote:
Currently post_save hook is called without checking its return. If post_save
fails, we need to set an error and
On 2025/08/02 16:26, Michael Tokarev wrote:
On 27.07.2025 09:22, Akihiko Odaki wrote:
...
@@ -3942,6 +3943,7 @@ static void
virtio_net_device_realize(DeviceState *dev, Error **errp)
n->mac_table.macs = g_malloc0(MAC_TABLE_ENTRIES * ETH_ALEN);
n->vlans = g_malloc0(MAX_VLA
On 2025/08/01 22:27, Arun Menon wrote:
Hi Akihiko,
Thanks for the review.
On Fri, Aug 01, 2025 at 04:12:34PM +0900, Akihiko Odaki wrote:
On 2025/07/31 22:20, Arun Menon wrote:
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
On 2025/07/31 22:21, Arun Menon wrote:
The original vmstate_save_state_v() function combined multiple
responsibilities like calling pre-save hooks, saving the state of
the device, handling subsection saves and invoking post-save hooks.
This led to a lengthy and less readable function.
To address
On 2025/07/31 22:20, Arun Menon wrote:
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that vmstate_load() must report an error
in errp, in case of failure.
Reviewed-by: Marc-André
On 2025/07/31 22:21, Arun Menon wrote:
Currently post_save hook is called without checking its return. If post_save
fails, we need to set an error and propagate it to the caller.
Since post_save hook is called regardless of whether there is a preceeding
error,
it is possible that we have 2 dist
On 2025/07/31 22:20, Arun Menon wrote:
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that qemu_loadvm_state_main() must report an error
in errp, in case of failure.
loadvm_process_
On 2025/07/31 22:20, Arun Menon wrote:
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that qemu_loadvm_section_start_full() must report an error
in errp, in case of failure.
Signed
On 2025/07/31 22:20, Arun Menon wrote:
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that qemu_loadvm_state_header() must report an error
in errp, in case of failure.
Reviewed-by:
On 2025/07/31 22:20, Arun Menon wrote:
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that qemu_loadvm_state_header() must report an error
in errp, in case of failure.
Reviewed-by:
ting
it, you can ensure that, if this series causes a regression for TPM,
bisect will tell what led to the regression: the return value
propagation change or the addition of errp.
Regards,
Akihiko Odaki
ility is still maintained.
Signed-off-by: Akihiko Odaki
---
include/hw/arm/virt.h | 1 +
hw/arm/virt.c | 16
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
index
9a1b0f53d218cb6
efcd47110d ("pcie_sriov: Register VFs after migration")
Fixes: CVE-2025-54566
Fixes: CVE-2025-54567
Cc: qemu-sta...@nongnu.org
Reported-by: Corentin BAYET
Signed-off-by: Akihiko Odaki
---
Changes in v2:
- Changed to perform the VFEnable write mask update only when the bit is
clear
do not reset vlan filtering at set_features")
Cc: qemu-sta...@nongnu.org
Reported-by: Konstantin Shkolnyy
Signed-off-by: Akihiko Odaki
Tested-by: Konstantin Shkolnyy
Tested-by: Lei Yang
---
Not tested.
Konstantin, I would also want you to test this new version. Please also
give it Tested-by,
On 2025/07/25 21:19, Arun Menon wrote:
- We need to have good error reporting in the callbacks in
VMStateDescription struct. Specifically pre_save, post_save,
pre_load and post_load callbacks.
- It is not possible to change these functions everywhere in one
patch, therefore, we introduce
On 2025/07/24 4:31, Paolo Abeni wrote:
Extend the features configuration space to 128 bits. If the virtio
device supports any extended features, allow the common read/write
operation to access all of it, otherwise keep exposing only the
lower 64 bits.
On migration, save the 128 bit version of th
On 2025/07/24 4:31, Paolo Abeni wrote:
The virtio specifications allows for up to 128 bits for the
device features. Soon we are going to use some of the 'extended'
bits features for the virtio net driver.
Add support to allow extended features negotiation on a per
devices basis. Devices willing
On 2025/07/24 4:31, Paolo Abeni wrote:
The virtio specifications allows for up to 128 bits for the
device features. Soon we are going to use some of the 'extended'
bits features (bit 64 and above) for the virtio net driver.
Represent the virtio features bitmask with a fixes size array, and
intro
On 2025/07/18 17:52, Paolo Abeni wrote:
Tap devices support GSO over UDP tunnel offload. Probe for such
feature in a similar manner to other offloads.
GSO over UDP tunnel needs to be enabled in addition to a "plain"
offload (TSO or USO).
No need to check separately for the outer header checksum
On 2025/07/21 22:29, Daniel P. Berrangé wrote:
On Mon, Jul 21, 2025 at 10:14:30PM +0900, Akihiko Odaki wrote:
On 2025/07/21 20:29, Arun Menon wrote:
- We need to have good error reporting in the callbacks in
VMStateDescription struct. Specifically pre_save, post_save,
pre_load and
On 2025/07/21 20:29, Arun Menon wrote:
- We need to have good error reporting in the callbacks in
VMStateDescription struct. Specifically pre_save, post_save,
pre_load and post_load callbacks.
- It is not possible to change these functions everywhere in one
patch, therefore, we introduce
On 2025/07/21 20:29, Arun Menon wrote:
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that qemu_loadvm_state() must report an error
in errp, in case of failure.
Signed-off-by: Arun
On 2025/07/21 20:29, Arun Menon wrote:
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Arun Menon
---
migration/savevm.c | 16 +---
On 2025/07/21 20:29, Arun Menon wrote:
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_postcopy_handle_advise() must report an error
in errp, in case of failure.
Reviewe
On 2025/07/21 20:29, Arun Menon wrote:
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_process_command() must report an error
in errp, in case of failure.
Signed-off-by:
On 2025/07/21 20:29, Arun Menon wrote:
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that vmstate_load_state() must report an error
in errp, in case of failure.
Signed-off-by: Aru
On 2025/07/21 20:29, Arun Menon wrote:
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that vmstate_subsection_load() must report an error
in errp, in case of failure.
Signed-off-by
On 2025/07/21 16:51, Paolo Abeni wrote:
7/20/25 12:44 PM, Akihiko Odaki wrote:
On 2025/07/18 17:52, Paolo Abeni wrote:
@@ -,26 +3362,23 @@ virtio_load(VirtIODevice *vdev, QEMUFile *f, int
version_id)
vdev->device_endian = virtio_default_endian();
}
-
On 2025/07/21 16:33, Paolo Abeni wrote:
On 7/20/25 12:41 PM, Akihiko Odaki wrote:
On 2025/07/18 17:52, Paolo Abeni wrote:
diff --git a/include/hw/virtio/virtio-features.h
b/include/hw/virtio/virtio-features.h
new file mode 100644
index 00..68e326e3e8
--- /dev/null
+++ b/include/hw
On 2025/07/18 17:52, Paolo Abeni wrote:
Extend the VirtioDeviceFeatures struct with an additional u64
to track unknown features in the 64-127 bit range and decode
the full virtio features spaces for vhost and virtio devices.
Also add entries for the soon-to-be-supported virtio net GSO over
UDP f
On 2025/07/18 17:52, Paolo Abeni wrote:
If the driver uses any of the extended features (i.e. 64 or above),
store the extended features range (64-127 bits).
At load time, let legacy features initialize the full features range
and pass it to the set helper; sub-states loading will have filled-up
On 2025/07/18 17:52, Paolo Abeni wrote:
The virtio specifications allows for up to 128 bits for the
device features. Soon we are going to use some of the 'extended'
bits features (bit 64 and above) for the virtio net driver.
Represent the virtio features bitmask with a fixes size array, and
intr
On 2025/07/18 17:52, Paolo Abeni wrote:
The set_offload() argument list is already pretty long and
we are going to introduce soon a bunch of additional offloads.
Replace the offload arguments with a single struct and update
all the relevant call-sites.
No functional changes intended.
Signed-of
On 2025/07/16 0:49, Paolo Abeni wrote:
On 7/15/25 10:05 AM, Akihiko Odaki wrote:
On 2025/07/11 22:02, Paolo Abeni wrote:
diff --git a/net/tap-bsd.c b/net/tap-bsd.c
index 86b6edee94..e7de0672f4 100644
--- a/net/tap-bsd.c
+++ b/net/tap-bsd.c
@@ -217,6 +217,11 @@ int tap_probe_has_uso(int fd
On 2025/07/18 2:02, Daniel P. Berrangé wrote:
On Thu, Jul 17, 2025 at 12:34:21PM +0900, Akihiko Odaki wrote:
On 2025/07/17 9:37, Arun Menon wrote:
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor
On 2025/07/17 9:37, Arun Menon wrote:
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that ram_postcopy_incoming_init() must report an error
in errp, in case of failure.
Signed-off-
On 2025/07/17 9:37, Arun Menon wrote:
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_process_enable_colo() must report an error
in errp, in case of failure.
Signed-off-
On 2025/07/16 19:13, Paolo Abeni wrote:
On 7/15/25 10:07 AM, Akihiko Odaki wrote:
On 2025/07/11 22:02, Paolo Abeni wrote:
When any host or guest GSO over UDP tunnel offload is enabled the
virtio net header includes the additional tunnel-related fields,
update the size accordingly.
Push the
On 2025/07/16 0:43, Paolo Abeni wrote:
On 7/15/25 9:59 AM, Akihiko Odaki wrote:
On 2025/07/11 22:02, Paolo Abeni wrote:
@@ -785,11 +821,12 @@ VirtioStatus *qmp_x_query_virtio_status(const char *path,
Error **errp)
status->vhost_dev->nvqs = hdev->nvqs;
status-&
On 2025/07/16 18:14, Paolo Abeni wrote:
On 7/15/25 6:21 PM, Paolo Abeni wrote:
On 7/15/25 9:42 AM, Akihiko Odaki wrote:
On 2025/07/11 22:02, Paolo Abeni wrote:
@@ -158,7 +159,10 @@ struct VirtIOPCIProxy {
uint32_t nvectors;
uint32_t dfselect;
uint32_t gfselect
On 2025/07/16 0:40, Paolo Abeni wrote:
On 7/15/25 9:24 AM, Akihiko Odaki wrote:
On 2025/07/11 22:02, Paolo Abeni wrote:
+ */
+QEMU_BUILD_BUG_ON(VIRTIO_FEATURES_DWORDS != 2);
+if (virtio_128bit_features_needed(vdev)) {
There is no need to distinguish virtio_128bit_features_needed
On 2025/07/15 23:52, Paolo Abeni wrote:
On 7/15/25 8:36 AM, Akihiko Odaki wrote:
On 2025/07/11 22:02, Paolo Abeni wrote:
The set_offload() argument list is already pretty long and
we are going to introduce soon a bunch of additional offloads.
Replace the offload arguments with a single struct
On 2025/07/11 22:02, Paolo Abeni wrote:
When any host or guest GSO over UDP tunnel offload is enabled the
virtio net header includes the additional tunnel-related fields,
update the size accordingly.
Push the GSO over UDP tunnel offloads all the way down to the tap
device extending the newly int
On 2025/07/11 22:02, Paolo Abeni wrote:
Extend the VirtioDeviceFeatures struct with an additional u64
to track unknown features in the 65-128 bit range and decode
the full virtio features spaces for vhost and virtio devices.
Signed-off-by: Paolo Abeni
---
I'm unsure if it's actually legit to up
On 2025/07/11 22:02, Paolo Abeni wrote:
Tap devices support GSO over UDP tunnel offload. Probe for such
feature in a similar manner to other offloads.
GSO over UDP tunnel needs to be enabled in addition to a "plain"
offload (TSO or USO).
No need to check separately for the outer header checksu
On 2025/07/11 22:02, Paolo Abeni wrote:
Extend the features configuration space to 128 bits, and allow the
common read/write operation to access all of it.
On migration, save the 128 bit version of the features only if the
upper bits are non zero; after load zero the upper bits if the extended
f
On 2025/07/11 22:02, Paolo Abeni wrote:
If the driver uses any of the extended features (i.e. above 64),
serialize the full features range (128 bits).
This is one of the few spots that need explicitly to know and set
in stone the extended features array size; add a build bug to prevent
breaking
On 2025/07/11 22:02, Paolo Abeni wrote:
The virtio specifications allows for up to 128 bits for the
device features. Soon we are going to use some of the 'extended'
bits features (above 64) for the virtio net driver.
Represent the virtio features bitmask with a fixes size array, and
introduce a
On 2025/07/11 22:02, Paolo Abeni wrote:
The set_offload() argument list is already pretty long and
we are going to introduce soon a bunch of additional offloads.
Replace the offload arguments with a single struct and update
all the relevant call-sites.
No functional changes intended.
Signed-of
pen at all because we always install
a placeholder surface to the console when there is nothing to display.
Resolves: Coverity CID 1610328
Signed-off-by: Weifeng Liu
Reviewed-by: Akihiko Odaki
do not reset vlan filtering at set_features")
Cc: qemu-sta...@nongnu.org
Reported-by: Konstantin Shkolnyy
Signed-off-by: Akihiko Odaki
---
Not tested.
Konstantin, I would also want you to test this new version. Please also
give it Tested-by, and, if possible, Reviewed-by.
---
Changes in v2:
feature negotiation sequence.
Fixes: 06b636a1e2ad ("virtio-net: do not reset vlan filtering at set_features")
Reported-by: Konstantin Shkolnyy
Signed-off-by: Akihiko Odaki
---
Not tested.
Konstantin, please see if this patch fixes your workload.
---
hw/net/virtio-net.c | 11 ++-
d-by: Corentin BAYET
Signed-off-by: Akihiko Odaki
---
hw/pci/pcie_sriov.c | 42 +++---
1 file changed, 23 insertions(+), 19 deletions(-)
diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c
index
3ad18744f4a8ed2b35144fafcdc8e7e00fec3672..a08b5258275f51876c18
ht. Can you submit a patch to fix it?
Regards,
Akihiko Odaki
On 2025/05/23 18:43, Paolo Abeni wrote:
On 5/23/25 9:19 AM, Akihiko Odaki wrote:
On 2025/05/21 20:33, Paolo Abeni wrote:
Some virtualized deployments use UDP tunnel pervasively and are impacted
negatively by the lack of GSO support for such kind of traffic in the
virtual NIC driver.
The
a: Restore vlan filtering state")
Signed-off-by: Konstantin Shkolnyy
Acked-by: Jason Wang
Acked-by: Eugenio Pérez
Reviewed-by: Akihiko Odaki
On 2025/06/21 4:47, Yiwei Zhang wrote:
On Thu, Jun 19, 2025 at 11:45 PM Alex Bennée wrote:
Yiwei Zhang writes:
On Sun, Jun 8, 2025 at 1:24 AM Akihiko Odaki
wrote:
On 2025/06/06 1:26, Alex Bennée wrote:
From: Yiwei Zhang
Venus and later native contexts have their own fence context
On 2025/06/13 5:54, John Snow wrote:
\{ is an illegal escape sequence, to get a literal backslash we need to
use \\.
This is being fixed because of an issue spotted when attempting to use
the pyupgrade script.
Signed-off-by: John Snow
Reviewed-by: Akihiko Odaki
easily.)
Signed-off-by: John Snow
Reviewed-by: Akihiko Odaki
erent repositories.
Signed-off-by: John Snow
Reviewed-by: Akihiko Odaki
On 2025/06/13 5:54, John Snow wrote:
The next patch will synchronize the qemu.qmp library with the external,
standalone version. That synchronization will require an extra ignore
for pylint, so do that now.
Signed-off-by: John Snow
Reviewed-by: Akihiko Odaki
On 2025/06/14 1:53, Sean Wei wrote:
The LGPLv2.1 boiler-plate in pdb.c file still contained
the obsolete "51 Franklin Street" postal address.
Replace it with the canonical GNU licenses URL recommended by the FSF:
https://www.gnu.org/licenses/
Signed-off-by: Sean Wei
Reviewed-b
ny time. I figured now was a good time as any to
get rid of them before they become a problem randomly some day in the
future.
I guess you meant that the old style type hints are deprecated.
Regards,
Akihiko Odaki
n't use Linux kernel internal types like u32, __u32 or __le32.
It's unfortunate that QEMU lacks endian types and a checker for them;
such a checker could not have caught this particular case, but can catch
other similar bugs.
Regards,
Akihiko Odaki
const struct iovec data
rrangement where we are allowed to use versions of
Meson that otherwise would break our build platform guarantee.)
Lately, we've had some issues with the wide range of Sphinx versions we
support presenting various cross-platform difficulties. In particular,
Akihiko Odaki has sent patches to
On 2025/06/07 0:02, Akihiko Odaki wrote:
On 2025/06/06 19:16, Alex Bennée wrote:
Akihiko Odaki writes:
On 2025/06/05 20:57, Alex Bennée wrote:
Akihiko Odaki writes:
On 2025/06/03 20:01, Alex Bennée wrote:
QOM objects can be embedded in other QOM objects and managed as part
of their
ec76ce0-c3ca-48ed-befe-e0930d4a3...@linaro.org/
+assert(is_power_of_2(size) && size >= 1 && size <= (1 << MO_SIZE));
size >= 1 is unnecessary because being power of 2 implies that. The
comment doesn't mention this condition either.
Regards,
Akihiko Odaki
#endif
return (MemOp)ctz32(size);
}
7] ui/gtk-gl-area: Remove extra draw call in
refresh" requires Cc: qemu-sta...@nongnu.org. Fixing -display gtk,gl=on
for Wayland sounds as important as this patch.
Regards,
Akihiko Odaki
Signed-off-by: Yiwei Zhang
Reviewed-by: Dmitry Osipenko
Message-Id: <20250518152651.334115-1-zzyi..
> subregion
(c) FlatView -> subregion
Therefore, the subregion will be freed with (c). So the unmapping
operation will never finish until the BQL gets unlocked.
Regards,
Akihiko Odaki
Signed-off-by: Manos Pitsidianakis
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: &l
no extra changes are needed for the tests to continue
passing.
Signed-off-by: John Snow
Reviewed-by: Akihiko Odaki
I didn't notice these files. Perhaps they are better to be documented
with pythondeps.toml.
Regards,
Akihiko Odaki
On 2025/06/07 5:38, Paolo Bonzini wrote:
On Fri, Jun 6, 2025 at 11:46 AM Akihiko Odaki wrote:
This conditional is unnecessary; docs/about/build-platforms.rst says we
only supports MinGW.
I failed to catch this problem because I ran MinGW on Windows, which is
case-insensitive. Since it is case
On 2025/06/06 20:31, Alex Bennée wrote:
Akihiko Odaki writes:
On 2025/06/06 18:54, Alex Bennée wrote:
Akihiko Odaki writes:
On 2025/06/06 1:26, Alex Bennée wrote:
QOM objects can be embedded in other QOM objects and managed as part
of their lifetime but this isn't the cas
On 2025/06/06 19:16, Alex Bennée wrote:
Akihiko Odaki writes:
On 2025/06/05 20:57, Alex Bennée wrote:
Akihiko Odaki writes:
On 2025/06/03 20:01, Alex Bennée wrote:
QOM objects can be embedded in other QOM objects and managed as part
of their lifetime but this isn't the cas
On 2025/06/06 18:54, Alex Bennée wrote:
Akihiko Odaki writes:
On 2025/06/06 1:26, Alex Bennée wrote:
QOM objects can be embedded in other QOM objects and managed as part
of their lifetime but this isn't the case for
virtio_gpu_virgl_hostmem_region. However before we can split it out we
On 2025/06/05 17:51, Alex Bennée wrote:
Akihiko Odaki writes:
On 2025/06/03 20:01, Alex Bennée wrote:
Currently the boot.S code assumes everything starts at EL1. This will
break things like the memory test which will barf on unaligned memory
access when run at a higher level.
Adapt the boot
On 2025/06/05 22:24, Paolo Bonzini wrote:
From: Akihiko Odaki
In a recent discussion, Phil Dennis-Jordan pointed out a quirk in
QemuEvent destruction due to futex-like abstraction, which prevented
the usage of QemuEvent in new and existing code[1]. With some more
thoughts after this
On 2025/06/05 20:57, Alex Bennée wrote:
Akihiko Odaki writes:
On 2025/06/03 20:01, Alex Bennée wrote:
QOM objects can be embedded in other QOM objects and managed as part
of their lifetime but this isn't the case for
virtio_gpu_virgl_hostmem_region. However before we can split it out we
od to me, so:
Reviewed-by: Akihiko Odaki
Regards,
Akihiko Odaki
diff --git a/tests/qtest/libqos/igb.c b/tests/qtest/libqos/igb.c
index f40c4ec4cd..ab3ef6f0c3 100644
--- a/tests/qtest/libqos/igb.c
+++ b/tests/qtest/libqos/igb.c
@@ -104,10 +104,10 @@ static void igb_pci_start_
call
in refresh" has an undressed comment[2][7].
I would like to see improvements in how comments are addressed before a
series is resent.
Regards,
Akihiko Odaki
[1]
https://lore.kernel.org/qemu-devel/e6af12bd-1c36-4e50-8bae-d8d80cad1...@daynix.com
[2]
https://lore.kernel.org/qemu-deve
his patch can
be simply dropped.
Regards,
Akihiko Odaki
-mr = &vmr->mr;
memory_region_init_ram_ptr(mr, OBJECT(mr), "blob", size, data);
memory_region_add_subregion(&b->hostmem, offset, mr);
memory_region_set_enabled(mr, true);
@@ -131,7 +
On 2025/06/03 20:01, Alex Bennée wrote:
Thanks for volunteering to help.
Cc: Akihiko Odaki
Cc: Dmitry Osipenko
Reviewed-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Bennée
Acked-by: Michael S. Tsirkin
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions
CH v4 11/17] ui/gtk-gl-area: Remove extra draw call
in refresh".
Regards,
Akihiko Odaki
+ .quad cmdline
+ .quad 128
.text
.align 4
.global __start
__start:
+ /*
+ * Initialise the stack for whatever EL we are in before
+* anything e
state to fix the memory leak.
Signed-off-by: Akihiko Odaki
---
Changes in v3:
- Rebased.
- Reordered the patches.
- Removed the extra allocation of VncWorker.
- Removed the worker field from VncState.
- Dropped the Reviewed-by tags.
- Link to v2:
https://lore.kernel.org/qemu-devel/20250531-zlib-v2
copying.
It allows allocating and freeing all shared data at once and shows that
the race with the worker thread needs to be taken care of when
accessing them.
Signed-off-by: Akihiko Odaki
---
ui/vnc.h | 49 --
ui/vnc-enc-tight.c| 456
state to fix the memory leak.
Fixes: bd023f953e5e ("vnc: threaded VNC server")
Signed-off-by: Akihiko Odaki
---
ui/vnc.h | 2 +-
ui/vnc-enc-zlib.c | 30 +++---
ui/vnc.c | 13 ++---
3 files changed, 26 insertions(+), 19 deletions(-)
di
copying.
It allows allocating and freeing all shared data at once and shows that
the race with the worker thread needs to be taken care of when
accessing them.
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
ui/vnc.h | 12 +-
ui/vnc-enc-tight.c| 341
state to fix the memory leak.
Fixes: bd023f953e5e ("vnc: threaded VNC server")
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
ui/vnc.h | 2 +-
ui/vnc-enc-zlib.c | 30 +++---
ui/vnc-jobs.c | 2 --
ui/vnc.c | 2 +
state to fix the memory leak.
Signed-off-by: Akihiko Odaki
---
Changes in v2:
- Rebased.
- Link to v1:
https://lore.kernel.org/qemu-devel/20250417-zlib-v1-0-34fad73b8...@daynix.com
---
Akihiko Odaki (2):
ui/vnc: Introduce the VncWorker type
ui/vnc: Do not copy z_stream
ui/vnc.h
d
when the user sets the property to true while it is defined as an
an error for the "host" CPU when the host doesn't have a PMU.
This fixes qtest-aarch64/arm-cpu-features on the hosts that supports
KVM but doesn't support PMU emulation.
Signed-off-by: Akihiko Odaki
---
kvm-stea
exposes all these four registers
to GDB.
It is not necessary to add ARM_CP_ALIAS to these registers because the
flag is already set.
Signed-off-by: Akihiko Odaki
---
Supersedes: <20250317-raw-v1-0-09e2dfff0...@daynix.com>
("[PATCH 0/4] target/arm: Flag PMCNTENCLR with ARM_CP_NO_RAW"
ps up.
Signed-off-by: Akihiko Odaki
---
My email address at Daynix will remain active at least for the next
month.
I added the submitter of the patches I recently reviewed to Cc. Please
Cc my new email address for future reviews.
I have a number of patches that are not pulled yet. Colleagues at D
Report hashing capability so that virtio-net can deliver the correct
capability information to the guest.
Signed-off-by: Akihiko Odaki
---
include/net/net.h | 3 +++
net/net.c | 9 +
net/vhost-vdpa.c | 28
3 files changed, 40 insertions(+)
diff
DEFINE_PROP_ON_OFF_AUTO_BIT64() corresponds to DEFINE_PROP_ON_OFF_AUTO()
as DEFINE_PROP_BIT64() corresponds to DEFINE_PROP_BOOL(). The difference
is that DEFINE_PROP_ON_OFF_AUTO_BIT64() exposes OnOffAuto instead of
bool.
Signed-off-by: Akihiko Odaki
---
include/hw/qdev-properties.h | 18
ing")
Signed-off-by: Akihiko Odaki
---
Changes in v2:
- Updated a documentation comment of pre_load_queues() for clarity.
- Link to v1:
https://lore.kernel.org/qemu-devel/20250510-n-v1-1-19ee26ac3...@daynix.com
---
include/hw/virtio/virtio.h | 10 --
hw/net/virtio-net.c| 1
It is no longer used.
Signed-off-by: Akihiko Odaki
---
net/vhost-vdpa.c | 8
1 file changed, 8 deletions(-)
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 4f63ded40d47..149c0f7f1766 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -238,12 +238,6 @@ static void
This allows offloading hash reporting and RSS to tap.
Signed-off-by: Akihiko Odaki
---
hw/net/virtio-net.c | 69 +++--
1 file changed, 56 insertions(+), 13 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 52fe404b3431
1 - 100 of 1974 matches
Mail list logo
