On 2025/07/16 0:49, Paolo Abeni wrote:
On 7/15/25 10:05 AM, Akihiko Odaki wrote:
On 2025/07/11 22:02, Paolo Abeni wrote:
diff --git a/net/tap-bsd.c b/net/tap-bsd.c
index 86b6edee94..e7de0672f4 100644
--- a/net/tap-bsd.c
+++ b/net/tap-bsd.c
@@ -217,6 +217,11 @@ int tap_probe_has_uso(int fd)
return 0;
}
+int tap_probe_has_tunnel(int fd)
This should return bool for consistency.
Some inconsistency will persist, as others bsd helpers supposed to
return a bool currently return an int. I tried to be consistent with the
surrounding code, but no strong objections.
That's true, but when considering the entire codebase, it is so common
to return bool instead of int. So I regard the existing tap-local
functions as exceptional, and making a new function return bool results
in a better global consistency.
Regards,
Akihiko Odaki
