RE: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to host

2025-05-21 Thread Duan, Zhenzhong
>-Original Message- >From: Nicolin Chen >Subject: Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to >host > >On Wed, May 21, 2025 at 07:14:45PM +0800, Zhenzhong Duan wrote: >> +static const MemoryListener iommufd_s2domain_memory_listener = { >> +.name = "iommufd_s

Re: [PATCH v3 12/20] virtio-gpu: fix hang under TCG when unmapping blob

2025-05-21 Thread Alex Bennée
Akihiko Odaki writes: > On 2025/05/22 1:42, Alex Bennée wrote: >> From: Manos Pitsidianakis >> This commit fixes an indefinite hang when using VIRTIO GPU blob >> objects >> under TCG in certain conditions. >> The VIRTIO_GPU_CMD_RESOURCE_MAP_BLOB VIRTIO command creates a >> MemoryRegion and attac

Re: [PATCH] vfio/igd: Fix incorrect error propagation in vfio_pci_igd_opregion_detect()

2025-05-21 Thread Corvin Köhne
On Wed, 2025-05-21 at 23:40 +0800, Tomita Moeko wrote: > CAUTION: External Email!! > In vfio_pci_igd_opregion_detect(), errp will be set when device does > not have OpRegion or is hotplugged. This errp will be propergated to > pci_qdev_realize(), which interprets it as failure, causing unexpected

Re: [PATCH V3 10/42] vfio/container: restore DMA vaddr

2025-05-21 Thread Cédric Le Goater
On 5/12/25 17:32, Steve Sistare wrote: In new QEMU, do not register the memory listener at device creation time. Register it later, in the container post_load handler, after all vmstate that may affect regions and mapping boundaries has been loaded. The post_load registration will cause the list

Re: [PATCH v3 19/20] gdbstub: Implement qGDBServerVersion packet

2025-05-21 Thread Akihiko Odaki
On 2025/05/22 1:42, Alex Bennée wrote: From: Dominik 'Disconnect3d' Czarnota This commit adds support for the `qGDBServerVersion` packet to the qemu gdbstub which could be used by clients to detect the QEMU version (and, e.g., use a workaround for known bugs). This packet is not documented/st

Re: [PATCH v3 16/20] include/exec: fix assert in size_memop

2025-05-21 Thread Akihiko Odaki
On 2025/05/22 1:42, Alex Bennée wrote: We can handle larger sized memops now, expand the range of the assert. Fixes: 4b473e0c60 (tcg: Expand MO_SIZE to 3 bits) Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - instead of 128 use 1 << MO_SIZE for future proofing v3 - fix

Re: [PATCH v3 12/20] virtio-gpu: fix hang under TCG when unmapping blob

2025-05-21 Thread Akihiko Odaki
On 2025/05/22 1:42, Alex Bennée wrote: From: Manos Pitsidianakis This commit fixes an indefinite hang when using VIRTIO GPU blob objects under TCG in certain conditions. The VIRTIO_GPU_CMD_RESOURCE_MAP_BLOB VIRTIO command creates a MemoryRegion and attaches it to an offset on a PCI BAR of the

Re: [PATCH v3 08/20] contrib/plugins: allow setting of instructions per quantum

2025-05-21 Thread Akihiko Odaki
On 2025/05/22 1:42, Alex Bennée wrote: The default is we update time every 1/10th of a second or so. However for some cases we might want to update time more frequently. Allow this to be set via the command line through the ipq argument. Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier

Re: [PATCH v3 07/20] contrib/plugins: add a scaling factor to the ips arg

2025-05-21 Thread Akihiko Odaki
On 2025/05/22 1:42, Alex Bennée wrote: It's easy to get lost in zeros while setting the numbers of instructions per second. Add a scaling suffix to make things simpler. Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier --- v2 - normalise the suffix before a full strcmp0 - check e

Re: [PATCH v3 06/20] tests/functional: Add PCI hotplug test for aarch64

2025-05-21 Thread Akihiko Odaki
On 2025/05/22 1:42, Alex Bennée wrote: From: Gustavo Romero Add a functional test, aarch64_hotplug_pci, to exercise PCI hotplug and hot-unplug on arm64. Signed-off-by: Gustavo Romero Reviewed-by: Daniel P. Berrangé Reviewed-by: Eric Auger Message-Id: <20250512144629.182340-1-gustavo.rom...@

Re: [PATCH v3 05/20] tests/Makefile: include test-plugins in per-arch build deps

2025-05-21 Thread Akihiko Odaki
On 2025/05/22 1:42, Alex Bennée wrote: The user can run a subset of the tcg tests directly, e.g.: make run-tcg-tests-hexagon-linux-user but in this case we fail if there has not been a full build to ensure all the test-plugins are there. Fix the dependency to ensure we always will build them

Re: [PATCH v3 01/20] tests/docker: expose $HOME/.cache/qemu as docker volume

2025-05-21 Thread Thomas Huth
On 21/05/2025 18.42, Alex Bennée wrote: If you want to run functional tests we should share .cache/qemu so we don't force containers to continually re-download images. Signed-off-by: Alex Bennée Maybe add something about the ccache relocation to the commit message? Anyway: Reviewed-by: Thoma

Re: [PATCH v3 04/20] tests/qtest: fix igb test failure under --enable-ubsan

2025-05-21 Thread Akihiko Odaki
On 2025/05/22 1:42, Alex Bennée wrote: From: Nabih Estefan ../tests/qtest/libqos/igb.c:106:5: runtime error: load of misaligned address 0x562040be8e33 for type 'uint32_t', which requires 4 byte alignment Instead of straight casting the uint8_t array, we can use ldl_le_p and lduw_l_p to ass

Re: [PATCH v7 2/2] tests/functional: add memlock tests

2025-05-21 Thread Thomas Huth
On 21/05/2025 15.55, Alexandr Moshkov wrote: Add new tests to check the correctness of the `-overcommit memlock` option (possible values: off, on, on-fault) by using `/proc/{qemu_pid}/smaps` file to check in Size, Rss and Locked fields of anonymous segments: * if `memlock=off`, then Locked = 0 o

Re: [PATCH v3 10/20] MAINTAINERS: add Akihiko and Dmitry as reviewers

2025-05-21 Thread Markus Armbruster
Alex Bennée writes: > Thanks for volunteering to help. > > Cc: Akihiko Odaki > Cc: Dmitry Osipenko > Signed-off-by: Alex Bennée > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 8dfb393c06..a14e2796e0 100644 > --- a/MAINTAINERS >

Re: [PATCH v3 09/20] MAINTAINERS: add myself to virtio-gpu for Odd Fixes

2025-05-21 Thread Markus Armbruster
Alex Bennée writes: > Seeing as I've taken a few patches to here now I might as well put > myself forward to maintain virtio-gpu. I've marked it as Odd Fixes as > it is not my core focus. If someone with more GPU experience comes > forward we can always update again. > > Signed-off-by: Alex Benné

Re: [PATCH v2 09/12] qapi: make most CPU commands unconditionally available

2025-05-21 Thread Markus Armbruster
Pierrick Bouvier writes: > On 5/18/25 11:29 PM, Markus Armbruster wrote: >> Pierrick Bouvier writes: >> >>> From: Daniel P. Berrangé >>> >>> This removes the TARGET_* conditions from all the CPU commands >>> that are conceptually target independent. Top level stubs are >>> provided to cope wit

Re: [PATCH v3 03/20] tests/tcg: make aarch64 boot.S handle different starting modes

2025-05-21 Thread Akihiko Odaki
On 2025/05/22 1:42, Alex Bennée wrote: Currently the boot.S code assumes everything starts at EL1. This will break things like the memory test which will barf on unaligned memory access when run at a higher level. Adapt the boot code to do some basic verification of the starting mode and the min

Re: [PATCH v2 3/7] target/arm: remove explicit dependencies listed

2025-05-21 Thread Thomas Huth
On 22/05/2025 00.34, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/meson.build b/target/arm/meson.build index b404fa54863..2ff7ed6e98f 100644 --- a/target/arm/meson.build +++ b/

Re: [PATCH v2 2/7] hw/arm: remove explicit dependencies listed

2025-05-21 Thread Thomas Huth
On 22/05/2025 00.34, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/arm/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/meson.build b/hw/arm/meson.build index 5098795f61d..d90be8f4c94 100644 --- a/hw/arm/meson.build +++ b/hw/arm/meson

Re: [PATCH] virtio-net: Add queues for RSS during migration

2025-05-21 Thread Akihiko Odaki
On 2025/05/22 10:50, 'Jason Wang' via devel wrote: On Wed, May 21, 2025 at 11:51 AM Akihiko Odaki wrote: On 2025/05/21 9:51, Jason Wang wrote: On Fri, May 16, 2025 at 11:29 AM Akihiko Odaki wrote: On 2025/05/16 10:44, Jason Wang wrote: On Wed, May 14, 2025 at 2:58 PM Akihiko Odaki wrote:

[PATCH] check loongarch64 vldi immediates Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2971 Signed-off-by: Lorenz Hetterich

2025-05-21 Thread Lorenz Hetterich
--- target/loongarch/tcg/insn_trans/trans_vec.c.inc | 13 + 1 file changed, 13 insertions(+) diff --git a/target/loongarch/tcg/insn_trans/trans_vec.c.inc b/target/loongarch/tcg/insn_trans/trans_vec.c.inc index dff92772ad..5589a9e865 100644 --- a/target/loongarch/tcg/insn_trans/trans_

Re: [PATCH] check loongarch64 vldi immediates Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2971 Signed-off-by: Lorenz Hetterich

2025-05-21 Thread gaosong
在 2025/5/22 上午10:08, Lorenz Hetterich 写道: --- target/loongarch/tcg/insn_trans/trans_vec.c.inc | 13 + 1 file changed, 13 insertions(+) diff --git a/target/loongarch/tcg/insn_trans/trans_vec.c.inc b/target/loongarch/tcg/insn_trans/trans_vec.c.inc index dff92772ad..5589a9e865 10064

RE: [PATCH v3 2/5] hw/arm/aspeed_ast27x0: Remove unused iomem region overlapping VBootROM

2025-05-21 Thread Steven Lee
Hi reviewers, Please ignore this patch - I mistakenly sent two versions of patch 2/5. The correct one is titled: [PATCH v3 2/5] hw/arm/aspeed_ast27x0: Fix unimplemented region overlap with VBootROM Sorry for the confusion. Regards, Steven > -Original Message- > From: Steven Lee > S

Re: [PATCH V2] vhost: Don't set vring call if guest notifier is unused

2025-05-21 Thread Huaitong Han
Hi Stefano, I’ve implemented the version based on your suggestion. The core logic now looks like this: if (k->query_guest_notifiers && !k->query_guest_notifiers(qbus->parent) && virtio_queue_vector(vdev, idx) == VIRTIO_NO_VECTOR) { ... } And in virtio_pci_query_guest_notifiers(): if (

[PATCH v3 0/5] hw/arm/aspeed_ast2700-fc: Fix null pointer dereference

2025-05-21 Thread Steven Lee via
Clang's sanitizer reports a runtime error when booting with '-net nic -net user', due to a null pointer being passed to memory_region_find(), which subsequently triggers a crash in flatview_lookup(). Root cause: - Missing NIC configuration in the CA35 initialization. Fix: - Reduce ca35 ram size f

[PATCH v3 1/5] hw/arm/aspeed_ast2700-fc: Fix null pointer dereference in ca35 init

2025-05-21 Thread Steven Lee via
Clang's sanitizer reports a runtime error when booting with '-net nic -net user', due to a null pointer being passed to memory_region_find(), which subsequently triggers a crash in flatview_lookup(). Root cause: - Missing NIC configuration in the CA35 initialization. Fix: - Reduce ca35 ram size f

[PATCH v3 3/5] hw/arm/aspeed_ast27x0-fc: Map ca35 memory into system memory

2025-05-21 Thread Steven Lee via
Map the CA35 memory region as a subregion of system_memory to ensure a valid FlatView. This prevents failures in APIs that rely on the global memory view, such as rom_check_and_register_reset(). Signed-off-by: Steven Lee --- hw/arm/aspeed_ast27x0-fc.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v3 2/5] hw/arm/aspeed_ast27x0: Fix unimplemented region overlap with vbootrom

2025-05-21 Thread Steven Lee via
The unimplemented memory region overlaps with the VBootROM address range, causing incorrect memory layout. This patch adjusts the size and start address of the unimplemented region to avoid collision. The IO memory region (ASPEED_DEV_IOMEM) is now moved to 0x2 to reserve space for VBootROM at

[PATCH v3 2/5] hw/arm/aspeed_ast27x0: Remove unused iomem region overlapping VBootROM

2025-05-21 Thread Steven Lee via
The iomem region at 0x is unused and overlaps with VBootROM. Removing it avoids incorrect memory layout. Signed-off-by: Steven Lee --- hw/arm/aspeed_ast27x0.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index 1974a25766..32

[PATCH v3 5/5] docs: Remove ast2700fc from Aspeed family boards

2025-05-21 Thread Steven Lee via
The ast2700fc machine is now covered in the dedicated ast2700-evb section. Listing it in the general Aspeed board family list is redundant. Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater --- docs/system/arm/aspeed.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH v3 4/5] hw/arm/fby35: Map BMC memory into system memory

2025-05-21 Thread Steven Lee via
Add the BMC memory region as a subregion of system_memory so that modules relying on system memory can operate correctly. Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater --- hw/arm/fby35.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/fby35.c b/hw/arm/fby35.c index e123fa69

Re: [PATCH v3 5/8] Add memory hardware address read/write API

2025-05-21 Thread Rowan Hart
Well, first I just noticed that I left a debug print in this function! So I'll fix that. Reading this patch, and patch 3 (Add address space API), I am not sure AddressSpace is something we want to leak in plugins interface. It is a concept *very* internal to QEMU, and not reflecting directly s

RE: [PATCH V3 29/42] backends/iommufd: change process ioctl

2025-05-21 Thread Duan, Zhenzhong
>-Original Message- >From: Steven Sistare >Subject: Re: [PATCH V3 29/42] backends/iommufd: change process ioctl > >On 5/20/2025 11:11 PM, Duan, Zhenzhong wrote: >>> -Original Message- >>> From: Steven Sistare >>> Subject: Re: [PATCH V3 29/42] backends/iommufd: change process io

[PATCH v2 0/3] Fix RAM size detection failure on BE hosts

2025-05-21 Thread Jamin Lin via
v1: 1. Fix RAM size detection failure on BE hosts 2. INTC: Set impl.min_access_size to 4 Fix coding style v2: Fix review issue. Jamin Lin (3): hw/intc/aspeed: Set impl.min_access_size to 4 hw/intc/aspeed Fix coding style hw/arm/aspeed_ast27x0: Fix RAM size detection failure on

[PATCH v2 2/3] hw/intc/aspeed Fix coding style

2025-05-21 Thread Jamin Lin via
Fix coding style issues from checkpatch.pl. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater --- hw/intc/aspeed_intc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/intc/aspeed_intc.c b/hw/intc/aspeed_intc.c index 19f88853d8..5cd786dee6 100644 --- a/hw/intc/

[PATCH v2 3/3] hw/arm/aspeed_ast27x0: Fix RAM size detection failure on BE hosts

2025-05-21 Thread Jamin Lin via
On big-endian hosts, the aspeed_ram_capacity_write() function previously passed the address of a 64-bit "data" variable directly to address_space_write(), assuming host and guest endianness matched. However, the data is expected to be written in little-endian format to DRAM. On big-endian hosts, t

[PATCH v2 1/3] hw/intc/aspeed: Set impl.min_access_size to 4

2025-05-21 Thread Jamin Lin via
This patch explicitly sets ".impl.min_access_size = 4" to match the declared ".valid.min_access_size = 4", enforcing stricter access size checking and preventing inconsistent partial accesses to the interrupt controller registers. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater --- hw/in

[PATCH v4 0/1] fix the way riscv_plic_hart_config_string() gets the CPUState

2025-05-21 Thread Chao Liu
From: "Chao Liu" Hi, all: Thanks to Alistair for the review~ PATCH v4: Rebasing this on https://github.com/alistair23/qemu/tree/riscv-to-apply.next PATCH v3: Use cpu_by_arch_id() instead of qemu_get_cpu(), when registering gpio in sifive_plic_create(). PATCH v2: During plic initialization,

[PATCH v4 1/1] hw/riscv: fix PLIC hart topology configuration string when not getting CPUState correctly

2025-05-21 Thread Chao Liu
riscv_plic_hart_config_string() when getting CPUState via qemu_get_cpu() should be consistent with keeping sifive_plic_realize() by hartid_base + cpu_index. A better approach is to use cpu_by_arch_id() instead of qemu_get_cpu(), in riscv cpu_by_arch_id() uses the mhartid. For non-numa or single-c

Re: [PATCH] virtio-net: Add queues for RSS during migration

2025-05-21 Thread Jason Wang
On Wed, May 21, 2025 at 11:51 AM Akihiko Odaki wrote: > > On 2025/05/21 9:51, Jason Wang wrote: > > On Fri, May 16, 2025 at 11:29 AM Akihiko Odaki > > wrote: > >> > >> On 2025/05/16 10:44, Jason Wang wrote: > >>> On Wed, May 14, 2025 at 2:58 PM Akihiko Odaki > >>> wrote: > > On 2025/

RE: [PATCH v1 3/3] hw/arm/aspeed_ast27x0: Fix RAM size detection failure on BE hosts

2025-05-21 Thread Jamin Lin
Hi Cédric > Subject: Re: [PATCH v1 3/3] hw/arm/aspeed_ast27x0: Fix RAM size detection > failure on BE hosts > > On 5/20/25 09:35, Jamin Lin wrote: > > On big-endian hosts, the aspeed_ram_capacity_write() function > > previously passed the address of a 64-bit "data" variable directly to > > addres

Re: [PATCH v3 1/1] hw/riscv: fix PLIC hart topology configuration string when not getting CPUState correctly

2025-05-21 Thread Alistair Francis
On Wed, Apr 16, 2025 at 3:20 PM Chao Liu wrote: > > riscv_plic_hart_config_string() when getting CPUState via qemu_get_cpu() > should be consistent with keeping sifive_plic_realize() > by hartid_base + cpu_index. > > A better approach is to use cpu_by_arch_id() instead of qemu_get_cpu(), > in risc

Re: [PATCH v3 1/1] hw/riscv: fix PLIC hart topology configuration string when not getting CPUState correctly

2025-05-21 Thread Alistair Francis
On Wed, Apr 16, 2025 at 3:20 PM Chao Liu wrote: > > riscv_plic_hart_config_string() when getting CPUState via qemu_get_cpu() > should be consistent with keeping sifive_plic_realize() > by hartid_base + cpu_index. > > A better approach is to use cpu_by_arch_id() instead of qemu_get_cpu(), > in risc

Re: [PATCH v11 8/8] hw/riscv/virt: Add IOPMP support

2025-05-21 Thread Alistair Francis
On Wed, Mar 12, 2025 at 7:43 PM Ethan Chen via wrote: > > - Add 'iopmp=on' option to enable IOPMP. It adds iopmp devices virt machine > to protect all regions of system memory. > > Signed-off-by: Ethan Chen > --- > docs/specs/index.rst | 1 + > docs/specs/riscv-iopmp.rst | 60 ++

Re: [PATCH v2 2/2] migration/hmp: Add "info migrate -a", reorg the dump

2025-05-21 Thread Zhijian Li (Fujitsu)
On 21/05/2025 22:03, Peter Xu wrote: > On Wed, May 21, 2025 at 08:43:37AM +, Zhijian Li (Fujitsu) wrote: > [...] >>> After this change, sample output (default, no "-a" specified): >>> >>> Status: postcopy-active >>> Time (ms): total=40504, setup=14, down=145 >>> RAM info: >>>

Re: [PATCH v2 2/2] migration/hmp: Add "info migrate -a", reorg the dump

2025-05-21 Thread Zhijian Li (Fujitsu)
On 22/05/2025 05:04, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: >> On Wed, May 21, 2025 at 08:43:37AM +, Zhijian Li (Fujitsu) wrote: >> [...] After this change, sample output (default, no "-a" specified): Status: postcopy-active Time (ms)

Re: [PATCH v3 1/8] Expose gdb_write_register function to consumers of gdbstub

2025-05-21 Thread Pierrick Bouvier
On 5/21/25 2:43 AM, Rowan Hart wrote: From: novafacing Signed-off-by: novafacing Signed-off-by: Rowan Hart --- gdbstub/gdbstub.c | 2 +- include/exec/gdbstub.h | 14 ++ 2 files changed, 15 insertions(+), 1 deletion(-) Reviewed-by: Pierrick Bouvier

Re: [PATCH v11 6/8] hw/misc/riscv_iopmp: Add RISC-V IOPMP device

2025-05-21 Thread Alistair Francis
On Wed, Mar 12, 2025 at 7:41 PM Ethan Chen via wrote: > > Support IOPMP specification v0.7. > The specification url: > https://github.com/riscv-non-isa/iopmp-spec/releases/tag/v0.7 v10 of the series supported v0.9.2RC3 [1], why is this now 0.7? We should be targeting the latest version of a draf

Re: [PATCH v11 5/8] hw/misc/riscv_iopmp_txn_info: Add struct for transaction infomation

2025-05-21 Thread Alistair Francis
On Wed, Mar 12, 2025 at 7:43 PM Ethan Chen via wrote: > > The entire valid transaction must fit within a single IOPMP entry. > However, during IOMMU translation, the transaction size is not > available. This structure defines the transaction information required > by the IOPMP. > > Signed-off-by:

Re: [PATCH v2 2/2] target/riscv: Make PMP region count configurable

2025-05-21 Thread Alistair Francis
On Fri, Apr 25, 2025 at 7:46 PM Jay Chang wrote: > > Previously, the number of PMP regions was hardcoded to 16 in QEMU. > This patch replaces the fixed value with a new `pmp_regions` field, > allowing platforms to configure the number of PMP regions. > > If no specific value is provided, the defau

Re: [PATCH v2 1/2] target/riscv: Extend PMP region up to 64

2025-05-21 Thread Alistair Francis
On Fri, Apr 25, 2025 at 7:45 PM Jay Chang wrote: > > According to the RISC-V Privileged Specification (version >1.12), > RV32 supports 16 CSRs (pmpcfg0–pmpcfg15) to configure 64 PMP regions > (pmpaddr0–pmpaddr63). > > Reviewed-by: Frank Chang > Signed-off-by: Jay Chang Reviewed-by: Alistair Fra

[PATCH v2 6/7] meson: remove lib{system, user}_ss aliases

2025-05-21 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- meson.build | 2 -- accel/tcg/meson.build | 8 gdbstub/meson.build | 4 ++-- hw/core/meson.build | 4 ++-- plugins/meson.build | 4 ++-- system/meson.build| 2 +- tcg/meson.build | 4 ++-- 7 files changed, 13 insertions(+), 15

Re: [PATCH RFC V5 00/30] Support of Virtual CPU Hotplug for ARMv8 Arch

2025-05-21 Thread Gavin Shan
Hi Gustavo and Salil, On 5/22/25 1:06 AM, Gustavo Romero wrote: Hi Salil, Gavin, and folks, On 5/20/25 21:22, Gavin Shan wrote: Hi Salil, A kindly ping. vCPU hotplug is an important feature and You has put so much energies and amazing efforts to enable the feature from QEMU side, but it seems

[PATCH v3 01/14] qapi: expose rtc-reset-reinjection command unconditionally

2025-05-21 Thread Pierrick Bouvier
From: Daniel P. Berrangé This removes the TARGET_I386 condition from the rtc-reset-reinjection command. This requires providing a QMP command stub for non-i386 target. This in turn requires moving the command out of misc-target.json, since that will trigger symbol poisoning errors when built from

Re: [PATCH v3 5/8] Add memory hardware address read/write API

2025-05-21 Thread Pierrick Bouvier
On 5/21/25 2:43 AM, Rowan Hart wrote: From: novafacing Signed-off-by: novafacing Signed-off-by: Rowan Hart --- include/qemu/qemu-plugin.h | 96 +++ plugins/api.c | 100 + 2 files changed, 196 insertions(+)

Re: [PATCH 0/6] single-binary: build target common libraries with dependencies

2025-05-21 Thread Pierrick Bouvier
On 5/15/25 10:27 PM, Pierrick Bouvier wrote: Recently, common libraries per target base architecture were introduced in order to compile those files only once. However, it was missing common dependencies (which include external libraries), so it failed to build on some hosts. This series fixes t

Re: [PATCH v3 2/8] Add register write API

2025-05-21 Thread Pierrick Bouvier
On 5/21/25 2:43 AM, Rowan Hart wrote: From: novafacing Signed-off-by: novafacing Signed-off-by: Rowan Hart --- include/qemu/qemu-plugin.h | 57 +- plugins/api.c | 26 - 2 files changed, 56 insertions(+), 27 deletions(-) Re

[PATCH v3 03/14] qapi: make SEV commands unconditionally available

2025-05-21 Thread Pierrick Bouvier
From: Daniel P. Berrangé This removes the TARGET_I386 condition from the SEV confidential virtualization commands, moving them to the recently introduced misc-i386.json QAPI file, given they are inherantly i386 specific commands. Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé

[PATCH v3 02/14] qapi: expand docs for SEV commands

2025-05-21 Thread Pierrick Bouvier
From: Daniel P. Berrangé This gives some more context about the behaviour of the commands in unsupported guest configuration or platform scenarios. Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé Signed-off-by: Pierrick Bouvier --- qapi/misc-target.json | 43

Re: [PATCH v3 4/8] Add memory virtual address write API

2025-05-21 Thread Pierrick Bouvier
On 5/21/25 2:43 AM, Rowan Hart wrote: From: novafacing Signed-off-by: novafacing Signed-off-by: Rowan Hart --- include/qemu/qemu-plugin.h | 21 + plugins/api.c | 18 ++ 2 files changed, 39 insertions(+) Reviewed-by: Pierrick Bouvier

Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to host

2025-05-21 Thread Nicolin Chen
On Wed, May 21, 2025 at 07:14:45PM +0800, Zhenzhong Duan wrote: > +static const MemoryListener iommufd_s2domain_memory_listener = { > +.name = "iommufd_s2domain", > +.priority = 1000, > +.region_add = iommufd_listener_region_add_s2domain, > +.region_del = iommufd_listener_region_del

[PATCH v3 00/14] qapi: remove all TARGET_* conditionals from the schema

2025-05-21 Thread Pierrick Bouvier
This series exposes all qmp commands for any target unconditionally, allowing to compile QAPI generated code without any TARGET conditionals. Based on original RFC from Daniel P. Berrangé: https://lore.kernel.org/qemu-devel/20250508135816.673087-1-berra...@redhat.com/ v3 -- - Change error messag

[PATCH v2 5/7] meson: merge lib{system, user}_ss with {system, user}_ss

2025-05-21 Thread Pierrick Bouvier
Now that target configuration can be applied to lib{system, user}_ss, there is no reason to keep that separate from the existing {system, user}_ss. The only difference is that we'll now compile those files with -DCOMPILING_SYSTEM_VS_USER, which removes poison for CONFIG_USER_ONLY and CONFIG_SOFTMMU

Re: [PATCH v2 00/12] qapi: remove all TARGET_* conditionals from the schema

2025-05-21 Thread Pierrick Bouvier
On 5/15/25 10:27 AM, Pierrick Bouvier wrote: This series exposes all qmp commands for any target unconditionally, allowing to compile QAPI generated code without any TARGET conditionals. Based on original RFC from Daniel P. Berrangé: https://lore.kernel.org/qemu-devel/20250508135816.673087-1-ber

[PATCH v3 14/14] qapi/misc-i386: move errors to their own documentation section

2025-05-21 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- qapi/misc-i386.json | 39 +++ 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/qapi/misc-i386.json b/qapi/misc-i386.json index 6f79817e382..796eaa5f406 100644 --- a/qapi/misc-i386.json +++ b/qapi/misc-i386.json

[PATCH v3 05/14] qapi: make SGX commands unconditionally available

2025-05-21 Thread Pierrick Bouvier
From: Daniel P. Berrangé This removes the TARGET_I386 condition from the SGX confidential virtualization commands, moving them to the recently introduced misc-i386.json QAPI file, given they are inherantly i386 specific commands. Observe a pre-existing bug that the "SGXEPCSection" struct lacked

[PATCH v3 08/14] qapi: Make CpuModelExpansionInfo::deprecated-props optional and generic

2025-05-21 Thread Pierrick Bouvier
From: Philippe Mathieu-Daudé We'd like to have some unified QAPI schema. Having a structure field conditional to a target being built in is not very practical. While @deprecated-props is only used by s390x target, it is generic enough and could be used by other targets (assuming we expand CpuMod

[PATCH v3 11/14] qapi: make all generated files common

2025-05-21 Thread Pierrick Bouvier
Monolithic files (qapi_nonmodule_outputs) can now be compiled just once, so we can remove qapi_util_outputs logic. This removes the need for any specific_ss file. Signed-off-by: Pierrick Bouvier --- qapi/meson.build | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-)

[PATCH v3 09/14] qapi: make s390x specific CPU commands unconditionally available

2025-05-21 Thread Pierrick Bouvier
From: Daniel P. Berrangé This removes the TARGET_S390X and CONFIG_KVM conditions from the CPU commands that are conceptually specific to s390x. Top level stubs are provided to cope with non-s390x targets, or builds without KVM. The removal of CONFIG_KVM is justified by the fact there is no conce

[PATCH v3 12/14] qapi: use imperative style in documentation

2025-05-21 Thread Pierrick Bouvier
As requested by Markus: > We prefer imperative mood "Return" over "Returns". Signed-off-by: Pierrick Bouvier --- qapi/audio.json | 2 +- qapi/char.json | 4 ++-- qapi/cryptodev.json | 2 +- qapi/machine.json | 4 ++-- qapi/migration.json | 8 qapi/misc-i386.json | 6 +++--- q

[PATCH v3 07/14] qapi: remove the misc-target.json file

2025-05-21 Thread Pierrick Bouvier
From: Daniel P. Berrangé This file is now empty and can thus be removed. Observe the pre-existing bug with s390-skeys.c and target/i386/monitor.c both including qapi-commands-misc-target.h despite not requiring it. Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé Signed-off-by

[PATCH v3 04/14] qapi: expose query-gic-capability command unconditionally

2025-05-21 Thread Pierrick Bouvier
From: Daniel P. Berrangé This removes the TARGET_ARM condition from the query-gic-capability command. This requires providing a QMP command stub for non-ARM targets. This in turn requires moving the command out of misc-target.json, since that will trigger symbol poisoning errors when built from t

[PATCH v3 06/14] qapi: make Xen event commands unconditionally available

2025-05-21 Thread Pierrick Bouvier
From: Daniel P. Berrangé This removes the TARGET_I386 condition from the Xen event channel commands, moving them to the recently introduced misc-i386.json QAPI file, given they are inherantly i386 specific commands. Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé Acked-by: Dav

[PATCH v3 13/14] qapi/misc-i386: s/field will be set/field is set/

2025-05-21 Thread Pierrick Bouvier
As requested by Markus: > I'd prefer "field is set". Signed-off-by: Pierrick Bouvier --- qapi/misc-i386.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/misc-i386.json b/qapi/misc-i386.json index 3fda7a20bdd..6f79817e382 100644 --- a/qapi/misc-i386.json +++ b/qapi/mi

[PATCH v3 10/14] qapi: remove qapi_specific_outputs from meson.build

2025-05-21 Thread Pierrick Bouvier
There is no more QAPI files that need to be compiled per target, so we can remove this. qapi_specific_outputs is now empty, so we can remove the associated logic in meson. Reviewed-by: Daniel P. Berrangé Reviewed-by: Richard Henderson Reviewed-by: Markus Armbruster Signed-off-by: Pierrick Bouvi

[PATCH v2 2/7] hw/arm: remove explicit dependencies listed

2025-05-21 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- hw/arm/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/meson.build b/hw/arm/meson.build index 5098795f61d..d90be8f4c94 100644 --- a/hw/arm/meson.build +++ b/hw/arm/meson.build @@ -8,7 +8,7 @@ arm_common_ss.add(when: 'C

[PATCH v2 3/7] target/arm: remove explicit dependencies listed

2025-05-21 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- target/arm/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/meson.build b/target/arm/meson.build index b404fa54863..2ff7ed6e98f 100644 --- a/target/arm/meson.build +++ b/target/arm/meson.build @@ -28,7 +28,7 @@ arm_user

[PATCH v2 4/7] meson: apply target config for picking files from lib{system, user}

2025-05-21 Thread Pierrick Bouvier
semihosting code needs to be included only if CONFIG_SEMIHOSTING is set. However, this is a target configuration, so we need to apply it to the lib{system, user}_ss. As well, this prepares merging lib{system, user}_ss with {system, user}_ss. Acked-by: Richard Henderson Signed-off-by: Pierrick Bo

[PATCH v2 1/7] meson: build target libraries with common dependencies

2025-05-21 Thread Pierrick Bouvier
As mentioned in [1], dependencies were missing when compiling per target libraries, thus breaking compilation on certain host systems. We now explicitly add common dependencies to those libraries, so it solves the problem. [1] https://lore.kernel.org/qemu-devel/20250513115637.184940-1-th...@redha

[PATCH v2 7/7] meson: merge hw_common_arch in target_common_system_arch

2025-05-21 Thread Pierrick Bouvier
No need to keep two different libraries, as both are compiled with exact same flags. As well, rename target common libraries to common_{arch} and system_{arch}, to follow what exists for common and system libraries. Signed-off-by: Pierrick Bouvier --- meson.build | 33 ---

[PATCH v2 0/7] single-binary: build target common libraries with dependencies

2025-05-21 Thread Pierrick Bouvier
Recently, common libraries per target base architecture were introduced in order to compile those files only once. However, it was missing common dependencies (which include external libraries), so it failed to build on some hosts. This series fixes this, inspired by Thomas fix [1], and applied to

Re: [PATCH v13 5/5] qtest/cxl: Add aarch64 virt test for CXL

2025-05-21 Thread Itaru Kitayama
> On May 22, 2025, at 2:52, Jonathan Cameron > wrote: > > On Wed, 21 May 2025 16:38:10 +0900 > Itaru Kitayama wrote: > >>> On May 19, 2025, at 21:54, Jonathan Cameron >>> wrote: >>> >>> On Thu, 15 May 2025 18:04:18 +0900 >>> Itaru Kitayama wrote: >>> > On May 13, 2025, at 20:14, Jo

Re: [PATCH rfcv3 05/21] vfio/iommufd: Save vendor specific device info

2025-05-21 Thread Nicolin Chen
On Wed, May 21, 2025 at 07:14:35PM +0800, Zhenzhong Duan wrote: > @@ -852,6 +853,17 @@ static bool hiod_iommufd_vfio_realize(HostIOMMUDevice > *hiod, void *opaque, > caps->type = type; > caps->hw_caps = hw_caps; > > +switch (type) { > +case IOMMU_HW_INFO_TYPE_INTEL_VTD: > +

Re: [PATCH] vfio/container: pass MemoryRegion to DMA operations

2025-05-21 Thread John Levon
On Wed, May 21, 2025 at 10:55:34PM +0100, John Levon wrote: > Pass through the MemoryRegion to DMA operation handlers of vfio > containers. The vfio-user container will need this later, to translate > the vaddr into an offset for the dma map vfio-user message; CPR will > also will need this. Sent

[PATCH] vfio/container: pass MemoryRegion to DMA operations

2025-05-21 Thread John Levon
Pass through the MemoryRegion to DMA operation handlers of vfio containers. The vfio-user container will need this later, to translate the vaddr into an offset for the dma map vfio-user message; CPR will also will need this. Originally-by: John Johnson Signed-off-by: Jagannathan Raman Signed-off

Re: [PATCH v2 2/2] migration/hmp: Add "info migrate -a", reorg the dump

2025-05-21 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, May 21, 2025 at 08:43:37AM +, Zhijian Li (Fujitsu) wrote: > [...] > > > After this change, sample output (default, no "-a" specified): > > > > > >Status: postcopy-active > > >Time (ms): total=40504, setup=14, down=145 > > >RAM info: >

Re: Rust in QEMU update, April 2025

2025-05-21 Thread Paolo Bonzini
Il mer 21 mag 2025, 10:37 Paolo Bonzini ha scritto: > > So... not sure what to do there. It seems like vm-memory is very close > to > >> > being usable by QEMU, but maybe not completely. :( >> >> Is it possible or necessary for vm-memory to support overlap? Because I >> feel that if it is possib

Re: [PATCH 14/22] hw/i386/acpi-build: Move aml_pci_edsm to a generic place

2025-05-21 Thread Gustavo Romero
Hi Eric, On 5/21/25 13:24, Gustavo Romero wrote: Hi Eric, On 5/21/25 12:56, Eric Auger wrote: Hi Gustavo, On 5/21/25 5:26 PM, Gustavo Romero wrote: Hi Eric, On 5/14/25 14:01, Eric Auger wrote: Move aml_pci_edsm to pcihp since we want to reuse that for ARM and acpi-index support. Signed-of

Re: [PATCH V3 38/42] vfio/iommufd: reconstruct hw_caps

2025-05-21 Thread Steven Sistare
I withdraw this patch. I will instead save devid in cpr-state. - Steve On 5/12/2025 11:32 AM, Steve Sistare wrote: hw_caps is normally derived during realize, at vfio_device_hiod_create_and_realize -> hiod_iommufd_vfio_realize -> iommufd_backend_get_device_info. However, this depends on the d

[PATCH v7 1/2] tests/functional: add skipLockedMemoryTest decorator

2025-05-21 Thread Alexandr Moshkov
Used in future commit to skipping execution of a tests if the system's locked memory limit is below the required threshold. Signed-off-by: Alexandr Moshkov Reviewed-by: Thomas Huth --- tests/functional/qemu_test/__init__.py | 2 +- tests/functional/qemu_test/decorators.py | 18 ++

Re: [PATCH] file-posix: Probe paths and retry SG_IO on potential path errors

2025-05-21 Thread Benjamin Marzinski
On Wed, May 21, 2025 at 07:46:30PM +0200, Kevin Wolf wrote: > Am 20.05.2025 um 16:03 hat Stefan Hajnoczi geschrieben: > > On Thu, May 15, 2025 at 05:02:46PM +0200, Kevin Wolf wrote: > > > Am 15.05.2025 um 16:01 hat Stefan Hajnoczi geschrieben: > > > > On Thu, May 15, 2025 at 10:15:53AM +0200, Kevin

Re: QEMU 10.1 release schedule

2025-05-21 Thread Peter Maydell
On Wed, 21 May 2025 at 19:30, Stefan Hajnoczi wrote: > > Hi, > Daniel Berrangé has proposed a release schedule that looks good to me. > The release will happen just before the KVM Forum conference. > > Please reply if you have any questions or concerns about these dates! > > - Soft freeze: 2025-07

Re: [PATCH] vfio/igd: Fix incorrect error propagation in vfio_pci_igd_opregion_detect()

2025-05-21 Thread Alex Williamson
On Wed, 21 May 2025 23:40:36 +0800 Tomita Moeko wrote: > In vfio_pci_igd_opregion_detect(), errp will be set when device does > not have OpRegion or is hotplugged. This errp will be propergated to propagated > pci_qdev_realize(), which interprets it as failure, causing unexpected > termination

Re: [PATCH v2 08/12] qapi: Make CpuModelExpansionInfo::deprecated-props optional and generic

2025-05-21 Thread Pierrick Bouvier
On 5/18/25 11:18 PM, Markus Armbruster wrote: Pierrick Bouvier writes: From: Philippe Mathieu-Daudé We'd like to have some unified QAPI schema. Having a structure field conditional to a target being built in is not very practical. While @deprecated-props is only used by s390x target, it is

Re: [PATCH v2 09/12] qapi: make most CPU commands unconditionally available

2025-05-21 Thread Pierrick Bouvier
On 5/18/25 11:29 PM, Markus Armbruster wrote: Pierrick Bouvier writes: From: Daniel P. Berrangé This removes the TARGET_* conditions from all the CPU commands that are conceptually target independent. Top level stubs are provided to cope with targets which do not currently implement all of t

Re: [PATCH v2 02/12] qapi: expand docs for SEV commands

2025-05-21 Thread Pierrick Bouvier
On 5/18/25 10:57 PM, Markus Armbruster wrote: Pierrick Bouvier writes: From: Daniel P. Berrangé This gives some more context about the behaviour of the commands in unsupported guest configuration or platform scenarios. Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé Signe

[PATCH] target/arm: Ignore SCTLR_EL2.EnSCXT when !ELIsInHost()

2025-05-21 Thread Oliver Upton
Using an EL2 that enables SCXTNUM_ELx for guests while disabling the feature for the host generates erroneous traps to EL2 when running under TCG. Fix the issue by only evaluating SCTLR_EL2.EnSCXT when ELIsInHost(). Signed-off-by: Oliver Upton --- target/arm/helper.c | 16 1 fi

Re: [PATCH v5 23/25] tests: add plugin asserting correctness of discon event's to_pc

2025-05-21 Thread Pierrick Bouvier
On 5/20/25 2:09 PM, Pierrick Bouvier wrote: On 5/20/25 1:44 PM, Julian Ganz wrote: Hi Pierrick, May 20, 2025 at 10:01 PM, Pierrick Bouvier wrote: Regarding the issue with the same tb being mapped at different virtual addresses, I'm ok with the current solution of comparing only page bits. Th

Re: [PATCH V3 37/42] vfio/iommufd: reconstruct device

2025-05-21 Thread Steven Sistare
I withdraw this patch. Most of it is not needed if I save ioas_id in cpr-state. I will move a tiny bit that remains to another patch. - Steve On 5/12/2025 11:32 AM, Steve Sistare wrote: Reconstruct userland device state after CPR. During vfio_realize, skip all ioctls that configure the devic

  1   2   3   4   >