Hi reviewers,
Please ignore this patch - I mistakenly sent two versions of patch 2/5.
The correct one is titled:
[PATCH v3 2/5] hw/arm/aspeed_ast27x0: Fix unimplemented region overlap with
VBootROM
Sorry for the confusion.
Regards,
Steven
> -----Original Message-----
> From: Steven Lee <steven_...@aspeedtech.com>
> Sent: Thursday, May 22, 2025 11:36 AM
> To: Cédric Le Goater <c...@kaod.org>; Peter Maydell
> <peter.mayd...@linaro.org>; Troy Lee <leet...@gmail.com>; Jamin Lin
> <jamin_...@aspeedtech.com>; Andrew Jeffery
> <and...@codeconstruct.com.au>; Joel Stanley <j...@jms.id.au>; open
> list:ASPEED BMCs <qemu-...@nongnu.org>; open list:All patches CC here
> <qemu-devel@nongnu.org>
> Cc: Troy Lee <troy_...@aspeedtech.com>; long...@lenovo.com; Yunlin Tang
> <yunlin.t...@aspeedtech.com>; Steven Lee <steven_...@aspeedtech.com>
> Subject: [PATCH v3 2/5] hw/arm/aspeed_ast27x0: Remove unused iomem
> region overlapping VBootROM
>
> The iomem region at 0x00000000 is unused and overlaps with VBootROM.
> Removing it avoids incorrect memory layout.
>
> Signed-off-by: Steven Lee <steven_...@aspeedtech.com>
> ---
> hw/arm/aspeed_ast27x0.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index
> 1974a25766..328897ded0 100644
> --- a/hw/arm/aspeed_ast27x0.c
> +++ b/hw/arm/aspeed_ast27x0.c
> @@ -23,13 +23,11 @@
> #include "qobject/qlist.h"
> #include "qemu/log.h"
>
> -#define AST2700_SOC_IO_SIZE 0x01000000
> #define AST2700_SOC_IOMEM_SIZE 0x01000000
> #define AST2700_SOC_DPMCU_SIZE 0x00040000
> #define AST2700_SOC_LTPI_SIZE 0x01000000
>
> static const hwaddr aspeed_soc_ast2700_memmap[] = {
> - [ASPEED_DEV_IOMEM] = 0x00000000,
> [ASPEED_DEV_VBOOTROM] = 0x00000000,
> [ASPEED_DEV_SRAM] = 0x10000000,
> [ASPEED_DEV_DPMCU] = 0x11000000,
> @@ -521,8 +519,6 @@ static void aspeed_soc_ast2700_init(Object *obj)
> TYPE_UNIMPLEMENTED_DEVICE);
> object_initialize_child(obj, "ltpi", &s->ltpi,
> TYPE_UNIMPLEMENTED_DEVICE);
> - object_initialize_child(obj, "iomem", &s->iomem,
> - TYPE_UNIMPLEMENTED_DEVICE);
> object_initialize_child(obj, "iomem0", &s->iomem0,
> TYPE_UNIMPLEMENTED_DEVICE);
> object_initialize_child(obj, "iomem1", &s->iomem1, @@ -942,10 +938,6
> @@ static void aspeed_soc_ast2700_realize(DeviceState *dev, Error **errp)
> "aspeed.ltpi",
> sc->memmap[ASPEED_DEV_LTPI],
> AST2700_SOC_LTPI_SIZE);
> - aspeed_mmio_map_unimplemented(s, SYS_BUS_DEVICE(&s->iomem),
> - "aspeed.io",
> -
> sc->memmap[ASPEED_DEV_IOMEM],
> - AST2700_SOC_IO_SIZE);
> aspeed_mmio_map_unimplemented(s, SYS_BUS_DEVICE(&s->iomem0),
> "aspeed.iomem0",
>
> sc->memmap[ASPEED_DEV_IOMEM0],
> --
> 2.43.0
