Re: [RFC PATCH 6/9] rust: vmstate: add public utility macros to implement VMState

2025-01-07 Thread Zhao Liu
> +/// This macro can be used (by just passing it a type) to forward the > `VMState` > +/// trait to the first field of a tuple. This is a workaround for lack of > +/// support of nested [`offset_of`](core::mem::offset_of) until Rust 1.82.0. > +/// > +/// # Examples > +/// > +/// ``` > +/// # use

Re: [PATCH v1 2/5] hw/vfio/ap: notification handler for AP config changed event

2025-01-07 Thread Cédric Le Goater
On 1/7/25 19:43, Rorie Reyes wrote: Register an event notifier handler to process AP configuration change events by queuing the event and generating a CRW to let the guest know its AP configuration has changed Signed-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak Tested-by: Anthony Krowiak

Re: [PATCH] hw/riscv/riscv-iommu.c: Introduce a translation tag for the page table cache

2025-01-07 Thread Jason Chien
Hi Daniel, There is no response from Tomasz. Should this patch be merged? Jason Chien 於 2024年12月18日 週三 下午5:52寫道: > Ping. > > Jason Chien 於 2024年11月25日 週一 下午8:49寫道: > >> Hi Tomasz, any thoughs? >> >> Daniel Henrique Barboza 於 2024年11月12日 週二 >> 下午8:26寫道: >> >>> >>> CCing Tomasz >>> >>> On 11/8/

Re: [PATCH v1 1/5] linux-headers: NOTFORMERGE - placeholder uapi updates for AP config change

2025-01-07 Thread Cédric Le Goater
Hello Rorie, On 1/7/25 19:43, Rorie Reyes wrote: This patch adds enumeration constant VFIO_AP_CFG_CHG_IRQ_INDEX to specify an IRQ index for signaling that a change has been made to the guest's AP configuration. This is a placeholder for QEMU patches that use this value since it is a linux-header

Re: [PATCH v3 20/29] tests/functional: extend test_aarch64_virt with vulkan test

2025-01-07 Thread Thomas Huth
On 07/01/2025 17.51, Alex Bennée wrote: Now we have virtio-gpu Vulkan support lets add a test for it. I'm not a native speaker, but maybe rather: Now that we have virtio-gpu Vulkan support, let's add a test for it. ? ... diff --git a/tests/functional/test_aarch64_virt.py b/tests/functional

Re: [PATCH] qapi: fix colon in Since tag section

2025-01-07 Thread Markus Armbruster
Victor Toso writes: > As described in docs/devel/qapi-code-gen.rst line 998, > there should be no space between "Since" and ":". > > Signed-off-by: Victor Toso > --- > qapi/cxl.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qapi/cxl.json b/qapi/cxl.json > inde

Re: [PATCH v8 0/9] virtio-net: add support for SR-IOV emulation

2025-01-07 Thread Lei Yang
I tested this series of patches with virtio-net regression tests and basic scenario tests (reboot, shutdown, jumbo) for vf, everything works fine. Tested-by: Lei Yang On Sat, Jan 4, 2025 at 4:02 PM Akihiko Odaki wrote: > > Based-on: <20250104-reuse-v18-0-c349eafd8...@daynix.com> > ("[PATCH v18

Re: [PATCH v3 19/29] tests/functional: add zstd support to uncompress utility

2025-01-07 Thread Thomas Huth
On 07/01/2025 17.51, Alex Bennée wrote: Rather than using the python library (which has a different API anyway) lets just call the binary. zstdtools is already in out qemu.yml so all test containers should have it around. Tests should still use @skipIfMissingCommands('zstd') to gracefully handle

Re: [PATCH 1/7] memory: Export a helper to get intersection of a MemoryRegionSection with a given range

2025-01-07 Thread Chenyi Qiang
On 1/8/2025 12:47 PM, Alexey Kardashevskiy wrote: > On 13/12/24 18:08, Chenyi Qiang wrote: >> Rename the helper to memory_region_section_intersect_range() to make it >> more generic. >> >> Signed-off-by: Chenyi Qiang >> --- >>   hw/virtio/virtio-mem.c | 32 +--- >>  

Re: [PATCH 0/7] Enable shared device assignment

2025-01-07 Thread Chenyi Qiang
Thanks Alexey for your review! On 1/8/2025 12:47 PM, Alexey Kardashevskiy wrote: > On 13/12/24 18:08, Chenyi Qiang wrote: >> Commit 852f0048f3 ("RAMBlock: make guest_memfd require uncoordinated >> discard") effectively disables device assignment when using guest_memfd. >> This poses a significant

Re: [RFC PATCH 5/9] rust: vmstate: implement VMState for scalar types

2025-01-07 Thread Zhao Liu
> #[macro_export] > macro_rules! vmstate_of { > -($struct_name:ty, $field_name:ident $([0 .. $num:ident $(* > $factor:expr)?])? $(,)?) => { > +($struct_name:ty, $field_name:ident $([0 .. $num:tt $(* > $factor:expr)?])? $(,)?) => { Why change ident to tt? > $crate::bindings::

[PATCH v4 3/4] qdev-properties: Add DEFINE_PROP_ON_OFF_AUTO_BIT64()

2025-01-07 Thread Akihiko Odaki
DEFINE_PROP_ON_OFF_AUTO_BIT64() corresponds to DEFINE_PROP_ON_OFF_AUTO() as DEFINE_PROP_BIT64() corresponds to DEFINE_PROP_BOOL(). The difference is that DEFINE_PROP_ON_OFF_AUTO_BIT64() exposes OnOffAuto instead of bool. Signed-off-by: Akihiko Odaki --- include/hw/qdev-properties.h | 18

[PATCH v4 2/4] qdev-properties: Accept bool for OnOffAuto

2025-01-07 Thread Akihiko Odaki
Accept bool literals for OnOffAuto properties for consistency with bool properties. This enables users to set the "on" or "off" value in a uniform syntax without knowing whether the "auto" value is accepted. This behavior is especially useful when converting an existing bool property to OnOffAuto o

[PATCH v4 1/4] qapi: Do not consume a value if failed

2025-01-07 Thread Akihiko Odaki
Do not consume a value if interpreting one failed so that we can reinterpret the value with a different type. Signed-off-by: Akihiko Odaki --- qapi/qobject-input-visitor.c | 103 +-- 1 file changed, 69 insertions(+), 34 deletions(-) diff --git a/qapi/qobj

[PATCH v4 4/4] virtio: Convert feature properties to OnOffAuto

2025-01-07 Thread Akihiko Odaki
Some features are not always available with vhost. Legacy features are not available with vp_vdpa in particular. virtio devices used to disable them when not available even if the corresponding properties were explicitly set to "on". QEMU already has OnOffAuto type, which includes the "auto" value

[PATCH v4 0/4] virtio: Convert feature properties to OnOffAuto

2025-01-07 Thread Akihiko Odaki
This series was spun off from: "[PATCH 0/3] virtio-net: Convert feature properties to OnOffAuto" (https://patchew.org/QEMU/20240714-auto-v3-0-e27401aab...@daynix.com/) Some features are not always available with vhost. Legacy features are not available with vp_vdpa in particular. virtio devices us

Re: [PATCH v3 0/2] Add new PowerPC Special Purpose Registers

2025-01-07 Thread Harsh Prateek Bora
+ Shivaprasad (had posted patches for DAWR1/DAWRX1 earlier) https://lore.kernel.org/qemu-devel/170679876639.188422.11634974895844092362.st...@ltc-boston1.aus.stglabs.ibm.com/ On 1/8/25 02:21, dan tan wrote: From: dan tan *** BLURB HERE *** Version 3 summary: RWMR (Region Weighted Mode Re

Re: [PATCH 0/7] Enable shared device assignment

2025-01-07 Thread Alexey Kardashevskiy
On 13/12/24 18:08, Chenyi Qiang wrote: Commit 852f0048f3 ("RAMBlock: make guest_memfd require uncoordinated discard") effectively disables device assignment when using guest_memfd. This poses a significant challenge as guest_memfd is essential for confidential guests, thereby blocking device assi

Re: [PATCH 2/7] guest_memfd: Introduce an object to manage the guest-memfd with RamDiscardManager

2025-01-07 Thread Alexey Kardashevskiy
On 13/12/24 18:08, Chenyi Qiang wrote: As the commit 852f0048f3 ("RAMBlock: make guest_memfd require uncoordinated discard") highlighted, some subsystems like VFIO might disable ram block discard. However, guest_memfd relies on the discard operation to perform page conversion between private and

Re: [PATCH 1/7] memory: Export a helper to get intersection of a MemoryRegionSection with a given range

2025-01-07 Thread Alexey Kardashevskiy
On 13/12/24 18:08, Chenyi Qiang wrote: Rename the helper to memory_region_section_intersect_range() to make it more generic. Signed-off-by: Chenyi Qiang --- hw/virtio/virtio-mem.c | 32 +--- include/exec/memory.h | 13 + system/memory.c| 17 +

Re: [PATCH 5/7] memory: Register the RamDiscardManager instance upon guest_memfd creation

2025-01-07 Thread Alexey Kardashevskiy
On 13/12/24 18:08, Chenyi Qiang wrote: Introduce the realize()/unrealize() callbacks to initialize/uninitialize the new guest_memfd_manager object and register/unregister it in the target MemoryRegion. Guest_memfd was initially set to shared until the commit bd3bcf6962 ("kvm/memory: Make memory

RE: [PATCH 0/5] Introduce AST27x0 multi-SoC machine

2025-01-07 Thread Steven Lee
Hi Cédric, > -Original Message- > From: Cédric Le Goater > Sent: Tuesday, January 7, 2025 11:51 PM > To: Steven Lee ; Peter Maydell > ; Troy Lee ; Jamin Lin > ; Andrew Jeffery > ; Joel Stanley ; open > list:ASPEED BMCs ; open list:All patches CC here > > Cc: Troy Lee ; Yunlin Tang > > S

Re: [RFC PATCH 3/9] rust: vmstate: add varray support to vmstate_of!

2025-01-07 Thread Zhao Liu
On Tue, Dec 31, 2024 at 01:23:30AM +0100, Paolo Bonzini wrote: > Date: Tue, 31 Dec 2024 01:23:30 +0100 > From: Paolo Bonzini > Subject: [RFC PATCH 3/9] rust: vmstate: add varray support to vmstate_of! > X-Mailer: git-send-email 2.47.1 > > Untested... > > Signed-off-by: Paolo Bonzini > --- > ru

Re: [RFC PATCH 2/5] system/memory: support unaligned access

2025-01-07 Thread Tomoyuki HIROSE
Happy new year, Peter. I had another job and was late in replying to your email, sorry. On 2024/12/13 0:46, Peter Xu wrote: On Thu, Dec 12, 2024 at 02:39:41PM +0900, Tomoyuki HIROSE wrote: On 2024/12/12 7:54, Peter Xu wrote: On Wed, Dec 11, 2024 at 06:35:57PM +0900, Tomoyuki HIROSE wrote: So

Re: [PATCH v3 0/2] Move net backend cleanup to NIC cleanup

2025-01-07 Thread Jason Wang
On Mon, Jan 6, 2025 at 11:58 PM Jonah Palmer wrote: > > Commit a0d7215e33 ("vhost-vdpa: do not cleanup the vdpa/vhost-net > structures if peer nic is present") effectively delayed the backend > cleanup, allowing the frontend or the guest to access it resources as > long as the frontend NIC is stil

Re: Subject: [PATCH] loader: Add register setting support via cli

2025-01-07 Thread Sam Price
I made the changes, and added documentation. https://gitlab.com/thesamprice/qemu/-/compare/master...loader?from_project_id=11167699 I left it as [PREFIX] I can switch this to just RegNumber if desired. I am still struggling with the email format sorry. --- docs/system/generic-loader.rst | 98 +++

Re: [PATCH] target/loongarch: Only support 64bit pte width

2025-01-07 Thread bibo mao
On 2024/12/31 下午6:07, Bibo Mao wrote: With manual pte width can be 64bit, 128bit or more. Instead real hardware only supports 64bit pte width. For 12bit pte, there is no detail definition for all 128bit from manual. Here only 64bit pte width is supported for simplicity, will add this in later

Re: [PATCH v3 0/2] hw/loongarch/boot: Support Linux raw boot image

2025-01-07 Thread bibo mao
On 2025/1/3 上午6:47, Jiaxun Yang wrote: Signed-off-by: Jiaxun Yang --- Changes in v3: - Added PATCH 1 (Richard) - Link to v2: https://lore.kernel.org/r/20241224-la-direct-kernel-boot-v2-1-3e8336c54...@flygoat.com Changes in v2: - Use extract API for getting bit fields (philmd) - Mimic arm's

Re: [PATCH 6/7] migration: Fix arrays of pointers in JSON writer

2025-01-07 Thread Peter Xu
On Tue, Jan 07, 2025 at 04:50:24PM -0300, Fabiano Rosas wrote: > Currently, if an array of pointers contains a NULL pointer, that > pointer will be encoded as '0' in the stream. Since the JSON writer > doesn't define a "pointer" type, that '0' will now be an uint64, which > is different from the or

Re: or1k -M virt -hda and net.

2025-01-07 Thread Rob Landley
On 1/7/25 12:05, Alex Bennée wrote: Stafford Horne writes: I have not used -hda before, do you have it working with other targets? According to the qemu docs in qemu-options.hx. I see: Use file as hard disk 0, 1, 2 or 3 image on the default bus of the emulated machine (this is for e

Re: or1k -M virt -hda and net.

2025-01-07 Thread Rob Landley
On 1/7/25 11:31, Stafford Horne wrote: On Tue, Jan 07, 2025 at 05:56:52AM -0600, Rob Landley wrote: On 12/31/24 19:19, Rob Landley wrote: On 12/23/24 07:05, Stafford Horne wrote: The kernel config looks like it should have virt block device support, but ...    -device virtio-blk-device,driv

Re: [PATCH v3 0/3] Introduce a new Write Protected pin inverted property

2025-01-07 Thread Peter Maydell
On Tue, 7 Jan 2025 at 17:55, Cédric Le Goater wrote: > > Hello, > > > I would not recommend using qemu_irq_invert() in new code. > > > > I guess in an ideal world we'd implement a QOM object > > that encapsulated the the "not gate" logic, similar to > > TYPE_OR_IRQ. (Though for TYPE_OR_IRQ we made

Re: [PATCH 3/7] migration: Document the effect of vmstate_info_nullptr

2025-01-07 Thread Peter Xu
On Tue, Jan 07, 2025 at 04:50:21PM -0300, Fabiano Rosas wrote: > The migration stream lacks magic numbers at some key points. It's easy > to mis-parse data. Unfortunately, the VMS_NULLPTR_MARKER continues > with the trend. A '0' byte is ambiguous and could be interpreted as a > valid 0x30. > > It

Re: [PATCH 2/7] migration: Remove unused argument in vmsd_desc_field_end

2025-01-07 Thread Peter Xu
On Tue, Jan 07, 2025 at 04:50:20PM -0300, Fabiano Rosas wrote: > Signed-off-by: Fabiano Rosas Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH 0/2] test/qtest/migration: Use out-of-band execution for migrate-recover

2025-01-07 Thread Peter Xu
On Tue, Jan 07, 2025 at 05:31:52PM +0100, Juraj Marcin wrote: > In real use cases, the migrate-recover command requires out-of-band > execution, because the main thread processing normal commands is blocked > by a page fault in the guest memory. Tests, however, do not reflect this > which might res

[PATCH v1 2/5] hw/vfio/ap: notification handler for AP config changed event

2025-01-07 Thread Rorie Reyes
Register an event notifier handler to process AP configuration change events by queuing the event and generating a CRW to let the guest know its AP configuration has changed Signed-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak Tested-by: Anthony Krowiak --- hw/vfio/ap.c | 27 +++

[PATCH v1 1/5] linux-headers: NOTFORMERGE - placeholder uapi updates for AP config change

2025-01-07 Thread Rorie Reyes
This patch adds enumeration constant VFIO_AP_CFG_CHG_IRQ_INDEX to specify an IRQ index for signaling that a change has been made to the guest's AP configuration. This is a placeholder for QEMU patches that use this value since it is a linux-headers update which includes changes that aren't merged i

[PATCH v1 5/5] s390: implementing CHSC SEI for AP config change

2025-01-07 Thread Rorie Reyes
Handle interception of the CHSC SEI instruction for requests indicating the guest's AP configuration has changed. Signed-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak Tested-by: Anthony Krowiak --- target/s390x/ioinst.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff

[PATCH v1 4/5] hw/vfio/ap: Storing event information for an AP configuration change event

2025-01-07 Thread Rorie Reyes
These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie Reyes --- hw/vfio/ap.c | 37 inc

[PATCH v1 0/5] Report vfio-ap configuration changes

2025-01-07 Thread Rorie Reyes
This patch series creates and registers a handler that is called when userspace is notified by the kernel that a guest's AP configuration has changed. The handler in turn notifies the guest that its AP configuration has changed. This allows the guest to immediately respond to AP configuration chang

[PATCH v1 3/5] hw/vfio/ap: store object indicating AP config changed in a queue

2025-01-07 Thread Rorie Reyes
Creates an object indicating that an AP configuration change event has been received and stores it in a queue. These objects will later be used to store event information for an AP configuration change when the CHSC instruction is intercepted. Signed-off-by: Rorie Reyes Reviewed-by: Anthony Krowi

[PATCH v3 2/2] ppc/pnv: Add new PowerPC Special Purpose Registers (RWMR)

2025-01-07 Thread dan tan
From: dan tan Register RWMR - Region Weighted Mode Register for privileged access in Power9 and Power10 It controls what the SPURR register produces. Specs: - Power9: https://ibm.ent.box.com/s/tmklq90ze7aj8f4n32er1mu3sy9u8k3k - Power10: https://files.openpower.foundation/s/EgCy7C43p2NSRfR Si

[PATCH v3 1/2] ppc/pnv: Add new PowerPC Special Purpose Registers (DAWR1, DAWRX1)

2025-01-07 Thread dan tan
From: dan tan The handling of the following two registers are added to POWER10 - - DAWR1 (0x0bd, 189) - Data Address Watchpoint 1 - DAWRX1 (0x0b5, 181) - Data Address Watchpoint Extension 1 Signed-off-by: dan tan --- ver 3 no change ver 2 summary: - spec reference: https://files.openpower

[PATCH v3 0/2] Add new PowerPC Special Purpose Registers

2025-01-07 Thread dan tan
From: dan tan *** BLURB HERE *** Version 3 summary: RWMR (Region Weighted Mode Register) - - change the register to generic read/write from nop/write Version 2 summary: (DAWR1,DAWRX1): - spec reference: https://files.openpower.foundation/s/EgCy7C43p2NSRfR - correc

Re: [PATCH v3 16/29] tests/qtest: remove clock_steps from virtio tests

2025-01-07 Thread Fabiano Rosas
Alex Bennée writes: > In the qtest environment time will not step forward if the system is > paused (timers disabled) or we have no timer events to fire. As a > result VirtIO events are responded to directly and we don't need to > step time forward. > > We still do timeout processing to handle th

[PATCH 4/7] migration: Fix parsing of s390 stream

2025-01-07 Thread Fabiano Rosas
The parsing for the S390StorageAttributes section is currently leaving an unconsumed token that is later interpreted by the generic code as QEMU_VM_EOF, cutting the parsing short. The migration will issue a STATTR_FLAG_DONE between iterations, which the script consumes correctly, but there's a fin

[PATCH 7/7] s390x: Fix CSS migration

2025-01-07 Thread Fabiano Rosas
Commit a55ae46683 ("s390: move css_migration_enabled from machine to css.c") disabled CSS migration globally instead of doing it per-instance. CC: Paolo Bonzini CC: qemu-sta...@nongnu.org #9.1 Fixes: a55ae46683 ("s390: move css_migration_enabled from machine to css.c") Resolves: https://gitlab.co

[PATCH 6/7] migration: Fix arrays of pointers in JSON writer

2025-01-07 Thread Fabiano Rosas
Currently, if an array of pointers contains a NULL pointer, that pointer will be encoded as '0' in the stream. Since the JSON writer doesn't define a "pointer" type, that '0' will now be an uint64, which is different from the original type being pointed to, e.g. struct. That mixed-type array shoul

[PATCH 0/7] migration: Fix s390 regressions + migration script

2025-01-07 Thread Fabiano Rosas
Hi, The situation that broke the last migration PR was: 1) emitting of JSON data by QEMU for VMSTATE_ARRAY_OF_POINTER_TO_STRUCT when NULL pointers are present has been broken for a while; 2) parsing of s390x migration stream by analyze-script.py has been broken for a while; (there's

[PATCH 2/7] migration: Remove unused argument in vmsd_desc_field_end

2025-01-07 Thread Fabiano Rosas
Signed-off-by: Fabiano Rosas --- migration/vmstate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/vmstate.c b/migration/vmstate.c index fa002b24e8..aa2821dec6 100644 --- a/migration/vmstate.c +++ b/migration/vmstate.c @@ -311,7 +311,7 @@ static void vmsd_desc_

[PATCH 5/7] migration: Dump correct JSON format for nullptr replacement

2025-01-07 Thread Fabiano Rosas
From: Peter Xu QEMU plays a trick with null pointers inside an array of pointers in a VMSD field. See 07d4e69147 ("migration/vmstate: fix array of ptr with nullptrs") for more details on why. The idea makes sense in general, but it may overlooked the JSON writer where it could write nothing in

[PATCH 3/7] migration: Document the effect of vmstate_info_nullptr

2025-01-07 Thread Fabiano Rosas
The migration stream lacks magic numbers at some key points. It's easy to mis-parse data. Unfortunately, the VMS_NULLPTR_MARKER continues with the trend. A '0' byte is ambiguous and could be interpreted as a valid 0x30. It is maybe not worth trying to change this while keeping backward compatibili

[PATCH 1/7] migration: Add more error handling to analyze-migration.py

2025-01-07 Thread Fabiano Rosas
The analyze-migration script was seen failing in s390x in misterious ways. It seems we're reaching the VMSDFieldStruct constructor without any fields, which would indicate an empty .subsection entry, a VMSTATE_STRUCT with no fields or a vmsd with no fields. We don't have any of those, at least not

Re: [PATCH v2 0/2] qtest: Remove uses of 'first_cpu'

2025-01-07 Thread Philippe Mathieu-Daudé
On 4/1/25 00:48, Philippe Mathieu-Daudé wrote: On 3/1/25 13:26, Fabiano Rosas wrote: Philippe Mathieu-Daudé writes: Hi Fabiano, On 12/12/24 00:37, Philippe Mathieu-Daudé wrote: Replace first_cpu->as by address_space_memory. Philippe Mathieu-Daudé (2):     system/qtest: Remove uses of 'firs

Re: [PATCH v3 2/3] hw/sd/sdhci: Introduce a new Write Protected pin inverted property

2025-01-07 Thread Philippe Mathieu-Daudé
On 14/11/24 10:48, Jamin Lin wrote: The Write Protect pin of SDHCI model is default active low to match the SDHCI spec. So, write enable the bit 19 should be 1 and write protected the bit 19 should be 0 at the Present State Register (0x24). However, some boards are design Write Protected pin acti

Re: [PATCH v3 1/3] hw/sd/sdhci: Fix coding style

2025-01-07 Thread Philippe Mathieu-Daudé
On 14/11/24 10:48, Jamin Lin wrote: Fix coding style issues from checkpatch.pl Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater --- hw/sd/sdhci.c | 64 +-- 1 file changed, 42 insertions(+), 22 deletions(-) Reviewed-by: Philippe Mathieu

Re: [PATCH v3 3/3] hw/arm/aspeed: Invert sdhci write protected pin for AST2600 EVB

2025-01-07 Thread Philippe Mathieu-Daudé
On 14/11/24 10:48, Jamin Lin wrote: The Write Protect pin of SDHCI model is default active low to match the SDHCI spec. So, write enable the bit 19 should be 1 and write protected the bit 19 should be 0 at the Present State Register (0x24). According to the design of AST2600 EVB, the Write Prote

[RFC PATCH] tests/qtest/stm32l4x5_usart: Avoid accessing NVIC via MMIO

2025-01-07 Thread Philippe Mathieu-Daudé
The STM32L4x5 SoC family use a ARM Cortex-M core. Such core is architecturally tied with a NVIC (interrupt controller), having the NVIC MMIO mapped in the core address space. When using the QTest accelerator, we don't emulate vCPU, only a dummy is created. For now, QTest is only supposed to access

Re: [PATCH v1 0/5] Report vfio-ap configuration changes

2025-01-07 Thread Alex Williamson
On Tue, 7 Jan 2025 13:43:49 -0500 Rorie Reyes wrote: > This patch series creates and registers a handler that is called when > userspace is notified by the kernel that a guest's AP configuration has > changed. The handler in turn notifies the guest that its AP configuration > has changed. This a

Re: [PATCH v3 6/7] tests/qtest: Add API functions to capture IRQ toggling

2025-01-07 Thread Philippe Mathieu-Daudé
On 7/1/25 19:35, Philippe Mathieu-Daudé wrote: Cc'ing maintainers: $ ./scripts/get_maintainer.pl -f tests/qtest/libqtest.c Fabiano Rosas (maintainer:qtest) Laurent Vivier (maintainer:qtest) Paolo Bonzini (reviewer:qtest) On 16/12/24 15:18, Gustavo Romero wrote: Currently, the QTest API does

Re: [PATCH] rust: add --check-cfg test to rustc arguments

2025-01-07 Thread Paolo Bonzini
Il mar 7 gen 2025, 16:54 Paolo Bonzini ha scritto: > rustc will check that every reachable #[cfg] matches a list of > the expected config names and values. Recent versions of rustc are > also complaining about #[cfg(test)], even if it is basically a standard > part of the language. So, always a

Re: [PATCH v3 6/7] tests/qtest: Add API functions to capture IRQ toggling

2025-01-07 Thread Philippe Mathieu-Daudé
Cc'ing maintainers: $ ./scripts/get_maintainer.pl -f tests/qtest/libqtest.c Fabiano Rosas (maintainer:qtest) Laurent Vivier (maintainer:qtest) Paolo Bonzini (reviewer:qtest) On 16/12/24 15:18, Gustavo Romero wrote: Currently, the QTest API does not provide a function to capture when an IRQ l

Re: [PATCH v3 0/3] Introduce a new Write Protected pin inverted property

2025-01-07 Thread Cédric Le Goater
On 11/27/24 12:23, Philippe Mathieu-Daudé wrote: On 27/11/24 10:44, Cédric Le Goater wrote: On 11/14/24 10:48, Jamin Lin wrote: change from v1: 1. Support RTC for AST2700. 2. Support SDHCI write protected pin inverted for AST2500 and AST2600. 3. Introduce Capabilities Register 2 for SD slot 0 a

Re: or1k -M virt -hda and net.

2025-01-07 Thread Alex Bennée
Stafford Horne writes: > On Tue, Jan 07, 2025 at 05:56:52AM -0600, Rob Landley wrote: >> On 12/31/24 19:19, Rob Landley wrote: >> > On 12/23/24 07:05, Stafford Horne wrote: >> > > > The kernel config looks like it should have virt block device >> > > > support, but >> ... >> > >    -device virtio

Re: [PATCH v3 0/3] Introduce a new Write Protected pin inverted property

2025-01-07 Thread Cédric Le Goater
Hello, I would not recommend using qemu_irq_invert() in new code. I guess in an ideal world we'd implement a QOM object that encapsulated the the "not gate" logic, similar to TYPE_OR_IRQ. (Though for TYPE_OR_IRQ we made the mistake of making it inherit from TYPE_DEVICE, not TYPE_SYSBUS_DEVICE,

Re: or1k -M virt -hda and net.

2025-01-07 Thread Stafford Horne
On Tue, Jan 07, 2025 at 05:56:52AM -0600, Rob Landley wrote: > On 12/31/24 19:19, Rob Landley wrote: > > On 12/23/24 07:05, Stafford Horne wrote: > > > > The kernel config looks like it should have virt block device > > > > support, but > ... > > >    -device virtio-blk-device,drive=d0 -drive > > >

Re: [RESEND][PATCH v3 0/7] Add ivshmem-flat device

2025-01-07 Thread Alex Bennée
Markus Armbruster writes: > Gustavo Romero writes: > >> This is a resend of the series: >> >> https://lore.kernel.org/qemu-devel/2024022218.2261956-1-gustavo.rom...@linaro.org/ >> >> rebased on the current master. The series was sent about 9 months ago and >> remains relevant. Besides addres

Re: [PATCH 1/1] docs/nitro-enclave: Clarify Enclave and Firecracker relationship

2025-01-07 Thread Dorjoy Chowdhury
On Tue, Dec 31, 2024 at 12:26 AM Dorjoy Chowdhury wrote: > > On Thu, Dec 12, 2024 at 8:14 PM Dorjoy Chowdhury > wrote: > > > > On Thu, Dec 12, 2024 at 4:25 AM Alexander Graf wrote: > > > > > > The documentation says that Nitro Enclaves are based on Firecracker. AWS > > > has never made that sta

[PATCH v3 24/29] tests/vm: fix build_path based path

2025-01-07 Thread Alex Bennée
We no longer need to go into the per-arch build directories to find the build directories binary. Lets call it directly. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- tests/vm/basevm.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/vm/basevm.py

[PATCH v3 22/29] tests/docker: move riscv64 cross container from sid to trixie

2025-01-07 Thread Alex Bennée
Although riscv64 isn't going to be a release architecture for trixie the packages are still built while it is testing. Moving from sid will also avoid some of the volatility we get from tracking the bleeding edge. Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian-riscv64-cross.docke

[PATCH v3 11/29] tests/functional: update the riscv64 tuxrun tests

2025-01-07 Thread Alex Bennée
Now there are new up to date images available we should update to them. Note we re-use the riscv32 kernel and rootfs for test_riscv64_rv32. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-32-alex.ben...@linaro.org>

[PATCH v3 17/29] system/qtest: properly feedback results of clock_[step|set]

2025-01-07 Thread Alex Bennée
Time will not advance if the system is paused or there are no timer events set for the future. In absence of pending timer events advancing time would make no difference the system state. Attempting to do so would be a bug and the test or device under test would need fixing. Tighten up the result

[PATCH v3 20/29] tests/functional: extend test_aarch64_virt with vulkan test

2025-01-07 Thread Alex Bennée
Now we have virtio-gpu Vulkan support lets add a test for it. Currently this is using images build by buildroot: https://lists.buildroot.org/pipermail/buildroot/2024-December/768196.html Signed-off-by: Alex Bennée --- v2 - use decorator for has_cmd(zstd) - un-handled->unhandled - drop e

Re: [PATCH v2] hw/i386/pc: Fix level interrupt sharing for Xen event channel GSI

2025-01-07 Thread David Woodhouse
On Tue, 2025-01-07 at 16:38 +, Paul Durrant wrote: > > > +#ifdef CONFIG_XEN_EMU > > +    /* > > + * Xen delivers the GSI to the Legacy PIC (not that Legacy PIC > > + * routing actually works properly under Xen). And then to > > + * *either* the PIRQ handling or the

[PATCH v3 18/29] tests/functional: remove hacky sleep from the tests

2025-01-07 Thread Alex Bennée
We have proper detection of prompts now so we don't need to guess with sleep() sprinkled through the test. The extra step of calling halt is just to flush the final bits of the log (although the last line is still missed). Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth --- v2 - avoid lon

[PATCH v3 19/29] tests/functional: add zstd support to uncompress utility

2025-01-07 Thread Alex Bennée
Rather than using the python library (which has a different API anyway) lets just call the binary. zstdtools is already in out qemu.yml so all test containers should have it around. Tests should still use @skipIfMissingCommands('zstd') to gracefully handle when only minimal dependencies have been i

[PATCH v3 07/29] tests/functional: update the mips64el tuxrun tests

2025-01-07 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-28-alex.ben...@linaro.org> --- tests/functional/test_mips64el_tuxrun.py | 8 1 file

[PATCH v3 21/29] tests/lcitool: bump to latest version of libvirt-ci

2025-01-07 Thread Alex Bennée
We will shortly need this to build our riscv64 cross container. However to keep the delta down just do the bump first. As ccache4 is now preferred for FreeBSD to get the latest version there is a little update in the FreeBSD metadata. Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé --

[PATCH v3 23/29] tests/lcitool: remove temp workaround for debian mips64el

2025-01-07 Thread Alex Bennée
From: Daniel P. Berrangé The workaround applied in commit c60473d29254b79d9437eface8b342e84663ba66 Author: Alex Bennée Date: Wed Oct 2 10:03:33 2024 +0200 testing: bump mips64el cross to bookworm and fix package list Is no longer required since the affected builds are now fixed.

[PATCH v3 26/29] tests/vm: allow interactive login as root

2025-01-07 Thread Alex Bennée
This is useful when debugging and you want to add packages to an image. Signed-off-by: Alex Bennée --- tests/vm/Makefile.include | 3 ++- tests/vm/basevm.py| 9 +++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include

[PATCH v3 25/29] tests/vm: partially un-tabify help output

2025-01-07 Thread Alex Bennée
While the make syntax itself uses tabs having a mixture of tabs and spaces in the vm-help output make no sense and confuses things lining up between terminal and editor. Fix that. Signed-off-by: Alex Bennée --- tests/vm/Makefile.include | 26 +- 1 file changed, 13 inserti

[PATCH v3 28/29] dockerfiles: Remove 'MAINTAINER' entry in debian-tricore-cross.docker

2025-01-07 Thread Alex Bennée
From: Philippe Mathieu-Daudé AMSAT closed its email service [*] so my personal email address is now defunct. Remove it to avoid bouncing emails. [*] https://web.archive.org/web/20240617194936/https://forum.amsat-dl.org/index.php?thread/4581-amsat-mail-alias-service-to-end-august-1-2024/ Signed

[PATCH v3 14/29] tests/functional: update the x86_64 tuxrun tests

2025-01-07 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-35-alex.ben...@linaro.org> --- tests/functional/test_x86_64_tuxrun.py | 8 1 file ch

[PATCH v3 29/29] MAINTAINERS: Remove myself from reviewers

2025-01-07 Thread Alex Bennée
From: Wainer dos Santos Moschetta The time I spent contributing to QEMU was great, but I've not been active for a long time now. So removing myself from the reviewers list of "Integration Testing with the Avocado framework" and "Build and test automation" subsystems. Signed-off-by: Wainer dos Sa

[PATCH v3 09/29] tests/functional: update the ppc64 tuxrun tests

2025-01-07 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-30-alex.ben...@linaro.org> --- tests/functional/test_ppc64_tuxrun.py | 16 1

[PATCH v3 27/29] pc-bios: ensure keymaps dependencies set vnc tests

2025-01-07 Thread Alex Bennée
I was seeing failures on vnc-display-test on FreeBSD: make vm-build-freebsd V=1 TARGET_LIST=aarch64-softmmu BUILD_TARGET=check-qtest QEMU_LOCAL=1 DEBUG=1 Leads to: qemu-system-aarch64: -vnc none: could not read keymap file: 'en-us' Broken pipe ../src/tests/qtest/libqtest.c:196: kill_qem

[PATCH v3 15/29] tests/functional/aarch64: add tests for FEAT_RME

2025-01-07 Thread Alex Bennée
From: Pierrick Bouvier This boot an OP-TEE environment, and launch a nested guest VM inside it using the Realms feature. We do it for virt and sbsa-ref platforms. Signed-off-by: Pierrick Bouvier Message-Id: <20241220165212.3653495-1-pierrick.bouv...@linaro.org> [AJB: tweak ordering of setup] Si

[PATCH v3 04/29] tests/functional: update the mips32 tuxrun tests

2025-01-07 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-25-alex.ben...@linaro.org> --- tests/functional/test_mips_tuxrun.py | 8 1 file chan

[PATCH v3 05/29] tests/functional: update the mips32el tuxrun tests

2025-01-07 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-26-alex.ben...@linaro.org> --- tests/functional/test_mipsel_tuxrun.py | 8 1 file ch

[PATCH v3 03/29] tests/functional: add a m68k tuxrun tests

2025-01-07 Thread Alex Bennée
We didn't have this before and as it exercises the m68k virt platform it seems worth adding. We don't wait for the shutdown because QEMU will auto-exit on the shutdown. Cc: Laurent Vivier Cc: Anders Roxell Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-2

[PATCH v3 10/29] tests/functional: update the riscv32 tuxrun tests

2025-01-07 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-31-alex.ben...@linaro.org> --- tests/functional/test_riscv32_tuxrun.py | 8 1 file c

[PATCH v3 13/29] tests/functional: update the sparc64 tuxrun tests

2025-01-07 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-34-alex.ben...@linaro.org> --- tests/functional/test_sparc64_tuxrun.py | 8 1 file c

[PATCH v3 08/29] tests/functional: update the ppc32 tuxrun tests

2025-01-07 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-29-alex.ben...@linaro.org> --- tests/functional/test_ppc_tuxrun.py | 8 1 file chang

[PATCH v3 16/29] tests/qtest: remove clock_steps from virtio tests

2025-01-07 Thread Alex Bennée
In the qtest environment time will not step forward if the system is paused (timers disabled) or we have no timer events to fire. As a result VirtIO events are responded to directly and we don't need to step time forward. We still do timeout processing to handle the fact the target QEMU may not be

[PATCH v3 12/29] tests/functional: update the s390x tuxrun tests

2025-01-07 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-33-alex.ben...@linaro.org> --- tests/functional/test_s390x_tuxrun.py | 8 1 file cha

[PATCH v3 00/29] testing/next: functional tests, qtest clocks, vm and keymaps (pre-PR)

2025-01-07 Thread Alex Bennée
There are number of parts to this series. The first is the updated images for all the guests that didn't make it into 9.2. There are also some new functional tests for virtio-gpu along with some other clean-ups. The qtest patches focus on ensuring things calling clock_step and clock_set actually

[PATCH v3 06/29] tests/functional: update the mips64 tuxrun tests

2025-01-07 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-27-alex.ben...@linaro.org> --- tests/functional/test_mips64_tuxrun.py | 8 1 file ch

[PATCH v3 02/29] tests/functional: update the i386 tuxrun tests

2025-01-07 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-23-alex.ben...@linaro.org> --- tests/functional/test_i386_tuxrun.py | 8 1 file chan

[PATCH v3 01/29] tests/functional: update the arm tuxrun tests

2025-01-07 Thread Alex Bennée
Now there are new up to date images available we should update to them. Cc: Anders Roxell Reviewed-by: Thomas Huth Tested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20241121165806.476008-21-alex.ben...@linaro.org> --- tests/functional/test_arm_tuxrun.py | 28 ++---

Re: [RFC PATCH 7/9] rust: qemu_api: add vmstate_struct and vmstate_cell

2025-01-07 Thread Paolo Bonzini
On Tue, Dec 31, 2024 at 1:23 AM Paolo Bonzini wrote: > > These are not type safe, but they're the best that can be done without > const_refs_static. > > Signed-off-by: Paolo Bonzini FWIW, I'll change these patch to support varrays in v2. Paolo > --- > rust/qemu-api/src/vmstate.rs | 34 +++

  1   2   3   4   >