[PATCH v2] dma: Fix function names in documentation

2024-10-11 Thread Akihiko Odaki
Ensure the function names match. Signed-off-by: Akihiko Odaki --- Changes in v2: - s/space/memory/ (Peter Maydell) - Covered more function names - Link to v1: https://lore.kernel.org/r/20241008-dma-v1-1-c439c0fc5...@daynix.com --- include/sysemu/dma.h | 11 +-- 1 file changed, 5 inserti

Re: [PATCH v6] hw/misc/aspeed_hace: Fix SG Accumulative hashing

2024-10-11 Thread Cédric Le Goater
+ Aspeed reviewers. Sorry about that. C. On 10/11/24 07:38, Cédric Le Goater wrote: From: Alejandro Zeise Make the Aspeed HACE module use the new qcrypto accumulative hashing functions when in scatter-gather accumulative mode. A hash context will maintain a "running-hash" as each scatter-gat

[PATCH] pc-bios: Add amd-sev-es to edk2 json

2024-10-11 Thread Pratik R. Sampat
With the default BIOS being compatible with amd-sev-es add the feature to the json to indicate it's support Signed-off-by: Pratik R. Sampat --- pc-bios/descriptors/60-edk2-x86_64.json | 1 + 1 file changed, 1 insertion(+) diff --git a/pc-bios/descriptors/60-edk2-x86_64.json b/pc-bios/descripto

[PATCH] meson.build: Remove ncurses workaround for OpenBSD

2024-10-11 Thread Brad Smith
meson.build: Remove ncurses workaround for OpenBSD OpenBSD 7.5 has upgraded to ncurses 6.4. Signed-off-by: Brad Smith --- meson.build | 2 +- ui/curses.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 4ea1984fc5..22e7629d81 100644 --- a/me

Re: [PATCH 16/17] Revert "hw/sh4/r2d: Realize IDE controller before accessing it"

2024-10-11 Thread Philippe Mathieu-Daudé
On 11/10/24 10:19, Thomas Huth wrote: This reverts commit 3c5f86a22686ef475a8259c0d8ee714f61c770c9. Changing the order here caused a regression with the "tuxrun" kernels (from https://storage.tuxboot.com/20230331/) - ATA commands fail with a "ata1: lost interrupt (Status 0x58)" message. Apparent

Re: [PATCH v3 07/11] hw/sh4/r2d: Realize IDE controller before accessing it

2024-10-11 Thread Philippe Mathieu-Daudé
On 11/10/24 05:23, Thomas Huth wrote: On 03/05/2024 23.34, Guenter Roeck wrote: Hi, On Thu, Feb 08, 2024 at 07:12:40PM +0100, Philippe Mathieu-Daudé wrote: We should not wire IRQs on unrealized device. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Yoshinori S

[PATCH 2/2] tpm_emulator: Read control channel response in 2 passes

2024-10-11 Thread Stefan Berger
Error responses from swtpm are always only 4 bytes long. Therefore, read the entire response in 2 passes and stop if the first 4 bytes indicate an error response with no subsequent bytes readable. Read the rest in a 2nd pass, if needed. This avoids getting stuck while waiting for too many bytes if

[PATCH 1/2] tpm: Use new ptm_cap_n structure for PTM_GET_CAPABILITY

2024-10-11 Thread Stefan Berger
Use the new ptm_cap_n structure for getting the PTM_GET_CAPABILITY response from swtpm. Previously only 17 bits could possibly have been set in ptm_cap (=uint64_t) in big endian order and those bits are now found in the 2nd 32bit word in the response in the caps field. This data structure makes it

[PATCH 0/2] tpm: Resolve potential blocking forever issue

2024-10-11 Thread Stefan Berger
In case swtpm was to return a control channel message with an error code it would only return 4 bytes. However, some of the commands expect a response with more bytes and QEMU would get stuck in qemu_chr_fe_read_all() waiting for bytes following the error code. Therefore, read the response in 2 pas

Re: [PATCH v3 00/11] hw: Strengthen SysBus & QBus API

2024-10-11 Thread Philippe Mathieu-Daudé
On 11/10/24 05:56, Paolo Bonzini wrote: On 2/8/24 19:12, Philippe Mathieu-Daudé wrote: Hi, This series ensure following is called *before* a device is realized: - qbus_new() - sysbus_init_mmio() - qdev_init_gpio_in_named_with_opaque() and these are called *after* it is: - sysbus_mmio_map() - s

Re: [PATCH] MAINTAINERS: A new maintainer for the qtests

2024-10-11 Thread Philippe Mathieu-Daudé
On 11/10/24 11:13, Thomas Huth wrote: Since I blundered into becoming the maintainer of the new functional test framework in QEMU (tests/functional/) recently, I need to drop some other duties - it's getting too much for me otherwise. Laurent is also quite busy with other projects nowadays, so I

Re: [RFC 1/1] vfio: support CXL device in VFIO stub

2024-10-11 Thread Alex Williamson
On Sat, 21 Sep 2024 00:14:40 -0700 Zhi Wang wrote: > To support CXL device passthrough, vfio-cxl-core is introduced. This > is the QEMU part. > > Get the CXL caps from the vfio-cxl-core. Trap and emulate the HDM > decoder registers. Map the HDM decdoers when the guest commits a HDM > decoder. I

Re: [PULL 10/23] linux-user: Remove unused handle_vm86_fault

2024-10-11 Thread Michael Tokarev
On 11.10.2024 19:02, Thomas Huth wrote: On 04/10/2024 18.03, Michael Tokarev wrote: From: "Dr. David Alan Gilbert" handle_vm86_fault has been unused since:    1ade5b2fed ("linux-user/i386: Split out maybe_handle_vm86_trap") Remove it, and it's local macros. FYI, looks like this broke compi

Re: [PATCH RFC 06/10] target/riscv: Define PMU event related structures

2024-10-11 Thread Atish Kumar Patra
On Thu, Oct 10, 2024 at 5:44 AM Alexei Filippov wrote: > > > > On 10.10.2024 02:09, Atish Patra wrote: > > Signed-off-by: Atish Patra > > --- > > target/riscv/cpu.h | 25 + > > 1 file changed, 25 insertions(+) > > > > diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h

Re: [PATCH RFC 05/10] target/riscv: Rename the PMU events

2024-10-11 Thread Atish Kumar Patra
On Thu, Oct 10, 2024 at 5:10 AM Alexei Filippov wrote: > > > > On 10.10.2024 02:09, Atish Patra wrote: > > The current PMU events are defined by SBI PMU > > specification. As there is no standard event encoding > > scheme, Virt machine chooses to use the SBI PMU encoding. > > A platform may choos

[QEMU RFC] hw/mem/cxl_type3: add guard to avoid event log overflow during a DC extent add/release request

2024-10-11 Thread nifan . cxl
From: Fan Ni One DC extent add/release request can take multiple DC extents. For each extent in the request, one DC event record will be generated and isnerted into the event log. All the event records for the request will be grouped with the More flag (see CXL spec r3.1, Table 8-168 and 8-170).

Re: [PATCH 1/3] scsi: fetch unit attention when creating the request

2024-10-11 Thread Michael Tokarev
On 09.10.2024 21:00, Michael Galaxy wrote: Thanks for your help. - Michael On 10/9/24 11:28, Paolo Bonzini wrote: Yes, it looks like an easy backport. Adding Michael Tokarev and qemu-stable. Paolo On Wed, Oct 9, 2024 at 6:03 PM Michael Galaxy wrote: Hi All, We have stumbled upon this bu

[PATCH v2] sched_attr: Do not define for glibc >= 2.41

2024-10-11 Thread Khem Raj
glibc 2.41+ has added [1] definitions for sched_setattr and sched_getattr functions and struct sched_attr. Therefore, it needs to be checked for here as well before defining sched_attr Define sched_attr conditionally on SCHED_ATTR_SIZE_VER0 Fixes builds with glibc/trunk [1] https://sourceware.

Re: [PATCH] target/i386: Use probe_access_full_mmu in ptw_translate

2024-10-11 Thread Richard Henderson
On 10/8/24 20:48, Philippe Mathieu-Daudé wrote: On 8/10/24 21:20, Richard Henderson wrote: The probe_access_full_mmu function was designed for this purpose, and does not report the memory operation event to plugins. Cc: qemu-sta...@nongnu.org Fixes: 6d03226b422 ("plugins: force slow path when p

Re: [PATCH v2 2/8] target/riscv: Implement Ssdbltrp sret, mret and mnret behavior

2024-10-11 Thread Ved Shanbhogue
Alistair Francis wrote: When the Ssdbltrp extension is enabled, SSTATUS.SDT field is cleared when executing sret. When executing mret/mnret, SSTATUS.SDT is cleared when returning to U, VS or VU and VSSTATUS.SDT is cleared when returning to VU from HS. I don't see mret being mentioned in the spe

Re: [PATCH v1] linux-user: Add option to run `execve`d programs through QEMU

2024-10-11 Thread Noah Goldstein
On Wed, Oct 2, 2024 at 11:42 AM Noah Goldstein wrote: > > On Wed, Oct 2, 2024 at 11:39 AM Ilya Leoshkevich wrote: > > > > On Wed, 2024-10-02 at 09:05 -0500, Noah Goldstein wrote: > > > On Wed, Oct 2, 2024 at 3:08 AM Ilya Leoshkevich > > > wrote: > > > > > > > > On Fri, 2024-08-30 at 15:36 -0700,

Re: [PATCH 19/23] accel/tcg: Always use IntervalTree for code lookups

2024-10-11 Thread Pierrick Bouvier
On 10/11/24 07:47, Richard Henderson wrote: On 10/9/24 17:35, Pierrick Bouvier wrote: @@ -1061,15 +1061,13 @@ static inline void tlb_set_compare(CPUTLBEntryFull *full, CPUTLBEntry *ent, vaddr address, int flags, MMUAcce

Re: [PATCH] migration: Remove interface query-migrationthreads

2024-10-11 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > This reverts two commits: > > 671326201dac8fe91222ba0045709f04a8ec3af4 > 1b1f4ab69c41279a45ccd0d3178e83471e6e4ec1 > > Meanwhile it adds an entry to removed-features.rst for the > query-migrationthreads QMP command. > > This patch originates from another pa

[PATCH 01/17] tests/functional: Add a base class for the TuxRun tests

2024-10-11 Thread Thomas Huth
Add a base class for the TuxRun tests, based on the code from tests/avocado/tuxrun_baselines.py (the test have to be put into separate file in the following commits, depending on the target architecture that gets tested). Signed-off-by: Thomas Huth --- tests/functional/qemu_test/tuxruntest.py |

[PATCH 10/17] tests/functional: Convert the Avocado x86_64 tuxrun test

2024-10-11 Thread Thomas Huth
Move the tests to a new file so that they can be run via qemu-system-x86_64 in the functional framework. Signed-off-by: Thomas Huth --- tests/avocado/tuxrun_baselines.py | 18 - tests/functional/meson.build | 1 + tests/functional/test_x86_64_tuxrun.py | 36 ++

Re: [PATCH 04/23] accel/tcg: Split out tlbfast_flush_range_locked

2024-10-11 Thread Pierrick Bouvier
On 10/9/24 18:20, Richard Henderson wrote: On 10/9/24 16:05, Pierrick Bouvier wrote: @@ -720,13 +728,10 @@ static void tlb_flush_range_locked(CPUState *cpu, int midx,   return;   } +    tlbfast_flush_range_locked(d, f, addr, len, mask); +   for (vaddr i = 0; i < len; i += TAR

[PATCH v14 09/10] hw/nvme: add reservation protocal command

2024-10-11 Thread Changqi Lu
Add reservation acquire, reservation register, reservation release and reservation report commands in the nvme device layer. By introducing these commands, this enables the nvme device to perform reservation-related tasks, including querying keys, querying reservation status, registering reservati

Re: [PATCH v6 0/5] target/riscv: Add Smrnmi support.

2024-10-11 Thread Daniel Henrique Barboza
Hi Tommy, Do you plan to send a new version of this work soon? This series is a prerequisite of "target/riscv: Add support for Smdbltrp and Ssdbltrp extensions" and we need this series merged first. We have minor comments from Clément and Alistair so hopefully it shouldn't be too much work. Th

Re: [PATCH v16 02/13] hw/ppc/spapr_pci: Do not create DT for disabled PCI device

2024-10-11 Thread Shivaprasad G Bhat
On 9/18/24 7:57 PM, Cédric Le Goater wrote: Hello, Adding :   Harsh for QEMU/PPC pseries machine,   Shivaprasad for KVM/PPC VFIO and IOMMU support. Could you please give us your feedback on these changes ? Thanks, C.  On 9/13/24 05:44, Akihiko Odaki wrote: Disabled means it is a disabl

[PATCH 08/17] tests/functional: Convert the Avocado riscv64 tuxrun tests

2024-10-11 Thread Thomas Huth
Move the tests to a new file so that they can be run via qemu-system-riscv64 in the functional framework. Signed-off-by: Thomas Huth --- tests/avocado/tuxrun_baselines.py | 31 tests/functional/meson.build| 4 +++ tests/functional/test_riscv64_tuxrun.py |

[PATCH 02/17] tests/functional: Convert the Avocado ppc64 tuxrun tests

2024-10-11 Thread Thomas Huth
Move the tests to a new file so that they can be run via qemu-system-ppc64 in the functional framework. Signed-off-by: Thomas Huth --- tests/avocado/tuxrun_baselines.py | 92 - tests/functional/test_ppc64_tuxrun.py | 110 ++ 2 files changed, 110 i

Re: [PATCH v2 4/7] target/i386/cpu: Avoid mixing signed and unsigned in property setters

2024-10-11 Thread Igor Mammedov
On Thu, 10 Oct 2024 17:01:41 +0200 Markus Armbruster wrote: > Properties "family", "model", and "stepping" are visited as signed > integers. They are backed by bits in CPUX86State member > @cpuid_version. The code to extract and insert these bits mixes > signed and unsigned. Not actually wrong

[PATCH 12/17] tests/functional: Convert the Avocado mipsel tuxrun test

2024-10-11 Thread Thomas Huth
Move the test into a new file so that it can be run via qemu-system-mipsel in the functional framework. Signed-off-by: Thomas Huth --- tests/avocado/tuxrun_baselines.py | 17 tests/functional/meson.build | 1 + tests/functional/test_mipsel_tuxrun.py | 36

Re: [PATCH] migration: Remove interface query-migrationthreads

2024-10-11 Thread Fabiano Rosas
Peter Xu writes: > This reverts two commits: > > 671326201dac8fe91222ba0045709f04a8ec3af4 > 1b1f4ab69c41279a45ccd0d3178e83471e6e4ec1 > > Meanwhile it adds an entry to removed-features.rst for the > query-migrationthreads QMP command. > > This patch originates from another patchset [1] that wanted

Re: [PATCH] meson: drop --enable-avx* options

2024-10-11 Thread Richard Henderson
On 10/10/24 02:24, Daniel P. Berrangé wrote: On Thu, Oct 10, 2024 at 11:13:22AM +0200, Paolo Bonzini wrote: Just detect compiler support and always enable the optimizations if it is avilable; warn if the user did request AVX2/AVX512 use via -Dx86_version= but the intrinsics are not available. S

[PATCH 07/17] tests/functional: Convert the Avocado riscv32 tuxrun tests

2024-10-11 Thread Thomas Huth
Move the tests to a new file so that they can be run via qemu-system-riscv32 in the functional framework. Signed-off-by: Thomas Huth --- tests/avocado/tuxrun_baselines.py | 31 tests/functional/meson.build| 4 +++ tests/functional/test_riscv32_tuxrun.py |

[PATCH 15/17] tests/functional: Convert the Avocado ppc32 tuxrun test

2024-10-11 Thread Thomas Huth
Move the test into a new file so that it can be run via qemu-system-ppc in the functional framework. Signed-off-by: Thomas Huth --- tests/avocado/tuxrun_baselines.py | 16 - tests/functional/meson.build| 1 + tests/functional/test_ppc_tuxrun.py | 35 +++

[PATCH v14 02/10] block/raw: add persistent reservation in/out driver

2024-10-11 Thread Changqi Lu
Add persistent reservation in/out operations for raw driver. The following methods are implemented: bdrv_co_pr_read_keys, bdrv_co_pr_read_reservation, bdrv_co_pr_register, bdrv_co_pr_reserve, bdrv_co_pr_release, bdrv_co_pr_clear and bdrv_co_pr_preempt. Signed-off-by: Changqi Lu Signed-off-by: zhe

Re: [PATCH] migration: Put thread names together with macros

2024-10-11 Thread Fabiano Rosas
Peter Xu writes: > Keep migration thread names together, so it's easier to see a list of all > possible migration threads. > > Still two functional changes below besides the macro defintions: > > - There's one dirty rate thread that we overlooked before, now we add > that too and name it as "

[PATCH v14 01/10] block: add persistent reservation in/out api

2024-10-11 Thread Changqi Lu
Add persistent reservation in/out operations at the block level. The following operations are included: - read_keys:retrieves the list of registered keys. - read_reservation: retrieves the current reservation status. - register: registers a new reservation key. - reserve:

[PATCH 09/17] tests/functional: Convert the Avocado i386 tuxrun test

2024-10-11 Thread Thomas Huth
Move the tests to a new file so that they can be run via qemu-system-i386 in the functional framework. Signed-off-by: Thomas Huth --- tests/avocado/tuxrun_baselines.py| 16 - tests/functional/meson.build | 4 tests/functional/test_i386_tuxrun.py | 35 +++

[PATCH 03/17] tests/functional: Convert the Avocado aarch64 tuxrun tests

2024-10-11 Thread Thomas Huth
Move the tests to a new file so that they can be run via qemu-system-aarch64 in the functional framework. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + tests/avocado/tuxrun_baselines.py | 31 --- tests/functional/meson.build| 2 + t

Re: [PATCH] accel/kvm: check for KVM_CAP_MEMORY_ATTRIBUTES on vm

2024-10-11 Thread Gupta, Pankaj
On 10/11/2024 10:59 AM, Paolo Bonzini wrote: The exact set of available memory attributes can vary by VM. In the future it might vary depending on enabled capabilities, too. Query the extension on the VM level instead of on the KVM level, and only after architecture-specific initialization. In

[PATCH 00/17] Convert the Avocado tuxrun tests into new functional tests

2024-10-11 Thread Thomas Huth
This patch series converts the tests/avocado/tuxrun_baselines.py to the new functional test framework. While converting the sh4 test, I noticed that the Avocado test was completely broken, so I included a fix (revert) for that problem in this series, too. Thomas Huth (17): tests/functional: Add

Re: [PATCH v17 00/13] Support blob memory and venus on qemu

2024-10-11 Thread Dmitry Osipenko
On 10/10/24 03:59, Akihiro Suda wrote: >> And I think this series is ready to merge once the tree re-opens. > > Hi, is there any remaining blocker toward merging the patch set? There is no blocker. Patches will be merged once Michael will do it. Michael, please feel free to apply the patches to

Re: [PATCH v2 2/3] docs: avoid footnotes consisting of just URLs

2024-10-11 Thread Peter Maydell
On Fri, 11 Oct 2024 at 12:13, Paolo Bonzini wrote: > > Replace the footnotes with inline links whenever the footnote text > consists of nothing but the URL. While at it, make the link texts > consistent in the surrounding areas, for example avoiding usage of > "here" for the link's text. > > In t

Re: [PATCH] qapi, machine-qmp-cmds.c: query-accelerator support

2024-10-11 Thread Daniel Henrique Barboza
On 10/7/24 6:53 AM, Markus Armbruster wrote: Daniel P. Berrangé writes: Markus: QAPI design Qs for you at the bottom On Wed, Sep 25, 2024 at 10:19:33AM -0300, Daniel Henrique Barboza wrote: On 9/19/24 9:22 AM, Daniel P. Berrangé wrote: On Thu, Sep 19, 2024 at 08:20:56AM -0300, Daniel H

[PATCH v14 10/10] block/iscsi: add persistent reservation in/out driver

2024-10-11 Thread Changqi Lu
Add persistent reservation in/out operations for iscsi driver. The following methods are implemented: bdrv_co_pr_read_keys, bdrv_co_pr_read_reservation, bdrv_co_pr_register, bdrv_co_pr_reserve, bdrv_co_pr_release, bdrv_co_pr_clear and bdrv_co_pr_preempt. Signed-off-by: Changqi Lu Signed-off-by: z

Re: [PATCH v2 5/7] target/i386/cpu: Improve errors for out of bounds property values

2024-10-11 Thread Igor Mammedov
On Thu, 10 Oct 2024 17:01:42 +0200 Markus Armbruster wrote: > The error message for a "stepping" value that is out of bounds is a > bit odd: > > $ qemu-system-x86_64 -cpu qemu64,stepping=16 > qemu-system-x86_64: can't apply global qemu64-x86_64-cpu.stepping=16: > Property .stepping does

[PULL v3 06/18] meson.build: add HAVE_GLIB_WITH_ALIGNED_ALLOC flag

2024-10-11 Thread Paolo Bonzini
From: Manos Pitsidianakis Rust crates, introduced from the next commit onwards, can optionally use the glib allocator API and need to know whether g_aligned_alloc etc are available. This commit adds a define in config_host_data that depends on glib version >= 2.72. Reviewed-by: Alex Bennée Sig

[PATCH v14 08/10] hw/nvme: enable ONCS and rescap function

2024-10-11 Thread Changqi Lu
This commit enables ONCS to support the reservation function at the controller level. Also enables rescap function in the namespace by detecting the supported reservation function in the backend driver. Reviewed-by: Klaus Jensen Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi Reviewed-by: S

[PATCH 14/17] tests/functional: Convert the Avocado mips64el tuxrun test

2024-10-11 Thread Thomas Huth
Move the test into a new file so that it can be run via qemu-system-mips64el in the functional framework. Signed-off-by: Thomas Huth --- tests/avocado/tuxrun_baselines.py| 16 --- tests/functional/meson.build | 1 + tests/functional/test_mips64el_tuxrun.py | 35 +

Re: [PULL 00/17] Crypto fixes patches

2024-10-11 Thread Peter Maydell
On Thu, 10 Oct 2024 at 17:24, Daniel P. Berrangé wrote: > > The following changes since commit 838fc0a8769d7cc6edfe50451ba4e3368395f5c1: > > Merge tag 'chr-pull-request' of https://gitlab.com/marcandre.lureau/qemu > into staging (2024-10-09 15:06:56 +0100) > > are available in the Git repositor

Re: [PATCH 14/23] accel/tcg: Replace victim_tlb_hit with tlbtree_hit

2024-10-11 Thread Pierrick Bouvier
On 10/10/24 12:29, Richard Henderson wrote: On 10/9/24 17:10, Pierrick Bouvier wrote: +static bool tlbtree_hit(CPUState *cpu, int mmu_idx, +    MMUAccessType access_type, vaddr addr)   { -    size_t vidx; +    CPUTLBDesc *desc = &cpu->neg.tlb.d[mmu_idx]; +    CPUTLBDescFas

Re: [PATCH v16 03/13] hw/ppc/spapr_pci: Do not reject VFs created after a PF

2024-10-11 Thread Shivaprasad G Bhat
On 9/18/24 7:57 PM, Cédric Le Goater wrote: Adding :   Harsh for QEMU/PPC pseries machine,   Shivaprasad for KVM/PPC VFIO and IOMMU support. Thanks, C. On 9/13/24 05:44, Akihiko Odaki wrote: A PF may automatically create VFs and the PF may be function 0. Signed-off-by: Akihiko Odaki ---  

[PATCH 11/17] tests/functional: Convert the Avocado mips tuxrun test

2024-10-11 Thread Thomas Huth
Move the test into a new file so that it can be run via qemu-system-mips in the functional framework. Signed-off-by: Thomas Huth --- tests/avocado/tuxrun_baselines.py| 18 -- tests/functional/meson.build | 1 + tests/functional/test_mips_tuxrun.py | 36 ++

[PATCH v14 00/10] Support persistent reservation operations

2024-10-11 Thread Changqi Lu
Patch v14 has been modified, thanks to Stefan for the code review. v13->v14: - Fix some protocol and spelling related issues at hw/nvme/ctrl.c. v12->v13: - Fix byte swaps at hw/nvme/ctrl.c. v11->v12: - Fixed endian conversion during command parsing; - Add the maximum number of keys, currently li

[PATCH v14 06/10] block/nvme: add reservation command protocol constants

2024-10-11 Thread Changqi Lu
Add constants for the NVMe persistent command protocol. The constants include the reservation command opcode and reservation type values defined in section 7 of the NVMe 2.0 specification. Reviewed-by: Stefan Hajnoczi Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi --- include/block/nvme.h

[PATCH v14 04/10] scsi/util: add helper functions for persistent reservation types conversion

2024-10-11 Thread Changqi Lu
This commit introduces two helper functions that facilitate the conversion between the persistent reservation types used in the SCSI protocol and those used in the block layer. Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi Reviewed-by: Stefan Hajnoczi --- include/scsi/utils.h | 8 +

[PULL v3 18/18] docs: use consistent markup for footnotes

2024-10-11 Thread Paolo Bonzini
Unfortunately, the definition of the footnote syntax requires the author to use the awkward escaped space "\ " in the really common case of "footnote marker at end of word or sentence"; and in fact the rST documentation's examples of footnote syntax contain only artificial examples that do *not* us

[PATCH v14 07/10] hw/nvme: add helper functions for converting reservation types

2024-10-11 Thread Changqi Lu
This commit introduces two helper functions that facilitate the conversion between the reservation types used in the NVME protocol and those used in the block layer. Reviewed-by: Klaus Jensen Reviewed-by: Stefan Hajnoczi Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi --- hw/nvme/nvme.h |

Re: [PATCH v6 08/12] migration/multifd: Add new migration option for multifd DSA offloading.

2024-10-11 Thread Dr. David Alan Gilbert
* Yichen Wang (yichen.w...@bytedance.com) wrote: > From: Hao Xiang Please split the cpuid stuff out into a separate patch; it feels like it should be in some x86 specific place. > Intel DSA offloading is an optional feature that turns on if > proper hardware and software stack is available. To t

Re: [PATCH v2] scripts/archive-source: find directory name for subprojects

2024-10-11 Thread Peter Maydell
On Fri, 11 Oct 2024 at 09:35, Paolo Bonzini wrote: > > Rust subprojects have the semantic version (followed by -rs) in the subproject > name, but the full version (without -rs) is used by crates.io for the root > directory of the tarball. Teach scripts/archive-source.sh to look for the > root dir

Re: [PATCH v2 0/3] docs: fix and cleanup footnotes

2024-10-11 Thread Peter Maydell
On Fri, 11 Oct 2024 at 12:12, Paolo Bonzini wrote: > > Sphinx 8.1.0 got a lot better at detecting unreferenced footnotes, and > we have three of them---which causes the build to fail when the latest > version of sphinx is installed from Pip. In particular we hit this on the macos14 CI job now: h

[PULL v3 12/18] meson: define qemu_isa_flags

2024-10-11 Thread Paolo Bonzini
Create a separate variable for compiler flags that enable specific instruction set extensions, so that they can be used with cc.compiles/cc.links. Note that -mfpmath=sse is a code generation option but it does not enable new instructions, therefore I did not make it part of qemu_isa_flags. Sugges

[PATCH] MAINTAINERS: A new maintainer for the qtests

2024-10-11 Thread Thomas Huth
Since I blundered into becoming the maintainer of the new functional test framework in QEMU (tests/functional/) recently, I need to drop some other duties - it's getting too much for me otherwise. Laurent is also quite busy with other projects nowadays, so I looked around for help. Fabiano did qui

[PATCH v14 03/10] scsi/constant: add persistent reservation in/out protocol constants

2024-10-11 Thread Changqi Lu
Add constants for the persistent reservation in/out protocol in the scsi/constant module. The constants include the persistent reservation command, type, and scope values defined in sections 6.13 and 6.14 of the SCSI Primary Commands-4 (SPC-4) specification. Signed-off-by: Changqi Lu Signed-off-b

[PATCH v14 05/10] hw/scsi: add persistent reservation in/out api for scsi device

2024-10-11 Thread Changqi Lu
Add persistent reservation in/out operations in the SCSI device layer. By introducing the persistent reservation in/out api, this enables the SCSI device to perform reservation-related tasks, including querying keys, querying reservation status, registering reservation keys, initiating and releasin

Re: [PATCH] sched_attr: Do not define for glibc >= 2.41

2024-10-11 Thread Paolo Bonzini
On Fri, Oct 11, 2024 at 11:15 AM Laurent Vivier wrote: > > Le 11/10/2024 à 11:08, Paolo Bonzini a écrit : > > On 10/11/24 07:48, Khem Raj wrote: > >> glibc 2.41+ has added [1] definitions for sched_setattr and sched_getattr > >> functions > >> and struct sched_attr. Therefore, it needs to be chec

[PATCH 16/17] Revert "hw/sh4/r2d: Realize IDE controller before accessing it"

2024-10-11 Thread Thomas Huth
This reverts commit 3c5f86a22686ef475a8259c0d8ee714f61c770c9. Changing the order here caused a regression with the "tuxrun" kernels (from https://storage.tuxboot.com/20230331/) - ATA commands fail with a "ata1: lost interrupt (Status 0x58)" message. Apparently we need to wire the interrupt here fi

[PATCH 04/17] tests/functional: Convert the Avocado sparc64 tuxrun test

2024-10-11 Thread Thomas Huth
Move the test to a new file so that it can be run via qemu-system-sparc64 in the functional framework. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + tests/avocado/tuxrun_baselines.py | 16 tests/functional/meson.build| 1 + tests/f

Re: [RFC V2 PATCH 02/11] acpi: Implement control method sleep button

2024-10-11 Thread Igor Mammedov
On Tue, 8 Oct 2024 11:22:33 -0400 Annie Li wrote: > On 10/7/2024 8:59 AM, Igor Mammedov wrote: > > On Fri, 27 Sep 2024 14:38:57 -0400 > > Annie Li wrote: > > > >> The control method sleep button is added, as well as its GPE event > >> handler. > >> > >> Co-developed-by: Miguel Luis > >> Signed-

Re: [PATCH 3/4] target/riscv/kvm: add kvm-aia bools props

2024-10-11 Thread Daniel Henrique Barboza
On 10/10/24 10:57 PM, Alistair Francis wrote: On Tue, Sep 24, 2024 at 10:46 PM Daniel Henrique Barboza wrote: Boolean properties are preferrable in comparision to string properties since they don't require a string parsing. Add three bools that represents the available kvm-aia mode: riscv-

Re: [PATCH v6 00/12] Use Intel DSA accelerator to offload zero page checking in multifd live migration.

2024-10-11 Thread Fabiano Rosas
Yichen Wang writes: > v6 > * Rebase on top of 838fc0a8769d7cc6edfe50451ba4e3368395f5c1; > * Refactor code to have clean history on all commits; > * Add comments on DSA specific defines about how the value is picked; > * Address all comments from v5 reviews about api defines, questions, etc.; > >

[PATCH 13/17] tests/functional: Convert the Avocado mips64 tuxrun test

2024-10-11 Thread Thomas Huth
Move the test into a new file so that it can be run via qemu-system-mips64 in the functional framework. Signed-off-by: Thomas Huth --- tests/avocado/tuxrun_baselines.py | 17 - tests/functional/meson.build | 4 +++ tests/functional/test_mips64_tuxrun.py | 35 +

Re: [PATCH v2 00/17] Multifd 🔀 device state transfer support with VFIO consumer

2024-10-11 Thread Cédric Le Goater
Hello Maciej, On 8/27/24 19:54, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" This is an updated v2 patch series of the v1 series located here: https://lore.kernel.org/qemu-devel/cover.1718717584.git.maciej.szmigi...@oracle.com/ Changes from v1: * Extended the QEMU thread-pool with n

[PATCH 06/17] tests/functional: Convert the Avocado arm tuxrun tests

2024-10-11 Thread Thomas Huth
Move the tests to a new file so that they can be run via qemu-system-arm in the functional framework. Signed-off-by: Thomas Huth --- tests/avocado/tuxrun_baselines.py | 56 --- tests/functional/meson.build| 2 + tests/functional/test_arm_tuxrun.py | 70

Re: [PATCH 19/23] accel/tcg: Always use IntervalTree for code lookups

2024-10-11 Thread Richard Henderson
On 10/9/24 17:35, Pierrick Bouvier wrote: @@ -1061,15 +1061,13 @@ static inline void tlb_set_compare(CPUTLBEntryFull *full, CPUTLBEntry *ent, vaddr address, int flags, MMUAccessType access_type, bool enable)   { -    if (e

Re: [PATCH v3 06/20] accel/tcg: Use the alignment test in tlb_fill_align

2024-10-11 Thread Peter Maydell
On Fri, 11 Oct 2024 at 16:22, Richard Henderson wrote: > > On 10/10/24 03:44, Peter Maydell wrote: > > On Wed, 9 Oct 2024 at 01:05, Richard Henderson > > wrote: > >> > >> When we have a tlb miss, defer the alignment check to > >> the new tlb_fill_align hook. Move the existing alignment > >> chec

[PULL v3 15/18] gitlab-ci: add Rust-enabled CI job

2024-10-11 Thread Paolo Bonzini
Add a job using --enable-rust, to ensure that the toolchain is installed correctly by the Dockerfile and that QEMU builds with Rust enabled on at least one platform. Suggested-by: Daniel P. Berrangé Reviewed-by: Daniel P. Berrangé Acked-by: Alex Bennée Signed-off-by: Paolo Bonzini --- .gitlab

[PULL v3 08/18] scripts/archive-source: find directory name for subprojects

2024-10-11 Thread Paolo Bonzini
Rust subprojects have the semantic version (followed by -rs) in the subproject name, but the full version (without -rs) is used by crates.io for the root directory of the tarball. Teach scripts/archive-source.sh to look for the root directory name in wrap files. Signed-off-by: Paolo Bonzini ---

[PULL v3 03/18] configure, meson: detect Rust toolchain

2024-10-11 Thread Paolo Bonzini
Include the correct path and arguments to rustc in the native and cross files (native compilation is needed for procedural macros). Based on the host architecture and OS, the compiler and optionally the argument to --cpu, the Rust target triple can be detected automatically for either a native or

[PATCH 17/17] tests/functional: Convert the Avocado sh4 tuxrun test

2024-10-11 Thread Thomas Huth
Move the test into a new file so that it can be run via qemu-system-sh4 in the functional framework. Since this was the last test in tests/avocado/tuxrun_baselines.py, we can now delete that file completely. Signed-off-by: Thomas Huth --- tests/avocado/tuxrun_baselines.py | 228 --

[PULL v3 14/18] dockerfiles: add a Dockerfile using a nightly Rust toolchain

2024-10-11 Thread Paolo Bonzini
This will be useful in order to test QEMU's Rust code with nightly clippy. It can also be used to check that the code builds, until the minimum supported Rust version is lowered enough to allow enabling Rust in other Dockerfiles too. Use a separate container, instead of the Fedora one, to avoid t

Re: [PATCH v6 00/12] Use Intel DSA accelerator to offload zero page checking in multifd live migration.

2024-10-11 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > The doc update is still missing under docs/, we may need that for a final > merge. > > Are you using this in production? How it performs in real life? What is > the major issue to solve for you? Is it "zero detect eats cpu too much", > or "migration too

[PULL v3 07/18] rust: add crate to expose bindings and interfaces

2024-10-11 Thread Paolo Bonzini
From: Manos Pitsidianakis Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and provides some declaration macros for symbols visible to the rest of QEMU. Co-authored-by: Junjie Mao Co-authored-by: Paolo Bonzini Signed-off-by: Junjie Mao Signed-off-by: Paolo Bonzini Signed-

[PATCH] migration: Remove interface query-migrationthreads

2024-10-11 Thread Peter Xu
This reverts two commits: 671326201dac8fe91222ba0045709f04a8ec3af4 1b1f4ab69c41279a45ccd0d3178e83471e6e4ec1 Meanwhile it adds an entry to removed-features.rst for the query-migrationthreads QMP command. This patch originates from another patchset [1] that wanted to cleanup the interface and add

[PULL v3 10/18] rust: add PL011 device model

2024-10-11 Thread Paolo Bonzini
This commit adds a re-implementation of hw/char/pl011.c in Rust. How to build: 1. Configure a QEMU build with: --enable-system --target-list=aarch64-softmmu --enable-rust 2. Launching a VM with qemu-system-aarch64 should use the Rust version of the pl011 device Co-authored-by: Junjie Mao

Re: [PATCH] MAINTAINERS: A new maintainer for the qtests

2024-10-11 Thread Laurent Vivier
On 11/10/2024 16:13, Thomas Huth wrote: Since I blundered into becoming the maintainer of the new functional test framework in QEMU (tests/functional/) recently, I need to drop some other duties - it's getting too much for me otherwise. Laurent is also quite busy with other projects nowadays, so

[PATCH 05/17] tests/functional: Convert the Avocado s390x tuxrun test

2024-10-11 Thread Thomas Huth
Move the test to a new file so that it can be run via qemu-system-s390x in the functional framework. Signed-off-by: Thomas Huth --- MAINTAINERS | 2 +- tests/avocado/tuxrun_baselines.py | 17 -- tests/functional/test_s390x_tuxrun.py | 34 +++

[PULL v3 02/18] build-sys: Add rust feature option

2024-10-11 Thread Paolo Bonzini
From: Manos Pitsidianakis Add rust feature in meson.build, configure, to prepare for adding Rust code in the followup commits. Signed-off-by: Manos Pitsidianakis Reviewed-by: Alex Bennée Link: https://lore.kernel.org/r/14642d80fbccbc60f7aa78b449a7deb5e2784ed9.1727961605.git.manos.pitsidiana..

Re: [PATCH v3 06/20] accel/tcg: Use the alignment test in tlb_fill_align

2024-10-11 Thread Richard Henderson
On 10/10/24 03:44, Peter Maydell wrote: On Wed, 9 Oct 2024 at 01:05, Richard Henderson wrote: When we have a tlb miss, defer the alignment check to the new tlb_fill_align hook. Move the existing alignment check so that we only perform it with a tlb hit. Signed-off-by: Richard Henderson

Re: [PATCH v2 0/3] docs: fix and cleanup footnotes

2024-10-11 Thread Paolo Bonzini
On Fri, Oct 11, 2024 at 2:27 PM Peter Maydell wrote: > > On Fri, 11 Oct 2024 at 12:12, Paolo Bonzini wrote: > > > > Sphinx 8.1.0 got a lot better at detecting unreferenced footnotes, and > > we have three of them---which causes the build to fail when the latest > > version of sphinx is installed

[PULL v3 04/18] rust: add bindgen step as a meson dependency

2024-10-11 Thread Paolo Bonzini
From: Manos Pitsidianakis Add bindings_rs target for generating rust bindings to target-independent qemu C APIs. The bindings need be created before any rust crate that uses them is compiled. The bindings.rs file will end up in BUILDDIR/bindings.rs and have the same name as a target: ninja b

[PULL v3 09/18] rust: add utility procedural macro crate

2024-10-11 Thread Paolo Bonzini
From: Manos Pitsidianakis This commit adds a helper crate library, qemu-api-macros for derive (and other procedural) macros to be used along qemu-api. It needs to be a separate library because in Rust, procedural macros, or macros that can generate arbitrary code, need to be special separate com

[PATCH] linux-user/vm86: Fix compilation with Clang

2024-10-11 Thread Thomas Huth
Since commit 95b9c27c81 ("linux-user: Remove unused handle_vm86_fault") a bunch of other "static inline" function are now unused, too. Clang warns about such unused "static inline" functions in .c files, so the build currently breaks when compiling with "--enable-werror". Remove the unused function

[PULL v3 13/18] meson: ensure -mcx16 is passed when detecting ATOMIC128

2024-10-11 Thread Paolo Bonzini
Moving -mcx16 out of CPU_CFLAGS caused the detection of ATOMIC128 to fail, because flags have to be specified by hand in cc.compiles and cc.links invocations (why oh why??). Ensure that these tests enable all the instruction set extensions that will be used to build the emulators. Fixes: c2bf2ccb

[PULL v3 16/18] docs: fix invalid footnote syntax

2024-10-11 Thread Paolo Bonzini
All footnotes must come after a separator in reStructuredText. Fix the two files in which this does not happen. This mistake causes the link to be rendered literally: ...from the venv itself[#distlib]_. If no... and is caught by Sphinx 8.1.0 as an unreferenced footnote. Reviewed-by: Peter M

Re: [PATCH] MAINTAINERS: A new maintainer for the qtests

2024-10-11 Thread Fabiano Rosas
Thomas Huth writes: > Since I blundered into becoming the maintainer of the new functional > test framework in QEMU (tests/functional/) recently, I need to drop > some other duties - it's getting too much for me otherwise. Laurent > is also quite busy with other projects nowadays, so I looked ar

Re: [PATCH v2 5/7] target/i386/cpu: Improve errors for out of bounds property values

2024-10-11 Thread Philippe Mathieu-Daudé
On 10/10/24 16:25, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 10/10/24 12:01, Markus Armbruster wrote: The error message for a "stepping" value that is out of bounds is a bit odd: $ qemu-system-x86_64 -cpu qemu64,stepping=16 qemu-system-x86_64: can't apply global q

  1   2   >