On Fri, Oct 11, 2024 at 11:15 AM Laurent Vivier <laur...@vivier.eu> wrote: > > Le 11/10/2024 à 11:08, Paolo Bonzini a écrit : > > On 10/11/24 07:48, Khem Raj wrote: > >> glibc 2.41+ has added [1] definitions for sched_setattr and sched_getattr > >> functions > >> and struct sched_attr. Therefore, it needs to be checked for here as well > >> before > >> defining sched_attr > >> > >> Fixes builds with glibc/trunk > >> > >> [1] https://sourceware.org/git/? > >> p=glibc.git;a=commitdiff;h=21571ca0d70302909cf72707b2a7736cf12190a0;hp=298bc488fdc047da37482f4003023cb9adef78f8 > >> > >> Signed-off-by: Khem Raj <raj.k...@gmail.com> > >> Cc: Laurent Vivier <laur...@vivier.eu> (m > > > > Hi, I think it would be better to test in meson.build (with cc.has_type), > > as is already done in > > several other places in linux-user/syscall.c. > > We can also test if SCHED_ATTR_SIZE_VER0 exists as it is defined when the > structure is defined..
Yes, that works too. Paolo
