Re: [RFC v3 3/3] vhost: Allocate memory for packed vring

2024-08-11 Thread Eugenio Perez Martin
On Sun, Aug 11, 2024 at 7:20 PM Sahil wrote: > > Hi, > > On Wednesday, August 7, 2024 9:52:10 PM GMT+5:30 Eugenio Perez Martin wrote: > > On Fri, Aug 2, 2024 at 1:22 PM Sahil Siddiq wrote: > > > [...] > > > @@ -726,17 +738,30 @@ void vhost_svq_start(VhostShadowVirtqueue *svq, > > > VirtIODevice

Re: [PATCH 08/14] tests/avocado: remove tcg_plugins virt_mem_icount test

2024-08-11 Thread Thomas Huth
On 29/07/2024 16.44, Alex Bennée wrote: Since 4f8d886085 (tests/plugin/mem: migrate to new per_vcpu API) this test was skipping due to not being able to run callback and inline memory instrumentation at the same time. However b480f7a621 (tests/plugin: add test plugin for inline operations) tests

Re: [PATCH] qapi: Document QCryptodevBackendServiceType

2024-08-11 Thread Philippe Mathieu-Daudé
On 12/8/24 03:42, zhenwei pi wrote: QCryptodevBackendServiceType was introduced by bc304a6442e (cryptodev: Introduce server type in QAPI). However there is a lack of member description. Thanks to Markus for pointing out this. Signed-off-by: zhenwei pi --- qapi/cryptodev.json | 10 ++

Re: [PATCH 3/3] target/i386: Assert MMX and XMM registers in range

2024-08-11 Thread Philippe Mathieu-Daudé
On 12/8/24 04:58, Richard Henderson wrote: The mmx assert would fire without the fix for #2495. Signed-off-by: Richard Henderson --- target/i386/tcg/emit.c.inc | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH-for-9.1] target/mips: Fix execution mode in page_table_walk_refill()

2024-08-11 Thread Philippe Mathieu-Daudé
On 12/8/24 02:48, Richard Henderson wrote: On 8/12/24 02:54, Philippe Mathieu-Daudé wrote: When refactoring page_table_walk_refill() in commit 4e999bf419 we replaced the execution mode and forced it to kernel mode. Restore the previous behavior to also get supervisor / user modes. Reported-by:

Re: [PATCH v2 1/4] target/m68k: Introduce M68K_FEATURE_FPU_PACKED_DECIMAL

2024-08-11 Thread Philippe Mathieu-Daudé
On 12/8/24 02:44, Richard Henderson wrote: Set for 68020 and 68030, but does nothing so far. Signed-off-by: Richard Henderson --- target/m68k/cpu.h | 2 ++ target/m68k/cpu.c | 2 ++ 2 files changed, 4 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 4/4] tests/tcg/m68k: Add packed decimal tests

2024-08-11 Thread Philippe Mathieu-Daudé
On 12/8/24 02:44, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tests/tcg/m68k/packeddecimal-1.c | 41 +++ tests/tcg/m68k/packeddecimal-2.c | 42 tests/tcg/m68k/Makefile.target | 4 ++- 3 files changed, 86 inser

Re: [PATCH v2 2/4] target/m68k: Implement packed decimal real loads

2024-08-11 Thread Philippe Mathieu-Daudé
On 12/8/24 02:44, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/m68k/helper.h |2 + target/m68k/fpu_helper.c | 89 + target/m68k/gen-floatx80-pow10.c | 30 + target/m68k/translate.c | 22 +- target/m68k/floatx80-pow10.c.inc | 49

Re: [PATCH 2/3] target/i386: Use unit not type in decode_modrm

2024-08-11 Thread Philippe Mathieu-Daudé
On 12/8/24 04:58, Richard Henderson wrote: Rather that enumerating the types that can produce MMX operands, examine the unit. No functional change. Signed-off-by: Richard Henderson --- target/i386/tcg/decode-new.c.inc | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-

回复: [PATCH RFC V3 02/29] cpu-common: Add common CPU utility for possible vCPUs

2024-08-11 Thread liu ping
unsubscribe 发件人: qemu-devel-bounces+liuping24=outlook@nongnu.org 代表 Gavin Shan 发送时间: 2024年8月11日 21:59 收件人: Salil Mehta ; qemu-devel@nongnu.org ; qemu-...@nongnu.org ; m...@redhat.com 抄送: m...@kernel.org ; jean-phili...@linaro.org ; jonathan.came...@huawe

Re: [PATCH RFC V3 04/29] hw/arm/virt: Move setting of common CPU properties in a function

2024-08-11 Thread Gavin Shan
On 6/14/24 9:36 AM, Salil Mehta wrote: Factor out CPU properties code common for {hot,cold}-plugged CPUs. This allows code reuse. Signed-off-by: Salil Mehta --- hw/arm/virt.c | 261 -- include/hw/arm/virt.h | 4 + 2 files changed, 182 insert

Re: [PATCH RFC V3 03/29] hw/arm/virt: Limit number of possible vCPUs for unsupported Accel or GIC Type

2024-08-11 Thread Gavin Shan
On 6/14/24 9:36 AM, Salil Mehta wrote: If Virtual CPU Hotplug support does not exist on a particular Accel platform or ARM GIC version, we should limit the possible vCPUs to those available during boot time (i.e SMP CPUs) and explicitly disable Virtual CPU Hotplug support. Signed-off-by: Salil M

Re: [PATCH RFC V3 02/29] cpu-common: Add common CPU utility for possible vCPUs

2024-08-11 Thread Gavin Shan
On 6/14/24 9:36 AM, Salil Mehta wrote: This patch adds various utility functions that may be required to fetch or check the state of possible vCPUs. It also introduces the concept of *disabled* vCPUs, which are part of the *possible* vCPUs but are not enabled. This state will be used during machi

Re: [PATCH] vhost-user: add NEED_REPLY flag

2024-08-11 Thread 陆知行
Hi, can someone review this patch? I find requests which call vhost_user_get_u64 does not set NEED_REPLY flag luzhixing12345 于2024年8月4日周日 23:50写道: > Front-end message requests which need reply should set NEED_REPLY_MASK > in flag, and response from slave need clear NEED_REPLY_MASK flag. > > ---

Re: [PATCH RFC V3 01/29] arm/virt,target/arm: Add new ARMCPU {socket,cluster,core,thread}-id property

2024-08-11 Thread Gavin Shan
On 6/14/24 9:36 AM, Salil Mehta wrote: This shall be used to store user specified topology{socket,cluster,core,thread} and shall be converted to a unique 'vcpu-id' which is used as slot-index during hot(un)plug of vCPU. Co-developed-by: Keqian Zhu Signed-off-by: Keqian Zhu Signed-off-by: Salil

[PATCH 1/3] target/i386: Do not apply REX to MMX operands

2024-08-11 Thread Richard Henderson
Cc: qemu-sta...@nongnu.org Fixes: b3e22b2318a ("target/i386: add core of new i386 decoder") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2495 Signed-off-by: Richard Henderson --- target/i386/tcg/decode-new.c.inc | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ta

[PATCH 2/3] target/i386: Use unit not type in decode_modrm

2024-08-11 Thread Richard Henderson
Rather that enumerating the types that can produce MMX operands, examine the unit. No functional change. Signed-off-by: Richard Henderson --- target/i386/tcg/decode-new.c.inc | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/i386/tcg/decode-new.c.inc b/target/i3

[PATCH 3/3] target/i386: Assert MMX and XMM registers in range

2024-08-11 Thread Richard Henderson
The mmx assert would fire without the fix for #2495. Signed-off-by: Richard Henderson --- target/i386/tcg/emit.c.inc | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/target/i386/tcg/emit.c.inc b/target/i386/tcg/emit.c.inc index 016dce8146..747ff71b33 100644 --- a/targ

[PATCH for-9.1 0/3] target/i386: Do not apply REX to MMX operands

2024-08-11 Thread Richard Henderson
Fixes #2495. r~ Richard Henderson (3): target/i386: Do not apply REX to MMX operands target/i386: Use unit not type in decode_modrm target/i386: Assert MMX and XMM registers in range target/i386/tcg/decode-new.c.inc | 13 - target/i386/tcg/emit.c.inc | 9 +++-- 2 fi

Re: [PATCH v8 8/8] hw/riscv/virt: Add IOPMP support

2024-08-11 Thread Ethan Chen via
On Mon, Aug 12, 2024 at 10:48:40AM +1000, Alistair Francis wrote: > [EXTERNAL MAIL] > > On Fri, Aug 9, 2024 at 8:14 PM Ethan Chen wrote: > > > > On Thu, Aug 08, 2024 at 02:01:13PM +1000, Alistair Francis wrote: > > > > > > On Mon, Jul 15, 2024 at 8:15 PM Ethan Chen via > > > wrote: > > > > > >

Re: [PATCH v8 5/8] hw/misc/riscv_iopmp: Add API to set up IOPMP protection for system memory

2024-08-11 Thread Ethan Chen via
On Mon, Aug 12, 2024 at 10:47:33AM +1000, Alistair Francis wrote: > [EXTERNAL MAIL] > > On Fri, Aug 9, 2024 at 8:11 PM Ethan Chen wrote: > > > > On Thu, Aug 08, 2024 at 02:23:56PM +1000, Alistair Francis wrote: > > > > > > On Mon, Jul 15, 2024 at 8:13 PM Ethan Chen via > > > wrote: > > > > > >

Re: The members of QCryptodevBackendServiceType are undocumented

2024-08-11 Thread zhenwei pi
Hi Markus, Sorry for the lack of necessary description. I sent a patch, please review it. On 8/9/24 02:09, Markus Armbruster wrote: > Hi Zhenwei Pi, > > You added the type in commit bc304a6442e (cryptodev: Introduce server > type in QAPI). The doc comment describes none of the members. Can you >

[PATCH] qapi: Document QCryptodevBackendServiceType

2024-08-11 Thread zhenwei pi
QCryptodevBackendServiceType was introduced by bc304a6442e (cryptodev: Introduce server type in QAPI). However there is a lack of member description. Thanks to Markus for pointing out this. Signed-off-by: zhenwei pi --- qapi/cryptodev.json | 10 ++ 1 file changed, 10 insertions(+) diff

Re: [PATCH v5 0/5] vvfat: Fix write bugs for large files and add iotests

2024-08-11 Thread Amjad Alsharafi
On Aug 11 2024, at 10:45 pm, Michael Tokarev wrote: > The question here is whenever I should include whole series > (5 patches) or just one? I picked up all 5 for now. Yeah, we should include all of them (at least the first 4 are required for the actual fixes), the last one is unit test for

Re: [RFC PATCH] accel/tcg: clear all TBs from a page when it is written to

2024-08-11 Thread Richard Henderson
On 8/9/24 17:47, Nicholas Piggin wrote: This is not a clean patch, but does fix a problem I hit with TB invalidation due to the target software writing to memory with TBs. Lockup messages are triggering in Linux due to page clearing taking a long time when a code page has been freed, because it

Re: [PATCH] tcg/loongarch64: Fix tcg_out_movi tcg_debug_assert() error

2024-08-11 Thread Richard Henderson
On 8/12/24 03:43, Michael Tokarev wrote: 18.06.2024 15:50, Song Gao wrote: On Loongnix 20.5 systems, QEMU configure with option '--enable-debug' or '--enable-debug-tcg ', booting the Loongnix 20.5 VM in tcg mode will get an assertion error. "... [   31.484992] [drm] Initialized virtio

Re: [PATCH v8 8/8] hw/riscv/virt: Add IOPMP support

2024-08-11 Thread Alistair Francis
On Fri, Aug 9, 2024 at 8:14 PM Ethan Chen wrote: > > On Thu, Aug 08, 2024 at 02:01:13PM +1000, Alistair Francis wrote: > > > > On Mon, Jul 15, 2024 at 8:15 PM Ethan Chen via > > wrote: > > > > > > - Add 'iopmp=on' option to enable IOPMP. It adds an iopmp device virt > > > machine > > > to pro

Re: [PATCH-for-9.1] target/mips: Fix execution mode in page_table_walk_refill()

2024-08-11 Thread Richard Henderson
On 8/12/24 02:54, Philippe Mathieu-Daudé wrote: When refactoring page_table_walk_refill() in commit 4e999bf419 we replaced the execution mode and forced it to kernel mode. Restore the previous behavior to also get supervisor / user modes. Reported-by: Thomas Petazzoni Reported-by: Waldemar Brod

Re: [PATCH v8 5/8] hw/misc/riscv_iopmp: Add API to set up IOPMP protection for system memory

2024-08-11 Thread Alistair Francis
On Fri, Aug 9, 2024 at 8:11 PM Ethan Chen wrote: > > On Thu, Aug 08, 2024 at 02:23:56PM +1000, Alistair Francis wrote: > > > > On Mon, Jul 15, 2024 at 8:13 PM Ethan Chen via > > wrote: > > > > > > To enable system memory transactions through the IOPMP, memory regions > > > must > > > be moved t

[PATCH v2 3/4] target/m68k: Implement packed decimal real stores

2024-08-11 Thread Richard Henderson
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2488 Signed-off-by: Richard Henderson --- target/m68k/helper.h | 1 + target/m68k/fpu_helper.c | 112 +++ target/m68k/translate.c | 27 -- 3 files changed, 137 insertions(+), 3 deletions(-)

[PATCH v2 1/4] target/m68k: Introduce M68K_FEATURE_FPU_PACKED_DECIMAL

2024-08-11 Thread Richard Henderson
Set for 68020 and 68030, but does nothing so far. Signed-off-by: Richard Henderson --- target/m68k/cpu.h | 2 ++ target/m68k/cpu.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/target/m68k/cpu.h b/target/m68k/cpu.h index b5bbeedb7a..7114324e4d 100644 --- a/target/m68k/cpu.h +++ b/target

[PATCH for-9.2 v2 0/4] target/m68k: Implement fmove.p

2024-08-11 Thread Richard Henderson
Implement packed decimal real conversions. Changes for v2: * Generate the complete set of powers of 10 for floatx80. This was enough to get 9.e999 properly rounded. r~ Richard Henderson (4): target/m68k: Introduce M68K_FEATURE_FPU_PACKED_DECIMAL target/m68k: Implement

[PATCH v2 4/4] tests/tcg/m68k: Add packed decimal tests

2024-08-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tests/tcg/m68k/packeddecimal-1.c | 41 +++ tests/tcg/m68k/packeddecimal-2.c | 42 tests/tcg/m68k/Makefile.target | 4 ++- 3 files changed, 86 insertions(+), 1 deletion(-) create mode 100644 tests

Re: [PATCH v8 4/8] hw/misc/riscv_iopmp: Add RISC-V IOPMP device

2024-08-11 Thread Alistair Francis
On Fri, Aug 9, 2024 at 7:42 PM Ethan Chen wrote: > > On Thu, Aug 08, 2024 at 01:56:35PM +1000, Alistair Francis wrote: > > [EXTERNAL MAIL] > > > > On Mon, Jul 15, 2024 at 7:58 PM Ethan Chen via > > wrote: > > > > > > Support basic functions of IOPMP specification v0.9.1 rapid-k model. > > > The

Re: [PATCH] target/riscv: Use get_address() to get address with Zicbom extensions

2024-08-11 Thread Alistair Francis
On Mon, Aug 12, 2024 at 3:49 AM Michael Tokarev wrote: > > 19.04.2024 14:37, Philippe Mathieu-Daudé wrpte: > > On 19/4/24 13:05, Philippe Mathieu-Daudé wrote: > >> We need to use get_address() to get an address from cpu_gpr[], > >> since $zero is "special" (NULL). > > Hi! > > Has this change been

Re: [PATCH v3 14/20] target/riscv: mmu changes for zicfiss shadow stack protection

2024-08-11 Thread Richard Henderson
On 8/10/24 04:55, Deepak Gupta wrote: On Wed, Aug 07, 2024 at 01:19:55PM +1000, Richard Henderson wrote: On 8/7/24 10:06, Deepak Gupta wrote: int prot = 0; -    if (pte & PTE_R) { +    /* + * If PTE has read bit in it or it's shadow stack page, + * then reads allowed + */ +   

Re: [PATCH 1/1] module: Prevent crash by resetting local_err in module_load_qom_all()

2024-08-11 Thread Richard Henderson
On 8/9/24 22:13, Alexander Ivanov wrote: Set local_err to NULL after it has been freed in error_report_err(). This avoids triggering assert(*errp == NULL) failure in error_setv() when local_err is reused in the loop. Signed-off-by: Alexander Ivanov --- util/module.c | 1 + 1 file changed, 1

Re: [PATCH] target/arm/tcg: Fix overflow in matrix-multiply accumulate

2024-08-11 Thread Richard Henderson
On 8/11/24 15:43, Joe Hattori wrote: Arm's intrinsic matrix multiply accumulate instructions take two 8-bit vector and add up a 32-bit vector. Current emulation causes overflow when large 8-bit integers are used. This commit fixes the issue by casting the 8-bit integers to 32-bit integers before

Re: [PATCH qemu v3 1/1] target/riscv: Add Zilsd and Zclsd extension support

2024-08-11 Thread Richard Henderson
On 7/31/24 13:22, ~liuxu wrote: From: lxx <1733205...@qq.com> This patch adds support for the Zilsd and Zclsd extension, which is documented at https://github.com/riscv/riscv-zilsd/releases/tag/v0.9.0 Co-developed-by: SUN Dongya Co-developed-by: LIU Xu Co-developed-by: ZHAO Fujin --- targe

Re: [PULL 09/11] target/arm: add support for PMUv3 64-bit PMCCNTR in AArch32 mode

2024-08-11 Thread Richard Henderson
On 8/10/24 04:08, Peter Maydell wrote: From: Alex Richardson In the PMUv3, a new AArch32 64-bit (MCRR/MRRC) accessor for the PMCCNTR was added. In QEMU we forgot to implement this, so only provide the 32-bit accessor. Since we have a 64-bit PMCCNTR sysreg for AArch64, adding the 64-bit AArch32

Re: [PATCH v2] Update event idx if guest has made extra buffers during double check

2024-08-11 Thread Michael S. Tsirkin
On Mon, Jun 17, 2024 at 01:45:51PM +0800, thomas wrote: > If guest has made some buffers available during double check, > but the total buffer size available is lower than @bufsize, > notify the guest with the latest available idx(event idx) > seen by the host. > > Fixes: 06b12970174 ("virtio-net:

Re: [PATCH v2] block/reqlist: allow adding overlapping requests

2024-08-11 Thread Michael Tokarev
12.07.2024 17:07, Fiona Ebner wrote: Allow overlapping request by removing the assert that made it impossible. There are only two callers: 1. block_copy_task_create() It already asserts the very same condition before calling reqlist_init_req(). 2. cbw_snapshot_read_lock() There is no need to

Re: [PATCH] target/riscv: Use get_address() to get address with Zicbom extensions

2024-08-11 Thread Michael Tokarev
19.04.2024 14:37, Philippe Mathieu-Daudé wrpte: On 19/4/24 13:05, Philippe Mathieu-Daudé wrote: We need to use get_address() to get an address from cpu_gpr[], since $zero is "special" (NULL). Hi! Has this change been forgotten, or is it not needed anymore? It's been quite some time since Apr-

Re: [PATCH] dma-helpers: Fix iovec alignment

2024-08-11 Thread Michael Tokarev
12.04.2024 18:25, Eric Blake wrote: On Fri, Apr 12, 2024 at 10:06:17AM +0200, Stefan Fritsch wrote: Commit 99868af3d0 changed the hardcoded constant BDRV_SECTOR_SIZE to a dynamic field 'align' but introduced a bug. qemu_iovec_discard_back() is now passed the wanted iov length instead of the actu

Re: [PATCH v2] Update event idx if guest has made extra buffers during double check

2024-08-11 Thread Michael Tokarev
17.06.2024 08:45, thomas wrote: If guest has made some buffers available during double check, but the total buffer size available is lower than @bufsize, notify the guest with the latest available idx(event idx) seen by the host. Hi! Has this change been forgotten, or is it not needed anymore?

Re: [PATCH] tcg/loongarch64: Fix tcg_out_movi tcg_debug_assert() error

2024-08-11 Thread Michael Tokarev
18.06.2024 15:50, Song Gao wrote: On Loongnix 20.5 systems, QEMU configure with option '--enable-debug' or '--enable-debug-tcg ', booting the Loongnix 20.5 VM in tcg mode will get an assertion error. "... [ 31.484992] [drm] Initialized virtio_gpu 0.0.1 0 for virtio1 on minor 0 q

Re: [PATCH v3 5/5] accel/tcg: Always call tcg_flush_jmp_cache() on reset

2024-08-11 Thread Michael Tokarev
03.05.2024 15:34, Philippe Mathieu-Daudé wrote: In commit bb6cf6f016 ("accel/tcg: Factor tcg_cpu_reset_hold() out") we unfortunately restricted the tcg_flush_jmp_cache() to system emulation. Move it to the common tcg_exec_cpu_reset_hold() handler so user emulation gets the jmp_cache initialized w

Re: [PATCH 00/17] target/arm: AdvSIMD decodetree conversion, part 4

2024-08-11 Thread Michael Tokarev
17.07.2024 09:08, Richard Henderson wrote: Flush before the queue gets too big. Also, there's a bug fix in patch 14. Hi! Has this patchset (together with the bugfix) been forgotten? Maybe we should include at least the bug fix for 9.1? Thanks, /mjt r~ Richard Henderson (17): target/arm

Re: [RFC v3 3/3] vhost: Allocate memory for packed vring

2024-08-11 Thread Sahil
Hi, On Wednesday, August 7, 2024 9:52:10 PM GMT+5:30 Eugenio Perez Martin wrote: > On Fri, Aug 2, 2024 at 1:22 PM Sahil Siddiq wrote: > > [...] > > @@ -726,17 +738,30 @@ void vhost_svq_start(VhostShadowVirtqueue *svq, > > VirtIODevice *vdev, > > svq->vring.num = virtio_queue_get_num(vdev, >

[PATCH-for-9.1] target/mips: Fix execution mode in page_table_walk_refill()

2024-08-11 Thread Philippe Mathieu-Daudé
When refactoring page_table_walk_refill() in commit 4e999bf419 we replaced the execution mode and forced it to kernel mode. Restore the previous behavior to also get supervisor / user modes. Reported-by: Thomas Petazzoni Reported-by: Waldemar Brodkorb Resolves: https://gitlab.com/qemu-project/qe

Re: [RFC v3 3/3] vhost: Allocate memory for packed vring

2024-08-11 Thread Sahil
Hi, Thank you for your reply. On Wednesday, August 7, 2024 10:11:52 PM GMT+5:30 you wrote: > On Fri, Aug 2, 2024 at 1:22 PM Sahil Siddiq wrote: > [...] > > I'll also test these changes out by following the > > suggestions given in response to v1. I'll have more > > confidence once I know these c

Re: [PATCH v5 0/5] vvfat: Fix write bugs for large files and add iotests

2024-08-11 Thread Michael Tokarev
11.08.2024 13:19, Amjad Alsharafi wrote: ... It would be great to include this patch in `stable`. Thank you. The question here is whenever I should include whole series (5 patches) or just one? I picked up all 5 for now. Thanks, /mjt

[PATCH] target/arm/tcg: Fix overflow in matrix-multiply accumulate

2024-08-11 Thread Joe Hattori
Arm's intrinsic matrix multiply accumulate instructions take two 8-bit vector and add up a 32-bit vector. Current emulation causes overflow when large 8-bit integers are used. This commit fixes the issue by casting the 8-bit integers to 32-bit integers before multiplication. Fixes: 2323c5ffd4b5 ("

[PATCH] hw/smbios: support for type 7 (cache information)

2024-08-11 Thread Hal Martin
This patch adds support for SMBIOS type 7 (Cache Information) to qemu. level: cache level (1-8) size: cache size in bytes Example usage: -smbios type=7,level=1,size=0x8000 Signed-off-by: Hal Martin --- hw/smbios/smbios.c | 63 include/hw/firmware/

Re: [PATCH v5 0/5] vvfat: Fix write bugs for large files and add iotests

2024-08-11 Thread Amjad Alsharafi
On Aug 11 2024, at 6:09 pm, Michael Tokarev wrote: > 11.08.2024 12:52, Amjad Alsharafi wrote: > > Hi! > >> This actually has been reviewed and approved (last version was v6 >> here: >> https://patchew.org/QEMU/cover.1721470238.git.amjadsharaf...@gmail.com/) >> It has been merged into upstre

Re: [PATCH v5 0/5] vvfat: Fix write bugs for large files and add iotests

2024-08-11 Thread Michael Tokarev
11.08.2024 12:52, Amjad Alsharafi wrote: Hi! This actually has been reviewed and approved (last version was v6 here: https://patchew.org/QEMU/cover.1721470238.git.amjadsharaf...@gmail.com/) It has been merged into upstream here: https://gitlab.com/qemu-project/qemu/-/commit/6d00c6f98256ad

Re: [PATCH v5 0/5] vvfat: Fix write bugs for large files and add iotests

2024-08-11 Thread Amjad Alsharafi
On Aug 11 2024, at 3:51 pm, Michael Tokarev wrote: > 12.06.2024 15:43, Amjad Alsharafi wrote: >> These patches fix some bugs found when modifying files in vvfat. >> First, there was a bug when writing to the cluster 2 or above of a >> file, it >> will copy the cluster before it instead, so, wh

Re: [PATCH v6] virtio-pci: Fix the use of an uninitialized irqfd

2024-08-11 Thread Michael S. Tsirkin
On Sun, Aug 11, 2024 at 11:06:09AM +0300, Michael Tokarev wrote: > 07.08.2024 07:02, Jason Wang wrote: > > > Acked-by: Jason Wang > > Jason, would you mind picking this up together with -net help bugfix > and sending a pull request? > > This particular change has been (re)tried multiple times b

Re: [PATCH v6] virtio-pci: Fix the use of an uninitialized irqfd

2024-08-11 Thread Michael Tokarev
07.08.2024 07:02, Jason Wang wrote: Acked-by: Jason Wang Jason, would you mind picking this up together with -net help bugfix and sending a pull request? This particular change has been (re)tried multiple times by Cindy Lu already, and the bug is still not fixed and affects users. Both this

Re: [PULL 5/5] nbd/server: CVE-2024-7409: Close stray clients at server-stop

2024-08-11 Thread Michael Tokarev
09.08.2024 00:53, Eric Blake wrote: A malicious client can attempt to connect to an NBD server, and then intentionally delay progress in the handshake, including if it does not know the TLS secrets. Although the previous two patches reduce this behavior by capping the default max-connections par

Re: [PATCH v5 0/5] vvfat: Fix write bugs for large files and add iotests

2024-08-11 Thread Michael Tokarev
12.06.2024 15:43, Amjad Alsharafi wrote: These patches fix some bugs found when modifying files in vvfat. First, there was a bug when writing to the cluster 2 or above of a file, it will copy the cluster before it instead, so, when writing to cluster=2, the content of cluster=1 will be copied int

Re: [PATCH v5 1/5] vvfat: Fix bug in writing to middle of file

2024-08-11 Thread Michael Tokarev
12.06.2024 15:43, Amjad Alsharafi wrote: Before this commit, the behavior when calling `commit_one_file` for example with `offset=0x2000` (second cluster), what will happen is that we won't fetch the next cluster from the fat, and instead use the first cluster for the read operation. This is due

Re: [PULL 16/28] hw/sd/sdcard: Do not abort when reading DAT lines on invalid cmd state

2024-08-11 Thread Michael Tokarev
06.08.2024 15:51, Philippe Mathieu-Daudé wrote: Guest should not try to read the DAT lines from invalid command state. If it still insists to do so, return a dummy value. Cc: qemu-sta...@nongnu.org Fixes: e2dec2eab0 ("hw/sd/sdcard: Remove default case in read/write on DAT lines") This commit

Re: [PATCH] net: Fix '-net nic,model=' for non-help arguments

2024-08-11 Thread Michael Tokarev
06.08.2024 20:21, David Woodhouse wrote: From: David Woodhouse Oops, don't *delete* the model option when checking for 'help'. Fixes: 64f75f57f9d2 ("net: Reinstate '-net nic, model=help' output as documented in man page") Reported-by: Hans Signed-off-by: David Woodhouse Cc: qemu-sta...@nong

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-11 Thread Michael S. Tsirkin
On Thu, Aug 08, 2024 at 11:25:29AM -0400, Peter Xu wrote: > On Thu, Aug 08, 2024 at 10:47:28AM -0400, Michael S. Tsirkin wrote: > > On Thu, Aug 08, 2024 at 10:15:36AM -0400, Peter Xu wrote: > > > On Thu, Aug 08, 2024 at 07:12:14AM -0400, Michael S. Tsirkin wrote: > > > > This is too big of a hammer