Re: [PATCH 01/18] qapi: Smarter camel_to_upper() to reduce need for 'prefix'

2024-07-30 Thread Markus Armbruster
Avihai Horon writes: > On 31/07/2024 8:12, Markus Armbruster wrote: >> External email: Use caution opening links or attachments >> >> >> Avihai Horon writes: >> >>> On 30/07/2024 15:22, Markus Armbruster wrote: Avihai, there's a question for you on VfioMigrationState. Daniel P. Be

Re: [PATCH v2 2/2] qom/object, accel-system: add support to Accel globals

2024-07-30 Thread Markus Armbruster
I apologize for the delay. Daniel Henrique Barboza writes: > We're not honouring KVM options that are provided by any -accel option > aside from the first. In this example: > > qemu-system-riscv64 -accel kvm,riscv-aia=emul (...) \ > -accel kvm,riscv-aia=hwaccel > > 'riscv-aia' will be set to

Re: [PULL 0/6] Docs testing patches

2024-07-30 Thread Richard Henderson
On 7/31/24 08:19, Philippe Mathieu-Daudé wrote: The following changes since commit ef009e4b4dc0421464008e6e303b892141ede579: Merge tag 's390x-20240730' ofhttps://github.com/davidhildenbrand/qemu into staging (2024-07-30 19:21:58 +1000) are available in the Git repository at:

Re: [PULL for 9.1-rc1 00/14] Minor bug fixes and documentation cleanups

2024-07-30 Thread Richard Henderson
On 7/31/24 02:22, Alex Bennée wrote: The following changes since commit 8617cb073ca9fa5588d7afad5c81b7aa6cd02f26: Merge tag 'pull-misc-20240730' ofhttps://gitlab.com/rth7680/qemu into staging (2024-07-30 11:12:42 +1000) are available in the Git repository at: https://gitlab.c

Re: [PATCH v3 6/7] acpi/ghes: update comments to point to newer ACPI specs

2024-07-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Jul 2024 07:36:32 -0400 "Michael S. Tsirkin" escreveu: > On Tue, Jul 30, 2024 at 01:24:30PM +0200, Igor Mammedov wrote: > > On Mon, 22 Jul 2024 08:45:58 +0200 > > Mauro Carvalho Chehab wrote: > > > > > There is one reference to ACPI 4.0 and several references > > > to ACPI 6.x vers

Re: [PATCH 01/18] qapi: Smarter camel_to_upper() to reduce need for 'prefix'

2024-07-30 Thread Avihai Horon
On 31/07/2024 8:12, Markus Armbruster wrote: External email: Use caution opening links or attachments Avihai Horon writes: On 30/07/2024 15:22, Markus Armbruster wrote: Avihai, there's a question for you on VfioMigrationState. Daniel P. Berrangé writes: On Tue, Jul 30, 2024 at 10:10:1

[PATCH v6 RESEND 0/5] Power11 support for QEMU [PSeries]

2024-07-30 Thread Aditya Gupta
Overview Split "Power11 support for QEMU" into 2 patch series: pseries & powernv. This patch series is for pseries support for Power11. As Power11 core is same as Power10, hence much of the code has been reused from Power10. Power11 was added in Linux in: commit c2ed087ed35c ("po

[PATCH v6 RESEND 1/5] target/ppc: Reduce code duplication across Power9/10 init code

2024-07-30 Thread Aditya Gupta
From: Harsh Prateek Bora Power9/10 initialization code consists of a lot of logical OR of various flag bits as supported by respective Power platform during its initialization, most of which is duplicated and only selected bits are added or removed as needed with each new platform support being a

[PATCH v6 RESEND 5/5] ppc/pseries: Add Power11 cpu type

2024-07-30 Thread Aditya Gupta
Add sPAPR CPU Core definition for Power11 Cc: Cédric Le Goater Cc: Daniel Henrique Barboza Cc: David Gibson Cc: Frédéric Barrat Cc: Harsh Prateek Bora Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Reviewed-by: Harsh Prateek Bora Reviewed-by: Nicholas Piggin Signed-o

[PATCH v6 RESEND 2/5] target/ppc: Introduce 'PowerPCCPUClass::spapr_logical_pvr'

2024-07-30 Thread Aditya Gupta
Introduce 'PnvChipClass::spapr_logical_pvr' to know corresponding logical PVR of a PowerPC CPU. This helps to have a one-to-one mapping between PVR and logical PVR for a CPU, and used in a later commit to handle cases where PCR of two generations of Power chip is same, which causes regressions with

[PATCH v6 RESEND 4/5] target/ppc: Add Power11 DD2.0 processor

2024-07-30 Thread Aditya Gupta
Add CPU target code to add support for new Power11 Processor. Power11 core is same as Power10, hence reuse functions defined for Power10. Cc: Cédric Le Goater Cc: Daniel Henrique Barboza Cc: Frédéric Barrat Cc: Harsh Prateek Bora Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas

[PATCH v6 RESEND 3/5] target/ppc: Fix regression due to Power10 and Power11 having same PCR

2024-07-30 Thread Aditya Gupta
Power11 has the same PCR (Processor Compatibility Register) value, as Power10. Due to this, QEMU considers Power11 as a valid compat-mode for Power10, ie. earlier it was possible to run QEMU with '-M pseries,max-compat-mode=power11 --cpu power10' Same PCR also introduced a regression where `-M p

Re: [PATCH v4 2/6] arm/virt: Wire up GPIO error source for ACPI / GHES

2024-07-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Jul 2024 16:11:42 +0800 Zhao Liu escreveu: > Hi Mauro, > > On Mon, Jul 29, 2024 at 03:21:06PM +0200, Mauro Carvalho Chehab wrote: > > Date: Mon, 29 Jul 2024 15:21:06 +0200 > > From: Mauro Carvalho Chehab > > Subject: [PATCH v4 2/6] arm/virt: Wire up GPIO error source for ACPI / GHES

Re: [PATCH v3 2/7] arm/virt: Wire up GPIO error source for ACPI / GHES

2024-07-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Jul 2024 10:36:15 +0200 Igor Mammedov escreveu: > On Mon, 22 Jul 2024 08:45:54 +0200 > Mauro Carvalho Chehab wrote: > > > From: Jonathan Cameron > > > > Creates a GED - Generic Event Device and set a GPIO to > > be used or error injection. > > QEMU already has GED device, so que

Re: [PATCH 01/18] qapi: Smarter camel_to_upper() to reduce need for 'prefix'

2024-07-30 Thread Markus Armbruster
Avihai Horon writes: > On 30/07/2024 15:22, Markus Armbruster wrote: >> >> Avihai, there's a question for you on VfioMigrationState. >> >> Daniel P. Berrangé writes: >> >>> On Tue, Jul 30, 2024 at 10:10:15AM +0200, Markus Armbruster wrote: [...] >> * VfioMigrationState >> >>Can't see why t

Re: [PATCH v3 09/24] tests/functional: enable pre-emptive caching of assets

2024-07-30 Thread Richard Henderson
On 7/31/24 03:03, Daniel P. Berrangé wrote: Many tests need to access assets stored on remote sites. We don't want to download these during test execution when run by meson, since this risks hitting test timeouts when data transfers are slow. Add support for pre-emptive caching of assets by sett

Re: [PATCH] qmp: Add 'memtranslate' QMP command

2024-07-30 Thread Markus Armbruster
ju...@oro.sh writes: > 31 July 2024 at 02:12, "Dr. David Alan Gilbert" wrote: > > Hello Dr. Gilbert, > >> >> * Josh Junon (ju...@oro.sh) wrote: >> >> Hi Josh, >> >> > >> > This commit adds a new QMP/HMP command `memtranslate`, >> > which translates a virtual address to a physical address >> >

Re: [PATCH-for-9.1 4/5] hw/sd/sdhci: Trace ADMA descriptors

2024-07-30 Thread Richard Henderson
On 7/30/24 19:21, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci.c | 8 hw/sd/trace-events | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 8293d83556..66b9364e9e 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd

Re: [PATCH-for-9.1 3/5] hw/sd/sdhci: Reset @data_count index on invalid ADMA transfers

2024-07-30 Thread Richard Henderson
On 7/30/24 19:21, Philippe Mathieu-Daudé wrote: We neglected to clear the @data_count index on ADMA error, allowing to trigger assertion in sdhci_read_dataport() or sdhci_write_dataport(). Cc:qemu-sta...@nongnu.org Fixes: d7dfca0807 ("hw/sdhci: introduce standard SD host controller") Reported-by

Re: [PATCH-for-9.1 2/5] hw/sd/sdcard: Do not abort when reading DAT lines on invalid cmd state

2024-07-30 Thread Richard Henderson
On 7/30/24 19:21, Philippe Mathieu-Daudé wrote: Guest should not try to read the DAT lines from invalid command state. If it still insists to do so, return a dummy value. Cc:qemu-sta...@nongnu.org Fixes: e2dec2eab0 ("hw/sd/sdcard: Remove default case in read/write on DAT lines") Reported-by: Zh

Re: [PATCH-for-9.1 1/5] hw/sd/sdcard: Explicit dummy byte value

2024-07-30 Thread Richard Henderson
On 7/30/24 19:21, Philippe Mathieu-Daudé wrote: On error the DAT lines are left unmodified to their previous states. QEMU returns 0x00 for convenience. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/sd/s

Re: [PATCH v6 5/5] net/tap: Use qemu_close_all_open_fd()

2024-07-30 Thread Richard Henderson
On 7/30/24 22:24, Clément Léger wrote: Instead of using a slow implementation to close all open fd after forking, use qemu_close_all_open_fd(). Signed-off-by: Clément Léger --- net/tap.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Jason Wang
On Tue, Jul 30, 2024 at 6:23 PM Akihiko Odaki wrote: > > On 2024/07/30 12:45, Jason Wang wrote: > > On Tue, Jul 30, 2024 at 11:29 AM Akihiko Odaki > > wrote: > >> > >> On 2024/07/30 12:17, Jason Wang wrote: > >>> On Tue, Jul 30, 2024 at 11:12 AM Akihiko Odaki > >>> wrote: > > On 2024

Re: [PATCH v6 4/5] qemu/osdep: Add excluded fd parameter to qemu_close_all_open_fd()

2024-07-30 Thread Richard Henderson
On 7/30/24 22:24, Clément Léger wrote: diff --git a/util/oslib-posix.c b/util/oslib-posix.c index a6749d9f9b..e7bffaea16 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -808,11 +808,14 @@ int qemu_msync(void *addr, size_t length, int fd) return msync(addr, length, MS_SYNC); }

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Jason Wang
On Wed, Jul 31, 2024 at 5:33 AM Michael S. Tsirkin wrote: > > On Tue, Jul 30, 2024 at 04:03:53PM -0400, Peter Xu wrote: > > On Tue, Jul 30, 2024 at 03:22:50PM -0400, Michael S. Tsirkin wrote: > > > This is not what we did historically. Why should we start now? > > > > It's a matter of whether we s

Re: [PATCH v6 3/5] net/tap: Factorize fd closing after forking

2024-07-30 Thread Richard Henderson
On 7/30/24 22:24, Clément Léger wrote: The same code is used twice to actually close all open file descriptors after forking. Factorize it in a single place. Signed-off-by: Clément Léger --- net/tap.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) Review

Re: [PATCH v6 2/5] qemu/osdep: Split qemu_close_all_open_fd() and add fallback

2024-07-30 Thread Richard Henderson
On 7/30/24 22:24, Clément Léger wrote: +/* + * Close all open file descriptors. + */ +void qemu_close_all_open_fd(void) +{ +int open_max = sysconf(_SC_OPEN_MAX); +int i; + +if (qemu_close_all_open_fd_close_range()) { +return; +} + +if (qemu_close_all_open_fd_proc()) {

Re: [PATCH v6 1/5] qemu/osdep: Move close_all_open_fds() to oslib-posix

2024-07-30 Thread Richard Henderson
On 7/30/24 22:24, Clément Léger wrote: Move close_all_open_fds() in oslib-posix, rename it qemu_close_all_open_fds() and export it. Signed-off-by: Clément Léger --- include/qemu/osdep.h| 7 +++ system/async-teardown.c | 37 + util/oslib-posix.c

Re: [PATCH 8/8] target/arm: Enable FEAT_EBF16 in the "max" CPU

2024-07-30 Thread Richard Henderson
On 7/31/24 02:03, Peter Maydell wrote: Now that we've implemented the required behaviour for FEAT_EBF16, we can enable it for the "max" CPU type, list it in our documentation, and delete a TODO comment about it being missing. Signed-off-by: Peter Maydell --- docs/system/arm/emulation.rst | 1

Re: [PATCH 7/8] target/arm: Implement FPCR.EBF=1 semantics for bfdotadd()

2024-07-30 Thread Richard Henderson
On 7/31/24 02:03, Peter Maydell wrote: Implement the FPCR.EBF=1 semantics for bfdotadd() operations: * is_ebf() sets up fpst and fpst_odd * bfdotadd_ebf() implements the fused paired-multiply-and-add operation that we need The paired-multiply-and-add is similar to f16_dotadd() and we use

Re: [PATCH 6/8] target/arm: Prepare bfdotadd() callers for FEAT_EBF support

2024-07-30 Thread Richard Henderson
On 7/31/24 02:03, Peter Maydell wrote: @@ -2790,7 +2790,7 @@ DO_MMLA_B(gvec_usmmla_b, do_usmmla_b) * BFloat16 Dot Product */ -float32 bfdotadd(float32 sum, uint32_t e1, uint32_t e2) +bool is_ebf(CPUARMState *env, float_status *statusp, float_status *oddstatusp) { /* FPCR is igno

Re: [PATCH 6/8] target/arm: Prepare bfdotadd() callers for FEAT_EBF support

2024-07-30 Thread Richard Henderson
On 7/31/24 02:03, Peter Maydell wrote: We use bfdotadd() in four callsites for various helper functions. Currently this all assumes that we have the FPCR.EBF=0 semantics. For FPCR.EBF=1 we will need to: * call a different routine to bfdotadd() because we need to do a fused multiply-add rath

Re: [PATCH 5/8] target/arm: Pass env pointer through to gvec_bfmmla helper

2024-07-30 Thread Richard Henderson
On 7/31/24 02:03, Peter Maydell wrote: Pass the env pointer through to the gvec_bfmmla helper, so we can use it to add support for FEAT_EBF16. Signed-off-by: Peter Maydell --- target/arm/helper.h | 4 ++-- target/arm/tcg/translate-a64.c | 2 +- target/arm/tcg/translate-neon.c |

Re: [PATCH 4/8] target/arm: Pass env pointer through to gvec_bfdot_idx helper

2024-07-30 Thread Richard Henderson
On 7/31/24 02:03, Peter Maydell wrote: Pass the env pointer through to the gvec_bfdot_idx helper, so we can use it to add support for FEAT_EBF16. Signed-off-by: Peter Maydell --- target/arm/helper.h | 4 ++-- target/arm/tcg/translate-a64.c | 11 ++- target/arm/tcg/tran

Re: [PATCH 3/8] target/arm: Pass env pointer through to gvec_bfdot helper

2024-07-30 Thread Richard Henderson
On 7/31/24 02:03, Peter Maydell wrote: Pass the env pointer through to the gvec_bfdot helper, so we can use it to add support for FEAT_EBF16. Signed-off-by: Peter Maydell --- target/arm/helper.h | 4 ++-- target/arm/tcg/translate-a64.c | 27 - target/ar

Re: [PATCH 2/8] target/arm: Pass env pointer through to sme_bfmopa helper

2024-07-30 Thread Richard Henderson
On 7/31/24 02:03, Peter Maydell wrote: To implement the FEAT_EBF16 semantics, we are going to need the CPUARMState env pointer in every helper function which calls bfdotadd(). Pass the env pointer through from generated code to the sme_bfmopa helper. (We'll add the code that uses it when we've a

Re: [PATCH 1/8] target/arm: Allow setting the FPCR.EBF bit for FEAT_EBF16

2024-07-30 Thread Richard Henderson
On 7/31/24 02:02, Peter Maydell wrote: FEAT_EBF16 adds one new bit to the FPCR floating point control register. Allow this bit to be read and written when the ID registers indicate the presence of the feature. Note that because this new bit is not in FPSCR_FPCR_MASK the bit is not visible in th

Re: [PULL 00/21] target-arm queue

2024-07-30 Thread Richard Henderson
20240726-1' ofhttps://gitlab.com/npiggin/qemu into staging (2024-07-26 15:10:45 +1000) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20240730 for you to fetch changes up to 73188068d7ba40c8a37b4763db38bb1ce24ca07d:

[PATCH] target/hexagon: switch to dc set_props() list

2024-07-30 Thread Brian Cain
Define a hexagon_cpu_properties list to match the idiom used by other targets. Signed-off-by: Brian Cain --- target/hexagon/cpu.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c index 64cc05cca7..93579fbb15 10064

[PATCH] target/hexagon: define a v66 CPU

2024-07-30 Thread Brian Cain
For now, v66 behavior is the same as other CPUs. Signed-off-by: Brian Cain --- target/hexagon/cpu-qom.h | 1 + target/hexagon/cpu.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/target/hexagon/cpu-qom.h b/target/hexagon/cpu-qom.h index da92fe7468..0b149bd5fe 100644 --- a/target/hexa

Re: [PATCH] qmp: Add 'memtranslate' QMP command

2024-07-30 Thread junon
31 July 2024 at 02:12, "Dr. David Alan Gilbert" wrote: Hello Dr. Gilbert, > > * Josh Junon (ju...@oro.sh) wrote: > > Hi Josh, > > > > > This commit adds a new QMP/HMP command `memtranslate`, > > > > which translates a virtual address to a physical address > > > > using the guest's MMU. >

Re: [PATCH v2] hw/acpi: Add vmclock device

2024-07-30 Thread David Woodhouse
On 30 July 2024 21:45:53 BST, "Michael S. Tsirkin" wrote: >On Tue, Jul 30, 2024 at 08:04:17PM +0100, David Woodhouse wrote: >> On 30 July 2024 18:53:18 BST, "Michael S. Tsirkin" wrote: >> >We don't want to manually sync headers with Linux. >> >> Indeed. I was briefly tempted to fake it, but figu

Re: [PATCH] qmp: Add 'memtranslate' QMP command

2024-07-30 Thread Dr. David Alan Gilbert
* Josh Junon (ju...@oro.sh) wrote: Hi Josh, > This commit adds a new QMP/HMP command `memtranslate`, > which translates a virtual address to a physical address > using the guest's MMU. > > This uses the same mechanism that `[p]memsave` does to > perform the translation. > > This commit also fix

Re: QEMU unexpectedly closed the monitor

2024-07-30 Thread Itaru Kitayama
Hi Alex, > On Jul 30, 2024, at 22:25, Alex Bennée wrote: > > Itaru Kitayama writes: > >> Hi, >> >> Executing virt-install with the following options: >> >> sudo virt-install --machine=virt --arch=aarch64 --name=test8 --disk >> path=/var/lib/libvirt/images/jammy.qcow2,format=qcow2,device=disk

Re: [PATCH] linux-user/main: Allow setting tb-size

2024-07-30 Thread Richard Henderson
On 7/31/24 07:54, Ilya Leoshkevich wrote: While qemu-system can set tb-size using -accel tcg,tb-size=n, there is no similar knob for qemu-user. Add one in a way similar to how one-insn-per-tb is already handled. Signed-off-by: Ilya Leoshkevich --- linux-user/main.c | 12 1 file c

Re: [PATCH] target/arm: Handle denormals correctly for FMOPA (widening)

2024-07-30 Thread Richard Henderson
On 7/31/24 01:58, Peter Maydell wrote: -void HELPER(sme_fmopa_h)(void *vza, void *vzn, void *vzm, void *vpn, - void *vpm, void *vst, uint32_t desc) +void HELPER(sme_fmopa_h)(CPUARMState *env, + void *vza, void *vzn, void *vzm, void *vpn, +

[PULL 5/6] tests/avocado: test_arm_emcraft_sf2: handle RW requirements for asset

2024-07-30 Thread Philippe Mathieu-Daudé
From: Cleber Rosa The asset used in the mentioned test gets truncated before it's used in the test. This means that the file gets modified, and thus the asset's expected hash doesn't match anymore. This causes cache misses and re-downloads every time the test is re-run. Let's make a copy of th

[PULL 4/6] tests/avocado: mips: add hint for fetchasset plugin

2024-07-30 Thread Philippe Mathieu-Daudé
From: Cleber Rosa Avocado's fetchasset plugin runs before the actual Avocado job (and any test). It analyses the test's code looking for occurrences of "self.fetch_asset()" in the either the actual test or setUp() method. It's not able to fully analyze all code, though. The way these tests are

[PULL 1/6] docs: add test for firmware.json QAPI

2024-07-30 Thread Philippe Mathieu-Daudé
From: Thomas Weißschuh To make sure that the QAPI description stays valid, add a testcase. Suggested-by: Philippe Mathieu-Daudé Link: https://lore.kernel.org/qemu-devel/d9ce0234-4beb-4b90-b14c-76810d3b8...@linaro.org/ Reviewed-by: Daniel P. Berrangé Acked-by: Markus Armbruster Signed-off-by:

[PULL 6/6] osdep.h: Clean up no-longer-needed back-compat for macOS 10

2024-07-30 Thread Philippe Mathieu-Daudé
From: Peter Maydell Our official support policy only supports the most recent two versions of macOS (currently macOS 13 Ventura and macOS 14 Sonoma), and we already have code that assumes at least macOS 12 Monterey or better. In commit 2d27c91e2b72ac7 we dropped some of the back-compat code for

[PULL 2/6] docs/sphinx/depfile.py: Handle env.doc2path() returning a Path not a str

2024-07-30 Thread Philippe Mathieu-Daudé
From: Peter Maydell In newer versions of Sphinx the env.doc2path() API is going to change to return a Path object rather than a str. This was originally visible in Sphinx 8.0.0rc1, but has been rolled back for the final 8.0.0 release. However it will probably emit a deprecation warning and is lik

[PULL 3/6] tests/avocado: mips: fallback to HTTP given certificate expiration

2024-07-30 Thread Philippe Mathieu-Daudé
From: Cleber Rosa The SSL certificate installed at mipsdistros.mips.com has expired: 0 s:CN = mipsdistros.mips.com i:C = US, O = Amazon, OU = Server CA 1B, CN = Amazon a:PKEY: rsaEncryption, 2048 (bit); sigalg: RSA-SHA256 v:NotBefore: Dec 23 00:00:00 2019 GMT; NotAfter: Jan 23 12:00:00 2021

[PULL 0/6] Docs testing patches

2024-07-30 Thread Philippe Mathieu-Daudé
The following changes since commit ef009e4b4dc0421464008e6e303b892141ede579: Merge tag 's390x-20240730' of https://github.com/davidhildenbrand/qemu into staging (2024-07-30 19:21:58 +1000) are available in the Git repository at: https://github.com/philmd/qemu.git tags/docs-testin

[PATCH] qmp: Add 'memtranslate' QMP command

2024-07-30 Thread Josh Junon
This commit adds a new QMP/HMP command `memtranslate`, which translates a virtual address to a physical address using the guest's MMU. This uses the same mechanism that `[p]memsave` does to perform the translation. This commit also fixes a long standing issue of `[p]memsave` not properly handling

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Peter Xu
On Tue, Jul 30, 2024 at 05:32:48PM -0400, Michael S. Tsirkin wrote: > On Tue, Jul 30, 2024 at 04:03:53PM -0400, Peter Xu wrote: > > On Tue, Jul 30, 2024 at 03:22:50PM -0400, Michael S. Tsirkin wrote: > > > This is not what we did historically. Why should we start now? > > > > It's a matter of whet

Re: [PATCH] hvf: arm: Allow creating VMs with > 63GB of RAM on macOS 15+

2024-07-30 Thread Danny Canter
Thanks Peter! For the macOS 13 comment just so I’m clear, you’re saying the minimum we support is 13 now so the conditional compilation for those isn’t required anymore as well? I suppose that tracks given the wording that we support the last two macOS releases at any given time, that kind of

[PATCH] linux-user/main: Allow setting tb-size

2024-07-30 Thread Ilya Leoshkevich
While qemu-system can set tb-size using -accel tcg,tb-size=n, there is no similar knob for qemu-user. Add one in a way similar to how one-insn-per-tb is already handled. Signed-off-by: Ilya Leoshkevich --- linux-user/main.c | 12 1 file changed, 12 insertions(+) diff --git a/linux-

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Michael S. Tsirkin
On Tue, Jul 30, 2024 at 04:03:53PM -0400, Peter Xu wrote: > On Tue, Jul 30, 2024 at 03:22:50PM -0400, Michael S. Tsirkin wrote: > > This is not what we did historically. Why should we start now? > > It's a matter of whether we still want migration to randomly fail, like > what this patch does. >

Re: [PATCH v2] hw/acpi: Add vmclock device

2024-07-30 Thread Michael S. Tsirkin
On Tue, Jul 30, 2024 at 08:04:17PM +0100, David Woodhouse wrote: > On 30 July 2024 18:53:18 BST, "Michael S. Tsirkin" wrote: > >We don't want to manually sync headers with Linux. > > Indeed. I was briefly tempted to fake it, but figured it might get lost if we > subsequently do run the script to

Re: [PATCH] hw/acpi/ich9: Add periodic and swsmi timer

2024-07-30 Thread Dominic Prinz
Ping for my patch from last Friday. https://patchew.org/QEMU/20240719102053.316744-1-...@dprinz.de/ https://lore.kernel.org/qemu-devel/20240719102053.316744-1-...@dprinz.de/ On 19.07.24 12:20, Dominic Prinz wrote: This patch implements the periodic and the swsmi ICH9 chipset timer. They are es

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Peter Xu
On Tue, Jul 30, 2024 at 03:22:50PM -0400, Michael S. Tsirkin wrote: > This is not what we did historically. Why should we start now? It's a matter of whether we still want migration to randomly fail, like what this patch does. Or any better suggestions? I'm definitely open to that. Thanks, --

Re: [PATCH] migration: Refine the convergence detection

2024-07-30 Thread Peter Xu
On Wed, Jul 24, 2024 at 07:39:29PM +0800, Hyman Huang wrote: > Currently, the convergence algorithm determines that the migration > cannot converge according to the following principle: > The dirty pages generated in current iteration exceed a specific > percentage (throttle-trigger-threshold, 50 b

[PATCH v6 1/5] target/ppc: Reduce code duplication across Power9/10 init code

2024-07-30 Thread Aditya Gupta
From: Harsh Prateek Bora Power9/10 initialization code consists of a lot of logical OR of various flag bits as supported by respective Power platform during its initialization, most of which is duplicated and only selected bits are added or removed as needed with each new platform support being a

[PATCH v6 3/5] target/ppc: Fix regression due to Power10 and Power11 having same PCR

2024-07-30 Thread Aditya Gupta
Power11 has the same PCR (Processor Compatibility Register) value, as Power10. Due to this, QEMU considers Power11 as a valid compat-mode for Power10, ie. earlier it was possible to run QEMU with '-M pseries,max-compat-mode=power11 --cpu power10' Same PCR also introduced a regression where `-M p

[PATCH v6 5/5] ppc/pseries: Add Power11 cpu type

2024-07-30 Thread Aditya Gupta
Add sPAPR CPU Core definition for Power11 Cc: Cédric Le Goater Cc: Daniel Henrique Barboza Cc: David Gibson Cc: Frédéric Barrat Cc: Harsh Prateek Bora Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Reviewed-by: Harsh Prateek Bora Reviewed-by: Nicholas Piggin Signed-o

[PATCH v6 4/5] target/ppc: Add Power11 DD2.0 processor

2024-07-30 Thread Aditya Gupta
Add CPU target code to add support for new Power11 Processor. Power11 core is same as Power10, hence reuse functions defined for Power10. Cc: Cédric Le Goater Cc: Daniel Henrique Barboza Cc: Frédéric Barrat Cc: Harsh Prateek Bora Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas

[PATCH v6 2/5] target/ppc: Introduce 'PowerPCCPUClass::spapr_logical_pvr'

2024-07-30 Thread Aditya Gupta
Introduce 'PnvChipClass::spapr_logical_pvr' to know corresponding logical PVR of a PowerPC CPU. This helps to have a one-to-one mapping between PVR and logical PVR for a CPU, and used in a later commit to handle cases where PCR of two generations of Power chip is same, which causes regressions with

[PATCH v6 0/5] Power11 support for QEMU [PSeries]

2024-07-30 Thread Aditya Gupta
Overview Split "Power11 support for QEMU" into 2 patch series: pseries & powernv. This patch series is for pseries support for Power11. As Power11 core is same as Power10, hence much of the code has been reused from Power10. Power11 was added in Linux in: commit c2ed087ed35c ("po

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Michael S. Tsirkin
On Tue, Jul 30, 2024 at 03:11:03PM -0400, Peter Xu wrote: > On Tue, Jul 30, 2024 at 07:46:12PM +0100, Daniel P. Berrangé wrote: > > On Tue, Jul 30, 2024 at 02:13:51PM -0400, Peter Xu wrote: > > > On Mon, Jul 29, 2024 at 06:26:41PM +0100, Daniel P. Berrangé wrote: > > > > On Mon, Jul 29, 2024 at 01:

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Peter Xu
On Tue, Jul 30, 2024 at 07:46:12PM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 30, 2024 at 02:13:51PM -0400, Peter Xu wrote: > > On Mon, Jul 29, 2024 at 06:26:41PM +0100, Daniel P. Berrangé wrote: > > > On Mon, Jul 29, 2024 at 01:00:30PM -0400, Peter Xu wrote: > > > > On Mon, Jul 29, 2024 at 04:

Re: [PATCH v2] hw/acpi: Add vmclock device

2024-07-30 Thread David Woodhouse
On 30 July 2024 18:53:18 BST, "Michael S. Tsirkin" wrote: >We don't want to manually sync headers with Linux. Indeed. I was briefly tempted to fake it, but figured it might get lost if we subsequently do run the script to automatically merge from Linux, before the guest driver is merged there.

Re: [PATCH] hw/acpi/ich9: Add periodic and swsmi timer

2024-07-30 Thread Michael S. Tsirkin
On Fri, Jul 19, 2024 at 12:20:53PM +0200, Dominic Prinz wrote: > This patch implements the periodic and the swsmi ICH9 chipset timer. They are > especially useful when prototyping UEFI firmware (e.g. with EDK2's OVMF) > with QEMU. > > This includes that writes to the SMI_STS register are enabled f

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Daniel P . Berrangé
On Tue, Jul 30, 2024 at 02:13:51PM -0400, Peter Xu wrote: > On Mon, Jul 29, 2024 at 06:26:41PM +0100, Daniel P. Berrangé wrote: > > On Mon, Jul 29, 2024 at 01:00:30PM -0400, Peter Xu wrote: > > > On Mon, Jul 29, 2024 at 04:58:03PM +0100, Daniel P. Berrangé wrote: > > > > > > > > We've got two mutu

Re: [PATCH v3 00/24] Convert avocado tests to normal Python unittests

2024-07-30 Thread Philippe Mathieu-Daudé
On 30/7/24 19:03, Daniel P. Berrangé wrote: This series is an update to Thomas' v2: https://lists.nongnu.org/archive/html/qemu-devel/2024-07/msg05805.html wherein Thomas suggested someone could do the asset caching updates while he is on vacation: https://lists.nongnu.org/archive/html/qe

Re: [PATCH] osdep.h: Clean up no-longer-needed back-compat for macOS 10

2024-07-30 Thread Philippe Mathieu-Daudé
On 30/7/24 11:59, Peter Maydell wrote: Our official support policy only supports the most recent two versions of macOS (currently macOS 13 Ventura and macOS 14 Sonoma), and we already have code that assumes at least macOS 12 Monterey or better. In commit 2d27c91e2b72ac7 we dropped some of the ba

Re: [PULL 00/14] Docs / testing patches for 2024-07-29

2024-07-30 Thread Philippe Mathieu-Daudé
On 30/7/24 12:14, Peter Maydell wrote: On Tue, 30 Jul 2024 at 11:05, Philippe Mathieu-Daudé wrote: On 29/7/24 17:36, Daniel P. Berrangé wrote: On Mon, Jul 29, 2024 at 05:27:00PM +0200, Philippe Mathieu-Daudé wrote: Thomas Huth (9): python: Install pycotap in our venv if necessary t

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Peter Xu
On Mon, Jul 29, 2024 at 06:26:41PM +0100, Daniel P. Berrangé wrote: > On Mon, Jul 29, 2024 at 01:00:30PM -0400, Peter Xu wrote: > > On Mon, Jul 29, 2024 at 04:58:03PM +0100, Daniel P. Berrangé wrote: > > > > > > We've got two mutually conflicting goals with the machine type > > > definitions. > >

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Peter Xu
On Tue, Jul 30, 2024 at 02:23:46AM +0900, Akihiko Odaki wrote: > On 2024/07/30 2:00, Peter Xu wrote: > > On Mon, Jul 29, 2024 at 04:58:03PM +0100, Daniel P. Berrangé wrote: > > > On Fri, Jul 26, 2024 at 04:47:40PM -0400, Peter Xu wrote: > > > > On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Be

Re: [PATCH v5 0/8] virtio-net: add support for SR-IOV emulation

2024-07-30 Thread Michael S. Tsirkin
On Tue, Jul 30, 2024 at 09:26:20PM +0900, Akihiko Odaki wrote: > On 2024/07/30 20:37, Michael S. Tsirkin wrote: > > On Mon, Jul 15, 2024 at 02:19:06PM +0900, Akihiko Odaki wrote: > > > Based-on: <20240714-rombar-v2-0-af1504ef5...@daynix.com> > > > ("[PATCH v2 0/4] hw/pci: Convert rom_bar into OnOff

Re: [PATCH v2] hw/acpi: Add vmclock device

2024-07-30 Thread Michael S. Tsirkin
> diff --git a/hw/acpi/vmclock-abi.h b/hw/acpi/vmclock-abi.h > new file mode 100644 > index 00..19cbf85efd > --- /dev/null > +++ b/hw/acpi/vmclock-abi.h > @@ -0,0 +1,186 @@ > +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR > BSD-2-Clause) */ > + > +/* > + * This structur

Re: [PATCH v6 0/6] hw/ppc: SPI model

2024-07-30 Thread Cédric Le Goater
Hello Chalapathi On 7/30/24 19:23, Chalapathi V wrote: Hello, In patch v6 below issues detected during Coverity Scan were fixed. - CID 1558831: Resource leaks (RESOURCE_LEAK) Variable "rsp_payload" going out of scope leaks the storage it points to. - CID 1558827:(OVERRUN) Overrunnin

[PATCH v6 2/6] hw/ssi: Add SPI model

2024-07-30 Thread Chalapathi V
SPI controller device model supports a connection to a single SPI responder. This provide access to SPI seeproms, TPM, flash device and an ADC controller. All SPI function control is mapped into the SPI register space to enable full control by firmware. In this commit SPI configuration component i

[PATCH v6 5/6] hw/ppc: SPI controller wiring to P10 chip

2024-07-30 Thread Chalapathi V
In this commit, create SPI controller on p10 chip and connect cs irq. The QOM tree of pnv-spi and seeprom are. /machine (powernv10-machine) /chip[0] (power10_v2.0-pnv-chip) /pib_spic[2] (pnv-spi) /pnv-spi-bus.2 (SSI) /xscom-spi[0] (memory-region) /machine (powernv10-machine) /

[PATCH v6 4/6] hw/block: Add Microchip's 25CSM04 to m25p80

2024-07-30 Thread Chalapathi V
Add Microchip's 25CSM04 Serial EEPROM to m25p80. 25CSM04 provides 4 Mbits of Serial EEPROM utilizing the Serial Peripheral Interface (SPI) compatible bus. The device is organized as 524288 bytes of 8 bits each (512Kbyte) and is optimized for use in consumer and industrial applications where reliab

[PATCH v6 6/6] tests/qtest: Add pnv-spi-seeprom qtest

2024-07-30 Thread Chalapathi V
In this commit Write a qtest pnv-spi-seeprom-test to check the SPI transactions between spi controller and seeprom device. Signed-off-by: Chalapathi V Acked-by: Cédric Le Goater Reviewed-by: Caleb Schlossin --- tests/qtest/pnv-spi-seeprom-test.c | 110 + tests/qtest

[PATCH v6 1/6] ppc/pnv: Remove ppc target dependency from pnv_xscom.h

2024-07-30 Thread Chalapathi V
In this commit target specific dependency from include/hw/ppc/pnv_xscom.h has been removed so that pnv_xscom.h can be included outside hw/ppc. Signed-off-by: Chalapathi V Reviewed-by: Cédric Le Goater Reviewed-by: Caleb Schlossin --- include/hw/ppc/pnv_xscom.h | 2 +- 1 file changed, 1 inserti

[PATCH v6 0/6] hw/ppc: SPI model

2024-07-30 Thread Chalapathi V
Hello, In patch v6 below issues detected during Coverity Scan were fixed. - CID 1558831: Resource leaks (RESOURCE_LEAK) Variable "rsp_payload" going out of scope leaks the storage it points to. - CID 1558827:(OVERRUN) Overrunning array "s->seq_op" of 8 bytes at byte offset 16 using index

[PATCH v6 3/6] hw/ssi: Extend SPI model

2024-07-30 Thread Chalapathi V
In this commit SPI shift engine and sequencer logic is implemented. Shift engine performs serialization and de-serialization according to the control by the sequencer and according to the setup defined in the configuration registers. Sequencer implements the main control logic and FSM to handle dat

[PATCH v3 24/24] gitlab-ci: Add "check-functional" to the build tests

2024-07-30 Thread Daniel P . Berrangé
From: Thomas Huth Now that we converted many tests from the "check-avocado" test suite to the "check-functional" test suite, we should make sure that these also get tested in the CI. Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- .gitlab-ci.d/buildtest-template.yml | 3 +- .g

[PATCH v3 05/24] tests/functional: Prepare the meson build system for the functional tests

2024-07-30 Thread Daniel P . Berrangé
From: Thomas Huth Provide a meson.build file for the upcoming python-based functional tests, and add some wrapper glue targets to the tests/Makefile.include file. We are going to use two "speed" modes for the functional tests: The "quick" tests can be run at any time (i.e. also during "make check

[PATCH v3 08/24] tests/functional: add a module for handling asset download & caching

2024-07-30 Thread Daniel P . Berrangé
The 'Asset' class is a simple module that declares a downloadable asset that can be cached locally. Downloads are stored in the user's home dir at ~/.cache/qemu/download, using a sha256 sum of the URL. Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/__init__.py | 1 + tests/fun

[PATCH v3 23/24] tests/functional: Convert the rx_gdbsim avocado test into a standalone test

2024-07-30 Thread Daniel P . Berrangé
From: Thomas Huth Provide a "gzip_uncompress" function based on the standard "gzip" module to avoid the usage of avocado.utils here. Signed-off-by: Thomas Huth --- tests/functional/meson.build | 4 ++ tests/functional/qemu_test/utils.py | 12 .../test_rx_gdbsim

[PATCH v3 07/24] tests/functional: Convert avocado tests that just need a small adjustment

2024-07-30 Thread Daniel P . Berrangé
From: Thomas Huth These simple tests can be converted to stand-alone tests quite easily, e.g. by just setting the machine to 'none' now manually or by adding "-cpu" command line parameters, since we don't support the corresponding avocado tags in the new python test framework. Reviewed-by: Danie

[PATCH v3 02/24] tests/functional: Add base classes for the upcoming pytest-based tests

2024-07-30 Thread Daniel P . Berrangé
From: Thomas Huth The file is mostly a copy of the tests/avocado/avocado_qemu/__init__.py file with some adjustments to get rid of the Avocado dependencies (i.e. we also have to drop the LinuxSSHMixIn and LinuxTest for now). The emulator binary and build directory are now passed via environment

[PATCH v3 16/24] tests/functional: Convert the riscv_opensbi avocado test into a standalone test

2024-07-30 Thread Daniel P . Berrangé
From: Thomas Huth The avocado test defined test functions for both, riscv32 and riscv64. Since we can run the whole file with multiple targets in the new framework, we can now consolidate the functions so we have to only define one function per machine now. Reviewed-by: Alistair Francis Signed-

[PATCH v3 20/24] tests/functional: Convert the ppc_hv avocado test into a standalone test

2024-07-30 Thread Daniel P . Berrangé
From: Thomas Huth Note: The original Avocado test seems currently to be broken, it hangs when the guest is trying to install additional packages. So mark it as broken for now until it gets fixed. Signed-off-by: Thomas Huth --- .../test_ppc64_hv.py} | 48

[PATCH v3 13/24] tests/functional: Convert the s390x avocado tests into standalone tests

2024-07-30 Thread Daniel P . Berrangé
From: Thomas Huth These tests use archive.lzma_uncompress() from the Avocado utils, so provide a small helper function for this, based on the standard lzma module from Python instead. And while we're at it, replace the MD5 hashes in the topology test with proper SHA256 hashes, since MD5 should n

[PATCH v3 17/24] tests/functional: Convert the virtio_gpu avocado test into a standalone test

2024-07-30 Thread Daniel P . Berrangé
From: Thomas Huth Nothing thrilling in here, it's just a straight forward conversion. Signed-off-by: Thomas Huth --- tests/functional/meson.build | 1 + .../test_virtio_gpu.py} | 64 +-- 2 files changed, 30 insertions(+), 35 deletions(-)

[PATCH v3 18/24] tests/functional: Convert most ppc avocado tests into standalone tests

2024-07-30 Thread Daniel P . Berrangé
From: Thomas Huth Nothing thrilling in here, just straight forward conversions. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- MAINTAINERS | 8 +-- tests/functional/meson.build | 11 .../test_ppc64_powernv.py}

[PATCH v3 00/24] Convert avocado tests to normal Python unittests

2024-07-30 Thread Daniel P . Berrangé
This series is an update to Thomas' v2: https://lists.nongnu.org/archive/html/qemu-devel/2024-07/msg05805.html wherein Thomas suggested someone could do the asset caching updates while he is on vacation: https://lists.nongnu.org/archive/html/qemu-devel/2024-07/msg06228.html hence this posti

  1   2   3   >