On 31/07/2024 8:12, Markus Armbruster wrote:
External email: Use caution opening links or attachments


Avihai Horon <avih...@nvidia.com> writes:

On 30/07/2024 15:22, Markus Armbruster wrote:
Avihai, there's a question for you on VfioMigrationState.

Daniel P. Berrangé <berra...@redhat.com> writes:

On Tue, Jul 30, 2024 at 10:10:15AM +0200, Markus Armbruster wrote:
[...]

* VfioMigrationState

    Can't see why this one has a prefix.  Avihai, can you enlighten me?
linux-headers/linux/vfio.h defines enum vfio_device_mig_state with values 
VFIO_DEVICE_STATE_STOP etc.
It does not define any VFIO_DEVICE_STATE_*, though.

I used the QAPI prefix to emphasize this is a QAPI entity rather than a VFIO 
entity.
We define about two dozen symbols starting with VFIO_, and several
hundreds starting with vfio_.  What makes this enumeration type
different so its members need emphasis?

Right. I thought it would be clearer with the QAPI prefix because VFIO_DEVICE_STATE_* and VFIO_MIGRATION_STATE_* have similar values.

But it's not a must. If you want to reduce prefix usage, go ahead, I don't have a strong opinion about it.


[...]


Reply via email to