Re: Examining device state via monitor for debugging

2024-06-10 Thread Manos Pitsidianakis
On Tue, 11 Jun 2024 at 09:11, Mark Cave-Ayland wrote: > > On 11/06/2024 06:49, Markus Armbruster wrote: > > > Philippe Mathieu-Daudé writes: > > > >> Officialise the QMP command, use the existing > >> hmp_info_human_readable_text() helper. > > > > I'm not sure "officialise" is a word :) > > > > T

答复: [PATCH] hw/net: cadence_gem: fix: type2_compare_x_word_0 error

2024-06-10 Thread andrew Yuan
Yes, Need to check whether the "offset" exceeds the "size" argument of gem_receive() in get_queue_from_screen() function; -邮件原件- 发件人: Peter Maydell 发送时间: 2024年6月6日 20:06 收件人: Edgar E. Iglesias 抄送: andrew Yuan ; luc.mic...@amd.com; alist...@alistair23.me; jasow...@redhat.com; qemu-...

答复: [PATCH] hw/net: cadence_gem: fix: type2_compare_x_word_0 error

2024-06-10 Thread andrew Yuan
OK,I will send another patch for the missing logic for the DISABLE_MASK bit; 发件人: Edgar E. Iglesias 发送时间: 2024年6月6日 19:04 收件人: andrew Yuan 抄送: luc.mic...@amd.com; alist...@alistair23.me; peter.mayd...@linaro.org; jasow...@redhat.com; qemu-...@nongnu.org; qemu-devel@nongnu.org 主题: Re: [PATCH] h

Re: [PATCH v3] i386/cpu: fixup number of addressable IDs for processor cores in the physical package

2024-06-10 Thread Zhao Liu
On Tue, Jun 11, 2024 at 11:23:14AM +0800, Chuang Xu wrote: > Date: Tue, 11 Jun 2024 11:23:14 +0800 > From: Chuang Xu > Subject: [PATCH v3] i386/cpu: fixup number of addressable IDs for processor > cores in the physical package > X-Mailer: git-send-email 2.24.3 (Apple Git-128) > > When QEMU is st

Re: Examining device state via monitor for debugging

2024-06-10 Thread Mark Cave-Ayland
On 11/06/2024 06:49, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: Officialise the QMP command, use the existing hmp_info_human_readable_text() helper. I'm not sure "officialise" is a word :) Taking a step back... "info via" and its new QMP counterpart x-query-mos6522-devices du

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

2024-06-10 Thread Manos Pitsidianakis
On Tue, 11 Jun 2024 00:38, Pierrick Bouvier wrote: Maybe it could be better if build.rs file was *not* needed for new devices/folders, and could be abstracted as a detail of the python wrapper script instead of something that should be committed. That'd mean you cannot work on the rust files

Examining device state via monitor for debugging (was: [PATCH 0/2] hw/misc/mos6522: Do not open-code hmp_info_human_readable_text())

2024-06-10 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Officialise the QMP command, use the existing > hmp_info_human_readable_text() helper. I'm not sure "officialise" is a word :) Taking a step back... "info via" and its new QMP counterpart x-query-mos6522-devices dump device state. I understand why examining de

Re: [PATCH 1/2] hw/misc/mos6522: Expose x-query-mos6522-devices QMP command

2024-06-10 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > This is a counterpart to the HMP "info via" command. It is being > added with an "x-" prefix because this QMP command is intended as an > adhoc debugging tool and will thus not be modelled in QAPI as fully > structured data, nor will it have long term guaranteed s

Re: [Stable-7.2.12 00/29] Patch Round-up for stable 7.2.12, frozen at 2024-06-07

2024-06-10 Thread Michael Tokarev
10.06.2024 15:21, Eric Blake wrote: On Mon, Jun 10, 2024 at 07:17:53AM GMT, Eric Blake wrote: In addition to these two, we also need the following for NBD: 14ddea7e3c81 Eric Blake: qio: Inherit follow_coroutine_ctx across TLS and optionally: 5905c09466f4 Eric Blake: iotests: test N

Re: qemu-riscv32 usermode still broken?

2024-06-10 Thread Alistair Francis
On Wed, Sep 20, 2023 at 6:39 AM Andreas K. Huettel wrote: > > Hi Alistair, > > > It would be great to get a strace of the failure to narrow down what > > it is. From there it should be not too hard to find and fix. > > thanks a lot. Here's as much info as I could get with strace mechanisms. > > 1)

[ANNOUNCE] QEMU 9.0.1 Stable released

2024-06-10 Thread Michael Tokarev
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi everyone, The QEMU v9.0.1 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source https://download.qemu.org/qemu-9.0.1.tar.xz https://download.qemu.org/qemu-9.0.1.tar.x

[ANNOUNCE] QEMU 7.2.12 Stable released

2024-06-10 Thread Michael Tokarev
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi everyone, The QEMU v7.2.12 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source https://download.qemu.org/qemu-7.2.12.tar.xz https://download.qemu.org/qemu-7.2.12.ta

[ANNOUNCE] QEMU 8.2.5 Stable released

2024-06-10 Thread Michael Tokarev
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi everyone, The QEMU v8.2.5 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source https://download.qemu.org/qemu-8.2.5.tar.xz https://download.qemu.org/qemu-8.2.5.tar.x

RE: [RFC v2 4/7] virtio-iommu: Compute host reserved regions

2024-06-10 Thread Duan, Zhenzhong
>-Original Message- >From: Eric Auger >Subject: [RFC v2 4/7] virtio-iommu: Compute host reserved regions > >Compute the host reserved regions in virtio_iommu_set_iommu_device(). >The usable IOVA regions are retrieved from the HOSTIOMMUDevice. >The virtio_iommu_set_host_iova_ranges() hel

RE: [RFC v2 3/7] HostIOMMUDevice: Introduce get_iova_ranges callback

2024-06-10 Thread Duan, Zhenzhong
>-Original Message- >From: Eric Auger >Subject: [RFC v2 3/7] HostIOMMUDevice: Introduce get_iova_ranges >callback > >Introduce a new HostIOMMUDevice callback that allows to >retrieve the usable IOVA ranges. > >Implement this callback in the legacy VFIO and IOMMUFD VFIO >host iommu devic

[PATCH v3] i386/cpu: fixup number of addressable IDs for processor cores in the physical package

2024-06-10 Thread Chuang Xu
When QEMU is started with: -cpu host,host-cache-info=on,l3-cache=off \ -smp 2,sockets=1,dies=1,cores=1,threads=2 Guest can't acquire maximum number of addressable IDs for processor cores in the physical package from CPUID[04H]. When creating a CPU topology of 1 core per package, host-cache-info on

RE: [RFC v2 7/7] memory: Remove IOMMU MR iommu_set_iova_range API

2024-06-10 Thread Duan, Zhenzhong
>-Original Message- >From: Eric Auger >Subject: [RFC v2 7/7] memory: Remove IOMMU MR iommu_set_iova_range >API > >Since the host IOVA ranges are now passed through the >PCIIOMMUOps set_host_resv_regions and we have removed >the only implementation of iommu_set_iova_range() in >the virti

RE: [RFC v2 6/7] hw/vfio: Remove memory_region_iommu_set_iova_ranges() call

2024-06-10 Thread Duan, Zhenzhong
>-Original Message- >From: Eric Auger >Subject: [RFC v2 6/7] hw/vfio: Remove >memory_region_iommu_set_iova_ranges() call > >As we have just removed the only implementation of >iommu_set_iova_ranges IOMMU MR callback in the virtio-iommu, >let's remove the call to the memory wrapper. Usab

RE: [RFC v2 5/7] virtio-iommu: Remove the implementation of iommu_set_iova_range

2024-06-10 Thread Duan, Zhenzhong
>-Original Message- >From: Eric Auger >Subject: [RFC v2 5/7] virtio-iommu: Remove the implementation of >iommu_set_iova_range > >Now that we use PCIIOMMUOps to convey information about usable IOVA >ranges we do not to implement the iommu_set_iova_ranges IOMMU MR >callback. > >Signed-off

RE: [RFC v2 1/7] HostIOMMUDevice: Store the VFIO/VDPA agent

2024-06-10 Thread Duan, Zhenzhong
>-Original Message- >From: Eric Auger >Subject: [RFC v2 1/7] HostIOMMUDevice: Store the VFIO/VDPA agent > >Store the agent device (VFIO or VDPA) in the host IOMMU device. >This will allow easy access to some of its resources. > >Signed-off-by: Eric Auger >--- Reviewed-by: Zhenzhong Du

Re:Re: [PATCH v5 00/10] Support persistent reservation operations

2024-06-10 Thread 卢长奇
Hi, Sorry, I explained it in patch2 and forgot to reply your email. The existing PRManager only works with local scsi devices. This series will completely decouple devices and drivers. The device can not only be scsi, but also other devices such as nvme. The same is true for the driver, which is

Re: [External] Re: [PATCH v5 01/10] block: add persistent reservation in/out api

2024-06-10 Thread 卢长奇
Hi, Thanks for your advices! I will add it. On 2024/6/11 01:26, Stefan Hajnoczi wrote: > On Thu, Jun 06, 2024 at 08:24:35PM +0800, Changqi Lu wrote: >> Add persistent reservation in/out operations >> at the block level. The following operations >> are included: >> >> - read_keys: retrieves the li

RE: [RFC v2 2/7] virtio-iommu: Implement set|unset]_iommu_device() callbacks

2024-06-10 Thread Duan, Zhenzhong
Hi Eric, >-Original Message- >From: Eric Auger >Subject: [RFC v2 2/7] virtio-iommu: Implement set|unset]_iommu_device() >callbacks > >Implement PCIIOMMUOPs [set|unset]_iommu_device() callbacks. >In set(), a VirtioHostIOMMUDevice is allocated which holds >a reference to the HostIOMMUDevice

RE: [PATCH v7 00/17] Add a host IOMMU device abstraction to check with vIOMMU

2024-06-10 Thread Duan, Zhenzhong
>-Original Message- >From: Eric Auger >Subject: Re: [PATCH v7 00/17] Add a host IOMMU device abstraction to >check with vIOMMU > >Hi Zhenzhong, > >On 6/5/24 10:30, Zhenzhong Duan wrote: >> Hi, >> >> This series introduce a HostIOMMUDevice abstraction and sub-classes. >> Also HostIOMMUDev

Re: [PULL 06/10] hw/loongarch: Refine fwcfg memory map

2024-06-10 Thread maobibo
On 2024/6/7 下午10:31, Peter Maydell wrote: On Thu, 23 May 2024 at 02:48, Song Gao wrote: From: Bibo Mao Memory map table for fwcfg is used for UEFI BIOS, UEFI BIOS uses the first entry from fwcfg memory map as the first memory HOB, the second memory HOB will be used if the first memory HOB

Re: [PATCH RESEND 1/6] target/riscv: Introduce extension implied rules definition

2024-06-10 Thread Frank Chang
Hi Alistair, On Tue, Jun 11, 2024 at 9:35 AM Alistair Francis wrote: > On Wed, Jun 5, 2024 at 4:35 PM wrote: > > > > From: Frank Chang > > > > RISCVCPUImpliedExtsRule is created to store the implied rules. > > 'is_misa' flag is used to distinguish whether the rule is derived > > from the MISA

Re: [PATCH v3 00/13] riscv: QEMU RISC-V IOMMU Support

2024-06-10 Thread LIU Zhiwei
Hi Daniel, I want to know if we can use the IOMMU and IOPMP at the same time. The relationship between them is more similar to MMU and sPMP or to MMU and PMP? Thanks, Zhiwei On 2024/5/24 1:39, Daniel Henrique Barboza wrote: Hi, In this new version a lot of changes were made throughout all

Re: [PATCH RESEND 4/6] target/riscv: Add standard extension implied rules

2024-06-10 Thread Alistair Francis
On Wed, Jun 5, 2024 at 4:35 PM wrote: > > From: Frank Chang > > Add standard extension implied rules to enable the implied extensions of > the standard extension recursively. > > Signed-off-by: Frank Chang Acked-by: Alistair Francis Alistair > --- > target/riscv/cpu.c | 340

Re: [PATCH RESEND 3/6] target/riscv: Add MISA implied rules

2024-06-10 Thread Alistair Francis
On Wed, Jun 5, 2024 at 4:34 PM wrote: > > From: Frank Chang > > Add MISA extension implied rules to enable the implied extensions > of MISA recursively. > > Signed-off-by: Frank Chang Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu.c | 50

Re: [PATCH RESEND 1/6] target/riscv: Introduce extension implied rules definition

2024-06-10 Thread Alistair Francis
On Wed, Jun 5, 2024 at 4:35 PM wrote: > > From: Frank Chang > > RISCVCPUImpliedExtsRule is created to store the implied rules. > 'is_misa' flag is used to distinguish whether the rule is derived > from the MISA or other extensions. > 'ext' stores the MISA bit if 'is_misa' is true. Otherwise, it s

Re: [PATCH v3 00/13] riscv: QEMU RISC-V IOMMU Support

2024-06-10 Thread Alistair Francis
On Tue, Jun 11, 2024 at 5:16 AM Daniel Henrique Barboza wrote: > > > > On 6/10/24 3:32 PM, Andrew Jones wrote: > > On June 10, 2024 2:34:58 AM GMT+02:00, Alistair Francis > > wrote: > >> On Fri, May 24, 2024 at 3:43 AM Daniel Henrique Barboza > >> wrote: > >>> > >>> Hi, > >>> > >>> In this new

Re: [PATCH v3 4/5] target/riscv: Restrict semihosting to TCG

2024-06-10 Thread Alistair Francis
On Tue, Jun 11, 2024 at 12:59 AM Philippe Mathieu-Daudé wrote: > > Semihosting currently uses the TCG probe_access API. To prepare for > encoding the TCG dependency in Kconfig, do not enable it unless TCG > is available. > > Suggested-by: Paolo Bonzini > Signed-off-by: Philippe Mathieu-Daudé > R

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

2024-06-10 Thread Pierrick Bouvier
On 6/10/24 13:29, Manos Pitsidianakis wrote: On Mon, 10 Jun 2024 22:37, Pierrick Bouvier wrote: Hello Manos, On 6/10/24 11:22, Manos Pitsidianakis wrote: Hello everyone, This is an early draft of my work on implementing a very simple device, in this case the ARM PL011 (which in C code reside

Re: [PATCH 1/3] hw/s390x: Declare target specific monitor commands in hmp-target.h

2024-06-10 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@linaro.org) wrote: > "monitor/hmp-target.h" is meant to hold target-specific commands. > Move s390x specific commands there, slightly simplifying hmp-target.c. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/s390x/storage-attributes.h | 4 > inc

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

2024-06-10 Thread Stefan Hajnoczi
On Mon, 10 Jun 2024 at 16:27, Manos Pitsidianakis wrote: > > On Mon, 10 Jun 2024 22:59, Stefan Hajnoczi wrote: > >> What are the issues with not using the compiler, rustc, directly? > >> - > >> [whataretheissueswith] Back to [TOC] >

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

2024-06-10 Thread Manos Pitsidianakis
On Mon, 10 Jun 2024 22:37, Pierrick Bouvier wrote: Hello Manos, On 6/10/24 11:22, Manos Pitsidianakis wrote: Hello everyone, This is an early draft of my work on implementing a very simple device, in this case the ARM PL011 (which in C code resides in hw/char/pl011.c and is used in hw/arm/vir

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

2024-06-10 Thread Manos Pitsidianakis
On Mon, 10 Jun 2024 22:59, Stefan Hajnoczi wrote: What are the issues with not using the compiler, rustc, directly? - [whataretheissueswith] Back to [TOC] 1. Tooling Mostly writing up the build-sys tooling to do so. Ideally we'd

Re: [PATCH v2 18/18] migration/ram: Add direct-io support to precopy file migration

2024-06-10 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Jun 10, 2024 at 02:45:53PM -0300, Fabiano Rosas wrote: >> >> AIUI, the issue here that users are already allowed to specify in >> >> libvirt the equivalent to direct-io and multifd independent of each >> >> other (bypass-cache, parallel). To start requiring both togethe

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

2024-06-10 Thread Stefan Hajnoczi
On Mon, 10 Jun 2024 at 14:23, Manos Pitsidianakis wrote: > > Hello everyone, > > This is an early draft of my work on implementing a very simple device, > in this case the ARM PL011 (which in C code resides in hw/char/pl011.c > and is used in hw/arm/virt.c). > > The device is functional, with copi

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

2024-06-10 Thread Pierrick Bouvier
Hello Manos, On 6/10/24 11:22, Manos Pitsidianakis wrote: Hello everyone, This is an early draft of my work on implementing a very simple device, in this case the ARM PL011 (which in C code resides in hw/char/pl011.c and is used in hw/arm/virt.c). The device is functional, with copied logic fr

Re: [PATCH] hw/openrisc: Fixed undercounting of TTCR in continuous mode

2024-06-10 Thread Joel Holdsworth
Hi Stafford, thanks for your response. > - You sent this 2 times, is the only change in v2 the sender address? Yes, I was just having some difficulty with Git and SMTP. Should be fixed now. >> In the existing design, TTCR is prone to undercounting when running in >> continuous mode. This manife

Re: [PATCH v3 00/13] riscv: QEMU RISC-V IOMMU Support

2024-06-10 Thread Daniel Henrique Barboza
On 6/10/24 3:32 PM, Andrew Jones wrote: On June 10, 2024 2:34:58 AM GMT+02:00, Alistair Francis wrote: On Fri, May 24, 2024 at 3:43 AM Daniel Henrique Barboza wrote: Hi, In this new version a lot of changes were made throughout all the code, most notably on patch 3. Link for the previou

Re: [PATCH v2 18/18] migration/ram: Add direct-io support to precopy file migration

2024-06-10 Thread Daniel P . Berrangé
On Mon, Jun 10, 2024 at 03:02:10PM -0400, Peter Xu wrote: > On Mon, Jun 10, 2024 at 02:45:53PM -0300, Fabiano Rosas wrote: > > >> AIUI, the issue here that users are already allowed to specify in > > >> libvirt the equivalent to direct-io and multifd independent of each > > >> other (bypass-cache,

Re: [PATCH v2 18/18] migration/ram: Add direct-io support to precopy file migration

2024-06-10 Thread Peter Xu
On Mon, Jun 10, 2024 at 02:45:53PM -0300, Fabiano Rosas wrote: > >> AIUI, the issue here that users are already allowed to specify in > >> libvirt the equivalent to direct-io and multifd independent of each > >> other (bypass-cache, parallel). To start requiring both together now in > >> some situa

Re: [PATCH v2 4/7] migration/multifd: Add UADK initialization

2024-06-10 Thread Fabiano Rosas
Shameer Kolothum via writes: > Initialize UADK session and allocate buffers required. The actual > compression/decompression will only be done in a subsequent patch. > > Signed-off-by: Shameer Kolothum Reviewed-by: Fabiano Rosas

Re: [PATCH v3 00/13] riscv: QEMU RISC-V IOMMU Support

2024-06-10 Thread Andrew Jones
On June 10, 2024 2:34:58 AM GMT+02:00, Alistair Francis wrote: >On Fri, May 24, 2024 at 3:43 AM Daniel Henrique Barboza > wrote: >> >> Hi, >> >> In this new version a lot of changes were made throughout all the code, >> most notably on patch 3. Link for the previous version is [1]. >> >> * How it

Re: [PATCH v3 2/5] target/xtensa: Restrict semihosting to TCG

2024-06-10 Thread Max Filippov
On Mon, Jun 10, 2024 at 04:58:04PM +0200, Philippe Mathieu-Daudé wrote: > The semihosting feature depends on TCG (due to the probe_access > API access). Although TCG is the single accelerator currently > available for the xtensa target, use the Kconfig "imply" directive > which is more correct (if

Re: [RFC PATCH 2/3] monitor: Allow passing HMP arguments to QMP HumanReadableText API

2024-06-10 Thread Daniel P . Berrangé
On Mon, Jun 10, 2024 at 07:58:51PM +0200, Philippe Mathieu-Daudé wrote: > Allow HMP commands implemented using the HumanReadableText API > (via the HMPCommand::cmd_info_hrt handler) to pass arguments > to the QMP equivalent command. The arguments are serialized as > a JSON dictionary. > > Signed-o

[RFC PATCH v1 4/6] DO NOT MERGE: replace TYPE_PL011 with x-pl011-rust in arm virt machine

2024-06-10 Thread Manos Pitsidianakis
Signed-off-by: Manos Pitsidianakis --- hw/arm/virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 3c93c0c0a6..153be0f42d 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -912,7 +912,7 @@ static void create_uart(const VirtMachineState *vm

[RFC PATCH v1 6/6] DO NOT MERGE: update rustdoc gitlab pages gen

2024-06-10 Thread Manos Pitsidianakis
Signed-off-by: Manos Pitsidianakis --- .gitlab-ci.d/buildtest.yml | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 1cd6519506..da882813b8 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buil

[RFC PATCH v1 3/6] DO NOT MERGE: add rustdoc build for gitlab pages

2024-06-10 Thread Manos Pitsidianakis
Signed-off-by: Manos Pitsidianakis --- .gitlab-ci.d/buildtest.yml | 55 +- 1 file changed, 36 insertions(+), 19 deletions(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 91c57efded..1cd6519506 100644 --- a/.gitlab-ci.d/buildtest.y

[RFC PATCH v1 0/6] Implement ARM PL011 in Rust

2024-06-10 Thread Manos Pitsidianakis
Hello everyone, This is an early draft of my work on implementing a very simple device, in this case the ARM PL011 (which in C code resides in hw/char/pl011.c and is used in hw/arm/virt.c). The device is functional, with copied logic from the C code but with effort not to make a direct C to Ru

[RFC PATCH v1 1/6] build-sys: Add rust feature option

2024-06-10 Thread Manos Pitsidianakis
Add options for Rust in meson_options.txt, meson.build, configure to prepare for adding Rust code in the followup commits. `rust` is a reserved meson name, so we have to use an alternative. `with_rust` was chosen. Signed-off-by: Manos Pitsidianakis --- The cargo wrapper script hardcodes some rus

[PATCH 1/3] hw/s390x: Declare target specific monitor commands in hmp-target.h

2024-06-10 Thread Philippe Mathieu-Daudé
"monitor/hmp-target.h" is meant to hold target-specific commands. Move s390x specific commands there, slightly simplifying hmp-target.c. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/s390x/storage-attributes.h | 4 include/hw/s390x/storage-keys.h | 4 include/monitor/hmp-t

[RFC PATCH 2/3] monitor: Allow passing HMP arguments to QMP HumanReadableText API

2024-06-10 Thread Philippe Mathieu-Daudé
Allow HMP commands implemented using the HumanReadableText API (via the HMPCommand::cmd_info_hrt handler) to pass arguments to the QMP equivalent command. The arguments are serialized as a JSON dictionary. Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/writing-monitor-commands.rst | 15 +++

Re: [PATCH 0/5] trace: Remove and forbid newline characters in event format

2024-06-10 Thread Philippe Mathieu-Daudé
On 10/6/24 19:05, Stefan Hajnoczi wrote: On Thu, Jun 06, 2024 at 12:39:38PM +0200, Philippe Mathieu-Daudé wrote: Trace events aren't designed to be multi-lines. Few format use the newline character: remove it and forbid further uses. Philippe Mathieu-Daudé (5): backends/tpm: Remove newline c

[RFC PATCH 3/3] hw/s390x: Introduce x-query-s390x-cmma QMP command

2024-06-10 Thread Philippe Mathieu-Daudé
This is a counterpart to the HMP "info cmma" command. It is being added with an "x-" prefix because this QMP command is intended as an adhoc debugging tool and will thus not be modelled in QAPI as fully structured data, nor will it have long term guaranteed stability. The existing HMP command is re

[RFC PATCH 0/3] monitor: Pass HMP arguments to QMP HumanReadableText API as JSON

2024-06-10 Thread Philippe Mathieu-Daudé
Current HMPCommand::cmd_info_hrt() handlers don't allow passing arguments from the monitor. This series pass them to the underlying QMP commands as a JSON dictionary, easily deserialized as QDict, similarly to how current HMP commands receive their arguments. Thus very few changes are required to p

Re: [PATCH qemu ] hw/acpi: Fix big endian host creation of Generic Port Affinity Structures

2024-06-10 Thread Jonathan Cameron via
Hi Igor, Some code snippets below to try and see if I'm on the correct track for what you had in mind. > > > > > diff --git a/hw/acpi/acpi_generic_initiator.c > > > b/hw/acpi/acpi_generic_initiator.c > > > index 78b80dcf08..f064753b67 100644 > > > --- a/hw/acpi/acpi_generic_initiator.c > >

Re: [PATCH v2 18/18] migration/ram: Add direct-io support to precopy file migration

2024-06-10 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Jun 07, 2024 at 03:42:35PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Thu, May 23, 2024 at 04:05:48PM -0300, Fabiano Rosas wrote: >> >> We've recently added support for direct-io with multifd, which brings >> >> performance benefits, but creates a non-

Re: [PATCH v5 01/10] block: add persistent reservation in/out api

2024-06-10 Thread Stefan Hajnoczi
On Thu, Jun 06, 2024 at 08:24:35PM +0800, Changqi Lu wrote: > Add persistent reservation in/out operations > at the block level. The following operations > are included: > > - read_keys:retrieves the list of registered keys. > - read_reservation: retrieves the current reservation status. >

Re: [PATCH v5 00/10] Support persistent reservation operations

2024-06-10 Thread Stefan Hajnoczi
On Thu, Jun 06, 2024 at 08:24:34PM +0800, Changqi Lu wrote: > Hi, > > patchv5 has been modified. > > Sincerely hope that everyone can help review the > code and provide some suggestions. > > v4->v5: > - Fixed a memory leak bug at hw/nvme/ctrl.c. > > v3->v4: > - At the nvme layer, the two patch

[PULL 5/6] hw/vfio: Remove newline character in trace events

2024-06-10 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Trace events aren't designed to be multi-lines. Remove the newline characters. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Mads Ynddal Reviewed-by: Daniel P. Berrangé Message-id: 20240606103943.79116-5-phi...@linaro.org Signed-off-by: Stefan Hajnoczi --- hw/

[PULL 6/6] tracetool: Forbid newline character in event format

2024-06-10 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Events aren't designed to be multi-lines. Multiple events can be used instead. Prevent that format using multi-lines by forbidding the newline character. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Mads Ynddal Reviewed-by: Daniel P. Berrangé Message-id: 202406

[PULL 4/6] hw/usb: Remove newline character in trace events

2024-06-10 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Trace events aren't designed to be multi-lines. Remove the newline characters. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Mads Ynddal Reviewed-by: Daniel P. Berrangé Message-id: 20240606103943.79116-4-phi...@linaro.org Signed-off-by: Stefan Hajnoczi --- hw/

Re: [PATCH 11/25] target/i386: replace read_crN helper with read_cr8

2024-06-10 Thread Paolo Bonzini
On Sat, Jun 8, 2024 at 8:46 PM Richard Henderson wrote: > > On 6/8/24 01:40, Paolo Bonzini wrote: > > All other control registers are stored plainly in CPUX86State. > > s/stored/read/ I mean the CPUX86State is their storage and it's plain. :) Paolo > > Reviewed-by: Richard Henderson > > > r~ >

[PULL 3/6] hw/sh4: Remove newline character in trace events

2024-06-10 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Trace events aren't designed to be multi-lines. Remove the newline character which doesn't bring much value. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Mads Ynddal Reviewed-by: Daniel P. Berrangé Message-id: 20240606103943.79116-3-phi...@linaro.org Signed-off

[PULL 2/6] backends/tpm: Remove newline character in trace event

2024-06-10 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Split the 'tpm_util_show_buffer' event in two to avoid using a newline character. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Mads Ynddal Reviewed-by: Daniel P. Berrangé Reviewed-by: Stefan Berger Message-id: 20240606103943.79116-2-phi...@linaro.org Signed-of

[PULL 1/6] tracetool: Remove unused vcpu.py script

2024-06-10 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé vcpu.py is pointless since commit 89aafcf2a7 ("trace: remove code that depends on setting vcpu"), remote it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Reviewed-by: Zhao Liu Message-id: 20240606102631.78152-1-phi...@linaro.org Signed-off

[PULL 0/6] Tracing patches

2024-06-10 Thread Stefan Hajnoczi
The following changes since commit 80e8f0602168f451a93e71cbb1d59e93d745e62e: Merge tag 'bsd-user-misc-2024q2-pull-request' of gitlab.com:bsdimp/qemu into staging (2024-06-09 11:21:55 -0700) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/tracing-pull-reques

Re: [PATCH 24/25] target/i386: do not check PREFIX_LOCK in old-style decoder

2024-06-10 Thread Paolo Bonzini
On Sat, Jun 8, 2024 at 10:16 PM Richard Henderson wrote: > > On 6/8/24 01:41, Paolo Bonzini wrote: > > It is already checked before getting there. > > > > Signed-off-by: Paolo Bonzini > > --- > > target/i386/tcg/translate.c | 26 -- > > 1 file changed, 8 insertions(+), 1

Re: [PATCH 2/2] hw/misc/mos6522: Do not open-code hmp_info_human_readable_text()

2024-06-10 Thread Daniel P . Berrangé
On Mon, Jun 10, 2024 at 05:07:58PM +0200, Philippe Mathieu-Daudé wrote: > Register the command 'info via' using HMPCommand::cmd_info_hrt(), > so it is processed using the generic hmp_info_human_readable_text(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/misc/mos6522.h| 2 -

Re: [PATCH 1/2] hw/misc/mos6522: Expose x-query-mos6522-devices QMP command

2024-06-10 Thread Daniel P . Berrangé
On Mon, Jun 10, 2024 at 05:07:57PM +0200, Philippe Mathieu-Daudé wrote: > This is a counterpart to the HMP "info via" command. It is being > added with an "x-" prefix because this QMP command is intended as an > adhoc debugging tool and will thus not be modelled in QAPI as fully > structured data,

Re: [PATCH 0/5] trace: Remove and forbid newline characters in event format

2024-06-10 Thread Stefan Hajnoczi
On Thu, Jun 06, 2024 at 12:39:38PM +0200, Philippe Mathieu-Daudé wrote: > Trace events aren't designed to be multi-lines. > Few format use the newline character: remove it > and forbid further uses. > > Philippe Mathieu-Daudé (5): > backends/tpm: Remove newline character in trace event > hw/sh

[PATCH v2] scsi-disk: Fix crash for VM configured with USB CDROM after live migration

2024-06-10 Thread Paolo Bonzini
From: Hyman Huang For VMs configured with the USB CDROM device: -drive file=/path/to/local/file,id=drive-usb-disk0,media=cdrom,readonly=on... -device usb-storage,drive=drive-usb-disk0,id=usb-disk0... QEMU process may crash after live migration, to reproduce the issue, configure VM (Guest OS ubu

Re: [PATCH v4 00/15] vfio: VFIO migration support with vIOMMU

2024-06-10 Thread Cédric Le Goater
On 6/7/24 5:10 PM, Joao Martins wrote: On 06/06/2024 16:43, Cédric Le Goater wrote: Hello Joao, On 6/22/23 23:48, Joao Martins wrote: Hey, This series introduces support for vIOMMU with VFIO device migration, particurlarly related to how we do the dirty page tracking. Today vIOMMUs serve two

Re: [PATCH v4 4/4] iotests: Add `vvfat` tests

2024-06-10 Thread Kevin Wolf
Am 10.06.2024 um 16:11 hat Amjad Alsharafi geschrieben: > On Mon, Jun 10, 2024 at 02:01:24PM +0200, Kevin Wolf wrote: > > With the updated test, I can catch the problems that are fixed by > > patches 1 and 2, but it still doesn't need patch 3 to pass. > > > > Kevin > > > > Thanks for reviewing,

Re: [PATCH v4 2/4] vvfat: Fix usage of `info.file.offset`

2024-06-10 Thread Kevin Wolf
Am 05.06.2024 um 02:58 hat Amjad Alsharafi geschrieben: > The field is marked as "the offset in the file (in clusters)", but it > was being used like this > `cluster_size*(nums)+mapping->info.file.offset`, which is incorrect. > > Additionally, removed the `abort` when `first_mapping_index` does no

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-06-10 Thread Peter Xu
On Fri, Jun 07, 2024 at 08:49:01AM +, Gonglei (Arei) wrote: > Actually we tried this solution, but it didn't work. Pls see patch 3/6 > > Known limitations: > For a blocking rsocket fd, if we use io_create_watch to wait for > POLLIN or POLLOUT events, since the rsocket fd is blocking, we >

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-06-10 Thread Peter Xu
On Fri, Jun 07, 2024 at 08:28:29AM +, Gonglei (Arei) wrote: > > > > -Original Message- > > From: Jinpu Wang [mailto:jinpu.w...@ionos.com] > > Sent: Friday, June 7, 2024 1:54 PM > > To: Gonglei (Arei) > > Cc: qemu-devel@nongnu.org; pet...@redhat.com; yu.zh...@ionos.com; > > mgal...@ak

[PATCH v2 1/3] hw/arm/virt: Add serial aliases in DTB

2024-06-10 Thread Peter Maydell
If there is more than one UART in the DTB, then there is no guarantee on which order a guest is supposed to initialise them. The standard solution to this is "serialN" entries in the "/aliases" node of the dtb which give the nodename of the UARTs. At the moment we only have two UARTs in the DTB w

[PATCH v2 2/3] hw/arm/virt: Rename VIRT_UART and VIRT_SECURE_UART to VIRT_UART[01]

2024-06-10 Thread Peter Maydell
We're going to make the second UART not always a secure-only device. Rename the constants VIRT_UART and VIRT_SECURE_UART to VIRT_UART0 and VIRT_UART1 accordingly. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- include/hw/arm/virt.h| 4 ++-- hw/arm/virt-acpi-build.c |

[PATCH v2 3/3] hw/arm/virt: allow creation of a second NonSecure UART

2024-06-10 Thread Peter Maydell
For some use-cases, it is helpful to have more than one UART available to the guest. If the second UART slot is not already used for a TrustZone Secure-World-only UART, create it as a NonSecure UART only when the user provides a serial backend (e.g. via a second -serial command line option). Thi

[PATCH v2 0/3] hw/arm: Create second NonSecure UART for virt board

2024-06-10 Thread Peter Maydell
This is v2 of a series I posted back in October last year: https://patchew.org/QEMU/20231023161532.2729084-1-peter.mayd...@linaro.org/ At the time I wanted to wait until EDK2 had been updated so it didn't behave weirdly in the presence of a second UART. That happened at the tail end of last year,

Re: [PATCH v2 18/18] migration/ram: Add direct-io support to precopy file migration

2024-06-10 Thread Peter Xu
On Fri, Jun 07, 2024 at 03:42:35PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Thu, May 23, 2024 at 04:05:48PM -0300, Fabiano Rosas wrote: > >> We've recently added support for direct-io with multifd, which brings > >> performance benefits, but creates a non-uniform user interface by

[PATCH v4 3/3] tests/qtest/x86: check for availability of older cpu models before running tests

2024-06-10 Thread Ani Sinha
It is better to check if some older cpu models like 486, athlon, pentium, penryn, phenom, core2duo etc are available before running their corresponding tests. Some downstream distributions may no longer support these older cpu models. Signature of add_feature_test() has been modified to return voi

[PATCH v3 2/3] tests/qtest/libqtest: add qtest_has_cpu_model() api

2024-06-10 Thread Ani Sinha
Added a new test api qtest_has_cpu_model() in order to check availability of some cpu models in the current QEMU binary. The specific architecture of the QEMU binary is selected using the QTEST_QEMU_BINARY environment variable. This api would be useful to run tests against some older cpu models aft

[PATCH v4 0/3] x86 cpu test refactoring

2024-06-10 Thread Ani Sinha
Add a new library api to check for the support of a specific cpu type. Used the new api to check support for some older x86 cpu models before running the tests. CC: th...@redhat.com CC: imamm...@redhat.com CC: qemu-devel@nongnu.org CC: pbonz...@redhat.com CC: lviv...@redhat.com CC: m...@redhat.com

[PATCH 1/3] qtest/x86/numa-test: do not use the obsolete 'pentium' cpu

2024-06-10 Thread Ani Sinha
'pentium' cpu is old and obsolete and should be avoided for running tests if its not strictly needed. Use 'max' cpu instead for generic non-cpu specific numa test. CC: th...@redhat.com Reviewed-by: Thomas Huth Reviewed-by: Igor Mammedov Signed-off-by: Ani Sinha --- tests/qtest/numa-test.c | 3

Re: Historical QMP schema

2024-06-10 Thread John Snow
On Mon, Jun 10, 2024 at 9:39 AM Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Jun 06, 2024 at 01:22:14PM -0400, John Snow wrote: > >> On Thu, Jun 6, 2024 at 6:25 AM Victor Toso > wrote: > >> > On Wed, Jun 05, 2024 at 11:47:53AM GMT, John Snow wrote: > >> Importantly, old v

[PATCH 0/2] hw/misc/mos6522: Do not open-code hmp_info_human_readable_text()

2024-06-10 Thread Philippe Mathieu-Daudé
Officialise the QMP command, use the existing hmp_info_human_readable_text() helper. Philippe Mathieu-Daudé (2): hw/misc/mos6522: Expose x-query-mos6522-devices QMP command hw/misc/mos6522: Do not open-code hmp_info_human_readable_text() MAINTAINERS | 2 +- qapi/machine.jso

[PATCH 2/2] hw/misc/mos6522: Do not open-code hmp_info_human_readable_text()

2024-06-10 Thread Philippe Mathieu-Daudé
Register the command 'info via' using HMPCommand::cmd_info_hrt(), so it is processed using the generic hmp_info_human_readable_text(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/mos6522.h| 2 -- include/monitor/hmp-target.h | 1 - hw/misc/mos6522.c| 13 --

[PATCH 1/2] hw/misc/mos6522: Expose x-query-mos6522-devices QMP command

2024-06-10 Thread Philippe Mathieu-Daudé
This is a counterpart to the HMP "info via" command. It is being added with an "x-" prefix because this QMP command is intended as an adhoc debugging tool and will thus not be modelled in QAPI as fully structured data, nor will it have long term guaranteed stability. Signed-off-by: Philippe Mathie

[PATCH v3 3/5] target/mips: Restrict semihosting to TCG

2024-06-10 Thread Philippe Mathieu-Daudé
Semihosting currently uses the TCG probe_access API. To prepare for encoding the TCG dependency in Kconfig, do not enable it unless TCG is available. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anton Johansson --- target/mips/Kconfig | 2 +- 1 file changed, 1

[PATCH v3 2/5] target/xtensa: Restrict semihosting to TCG

2024-06-10 Thread Philippe Mathieu-Daudé
The semihosting feature depends on TCG (due to the probe_access API access). Although TCG is the single accelerator currently available for the xtensa target, use the Kconfig "imply" directive which is more correct (if we were to support a different accel). Reported-by: Anton Johansson Signed-off

[PATCH v3 4/5] target/riscv: Restrict semihosting to TCG

2024-06-10 Thread Philippe Mathieu-Daudé
Semihosting currently uses the TCG probe_access API. To prepare for encoding the TCG dependency in Kconfig, do not enable it unless TCG is available. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anton Johansson --- target/riscv/Kconfig | 4 ++-- 1 file changed

[PATCH v3 5/5] semihosting: Restrict to TCG

2024-06-10 Thread Philippe Mathieu-Daudé
Semihosting currently uses the TCG probe_access API. It is pointless to have it in the binary when TCG isn't. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- semihosting/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/semihosting/Kconfig b/semihosting/Kconfi

[PATCH v3 1/5] target/m68k: Restrict semihosting to TCG

2024-06-10 Thread Philippe Mathieu-Daudé
The semihosting feature depends on TCG (due to the probe_access API access). Although TCG is the single accelerator currently available for the m68k target, use the Kconfig "imply" directive which is more correct (if we were to support a different accel). Reported-by: Anton Johansson Signed-off-b

[PATCH v3 0/5] semihosting: Restrict to TCG

2024-06-10 Thread Philippe Mathieu-Daudé
v3: Address Anton's comment v2: Address Paolo's comment Semihosting currently uses the TCG probe_access API, so it is pointless to have it in the binary when TCG isn't. It could be implemented for other accelerators, but work need to be done. Meanwhile, do not enable it unless TCG is available.

Re: [PATCH v2 1/3] target/mips: Restrict semihosting to TCG

2024-06-10 Thread Philippe Mathieu-Daudé
On 10/6/24 11:29, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 7/6/24 13:08, Anton Johansson wrote: On 30/05/24, Philippe Mathieu-Daudé wrote: Semihosting currently uses the TCG probe_access API. To prepare for encoding the TCG dependency in Kconfig, do not enable it unless TCG is av

  1   2   >