[PATCH] qga-win: Fix guest-get-fsinfo multi-disks collection

2023-12-26 Thread peng . ji
From: Peng Ji When a volume has more than one disk, all disks cannot be returned correctly because there is not enough malloced memory for disk extents, so before executing DeviceIoControl for the second time, get the correct size of the required memory space to store all disk extents. Signed-of

[PATCH] qga-win: Fix guest-get-fsinfo multi-disks collection

2023-12-26 Thread peng . ji
From: Peng Ji When a volume has more than one disk, all disks cannot be returned correctly because there is not enough malloced memory for disk extents, so before executing DeviceIoControl for the second time, get the correct size of the required memory space to store all disk extents. Signed-of

[Bug 1119281] Re: The virtio network device breaks UuidCreateSequential()

2023-12-26 Thread Not Applicable
The issue is still there in 2023. Well since XP's source code had been leaked. I've gone through the source code and may have found the cause. Nowadays UuidCreateSequential should use MAC address when available. Here I quoted from the link below: "For security reasons, UuidCreate was modified so

[Bug 1119281] Re: The virtio network device breaks UuidCreateSequential()

2023-12-26 Thread Not Applicable
-- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1119281 Title: The virtio network device breaks UuidCreateSequential() Status in QEMU: Expired Bug description: UuidCreateSequential() usually cre

[Bug 1119281] Re: The virtio network device breaks UuidCreateSequential()

2023-12-26 Thread Not Applicable
The issue is still there in 2023. Well since XP's source code had been leaked. I've gone through the source code and may have found the cause. Nowadays UuidCreateSequential should use MAC address when available. Here I quoted from the link below: "For security reasons, UuidCreate was modified so

Re: [PATCH] docs/devel: Document conventional file prefixes and suffixes

2023-12-26 Thread Zhao Liu
Hi Philippe, On Tue, Dec 26, 2023 at 04:04:41PM +0100, Philippe Mathieu-Daudé wrote: > Date: Tue, 26 Dec 2023 16:04:41 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH] docs/devel: Document conventional file prefixes and > suffixes > X-Mailer: git-send-email 2.41.0 > > Some header and sou

Re: [External] Re: [PATCH v2 11/20] util/dsa: Implement DSA task asynchronous submission and wait for completion.

2023-12-26 Thread Hao Xiang
On Wed, Dec 13, 2023 at 6:01 AM Fabiano Rosas wrote: > > Hao Xiang writes: > > > * Add a DSA task completion callback. > > * DSA completion thread will call the tasks's completion callback > > on every task/batch task completion. > > * DSA submission path to wait for completion. > > * Implement C

Re: [External] Re: [PATCH v2 07/20] util/dsa: Implement DSA device start and stop logic.

2023-12-26 Thread Hao Xiang
On Tue, Dec 19, 2023 at 5:19 AM Fabiano Rosas wrote: > > Hao Xiang writes: > > >> > >> > +} > >> > + > >> > +void dsa_start(void) {} > >> > + > >> > +void dsa_stop(void) {} > >> > + > >> > +void dsa_cleanup(void) {} > >> > + > >> > +#endif > >> > >> These could all be in the header. > > > > The f

Re: [PATCH v4 2/4] Add RISC-V IOPMP support

2023-12-26 Thread Ethan Chen via
On Mon, Dec 18, 2023 at 02:04:06PM +1000, Alistair Francis wrote: > On Wed, Nov 22, 2023 at 3:35 PM Ethan Chen via wrote: > > > > Support specification Version 1.0.0-draft4 rapid-k model. > > The specification url: > > https://github.com/riscv-non-isa/iopmp-spec/blob/main/riscv_iopmp_specification

Re: [External] Re: [PATCH v2 08/20] util/dsa: Implement DSA task enqueue and dequeue.

2023-12-26 Thread Hao Xiang
On Tue, Dec 12, 2023 at 8:10 AM Fabiano Rosas wrote: > > Hao Xiang writes: > > > * Use a safe thread queue for DSA task enqueue/dequeue. > > * Implement DSA task submission. > > * Implement DSA batch task submission. > > > > Signed-off-by: Hao Xiang > > --- > > include/qemu/dsa.h | 35

Re: [PATCH v3 2/2] linux-user: Fix openat() emulation to not modify atime

2023-12-26 Thread Shu-Chun Weng
ping~ On Fri, Dec 8, 2023 at 2:42 PM Shu-Chun Weng wrote: > Commit b8002058 strengthened openat()'s /proc detection by calling > realpath(3) on the given path, which allows various paths and symlinks > that points to the /proc file system to be intercepted correctly. > > Using realpath(3), thoug

Re: [PULL 0/7] Trivial patches for 2023-12-25

2023-12-26 Thread Michael Tokarev
26.12.2023 18:39, Philippe Mathieu-Daudé: .. Stefan Weil via (1):    virtio-blk: Fix potential nullpointer read access in virtio_blk_data_plane_destroy This last patch has as author: From: Stefan Weil via Ugh. It's too late. And yes, that's my mishap, - I forgot to check for such stuff

Re: [PULL 0/1] Dirty page rate and dirty page limit 20231225 patch

2023-12-26 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/9.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/7] Trivial patches for 2023-12-25

2023-12-26 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/9.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/11] m68k next-cube patches

2023-12-26 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/9.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/21] virtio,pc,pci: features, cleanups, fixes

2023-12-26 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/9.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [RFC PATCH] meson.build: report graphics backends

2023-12-26 Thread Philippe Mathieu-Daudé
Hi Alex, On 22/12/23 12:48, Alex Bennée wrote: To enable accelerated VirtIO GPUs for the guest we need the rendering support on the host but currently it's not reported in the configuration summary. Add a graphics backend section and report the status of the VirGL and Rutabaga support libraries.

Re: [PATCH 0/4] hw: Remove 'exec/exec-all.h' header when unused

2023-12-26 Thread Philippe Mathieu-Daudé
On 12/12/23 12:36, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (4): hw/ppc/spapr_hcall: Remove unused 'exec/exec-all.h' included header hw/misc/mips_itu: Remove unnecessary 'exec/exec-all.h' header hw/s390x/ipl: Remove unused 'exec/exec-all.h' included header target: Restric

Re: [PATCH 3/4] hw/s390x/ipl: Remove unused 'exec/exec-all.h' included header

2023-12-26 Thread Philippe Mathieu-Daudé
On 13/12/23 09:18, Christian Borntraeger wrote: Am 12.12.23 um 16:28 schrieb Eric Farman: So why do you think exec-all.h is unused? I think because that got moved out of exec-all.h a few months ago, via commit 3549118b498873c84b442bc280a5edafbb61e0a4 Author: Philippe Mathieu-Daudé Date:   Thu

Re: [PULL 0/7] Trivial patches for 2023-12-25

2023-12-26 Thread Philippe Mathieu-Daudé
Hi, On 25/12/23 09:10, Michael Tokarev wrote: trivial patches for 2023-12-25 Akihiko Odaki (2): qemu-options: Unify the help entries for cocoa qemu-

Re: [PATCH 0/2] system/qtest: Minor include cleanups

2023-12-26 Thread Philippe Mathieu-Daudé
On 12/12/23 12:30, Philippe Mathieu-Daudé wrote: Add missing header and restrict to sysemu. Philippe Mathieu-Daudé (2): system/qtest: Include missing 'hw/core/cpu.h' header system/qtest: Restrict QTest API to system emulation Thanks Thomas for merging these!

Re: [PATCH] virtio-blk: Fix potential nullpointer read access in virtio_blk_data_plane_destroy

2023-12-26 Thread Philippe Mathieu-Daudé
On 24/12/23 12:43, Stefan Weil via wrote: Fixes: CID 1532828 Fixes: b6948ab01d ("virtio-blk: add iothread-vq-mapping parameter") Signed-off-by: Stefan Weil --- hw/block/dataplane/virtio-blk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 23/24] exec/cpu-all: Extract page-protection definitions to page-prot-common.h

2023-12-26 Thread Philippe Mathieu-Daudé
Hi Nicholas, On 22/12/23 09:06, Nicholas Piggin wrote: On Tue Dec 12, 2023 at 7:20 AM AEST, Philippe Mathieu-Daudé wrote: Extract page-protection definitions from "exec/cpu-all.h" to "exec/page-prot-common.h". The list of files requiring the new header was generated using: $ git grep -wE \

[PATCH] docs/devel: Document conventional file prefixes and suffixes

2023-12-26 Thread Philippe Mathieu-Daudé
Some header and source file names use common prefix / suffix but we never really ruled a convention. Start doing so with the current patterns from the tree. Suggested-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/style.rst | 49

Re: [PATCH] esp: process the result of scsi_device_find()

2023-12-26 Thread Philippe Mathieu-Daudé
Cc'ing Mark for the logical change (should we rather assert?). On 18/12/23 16:02, Alexandra Diupina wrote: Add a 'current_lun' check for a null value to avoid null pointer dereferencing Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 4eb8606560 (esp: store lun coming f

Re: [PATCH] load_elf: fix iterator type in glue

2023-12-26 Thread Philippe Mathieu-Daudé
Hi, On 21/12/23 09:08, Anastasia Belova wrote: file_size is uint32_t, so j < file_size should be uint32_t too. file_size is of elf_word type, which is either uint32_t or uint64_t. Your explanation is not very clear... Maybe you want an unsigned type? In that case, does the following makes you

Re: [PATCH] hw/m68k/mcf5206: Embed m5206_timer_state in m5206_mbar_state

2023-12-26 Thread Philippe Mathieu-Daudé
On 21/12/23 13:29, Thomas Huth wrote: There's no need to explicitely allocate the memory here, we can simply embed it into the m5206_mbar_state instead. Signed-off-by: Thomas Huth --- hw/m68k/mcf5206.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) Reviewed-by:

Re: [PATCH] include/ui/rect.h: fix qemu_rect_init() mis-assignment

2023-12-26 Thread Philippe Mathieu-Daudé
On 22/12/23 20:17, Michael Tokarev wrote: From: Elen Avan Signed-off-by: Elen Avan Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2051 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2050 Fixes: a200d53b1fde "virtio-gpu: replace PIXMAN for region/rect test" Cc: qemu-sta...@nong

Re: [PATCH 00/33] hw/cpu/arm: Remove one use of qemu_get_cpu() in A7/A15 MPCore priv

2023-12-26 Thread Philippe Mathieu-Daudé
Hi, ping for review? On 12/12/23 17:29, Philippe Mathieu-Daudé wrote: Hi, When a MPCore cluster is used, the Cortex-A cores belong the the cluster container, not to the board/soc layer. This series move the creation of vCPUs to the MPCore private container. Doing so we consolidate the QOM mod

Re: [PATCH 0/2] target/alpha: Only build sys_helper.c on system emulation

2023-12-26 Thread Philippe Mathieu-Daudé
On 7/12/23 11:54, Philippe Mathieu-Daudé wrote: Extract helper_load_pcc() to clk_helper.c so we can restrict sys_helper.c to system emulation. Philippe Mathieu-Daudé (2): target/alpha: Extract clk_helper.c from sys_helper.c target/alpha: Only build sys_helper.c on system emulation targe

Re: [PULL 00/21] virtio,pc,pci: features, cleanups, fixes

2023-12-26 Thread Michael S. Tsirkin
On Tue, Dec 26, 2023 at 04:24:01AM -0500, Michael S. Tsirkin wrote: > The following changes since commit 80f1709aa0eb4de09b4240563463f991a5b9d855: > > Merge tag 'pull-loongarch-20231221' of https://gitlab.com/gaosong/qemu into > staging (2023-12-21 19:44:19 -0500) > > are available in the Git

[PULL 06/21] vhost-scsi: fix usage of error_reportf_err()

2023-12-26 Thread Michael S. Tsirkin
From: Dongli Zhang It is required to use error_report() instead of error_reportf_err(), if the prior function does not take local_err as the argument. As a result, the local_err is always NULL and segment fault may happen. vhost_scsi_start() -> vhost_scsi_set_endpoint(s) --> does not allocate lo

[PULL 14/21] vdpa: move file descriptor to vhost_vdpa_shared

2023-12-26 Thread Michael S. Tsirkin
From: Eugenio Pérez Next patches will register the vhost_vdpa memory listener while the VM is migrating at the destination, so we can map the memory to the device before stopping the VM at the source. The main goal is to reduce the downtime. However, the destination QEMU is unaware of which vho

[PULL 15/21] vdpa: move iotlb_batch_begin_sent to vhost_vdpa_shared

2023-12-26 Thread Michael S. Tsirkin
From: Eugenio Pérez Next patches will register the vhost_vdpa memory listener while the VM is migrating at the destination, so we can map the memory to the device before stopping the VM at the source. The main goal is to reduce the downtime. However, the destination QEMU is unaware of which vho

[PULL 19/21] vdpa: use VhostVDPAShared in vdpa_dma_map and unmap

2023-12-26 Thread Michael S. Tsirkin
From: Eugenio Pérez The callers only have the shared information by the end of this series. Start converting this functions. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Message-Id: <20231221174322.3130442-12-epere...@redhat.com> Tested-by: Lei Yang Reviewed-by: Michael S. Tsirkin Signe

[PULL 12/21] vdpa: move shadow_data to vhost_vdpa_shared

2023-12-26 Thread Michael S. Tsirkin
From: Eugenio Pérez Next patches will register the vhost_vdpa memory listener while the VM is migrating at the destination, so we can map the memory to the device before stopping the VM at the source. The main goal is to reduce the downtime. However, the destination QEMU is unaware of which vho

[PULL 21/21] vdpa: move memory listener to vhost_vdpa_shared

2023-12-26 Thread Michael S. Tsirkin
From: Eugenio Pérez Next patches will register the vhost_vdpa memory listener while the VM is migrating at the destination, so we can map the memory to the device before stopping the VM at the source. The main goal is to reduce the downtime. However, the destination QEMU is unaware of which vho

[PULL 20/21] vdpa: use dev_shared in vdpa_iommu

2023-12-26 Thread Michael S. Tsirkin
From: Eugenio Pérez The memory listener functions can call these too. Make vdpa_iommu work with VhostVDPAShared. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Message-Id: <20231221174322.3130442-13-epere...@redhat.com> Tested-by: Lei Yang Reviewed-by: Michael S. Tsirkin Signed-off-by: M

[PULL 08/21] vdpa: do not set virtio status bits if unneeded

2023-12-26 Thread Michael S. Tsirkin
From: Eugenio Pérez Next commits will set DRIVER and ACKNOWLEDGE flags repeatedly in the case of a migration destination. Let's save ioctls with this. Signed-off-by: Eugenio Pérez Message-Id: <20231215172830.2540987-2-epere...@redhat.com> --- hw/virtio/vhost-vdpa.c | 4 1 file changed, 4

[PULL 17/21] vdpa: remove msg type of vhost_vdpa

2023-12-26 Thread Michael S. Tsirkin
From: Eugenio Pérez It is always VHOST_IOTLB_MSG_V2. We can always make it back per vhost_dev if needed. This change makes easier for vhost_vdpa_map and unmap not to depend on vhost_vdpa but only in VhostVDPAShared. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Message-Id: <20231221174322

[PULL 16/21] vdpa: move backend_cap to vhost_vdpa_shared

2023-12-26 Thread Michael S. Tsirkin
From: Eugenio Pérez Next patches will register the vhost_vdpa memory listener while the VM is migrating at the destination, so we can map the memory to the device before stopping the VM at the source. The main goal is to reduce the downtime. However, the destination QEMU is unaware of which vho

[PULL 13/21] vdpa: use vdpa shared for tracing

2023-12-26 Thread Michael S. Tsirkin
From: Eugenio Pérez By the end of this series dma_map and dma_unmap functions don't have the vdpa device for tracing. Movinge trace function to shared member one. Print it also in the vdpa initialization so log reader can relate them. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Message-

[PULL 04/21] vhost-scsi: Add support for a worker thread per virtqueue

2023-12-26 Thread Michael S. Tsirkin
From: Mike Christie This adds support for vhost-scsi to be able to create a worker thread per virtqueue. Right now for vhost-net we get a worker thread per tx/rx virtqueue pair which scales nicely as we add more virtqueues and CPUs, but for scsi we get the single worker thread that's shared by al

[PULL 18/21] vdpa: move iommu_list to vhost_vdpa_shared

2023-12-26 Thread Michael S. Tsirkin
From: Eugenio Pérez Next patches will register the vhost_vdpa memory listener while the VM is migrating at the destination, so we can map the memory to the device before stopping the VM at the source. The main goal is to reduce the downtime. However, the destination QEMU is unaware of which vho

[PULL 10/21] vdpa: move iova tree to the shared struct

2023-12-26 Thread Michael S. Tsirkin
From: Eugenio Pérez Next patches will register the vhost_vdpa memory listener while the VM is migrating at the destination, so we can map the memory to the device before stopping the VM at the source. The main goal is to reduce the downtime. However, the destination QEMU is unaware of which vho

[PULL 11/21] vdpa: move iova_range to vhost_vdpa_shared

2023-12-26 Thread Michael S. Tsirkin
From: Eugenio Pérez Next patches will register the vhost_vdpa memory listener while the VM is migrating at the destination, so we can map the memory to the device before stopping the VM at the source. The main goal is to reduce the downtime. However, the destination QEMU is unaware of which vho

[PULL 01/21] virtio: rng: Check notifier helpers for VIRTIO_CONFIG_IRQ_IDX

2023-12-26 Thread Michael S. Tsirkin
From: Mathieu Poirier Since the driver doesn't support interrupts, we must return early when index is set to VIRTIO_CONFIG_IRQ_IDX. Basically the same thing Viresh did for "91208dd297f2 virtio: i2c: Check notifier helpers for VIRTIO_CONFIG_IRQ_IDX". Fixes: 544f0278afca ("virtio: introduce macro

[PULL 05/21] hw/acpi: propagate vcpu hotplug after switch to modern interface

2023-12-26 Thread Michael S. Tsirkin
From: Aaron Young If a vcpu with an apic-id that is not supported by the legacy interface (>255) is hot-plugged, the legacy code will dynamically switch to the modern interface. However, the hotplug event is not forwarded to the new interface resulting in the vcpu not being fully/properly added t

[PULL 09/21] vdpa: add VhostVDPAShared

2023-12-26 Thread Michael S. Tsirkin
From: Eugenio Pérez It will hold properties shared among all vhost_vdpa instances associated with of the same device. For example, we just need one iova_tree or one memory listener for the entire device. Next patches will register the vhost_vdpa memory listener at the beginning of the VM migrat

[PULL 07/21] Fix bugs when VM shutdown with virtio-gpu unplugged

2023-12-26 Thread Michael S. Tsirkin
From: wangmeiling Virtio-gpu malloc memory for the queue when it realized, but the queues was not released when it unrealized, which resulting in a memory leak. In addition, vm_change_state_handler is not cleaned up, which is related to vdev and will lead to segmentation fault when VM shutdown.

[PULL 02/21] tests: bios-tables-test: Rename smbios type 4 related test functions

2023-12-26 Thread Michael S. Tsirkin
From: Zhao Liu In fact, type4-count, core-count, core-count2, thread-count and thread-count2 are tested with KVM not TCG. Rename these test functions to reflect KVM base instead of TCG. Signed-off-by: Zhao Liu Message-Id: <20231127160202.1037290-1-zhao1@linux.intel.com> Reviewed-by: Philip

[PULL 03/21] vhost: Add worker backend callouts

2023-12-26 Thread Michael S. Tsirkin
From: Mike Christie This adds the vhost backend callouts for the worker ioctls added in the 6.4 linux kernel commit: c1ecd8e95007 ("vhost: allow userspace to create workers") Signed-off-by: Mike Christie Reviewed-by: Stefano Garzarella Reviewed-by: Stefan Hajnoczi Message-Id: <2023120423161

[PULL 00/21] virtio,pc,pci: features, cleanups, fixes

2023-12-26 Thread Michael S. Tsirkin
The following changes since commit 80f1709aa0eb4de09b4240563463f991a5b9d855: Merge tag 'pull-loongarch-20231221' of https://gitlab.com/gaosong/qemu into staging (2023-12-21 19:44:19 -0500) are available in the Git repository at: https://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_

Re: [PATCH] target/riscv: Fix mcycle/minstret increment behavior

2023-12-26 Thread Michael Tokarev
26.12.2023 12:21, Daniel Henrique Barboza: Michael, This is a good candidate for qemu-trivial. Already acked. Yeah, I've noticed it it earlier today and already copied to the qemu-stable-toapply folder :) Thanks! /mjt

Re: [PATCH] target/riscv: Fix mcycle/minstret increment behavior

2023-12-26 Thread Daniel Henrique Barboza
Michael, This is a good candidate for qemu-trivial. Already acked. Thanks, Daniel On 12/26/23 01:05, Xu Lu wrote: The mcycle/minstret counter's stop flag is mistakenly updated on a copy on stack. Thus the counter increments even when the CY/IR bit in the mcountinhibit register is set. This c

Re: [PATCH v11 0/7] Support x2APIC mode with TCG accelerator

2023-12-26 Thread Michael S. Tsirkin
On Mon, Dec 25, 2023 at 11:40:54PM +0700, Bui Quang Minh wrote: > Hi everyone, > > This series implements x2APIC mode in userspace local APIC and the > RDMSR/WRMSR helper to access x2APIC registers in x2APIC mode. Intel iommu > and AMD iommu are adjusted to support x2APIC interrupt remapping. With

Re: [PATCH] target/riscv: Fix mcycle/minstret increment behavior

2023-12-26 Thread Daniel Henrique Barboza
On 12/26/23 01:05, Xu Lu wrote: The mcycle/minstret counter's stop flag is mistakenly updated on a copy on stack. Thus the counter increments even when the CY/IR bit in the mcountinhibit register is set. This commit corrects its behavior. Good catch. Fixes: 3780e33732f88 (target/riscv: Su