On Tue, Dec 19, 2023 at 5:19 AM Fabiano Rosas <faro...@suse.de> wrote: > > Hao Xiang <hao.xi...@bytedance.com> writes: > > >> > >> > +} > >> > + > >> > +void dsa_start(void) {} > >> > + > >> > +void dsa_stop(void) {} > >> > + > >> > +void dsa_cleanup(void) {} > >> > + > >> > +#endif > >> > >> These could all be in the header. > > > > The function definitions are already in dsa.h Do you mean moving the > > function implementations to the header as well? > > > > I mean the empty !CONFIG_DSA_OPT variants could be in the header as > static inline. >
Fixed.