Re: [PATCH v4 3/3] tests/qtest: Introduce tests for AMD/Xilinx Versal TRNG device

Hi Peter, This is in regard to your comment on the use of g_usleep() in waiting for an event-bit update from the device under test. The TRNG device model presented in patch #1 does not have any asynchronous behavior. So, do you mean that, although the qtest process and the qemu-system-* process

Re: [PULL 00/11] testing patches (+ 1 deprecation patch)

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/2] hex queue - GETPC() fixes, shadowing fixes

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH 2/6] system/physmem: IOMMU: Invoke the translate_size function if it is implemented

On Fri, Oct 27, 2023 at 12:13:50PM -0400, Peter Xu wrote: > Add cc list. > > On Fri, Oct 27, 2023 at 12:02:24PM -0400, Peter Xu wrote: > > On Fri, Oct 27, 2023 at 11:28:36AM +0800, Ethan Chen wrote: > > > On Thu, Oct 26, 2023 at 10:20:41AM -0400, Peter Xu wrote: > > > > Could you elaborate why is

[PATCH v6 5/5] default-configs: Add TARGET_XML_FILES definition

loongarch64-linux-user has references to XML files so include them. Fixes: d32688ecdb ("default-configs: Add loongarch linux-user support") Signed-off-by: Akihiko Odaki --- configs/targets/loongarch64-linux-user.mak | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/targets/loongarch64-

[PATCH v6 1/5] hw/riscv: Use misa_mxl instead of misa_mxl_max

The effective MXL value matters when booting. Signed-off-by: Akihiko Odaki --- hw/riscv/boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c index 52bf8e67de..dad3f6e7b1 100644 --- a/hw/riscv/boot.c +++ b/hw/riscv/boot.c @@ -36,7 +36,7 @@

[PATCH v6 3/5] target/riscv: Move misa_mxl_max to class

misa_mxl_max is common for all instances of a RISC-V CPU class so they are better put into class. Signed-off-by: Akihiko Odaki --- target/riscv/cpu-qom.h | 1 + target/riscv/cpu.h | 3 +- target/riscv/cpu.c | 118 +++-- target/riscv/gdbstub

[PATCH v6 4/5] target/riscv: Validate misa_mxl_max only once

misa_mxl_max is now a class member and initialized only once for each class. This also moves the initialization of gdb_core_xml_file which will be referenced before realization in the future. Signed-off-by: Akihiko Odaki --- target/riscv/cpu.c | 21 + target/riscv/tcg

[PATCH v6 2/5] target/riscv: Remove misa_mxl validation

It is initialized with a simple assignment and there is little room for error. In fact, the validation is even more complex. Signed-off-by: Akihiko Odaki Acked-by: LIU Zhiwei Reviewed-by: Daniel Henrique Barboza --- target/riscv/tcg/tcg-cpu.c | 13 ++--- 1 file changed, 2 insertions(+)

[PATCH v6 0/5] gdbstub and TCG plugin improvements

Based-on: <20231029145033.592566-1-alex.ben...@linaro.org> ("[PATCH v2 00/19] Maintainer updates for testing, gdb, semihosting and plugins (pre-PR)") This series extracts fixes and refactorings that can be applied independently from "[PATCH v9 00/23] plugins: Allow to read registers". The patch "

[PATCH v6 06/21] net: Remove flag propagation

There is no defined flag now. Signed-off-by: Akihiko Odaki --- include/net/filter.h| 3 --- include/net/queue.h | 6 -- include/sysemu/replay.h | 2 +- net/dump.c | 4 ++-- net/filter-buffer.c | 4 +--- net/filter-mirror.c | 6 ++ net/filter-replay.c

[PATCH v6 21/21] ebpf: Add a separate target for skeleton

This generalizes the rule to generate the skeleton and allows to add another. Signed-off-by: Akihiko Odaki --- tools/ebpf/Makefile.ebpf | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tools/ebpf/Makefile.ebpf b/tools/ebpf/Makefile.ebpf index 3391e7ce08..572ca5

[PATCH v6 15/21] virtio-net: Do not clear VIRTIO_NET_F_HASH_REPORT

virtio-net can report hash values even if the peer does not have a virtio-net header. Signed-off-by: Akihiko Odaki --- hw/net/virtio-net.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index e30105884c..bdb4579f98 100644 --- a/hw/net/virtio-net.c

[PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

vhost requires eBPF for RSS. When eBPF is not available, virtio-net implicitly disables RSS even if the user explicitly requests it. Return an error instead of implicitly disabling RSS if RSS is requested but not available. Signed-off-by: Akihiko Odaki --- hw/net/virtio-net.c | 97 ++

[PATCH v6 14/21] virtio-net: Do not write hashes to peer buffer

The peer buffer is qualified with const and not meant to be modified. It also prevents enabling VIRTIO_NET_F_HASH_REPORT for peers without virtio-net header support. Signed-off-by: Akihiko Odaki --- hw/net/virtio-net.c | 36 +--- 1 file changed, 17 insertions(+),

[PATCH v6 10/21] virtio-net: Unify the logic to update NIC state for RSS

The code to attach or detach the eBPF program to RSS were duplicated so unify them into one function to save some code. Signed-off-by: Akihiko Odaki --- hw/net/virtio-net.c | 90 ++--- 1 file changed, 36 insertions(+), 54 deletions(-) diff --git a/hw/net/

[PATCH v6 04/21] net: Remove receive_raw()

While netmap implements virtio-net header, it does not implement receive_raw(). Instead of implementing receive_raw for netmap, add virtio-net headers in the common code and use receive_iov()/receive() instead. This also fixes the buffer size for the virtio-net header. Fixes: fbbdbddec0 ("tap: all

[PATCH v6 08/21] virtio-net: Copy header only when necessary

It is necessary to copy the header only for byte swapping. Worse, when byte swapping is not needed, the header can be larger than the buffer due to VIRTIO_NET_F_HASH_REPORT, which results in buffer overflow. Copy the header only when byte swapping is needed. Fixes: e22f0603fb ("virtio-net: refere

[PATCH v6 00/21] virtio-net RSS/hash report fixes and improvements

Based-on: <20230524064704.47711-1-akihiko.od...@daynix.com> ("[PATCH 0/2] net: Update MemReentrancyGuard for NIC") This series contains fixes and improvements for virtio-net RSS and hash reporting feature. V5 -> V6: Corrected the message for patch "virtio-net: Return an error when vhost canno

[PATCH v6 19/21] ebpf: Return 0 when configuration fails

The kernel interprets the returned value as an unsigned 32-bit so -1 will mean queue 4294967295, which is awkward. Return 0 instead. Signed-off-by: Akihiko Odaki --- ebpf/rss.bpf.skeleton.h | 1339 +++ tools/ebpf/rss.bpf.c|2 +- 2 files changed, 670 in

[PATCH v6 03/21] net: Move virtio-net header length assertion

The virtio-net header length assertion should happen for any clients. Signed-off-by: Akihiko Odaki --- net/net.c | 5 + net/tap.c | 3 --- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/net/net.c b/net/net.c index fda9a8f994..717d48ce15 100644 --- a/net/net.c +++ b/net/net.c

[PATCH v6 09/21] virtio-net: Disable RSS on reset

RSS is disabled by default. Fixes: 590790297c ("virtio-net: implement RSS configuration command") Signed-off-by: Akihiko Odaki Reviewed-by: Michael Tokarev --- hw/net/virtio-net.c | 70 +++-- 1 file changed, 36 insertions(+), 34 deletions(-) diff --git a

[PATCH v6 17/21] ebpf: Use standard section name

It makes easier to play with bpftool by allowing it to infer the program type. It also makes it unnecessary to set the program type manually when loading the program in ebpf_rss_load(). Signed-off-by: Akihiko Odaki --- ebpf/rss.bpf.skeleton.h | 1514 --- ebpf/

[PATCH v6 18/21] ebpf: Simplify error handling

The error handling procedures required when rss_bpf__open() and rss_bpf__load(rss_bpf_ctx) are different so it's better to implement them separately. Signed-off-by: Akihiko Odaki --- ebpf/ebpf_rss.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/ebpf/ebpf_rss.c b/

[PATCH v6 13/21] virtio-net: Always set populate_hash

The member is not cleared during reset so may have a stale value. Signed-off-by: Akihiko Odaki --- hw/net/virtio-net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 1fa020d905..0fe75b3c08 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-n

[PATCH v6 07/21] tap: Shrink zeroed virtio-net header

tap prepends a zeroed virtio-net header when writing a packet to a tap with virtio-net header enabled but not in use. This only happens when s->host_vnet_hdr_len == sizeof(struct virtio_net_hdr). Signed-off-by: Akihiko Odaki --- net/tap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH v6 01/21] tap: Remove tap_probe_vnet_hdr_len()

It was necessary since an Linux older than 2.6.35 may implement the virtio-net header but may not allow to change its length. Remove it since such an old Linux is no longer supported. Signed-off-by: Akihiko Odaki Acked-by: Michael S. Tsirkin --- net/tap_int.h | 1 - net/tap-bsd.c | 5

[PATCH v6 20/21] ebpf: Refactor tun_rss_steering_prog()

This saves branches and makes later BPF program changes easier. Signed-off-by: Akihiko Odaki --- tools/ebpf/rss.bpf.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/tools/ebpf/rss.bpf.c b/tools/ebpf/rss.bpf.c index 22c75d5912..012af38df1 100644 -

[PATCH v6 12/21] virtio-net: Enable software RSS

virtio-net implements software RSS but does not enable it. Enable it when RSS is requested, but the eBPF implementation is not available. We also check if vhost is in use in such a case since software RSS is incompatible with vhost. A warning will be emitted when falling back to software RSS since

[PATCH v6 02/21] tap: Remove qemu_using_vnet_hdr()

Since qemu_set_vnet_hdr_len() is always called when qemu_using_vnet_hdr() is called, we can merge them and save some code. For consistency, express that the virtio-net header is not in use by returning 0 with qemu_get_vnet_hdr_len() instead of having a dedicated function, qemu_get_using_vnet_hdr()

[PATCH v6 16/21] ebpf: Fix RSS error handling

calculate_rss_hash() was using hash value 0 to tell if it calculated a hash, but the hash value may be 0 on a rare occasion. Have a distinct bool value for correctness. Fixes: f3fa412de2 ("ebpf: Added eBPF RSS program.") Signed-off-by: Akihiko Odaki --- tools/ebpf/rss.bpf.c | 20 +++-

[PATCH v6 05/21] tap: Remove tap_receive()

The receive member of NetClientInfo is only for legacy clients and the receive_iov member is always used when it is set. Signed-off-by: Akihiko Odaki --- net/tap.c | 36 1 file changed, 36 deletions(-) diff --git a/net/tap.c b/net/tap.c index d54e90f184..ab4

Re: [PATCH 0/1] Enable -Wshadow=local

On Fri, 27 Oct 2023 at 13:42, Markus Armbruster wrote: > > Stefan Hajnoczi writes: > > > On Thu, 26 Oct 2023 at 14:32, Markus Armbruster wrote: > >> > >> Requires Brian's pull request and two patches from Thomas to compile: > >> > >> [PULL 0/2] hex queue - GETPC() fixes, shadowing fixes > >>

Re: [PATCH 01/14] target/riscv: Add cfg property for Zvkt extension

On Thu, Oct 26, 2023 at 1:15 AM Max Chou wrote: > > Vector crypto spec defines the Zvkt extension that included all of the > instructions of Zvbb & Zvbc extensions and some vector instructions. > > Signed-off-by: Max Chou Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu_cfg.h

Re: Patch to fix malfunctioning of T2-T5 timers on the STM32 platform

On Sat, Oct 28, 2023 at 5:55 AM Lucjan Bryndza wrote: > > > Current implementation of T2 - T5 times on the STM32 platform does not work > properly. > After configuring the timer-counter circuit to report interrupts every 10ms, > in reality the first interrupt is reported > only once after a few

Re: Patch to fix malfunctioning of T2-T5 timers on the STM32 platform

Hi Lucjan, On 27/10/23 21:37, Lucjan Bryndza wrote: Current implementation of T2 - T5 times on the STM32 platform does not work properly. After configuring the timer-counter circuit to report interrupts every 10ms, in reality the first interrupt is reported only once after a few seconds, whi

Re: [PATCH v5 04/21] net: Remove receive_raw()

On 2023/10/30 13:08, Jason Wang wrote: On Mon, Oct 30, 2023 at 12:03 PM Akihiko Odaki wrote: On 2023/10/30 12:06, Jason Wang wrote: 在 2023/10/27 15:52, Akihiko Odaki 写道: On 2023/10/27 15:49, Jason Wang wrote: On Tue, Oct 17, 2023 at 12:09 PM Akihiko Odaki wrote: While netmap implements

Re: [PATCH] hw/ufs: Modify lu.c to share codes with SCSI subsystem

Hi Jeuk, On 20/10/23 03:51, Jeuk Kim wrote: This patch removes the code that ufs-lu was duplicating from scsi-hd and allows them to share code. It makes ufs-lu have a virtual scsi-bus and scsi-hd internally. This allows scsi related commands to be passed thorugh to the scsi-hd. The query reques

Re: [PATCH v5 04/21] net: Remove receive_raw()

On Mon, Oct 30, 2023 at 12:03 PM Akihiko Odaki wrote: > > On 2023/10/30 12:06, Jason Wang wrote: > > > > 在 2023/10/27 15:52, Akihiko Odaki 写道: > >> On 2023/10/27 15:49, Jason Wang wrote: > >>> On Tue, Oct 17, 2023 at 12:09 PM Akihiko Odaki > >>> wrote: > > While netmap implements virtio

Re: [PATCH v9 4/7] hw/isa/vt82c686: Implement PCI IRQ routing

Hi Zoltan, On 7/3/23 12:42, BALATON Zoltan wrote: The real VIA south bridges implement a PCI IRQ router which is configured by the BIOS or the OS. In order to respect these configurations, QEMU needs to implement it as well. The real chip may allow routing IRQs from internal functions independen

[PULL 1/1] hw/ufs: Modify lu.c to share codes with SCSI subsystem

From: Jeuk Kim This patch removes the code that ufs-lu was duplicating from scsi-hd and allows them to share code. It makes ufs-lu have a virtual scsi-bus and scsi-hd internally. This allows scsi related commands to be passed thorugh to the scsi-hd. The query request and nop command work the sam

[PULL 0/1] ufs queue

From: Jeuk Kim The following changes since commit c60be6e3e38cb36dc66129e757ec4b34152232be: Merge tag 'pull-sp-20231025' of https://gitlab.com/rth7680/qemu into staging (2023-10-27 09:43:53 +0900) are available in the Git repository at: https://gitlab.com/jeuk20.kim/qemu.git tags/pull-ufs

Re: [PATCH v5 04/21] net: Remove receive_raw()

On 2023/10/30 12:06, Jason Wang wrote: 在 2023/10/27 15:52, Akihiko Odaki 写道: On 2023/10/27 15:49, Jason Wang wrote: On Tue, Oct 17, 2023 at 12:09 PM Akihiko Odaki wrote: While netmap implements virtio-net header, it does not implement receive_raw(). The only user for raw is the announcing

Re: [PATCH v6 12/12] target/riscv/tcg: warn if profile exts are disabled

On Sat, Oct 28, 2023 at 8:07 PM Daniel Henrique Barboza wrote: > > Enabling a profile and then disabling some of its mandatory extensions > is a valid use. It can be useful for debugging and testing. But the > common expected use of enabling a profile is to enable all its mandatory > extensions. >

Re: [PATCH v5 15/21] virtio-net: Do not clear VIRTIO_NET_F_HASH_REPORT

On 2023/10/30 6:56, Yuri Benditovich wrote: This patch allows  VIRTIO_NET_F_HASH_REPORT feature to the adapter whose backend does not have a virtio header and does not have offload features that depend on it. The migration between such different systems is very problematic even if it seems succ

Re: [PATCH v6 11/12] target/riscv/tcg: honor user choice for G MISA bits

On Sat, Oct 28, 2023 at 6:56 PM Daniel Henrique Barboza wrote: > > RVG behaves like a profile: a single flag enables a set of bits. Right > now we're considering user choice when handling RVG and zicsr/zifencei > and ignoring user choice on MISA bits. > > We'll add user warnings for profiles when

Re: [PATCH v6 09/12] target/riscv/tcg: handle profile MISA bits

On Sat, Oct 28, 2023 at 7:35 PM Daniel Henrique Barboza wrote: > > The profile support is handling multi-letter extensions only. Let's add > support for MISA bits as well. > > We'll go through every known MISA bit. If the profile doesn't declare > the bit as mandatory, ignore it. Otherwise, set th

Re: [PATCH v6 06/12] target/riscv/tcg: add user flag for profile support

On Sat, Oct 28, 2023 at 8:44 PM Andrew Jones wrote: > > On Sat, Oct 28, 2023 at 05:54:21AM -0300, Daniel Henrique Barboza wrote: > > The TCG emulation implements all the extensions described in the > > RVA22U64 profile, both mandatory and optional. The mandatory extensions > > will be enabled via

Re: [PATCH v5 11/21] virtio-net: Return an error when vhost cannot enable RSS

在 2023/10/27 15:54, Akihiko Odaki 写道: On 2023/10/27 16:07, Jason Wang wrote: On Tue, Oct 17, 2023 at 12:10 PM Akihiko Odaki wrote: vhost requires eBPF for RSS. Even when eBPF is not available, virtio-net reported RSS availability, and raised a warning only after the guest requested RSS, a

Re: [PATCH] linux-user/elfload: Add missing arm64 hwcap values

On 29/10/23 22:00, Marielle Novastrider wrote: Specifically DIT, LSE2, and MTE3. We already expose detection of these via the CPUID interface, but missed these from ELF hwcaps. Signed-off-by: Marielle Novastrider --- linux-user/elfload.c | 3 +++ target/arm/cpu.h | 5 + 2 files cha

Re: [PATCH 6/6] system/memory: Trace names of MemoryRegions rather than host pointers

Hi Bernhard, On 28/10/23 14:24, Bernhard Beschow wrote: Tracing the host pointer of the accessed MemoryRegion seems to be a debug feature for developing QEMU itself. When analyzing guest behavior by comparing traces, these pointers generate a lot of noise since the pointers differ between QEMU i

Re: [PATCH v1 5/6] linux-user/loongarch64: Add LSX sigcontext save/restore

在 2023/10/29 上午5:35, Richard Henderson 写道: On 10/9/23 20:37, Song Gao wrote: Signed-off-by: Song Gao ---   linux-user/loongarch64/signal.c | 107 ++--   1 file changed, 87 insertions(+), 20 deletions(-) diff --git a/linux-user/loongarch64/signal.c b/linux-user/loong

Re: [PATCH v1 2/6] target/loongarch: Add set_vec_extctx to set LSX/LASX instructions extctx_flags

在 2023/10/29 上午5:40, Richard Henderson 写道: On 10/9/23 20:36, Song Gao wrote: Signed-off-by: Song Gao ---   target/loongarch/insn_trans/trans_vec.c.inc | 12   target/loongarch/internals.h    |  2 ++   2 files changed, 14 insertions(+) diff --git a/target/loongarch/insn_

Re: [PATCH 5/6] hw/i2c/pm_smbus: Convert DPRINTF to trace events

On 28/10/23 14:24, Bernhard Beschow wrote: Let the trace messages slightly deviate from the function names ("smb" -> "smbus") being traced in order to avoid conflights with the SMB protocol. Signed-off-by: Bernhard Beschow --- hw/i2c/pm_smbus.c | 18 -- hw/i2c/trace-events

Re: [PATCH 4/6] hw/misc/imx6_ccm: Convert DPRINTF to trace events

Hi Bernhard, On 28/10/23 14:24, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow --- hw/misc/imx6_ccm.c | 41 ++--- hw/misc/trace-events | 15 +++ 2 files changed, 29 insertions(+), 27 deletions(-) +# imx6_ccm.c +imx6_analog_get_p

RE: [PATCH v3 18/37] vfio/container: Implement attach/detach_device

>-Original Message- >From: Cédric Le Goater >Sent: Saturday, October 28, 2023 12:07 AM >Subject: Re: [PATCH v3 18/37] vfio/container: Implement attach/detach_device > >Sorry, previous email was empty. Friday effect ! > >On 10/26/23 12:30, Zhenzhong Duan wrote: >> From: Eric Auger >> >>

Re: [PATCH 3/6] hw/misc/imx7_snvs: Trace MMIO access

On 28/10/23 14:24, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow --- hw/misc/imx7_snvs.c | 5 + hw/misc/trace-events | 4 2 files changed, 9 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 1/6] hw/watchdog/wdt_imx2: Trace MMIO access

On 28/10/23 14:24, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow --- hw/watchdog/wdt_imx2.c | 24 ++-- hw/watchdog/trace-events | 4 2 files changed, 22 insertions(+), 6 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v3 0/4] riscv: zicntr/zihpm flags and disable support

On Tue, Oct 24, 2023 at 1:40 AM Daniel Henrique Barboza wrote: > > Hi, > > In this v3 the patches that added the extensions flags were squashed > with the patches that handled the disablement of the extensions in TCG, > as suggested by Alistair in v2. > > No other change made. Patches based on Ali

RE: [PATCH v3 19/37] vfio/spapr: Introduce spapr backend and target interface

>-Original Message- >From: Cédric Le Goater >Sent: Saturday, October 28, 2023 12:05 AM >Subject: Re: [PATCH v3 19/37] vfio/spapr: Introduce spapr backend and target >interface > >On 10/26/23 12:30, Zhenzhong Duan wrote: >> Introduce an empry spapr backend which will hold spapr specific >

RE: [PATCH v3 14/37] vfio/container: Move vrdl_list, pgsizes and dma_max_mappings to base container

Hi Cédric, >-Original Message- >From: Cédric Le Goater >Sent: Friday, October 27, 2023 11:52 PM >Subject: Re: [PATCH v3 14/37] vfio/container: Move vrdl_list, pgsizes and >dma_max_mappings to base container > >On 10/26/23 12:30, Zhenzhong Duan wrote: >> From: Eric Auger >> ... >> void

Re: [PATCH v3 3/4] target/riscv: add zihpm extension flag for TCG

On Tue, Oct 24, 2023 at 1:40 AM Daniel Henrique Barboza wrote: > > zihpm is the Hardware Performance Counters extension described in > chapter 12 of the unprivileged spec. It describes support for 29 > unprivileged performance counters, hpmcounter3-hpmcounter31. > > As with zicntr, QEMU already im

Re: [PATCH v5 04/21] net: Remove receive_raw()

在 2023/10/27 15:52, Akihiko Odaki 写道: On 2023/10/27 15:49, Jason Wang wrote: On Tue, Oct 17, 2023 at 12:09 PM Akihiko Odaki wrote: While netmap implements virtio-net header, it does not implement receive_raw(). The only user for raw is the announcing. Netmap probably doesn't it at all.

Re: [PATCH v4 13/13] hw/riscv/virt-acpi-build.c: Add PLIC in MADT

On Thu, Oct 26, 2023 at 6:15 AM Sunil V L wrote: > > Add PLIC structures for each socket in the MADT when system is > configured with PLIC as the external interrupt controller. > > Signed-off-by: Haibo Xu > Signed-off-by: Sunil V L > Reviewed-by: Daniel Henrique Barboza > Reviewed-by: Andrew Jo

Re: [PATCH v4 12/13] hw/riscv/virt-acpi-build.c: Add IO controllers and devices

On Thu, Oct 26, 2023 at 6:15 AM Sunil V L wrote: > > Add basic IO controllers and devices like PCI, VirtIO and UART in the > ACPI namespace. > > Signed-off-by: Sunil V L > Reviewed-by: Daniel Henrique Barboza Acked-by: Alistair Francis Alistair > --- > hw/riscv/Kconfig | 1 + > h

RE: [PATCH v3 11/37] vfio/container: Switch to IOMMU BE set_dirty_page_tracking/query_dirty_bitmap API

>-Original Message- >From: Cédric Le Goater >Sent: Friday, October 27, 2023 10:53 PM >Subject: Re: [PATCH v3 11/37] vfio/container: Switch to IOMMU BE >set_dirty_page_tracking/query_dirty_bitmap API > >On 10/26/23 12:30, Zhenzhong Duan wrote: >> From: Eric Auger >> >> dirty_pages_suppor

RE: [PATCH v3 10/37] vfio/container: Move space field to base container

>-Original Message- >From: Cédric Le Goater >Sent: Friday, October 27, 2023 10:46 PM >Subject: Re: [PATCH v3 10/37] vfio/container: Move space field to base >container > >On 10/26/23 12:30, Zhenzhong Duan wrote: >> From: Eric Auger >> >> Move the space field to the base object. Also th

Re: [PATCH v4 11/13] hw/riscv/virt: Update GPEX MMIO related properties

On Thu, Oct 26, 2023 at 6:09 AM Sunil V L wrote: > > Update the GPEX host bridge properties related to MMIO ranges with > values set for the virt machine. > > Suggested-by: Igor Mammedov > Signed-off-by: Sunil V L Reviewed-by: Alistair Francis Alistair > --- > hw/riscv/virt.c | 47 +

RE: [PATCH v3 09/37] vfio/common: Move giommu_list in base container

>-Original Message- >From: Cédric Le Goater >Sent: Friday, October 27, 2023 10:39 PM >Subject: Re: [PATCH v3 09/37] vfio/common: Move giommu_list in base >container > >On 10/26/23 12:30, Zhenzhong Duan wrote: >> From: Eric Auger >> >> Move the giommu_list field in the base object and st

RE: [PATCH v3 08/37] vfio/container: Switch to dma_map|unmap API

>-Original Message- >From: Cédric Le Goater >Sent: Friday, October 27, 2023 10:26 PM >Subject: Re: [PATCH v3 08/37] vfio/container: Switch to dma_map|unmap API > >On 10/26/23 12:30, Zhenzhong Duan wrote: >> From: Eric Auger >> >> No fucntional change intended. >> >> Signed-off-by: Eric

RE: [PATCH v3 07/37] vfio/container: Introduce a empty VFIOIOMMUOps

>-Original Message- >From: Cédric Le Goater >Sent: Friday, October 27, 2023 10:21 PM >Subject: Re: [PATCH v3 07/37] vfio/container: Introduce a empty >VFIOIOMMUOps > >On 10/26/23 12:30, Zhenzhong Duan wrote: >> This empty VFIOIOMMUOps named vfio_legacy_ops will hold all general >> IOMMU

RE: [PATCH v3 06/37] vfio: Introduce base object for VFIOContainer and targetted interface

>-Original Message- >From: Cédric Le Goater >Sent: Friday, October 27, 2023 10:03 PM >Subject: Re: [PATCH v3 06/37] vfio: Introduce base object for VFIOContainer and >targetted interface > >On 10/26/23 12:30, Zhenzhong Duan wrote: >> Introduce a dumb VFIOContainer base object and its tar

Re: [PATCH v4 10/13] hw/pci-host/gpex: Define properties for MMIO ranges

On Thu, Oct 26, 2023 at 6:12 AM Sunil V L wrote: > > ACPI DSDT generator needs information like ECAM range, PIO range, 32-bit > and 64-bit PCI MMIO range etc related to the PCI host bridge. Instead of > making these values machine specific, create properties for the GPEX > host bridge with default

Re: [PATCH v4 03/13] hw/i386/acpi-microvm.c: Use common function to add virtio in DSDT

On Thu, Oct 26, 2023 at 7:23 AM Sunil V L wrote: > > With common function to add virtio in DSDT created now, update microvm > code also to use it instead of duplicate code. > > Suggested-by: Andrew Jones > Signed-off-by: Sunil V L Acked-by: Alistair Francis Alistair > --- > hw/i386/acpi-mic

Re: [PATCH 1/1] target/riscv: correct csr_ops[CSR_MSECCFG]

On Sun, Oct 29, 2023 at 10:47 AM Heinrich Schuchardt wrote: > > The CSR register mseccfg is used by multiple extensions: Smepm and Zkr. > > Consider this when checking the existence of the register. > > Fixes: 77442380ecbe ("target/riscv: rvk: add CSR support for Zkr") > Signed-off-by: Heinrich Sc

Re: [PATCH 1/1] target/riscv: correct csr_ops[CSR_MSECCFG]

On Sun, Oct 29, 2023 at 10:47 AM Heinrich Schuchardt wrote: > > The CSR register mseccfg is used by multiple extensions: Smepm and Zkr. > > Consider this when checking the existence of the register. > > Fixes: 77442380ecbe ("target/riscv: rvk: add CSR support for Zkr") > Signed-off-by: Heinrich Sc

Re: [PATCH] MAINTAINERS: Add the can documenation file to the CAN section

Hello Thomas and others, On Friday 27 of October 2023 08:09:31 Thomas Huth wrote: > Add can.rst to the corresponding section in MAINTAINERS, so that > the maintainers get CC:-ed on corresponding patches. > > Signed-off-by: Thomas Huth > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) >

Re: [PULL 00/41] target-arm queue

On Fri, 27 Oct 2023 at 23:41, Peter Maydell wrote: > > Hi; here's the latest target-arm queue. Mostly this is refactoring > and cleanup type patches. > > thanks > -- PMM Hi Peter, I can't find this email thread on lore.kernel.org and your git repo doesn't let me fetch the tag: $ git fetch http

Re: [PATCH v5 11/21] virtio-net: Return an error when vhost cannot enable RSS

On Tue, Oct 17, 2023 at 7:10 AM Akihiko Odaki wrote: > vhost requires eBPF for RSS. Even when eBPF is not available, virtio-net > reported RSS availability, and raised a warning only after the > guest requested RSS, and the guest could not know that RSS is not > available. > > The existing code s

Re: [PATCH v5 15/21] virtio-net: Do not clear VIRTIO_NET_F_HASH_REPORT

This patch allows VIRTIO_NET_F_HASH_REPORT feature to the adapter whose backend does not have a virtio header and does not have offload features that depend on it. The migration between such different systems is very problematic even if it seems successful, such setups are not performance-oriented

[PATCH] linux-user/elfload: Add missing arm64 hwcap values

Specifically DIT, LSE2, and MTE3. We already expose detection of these via the CPUID interface, but missed these from ELF hwcaps. Signed-off-by: Marielle Novastrider --- linux-user/elfload.c | 3 +++ target/arm/cpu.h | 5 + 2 files changed, 8 insertions(+) diff --git a/linux-user/elflo

[PATCH 10/11] tcg: Move tcg_temp_new_*, tcg_global_mem_new_* out of line

Signed-off-by: Richard Henderson --- include/tcg/tcg-op-common.h | 11 ++ include/tcg/tcg-temp-internal.h | 27 +++--- include/tcg/tcg.h | 51 -- tcg/tcg.c | 64 +++-- 4 files changed, 76 inser

[PATCH 03/11] tcg: Move generic expanders out of line

Signed-off-by: Richard Henderson --- include/tcg/tcg-op-common.h | 19 +++ tcg/tcg-op.c| 16 2 files changed, 19 insertions(+), 16 deletions(-) diff --git a/include/tcg/tcg-op-common.h b/include/tcg/tcg-op-common.h index e093f541a7..2134961a98 100

[PATCH 00/11] tcg: Move tcg expanders out of line

This reduces the amount of code within tcg-op-common.h, and the amount of code in the code segment full stop. With many translators these days, we're putting the expander function addresses into tables, or pass them to other general target-specific expansion helpers. At present that means we get

[PATCH 02/11] tcg: Move tcg_gen_op* out of line

In addition to moving out of line, with CONFIG_DEBUG_TCG mark them all noinline. Signed-off-by: Richard Henderson --- include/tcg/tcg-op-common.h | 252 +++- tcg/tcg-op.c| 208 + 2 files changed, 252 insertions(+), 208 d

[PATCH 07/11] tcg: Move tcg_gen_opN declarations to tcg-internal.h

These are used within tcg-op.c and tcg-op-ldst.c. There are no uses outside tcg/. Signed-off-by: Richard Henderson --- include/tcg/tcg-op-common.h | 7 --- tcg/tcg-internal.h | 7 +++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/tcg/tcg-op-common.h b/in

[PATCH 06/11] tcg: Move vec_gen_* declarations to tcg-internal.h

These are used within tcg-op-vec.c and tcg/host/tcg-target.c.inc. There are no uses outside tcg/. Signed-off-by: Richard Henderson --- include/tcg/tcg-op-common.h | 4 tcg/tcg-internal.h | 4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/tcg/tcg-op-com

[PATCH 11/11] tcg: Move tcg_temp_free_* out of line

Signed-off-by: Richard Henderson --- include/tcg/tcg-temp-internal.h | 29 + tcg/tcg.c | 25 + 2 files changed, 30 insertions(+), 24 deletions(-) diff --git a/include/tcg/tcg-temp-internal.h b/include/tcg/tcg-temp-internal

[PATCH 04/11] tcg: Move 32-bit expanders out of line

Signed-off-by: Richard Henderson --- include/tcg/tcg-op-common.h | 140 ++-- tcg/tcg-op.c| 116 ++ 2 files changed, 137 insertions(+), 119 deletions(-) diff --git a/include/tcg/tcg-op-common.h b/include/tcg/tcg-op-common

[PATCH 05/11] tcg: Move 64-bit expanders out of line

This one is more complicated, combining 32-bit and 64-bit expansion with C if instead of preprocessor #if. Signed-off-by: Richard Henderson --- include/tcg/tcg-op-common.h | 144 +- tcg/tcg-op.c| 231 +--- 2 files changed, 169 i

[PATCH 09/11] tcg: Move tcg_constant_* out of line

Signed-off-by: Richard Henderson --- include/tcg/tcg-op-common.h | 8 include/tcg/tcg.h | 26 -- tcg/tcg-internal.h | 7 +++ tcg/tcg.c | 15 +++ 4 files changed, 30 insertions(+), 26 deletions(-) diff --git a

[PATCH 08/11] tcg: Unexport tcg_gen_op*_{i32,i64}

These functions are no longer used outside tcg-op.c. There are several that are completely unused, so remove them. Signed-off-by: Richard Henderson --- include/tcg/tcg-op-common.h | 47 - tcg/tcg-op.c| 131 ++-- 2 files changed, 52 ins

[PATCH 01/11] tcg: Mark tcg_gen_op* as noinline

Encourage the compiler to tail-call rather than inline across the dozens of opcode expanders. Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index 828eb9ee46..9aed19e957 100

qemu-system-i386

<<< text/html; charset=UTF-8: Unrecognized >>>

Re: [PATCH v2 14/19] tests/docker: use debian-all-test-cross for sparc64

On 10/29/23 07:50, Alex Bennée wrote: Maintaining two sets of containers for test building is silly. While it makes sense for the QEMU cross-compile targets to have their own fat containers built by lcitool we might as well merge the other random debian based compilers into the same one used on g

Re: [PATCH v2 07/19] tests/docker: move sh4 to use debian-legacy-test-cross

On 10/29/23 07:50, Alex Bennée wrote: diff --git a/tests/docker/dockerfiles/debian-all-test-cross.docker b/tests/docker/dockerfiles/debian-all-test-cross.docker index 205173b0a5..43cc083318 100644 --- a/tests/docker/dockerfiles/debian-all-test-cross.docker +++ b/tests/docker/dockerfiles/debian-a

Re: [PATCH v3 3/3] hw/ppc: Nest1 chiplet wiring

On 10/28/23 13:30, Chalapathi V wrote: This part of the patchset connects the nest1 chiplet model to p10 chip. Signed-off-by: Chalapathi V Reviewed-by: Cédric Le Goater Thanks, C. --- hw/ppc/pnv.c | 11 +++ include/hw/ppc/pnv_chip.h | 2 ++ 2 files changed, 13

Re: [PATCH v3 2/3] hw/ppc: Add nest1 chiplet model

On 10/28/23 13:30, Chalapathi V wrote: The nest1 chiplet handle the high speed i/o traffic over PCIe and others. The nest1 chiplet consists of PowerBus Fabric controller, nest Memory Management Unit, chiplet control unit and more. This commit creates a nest1 chiplet model and initialize and real

Re: [PATCH v3 1/3] hw/ppc: Add pnv pervasive common chiplet units

On 10/28/23 13:30, Chalapathi V wrote: This part of the patchset creates a common pervasive chiplet model where it houses the common units of a chiplets. The chiplet control unit is common across chiplets and this commit implements the pervasive chiplet model with chiplet control registers. Sig

Re: [PATCH v2 05/19] gitlab: add build-loongarch to matrix

On 10/29/23 07:50, Alex Bennée wrote: We have the compiler and with a few updates a container that can build QEMU so we should at least run the check-tcg smoke tests. Signed-off-by: Alex Bennée --- .gitlab-ci.d/buildtest.yml| 9 .gitlab-ci.d/container-cross.yml

  1   2   >