>-----Original Message----- >From: Cédric Le Goater <c...@redhat.com> >Sent: Friday, October 27, 2023 10:21 PM >Subject: Re: [PATCH v3 07/37] vfio/container: Introduce a empty >VFIOIOMMUOps > >On 10/26/23 12:30, Zhenzhong Duan wrote: >> This empty VFIOIOMMUOps named vfio_legacy_ops will hold all general >> IOMMU ops of legacy container. >> >> Signed-off-by: Zhenzhong Duan <zhenzhong.d...@intel.com> >> --- >> include/hw/vfio/vfio-common.h | 2 +- >> hw/vfio/container.c | 5 +++++ >> 2 files changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h >> index d8f293cb57..8ded5cd8e4 100644 >> --- a/include/hw/vfio/vfio-common.h >> +++ b/include/hw/vfio/vfio-common.h >> @@ -255,7 +255,7 @@ typedef QLIST_HEAD(VFIOGroupList, VFIOGroup) >VFIOGroupList; >> typedef QLIST_HEAD(VFIODeviceList, VFIODevice) VFIODeviceList; >> extern VFIOGroupList vfio_group_list; >> extern VFIODeviceList vfio_device_list; >> - >> +extern const VFIOIOMMUOps vfio_legacy_ops; > > >why does it need to be external ?
It is referenced by vfio_connect_container() and vfio_attach_device(). Thanks Zhenzhong
