Re: [PATCH v8 00/12] Add VIRTIO sound card

Am 04.09.23 um 12:01 schrieb Manos Pitsidianakis: Hello Volker :) On Mon, 04 Sep 2023 10:20, Volker Rümelin wrote: All qemu_log_mask() format strings need a trailing \n. Thank you, will fix it! I still hear a lot of playback dropouts. I had planned to look at the playback code, but I didn'

Re: [PATCH RESEND v5 24/26] contrib/plugins: Allow to log registers

On 2023/09/05 0:30, Alex Bennée wrote: Akihiko Odaki writes: On 2023/08/31 0:08, Alex Bennée wrote: Akihiko Odaki writes: This demonstrates how a register can be read from a plugin. Signed-off-by: Akihiko Odaki --- docs/devel/tcg-plugins.rst | 10 ++- contrib/plugins/execlog.c |

Re: [PATCH v2 05/19] host-utils: Add muldiv64_round_up

On 9/5/23 05:56, Nicholas Piggin wrote: On Mon Sep 4, 2023 at 11:30 PM AEST, Cédric Le Goater wrote: On 9/4/23 15:07, Nicholas Piggin wrote: On Sat Sep 2, 2023 at 3:02 AM AEST, Richard Henderson wrote: On 9/1/23 04:51, Cédric Le Goater wrote: Adding more reviewers since this patch is modifyin

Re: [PATCH 00/16] tests: Add CPU topology related smbios test cases

Hi Michael, On Fri, Sep 01, 2023 at 12:55:33PM +0300, Michael Tokarev wrote: > Date: Fri, 1 Sep 2023 12:55:33 +0300 > From: Michael Tokarev > Subject: Re: [PATCH 00/16] tests: Add CPU topology related smbios test cases > > 25.08.2023 06:36, Zhao Liu wrote: > > From: Zhao Liu > > > > Hi all, >

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

Michael, On 8/30/23 17:37, Stefan Hajnoczi wrote: > On Wed, 30 Aug 2023 at 09:30, Laszlo Ersek wrote: >> >> On 8/30/23 14:10, Stefan Hajnoczi wrote: >>> On Sun, 27 Aug 2023 at 14:31, Laszlo Ersek wrote: (1) The virtio-1.0 specification

Re: [PATCH v8 00/12] Add VIRTIO sound card

Am 04.09.23 um 14:11 schrieb Alex Bennée: Manos Pitsidianakis writes: Hello Volker :) On Mon, 04 Sep 2023 10:20, Volker Rümelin wrote: All qemu_log_mask() format strings need a trailing \n. Thank you, will fix it! I still hear a lot of playback dropouts. I had planned to look at the play

Re: [PATCH 06/15] configure: remove boolean variables for targets

Il lun 4 set 2023, 10:15 Thomas Huth ha scritto: > It might look nicer to put the linux and solaris parts from above as > separate entries in the new case-esac statement. > True but it all disappears by the end of the series. Paolo > Anyway: > Reviewed-by: Thomas Huth > >

Re: [RFC PATCH 1/3] Python: Drop support for Python 3.7

Il lun 4 set 2023, 12:34 Philippe Mathieu-Daudé ha scritto: > > Since it is safe to under our supported platform policy, bump our > > Is 'under' a verb? This sentence is not obvious to me. > No, just drop "to". Paolo > > minimum supported version of Python to 3.8. The two most interesting >

Re: [PATCH v2 06/22] target/tricore: Clean up local variable shadowing

On Mon, Sep 04, 2023 at 06:12:18PM +0200, Philippe Mathieu-Daudé wrote: > Fix: > > target/tricore/translate.c:5016:18: warning: declaration of ‘temp’ shadows > a previous local [-Wshadow=compatible-local] >5016 | TCGv temp = tcg_constant_i32(const9); > |

Re: [PATCH v2 05/19] host-utils: Add muldiv64_round_up

On Mon Sep 4, 2023 at 11:30 PM AEST, Cédric Le Goater wrote: > On 9/4/23 15:07, Nicholas Piggin wrote: > > On Sat Sep 2, 2023 at 3:02 AM AEST, Richard Henderson wrote: > >> On 9/1/23 04:51, Cédric Le Goater wrote: > >>> Adding more reviewers since this patch is modifying a common service. > >>> > >

Re: [PATCH] softmmu/dirtylimit: Fix usleep early return on signal

On 2023/9/4 21:27, Yong Huang wrote: On Fri, Sep 1, 2023 at 10:19 AM > wrote: From: alloc mailto:alloc.yo...@outlook.com>> Timeout functions like usleep can return early on signal, which reduces more dirty pages than expected. In dirtylimit case

Re: [PATCH 10/22] Implement shmid_ds conversion between host and target.

On 9/3/23 01:45, Kariiem Taha wrote: Richard Henderson writes: On 8/19/23 02:47, Karim Taha wrote: +if (!lock_user_struct(VERIFY_WRITE, target_sd, target_addr, 0)) { +return -TARGET_EFAULT; +} +if (host_to_target_ipc_perm(target_addr, &(host_sd->shm_perm))) { +retu

Re: [PATCH v5 01/20] tests/docker: Update docker-loongarch-cross toolchain

On 9/4/23 07:02, Alex Bennée wrote: Richard Henderson writes: Update from clfs 5.0 to clfs 8.1, which includes updates to binutils 2.41, gcc 13.2, and glibc 2.38. See https://github.com/loongson/build-tools Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée Do you want this queu

Re: [PATCH v8 10/12] virtio-sound: implement audio output (TX)

Am 04.09.23 um 12:34 schrieb Manos Pitsidianakis: On Mon, 04 Sep 2023 13:26, Philippe Mathieu-Daudé wrote: +/* + * AUD_* output callback. + * + * @data: VirtIOSoundPCMStream stream + * @available: number of bytes that can be written with AUD_write() + */ +static void virtio_snd_pcm_out_cb(voi

Re: [PATCH v8 02/12] Add virtio-sound-pci device

Am 04.09.23 um 12:26 schrieb Manos Pitsidianakis: On Mon, 04 Sep 2023 09:32, Volker Rümelin wrote: +static Property virtio_snd_pci_properties[] = { +    DEFINE_AUDIO_PROPERTIES(VirtIOSoundPCI, vdev.card), I think DEFINE_AUDIO_PROPERTIES should be moved back to virtio-snd.c. The audiodev prop

Re: [PATCH v22 17/20] tests/avocado: s390x cpu topology test dedicated CPU

On Fri, 2023-09-01 at 17:58 +0200, Nina Schoetterl-Glausch wrote: > From: Pierre Morel > > A dedicated CPU in vertical polarization can only have > a high entitlement. > Let's check this from both host and guest point of view. > > Signed-off-by: Pierre Morel > Co-developed-by: Nina Schoetterl-G

Re: [PATCH v22 16/20] tests/avocado: s390x cpu topology entitlement tests

On Fri, 2023-09-01 at 17:58 +0200, Nina Schoetterl-Glausch wrote: > From: Pierre Morel > > Test changes in the entitlement from both a guest and a host point of > view, depending on the polarization. > > Signed-off-by: Pierre Morel > Co-developed-by: Nina Schoetterl-Glausch > Signed-off-by: Ni

Re: [PATCH v22 15/20] tests/avocado: s390x cpu topology polarization

On Fri, 2023-09-01 at 17:58 +0200, Nina Schoetterl-Glausch wrote: > From: Pierre Morel > > Polarization is changed on a request from the guest. > Let's verify the polarization is accordingly set by QEMU. > > Signed-off-by: Pierre Morel > Co-developed-by: Nina Schoetterl-Glausch > Signed-off-by

Re: [PATCH v22 14/20] tests/avocado: s390x cpu topology core

On Fri, 2023-09-01 at 17:58 +0200, Nina Schoetterl-Glausch wrote: > From: Pierre Morel > > Introduction of the s390x cpu topology core functions and > basic tests. > > We test the correlation between the command line and > the QMP results in query-cpus-fast for various CPU topology. > > Signed-

Re: [PATCH 2/2] hw/cxl: Support 4 HDM decoders at all levels of topology

Hi Jonathan, Few style comments inlined. On 4/9/23 18:47, Jonathan Cameron wrote: Support these decoders in CXL host bridges (pxb-cxl), CXL Switch USP and CXL Type 3 end points. Signed-off-by: Jonathan Cameron --- Note there is a fix in here for a wrong increment that had no impact when there

Re: [PATCH 1/2] hw/cxl: Add utility functions decoder interleave ways and target count.

On 4/9/23 18:47, Jonathan Cameron wrote: As an encoded version of these key configuration parameters is a register, provide functions to extract it again so as to avoid the need for duplicating the storage. Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_component.h | 14 ++

Re: [PATCH v22 03/20] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

On Fri, 2023-09-01 at 17:57 +0200, Nina Schoetterl-Glausch wrote: > From: Pierre Morel > > On interception of STSI(15.1.x) the System Information Block > (SYSIB) is built from the list of pre-ordered topology entries. > > Signed-off-by: Pierre Morel > Co-developed-by: Nina Schoetterl-Glausch >

[PATCH] hw/pci-bridge/cxl-upstream: Add serial number extended capability support

Will be needed so there is a defined serial number for information queries via the Switch CCI. Signed-off-by: Jonathan Cameron --- No ordering dependencies wrt to other CXL patch sets. Whilst we 'need' it for the Switch CCI set it is valid without it and aligns with existing EP serial number sup

Re: [PATCH 4/5] cxl/type3: add an optional mhd validation function for memory accesses

On Thu, 31 Aug 2023 21:29:13 -0400 Gregory Price wrote: > When memory accesses are made, some MHSLD's would validate the address > is within the scope of allocated sections. To do this, the base device > must call an optional function set by inherited devices. > > Signed-off-by: Gregory Price

Re: [PATCH for-8.1] vfio/display: Fix missing update to set backing fields

Hi On Mon, Sep 4, 2023 at 6:11 PM Alex Williamson wrote: > > On Mon, 4 Sep 2023 15:06:21 +0400 > Marc-André Lureau wrote: > > > Hi > > > > On Thu, Aug 17, 2023 at 8:29 PM Kim, Dongwon wrote: > > > > > > Ok, this regression happened not just because of renaming. Originally > > > width and height

Re: [PATCH 2/5] cxl/type3: Cleanup multiple CXL_TYPE3() calls in read/write functions

On Thu, 31 Aug 2023 21:29:11 -0400 Gregory Price wrote: > Call CXL_TYPE3 once at top of function to avoid multiple invocations. > > Signed-off-by: Gregory Price Good cleanup on it's own. I'll queue this one up on the backend of the sanitize set that introduces the second use in each of these

Re: [PATCH v6 05/17] nbd/server: Refactor handling of command sanity checks

On 29.08.23 20:58, Eric Blake wrote: Upcoming additions to support NBD 64-bit effect lengths will add a new command flag NBD_CMD_FLAG_PAYLOAD_LEN that needs to be considered in our sanity checks of the client's messages (that is, more than just CMD_WRITE have the potential to carry a client paylo

[PATCH 2/2] hw/cxl: Support 4 HDM decoders at all levels of topology

Support these decoders in CXL host bridges (pxb-cxl), CXL Switch USP and CXL Type 3 end points. Signed-off-by: Jonathan Cameron --- Note there is a fix in here for a wrong increment that had no impact when there was only one HDM decoder. include/hw/cxl/cxl_component.h | 7 +++ hw/cxl/cxl-compo

[PATCH 1/2] hw/cxl: Add utility functions decoder interleave ways and target count.

As an encoded version of these key configuration parameters is a register, provide functions to extract it again so as to avoid the need for duplicating the storage. Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_component.h | 14 ++ hw/cxl/cxl-component-utils.c | 17 ++

[PATCH 0/2] hw/cxl: Support emulating 4 HDM decoders throughout topology

For initial CXL emulation / kernel driver bring up a single Host-managed Device Memory (HDM) decoder instance was sufficient as it let us test the basic region creation code etc. More complex testing appropriate today requires a more realistic configuration with multiple decoders. The Linux kernel

Re: [PATCH v2] qdict: Preserve order for iterating qdict elements

On Sat, Sep 02, 2023 at 05:40:40PM +0800, William Tsai wrote: > Changing the structure of qdict so that it can preserve order when > iterating qdict. This will fix array_properties as it relies on `len-` > prefixed argument to be set first. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issu

Re: [PATCH 3/3] tests/qtest/pflash: Clean up local variable shadowing

On Mon, 4 Sept 2023 at 17:30, Philippe Mathieu-Daudé wrote: > > Fix: > > tests/qtest/pflash-cfi02-test.c: In function ‘test_geometry’: > tests/qtest/pflash-cfi02-test.c:409:22: warning: declaration of ‘byte_addr’ > shadows a previous local [-Wshadow=compatible-local] > 409 | u

Re: [PATCH 2/3] hw/intc/openpic: Clean up local variable shadowing

On Mon, 4 Sept 2023 at 17:28, Philippe Mathieu-Daudé wrote: > > Fix: > > hw/intc/openpic.c: In function ‘openpic_gbl_write’: > hw/intc/openpic.c:614:17: warning: declaration of ‘idx’ shadows a previous > local [-Wshadow=compatible-local] > 614 | int idx; > |

Re: [PATCH 1/3] hw/core/machine: Clean up local variable shadowing

On Mon, 4 Sept 2023 at 17:28, Philippe Mathieu-Daudé wrote: > > Fix: > > hw/core/machine.c: In function ‘machine_initfn’: > hw/core/machine.c:1081:17: warning: declaration of ‘obj’ shadows a > parameter [-Wshadow=compatible-local] >1081 | Object *obj = OBJECT(ms); > |

Re: [RFC PATCH v2 22/22] softmmu/physmem: Clean up local variable shadowing

On Mon, Sep 04, 2023 at 06:12:34PM +0200, Philippe Mathieu-Daudé wrote: > Fix: > > softmmu/physmem.c: In function > ‘cpu_physical_memory_snapshot_and_clear_dirty’: > softmmu/physmem.c:916:27: warning: declaration of ‘offset’ shadows a > parameter [-Wshadow=compatible-local] > 916 |

Re: [PATCH v2 16/22] crypto/cipher-gnutls.c: Clean up local variable shadowing

On 4/9/23 18:27, Daniel P. Berrangé wrote: On Mon, Sep 04, 2023 at 06:12:28PM +0200, Philippe Mathieu-Daudé wrote: Fix: In file included from crypto/cipher.c:140: crypto/cipher-gnutls.c.inc: In function ‘qcrypto_gnutls_cipher_encrypt’: crypto/cipher-gnutls.c.inc:116:17: warning: declar

[PATCH 0/3] (few more) Steps towards enabling -Wshadow [3 more]

Just missed while posting v2 eh :/ (https://lore.kernel.org/qemu-devel/20230904161235.84651-1-phi...@linaro.org/) Philippe Mathieu-Daudé (3): hw/core/machine: Clean up local variable shadowing hw/intc/openpic: Clean up local variable shadowing tests/qtest/pflash: Clean up local variable shad

[PATCH 2/3] hw/intc/openpic: Clean up local variable shadowing

Fix: hw/intc/openpic.c: In function ‘openpic_gbl_write’: hw/intc/openpic.c:614:17: warning: declaration of ‘idx’ shadows a previous local [-Wshadow=compatible-local] 614 | int idx; | ^~~ hw/intc/openpic.c:568:9: note: shadowed declaration is here

[PATCH 1/3] hw/core/machine: Clean up local variable shadowing

Fix: hw/core/machine.c: In function ‘machine_initfn’: hw/core/machine.c:1081:17: warning: declaration of ‘obj’ shadows a parameter [-Wshadow=compatible-local] 1081 | Object *obj = OBJECT(ms); | ^~~ hw/core/machine.c:1065:36: note: shadowed declaration is h

[PATCH] target/riscv: update checks on writing pmpcfg for ePMP to version 1.0

Current checks on writing pmpcfg for ePMP follows ePMP version 0.9.1. However, ePMP specification has already been ratified, and there are some differences between version 0.9.1 and 1.0. In this commit we update the checks of writing pmpcfg to follow ePMP version 1.0. When mseccfg.MML is set, the

[PATCH 3/3] tests/qtest/pflash: Clean up local variable shadowing

Fix: tests/qtest/pflash-cfi02-test.c: In function ‘test_geometry’: tests/qtest/pflash-cfi02-test.c:409:22: warning: declaration of ‘byte_addr’ shadows a previous local [-Wshadow=compatible-local] 409 | uint64_t byte_addr = (uint64_t)i * c->sector_len[region]; |

Re: [PATCH v2 16/22] crypto/cipher-gnutls.c: Clean up local variable shadowing

On Mon, Sep 04, 2023 at 06:12:28PM +0200, Philippe Mathieu-Daudé wrote: > Fix: > > In file included from crypto/cipher.c:140: > crypto/cipher-gnutls.c.inc: In function ‘qcrypto_gnutls_cipher_encrypt’: > crypto/cipher-gnutls.c.inc:116:17: warning: declaration of ‘err’ shadows a > previous lo

Re: [PATCH] docs/devel/loads-stores: Fix git grep regexes

On 4/9/23 18:17, Peter Maydell wrote: The loads-and-stores documentation includes git grep regexes to find occurrences of the various functions. Some of these regexes have errors, typically failing to escape the '?', '(' and ')' when they should be metacharacters (since these are POSIX basic REs

[PATCH 1/1] qom: fix setting of array properties

DEFINE_PROP_ARRAY() creates a property 'len-$ARRAY-PROP-NAME' which, when set, will create a sequence of '$ARRAY-PROP-NAME[N]' properties. This only works if the 'len-$ARRAY-PROP-NAME' property is set first, and the array elements afterwards. Historically this required the user to set correct orde

[PATCH 0/1] qom: fix setting of qdev array properties

By the time of the 8.2.0 release, it will have been 2 years and 6 releases since we accidentally broke setting of array properties for user creatable devices: https://gitlab.com/qemu-project/qemu/-/issues/1090 Some context: * Initial identification / report on the mailing list https://list

Re: [PATCH 65/67] ppc/kconfig: make SAM460EX depend on PPC & PIXMAN

On 8/30/23 14:34, BALATON Zoltan wrote: From: Marc-André Lureau SM501 is going to depend on PIXMAN next. Why is this patch needed when SM501 is the one that depends on PIXMAN and should pull in the dependency? Also what's the change in default.mak? The change in default.mak is needed be

[PATCH v2 3/3] tests/acpi: Update DSDT.cxl with QTG DSM

Description of change in previous patch. Signed-off-by: Jonathan Cameron --- tests/qtest/bios-tables-test-allowed-diff.h | 1 - tests/data/acpi/q35/DSDT.cxl| Bin 9655 -> 9723 bytes 2 files changed, 1 deletion(-) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/test

[PATCH v2 2/3] hw/cxl: Add QTG _DSM support for ACPI0017 device

From: Dave Jiang Add a simple _DSM call support for the ACPI0017 device to return a fake QTG ID value of 0 in all cases. The enabling is for _DSM plumbing testing from the OS. Following edited for readbility only Device (CXLM) { Name (_HID, "ACPI0017") // _HID: Hardware ID ... Method (

[PATCH v2 1/3] tests/acpi: Allow update of DSDT.cxl

Addition of QTG in following patch requires an update to the test data. Signed-off-by: Jonathan Cameron --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h i

[PATCH v2 0/3] hw/cxl: Add dummy ACPI QTG DSM

v2 updates: - Edit of patch description to not confuse matters by mentioning switches. - Associated ACPI test updates. CXL platforms may support the concept of QoS Thottling groups (QTG). Typically you want to associate devices with similar performance with the same QTG. As there is no standard

[PATCH v2 04/22] target/mips: Clean up local variable shadowing

Fix: target/mips/tcg/nanomips_translate.c.inc:4410:33: error: declaration shadows a local variable [-Werror,-Wshadow] int32_t imm = extract32(ctx->opcode, 1, 13) | ^ target/mips/tcg/nanomips_translate.c.inc:3577:9: note: previous declara

[PATCH v2 15/22] net/eth: Clean up local variable shadowing

Fix: net/eth.c:435:20: error: declaration shadows a local variable [-Werror,-Wshadow] size_t input_size = iov_size(pkt, pkt_frags); ^ net/eth.c:413:16: note: previous declaration is here size_t input_size = iov_size(pkt, pkt_frags); ^ Sug

[PATCH v2 14/22] hw/nios2: Clean up local variable shadowing

Fix: hw/nios2/10m50_devboard.c: In function ‘nios2_10m50_ghrd_init’: hw/nios2/10m50_devboard.c:101:22: warning: declaration of ‘dev’ shadows a previous local [-Wshadow=compatible-local] 101 | DeviceState *dev = qdev_new(TYPE_NIOS2_VIC); | ^~~ hw/nios

[PATCH v2 16/22] crypto/cipher-gnutls.c: Clean up local variable shadowing

Fix: In file included from crypto/cipher.c:140: crypto/cipher-gnutls.c.inc: In function ‘qcrypto_gnutls_cipher_encrypt’: crypto/cipher-gnutls.c.inc:116:17: warning: declaration of ‘err’ shadows a previous local [-Wshadow=compatible-local] 116 | int err = gnutls_cipher_init(&

[PATCH v2 20/22] sysemu/device_tree: Clean up local variable shadowing

Fix: hw/mips/boston.c:472:5: error: declaration shadows a local variable [-Werror,-Wshadow] qemu_fdt_setprop_cells(fdt, name, "reg", reg_base, reg_size); ^ include/sysemu/device_tree.h:129:13: note: expanded from macro 'qemu_fdt_setprop_cells' int i; ^ hw/mips/b

[PATCH v2 18/22] semihosting/arm-compat: Clean up local variable shadowing

Fix: semihosting/arm-compat-semi.c: In function ‘do_common_semihosting’: semihosting/arm-compat-semi.c:379:13: warning: declaration of ‘ret’ shadows a previous local [-Wshadow=local] 379 | int ret, err = 0; | ^~~ semihosting/arm-compat-semi.c:370:14: note: sh

Re: [PATCH v6 04/17] nbd: Prepare for 64-bit request effect lengths

On 29.08.23 20:58, Eric Blake wrote: Widen the length field of NBDRequest to 64-bits, although we can assert that all current uses are still under 32 bits: either because of NBD_MAX_BUFFER_SIZE which is even smaller (and where size_t can still be appropriate, even on 32-bit platforms), or because

[PATCH v2 03/22] target/arm/hvf: Clean up local variable shadowing

Per Peter Maydell analysis [*]: The hvf_vcpu_exec() function is not documented, but in practice its caller expects it to return either EXCP_DEBUG (for "this was a guest debug exception you need to deal with") or something else (presumably the intention being 0 for OK). The hvf_sysreg_re

[PATCH] docs/devel/loads-stores: Fix git grep regexes

The loads-and-stores documentation includes git grep regexes to find occurrences of the various functions. Some of these regexes have errors, typically failing to escape the '?', '(' and ')' when they should be metacharacters (since these are POSIX basic REs). We also weren't consistent about whet

[PATCH v2 21/22] softmmu/memory: Clean up local variable shadowing

Fix: softmmu/memory.c: In function ‘mtree_print_mr’: softmmu/memory.c:3236:27: warning: declaration of ‘ml’ shadows a previous local [-Wshadow=compatible-local] 3236 | MemoryRegionList *ml; | ^~ softmmu/memory.c:3213:32: note: shadowed declaratio

[PATCH v2 01/22] tcg: Clean up local variable shadowing

Fix: tcg/tcg.c:2551:27: error: declaration shadows a local variable [-Werror,-Wshadow] MemOp op = get_memop(oi); ^ tcg/tcg.c:2437:12: note: previous declaration is here TCGOp *op; ^ accel/tcg/tb-maint.c:245:18: error: declaration

[RFC PATCH v2 22/22] softmmu/physmem: Clean up local variable shadowing

Fix: softmmu/physmem.c: In function ‘cpu_physical_memory_snapshot_and_clear_dirty’: softmmu/physmem.c:916:27: warning: declaration of ‘offset’ shadows a parameter [-Wshadow=compatible-local] 916 | unsigned long offset = page % DIRTY_MEMORY_BLOCK_SIZE; |

[PATCH v2 17/22] util/vhost-user-server: Clean up local variable shadowing

Fix: util/vhost-user-server.c: In function ‘set_watch’: util/vhost-user-server.c:274:20: warning: declaration of ‘vu_fd_watch’ shadows a previous local [-Wshadow=compatible-local] 274 | VuFdWatch *vu_fd_watch = g_new0(VuFdWatch, 1); |^~~ util/

[PATCH v2 19/22] linux-user/strace: Clean up local variable shadowing

Fix: linux-user/strace.c: In function ‘print_sockaddr’: linux-user/strace.c:370:17: warning: declaration of ‘i’ shadows a previous local [-Wshadow=compatible-local] 370 | int i; | ^ linux-user/strace.c:361:9: note: shadowed declaration is here 361

[PATCH v2 12/22] hw/m68k: Clean up local variable shadowing

Fix: hw/m68k/virt.c:263:13: error: declaration shadows a local variable [-Werror,-Wshadow] BOOTINFOSTR(param_ptr, BI_COMMAND_LINE, ^ hw/m68k/bootinfo.h:47:13: note: expanded from macro 'BOOTINFOSTR' int i; \ ^ hw/m68k/virt.c:130:9: note: previous

[PATCH v2 10/22] hw/arm/aspeed: Clean up local variable shadowing

Fix: hw/arm/aspeed_ast2600.c:391:18: error: declaration shadows a local variable [-Werror,-Wshadow] qemu_irq irq = aspeed_soc_get_irq(s, ASPEED_DEV_TIMER1 + i); ^ hw/arm/aspeed_ast2600.c:283:14: note: previous declaration is here qemu_irq irq; ^ hw

[PATCH v2 08/22] hw/arm/virt: Clean up local variable shadowing

Fix: hw/arm/virt.c:821:22: error: declaration shadows a local variable [-Werror,-Wshadow] qemu_irq irq = qdev_get_gpio_in(vms->gic, ^ hw/arm/virt.c:803:13: note: previous declaration is here int irq; ^ Signed-off-by: Philippe Mathieu-Daudé

[PATCH v2 13/22] hw/microblaze: Clean up local variable shadowing

Fix: hw/microblaze/petalogix_ml605_mmu.c: In function ‘petalogix_ml605_init’: hw/microblaze/petalogix_ml605_mmu.c:186:24: warning: declaration of ‘dinfo’ shadows a previous local [-Wshadow=compatible-local] 186 | DriveInfo *dinfo = drive_get(IF_MTD, 0, i); |

[PATCH v2 09/22] hw/arm/allwinner: Clean up local variable shadowing

Fix: hw/arm/allwinner-r40.c:412:14: error: declaration shadows a local variable [-Werror,-Wshadow] for (int i = 0; i < AW_R40_NUM_MMCS; i++) { ^ hw/arm/allwinner-r40.c:299:14: note: previous declaration is here unsigned i; ^ Signed-off-by: Philippe Mathieu-D

[PATCH v2 11/22] hw/ide/ahci: Clean up local variable shadowing

hw/ide/ahci.c:1577:23: error: declaration shadows a local variable [-Werror,-Wshadow] IDEState *s = &ad->port.ifs[j]; ^ hw/ide/ahci.c:1569:29: note: previous declaration is here void ahci_uninit(AHCIState *s) ^ Signed-off-b

[PATCH v2 02/22] target/arm/tcg: Clean up local variable shadowing

Fix: target/arm/tcg/translate-m-nocp.c: In function ‘gen_M_fp_sysreg_read’: target/arm/tcg/translate-m-nocp.c:509:18: warning: declaration of ‘tmp’ shadows a previous local [-Wshadow=compatible-local] 509 | TCGv_i32 tmp = load_cpu_field(v7m.fpdscr[M_REG_NS]); |

[PATCH v2 00/22] (few more) Steps towards enabling -Wshadow

Since v1: - Addressed review comments - Added R-b tags - More patches For rational see Markus cover on https://lore.kernel.org/qemu-devel/20230831132546.3525721-1-arm...@redhat.com/ This series contains few more, my take. Based-on: <20230831132546.3525721-1-arm...@redhat.com> Philippe Mathieu-D

[PATCH v2 07/22] hw/arm/armv7m: Clean up local variable shadowing

Fix: hw/arm/armv7m.c: In function ‘armv7m_realize’: hw/arm/armv7m.c:520:27: warning: declaration of ‘sbd’ shadows a previous local [-Wshadow=compatible-local] 520 | SysBusDevice *sbd = SYS_BUS_DEVICE(&s->bitband[i]); | ^~~ hw/arm/armv7m.c:27

[PATCH v2 06/22] target/tricore: Clean up local variable shadowing

Fix: target/tricore/translate.c:5016:18: warning: declaration of ‘temp’ shadows a previous local [-Wshadow=compatible-local] 5016 | TCGv temp = tcg_constant_i32(const9); | ^~~~ target/tricore/translate.c:4958:10: note: shadowed declaration is here 49

[PATCH v2 05/22] target/m68k: Clean up local variable shadowing

Fix: target/m68k/translate.c:828:18: error: declaration shadows a local variable [-Werror,-Wshadow] TCGv tmp = tcg_temp_new(); ^ target/m68k/translate.c:801:15: note: previous declaration is here TCGv reg, tmp, result; ^ Signed-off-by: Philippe

Re: [PATCH] iothread: Set the GSource "name" field

On 4/9/23 16:48, Fabiano Rosas wrote: Having a name in the source helps with debugging core dumps when one might not have access to TLS data to cross-reference AioContexts with their addresses. Signed-off-by: Fabiano Rosas --- iothread.c | 13 + 1 file changed, 9 insertions(+), 4

Re: [PATCH RESEND v5 24/26] contrib/plugins: Allow to log registers

Akihiko Odaki writes: > On 2023/08/31 0:08, Alex Bennée wrote: >> Akihiko Odaki writes: >> >>> This demonstrates how a register can be read from a plugin. >>> >>> Signed-off-by: Akihiko Odaki >>> --- >>> docs/devel/tcg-plugins.rst | 10 ++- >>> contrib/plugins/execlog.c | 140 ++

Re: [PATCH v6 01/17] nbd: Replace bool structured_reply with mode enum

On 29.08.23 20:58, Eric Blake wrote: The upcoming patches for 64-bit extensions requires various points in the protocol to make decisions based on what was negotiated. While we could easily add a 'bool extended_headers' alongside the existing 'bool structured_reply', this does not scale well if

[PATCH] qcow2: keep reference on zeroize with discard-no-unref enabled

When the discard-no-unref flag is enabled, we keep the reference for normal discard requests. But when a discard is executed on a snapshot/qcow2 image with backing, the discards are saved as zero clusters in the snapshot image. When committing the snapshot to the backing file, not discard_in_l2_sl

Re: [PATCH v5 20/20] linux-user/s390x: Add vdso

Richard Henderson writes: > Signed-off-by: Richard Henderson > --- > linux-user/s390x/vdso-asmoffset.h | 2 + > linux-user/elfload.c | 3 ++ > linux-user/s390x/signal.c | 4 +- > linux-user/s390x/meson.build | 24 +++ > linux-user/s390x/vdso.S

Re: [PATCH v5 04/20] linux-user: Do not clobber bprm_buf swapping ehdr

Richard Henderson writes: > Rearrange the allocation of storage for ehdr between load_elf_image > and load_elf_binary. The same set of copies are done, but we don't > modify bprm_buf, which will be important later. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson R

Re: [PATCH v5 03/20] linux-user: Tidy loader_exec

Richard Henderson writes: > Reorg the if cases to reduce indentation. > Test for 4 bytes in the file before checking the signatures. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PATCH] iothread: Set the GSource "name" field

Having a name in the source helps with debugging core dumps when one might not have access to TLS data to cross-reference AioContexts with their addresses. Signed-off-by: Fabiano Rosas --- iothread.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/iothread.c b/i

Re: [PATCH 61/67] ui/spice: SPICE/QXL requires PIXMAN

Il mer 30 ago 2023, 17:21 Philippe Mathieu-Daudé ha scritto: > On 30/8/23 11:38, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > --- > > hw/display/Kconfig | 2 +- > > ui/meson.build | 12 ++-- > > 2 files changed, 7 i

[PATCH] io: Stop appending -listen to net listeners

All callers of qio_net_listener_set_name() already add some sort of "listen" or "listener" suffix. For intance, we currently have "migration-socket-listener-listen" and "vnc-listen-listen" as ioc names. Signed-off-by: Fabiano Rosas --- io/net-listener.c | 4 +--- 1 file changed, 1 insertion(+),

[PULL 00/14] Block layer patches

The following changes since commit 17780edd81d27fcfdb7a802efc870a99788bd2fc: Merge tag 'quick-fix-pull-request' of https://gitlab.com/bsdimp/qemu into staging (2023-08-31 10:06:29 -0400) are available in the Git repository at: https://repo.or.cz/qemu/kevin.git tags/for-upstream for you to

[PULL 05/14] qemu-img: omit errno value in error message

From: Michael Tokarev I'm getting io-qcow2-244 test failure on mips* due to output mismatch: Take an internal snapshot: -qemu-img: Could not create snapshot 'test': -95 (Operation not supported) +qemu-img: Could not create snapshot 'test': -122 (Operation not supported) No errors were foun

[PULL 06/14] block/iscsi: Document why we use raw malloc()

From: Peter Maydell In block/iscsi.c we use a raw malloc() call, which is unusual given the project standard is to use the glib memory allocation functions. Document why we do so, to avoid it being converted to g_malloc() by mistake. Signed-off-by: Peter Maydell Message-ID: <20230727150705.2664

[PULL 04/14] block: change reqs_lock to QemuMutex

From: Stefan Hajnoczi CoMutex has poor performance when lock contention is high. The tracked requests list is accessed frequently and performance suffers in QEMU multi-queue block layer scenarios. It is not necessary to use CoMutex for the requests lock. The lock is always released across corout

[PULL 08/14] qemu-img: Update documentation for compressed images

Document the 'compression_type' option for qcow2, and mention that streamOptimized vmdk supports compression, too. Reported-by: Richard W.M. Jones Signed-off-by: Kevin Wolf Message-ID: <20230901102430.23856-1-kw...@redhat.com> Reviewed-by: Richard W.M. Jones Signed-off-by: Kevin Wolf --- docs

[PULL 02/14] iotests: adapt test output for new qemu_cleanup() behavior

From: Fiona Ebner Since commit ca2a5e630d ("qemu_cleanup: begin drained section after vm_shutdown()"), there will be an additional pause for jobs during qemu_cleanup(). The reason is that the bdrv_drain_all() call in do_vm_stop() is not inside the drained section used by qemu_cleanup() anymore. I

[PULL 14/14] block: Remove unnecessary variable in bdrv_block_device_info

From: Fabiano Rosas The commit 5d8813593f ("block/qapi: Let bdrv_query_image_info() recurse") removed the loop where we set the 'bs0' variable, so now it is just the same as 'bs'. Signed-off-by: Fabiano Rosas Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20230901184605.32260-3-faro...@suse.

[PULL 13/14] block: Remove bdrv_query_block_node_info

From: Fabiano Rosas The last call site of this function has been removed by commit c04d0ab026 ("qemu-img: Let info print block graph"). Reviewed-by: Claudio Fontana Signed-off-by: Fabiano Rosas Message-ID: <20230901184605.32260-2-faro...@suse.de> Reviewed-by: Kevin Wolf Signed-off-by: Kevin W

[PULL 10/14] block: remove AIOCBInfo->get_aio_context()

From: Stefan Hajnoczi The synchronous bdrv_aio_cancel() function needs the acb's AioContext so it can call aio_poll() to wait for cancellation. It turns out that all users run under the BQL in the main AioContext, so this callback is not needed. Remove the callback, mark bdrv_aio_cancel() GLOBA

[PULL 03/14] block: minimize bs->reqs_lock section in tracked_request_end()

From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Message-ID: <20230808155852.2745350-2-stefa...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block/io.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/block/io.c b/blo

[PULL 01/14] block/vpc: Avoid dynamic stack allocation

From: Philippe Mathieu-Daudé Use autofree heap allocation instead of variable-length array on the stack. Here we don't expect the bitmap size to be enormous, and since we're about to read/write it to disk the overhead of the allocation should be fine. The codebase has very few VLAs, and if we ca

[PULL 11/14] block-backend: process I/O in the current AioContext

From: Stefan Hajnoczi Switch blk_aio_*() APIs over to multi-queue by using qemu_get_current_aio_context() instead of blk_get_aio_context(). This change will allow devices to process I/O in multiple IOThreads in the future. I audited existing blk_aio_*() callers: - migration/block.c: blk_mig_lock

[PULL 07/14] block: Be more verbose in create fallback

From: Hanna Czenczek For image creation code, we have central fallback code for protocols that do not support creating new images (like NBD or iscsi). So for them, you can only specify existing paths/exports that are overwritten to make clean new images. In such a case, if the given path cannot

[PULL 09/14] vmdk: Clean up bdrv_open_child() return value check

From: Dmitry Frolov bdrv_open_child() may return NULL. Usually return value is checked for this function. Check for return value is more reliable. Fixes: 24bc15d1f6 ("vmdk: Use BdrvChild instead of BDS for references to extents") Signed-off-by: Dmitry Frolov Message-ID: <20230831125926.796205

[PULL 12/14] block-backend: process zoned requests in the current AioContext

From: Stefan Hajnoczi Process zoned requests in the current thread's AioContext instead of in the BlockBackend's AioContext. There is no need to use the BlockBackend's AioContext thanks to CoMutex bs->wps->colock, which protects zone metadata. Signed-off-by: Stefan Hajnoczi Message-ID: <202308

  1   2   3   4   >