Re: [PATCH v2 9/9] docs/system: add basic virtio-gpu documentation

2023-08-01 Thread Akihiko Odaki
On 2023/08/01 10:17, Gurchetan Singh wrote: This adds basic documentation for virtio-gpu. Suggested-by: Akihiko Odaki Signed-off-by: Gurchetan Singh --- v2: - Incorporated suggestions by Akihiko Odaki - Listed the currently supported capset_names (Bernard) docs/system/device-emulation

Re: [PATCH v2 8/9] gfxstream + rutabaga: enable rutabaga

2023-08-01 Thread Akihiko Odaki
On 2023/08/01 10:17, Gurchetan Singh wrote: This change enables rutabaga to receive virtio-gpu-3d hypercalls when it is active. Signed-off-by: Gurchetan Singh --- hw/display/virtio-gpu-base.c | 3 ++- hw/display/virtio-gpu.c | 5 +++-- softmmu/qdev-monitor.c | 3 +++ softmmu/vl.

Re: [PATCH v2 7/9] gfxstream + rutabaga: meson support

2023-08-01 Thread Akihiko Odaki
On 2023/08/01 10:17, Gurchetan Singh wrote: - Add meson detection of rutabaga_gfx - Build virtio-gpu-rutabaga.c + associated vga/pci files when present Signed-off-by: Gurchetan Singh --- hw/display/meson.build| 22 ++ meson.build | 7 +++

Re: [PATCH v2 6/9] gfxstream + rutabaga: add initial support for gfxstream

2023-08-01 Thread Akihiko Odaki
On 2023/08/01 10:17, Gurchetan Singh wrote: This adds initial support for gfxstream and cross-domain. Both features rely on virtio-gpu blob resources and context types, which are also implemented in this patch. gfxstream has a long and illustrious history in Android graphics paravirtualization.

Re: [PATCH v6 0/8] linux-user: brk fixes

2023-08-01 Thread Helge Deller
* Joel Stanley : > On Tue, 1 Aug 2023 at 23:28, Helge Deller wrote: > > > > This patch series is a fix-up for some current problems > > regarding heap memory / brk handling in qemu which happens > > on some 32-bit platforms, e.g. problems loading static > > binaries. > > > > This series includes t

Re: [PATCH v6 6/8] linux-user: Show heap address in /proc/pid/maps

2023-08-01 Thread Helge Deller
Hi Philiplle, On 8/2/23 07:41, Philippe Mathieu-Daudé wrote: On 2/8/23 01:27, Helge Deller wrote: .. Show 32- and 64-bit pointers with 8 digits and leading zeros (%08x/%08lx). For 64-bit we could use %16lx, but we mimic the Linux kernel, which shows even 64-bit addresses with %08lx. You are

Re: [PATCH v6 6/8] linux-user: Show heap address in /proc/pid/maps

2023-08-01 Thread Philippe Mathieu-Daudé
Hi Helge, On 2/8/23 01:27, Helge Deller wrote: Show the memory location of the heap in the /proc/pid/maps file inside the guest. Store the heap address in ts->heap_base, which requires to make that variable accessible for all guest architectures, not just architectures for semihosted binaries (a

Re: [PATCH v3 3/3] cpu, softmmu/vl.c: Change parsing of -cpu argument to allow -cpu cpu,help to print options for the CPU type similar to how the '-device' option works.

2023-08-01 Thread Markus Armbruster
Dinah B writes: > Thanks, I will fix this. I somehow didn't catch that you had replied to the > old one. Happens :)

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2023-08-01 Thread Akihiko Odaki
On 2023/08/01 7:31, Yuri Benditovich wrote: USO features of virtio-net device depend on kernel ability to support them, for backward compatibility by default the features are disabled on 8.0 and earlier. Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychecnko --- hw/core/machine.c

Re: [PATCH] vdpa: set old virtio status at cvq isolation probing end

2023-08-01 Thread Jason Wang
On Tue, Aug 1, 2023 at 11:28 AM Jason Wang wrote: > > On Mon, Jul 31, 2023 at 5:41 PM Eugenio Perez Martin > wrote: > > > > On Mon, Jul 31, 2023 at 10:42 AM Jason Wang wrote: > > > > > > On Mon, Jul 31, 2023 at 4:05 PM Eugenio Perez Martin > > > wrote: > > > > > > > > On Mon, Jul 31, 2023 at 8:

Re: [PATCH v6 0/8] linux-user: brk fixes

2023-08-01 Thread Joel Stanley
On Tue, 1 Aug 2023 at 23:28, Helge Deller wrote: > > This patch series is a fix-up for some current problems > regarding heap memory / brk handling in qemu which happens > on some 32-bit platforms, e.g. problems loading static > binaries. > > This series includes the 5 patches from Akihiko Odaki >

Re: [PATCH QEMU 1/2] qapi: Reformat and craft the migration doc comments

2023-08-01 Thread Yong Huang
On Tue, Aug 1, 2023 at 8:33 PM Markus Armbruster wrote: > Yong Huang writes: > > > On Fri, Jul 28, 2023 at 3:49 PM Markus Armbruster > wrote: > > > >> ~hyman writes: > >> > >> > From: Hyman Huang(黄勇) > >> > > >> > Reformat migration doc comments to conform to current conventions > >> > as com

Re: [PATCH 0/3] hw/ufs: fix compilation warnings

2023-08-01 Thread Jeuk Kim
On 8/2/2023 6:03 AM, Philippe Mathieu-Daudé wrote: Hi Mike, On 28/7/23 01:34, Mike Maslenkin wrote: This patchset contains a trivial compilation fixes for UFS support applied to block-next tree. Since the series isn't merged, it would be clearer to send a v9 of "hw/ufs: Add Universal Flash St

Re: [PATCH QEMU v3 1/3] qapi: Reformat the dirty-limit migration doc comments

2023-08-01 Thread Yong Huang
On Tue, Aug 1, 2023 at 8:34 PM Markus Armbruster wrote: > ~hyman writes: > > > From: Hyman Huang(黄勇) > > > > Reformat the dirty-limit migration doc comments to conform > > to current conventions as commit a937b6aa739 (qapi: Reformat > > doc comments to conform to current conventions). > > > > S

Re: [PATCH v6 1/8] linux-user: Unset MAP_FIXED_NOREPLACE for host

2023-08-01 Thread Richard Henderson
On 8/1/23 16:27, Helge Deller wrote: From: Akihiko Odaki Passing MAP_FIXED_NOREPLACE to host will fail if the virtual address space is reserved with mmap. Replace it with MAP_FIXED. Signed-off-by: Akihiko Odaki Reviewed-by: Helge Deller Signed-off-by: Helge Deller --- linux-user/mmap.c |

[PATCH v6 7/8] linux-user: Optimize memory layout for static and dynamic executables

2023-08-01 Thread Helge Deller
Reorganize the guest memory layout to get as much memory as possible for heap for the guest application. This patch optimizes the memory layout by loading pie executables into lower memory and shared libs into higher memory (at TASK_UNMAPPED_BASE). This leaves a bigger memory area usable for heap

[PATCH v6 5/8] linux-user: Do not align brk with host page size

2023-08-01 Thread Helge Deller
From: Akihiko Odaki do_brk() minimizes calls into target_mmap() by aligning the address with host page size, which is potentially larger than the target page size. However, the current implementation of this optimization has two bugs: - The start of brk is rounded up with the host page size whil

[PATCH v6 4/8] linux-user: Do nothing if too small brk is specified

2023-08-01 Thread Helge Deller
From: Akihiko Odaki Linux 6.4.7 does nothing when a value smaller than the initial brk is specified. Fixes: 86f04735ac ("linux-user: Fix brk() to release pages") Signed-off-by: Akihiko Odaki Reviewed-by: Helge Deller Signed-off-by: Helge Deller --- linux-user/syscall.c | 6 +++--- 1 file cha

[PATCH v6 6/8] linux-user: Show heap address in /proc/pid/maps

2023-08-01 Thread Helge Deller
Show the memory location of the heap in the /proc/pid/maps file inside the guest. Store the heap address in ts->heap_base, which requires to make that variable accessible for all guest architectures, not just architectures for semihosted binaries (arm, m68k, riscv). Note that /proc/pid/maps in the

[PATCH v6 8/8] linux-user: Load pie executables at upper memory

2023-08-01 Thread Helge Deller
Fix the elf loader to calculate a valid TASK_UNMAPPED_BASE address for all 32-bit architectures, based on the GUEST_ADDR_MAX constant. Additionally modify the elf loader to load dynamic pie executables at around: ~ 0x55 for 64-bit guest binaries on 64-bit host, - 0x0030for 32-bit

[PATCH v6 3/8] linux-user: Use MAP_FIXED_NOREPLACE for do_brk()

2023-08-01 Thread Helge Deller
From: Akihiko Odaki MAP_FIXED_NOREPLACE can ensure the mapped address is fixed without concerning that the new mapping overwrites something else. Signed-off-by: Akihiko Odaki Reviewed-by: Helge Deller Signed-off-by: Helge Deller --- linux-user/syscall.c | 17 +++-- 1 file changed

[PATCH v6 2/8] linux-user: Do not call get_errno() in do_brk()

2023-08-01 Thread Helge Deller
From: Akihiko Odaki Later the returned value is compared with -1, and negated errno is not expected. Fixes: 00faf08c95 ("linux-user: Don't use MAP_FIXED in do_brk()") Signed-off-by: Akihiko Odaki Reviewed-by: Helge Deller Signed-off-by: Helge Deller --- linux-user/syscall.c | 6 +++--- 1 fil

[PATCH v6 1/8] linux-user: Unset MAP_FIXED_NOREPLACE for host

2023-08-01 Thread Helge Deller
From: Akihiko Odaki Passing MAP_FIXED_NOREPLACE to host will fail if the virtual address space is reserved with mmap. Replace it with MAP_FIXED. Signed-off-by: Akihiko Odaki Reviewed-by: Helge Deller Signed-off-by: Helge Deller --- linux-user/mmap.c | 2 ++ 1 file changed, 2 insertions(+) d

[PATCH v6 0/8] linux-user: brk fixes

2023-08-01 Thread Helge Deller
This patch series is a fix-up for some current problems regarding heap memory / brk handling in qemu which happens on some 32-bit platforms, e.g. problems loading static binaries. This series includes the 5 patches from Akihiko Odaki with some additional fixes and cleanups by me. Akihiko Odaki (5

Re: [PATCH v3 02/17] tests: Rename test-x86-cpuid.c to test-x86-topo.c

2023-08-01 Thread Moger, Babu
Zhao, On 8/1/23 05:35, Zhao Liu wrote: > From: Zhao Liu > > In fact, this unit tests APIC ID other than CPUID. This is not clear. The tests in test-x86-topo.c actually test the APIC ID combinations. Rename to test-x86-topo.c to make its name more in line with its actual content. > Rename to t

Re: [PATCH v3 00/17] Support smp.clusters for x86

2023-08-01 Thread Moger, Babu
Hi Zhao, On 8/1/23 05:35, Zhao Liu wrote: > From: Zhao Liu > > Hi list, > > This is the our v3 patch series, rebased on the master branch at the > commit 234320cd0573 ("Merge tag 'pull-target-arm-20230731' of https: > //git.linaro.org/people/pmaydell/qemu-arm into staging"). > > Comparing with

Re: [PATCH v3 01/17] i386: Fix comment style in topology.h

2023-08-01 Thread Moger, Babu
Hi Zhao, On 8/1/23 05:35, Zhao Liu wrote: > From: Zhao Liu > > For function comments in this file, keep the comment style consistent > with other places. s/with other places./with other files in the directory./ > > Signed-off-by: Zhao Liu > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Y

[PATCH v2 2/3] linux-user: Emulate /proc/cpuinfo on aarch64 and arm

2023-08-01 Thread Helge Deller
Add emulation for /proc/cpuinfo for arm architecture. The output below mimics output as seen on debian porterboxes. aarch64 output example: processor : 0 model name : ARMv8 Processor rev 0 (v8l) BogoMIPS: 100.00 Features: fp asimd aes pmull sha1 sha2 crc32 atomics fphp

[PATCH v2 3/3] linux-user: Emulate /proc/cpuinfo for Alpha

2023-08-01 Thread Helge Deller
Add emulation for /proc/cpuinfo for the alpha architecture. alpha output example: (alpha-chroot)root@p100:/# cat /proc/cpuinfo cpu : Alpha cpu model : ev67 cpu variation : 7 cpu revision: 0 cpu serial number : JA system type

[PATCH v2 1/3] linux-user: Fix openat() emulation to correctly detect accesses to /proc

2023-08-01 Thread Helge Deller
In qemu we catch accesses to files like /proc/cpuinfo or /proc/net/route and return to the guest contents which would be visible on a real system (instead what the host would show). This patch fixes a bug, where for example the accesses cat /proccpuinfo or cd /proc && cat cpuinfo will

[PATCH v2 0/3] linux-user: /proc/cpuinfo fix and content emulation for arm

2023-08-01 Thread Helge Deller
- One fix for correctly detecting /proc/cpuinfo access - A new /proc/cpuinfo output for arm/arm64. - A new /proc/cpuinfo output for Alpha Helge Deller (3): linux-user: Fix openat() emulation to correctly detect accesses to /proc linux-user: Emulate /proc/cpuinfo on aarch64 and arm linux-

[PULL 02/10] i386/xen: consistent locking around Xen singleshot timers

2023-08-01 Thread Philippe Mathieu-Daudé
From: David Woodhouse Coverity points out (CID 1507534, 1507968) that we sometimes access env->xen_singleshot_timer_ns under the protection of env->xen_timers_lock and sometimes not. This isn't always an issue. There are two modes for the timers; if the kernel supports the EVTCHN_SEND capability

[PULL 10/10] target/m68k: Fix semihost lseek offset computation

2023-08-01 Thread Philippe Mathieu-Daudé
From: Peter Maydell The arguments for deposit64 are (value, start, length, fieldval); this appears to have thought they were (value, fieldval, start, length). Reorder the parameters to match the actual function. Cc: qemu-sta...@nongnu.org Fixes: 950272506d ("target/m68k: Use semihosting/syscalls

[PULL 04/10] ui/dbus: fix win32 compilation when !opengl

2023-08-01 Thread Philippe Mathieu-Daudé
From: Marc-Andre Lureau Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1782 Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230725112540.53284-1-marcandre.lur...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé --- ui/dbus-listener.c | 4 +++- 1 fil

[PULL 01/10] hw/xen: fix off-by-one in xen_evtchn_set_gsi()

2023-08-01 Thread Philippe Mathieu-Daudé
From: David Woodhouse Coverity points out (CID 1508128) a bounds checking error. We need to check for gsi >= IOAPIC_NUM_PINS, not just greater-than. Also fix up an assert() that has the same problem, that Coverity didn't see. Fixes: 4f81baa33ed6 ("hw/xen: Support GSI mapping to PIRQ") Signed-of

[PULL 07/10] tests/migration: Add -fno-stack-protector

2023-08-01 Thread Philippe Mathieu-Daudé
From: Akihiko Odaki A build of GCC 13.2 will have stack protector enabled by default if it was configured with --enable-default-ssp option. For such a compiler, it is necessary to explicitly disable stack protector when linking without standard libraries. Signed-off-by: Akihiko Odaki Reviewed-b

[PULL 08/10] target/nios2: Pass semihosting arg to exit

2023-08-01 Thread Philippe Mathieu-Daudé
From: Keith Packard Instead of using R_ARG0 (the semihost function number), use R_ARG1 (the provided exit status). Signed-off-by: Keith Packard Reviewed-by: Peter Maydell Message-Id: <20230801152245.332749-1-kei...@keithp.com> Signed-off-by: Philippe Mathieu-Daudé --- target/nios2/nios2-semi

[PULL 05/10] ui/dbus: fix clang compilation issue

2023-08-01 Thread Philippe Mathieu-Daudé
From: Marc-André Lureau ../ui/dbus-listener.c:236:9: error: expected expression Error *err = NULL; See: https://gitlab.com/qemu-project/qemu/-/issues/1782#note_1488517427 Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <202307

[PULL 09/10] target/nios2: Fix semihost lseek offset computation

2023-08-01 Thread Philippe Mathieu-Daudé
From: Keith Packard The arguments for deposit64 are (value, start, length, fieldval); this appears to have thought they were (value, fieldval, start, length). Reorder the parameters to match the actual function. Signed-off-by: Keith Packard Reviewed-by: Philippe Mathieu-Daudé Fixes: d1e23cbaa4

[PULL 03/10] hw/xen: prevent guest from binding loopback event channel to itself

2023-08-01 Thread Philippe Mathieu-Daudé
From: David Woodhouse Fuzzing showed that a guest could bind an interdomain port to itself, by guessing the next port to be allocated and putting that as the 'remote' port number. By chance, that works because the newly-allocated port has type EVTCHNSTAT_unbound. It shouldn't. Signed-off-by: Dav

[PULL 06/10] misc: Fix some typos in documentation and comments

2023-08-01 Thread Philippe Mathieu-Daudé
From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230730180329.851576-1...@weilnetz.de> Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst| 2 +- docs/devel/qom.rst | 2 +- docs/system/dev

[PULL 00/10] Misc fixes for 2023-08-01

2023-08-01 Thread Philippe Mathieu-Daudé
The following changes since commit 802341823f1720511dd5cf53ae40285f7978c61b: Merge tag 'pull-tcg-20230731' of https://gitlab.com/rth7680/qemu into staging (2023-07-31 14:02:51 -0700) are available in the Git repository at: https://github.com/philmd/qemu.git tags/misc-fixes-202

Re: [PATCH 2/3] tests/migration: Add -fno-stack-protector

2023-08-01 Thread Philippe Mathieu-Daudé
On 31/7/23 08:58, Akihiko Odaki wrote: A build of GCC 13.2 will have stack protector enabled by default if it was configured with --enable-default-ssp option. For such a compiler, it is necessary to explicitly disable stack protector when linking without standard libraries. Signed-off-by: Akihik

Re: [PATCH] ui/dbus: fix win32 compilation when !opengl

2023-08-01 Thread Philippe Mathieu-Daudé
On 25/7/23 13:25, marcandre.lur...@redhat.com wrote: From: Marc-Andre Lureau Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1782 Signed-off-by: Marc-André Lureau --- ui/dbus-listener.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Thanks, queued via misc-fixes.

Re: [PATCH] target/nios2: Fix semihost lseek offset computation

2023-08-01 Thread Philippe Mathieu-Daudé
On 1/8/23 01:52, Keith Packard via wrote: The arguments for deposit64 are (value, start, length, fieldval); this appears to have thought they were (value, fieldval, start, length). Reorder the parameters to match the actual function. Signed-off-by: Keith Packard --- target/nios2/nios2-semi.c

Re: [PATCH for-8.1] target/m68k: Fix semihost lseek offset computation

2023-08-01 Thread Philippe Mathieu-Daudé
On 1/8/23 17:45, Peter Maydell wrote: The arguments for deposit64 are (value, start, length, fieldval); this appears to have thought they were (value, fieldval, start, length). Reorder the parameters to match the actual function. Cc: qemu-sta...@nongnu.org Fixes: 950272506d ("target/m68k: Use se

Re: [PATCH for-8.1] Misc Xen-on-KVM fixes

2023-08-01 Thread Philippe Mathieu-Daudé
On 1/8/23 19:57, David Woodhouse wrote: A few minor fixes for the Xen emulation support. One was just merged, but there are three outstanding. David Woodhouse (3): hw/xen: fix off-by-one in xen_evtchn_set_gsi() i386/xen: consistent locking around Xen singleshot timers hw/xen

Re: [PATCH] target/nios2: Pass semihosting arg to exit

2023-08-01 Thread Philippe Mathieu-Daudé
On 1/8/23 17:22, Keith Packard via wrote: Instead of using R_ARG0 (the semihost function number), use R_ARG1 (the provided exit status). Signed-off-by: Keith Packard --- target/nios2/nios2-semi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Thanks, queued via misc-fixes.

Re: [PATCH] Fix some typos in documentation and comments

2023-08-01 Thread Philippe Mathieu-Daudé
On 30/7/23 20:03, Stefan Weil wrote: Signed-off-by: Stefan Weil --- This patch was triggered by a spelling check for the generated QEMU documentation using codespell. It does not try to fix all typos which still exist in the QEMU code, but has a focus on those required to fix the documentation.

Re: [PATCH] ui/dbus: fix clang compilation issue

2023-08-01 Thread Philippe Mathieu-Daudé
On 26/7/23 17:12, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau ../ui/dbus-listener.c:236:9: error: expected expression Error *err = NULL; See: https://gitlab.com/qemu-project/qemu/-/issues/1782#note_1488517427 Signed-off-by: Marc-André Lureau --- ui/dbus-listener.c |

[PATCH v1] Allowing setting and overriding parameters in smb.conf

2023-08-01 Thread Henrik Carlqvist
>From c480f787981308067a059213a1a7ce9c70ab668e Mon Sep 17 00:00:00 2001 From: Henrik Carlqvist Date: Tue, 1 Aug 2023 23:00:15 +0200 Subject: [PATCH] Allowing setting and overriding parameters in smb.conf Signed-off-by: Henrik Carlqvist --- It would be nice to be able to change settings in smb.c

Re: [PATCH 1/2] linux-user: Fix openat() emulation to correctly detect accesses to /proc

2023-08-01 Thread Daniel P . Berrangé
On Tue, Aug 01, 2023 at 09:10:34PM +0200, Helge Deller wrote: > In qemu we catch accesses to files like /proc/cpuinfo or /proc/net/route > and return to the guest contents which would be visible on a real system > (instead what the host would show). > > This patch fixes a bug, where for example th

Re: [PATCH 3/3] accel/tcg: Do not issue misaligned i/o

2023-08-01 Thread Philippe Mathieu-Daudé
On 1/8/23 20:42, Richard Henderson wrote: In the single-page case we were issuing misaligned i/o to the memory subsystem, which does not handle it properly. Split such accesses via do_{ld,st}_mmio_*. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1800 Signed-off-by: Richard Henderson -

Re: [PATCH 2/3] accel/tcg: Issue wider aligned i/o in do_{ld,st}_mmio_*

2023-08-01 Thread Philippe Mathieu-Daudé
On 1/8/23 20:42, Richard Henderson wrote: If the address and size are aligned, send larger chunks to the memory subsystem. This will be required to make more use of these helpers. Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 76 +- 1

Re: [PATCH] gdbstub: use 0 ("any process") on packets with no PID

2023-08-01 Thread Ilya Leoshkevich
On Tue, 2023-08-01 at 12:37 -0300, Matheus Tavares Bernardino wrote: > Previously, qemu-user would always report PID 1 to GDB. This was > changed > at dc14a7a6e9 (gdbstub: Report the actual qemu-user pid, 2023-06-30), > but read_thread_id() still considers GDB packets with "no PID" as > "PID > 1",

Re: [PATCH 1/3] accel/tcg: Adjust parameters and locking with do_{ld, st}_mmio_*

2023-08-01 Thread Philippe Mathieu-Daudé
Hi Richard, On 1/8/23 20:42, Richard Henderson wrote: Replace MMULookupPageData* with CPUTLBEntryFull, addr, size. Move QEMU_IOTHREAD_LOCK_GUARD to the caller. This simplifies the usage from do_ld16_beN and do_st16_leN, where we weren't locking the entire operation, and required hoop jumping fo

Re: [PATCH 0/3] hw/ufs: fix compilation warnings

2023-08-01 Thread Philippe Mathieu-Daudé
Hi Mike, On 28/7/23 01:34, Mike Maslenkin wrote: This patchset contains a trivial compilation fixes for UFS support applied to block-next tree. Since the series isn't merged, it would be clearer to send a v9 of "hw/ufs: Add Universal Flash Storage (UFS) support" with the fixes squashed in (the

Re: [PATCH v3 3/3] cpu, softmmu/vl.c: Change parsing of -cpu argument to allow -cpu cpu, help to print options for the CPU type similar to how the '-device' option works.

2023-08-01 Thread Dinah B
Thanks, I will fix this. I somehow didn't catch that you had replied to the old one. -Dinah On Tue, Aug 1, 2023 at 10:10 AM Markus Armbruster wrote: > Dinah Baum writes: > > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1480 > > Signed-off-by: Dinah Baum > > > > Signed-off-by: Din

Re: [PATCH] gdbstub: Fix client Ctrl-C handling

2023-08-01 Thread Philippe Mathieu-Daudé
On 31/7/23 15:59, Peter Maydell wrote: On Mon, 31 Jul 2023 at 07:59, Joel Stanley wrote: On Sun, 30 Jul 2023 at 09:43, Nicholas Piggin wrote: On Wed Jul 26, 2023 at 4:35 PM AEST, Joel Stanley wrote: On Wed, 12 Jul 2023 at 02:12, Nicholas Piggin wrote: I was taking a look at -rc1 and i

Re: [PATCH v2 06/11] tpm_crb: move ACPI table building to device interface

2023-08-01 Thread Stefan Berger
On 7/31/23 23:02, Joelle van Dyne wrote: On Mon, Jul 17, 2023 at 6:42 AM Igor Mammedov wrote: On Fri, 14 Jul 2023 13:21:33 -0400 Stefan Berger wrote: On 7/14/23 03:09, Joelle van Dyne wrote: This logic is similar to TPM TIS ISA device. Since TPM CRB can only support TPM 2.0 backends, we

Re: [PATCH 2/2] linux-user: Emulate /proc/cpuinfo on aarch64 and arm

2023-08-01 Thread Richard Henderson
On 8/1/23 12:10, Helge Deller wrote: +dprintf(fd, "CPU implementer\t: 0x%d\n", is64 ? 50 : 56); +dprintf(fd, "CPU architecture: %d\n",is64 ? 8 : 7); +dprintf(fd, "CPU variant\t: 0x%d\n", is64 ? 0 : 2); +dprintf(fd, "CPU part\t: 0x%d\n",is64 ? 0 : 58

[PATCH 2/2] linux-user: Emulate /proc/cpuinfo on aarch64 and arm

2023-08-01 Thread Helge Deller
Add emulation for /proc/cpuinfo for arm architecture. The output below mimics output as seen on debian porterboxes. aarch64 output example: processor : 0 BogoMIPS: 100.00 Features: fp asimd aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop

[PATCH 0/2] linux-user: /proc/cpuinfo fix and content emulation for arm

2023-08-01 Thread Helge Deller
One fix for correctly detecting /proc/cpuinfo access and new /proc/cpuinfo output for arm/arm64 Helge Deller (2): linux-user: Fix openat() emulation to correctly detect accesses to /proc linux-user: Emulate /proc/cpuinfo on aarch64 and arm linux-user/elfload.c | 130 +

[PATCH 1/2] linux-user: Fix openat() emulation to correctly detect accesses to /proc

2023-08-01 Thread Helge Deller
In qemu we catch accesses to files like /proc/cpuinfo or /proc/net/route and return to the guest contents which would be visible on a real system (instead what the host would show). This patch fixes a bug, where for example the accesses cat /proccpuinfo or cd /proc && cat cpuinfo will

Re: [PATCH 6/8] configure: support passthrough of -Dxxx args to meson

2023-08-01 Thread Daniel P . Berrangé
On Tue, Aug 01, 2023 at 08:42:05PM +0200, Thomas Huth wrote: > On 01/08/2023 15.04, Daniel P. Berrangé wrote: > > This can be useful for setting some meson global options, such as the > > optimization level or debug state.xs > > > > Signed-off-by: Daniel P. Berrangé > > --- > > configure | 5 ++

Re: [PATCH 7/8] gitlab: disable optimization and debug symbols in msys build

2023-08-01 Thread Daniel P . Berrangé
On Tue, Aug 01, 2023 at 08:44:02PM +0200, Thomas Huth wrote: > On 01/08/2023 15.04, Daniel P. Berrangé wrote: > > Building at -O2, adds 33% to the build time, over -O2. IOW a build that > > takes 45 minutes at -O0, takes 60 minutes at -O2. Turning off debug > > symbols drops it further, down to 38

Re: [PATCH 0/8] gitlab: speed up msys windows jobs with GCC

2023-08-01 Thread Thomas Huth
On 01/08/2023 15.03, Daniel P. Berrangé wrote: This is an alternative and/or complementary to Thomas' proposal to use CLang with msys: https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg05402.html First of all, the current msys installer we're using is over 12 months out of date. Thus

Re: [PATCH 8/8] gitlab: disable FF_SCRIPT_SECTIONS on msys jobs

2023-08-01 Thread Thomas Huth
On 01/08/2023 15.04, Daniel P. Berrangé wrote: The FF_SCRIPT_SECTIONS=1 variable should ordinarily cause output from each line of the job script to be presented in a collapsible section with execution time listed. While it works on Linux shared runners, when used with Windows runners with PowerS

Re: [PATCH 7/8] gitlab: disable optimization and debug symbols in msys build

2023-08-01 Thread Thomas Huth
On 01/08/2023 15.04, Daniel P. Berrangé wrote: Building at -O2, adds 33% to the build time, over -O2. IOW a build that takes 45 minutes at -O0, takes 60 minutes at -O2. Turning off debug symbols drops it further, down to 38 minutes. IOW, a "-O2 -g" build is 58% slower than a "-O0" build on msys

[PATCH for-8.1 0/3] accel/tcg: Do not issue misaligned i/o

2023-08-01 Thread Richard Henderson
Fixing #1800, and possibly more. r~ Richard Henderson (3): accel/tcg: Adjust parameters and locking with do_{ld,st}_mmio_* accel/tcg: Issue wider aligned i/o in do_{ld,st}_mmio_* accel/tcg: Do not issue misaligned i/o accel/tcg/cputlb.c | 251 ++---

[PATCH 2/3] accel/tcg: Issue wider aligned i/o in do_{ld,st}_mmio_*

2023-08-01 Thread Richard Henderson
If the address and size are aligned, send larger chunks to the memory subsystem. This will be required to make more use of these helpers. Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 76 +- 1 file changed, 69 insertions(+), 7 deletions(-)

[PATCH 1/3] accel/tcg: Adjust parameters and locking with do_{ld, st}_mmio_*

2023-08-01 Thread Richard Henderson
Replace MMULookupPageData* with CPUTLBEntryFull, addr, size. Move QEMU_IOTHREAD_LOCK_GUARD to the caller. This simplifies the usage from do_ld16_beN and do_st16_leN, where we weren't locking the entire operation, and required hoop jumping for passing addr and size. Signed-off-by: Richard Henderso

Re: [PATCH 6/8] configure: support passthrough of -Dxxx args to meson

2023-08-01 Thread Thomas Huth
On 01/08/2023 15.04, Daniel P. Berrangé wrote: This can be useful for setting some meson global options, such as the optimization level or debug state.xs Signed-off-by: Daniel P. Berrangé --- configure | 5 + 1 file changed, 5 insertions(+) diff --git a/configure b/configure index 26ec5

[PATCH 3/3] accel/tcg: Do not issue misaligned i/o

2023-08-01 Thread Richard Henderson
In the single-page case we were issuing misaligned i/o to the memory subsystem, which does not handle it properly. Split such accesses via do_{ld,st}_mmio_*. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1800 Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 118 +++

Re: [PATCH] gdbstub: Fix client Ctrl-C handling

2023-08-01 Thread Matheus Tavares Bernardino
Hi, Nick. > Nicholas Piggin wrote: > > On Tue Jul 11, 2023 at 9:03 PM AEST, Matheus Tavares Bernardino wrote: > > > Nicholas Piggin wrote: > > > > > > diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c > > > index 6911b73c07..ce8b42eb15 100644 > > > --- a/gdbstub/gdbstub.c > > > +++ b/gdbstub/gd

Re: [PATCH 2/8] gitlab: print timestamps during windows msys jobs

2023-08-01 Thread Thomas Huth
On 01/08/2023 15.03, Daniel P. Berrangé wrote: It is hard to get visibility into where time is consumed in our Windows msys jobs. Adding a few log console messages with the timestamp will aid in our debugging. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/windows.yml | 5 + 1 file c

Re: [PATCH 1/8] gitlab: remove duplication between msys jobs

2023-08-01 Thread Thomas Huth
On 01/08/2023 15.03, Daniel P. Berrangé wrote: Although they share a common parent, the two msys jobs still have massive duplication in their script definitions that can easily be collapsed. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/windows.yml | 132 +++--

Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang

2023-08-01 Thread Thomas Huth
On 01/08/2023 15.49, Daniel P. Berrangé wrote: ... If the value of the msys2 jobs is that they let us run the test suite, can we limit the usage of msys2 to just that part, and chain it upto the fedora mingw cross compile jobs ie. win64-fedora-cross-container | +-> cross-win64-syste

Re: [PATCH 0/8] gitlab: speed up msys windows jobs with GCC

2023-08-01 Thread Thomas Huth
On 01/08/2023 16.35, Daniel P. Berrangé wrote: On Tue, Aug 01, 2023 at 03:53:22PM +0200, Markus Armbruster wrote: Daniel P. Berrangé writes: This is an alternative and/or complementary to Thomas' proposal to use CLang with msys: https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg054

Re: [PATCH for-8.1] target/m68k: Fix semihost lseek offset computation

2023-08-01 Thread Philippe Mathieu-Daudé
On 1/8/23 17:45, Peter Maydell wrote: The arguments for deposit64 are (value, start, length, fieldval); this appears to have thought they were (value, fieldval, start, length). Reorder the parameters to match the actual function. Cc: qemu-sta...@nongnu.org Fixes: 950272506d ("target/m68k: Use se

[PATCH for-8.1 1/3] hw/xen: fix off-by-one in xen_evtchn_set_gsi()

2023-08-01 Thread David Woodhouse
From: David Woodhouse Coverity points out (CID 1508128) a bounds checking error. We need to check for gsi >= IOAPIC_NUM_PINS, not just greater-than. Also fix up an assert() that has the same problem, that Coverity didn't see. Fixes: 4f81baa33ed6 ("hw/xen: Support GSI mapping to PIRQ") Signed-of

[PATCH for-8.1 3/3] hw/xen: prevent guest from binding loopback event channel to itself

2023-08-01 Thread David Woodhouse
From: David Woodhouse Fuzzing showed that a guest could bind an interdomain port to itself, by guessing the next port to be allocated and putting that as the 'remote' port number. By chance, that works because the newly-allocated port has type EVTCHNSTAT_unbound. It shouldn't. Signed-off-by: Dav

[PATCH for-8.1 2/3] i386/xen: consistent locking around Xen singleshot timers

2023-08-01 Thread David Woodhouse
From: David Woodhouse Coverity points out (CID 1507534, 1507968) that we sometimes access env->xen_singleshot_timer_ns under the protection of env->xen_timers_lock and sometimes not. This isn't always an issue. There are two modes for the timers; if the kernel supports the EVTCHN_SEND capability

[PATCH for-8.1] Misc Xen-on-KVM fixes

2023-08-01 Thread David Woodhouse
A few minor fixes for the Xen emulation support. One was just merged, but there are three outstanding. David Woodhouse (3): hw/xen: fix off-by-one in xen_evtchn_set_gsi() i386/xen: consistent locking around Xen singleshot timers hw/xen: prevent guest from binding loopback event c

Re: [PULL 0/5] Misc fixes, for thread-pool, xen, and xen-emulate

2023-08-01 Thread Richard Henderson
https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git tags/pull-xen-20230801 for you to fetch changes up to 856ca10f9ce1fcffeab18546b36a64f79017c905: xen-platform: do full PCI reset during unplug of IDE devices (2023-08-01 10:2

[PULL 0/1 for 8.1] TLS crash fix

2023-08-01 Thread Daniel P . Berrangé
The following changes since commit 802341823f1720511dd5cf53ae40285f7978c61b: Merge tag 'pull-tcg-20230731' of https://gitlab.com/rth7680/qemu into staging (2023-07-31 14:02:51 -0700) are available in the Git repository at: https://gitlab.com/berrange/qemu tags/io-tls-hs-crash-pull-request

[PULL 1/1] io: remove io watch if TLS channel is closed during handshake

2023-08-01 Thread Daniel P . Berrangé
The TLS handshake make take some time to complete, during which time an I/O watch might be registered with the main loop. If the owner of the I/O channel invokes qio_channel_close() while the handshake is waiting to continue the I/O watch must be removed. Failing to remove it will later trigger the

Re: [PATCH v2] io: remove io watch if TLS channel is closed during handshake

2023-08-01 Thread Michael Tokarev
12.07.2023 19:55, Daniel P. Berrangé wrote: The TLS handshake make take some time to complete, during which time an I/O watch might be registered with the main loop. If the owner of the I/O channel invokes qio_channel_close() while the handshake is waiting to continue the I/O watch must be remove

Re: [RFC PATCH 08/19] HostMem: Add private property to indicate to use kvm gmem

2023-08-01 Thread David Hildenbrand
On 31.07.23 18:21, Xiaoyao Li wrote: From: Isaku Yamahata Signed-off-by: Isaku Yamahata Signed-off-by: Xiaoyao Li --- backends/hostmem.c | 18 ++ include/sysemu/hostmem.h | 2 +- qapi/qom.json| 4 3 files changed, 23 insertions(+), 1 deletion(-)

Re: [RFC PATCH 05/19] kvm: Enable KVM_SET_USER_MEMORY_REGION2 for memslot

2023-08-01 Thread Claudio Fontana
On 7/31/23 18:21, Xiaoyao Li wrote: > From: Chao Peng > > Switch to KVM_SET_USER_MEMORY_REGION2 when supported by KVM. > > With KVM_SET_USER_MEMORY_REGION2, QEMU can set up memory region that > backen'ed both by hva-based shared memory and gmem fd based private > memory. > > Signed-off-by: Chao

Re: [PATCH] migration/calc-dirty-rate: millisecond precision period

2023-08-01 Thread Peter Xu
On Thu, Jun 29, 2023 at 11:59:03AM +0300, Andrei Gudkov wrote: > Introduces alternative argument calc-time-ms, which is the > the same as calc-time but accepts millisecond value. > Millisecond precision allows to make predictions whether > migration will succeed or not. To do this, calculate dirty

Re: [PATCH v5 01/11] hw: arm: Add bananapi M2-Ultra and allwinner-r40 support

2023-08-01 Thread Guenter Roeck
On 8/1/23 09:01, Peter Maydell wrote: On Sat, 24 Jun 2023 at 16:02, Guenter Roeck wrote: On 6/24/23 07:23, Guenter Roeck wrote: On 6/24/23 03:40, Peter Maydell wrote: On Fri, 23 Jun 2023 at 20:33, Guenter Roeck wrote: On 6/23/23 10:44, Peter Maydell wrote: On Sat, 17 Jun 2023 at 17:29, G

Re: [Qemu-devel] [PATCH] acpi: Add emulated sleep button

2023-08-01 Thread Annie.li
Hi Igor, On 7/14/2023 10:04 AM, Igor Mammedov wrote: On Fri, 7 Jul 2023 13:43:36 -0400 "Annie.li" wrote: Hi Igor, Revisiting this thread and have more questions, please clarify, thank you! On 9/20/2021 3:53 AM, Igor Mammedov wrote: On Fri, 6 Aug 2021 16:18:09 -0400 "Annie.li" wrote: H

Re: [PATCH] migration/calc-dirty-rate: millisecond precision period

2023-08-01 Thread Peter Xu
On Tue, Aug 01, 2023 at 05:55:29PM +0300, gudkov.and...@huawei.com wrote: > Hmmm, such underestimation looks strange to me. I am willing to test > page-sampling and see whether its quality can be improved. Do you have > any specific suggestions on the application to use as a workload? I could have

Re: [RFC PATCH 04/19] memory: Introduce memory_region_can_be_private()

2023-08-01 Thread Claudio Fontana
On 8/1/23 18:48, Claudio Fontana wrote: > On 7/31/23 18:21, Xiaoyao Li wrote: >> Signed-off-by: Xiaoyao Li >> --- >> include/exec/memory.h | 9 + >> softmmu/memory.c | 5 + >> 2 files changed, 14 insertions(+) >> >> diff --git a/include/exec/memory.h b/include/exec/memory.h >> in

Re: [RFC PATCH 04/19] memory: Introduce memory_region_can_be_private()

2023-08-01 Thread Claudio Fontana
On 7/31/23 18:21, Xiaoyao Li wrote: > Signed-off-by: Xiaoyao Li > --- > include/exec/memory.h | 9 + > softmmu/memory.c | 5 + > 2 files changed, 14 insertions(+) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 61e31c7b9874..e119d3ce1a1d 100644 > --- a/inc

Re: [RFC PATCH 03/19] RAMBlock: Support KVM gmemory

2023-08-01 Thread David Hildenbrand
On 31.07.23 18:21, Xiaoyao Li wrote: From: Chao Peng Add KVM gmem support to RAMBlock so we can have both normal hva based memory and gmem fd based memory in one RAMBlock. The gmem part is represented by the gmem_fd. Signed-off-by: Chao Peng Signed-off-by: Xiaoyao Li So, *someone* creates

Re: [RFC PATCH 04/19] memory: Introduce memory_region_can_be_private()

2023-08-01 Thread Sean Christopherson
On Mon, Jul 31, 2023, Peter Xu wrote: > On Mon, Jul 31, 2023 at 05:36:37PM -0400, Michael S. Tsirkin wrote: > > On Mon, Jul 31, 2023 at 02:34:22PM -0700, Sean Christopherson wrote: > > > On Mon, Jul 31, 2023, Peter Xu wrote: > > > > On Mon, Jul 31, 2023 at 12:21:46PM -0400, Xiaoyao Li wrote: > > >

Re: [PATCH] linux-user: Fix openat() emulation to correctly detect accesses to /proc

2023-08-01 Thread Daniel P . Berrangé
On Tue, Aug 01, 2023 at 04:58:57PM +0200, Helge Deller wrote: > In qemu we catch accesses to files like /proc/cpuinfo or /proc/net/route > and return to the guest contents which would be visible on a real system > (instead what the host would show). > > This patch fixes a bug, where for example th

[PATCH 1/2] block/blkio: close the fd when blkio_connect() fails

2023-08-01 Thread Stefano Garzarella
libblkio drivers take ownership of `fd` only after a successful blkio_connect(), so if it fails, we are still the owners. Fixes: cad2ccc395 ("block/blkio: use qemu_open() to support fd passing for virtio-blk") Suggested-by: Hanna Czenczek Signed-off-by: Stefano Garzarella --- block/blkio.c | 9

  1   2   >