On 01/08/2023 15.03, Daniel P. Berrangé wrote:
Although they share a common parent, the two msys jobs still have
massive duplication in their script definitions that can easily be
collapsed.

Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
---
  .gitlab-ci.d/windows.yml | 132 +++++++++++++++------------------------
  1 file changed, 49 insertions(+), 83 deletions(-)

As I discovered in the recent days, this is also quite helpful in case we ever want to switch to Clang, since we need to change the prefix of the packages there. And it's still easy to have distinct packages with some few lines of codes changes, as I tried it out in my Clang patch. So this patch now sounds fine to me:

Reviewed-by: Thomas Huth <th...@redhat.com>


Reply via email to