On Tue, Aug 01, 2023 at 08:42:05PM +0200, Thomas Huth wrote: > On 01/08/2023 15.04, Daniel P. Berrangé wrote: > > This can be useful for setting some meson global options, such as the > > optimization level or debug state.xs > > > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > > --- > > configure | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/configure b/configure > > index 26ec5e4f54..9fe3718b77 100755 > > --- a/configure > > +++ b/configure > > @@ -757,6 +757,9 @@ for opt do > > # everything else has the same name in configure and meson > > --*) meson_option_parse "$opt" "$optarg" > > ;; > > + # Pass through -Dxxxx options to meson > > + -D*) meson_options="$meson_options $opt" > > + ;; > > esac > > done > > @@ -887,6 +890,8 @@ cat << EOF > > pie Position Independent Executables > > debug-tcg TCG debugging (default is disabled) > > + -Dmesonoptname=val passthrough option to meson unmodified > > I'd rather place that earlier in the help text, above the > "meson_options_help" line in the configure script, next to the other > --option=something lines.
Sure I've no preference. I was expecting Paolo to tell me to put it somewhere else anyway :-) With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
