Re: [PATCH v3] target: ppc: Use MSR_HVB bit to get the target endianness for memory dump

On 5/22/23 23:50, Greg Kurz wrote: On Mon, 22 May 2023 12:02:42 -0400 Narayana Murty N wrote: Currently on PPC64 qemu always dumps the guest memory in Big Endian (BE) format even though the guest running in Little Endian (LE) mode. So crash tool fails to load the dump as illustrated below: L

[PATCH 1/3] hw/mips/jazz: Fix modifying QOM class internal state from instance

QOM object instance should not modify its class state (because all other objects instanciated from this class get affected). Instead of modifying the MIPSCPUClass 'no_data_aborts' field in the instance machine_init() handler, set it in the machine class_init handler. Since 2 machines require this,

[PATCH 2/3] hw/ppc/e500plat: Fix modifying QOM class internal state from instance

QOM object instance should not modify its class state (because all other objects instanciated from this class get affected). Instead of modifying the PPCE500MachineClass 'mpic_version' field in the instance machine_init() handler, set it in the machine class init handler (e500plat_machine_class_in

[PATCH 3/3] hw/i2c/pmbus_device: Fix modifying QOM class internals from instance

QOM object instance should not modify its class state (because all other objects instanciated from this class get affected). Instead of modifying the PMBusDeviceClass 'device_num_pages' field the first time a instance is initialized (in pmbus_pages_alloc), introduce a new pmbus_pages_num() helper

[PATCH 0/3] hw: Fix abuse of QOM class internals modified by their instances

Bernhard warned for QOM class abuse here [*]: > A realize method is supposed to modify a single instance only > while we're modifying the behavior of whole classes here, i.e. > will affect every instance of these classes. This goes against > QOM design principles and will therefore be confusing fo

[PATCH] hw/ppc/openpic: Do not open-code ROUND_UP() macro

While reviewing, the ROUND_UP() macro is easier to figure out. Besides, the comment confirms we want to round up here. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ppc/openpic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/ppc/openpic.h b/include/hw/ppc/

[PATCH 2/4] hw/i386/microvm: Simplify using object_dynamic_cast()

Use object_dynamic_cast() to determine if 'dev' is a TYPE_VIRTIO_MMIO. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/microvm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c index 3d606a20b4..7227a2156c 100644 --- a/hw/i386/microvm

[PATCH 4/4] hw/usb/hcd-ehci-pci: Simplify using DEVICE_GET_CLASS() macro

Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/hcd-ehci-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-ehci-pci.c b/hw/usb/hcd-ehci-pci.c index 4c37c8e227..345444a573 100644 --- a/hw/usb/hcd-ehci-pci.c +++ b/hw/usb/hcd-ehci-pci.c @@ -74,7 +74,7 @@ static vo

[PATCH 0/4] hw: Minor simplifications using proper QOM getter macros

Enforce QOM style. Besides, using the proper QOM macros slightly simplifies the code. Philippe Mathieu-Daudé (4): hw/core/cpu: Simplify realize() using MACHINE_GET_CLASS() macro hw/i386/microvm: Simplify using object_dynamic_cast() hw/pci/pci: Simplify pci_bar_address() using MACHINE_GET_CLA

[PATCH 3/4] hw/pci/pci: Simplify pci_bar_address() using MACHINE_GET_CLASS() macro

Remove unnecessary intermediate variables. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci/pci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 1cc7c89036..a2cb6071cb 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1444,9 +1444,7 @@ pci

[PATCH 1/4] hw/core/cpu: Simplify realize() using MACHINE_GET_CLASS() macro

Signed-off-by: Philippe Mathieu-Daudé --- hw/core/cpu-common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c index 5ccc3837b6..620312e9a5 100644 --- a/hw/core/cpu-common.c +++ b/hw/core/cpu-common.c @@ -196,8 +196,7 @@ static voi

Re: [PATCH] meson: remove -no-pie linker flag

Am 22.05.23 um 10:08 schrieb Paolo Bonzini: The large comment in the patch says it all; the -no-pie flag is broken and this is why it was not included in QEMU_LDFLAGS before commit a988b4c5614 ("build: move remaining compiler flag tests to meson", 2023-05-18). Resolves: https://gitlab.com/qemu-p

Re: [PATCH v2 1/1] Add vpd data for Rainier machine

On 5/22/23 17:36, Ninad Palsule wrote: The VPD data is added for system and BMC FRU. This data is fabricated. Tested: - The system-vpd.service is active. - VPD service related to bmc is active. Signed-off-by: Ninad Palsule Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/as

Re: [PATCH] ui/cursor: incomplete check for integer overflow in cursor_alloc

> > -QEMUCursor *cursor_alloc(int width, int height) > > +QEMUCursor *cursor_alloc(uint32_t width, uint32_t height) > >  { > >      QEMUCursor *c; > > Can't we check width/height > 0 && <= SOME_LIMIT_THAT_MAKES_SENSE? > > Maybe a 16K * 16K cursor is future proof and safe enough.

Re: [PATCH 1/4] hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes

> 2023年5月23日 02:25，Song Gao 写道： > > > > 在 2023/5/22 下午9:44, Philippe Mathieu-Daudé 写道: >> On 22/5/23 13:47, Jiaxun Yang wrote: >>> >>> 2023年5月22日 04:52，Huacai Chen 写道： Hi, Jiaxun, Rename loongarch_ipi to loongson_ipi? It will be shared by both MIPS and Loon

Re: [PATCH] acpi/tests/avocado/bits: enable bios bits avocado tests on gitlab CI pipeline

> On 22-May-2023, at 11:30 PM, Thomas Huth wrote: > > On 21/05/2023 07.51, Michael S. Tsirkin wrote: >> On Fri, May 19, 2023 at 08:44:18PM +0530, Ani Sinha wrote: >>> >>> On 17-May-2023, at 12:23 PM, Ani Sinha wrote: Biosbits avocado tests on gitlab has thus far been disable

Re: [PULL v2 0/4] QAPI patches patches for 2023-05-17

On 5/22/23 04:20, Markus Armbruster wrote: The following changes since commit aa222a8e4f975284b3f8f131653a4114b3d333b3: Merge tag 'for_upstream' ofhttps://git.kernel.org/pub/scm/virt/kvm/mst/qemu into staging (2023-05-19 12:17:16 -0700) are available in the Git repository at: https://r

Re: [PATCH v4 03/11] hw: allwinner-r40: Complete uart devices

在 2023/5/15 2:55, Niek Linnenbank 写道: Hi Qianfan, On Wed, May 10, 2023 at 12:30 PM wrote: From: qianfan Zhao R40 has eight UARTs, support both 16450 and 16550 compatible modes. Signed-off-by: qianfan Zhao ---  hw/arm/allwinner-r40.c         | 31

Re: [PATCH v8 4/7] igb: RX payload guest writting refactoring

On 2023/05/18 23:04, Tomasz Dzieciol wrote: Refactoring is done in preparation for support of multiple advanced descriptors RX modes, especially packet-split modes. Signed-off-by: Tomasz Dzieciol --- hw/net/e1000e_core.c | 18 ++-- hw/net/igb_core.c| 214

Re: [PATCH v8 3/7] igb: RX descriptors guest writting refactoring

On 2023/05/18 23:04, Tomasz Dzieciol wrote: Refactoring is done in preparation for support of multiple advanced descriptors RX modes, especially packet-split modes. Signed-off-by: Tomasz Dzieciol --- hw/net/igb_core.c | 178 +++- hw/net/igb_regs.h

Re: [PATCH v8 0/7] igb: packet-split descriptors support

On 2023/05/18 23:04, Tomasz Dzieciol wrote: Based-on: <20230423041833.5302-1-akihiko.od...@daynix.com> ("[PATCH v3 00/47] igb: Fix for DPDK") Purposes of this series of patches: * introduce packet-split RX descriptors support. This feature is used by Linux VF driver for MTU values from 2048.

[PATCH v5 11/48] tests/avocado: Remove unused imports

Signed-off-by: Akihiko Odaki --- tests/avocado/netdev-ethtool.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/avocado/netdev-ethtool.py b/tests/avocado/netdev-ethtool.py index f7e9464184..8de118e313 100644 --- a/tests/avocado/netdev-ethtool.py +++ b/tests/avocado/netdev-ethtool.py @@

[PATCH v5 24/48] igb: Add more definitions for Tx descriptor

Signed-off-by: Akihiko Odaki Reviewed-by: Sriram Yagnaraman --- hw/net/igb_regs.h | 32 +++- hw/net/igb_core.c | 4 ++-- 2 files changed, 29 insertions(+), 7 deletions(-) diff --git a/hw/net/igb_regs.h b/hw/net/igb_regs.h index 21ee9a3b2d..eb995d8b2e 100644 --- a/hw

[PATCH v5 40/48] igb: Implement igb-specific oversize check

igb has a configurable size limit for LPE, and uses different limits depending on whether the packet is treated as a VLAN packet. Signed-off-by: Akihiko Odaki Reviewed-by: Sriram Yagnaraman --- hw/net/igb_core.c | 36 +--- 1 file changed, 21 insertions(+), 15 del

[PATCH v5 23/48] vmxnet3: Reset packet state after emptying Tx queue

Keeping Tx packet state after the transmit queue is emptied but this behavior is unreliable as the state can be reset anytime the migration happens. Always reset Tx packet state always after the queue is emptied. Signed-off-by: Akihiko Odaki --- hw/net/vmxnet3.c | 3 ++- 1 file changed, 2 inser

[PATCH v5 43/48] e1000e: Notify only new interrupts

In MSI-X mode, if there are interrupts already notified but not cleared and a new interrupt arrives, e1000e incorrectly notifies the notified ones again along with the new one. To fix this issue, replace e1000e_update_interrupt_state() with two new functions: e1000e_raise_interrupts() and e1000e_l

[PATCH v5 31/48] net/eth: Always add VLAN tag

It is possible to have another VLAN tag even if the packet is already tagged. Signed-off-by: Akihiko Odaki --- include/net/eth.h | 4 ++-- hw/net/net_tx_pkt.c | 16 +++- net/eth.c | 22 ++ 3 files changed, 15 insertions(+), 27 deletions(-) diff --git

[PATCH v5 33/48] tests/qtest/libqos/igb: Set GPIE.Multiple_MSIX

GPIE.Multiple_MSIX is not set by default, and needs to be set to get interrupts from multiple MSI-X vectors. Signed-off-by: Akihiko Odaki Reviewed-by: Sriram Yagnaraman --- tests/qtest/libqos/igb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/libqos/igb.c b/tests/qtest/libqos

[PATCH v5 18/48] e1000e: Always log status after building rx metadata

Without this change, the status flags may not be traced e.g. if checksum offloading is disabled. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé --- hw/net/e1000e_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_c

[PATCH v5 37/48] igb: Implement Tx SCTP CSO

Signed-off-by: Akihiko Odaki Reviewed-by: Sriram Yagnaraman --- hw/net/net_tx_pkt.h | 8 hw/net/igb_core.c | 12 +++- hw/net/net_tx_pkt.c | 18 ++ 3 files changed, 33 insertions(+), 5 deletions(-) diff --git a/hw/net/net_tx_pkt.h b/hw/net/net_tx_pkt.h index 4

[PATCH v5 05/48] igb: Do not require CTRL.VME for tx VLAN tagging

While the datasheet of e1000e says it checks CTRL.VME for tx VLAN tagging, igb's datasheet has no such statements. It also says for "CTRL.VLE": > This register only affects the VLAN Strip in Rx it does not have any > influence in the Tx path in the 82576. (Appendix A. Changes from the 82575) There

[PATCH v5 42/48] igb: Implement Tx timestamp

Signed-off-by: Akihiko Odaki Reviewed-by: Sriram Yagnaraman --- hw/net/igb_regs.h | 3 +++ hw/net/igb_core.c | 7 +++ 2 files changed, 10 insertions(+) diff --git a/hw/net/igb_regs.h b/hw/net/igb_regs.h index 894705599d..82ff195dfc 100644 --- a/hw/net/igb_regs.h +++ b/hw/net/igb_regs.h @@ -

[PATCH v5 45/48] igb: Clear-on-read ICR when ICR.INTA is set

For GPIE.NSICR, Section 7.3.2.1.2 says: > ICR bits are cleared on register read. If GPIE.NSICR = 0b, then the > clear on read occurs only if no bit is set in the IMS or at least one > bit is set in the IMS and there is a true interrupt as reflected in > ICR.INTA. e1000e does similar though it chec

[PATCH v5 12/48] tests/avocado: Remove test_igb_nomsi_kvm

It is unlikely to find more bugs with KVM so remove test_igb_nomsi_kvm to save time to run it. Signed-off-by: Akihiko Odaki Reviewed-by: Thomas Huth Acked-by: Alex Bennée --- tests/avocado/netdev-ethtool.py | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/tests/

[PATCH v5 27/48] igb: Clear EICR bits for delayed MSI-X interrupts

Section 7.3.4.1 says: > When auto-clear is enabled for an interrupt cause, the EICR bit is > set when a cause event mapped to this vector occurs. When the EITR > Counter reaches zero, the MSI-X message is sent on PCIe. Then the > EICR bit is cleared and enabled to be set by a new cause event Signe

[PATCH v5 44/48] igb: Notify only new interrupts

This follows the corresponding change for e1000e. This fixes: tests/avocado/netdev-ethtool.py:NetDevEthtool.test_igb Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 201 -- hw/net/trace-events | 11 +- .../org.centos/str

[PATCH v5 06/48] igb: Clear IMS bits when committing ICR access

The datasheet says contradicting statements regarding ICR accesses so it is not reliable to determine the behavior of ICR accesses. However, e1000e does clear IMS bits when reading ICR accesses and Linux also expects ICR accesses will clear IMS bits according to: https://git.kernel.org/pub/scm/linu

[PATCH v5 21/48] igb: Read DCMD.VLE of the first Tx descriptor

Section 7.2.2.3 Advanced Transmit Data Descriptor says: > For frames that spans multiple descriptors, all fields apart from > DCMD.EOP, DCMD.RS, DCMD.DEXT, DTALEN, Address and DTYP are valid only > in the first descriptors and are ignored in the subsequent ones. Signed-off-by: Akihiko Odaki Revie

[PATCH v5 35/48] igb: Use UDP for RSS hash

e1000e does not support using UDP for RSS hash, but igb does. Signed-off-by: Akihiko Odaki Reviewed-by: Sriram Yagnaraman --- hw/net/igb_regs.h | 3 +++ hw/net/igb_core.c | 16 2 files changed, 19 insertions(+) diff --git a/hw/net/igb_regs.h b/hw/net/igb_regs.h index eb995d8b

[PATCH v5 22/48] e1000e: Reset packet state after emptying Tx queue

Keeping Tx packet state after the transmit queue is emptied has some problems: - The datasheet says the descriptors can be reused after the transmit queue is emptied, but the Tx packet state may keep references to them. - The Tx packet state cannot be migrated so it can be reset anytime the mig

[PATCH v5 46/48] vmxnet3: Do not depend on PC

vmxnet3 has no dependency on PC, and VMware Fusion actually makes it available on Apple Silicon according to: https://kb.vmware.com/s/article/90364 Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé --- hw/net/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH v5 32/48] hw/net/net_rx_pkt: Enforce alignment for eth_header

eth_strip_vlan and eth_strip_vlan_ex refers to ehdr_buf as struct eth_header. Enforce alignment for the structure. Signed-off-by: Akihiko Odaki Reviewed-by: Sriram Yagnaraman --- hw/net/net_rx_pkt.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/net/net_rx_pk

[PATCH v5 29/48] igb: Rename a variable in igb_receive_internal()

Rename variable "n" to "causes", which properly represents the content of the variable. Signed-off-by: Akihiko Odaki Reviewed-by: Sriram Yagnaraman --- hw/net/igb_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index

[PATCH v5 34/48] igb: Implement MSI-X single vector mode

Signed-off-by: Akihiko Odaki Reviewed-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index c954369964..6d55b43fb4 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -1873,7 +187

[PATCH v5 41/48] igb: Implement Rx PTP2 timestamp

Signed-off-by: Akihiko Odaki --- hw/net/igb_common.h | 16 +++--- hw/net/igb_regs.h | 23 hw/net/igb_core.c | 129 3 files changed, 127 insertions(+), 41 deletions(-) diff --git a/hw/net/igb_common.h b/hw/net/igb_common.h index f2a90657

[PATCH v5 07/48] net/net_rx_pkt: Use iovec for net_rx_pkt_set_protocols()

igb does not properly ensure the buffer passed to net_rx_pkt_set_protocols() is contiguous for the entire L2/L3/L4 header. Allow it to pass scattered data to net_rx_pkt_set_protocols(). Fixes: 3a977deebe ("Intrdocue igb device emulation") Signed-off-by: Akihiko Odaki Reviewed-by: Sriram Yagnarama

[PATCH v5 48/48] docs/system/devices/igb: Note igb is tested for DPDK

Signed-off-by: Akihiko Odaki --- docs/system/devices/igb.rst | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/docs/system/devices/igb.rst b/docs/system/devices/igb.rst index afe036dad2..60c10bf7c7 100644 --- a/docs/system/devices/igb.rst +++ b/docs/system/devices/i

[PATCH v5 04/48] igb: Fix Rx packet type encoding

igb's advanced descriptor uses a packet type encoding different from one used in e1000e's extended descriptor. Fix the logic to encode Rx packet type accordingly. Fixes: 3a977deebe ("Intrdocue igb device emulation") Signed-off-by: Akihiko Odaki Reviewed-by: Sriram Yagnaraman --- hw/net/igb_regs

[PATCH v5 14/48] net/eth: Rename eth_setup_vlan_headers_ex

The old eth_setup_vlan_headers has no user so remove it and rename eth_setup_vlan_headers_ex. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé --- include/net/eth.h | 9 + hw/net/net_tx_pkt.c | 2 +- net/eth.c | 2 +- 3 files changed, 3 insertions(+), 10 dele

[PATCH v5 47/48] MAINTAINERS: Add a reviewer for network packet abstractions

I have made significant changes for network packet abstractions so add me as a reviewer. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c31d2279ab..8b2ef5943c 100644 --- a/MAINT

[PATCH v5 25/48] igb: Share common VF constants

The constants need to be consistent between the PF and VF. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Sriram Yagnaraman --- hw/net/igb_common.h | 8 hw/net/igb.c| 10 +- hw/net/igbvf.c | 7 --- 3 files changed, 13 insertion

[PATCH v5 39/48] igb: Filter with the second VLAN tag for extended VLAN

Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 688eaf7319..5345f57031 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -69,7 +69,7 @@ typedef struc

[PATCH v5 02/48] hw/net/net_tx_pkt: Decouple interface from PCI

This allows to use the network packet abstractions even if PCI is not used. Signed-off-by: Akihiko Odaki --- hw/net/net_tx_pkt.h | 31 --- hw/net/e1000e_core.c | 13 - hw/net/igb_core.c| 13 ++--- hw/net/net_tx_pkt.c | 36 +---

[PATCH v5 28/48] e1000e: Rename a variable in e1000e_receive_internal()

Rename variable "n" to "causes", which properly represents the content of the variable. Signed-off-by: Akihiko Odaki --- hw/net/e1000e_core.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 7dce448657..aea70

[PATCH v5 36/48] igb: Implement Rx SCTP CSO

Signed-off-by: Akihiko Odaki Reviewed-by: Sriram Yagnaraman --- hw/net/igb_regs.h | 1 + include/net/eth.h | 4 ++- include/qemu/crc32c.h | 1 + hw/net/e1000e_core.c | 5 hw/net/igb_core.c | 15 +- hw/net/net_rx_pkt.c | 64 +++--

[PATCH v5 26/48] igb: Fix igb_mac_reg_init coding style alignment

Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé --- hw/net/igb_core.c | 96 +++ 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 56a53872cf..20645c4764 100644 --- a/hw/net/igb_

[PATCH v5 38/48] igb: Strip the second VLAN tag for extended VLAN

Signed-off-by: Akihiko Odaki --- hw/net/net_rx_pkt.h | 19 include/net/eth.h| 4 ++-- hw/net/e1000e_core.c | 3 ++- hw/net/igb_core.c| 14 ++-- hw/net/net_rx_pkt.c | 15 + net/eth.c| 52 6 fi

[PATCH v5 19/48] igb: Always log status after building rx metadata

Without this change, the status flags may not be traced e.g. if checksum offloading is disabled. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé --- hw/net/igb_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c ind

[PATCH v5 20/48] igb: Remove goto

The goto is a bit confusing as it changes the control flow only if L4 protocol is not recognized. It is also different from e1000e, and noisy when comparing e1000e and igb. Signed-off-by: Akihiko Odaki Reviewed-by: Sriram Yagnaraman --- hw/net/igb_core.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH v5 08/48] e1000e: Always copy ethernet header

e1000e_receive_internal() used to check the iov length to determine copy the iovs to a contiguous buffer, but the check is flawed in two ways: - It does not ensure that iovcnt > 0. - It does not take virtio-net header into consideration. The size of this copy is just 18 octets, which can be even l

[PATCH v5 16/48] e1000x: Take CRC into consideration for size check

Section 13.7.15 Receive Length Error Count says: > Packets over 1522 bytes are oversized if LongPacketEnable is 0b > (RCTL.LPE). If LongPacketEnable (LPE) is 1b, then an incoming packet > is considered oversized if it exceeds 16384 bytes. > These lengths are based on bytes in the received packet

[PATCH v5 15/48] e1000x: Share more Rx filtering logic

This saves some code and enables tracepoint for e1000's VLAN filtering. Signed-off-by: Akihiko Odaki Reviewed-by: Sriram Yagnaraman --- hw/net/e1000x_common.h | 4 +++- hw/net/e1000.c | 35 +-- hw/net/e1000e_core.c | 47 +---

[PATCH v5 03/48] e1000x: Fix BPRC and MPRC

Before this change, e1000 and the common code updated BPRC and MPRC depending on the matched filter, but e1000e and igb decided to update those counters by deriving the packet type independently. This inconsistency caused a multicast packet to be counted twice. Updating BPRC and MPRC depending on

[PATCH v5 30/48] net/eth: Use void pointers

The uses of uint8_t pointers were misleading as they are never accessed as an array of octets and it even require more strict alignment to access as struct eth_header. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé --- include/net/eth.h | 4 ++-- net/eth.c | 6 +++---

[PATCH v5 17/48] e1000x: Rename TcpIpv6 into TcpIpv6Ex

e1000e and igb employs NetPktRssIpV6TcpEx for RSS hash if TcpIpv6 MRQC bit is set. Moreover, igb also has a MRQC bit for NetPktRssIpV6Tcp though it is not implemented yet. Rename it to TcpIpv6Ex to avoid confusion. Signed-off-by: Akihiko Odaki Reviewed-by: Sriram Yagnaraman --- hw/net/e1000x_re

[PATCH v5 13/48] hw/net/net_tx_pkt: Remove net_rx_pkt_get_l4_info

This function is not used. Signed-off-by: Akihiko Odaki --- hw/net/net_rx_pkt.h | 9 - hw/net/net_rx_pkt.c | 5 - 2 files changed, 14 deletions(-) diff --git a/hw/net/net_rx_pkt.h b/hw/net/net_rx_pkt.h index a06f5c2675..ce8dbdb284 100644 --- a/hw/net/net_rx_pkt.h +++ b/hw/net/net_rx

[PATCH v5 01/48] hw/net/net_tx_pkt: Decouple implementation from PCI

This is intended to be followed by another change for the interface. It also fixes the leak of memory mapping when the specified memory is partially mapped. Fixes: e263cd49c7 ("Packet abstraction for VMWARE network devices") Signed-off-by: Akihiko Odaki --- hw/net/net_tx_pkt.h | 9 hw/

[PATCH v5 10/48] Fix references to igb Avocado test

Fixes: 9f95111474 ("tests/avocado: re-factor igb test to avoid timeouts") Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS| 2 +- docs/system/devices/igb.rst| 2 +- scripts/ci/org.centos/stream/8/x86_

[PATCH v5 09/48] igb: Always copy ethernet header

igb_receive_internal() used to check the iov length to determine copy the iovs to a contiguous buffer, but the check is flawed in two ways: - It does not ensure that iovcnt > 0. - It does not take virtio-net header into consideration. The size of this copy is just 22 octets, which can be even less

[PATCH v5 00/48] igb: Fix for DPDK

Based-on: <366bbcafdb6e0373f0deb105153768a8c0bded87.ca...@gmail.com> ("[PATCH 0/1] e1000e: Fix tx/rx counters") This series has fixes and feature additions to pass DPDK Test Suite with igb. It also includes a few minor changes related to networking. Patch [01, 10] are bug fixes. Patch [11, 14] de

[PATCH v2] util/vfio-helpers: Use g_file_read_link()

When _FORTIFY_SOURCE=2, glibc version is 2.35, and GCC version is 12.1.0, the compiler complains as follows: In file included from /usr/include/features.h:490, from /usr/include/bits/libc-header-start.h:33, from /usr/include/stdint.h:26, from /us

Re: [PATCH v2 02/16] migration: Correct transferred bytes value

On Mon, 2023-05-15 at 21:56 +0200, Juan Quintela wrote: > We forget several places to add to trasferred amount of data. With > this fixes I get: > >qemu_file_transferred() + multifd_bytes == transferred > > The only place whrer this is not true is during devices sending. But > going all thr

Re: [PATCH v2 01/16] migration: Don't use INT64_MAX for unlimited rate

On Tue, 2023-05-16 at 14:47 +0200, Cédric Le Goater wrote: > On 5/16/23 11:24, Juan Quintela wrote: > > David Edmondson wrote: > > > Juan Quintela writes: > > > > > > > Define and use RATE_LIMIT_MAX instead. > > > > > > Suggest "RATE_LIMIT_MAX_NONE". > > > > Then even better > > > > RATE_LIMI

Re: [PATCH v12 02/15] accel: collecting TB execution count

On 5/23/2023 8:45 AM, Richard Henderson wrote: > On 5/18/23 06:57, Fei Wu wrote: >> +void HELPER(inc_exec_freq)(void *ptr) >> +{ >> +    TBStatistics *stats = (TBStatistics *) ptr; >> +    tcg_debug_assert(stats); >> +    ++stats->executions.normal; >> +} > ... >> +static inline void gen_tb_exec_co

RE: [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming

On Tuesday, May 23, 2023 7:36 AM, Peter Xu wrote: > > > We may also want to trap the channel setups on num: > > > > > > migrate_params_test_apply(): > > > > > > if (params->has_multifd_channels) { > > > dest->multifd_channels = params->multifd_channels; > > > } > > > > Didn’t get th

Re: [PATCH 1/4] hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes

在 2023/5/22 下午9:44, Philippe Mathieu-Daudé 写道: On 22/5/23 13:47, Jiaxun Yang wrote: 2023年5月22日 04:52，Huacai Chen 写道： Hi, Jiaxun, Rename loongarch_ipi to loongson_ipi? It will be shared by both MIPS and LoongArch in your series. Hi Huacai, Thanks for the point, what’s the opinion from

Re: [PATCH v4 03/11] hw: allwinner-r40: Complete uart devices

在 2023/5/15 2:55, Niek Linnenbank 写道: Hi Qianfan, On Wed, May 10, 2023 at 12:30 PM wrote: From: qianfan Zhao R40 has eight UARTs, support both 16450 and 16550 compatible modes. Signed-off-by: qianfan Zhao ---  hw/arm/allwinner-r40.c         | 31

Re: [PATCH v4 01/11] hw: arm: Add bananapi M2-Ultra and allwinner-r40 support

在 2023/5/15 2:50, Niek Linnenbank 写道: Hi Qianfan, On Wed, May 10, 2023 at 12:30 PM wrote: From: qianfan Zhao Allwinner R40 (sun8i) SoC features a Quad-Core Cortex-A7 ARM CPU, and a Mali400 MP2 GPU from ARM. It's also known as the Allwinner T3 for In-Car Entertainment usag

Re: [PATCH v4 08/11] hw: arm: allwinner-r40: Add emac and gmac support

在 2023/5/16 3:58, Niek Linnenbank 写道: Hi Qianfan, On Wed, May 10, 2023 at 12:30 PM wrote: From: qianfan Zhao R40 has two ethernet controllers named as emac and gmac. The emac is compatibled with A10, and the GMAC is compatibled with H3. Signed-off-by: qianfan Zhao --

Re: [PATCH v4 07/11] hw: sd: allwinner-sdhost: Add sun50i-a64 SoC support

在 2023/5/16 3:54, Niek Linnenbank 写道: On Wed, May 10, 2023 at 12:30 PM wrote: From: qianfan Zhao A64's sd register was similar to H3, and it introduced a new register named SAMP_DL_REG location at 0x144. The dma descriptor buffer size of mmc2 is only 8K and the other mmc

Re: [PATCH v4 06/11] hw/arm/allwinner-r40: add SDRAM controller device

在 2023/5/16 3:47, Niek Linnenbank 写道: On Wed, May 10, 2023 at 12:30 PM wrote: From: qianfan Zhao Types of memory that the SDRAM controller supports are DDR2/DDR3 and capacities of up to 2GiB. This commit adds emulation support of the Allwinner R40 SDRAM controller. T

Re: [PATCH v12 02/15] accel: collecting TB execution count

On 5/18/23 06:57, Fei Wu wrote: +void HELPER(inc_exec_freq)(void *ptr) +{ +TBStatistics *stats = (TBStatistics *) ptr; +tcg_debug_assert(stats); +++stats->executions.normal; +} ... +static inline void gen_tb_exec_count(TranslationBlock *tb) +{ +if (tb_stats_enabled(tb, TB_EXEC_S

Re: [PATCH v4 05/11] hw/misc: Rename axp209 to axp22x and add support AXP221 PMU

在 2023/5/16 3:29, Niek Linnenbank 写道: Hi Qianfan, Good idea indeed to turn this driver into a more generic one. If possible, its best to re-use code rather than adding new. On Wed, May 10, 2023 at 12:30 PM wrote: From: qianfan Zhao This patch adds minimal support for AXP-221 PM

Re: [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming

On Sat, May 20, 2023 at 01:42:06AM +, Wang, Wei W wrote: > On Friday, May 19, 2023 11:34 PM, Peter Xu wrote: > > > Ah yes indeed it keeps working, because we apply -global bits before > > > setup sockets. Then it's fine by me since that's the only thing I > > > would still like to keep it worki

Re: [PATCH] bitops.h: Compile out asserts without --enable-debug

On 5/22/23 15:26, BALATON Zoltan wrote: On Mon, 22 May 2023, Alex Bennée wrote: (ajb: add Richard for his compiler-fu) BALATON Zoltan writes: On Mon, 22 May 2023, Alex Bennée wrote: BALATON Zoltan writes: The low level extract and deposit funtions provided by bitops.h are used in performan

Re: [PATCH v7 5/7] hw/cxl/events: Add injection of General Media Events

The 05/22/2023 16:09, Jonathan Cameron wrote: > From: Ira Weiny > > To facilitate testing provide a QMP command to inject a general media > event. The event can be added to the log specified. > > Signed-off-by: Ira Weiny > Signed-off-by: Jonathan Cameron > > --- Reviewed-by: Fan Ni > v7:

Re: Add CI configuration for Kubernetes

On 5/22/23 10:41, Camilla Conte wrote: Here's a second version (v2) of patches to support the Kubernetes runner for Gitlab CI. You can find the v1 thread here: https://lore.kernel.org/qemu-devel/20230407145252.32955-1-cco...@redhat.com/. This does not work: https://gitlab.com/qemu-project/q

Re: [PATCH v7 4/7] hw/cxl/events: Add event interrupt support

The 05/22/2023 16:09, Jonathan Cameron wrote: > From: Ira Weiny > > Replace the stubbed out CXL Get/Set Event interrupt policy mailbox > commands. Enable those commands to control interrupts for each of the > event log types. > > Skip the standard input mailbox length on the Set command due to

Re: [PATCH] bitops.h: Compile out asserts without --enable-debug

On Mon, 22 May 2023, Alex Bennée wrote: (ajb: add Richard for his compiler-fu) BALATON Zoltan writes: On Mon, 22 May 2023, Alex Bennée wrote: BALATON Zoltan writes: The low level extract and deposit funtions provided by bitops.h are used in performance critical places. It crept into target/

Re: [PULL 00/20] Allow "make check" with "--without-default-devices"

On 5/22/23 04:49, Thomas Huth wrote: The following changes since commit aa222a8e4f975284b3f8f131653a4114b3d333b3: Merge tag 'for_upstream' ofhttps://git.kernel.org/pub/scm/virt/kvm/mst/qemu into staging (2023-05-19 12:17:16 -0700) are available in the Git repository at: https://gitlab.

Re: [PATCH 1/1] hw/ide/core.c: fix handling of unsupported commands

Certainly seems like my patch is wrong as it will make the abort path execute ide_cmd_done twice. During debug I came to the conclusion that ide_cmd_done is not called at all as I was getting timeouts on the driver side while waiting for D2H FIS. I am still not sure how I was getting this behavior

Re: [QEMU][PATCH v5 3/4] xlnx-versal: Connect Xilinx VERSAL CANFD controllers

On [2023 May 19] Fri 13:36:57, Vikram Garhwal wrote: > Connect CANFD0 and CANFD1 on the Versal-virt machine and update > xlnx-versal-virt > document with CANFD command line examples. > > Signed-off-by: Vikram Garhwal > Reviewed-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > docs/

Re: [PATCH] qcow2: Explicit mention of padding bytes

On 22.05.23 21:46, Eric Blake wrote: Although we already covered the need for padding bytes with our changes in commit 3ae3fcfa, commit 66fcbca5 (both v5.0.0) added one byte and relied on the rest of the text for implicitly covering 7 padding bytes. For consistency with other parts of the header

Building QEMU errors

Hi QEMU community, I'm trying to build QEMU on my development environment on Windows (64 bit, windows 10 enterprise), but am facing issues. I'm using the MSYS2 installer as administrator with the following commands: pacman -Syu pacman -Su pacman -S base-devel mingw-w64-x86_64-toolchain git pyth

Re: [PATCH v7 2/7] hw/cxl: Move CXLRetCode definition to cxl_device.h

The 05/22/2023 16:09, Jonathan Cameron wrote: > Following patches will need access to the mailbox return code > type so move it to the header. > > Reviewed-by: Ira Weiny > Signed-off-by: Jonathan Cameron > --- Reviewed-by: Fan Ni > include/hw/cxl/cxl_device.h | 28 +++

Re: [PATCH v7 3/7] hw/cxl/events: Wire up get/clear event mailbox commands

The 05/22/2023 16:09, Jonathan Cameron wrote: > From: Ira Weiny > > CXL testing is benefited from an artificial event log injection > mechanism. > > Add an event log infrastructure to insert, get, and clear events from > the various logs available on a device. > > Replace the stubbed out CXL Ge

Re: [PATCH v7 1/7] hw/cxl/events: Add event status register

The 05/22/2023 16:09, Jonathan Cameron wrote: > From: Ira Weiny > > The device status register block was defined. However, there were no > individual registers nor any data wired up. > > Define the event status register [CXL 3.0; 8.2.8.3.1] as part of the > device status register block. Wire u

Help finding Coverity defects for generated Hexagon code

Hi, coverity recently reported some defects in code generated by idef-parser (email attached). These defects are expected and we plan to emit a /* coverity[event_tag] */ comment to disable the specific event triggered. However, I'm not able to find the event_tag as I can't find the defect in the

[PATCH v4 0/1] ROM migration

v4: preparation patches are already merged to master 01: fix false-positive "error: ‘size’ may be used uninitialized", keep r-bs Vladimir Sementsov-Ogievskiy (1): pci: ROM preallocation for incoming migration hw/pci/pci.c | 79 ++-- 1 file ch

[PATCH v4 1/1] pci: ROM preallocation for incoming migration

On incoming migration we have the following sequence to load option ROM: 1. On device realize we do normal load ROM from the file 2. Than, on incoming migration we rewrite ROM from the incoming RAM block. If sizes mismatch we fail, like this: Size mismatch: :00:03.0/virtio-net-pci.rom

  1   2   3   4   >