[PATCH v2 13/16] qapi: Replace ad hoc "since" documentation by member documentation

2023-04-24 Thread Markus Armbruster
MemoryDeviceInfoKind, NetClientDriver, and GuestPanicAction mention some members only in ad hoc since documentation. The generated documentation shows these members as "Not documented". Replace by formal member documentation. Add actual documentation text for the GuestPanicAction members, to mat

[PATCH v2 05/16] qapi/block-core: Clean up after removal of dirty bitmap @status

2023-04-24 Thread Markus Armbruster
Commit 81cbfd50886 (block: remove dirty bitmaps 'status' field) removed deprecated BlockDirtyInfo member @status. It neglected to remove references to its enumeration values from the documentation of its replacements. Do that now. Signed-off-by: Markus Armbruster Reviewed-by: Vladimir Sementsov

[PATCH v2 01/16] qga/qapi-schema: Tidy up documentation of guest-fsfreeze-status

2023-04-24 Thread Markus Armbruster
Delete "error state indicates", because it doesn't make sense. I suspect it was an accident. Signed-off-by: Markus Armbruster Reviewed-by: Konstantin Kostiuk Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Marc-André Lureau --- qga/qapi-schema.json | 2 +- 1 file changed, 1 insertion(+

[PATCH v2 11/16] qga/qapi-schema: Fix member documentation markup

2023-04-24 Thread Markus Armbruster
GuestDiskStatsInfo's member documentation is parsed as ordinary text due to missing colons. The generated documentation shows these members as "Not documented". The fix is obvious: add the missing colons. Signed-off-by: Markus Armbruster Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: M

[PATCH v2 14/16] qapi: Fix misspelled section tags in doc comments

2023-04-24 Thread Markus Armbruster
Section tags are case sensitive and end with a colon. Screwing up either gets them interpreted as ordinary paragraph. Fix a few. Signed-off-by: Markus Armbruster Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Marc-André Lureau --- qapi/machine.json | 4 ++-- qapi/migration.json | 2

[PATCH v2 09/16] qapi: Fix bullet list markup in documentation

2023-04-24 Thread Markus Armbruster
Peter Maydell's commit 100cc4fe0f08 explains: rST insists on a blank line before and after a bulleted list [...] Add some extra blank lines in the doc comments so they're acceptable rST input. It missed one in qapi/trace.json. Paolo Bonzini later added another instance in qapi/stats.

[PATCH v2 02/16] qga/qapi-schema: Fix a misspelled reference

2023-04-24 Thread Markus Armbruster
Code returns a list of GuestNetworkInterface, documentation claims GuestNetworkInfo, which doesn't exist. Fix the documentation. Fixes: 3424fc9f16a1 (qemu-ga: add guest-network-get-interfaces command) Signed-off-by: Markus Armbruster Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Marc-A

[PATCH v2 15/16] qapi: Format since information the conventional way: (since X.Y)

2023-04-24 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Marc-André Lureau --- qapi/block-core.json | 6 +++--- qapi/stats.json | 2 +- qapi/tpm.json| 3 +-- qapi/ui.json | 6 +++--- 4 files changed, 8 insertions(+), 9 deletions(-) diff --git

[PATCH v2 12/16] qapi: Fix argument documentation markup

2023-04-24 Thread Markus Armbruster
Member / argument documentation of BlockdevAmendOptionsQcow2, job-resume, and RDMA_GID_STATUS_CHANGED is parsed as ordinary text due to missing colon or space before the colon. The generated documentation shows these members / arguments as "Not documented". The fix is obvious: add missing colons,

[PATCH v2 03/16] qapi: Fix misspelled references

2023-04-24 Thread Markus Armbruster
query-cpu-definitions returns a list of CpuDefinitionInfo, but documentation claims CpuDefInfo, which doesn't exist. query-migrate-capabilities returns a list of MigrationCapabilityStatus, but documentation claims MigrationCapabilitiesStatus, which doesn't exist. balloon and query-balloon can fai

[PATCH v2 00/16] qapi qga/qapi-schema: Doc fixes

2023-04-24 Thread Markus Armbruster
Generated code does not change, except for the last patch, which moves a bit of code without changing it. v2: * PATCH 07: Commit message typo corrected, and extra spaces deleted in two more examples * PATCH 09: Also tidy up two indented bullet lists * PATCH 10: Three more instances fixed; Fixes:

[PATCH v2 07/16] qapi: Tidy up examples

2023-04-24 Thread Markus Armbruster
A few examples neglect to prefix QMP input with '->'. Fix that. Two examples have extra space after '<-'. Delete it. A few examples neglect to show output. Provide some. The example output for query-vcpu-dirty-limit could use further improvement. Add a TODO comment. Use "Examples:" instead

[PATCH v2 16/16] qapi storage-daemon/qapi: Fix documentation section structure

2023-04-24 Thread Markus Armbruster
In the QEMU QMP Reference Manual, subsection "Block core (VM unrelated)" is empty. Its contents is at the end of subsection "Background jobs" instead. That's because qapi/job.json is included first from qapi/block-core.json, which makes qapi/job.json's documentation go between qapi/block-core.jso

[PATCH v2 06/16] qapi: @foo should be used to reference, not ``foo``

2023-04-24 Thread Markus Armbruster
Documentation suggests @foo is merely shorthand for ``foo``. It's not, it carries additional meaning: it's a reference to a QAPI schema name. Reword the documentation to spell that out. Fix up the few ``foo`` that should be @foo. Signed-off-by: Markus Armbruster Reviewed-by: Vladimir Sementsov

[PATCH v2 08/16] qapi: Delete largely misleading "Stability Considerations"

2023-04-24 Thread Markus Armbruster
Documentation section "Stability Considerations" dates back to the early days of QMP (commit 82a56f0d83d (Monitor: Introduce the qmp-commands.hx file)). It became largely misleading years ago. Delete it. Signed-off-by: Markus Armbruster Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Mar

[PATCH v2 10/16] qapi: Fix unintended definition lists in documentation

2023-04-24 Thread Markus Armbruster
rST parses something like first line second line as a definition list item, where "first line" is the term being defined by "second line". This bites us in a couple of places. Here's one: # @bps_max: total throughput limit during bursts, # in bytes (Sinc

[PATCH v2 04/16] qapi: Fix up references to long gone error classes

2023-04-24 Thread Markus Armbruster
Commit de253f14912e88f4 (qmp: switch to the new error format on the wire) removed most error classes. Several later commits mistakenly mentioned them in documentation. Replace them by the actual error class there. Fixes: 44e3e053af56 (qmp: add interface blockdev-snapshot-delete-internal-sync) Fi

[QEMU][PATCH v4 0/4] Introduce Xilinx Versal CANFD

2023-04-24 Thread Vikram Garhwal
Hi, This patch implements CANFD controller for xlnx-versal-virt machine. There are two controllers CANFD0@0xFF06_ and CANFD1@0xFF07_ are connected to the machine. Also, added basic qtests for data exchange between both the controllers in various supported configs. Changelog: v3->v4: A

[QEMU][PATCH v4 4/4] tests/qtest: Introduce tests for Xilinx VERSAL CANFD controller

2023-04-24 Thread Vikram Garhwal
The QTests perform three tests on the Xilinx VERSAL CANFD controller: Tests the CANFD controllers in loopback. Tests the CANFD controllers in normal mode with CAN frame. Tests the CANFD controllers in normal mode with CANFD frame. Signed-off-by: Vikram Garhwal Acked-by: Thomas Huth R

[PATCH v2 1/3] hw/i2c: add mctp core

2023-04-24 Thread Klaus Jensen
From: Klaus Jensen Add an abstract MCTP over I2C endpoint model. This implements MCTP control message handling as well as handling the actual I2C transport (packetization). Devices are intended to derive from this and implement the class methods. Parts of this implementation is inspired by code

[PATCH v2 2/3] i2c/mctp: Allow receiving messages to dest eid 0

2023-04-24 Thread Klaus Jensen
From: Matt Johnston The Null Destination ID, 0, is used for MCTP control messages when addressing by physical ID. That is used for Get Endpoint ID and Set Endpoint ID when querying/assigning an EID to an endpoint. Signed-off-by: Matt Johnston --- hw/i2c/mctp.c | 3 ++- 1 file changed, 2 insert

[PATCH v2 3/3] hw/nvme: add nvme management interface model

2023-04-24 Thread Klaus Jensen
From: Klaus Jensen Add the 'nmi-i2c' device that emulates an NVMe Management Interface controller. Initial support is very basic (Read NMI DS, Configuration Get). This is based on previously posted code by Padmakar Kalghatgi, Arun Kumar Agasar and Saurav Kumar. Signed-off-by: Klaus Jensen ---

[PATCH v2 0/3] hw/{i2c, nvme}: mctp endpoint, nvme management interface model

2023-04-24 Thread Klaus Jensen
From: Klaus Jensen This adds a generic MCTP endpoint model that other devices may derive from. I'm not 100% happy with the design of the class methods, but it's a start. Also included is a very basic implementation of an NVMe-MI device, supporting only a small subset of the required commands. Li

[QEMU][PATCH v4 3/4] xlnx-versal: Connect Xilinx VERSAL CANFD controllers

2023-04-24 Thread Vikram Garhwal
Connect CANFD0 and CANFD1 on the Versal-virt machine and update xlnx-versal-virt document with CANFD command line examples. Signed-off-by: Vikram Garhwal Reviewed-by: Peter Maydell --- docs/system/arm/xlnx-versal-virt.rst | 31 ++ hw/arm/xlnx-versal-virt.c| 48 ++

[QEMU][PATCH v4 2/4] hw/net/can: Introduce Xilinx Versal CANFD controller

2023-04-24 Thread Vikram Garhwal
The Xilinx Versal CANFD controller is developed based on SocketCAN, QEMU CAN bus implementation. Bus connection and socketCAN connection for each CAN module can be set through command lines. Signed-off-by: Vikram Garhwal --- hw/net/can/meson.build |1 + hw/net/can/trace-events

[QEMU][PATCH v4 1/4] MAINTAINERS: Include canfd tests under Xilinx CAN

2023-04-24 Thread Vikram Garhwal
Signed-off-by: Vikram Garhwal Reviewed-by: Peter Maydell --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 24154f5721..c3dbacb615 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1809,7 +1809,7 @@ M: Francisco Iglesias S: Maintain

Re: [PATCH v3 1/7] target/i386: allow versioned CPUs to specify new cache_info

2023-04-24 Thread Robert Hoo
Babu Moger 于2023年4月25日周二 00:42写道: > > From: Michael Roth > > New EPYC CPUs versions require small changes to their cache_info's. Do you mean, for the real HW of EPYC CPU, each given model, e.g. Rome, has HW version updates periodically? > Because current QEMU x86 CPU definition does not support

Re: [PATCH 16/16] qapi storage-daemon/qapi: Fix documentation section structure

2023-04-24 Thread Markus Armbruster
Eric Blake writes: > On Tue, Apr 04, 2023 at 01:59:12PM +0200, Markus Armbruster wrote: >> In the QEMU QMP Reference Manual, subsection "Block core (VM >> unrelated)" is empty. Its contents is at the end of subsection >> "Background jobs" instead. That's because qapi/job.json is includeded > >

[PATCH v2 1/1] migration: Disable postcopy + multifd migration

2023-04-24 Thread Leonardo Bras
Since the introduction of multifd, it's possible to perform a multifd migration and finish it using postcopy. A bug introduced by yank (fixed on cfc3bcf373) was previously preventing a successful use of this migration scenario, and now thing should be working on most scenarios. But since there is

Re: [RFC PATCH 00/13] gfxstream + rutabaga_gfx: a surprising delight or startling epiphany?

2023-04-24 Thread Gurchetan Singh
On Sat, Apr 22, 2023 at 9:41 AM Akihiko Odaki wrote: > > On 2023/04/22 8:54, Gurchetan Singh wrote: > > On Fri, Apr 21, 2023 at 9:02 AM Stefan Hajnoczi wrote: > >> > >> On Thu, 20 Apr 2023 at 21:13, Gurchetan Singh > >> wrote: > >>> > >>> From: Gurchetan Singh > >>> > >>> Rationale: > >>> > >>>

Re: [RFC PATCH 12/13] HACK: use memory region API to inject memory to guest

2023-04-24 Thread Gurchetan Singh
On Sat, Apr 22, 2023 at 8:46 AM Akihiko Odaki wrote: > > On 2023/04/21 10:12, Gurchetan Singh wrote: > > I just copied the patches that have been floating around that do > > this, but it doesn't seem to robustly work. This current > > implementation is probably good enough to run vkcube or simple

Multiple vIOMMU instance support in QEMU?

2023-04-24 Thread Nicolin Chen
Hi all, (Please feel free to include related folks into this thread.) In light of an ongoing nested-IOMMU support effort via IOMMUFD, we would likely have a need of a multi-vIOMMU support in QEMU, or more specificly a multi-vSMMU support for an underlying HW that has multi physical SMMUs. This wo

Re: [RFC] hw/arm/virt: Provide DT binding generation for PCI eXpander Bridges

2023-04-24 Thread Jonathan Cameron via
On Mon, 24 Apr 2023 16:45:48 +0100 Peter Maydell wrote: > On Mon, 24 Apr 2023 at 16:41, Jonathan Cameron > wrote: > > > > On Mon, 24 Apr 2023 10:28:30 +0100 > > Peter Maydell wrote: > > > So, not knowing anything about CXL, my naive question is: > > > this is PCI, why can't we handle it the w

Re: [PATCH] pci: make ROM memory resizable

2023-04-24 Thread Vladimir Sementsov-Ogievskiy
On 25.04.23 00:06, Michael S. Tsirkin wrote: On Tue, Apr 25, 2023 at 12:02:49AM +0300, Vladimir Sementsov-Ogievskiy wrote: On 24.04.23 23:45, Michael S. Tsirkin wrote: On Mon, Apr 24, 2023 at 04:42:00PM -0400, Michael S. Tsirkin wrote: On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sements

Re: [RFC PATCH v3 14/20] configure: use 'mkvenv ensure meson' to bootstrap meson

2023-04-24 Thread Warner Losh
On Mon, Apr 24, 2023 at 2:41 PM John Snow wrote: > On Mon, Apr 24, 2023 at 4:36 PM Warner Losh wrote: > > > > > > > > On Mon, Apr 24, 2023, 2:03 PM John Snow wrote: > >> > >> This commit changes how we detect and install meson. It notably removes > >> '--meson='. > >> > >> The previous patch cr

Re: [PATCH] pci: make ROM memory resizable

2023-04-24 Thread Michael S. Tsirkin
On Tue, Apr 25, 2023 at 12:02:49AM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 24.04.23 23:45, Michael S. Tsirkin wrote: > > On Mon, Apr 24, 2023 at 04:42:00PM -0400, Michael S. Tsirkin wrote: > > > On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sementsov-Ogievskiy > > > wrote: > > > > On

Re: [PATCH] pci: make ROM memory resizable

2023-04-24 Thread Vladimir Sementsov-Ogievskiy
On 24.04.23 23:45, Michael S. Tsirkin wrote: On Mon, Apr 24, 2023 at 04:42:00PM -0400, Michael S. Tsirkin wrote: On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: On migration, on target we load local ROM file. But actual ROM content migrates through migration channe

Re: [PATCH v2 4/6] tests/qtest: make more migration pre-copy scenarios run non-live

2023-04-24 Thread Fabiano Rosas
Daniel P. Berrangé writes: > There are 27 pre-copy live migration scenarios being tested. In all of > these we force non-convergance and run for one iteration, then let it > converge and wait for completion during the second (or following) > iterations. At 3 mbps bandwidth limit the first iterati

Re: [PATCH] pci: make ROM memory resizable

2023-04-24 Thread Vladimir Sementsov-Ogievskiy
On 24.04.23 23:41, Michael S. Tsirkin wrote: @@ -2366,7 +2368,8 @@ static void pci_add_option_rom(PCIDevice *pdev, bool is_default_rom, snprintf(name, sizeof(name), "%s.rom", object_get_typename(OBJECT(pdev))); } pdev->has_rom = true; -memory_region_init_rom(&pdev->rom

Re: [PATCH] pci: make ROM memory resizable

2023-04-24 Thread Michael S. Tsirkin
On Mon, Apr 24, 2023 at 04:42:00PM -0400, Michael S. Tsirkin wrote: > On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > On migration, on target we load local ROM file. But actual ROM content > > migrates through migration channel. Original ROM content from local > >

Re: [PATCH v3 02/13] migration: Move qmp_migrate_set_parameters() to options.c

2023-04-24 Thread Vladimir Sementsov-Ogievskiy
On 24.04.23 21:32, Juan Quintela wrote: Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH] pci: make ROM memory resizable

2023-04-24 Thread Michael S. Tsirkin
On Mon, Apr 24, 2023 at 11:36:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On migration, on target we load local ROM file. But actual ROM content > migrates through migration channel. Original ROM content from local > file doesn't matter. But when size mismatch - we have an error like > > Si

Re: [RFC PATCH v3 14/20] configure: use 'mkvenv ensure meson' to bootstrap meson

2023-04-24 Thread John Snow
On Mon, Apr 24, 2023 at 4:36 PM Warner Losh wrote: > > > > On Mon, Apr 24, 2023, 2:03 PM John Snow wrote: >> >> This commit changes how we detect and install meson. It notably removes >> '--meson='. >> >> The previous patch creates a lightweight Python virtual environment >> unconditionally using

[RFC PATCH v3 04/20] mkvenv: Add better error message for missing pyexpat module

2023-04-24 Thread John Snow
NetBSD debundles pyexpat from python, but ensurepip needs pyexpat. Try our best to offer a helpful error message instead of just failing catastrophically. Signed-off-by: John Snow --- python/scripts/mkvenv.py | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/

Re: [PATCH v3 01/13] migration: Move migrate_use_tls() to options.c

2023-04-24 Thread Vladimir Sementsov-Ogievskiy
On 24.04.23 21:32, Juan Quintela wrote: Once there, rename it to migrate_tls() and make it return bool for consistency. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

[PATCH] pci: make ROM memory resizable

2023-04-24 Thread Vladimir Sementsov-Ogievskiy
On migration, on target we load local ROM file. But actual ROM content migrates through migration channel. Original ROM content from local file doesn't matter. But when size mismatch - we have an error like Size mismatch: :00:03.0/virtio-net-pci.rom: 0x4 != 0x8: Invalid argument Let

Re: [RFC PATCH v3 14/20] configure: use 'mkvenv ensure meson' to bootstrap meson

2023-04-24 Thread Warner Losh
On Mon, Apr 24, 2023, 2:03 PM John Snow wrote: > This commit changes how we detect and install meson. It notably removes > '--meson='. > > The previous patch creates a lightweight Python virtual environment > unconditionally using the user's configured $python that inherits system > packages. If

Ubuntu 22.04 - ARM Rock4SE

2023-04-24 Thread Victoria Stråberg
Hi! Im working with an ARM machine (Rock 4 SE, Radxa https://wiki.radxa.com/Rock4/se) and it has Ubuntu 22.04, Linux 4.4. I want to install Qemu on my machine to get an Intel processor. Im trying to follow your Linux start up guide: https://wiki.qemu.org/Hosts/Linux#Running_QEMU_on_Linux. How

[RFC PATCH v3 07/20] mkvenv: add nested venv workaround

2023-04-24 Thread John Snow
Python virtual environments do not typically nest; they may inherit from the top-level system packages or not at all. For our purposes, it would be convenient to emulate "nested" virtual environments to allow callers of the configure script to install specific versions of python utilities in order

[RFC PATCH v3 08/20] mkvenv: add ensure subcommand

2023-04-24 Thread John Snow
This command is to be used to add various packages (or ensure they're already present) into the configure-provided venv in a modular fashion. Examples: mkvenv ensure --online --dir "${source_dir}/python/wheels/" "meson>=0.61.5" mkvenv ensure --online "sphinx>=1.6.0" mkvenv ensure "qemu.qmp==0.0.2

[RFC PATCH v3 18/20] mkvenv: add diagnose() method for ensure() failures

2023-04-24 Thread John Snow
This is a routine that is designed to print some usable info for human beings back out to the terminal if/when "mkvenv ensure" fails to locate or install a package during configure time, such as meson or sphinx. Since we are requiring that "meson" and "sphinx" are installed to the same Python envi

[RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx

2023-04-24 Thread John Snow
GitLab CI: https://gitlab.com/jsnow/qemu/-/pipelines/846869409 (All green, except Python self-tests, see below) This patch series creates a mandatory python virtual environment ("venv") during configure time and uses it to ensure the availability of meson and sphinx. See https://www.qe

[RFC PATCH v3 06/20] mkvenv: work around broken pip installations on Debian 10

2023-04-24 Thread John Snow
This is a workaround intended for Debian 10, where the debian-patched pip does not function correctly if accessed from within a virtual environment. We don't support Debian 10 any longer, but it's possible that this bug might appear on other derivative platforms and this workaround may prove usefu

[RFC PATCH v3 20/20] configure: bootstrap sphinx with mkvenv

2023-04-24 Thread John Snow
When docs are explicitly requested, require Sphinx>=1.6.0. When docs are explicitly disabled, don't bother to check for Sphinx at all. If docs are set to "auto", attempt to locate Sphinx, but continue onward if it wasn't located. For the case that --enable-pypi is set to 'enabled' (the default) bu

[RFC PATCH v3 11/20] tests/vm: add py310-expat to NetBSD

2023-04-24 Thread John Snow
NetBSD cannot successfully run "ensurepip" without access to the pyexpat module, which NetBSD debundles. Like the Debian patch, it would be strictly faster long term to install pip/setuptools, and I recommend developers at their workstations take that approach instead. For the purposes of a throwa

[RFC PATCH v3 13/20] configure: create a python venv unconditionally

2023-04-24 Thread John Snow
This patch changes the configure script so that it always creates and uses a python virtual environment unconditionally. Meson bootstrapping is temporarily altered to force the use of meson from git or vendored source. The next commit restores the use of distribution-vendored Meson. Signed-off-by

[RFC PATCH v3 16/20] tests: Use configure-provided pyvenv for tests

2023-04-24 Thread John Snow
This patch changes how the avocado tests are provided, ever so slightly. Instead of creating a new testing venv, use the configure-provided 'pyvenv' instead, and install optional packages into that. Note 1: This doesn't respect the "disable-pypi" setting; the avocado tests remain an unconditional

[RFC PATCH v3 01/20] python: update pylint configuration

2023-04-24 Thread John Snow
Pylint 2.17.x decided that SocketAddrT was a bad name for a Type Alias for some reason. Sure, fine, whatever. Signed-off-by: John Snow --- python/setup.cfg | 1 + 1 file changed, 1 insertion(+) diff --git a/python/setup.cfg b/python/setup.cfg index 9e923d9762..3f36502954 100644 --- a/python/set

[RFC PATCH v3 12/20] scripts/make-release: download meson==0.61.5 .whl

2023-04-24 Thread John Snow
In preference to vendoring meson source, vendor a built distributable. This has two benefits: (1) We can get rid of a git submodule, (2) Installing built meson into a venv doesn't require any extra dependencies. RFC: The alternative approach is to just check in the .whl file into the git tree di

[RFC PATCH v3 15/20] configure: add --enable-pypi and --disable-pypi

2023-04-24 Thread John Snow
In the event that there's no vendored source present and no sufficient version of meson is found, we will attempt to connect to PyPI to install the package ... only if '--disable-pypi' was not passed. This mechanism is intended to replace the online functionality of the meson git submodule. While

[RFC PATCH v3 17/20] configure: move --enable-docs and --disable-docs back to configure

2023-04-24 Thread John Snow
Move this option back from meson into configure for the purposes of using the configuration value to bootstrap Sphinx in different ways based on this value. Signed-off-by: John Snow --- configure | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure b/configure index 7421bb8364..ae

[RFC PATCH v3 05/20] mkvenv: generate console entry shims from inside the venv

2023-04-24 Thread John Snow
This patch is meant to ensure that console entry point scripts will always generate on Python 3.7 installations where we may not have access to importlib.metadata. By running it from a separate process *inside* the venv, we can be assured to have access to setuptools and by extension pkg_resources

[RFC PATCH v3 03/20] mkvenv: add console script entry point generation

2023-04-24 Thread John Snow
When creating a virtual environment that inherits system packages, script entry points (like "meson", "sphinx-build", etc) are not re-generated with the correct shebang. When you are *inside* of the venv, this is not a problem, but if you are *outside* of it, you will not have a script that engages

[RFC PATCH v3 09/20] tests/docker: add python3-venv dependency

2023-04-24 Thread John Snow
Several debian-based tests need the python3-venv dependency as a consequence of Debian debundling the "ensurepip" module normally included with Python. As mkvenv.py stands as of this commit, Debian requires EITHER: (A) setuptools and pip, or (B) ensurepip mkvenv is a few seconds faster if you ha

[RFC PATCH v3 02/20] python: add mkvenv.py

2023-04-24 Thread John Snow
This script will be responsible for building a lightweight Python virtual environment at configure time. It works with Python 3.7 or newer. It has been designed to: - work *offline*, no PyPI required. - work *quickly*, The fast path is only ~65ms on my machine. - work *robustly*, with multiple fal

[RFC PATCH v3 14/20] configure: use 'mkvenv ensure meson' to bootstrap meson

2023-04-24 Thread John Snow
This commit changes how we detect and install meson. It notably removes '--meson='. The previous patch creates a lightweight Python virtual environment unconditionally using the user's configured $python that inherits system packages. If Meson is installed there and meets our minimum version requi

[RFC PATCH v3 19/20] configure: use --diagnose option with meson ensure

2023-04-24 Thread John Snow
Rely on the diagnosis information from mkvenv so it can be removed from the configure script. Signed-off-by: John Snow --- configure | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/configure b/configure index ae55de1408..0881fffc14 100755 --- a/configure +++ b/con

[RFC PATCH v3 10/20] tests/vm: Configure netbsd to use Python 3.10

2023-04-24 Thread John Snow
NetBSD removes some packages from the Python stdlib, but only re-packages them for Python 3.10. Switch to using Python 3.10. Signed-off-by: John Snow --- tests/vm/netbsd | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/vm/netbsd b/tests/vm/netbsd index 0b9536ca17..13eae109c0 100755 ---

Re: [PATCH] MAINTAINERS: Add Leonardo and Peter as reviewers

2023-04-24 Thread Leonardo Bras Soares Passos
On Fri, Apr 21, 2023 at 12:23 PM Peter Xu wrote: > > On Wed, Apr 19, 2023 at 06:29:57PM +0200, Juan Quintela wrote: > > Now that David has stepped down with Migration maintainership, > > Leonardo and Peter has volunteer to review the migration patches. > > This way they got CC'd on every migration

[PATCH v3 02/13] migration: Move qmp_migrate_set_parameters() to options.c

2023-04-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/migration.c | 420 -- migration/options.c | 418 + migration/options.h | 11 ++ 3 files changed, 429 insertions(+), 420 deletions(-) diff --git a/migration/migration.c

[PATCH v3 03/13] migration: Create migrate_params_init() function

2023-04-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/migration.c | 29 + migration/options.c | 31 +++ migration/options.h | 1 + 3 files changed, 33 insertions(+), 28 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index

[PATCH v3 05/13] migration: Create migrate_downtime_limit() function

2023-04-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/migration.c | 4 ++-- migration/options.c | 7 +++ migration/options.h | 1 + 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 45fc5be93a..ee8e9416ce 100644 --- a/migration/migrat

[PATCH v3 04/13] migration: Make all functions check have the same format

2023-04-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/options.c | 153 +++- 1 file changed, 39 insertions(+), 114 deletions(-) diff --git a/migration/options.c b/migration/options.c index 201f9ff58f..bf4efd6ad4 100644 --- a/migration/options.c +++ b/migration/options

[PATCH v3 01/13] migration: Move migrate_use_tls() to options.c

2023-04-24 Thread Juan Quintela
Once there, rename it to migrate_tls() and make it return bool for consistency. Signed-off-by: Juan Quintela --- Fix typos found by fabiano --- migration/migration.c | 9 - migration/migration.h | 2 -- migration/options.c | 11 ++- migration/options.h | 1 + migration/t

[PATCH v3 09/13] migration: Create migrate_tls_creds() function

2023-04-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/options.c | 7 +++ migration/options.h | 1 + migration/tls.c | 9 - 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/migration/options.c b/migration/options.c index f65b7babef..9eabb4c25d 100644 --- a/migration/options.c +

[PATCH v3 08/13] migration: Remove MigrationState from block_cleanup_parameters()

2023-04-24 Thread Juan Quintela
This makes the function more regular with everything else. Signed-off-by: Juan Quintela --- migration/migration.c | 4 ++-- migration/options.c | 4 +++- migration/options.h | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/migration/migration.c b/migration/migration.c i

[PATCH v3 06/13] migration: Move migrate_set_block_incremental() to options.c

2023-04-24 Thread Juan Quintela
Once there, make it more regular and remove th eneed for MigrationState parameter. Signed-off-by: Juan Quintela --- migration/migration.c | 9 ++--- migration/options.c | 9 + migration/options.h | 4 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/migration/

[PATCH v3 13/13] migration: Move migration_properties to options.c

2023-04-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/migration.c | 157 -- migration/options.c | 155 + migration/options.h | 7 ++ 3 files changed, 162 insertions(+), 157 deletions(-) diff --git a/migration/migration.c

[PATCH v3 00/13] Migration: Create options.c for capabilities/params/properties

2023-04-24 Thread Juan Quintela
Hi In this v3: - Rebase on top of latest. - Fix review of migrate_use_tls() comments. - Remaining of the patches not yet reviewed. Please review. [v2] - the first two patches are included on the last pull request. - Changed copyright from Anthony to Orit (thanks David) Some archeology required

[PATCH v3 10/13] migration: Create migrate_tls_authz() function

2023-04-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/options.c | 7 +++ migration/options.h | 1 + migration/tls.c | 5 + 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/migration/options.c b/migration/options.c index 9eabb4c25d..9e19e4ade1 100644 --- a/migration/options.c +++ b/

[PATCH v3 11/13] migration: Create migrate_tls_hostname() function

2023-04-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/options.c | 7 +++ migration/options.h | 1 + migration/tls.c | 6 -- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/migration/options.c b/migration/options.c index 9e19e4ade1..9fbba84b9a 100644 --- a/migration/options.c +++

[PATCH v3 12/13] migration: Create migrate_block_bitmap_mapping() function

2023-04-24 Thread Juan Quintela
Notice that we changed the test of ->has_block_bitmap_mapping for the test that block_bitmap_mapping is not NULL. Signed-off-by: Juan Quintela --- migration/block-dirty-bitmap.c | 14 -- migration/options.c| 7 +++ migration/options.h| 1 + 3 files chang

[PATCH v3 07/13] migration: Move block_cleanup_parameters() to options.c

2023-04-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/migration.c | 10 -- migration/options.c | 10 ++ migration/options.h | 1 + 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 9a42f73aeb..cefe6da2b8 100644 --- a/mig

Re: test-blockjob: intermittent CI failures in msys2-64bit job

2023-04-24 Thread Vladimir Sementsov-Ogievskiy
On 24.04.23 16:36, Emanuele Giuseppe Esposito wrote: Am 21/04/2023 um 12:13 schrieb Vladimir Sementsov-Ogievskiy: On 17.03.23 15:35, Thomas Huth wrote: On 17/03/2023 11.17, Peter Maydell wrote: On Mon, 6 Mar 2023 at 11:16, Peter Maydell wrote: On Fri, 3 Mar 2023 at 18:36, Peter Maydell w

Re: [PULL 00/20] Block patches

2023-04-24 Thread Sam Li
Stefan Hajnoczi 于2023年4月25日周二 01:52写道: > > On Fri, Apr 21, 2023 at 08:01:56PM +0100, Richard Henderson wrote: > > On 4/20/23 13:09, Stefan Hajnoczi wrote: > > > The following changes since commit > > > c1eb2ddf0f8075faddc5f7c3d39feae3e8e9d6b4: > > > > > >Update version for v8.0.0 release (202

[PULL 1/2] block/dmg: Declare a type definition for DMG uncompress function

2023-04-24 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Introduce the BdrvDmgUncompressFunc type defintion. To emphasis dmg_uncompress_bz2 and dmg_uncompress_lzfse are pointer to functions, declare them using this new typedef. Signed-off-by: Philippe Mathieu-Daudé Message-id: 20230320152610.32052-1-phi...@linaro.org Sign

[PULL 2/2] tracetool: use relative paths for '#line' preprocessor directives

2023-04-24 Thread Stefan Hajnoczi
From: Thomas De Schampheleire The event filename is an absolute path. Convert it to a relative path when writing '#line' directives, to preserve reproducibility of the generated output when different base paths are used. Signed-off-by: Thomas De Schampheleire Signed-off-by: Stefan Hajnoczi Mes

[PULL 0/2] Block patches

2023-04-24 Thread Stefan Hajnoczi
The following changes since commit ac5f7bf8e208cd7893dbb1a9520559e569a4677c: Merge tag 'migration-20230424-pull-request' of https://gitlab.com/juan.quintela/qemu into staging (2023-04-24 15:00:39 +0100) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git

Re: [PULL 00/20] Block patches

2023-04-24 Thread Stefan Hajnoczi
On Fri, Apr 21, 2023 at 08:01:56PM +0100, Richard Henderson wrote: > On 4/20/23 13:09, Stefan Hajnoczi wrote: > > The following changes since commit c1eb2ddf0f8075faddc5f7c3d39feae3e8e9d6b4: > > > >Update version for v8.0.0 release (2023-04-19 17:27:13 +0100) > > > > are available in the Git

Re: [PATCH 2/2] hw/net/allwinner-sun8i-emac: Correctly byteswap descriptor fields

2023-04-24 Thread Alex Bennée
Peter Maydell writes: > In allwinner-sun8i-emac we just read directly from guest memory into > a host FrameDescriptor struct and back. This only works on > little-endian hosts. Reading and writing of descriptors is already > abstracted into functions; make those functions also handle the > by

Re: [PATCH 1/2] hw/sd/allwinner-sdhost: Correctly byteswap descriptor fields

2023-04-24 Thread Alex Bennée
Peter Maydell writes: > In allwinner_sdhost_process_desc() we just read directly from > guest memory into a host TransferDescriptor struct and back. > This only works on little-endian hosts. Abstract the reading > and writing of descriptors into functions that handle the > byte-swapping so that

Re: [PATCH 2/2] hw/net/allwinner-sun8i-emac: Correctly byteswap descriptor fields

2023-04-24 Thread Thomas Huth
On 24/04/2023 18.50, Peter Maydell wrote: In allwinner-sun8i-emac we just read directly from guest memory into a host FrameDescriptor struct and back. This only works on little-endian hosts. Reading and writing of descriptors is already abstracted into functions; make those functions also handl

Re: [PATCH 1/2] hw/sd/allwinner-sdhost: Correctly byteswap descriptor fields

2023-04-24 Thread Thomas Huth
On 24/04/2023 18.50, Peter Maydell wrote: In allwinner_sdhost_process_desc() we just read directly from guest memory into a host TransferDescriptor struct and back. This only works on little-endian hosts. Abstract the reading and writing of descriptors into functions that handle the byte-swapping

[PATCH 0/2] arm: allwinner: fix endianness bugs in sdhost and sun8i-emac

2023-04-24 Thread Peter Maydell
This patchset fixes bugs in the sd controller and ethernet controller devices used in the orangepi-pc board model. The bug is the same in both cases: we read and write a descriptor struct from guest memory without byte-swapping it, so the code only does the right thing on a little-endian host. The

[PATCH 1/2] hw/sd/allwinner-sdhost: Correctly byteswap descriptor fields

2023-04-24 Thread Peter Maydell
In allwinner_sdhost_process_desc() we just read directly from guest memory into a host TransferDescriptor struct and back. This only works on little-endian hosts. Abstract the reading and writing of descriptors into functions that handle the byte-swapping so that TransferDescriptor structs as seen

[PATCH 2/2] hw/net/allwinner-sun8i-emac: Correctly byteswap descriptor fields

2023-04-24 Thread Peter Maydell
In allwinner-sun8i-emac we just read directly from guest memory into a host FrameDescriptor struct and back. This only works on little-endian hosts. Reading and writing of descriptors is already abstracted into functions; make those functions also handle the byte-swapping so that TransferDescript

Re: [PULL 00/20] Block patches

2023-04-24 Thread Stefan Hajnoczi
On Fri, Apr 21, 2023 at 08:01:56PM +0100, Richard Henderson wrote: > On 4/20/23 13:09, Stefan Hajnoczi wrote: > > The following changes since commit c1eb2ddf0f8075faddc5f7c3d39feae3e8e9d6b4: > > > >Update version for v8.0.0 release (2023-04-19 17:27:13 +0100) > > > > are available in the Git

Re: [PATCH] hw/intc/allwinner-a10-pic: Don't use set_bit()/clear_bit()

2023-04-24 Thread Thomas Huth
On 24/04/2023 17.28, Peter Maydell wrote: The Allwinner PIC model uses set_bit() and clear_bit() to update the values in its irq_pending[] array when an interrupt arrives. However it is using these functions wrongly: they work on an array of type 'long', and it is passing an array of type 'uint3

[PATCH v3 0/7] Add EPYC-Genoa model and update previous EPYC Models

2023-04-24 Thread Babu Moger
This series updates the AMD EPYC models and adds new EPYC-Genoa model. Sent out v1,v2 earlier but those changes are not merged yet. Now adding EPYC-Genoa on top of that. Here are the features. a. Allow versioned CPUs to specify new cache_info pointers. b. Add EPYC-v4, EPYC-Rome-v3 and EPYC-Milan-v

Re: [PULL 00/30] Migration 20230424 patches

2023-04-24 Thread Richard Henderson
ository at: https://gitlab.com/juan.quintela/qemu.git tags/migration-20230424-pull-request for you to fetch changes up to 9c894df3a37d675652390f7dbbe2f65b7bad7efa: migration: Create migrate_max_bandwidth() function (2023-04-24 15:01

  1   2   3   4   >