Re: [PATCH] pci: make ROM memory resizable

[Vladimir Sementsov-Ogievskiy]

On 24.04.23 23:41, Michael S. Tsirkin wrote:

@@ -2366,7 +2368,8 @@ static void pci_add_option_rom(PCIDevice *pdev, bool 
is_default_rom,
          snprintf(name, sizeof(name), "%s.rom", 
object_get_typename(OBJECT(pdev)));
      }
      pdev->has_rom = true;
-    memory_region_init_rom(&pdev->rom, OBJECT(pdev), name, pdev->romsize, 
&error_fatal);
+    memory_region_init_rom_resizable(&pdev->rom, OBJECT(pdev), name,
+                                     pdev->romsize, MAX_ROM_SIZE, 
&error_fatal);
      ptr = memory_region_get_ram_ptr(&pdev->rom);
      if (load_image_size(path, ptr, size) < 0) {
          error_setg(errp, "failed to load romfile \"%s\"", pdev->romfile);

You know this steals 2GB from address space, yes? This is quite a lot

Oops no, I didn't.

--
Best regards,
Vladimir