Re: [PATCH v3 1/3] util/main-loop: Fix maximum number of wait objects for win32

2022-09-08 Thread Bin Meng
On Fri, Sep 2, 2022 at 12:19 PM Bin Meng wrote: > > On Wed, Aug 24, 2022 at 4:52 PM Bin Meng wrote: > > > > From: Bin Meng > > > > The maximum number of wait objects for win32 should be > > MAXIMUM_WAIT_OBJECTS, not MAXIMUM_WAIT_OBJECTS + 1. > > > > Signed-off-by: Bin Meng > > --- > > > > Chang

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-08 Thread Jason Wang
On Fri, Sep 9, 2022 at 2:38 PM Jason Wang wrote: > > On Wed, Sep 7, 2022 at 12:36 AM Eugenio Pérez wrote: > > > > To have enabled vlans at device startup may happen in the destination of > > a live migration, so this configuration must be restored. > > > > At this moment the code is not accessibl

Re: [PATCH 3/3] vdpa: Support VLAN on nic control shadow virtqueue

2022-09-08 Thread Jason Wang
On Wed, Sep 7, 2022 at 12:36 AM Eugenio Pérez wrote: > > Update the virtio-net device model with each guest's update of vlan > through control virtqueue, and accept creating a SVQ with a device > exposing vlan feature bit. > > Done in the same commit since a malicious guest could send vlan > comma

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-08 Thread Jason Wang
On Wed, Sep 7, 2022 at 12:36 AM Eugenio Pérez wrote: > > To have enabled vlans at device startup may happen in the destination of > a live migration, so this configuration must be restored. > > At this moment the code is not accessible, since SVQ refuses to start if > vlan feature is exposed by th

Re: [PATCH v2 2/2] [RfC] expose host-phys-bits to guest

2022-09-08 Thread Michael S. Tsirkin
On Fri, Sep 09, 2022 at 08:06:53AM +0200, Gerd Hoffmann wrote: > Hi, > > > > > I think we still want to key this one off host_phys_bits > > > > so it works for e.g. hyperv emulation too. > > > > > > I think that should be the case. The chunks above change the > > > host-phys-bits option from s

Re: [PATCH v3] audio: Add sndio backend

2022-09-08 Thread Volker Rümelin
Am 07.09.22 um 15:23 schrieb Alexandre Ratchov: sndio is the native API used by OpenBSD, although it has been ported to other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.). Signed-off-by: Brad Smith Signed-off-by: Alexandre Ratchov --- References to the previous patch version

Re: [PATCH v2 2/2] [RfC] expose host-phys-bits to guest

2022-09-08 Thread Gerd Hoffmann
Hi, > > > I think we still want to key this one off host_phys_bits > > > so it works for e.g. hyperv emulation too. > > > > I think that should be the case. The chunks above change the > > host-phys-bits option from setting cpu->host_phys_bits to setting > > the FEAT_KVM_HINTS bit. That shoul

Re: [PATCH v2 2/2] [RfC] expose host-phys-bits to guest

2022-09-08 Thread Michael S. Tsirkin
On Fri, Sep 09, 2022 at 07:18:17AM +0200, Gerd Hoffmann wrote: > Hi, > > > > @@ -424,7 +426,10 @@ static void > > > microvm_device_pre_plug_cb(HotplugHandler *hotplug_dev, > > > { > > > X86CPU *cpu = X86_CPU(dev); > > > > > > -cpu->host_phys_bits = true; /* need reliable phys-bits *

Re: [PATCH v2 2/2] [RfC] expose host-phys-bits to guest

2022-09-08 Thread Gerd Hoffmann
Hi, > > @@ -424,7 +426,10 @@ static void microvm_device_pre_plug_cb(HotplugHandler > > *hotplug_dev, > > { > > X86CPU *cpu = X86_CPU(dev); > > > > -cpu->host_phys_bits = true; /* need reliable phys-bits */ > > +/* need reliable phys-bits */ > > +cpu->env.features[FEAT_KVM_HI

Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-09-08 Thread Andy Lutomirski
On 8/24/22 02:41, Chao Peng wrote: On Tue, Aug 23, 2022 at 04:05:27PM +, Sean Christopherson wrote: On Tue, Aug 23, 2022, David Hildenbrand wrote: On 19.08.22 05:38, Hugh Dickins wrote: On Fri, 19 Aug 2022, Sean Christopherson wrote: On Thu, Aug 18, 2022, Kirill A . Shutemov wrote: On We

Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-09-08 Thread Andy Lutomirski
On 8/19/22 17:27, Kirill A. Shutemov wrote: On Thu, Aug 18, 2022 at 08:00:41PM -0700, Hugh Dickins wrote: On Thu, 18 Aug 2022, Kirill A . Shutemov wrote: On Wed, Aug 17, 2022 at 10:40:12PM -0700, Hugh Dickins wrote: If your memory could be swapped, that would be enough of a good reason to mak

Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-09-08 Thread Andy Lutomirski
On 8/18/22 06:24, Kirill A . Shutemov wrote: On Wed, Aug 17, 2022 at 10:40:12PM -0700, Hugh Dickins wrote: On Wed, 6 Jul 2022, Chao Peng wrote: This is the v7 of this series which tries to implement the fd-based KVM guest private memory. Here at last are my reluctant thoughts on this patchset

Re: Seeing qtest assertion failure with 7.1

2022-09-08 Thread Markus Armbruster
Peter Maydell writes: > On Thu, 8 Sept 2022 at 16:54, Patrick Venture wrote: >> On Wed, Sep 7, 2022 at 10:40 AM Peter Maydell >> wrote: >>> Have a look in the source at what exactly the assertion >>> failure in libqtest.c is checking for -- IIRC it's a pretty >>> basic "did we open a socket fd

Re: [PATCH v3] audio: add help option for -audio and -audiodev

2022-09-08 Thread Markus Armbruster
Paolo Bonzini writes: > No, there's nothing yet. What about QOM introspection? Oh, we're not using QOM there. Would QOMification be desirable?

[PATCH v2 2/2] Update linux headers to v6.0-rc4

2022-09-08 Thread Chenyi Qiang
commit 7e18e42e4b280c85b76967a9106a13ca61c16179 Signed-off-by: Chenyi Qiang --- include/standard-headers/asm-x86/bootparam.h | 7 +- include/standard-headers/drm/drm_fourcc.h | 73 +++- include/standard-headers/linux/ethtool.h | 29 +-- include/standard-headers/linux/input.h

[PATCH v2 0/2] Update linux headers to v6.0-rc4 and fix the clang build error

2022-09-08 Thread Chenyi Qiang
After updating linux headers to v6.0-rc, clang build on x86 target would generate warnings related to -Wgnu-variable-sized-type-not-at-end. Simply turn off this warning in this patch set. --- Change logs v1 -> v2: - Change the patch order. (Peter Maydell) - Expand the commit message in patch 1.

[PATCH v2 1/2] configure: Add -Wno-gnu-variable-sized-type-not-at-end

2022-09-08 Thread Chenyi Qiang
In recent linux headers update to v6.0-rc, it switched GNU 'zero-length-array' extension to the C-standard-defined flexible array member. e.g. struct kvm_msrs { __u32 nmsrs; /* number of msrs in entries */ __u32 pad; - struct kvm_msr_entry entries[0]; + struct kvm_msr_

Re: [PATCH v4 0/6] Vhost-vdpa Shadow Virtqueue multiqueue support.

2022-09-08 Thread Jason Wang
On Tue, Sep 6, 2022 at 11:07 PM Eugenio Pérez wrote: > > This series enables shadowed CVQ to intercept multiqueue commands through > shadowed CVQ, update the virtio NIC device model so qemu send it in a > migration, and the restore of that MQ state in the destination. > > v3: > * Accept ctrl class

Re: [PATCH] hw/net/tulip: Fix DMA reentrancy issue with stack overflow (CVE-2022-2962)

2022-09-08 Thread Jason Wang
On Sat, Aug 27, 2022 at 3:03 PM Thomas Huth wrote: > > The Tulip NIC can be used to trigger an endless recursion when its > descriptors are set up to its own MMIO address space. Fix it by > limiting the DMA accesses to normal memory. > > Fixes: CVE-2022-2962 > Resolves: https://gitlab.com/qemu-pro

Re: [PATCH] e1000e: set RX desc status with DD flag in a separate operation

2022-09-08 Thread Jason Wang
On Sat, Aug 27, 2022 at 12:06 AM Ding Hui wrote: > > Like commit 034d00d48581 ("e1000: set RX descriptor status in > a separate operation"), there is also same issue in e1000e, which > would cause lost packets or stop sending packets to VM with DPDK. > > Do similar fix in e1000e. > > Resolves: htt

Re: [PATCH 2/2] configure: Add -Wno-gnu-variable-sized-type-not-at-end

2022-09-08 Thread Chenyi Qiang
On 9/8/2022 6:54 PM, Peter Maydell wrote: On Thu, 8 Sept 2022 at 10:09, Daniel P. Berrangé wrote: On Thu, Sep 08, 2022 at 09:53:44AM +0100, Peter Maydell wrote: On Thu, 8 Sept 2022 at 09:08, Chenyi Qiang wrote: After updating linux headers to v6.0-rc, clang build on x86 target would gen

[PATCH] virtio-gpu: update scanout if there is any area covered by the rect

2022-09-08 Thread Dongwon Kim
The scanout is currently updated only if the whole rect is inside the scanout space. This is not a correct condition because the scanout should be updated even a small area in the scanout space is covered by the rect. Cc: Gerd Hoffmann Signed-off-by: Dongwon Kim --- hw/display/virtio-gpu.c | 7

Re: [PATCH 2/2] target/riscv: remove fixed numbering from GDB xml feature files

2022-09-08 Thread Palmer Dabbelt
On Wed, 31 Aug 2022 01:41:23 PDT (-0700), aburg...@redhat.com wrote: The fixed register numbering in the various GDB feature files for RISC-V only exists because these files were originally copied from the GDB source tree. However, the fixed numbering only exists in the GDB source tree so that G

Re: [PATCH v3] audio: add help option for -audio and -audiodev

2022-09-08 Thread Paolo Bonzini
No, there's nothing yet. Paolo Il gio 8 set 2022, 15:47 Claudio Fontana ha scritto: > On 9/8/22 11:39, Paolo Bonzini wrote: > > Queued, thanks. > > > > Paolo > > > > > > Thanks. When it comes to programmatic checks about what QEMU supports in > terms of audio, > > is there something that can be

Re: [PATCH 3/4] hw/timer: ibex_timer.c: Update register addresses

2022-09-08 Thread Tyler Ng
On Thu, Sep 8, 2022 at 4:56 AM Alistair Francis wrote: > On Fri, Sep 2, 2022 at 3:24 AM Tyler Ng wrote: > > > > Updates the register addresses to match the OpenTitan spec. > > > > These changes were made in this commit: > > > https://github.com/lowRISC/opentitan/commit/a25e162b8f91bd0ca32258c83d

Re: [PATCH 1/4] hw/watchdog: wdt_ibex_aon.c: Implement the watchdog for the OpenTitan

2022-09-08 Thread Tyler Ng
On Thu, Sep 8, 2022 at 4:52 AM Alistair Francis wrote: > On Fri, Sep 2, 2022 at 3:29 AM Tyler Ng wrote: > > > > This commit adds most of an implementation of the OpenTitan Always-On > > Timer. The documentation for this timer is found here: > > > > https://docs.opentitan.org/hw/ip/aon_timer/doc/

Re: [PATCH v2 12/20] disas/nanomips: Replace std::string type

2022-09-08 Thread Milica Lazarevic
Thanks, it's more clear to me now! I'll modify it in the next by the suggestions. From: Richard Henderson Sent: Thursday, September 8, 2022 11:14 PM To: Milica Lazarevic ; th...@redhat.com Cc: qemu-devel@nongnu.org ; cfont...@suse.de ; berra...@redhat.com ; pb

Re: [PATCH] tcg/ppc: Optimize 26-bit jumps

2022-09-08 Thread Richard Henderson
On 9/8/22 22:18, Leandro Lupori wrote: PowerPC64 processors handle direct branches better than indirect ones, resulting in less stalled cycles and branch misses. However, PPC's tb_target_set_jmp_target() was only using direct branches for 16-bit jumps, while PowerPC64's unconditional branch inst

[PATCH] tcg/ppc: Optimize 26-bit jumps

2022-09-08 Thread Leandro Lupori
PowerPC64 processors handle direct branches better than indirect ones, resulting in less stalled cycles and branch misses. However, PPC's tb_target_set_jmp_target() was only using direct branches for 16-bit jumps, while PowerPC64's unconditional branch instructions are able to handle displacements

Re: [PATCH v2 12/20] disas/nanomips: Replace std::string type

2022-09-08 Thread Richard Henderson
On 9/8/22 20:16, Milica Lazarevic wrote: This would be better written as char *reg_list[33]; assert(count <= 32); for (c = 0; c < count; c++) { bool use_gp = ... uint64 this_rt = ... /* glib usage below requires casting

Re: [PATCH v2 1/5] msmouse: Handle mouse reset

2022-09-08 Thread Peter Maydell
On Thu, 8 Sept 2022 at 18:43, Arwed Meyer wrote: > > Detect mouse reset via RTS or DTR line: > Don't send or process anything while in reset. > When coming out of reset, send ID sequence first thing. > This allows msmouse to be detected by common mouse drivers. > > Resolves: https://gitlab.com/qem

Re: [PATCH 42/42] hw/i386/acpi-build: Resolve PIIX ISA bridge rather than ACPI controller

2022-09-08 Thread Bernhard Beschow
Am 1. September 2022 21:05:03 UTC schrieb "Philippe Mathieu-Daudé" : >On 1/9/22 18:26, Bernhard Beschow wrote: >> Resolving the PIIX ISA bridge rather than the PIIX ACPI controller mirrors >> the ICH9 code one line below. >> >> Signed-off-by: Bernhard Beschow >> --- >> hw/i386/acpi-build.c | 2

Re: [PATCH v7 08/14] hw/ppc: set machine->fdt in pegasos2_machine_reset()

2022-09-08 Thread BALATON Zoltan
On Thu, 8 Sep 2022, Daniel Henrique Barboza wrote: We'll introduce a QMP/HMP command that requires machine->fdt to be set properly. Cc: BALATON Zoltan Cc: qemu-...@nongnu.org Signed-off-by: Daniel Henrique Barboza Reviewed-by: BALATON Zoltan --- hw/ppc/pegasos2.c | 4 1 file changed,

Re: [PATCH v7 05/14] hw/ppc: set machine->fdt in bamboo_load_device_tree()

2022-09-08 Thread BALATON Zoltan
On Thu, 8 Sep 2022, Daniel Henrique Barboza wrote: This will enable support for 'dumpdtb' QMP/HMP command for the bamboo machine. Setting machine->fdt requires a MachineState pointer to be used inside bamboo_load_device_tree(). Let's change the function to receive this pointer from the caller. '

Re: [PATCH v7 07/14] hw/ppc: set machine->fdt in xilinx_load_device_tree()

2022-09-08 Thread BALATON Zoltan
On Thu, 8 Sep 2022, Daniel Henrique Barboza wrote: This will enable support for 'dumpdtb' QMP/HMP command for the virtex_ml507 machine. Setting machine->fdt requires a MachineState pointer to be used inside xilinx_load_device_tree(). Let's change the function to receive this pointer from the cal

[PATCH v7 10/14] hw/ppc: set machine->fdt in spapr machine

2022-09-08 Thread Daniel Henrique Barboza
The pSeries machine never bothered with the common machine->fdt attribute. We do all the FDT related work using spapr->fdt_blob. We're going to introduce a QMP/HMP command to dump the FDT, which will rely on setting machine->fdt properly to work across all machine archs/types. Let's set machine->

[PATCH v7 14/14] qmp/hmp, device_tree.c: introduce dumpdtb

2022-09-08 Thread Daniel Henrique Barboza
To save the FDT blob we have the '-machine dumpdtb=' property. With this property set, the machine saves the FDT in and exit. The created file can then be converted to plain text dts format using 'dtc'. There's nothing particularly sophisticated into saving the FDT that can't be done with the mac

[PATCH v7 08/14] hw/ppc: set machine->fdt in pegasos2_machine_reset()

2022-09-08 Thread Daniel Henrique Barboza
We'll introduce a QMP/HMP command that requires machine->fdt to be set properly. Cc: BALATON Zoltan Cc: qemu-...@nongnu.org Signed-off-by: Daniel Henrique Barboza --- hw/ppc/pegasos2.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c index 61f4263953

[PATCH v7 13/14] hw/xtensa: set machine->fdt in xtfpga_init()

2022-09-08 Thread Daniel Henrique Barboza
This will enable support for the 'dumpdtb' QMP/HMP command for all xtensa machines that uses a FDT. Signed-off-by: Daniel Henrique Barboza --- hw/xtensa/meson.build | 2 +- hw/xtensa/xtfpga.c| 6 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/xtensa/meson.build b/hw

[PATCH v7 06/14] hw/ppc: set machine->fdt in sam460ex_load_device_tree()

2022-09-08 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for the sam460ex machine. Setting machine->fdt requires a MachineState pointer to be used inside sam460ex_load_device_tree(). Let's change the function to receive this pointer from the caller. 'ramsize' and 'kernel_cmdline' can be retrieved di

[PATCH v7 12/14] hw/riscv: set machine->fdt in spike_board_init()

2022-09-08 Thread Daniel Henrique Barboza
This will enable support for the 'dumpdtb' QMP/HMP command for the spike machine. Cc: Palmer Dabbelt Cc: Alistair Francis Cc: Bin Meng Reviewed-by: Alistair Francis Signed-off-by: Daniel Henrique Barboza --- hw/riscv/spike.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/riscv/

[PATCH v7 05/14] hw/ppc: set machine->fdt in bamboo_load_device_tree()

2022-09-08 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for the bamboo machine. Setting machine->fdt requires a MachineState pointer to be used inside bamboo_load_device_tree(). Let's change the function to receive this pointer from the caller. 'ramsize' and 'kernel_cmdline' can be retrieved direct

[PATCH v7 11/14] hw/riscv: set machine->fdt in sifive_u_machine_init()

2022-09-08 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for the sifive_u machine. Cc: Alistair Francis Cc: Bin Meng Cc: Palmer Dabbelt Reviewed-by: Alistair Francis Signed-off-by: Daniel Henrique Barboza --- hw/riscv/sifive_u.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/riscv/s

[PATCH v7 04/14] hw/ppc: set machine->fdt in ppce500_load_device_tree()

2022-09-08 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for the e500 machine. Cc: Cédric Le Goater Signed-off-by: Daniel Henrique Barboza --- hw/ppc/e500.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 32495d0123..ea5f947824

[PATCH v7 07/14] hw/ppc: set machine->fdt in xilinx_load_device_tree()

2022-09-08 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for the virtex_ml507 machine. Setting machine->fdt requires a MachineState pointer to be used inside xilinx_load_device_tree(). Let's change the function to receive this pointer from the caller. kernel_cmdline' can be retrieved directly from t

[PATCH v7 02/14] hw/microblaze: set machine->fdt in microblaze_load_dtb()

2022-09-08 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for all microblaze machines that uses microblaze_load_dtb(). Cc: Edgar E. Iglesias Signed-off-by: Daniel Henrique Barboza --- hw/microblaze/boot.c | 8 +++- hw/microblaze/meson.build | 2 +- 2 files changed, 8 insertions(+), 2 dele

[PATCH v7 09/14] hw/ppc: set machine->fdt in pnv_reset()

2022-09-08 Thread Daniel Henrique Barboza
This will enable support for the 'dumpdtb' QMP/HMP command for all powernv machines. Reviewed-by: Cédric Le Goater Reviewed-by: Frederic Barrat Signed-off-by: Daniel Henrique Barboza --- hw/ppc/pnv.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/ppc/pnv.c b/hw/p

[PATCH v7 03/14] hw/nios2: set machine->fdt in nios2_load_dtb()

2022-09-08 Thread Daniel Henrique Barboza
This will enable support for 'dumpdtb' QMP/HMP command for all nios2 machines that uses nios2_load_dtb(). Cc: Chris Wulff Cc: Marek Vasut Signed-off-by: Daniel Henrique Barboza --- hw/nios2/boot.c | 8 +++- hw/nios2/meson.build | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-)

[PATCH v7 01/14] hw/arm: do not free machine->fdt in arm_load_dtb()

2022-09-08 Thread Daniel Henrique Barboza
At this moment, arm_load_dtb() can free machine->fdt when binfo->dtb_filename is NULL. If there's no 'dtb_filename', 'fdt' will be retrieved by binfo->get_dtb(). If get_dtb() returns machine->fdt, as is the case of machvirt_dtb() from hw/arm/virt.c, fdt now has a pointer to machine->fdt. And, in th

[PATCH v7 00/14] QMP/HMP: introduce 'dumpdtb'

2022-09-08 Thread Daniel Henrique Barboza
Hi, This new version implements all change requests from the v6. - patch 5: - change bamboo_load_device_tree() to use a MachineState pointer - patch 7: - change xilinx_load_device_tree() to use a MachineState pointer - patch 14: - placed SRST/ERST below the { }'s - removed the '/tmp' refe

Re: [PATCH v2 12/20] disas/nanomips: Replace std::string type

2022-09-08 Thread Milica Lazarevic
On 9/5/22 10:55, Milica Lazarevic wrote: > -static std::string save_restore_list(uint64 rt, uint64 count, uint64 gp) > +static char *save_restore_list(uint64 rt, uint64 count, uint64 gp) > { > -std::string str; > +/* > + * Currently, this file compiles as a cpp file, so the explicit

[PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-08 Thread Claudio Fontana
improve error handling during module load, by changing: bool module_load_one(const char *prefix, const char *lib_name); void module_load_qom_one(const char *type); to: bool module_load_one(const char *prefix, const char *name, Error **errp); bool module_load_qom_one(const char *type, Error **err

[PATCH v4 3/3] accel: abort if we fail to load the accelerator plugin

2022-09-08 Thread Claudio Fontana
if QEMU is configured with modules enabled, it is possible that the load of an accelerator module will fail. Abort in this case, relying on module_object_class_by_name to report the specific load error if any. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson --- accel/accel-softmmu

[PATCH v4 0/3] improve error handling for module load

2022-09-08 Thread Claudio Fontana
CHANGELOG: v3 -> v4: (Richard) * module_object_class_by_name: return NULL immediately on load error. * audio_driver_lookup: same. * bdrv_find_format: same. * dmg_open: handle optional compression submodules better: f.e., if "dmg-bz2" is not present, continue but offer a warning. If "dmg-bz2"

[PATCH v4 1/3] module: removed unused function argument "mayfail"

2022-09-08 Thread Claudio Fontana
mayfail is always passed as false for every invocation throughout the program. It controls whether to printf or not to printf an error on g_module_open failure. Remove this unused argument. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- i

Re: [PATCH v9 07/10] s390x/cpu_topology: CPU topology migration

2022-09-08 Thread Janis Schoetterl-Glausch
On Fri, 2022-09-02 at 09:55 +0200, Pierre Morel wrote: > The migration can only take place if both source and destination > of the migration both use or both do not use the CPU topology > facility. > > We indicate a change in topology during migration postload for the > case the topology changed b

Re: [PATCH 3/6] parallels: Add checking and repairing duplicate offsets in BAT

2022-09-08 Thread Denis V. Lunev
On 9/8/22 19:15, Denis V. Lunev wrote: On 9/2/22 10:52, Alexander Ivanov wrote: Cluster offsets must be unique among all BAT entries. Find duplicate offsets in the BAT. If a duplicated offset is found fix it by copying the content of the relevant cluster to a new allocated cluster and set the n

[PATCH v2 2/5] chardev: src buffer const for write functions

2022-09-08 Thread Arwed Meyer
Make source buffers const for char be write functions. This allows using buffers returned by fifo as buf parameter and source buffer should not be changed by write functions anyway. Signed-off-by: Arwed Meyer --- chardev/char.c | 4 ++-- include/chardev/char.h | 4 ++-- include/sysemu/

Re: [PATCH v3 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-08 Thread Claudio Fontana
On 9/8/22 19:10, Claudio Fontana wrote: > On 9/8/22 18:03, Richard Henderson wrote: >> On 9/8/22 15:53, Claudio Fontana wrote: >>> @@ -446,8 +447,13 @@ static int dmg_open(BlockDriverState *bs, QDict >>> *options, int flags, >>> return -EINVAL; >>> } >>> >>> -block_module_lo

[PATCH v2 1/5] msmouse: Handle mouse reset

2022-09-08 Thread Arwed Meyer
Detect mouse reset via RTS or DTR line: Don't send or process anything while in reset. When coming out of reset, send ID sequence first thing. This allows msmouse to be detected by common mouse drivers. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/77 Signed-off-by: Arwed Meyer --- cha

[PATCH v2 3/5] msmouse: Use fifo8 instead of array

2022-09-08 Thread Arwed Meyer
Make use of fifo8 functions instead of implementing own fifo code. This makes the code more readable and reduces risk of bugs. Signed-off-by: Arwed Meyer --- chardev/msmouse.c | 43 +-- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/charde

[PATCH v2 0/5] Make serial msmouse work

2022-09-08 Thread Arwed Meyer
This series of patches makes `-serial msmouse` work in practice. Tested with FreeDOS/CTMouse driver `ctmouse /V` which identifies a Logitech compatible 3 button mouse. It will probably run as well with any other compatible serial mouse driver on Windows 9x etc. Arwed Meyer (5): msmouse: Handle

[PATCH v2 4/5] msmouse: Add pnp data

2022-09-08 Thread Arwed Meyer
Make msmouse send serial pnp data. Enables you to see nice qemu device name in Win9x. Signed-off-by: Arwed Meyer --- chardev/msmouse.c | 58 ++- 1 file changed, 47 insertions(+), 11 deletions(-) diff --git a/chardev/msmouse.c b/chardev/msmouse.c index

[PATCH v2 5/5] serial: Allow unaligned i/o access

2022-09-08 Thread Arwed Meyer
Unaligned i/o access on serial UART works on real PCs. This is used for example by FreeDOS CTMouse driver. Without this it can't reset and detect serial mice. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/77 Signed-off-by: Arwed Meyer --- hw/char/serial.c | 3 +++ 1 file changed, 3 ins

Re: [PATCH 1/4] msmouse: Handle mouse reset

2022-09-08 Thread Arwed Meyer
Am 08.09.22 um 11:45 schrieb Marc-André Lureau: Hi On Wed, Sep 7, 2022 at 2:03 AM Arwed Meyer mailto:arwed.me...@gmx.de>> wrote: Detect mouse reset via RTS or DTR line: Don't send or process anything while in reset. When coming out of reset, send ID sequence first thing. This al

Re: [PATCH 4/4] serial: Allow unaligned i/o access

2022-09-08 Thread Arwed Meyer
Am 08.09.22 um 13:15 schrieb Michael S. Tsirkin: On Thu, Sep 08, 2022 at 02:11:28PM +0400, Marc-André Lureau wrote: Hi On Wed, Sep 7, 2022 at 2:03 AM Arwed Meyer wrote: Unaligned i/o access on serial UART works on real PCs. This is used for example by FreeDOS CTMouse driver. Without

Re: [PATCH 3/6] parallels: Add checking and repairing duplicate offsets in BAT

2022-09-08 Thread Denis V. Lunev
On 9/2/22 10:52, Alexander Ivanov wrote: Cluster offsets must be unique among all BAT entries. Find duplicate offsets in the BAT. If a duplicated offset is found fix it by copying the content of the relevant cluster to a new allocated cluster and set the new cluster offset to the duplicated entr

Re: [PATCH v3 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-08 Thread Claudio Fontana
On 9/8/22 18:03, Richard Henderson wrote: > On 9/8/22 15:53, Claudio Fontana wrote: >> @@ -446,8 +447,13 @@ static int dmg_open(BlockDriverState *bs, QDict >> *options, int flags, >> return -EINVAL; >> } >> >> -block_module_load_one("dmg-bz2"); >> -block_module_load_one(

Re: [PATCH 6/6] parallels: Image repairing in parallels_open()

2022-09-08 Thread Denis V. Lunev
On 9/2/22 10:53, Alexander Ivanov wrote: Repair an image at opening if the image is unclean or out-of-image corruption was detected. Signed-off-by: Alexander Ivanov --- block/parallels.c | 95 --- 1 file changed, 65 insertions(+), 30 deletions(-)

Re: [PATCH v3] 9pfs: use GHashTable for fid table

2022-09-08 Thread Linus Heckemann
(sorry for the dup @Greg, forgot to reply-all) Greg Kurz writes: >> > g_hash_table_steal_extended() [1] actually allows to do just that. >> >> g_hash_table_steal_extended unfortunately isn't available since it was >> introduced in glib 2.58 and we're maintaining compatibility to 2.56. >> > > Ha

Re: [PATCH v3] 9pfs: use GHashTable for fid table

2022-09-08 Thread Greg Kurz
On Thu, 08 Sep 2022 18:10:28 +0200 Linus Heckemann wrote: > (sorry for the dup @Greg, forgot to reply-all) > > Greg Kurz writes: > >> > g_hash_table_steal_extended() [1] actually allows to do just that. > >> > >> g_hash_table_steal_extended unfortunately isn't available since it was > >> intro

[PATCH v2] fw_cfg: Don't set callback_opaque NULL in fw_cfg_modify_bytes_read()

2022-09-08 Thread Shameer Kolothum via
On arm/virt platform, Chen Xiang reported a Guest crash while attempting the below steps, 1. Launch the Guest with nvdimm=on 2. Hot-add a NVDIMM dev 3. Reboot 4. Guest boots fine. 5. Reboot again. 6. Guest boot fails. QEMU_EFI reports the below error: ProcessCmdAddPointer: invalid pointer value i

Re: [PATCH v3 3/3] accel: abort if we fail to load the accelerator plugin

2022-09-08 Thread Richard Henderson
On 9/8/22 15:53, Claudio Fontana wrote: if QEMU is configured with modules enabled, it is possible that the load of an accelerator module will fail. Abort in this case, relying on module_object_class_by_name to report the specific load error if any. Signed-off-by: Claudio Fontana --- accel/acc

Re: Seeing qtest assertion failure with 7.1

2022-09-08 Thread Peter Maydell
On Thu, 8 Sept 2022 at 16:54, Patrick Venture wrote: > On Wed, Sep 7, 2022 at 10:40 AM Peter Maydell > wrote: >> Have a look in the source at what exactly the assertion >> failure in libqtest.c is checking for -- IIRC it's a pretty >> basic "did we open a socket fd" one. I think sometimes I >> u

Re: [PATCH v3 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-08 Thread Richard Henderson
On 9/8/22 15:53, Claudio Fontana wrote: @@ -446,8 +447,13 @@ static int dmg_open(BlockDriverState *bs, QDict *options, int flags, return -EINVAL; } -block_module_load_one("dmg-bz2"); -block_module_load_one("dmg-lzfse"); +if (!block_module_load_one("dmg-bz2", &loca

Re: Seeing qtest assertion failure with 7.1

2022-09-08 Thread Patrick Venture
On Wed, Sep 7, 2022 at 10:40 AM Peter Maydell wrote: > On Wed, 7 Sept 2022 at 16:39, Patrick Venture wrote: > > > > # Start of nvme tests > > # Start of pci-device tests > > # Start of pci-device-tests tests > > # starting QEMU: exec ./qemu-system-aarch64 -qtest > unix:/tmp/qtest-1431.sock -qtes

[PATCH RESEND v3 0/3] improve error handling for module load

2022-09-08 Thread Claudio Fontana
CHANGELOG: v2 -> v3: * take the file existence check outside of module_load_file, rename module_load_file to module_load_dso, will be called only on an existing file. This will simplify the return value. (Richard) * move exported function documentation into header files (Richard) v1 -> v2:

[PATCH v3 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-08 Thread Claudio Fontana
improve error handling during module load, by changing: bool module_load_one(const char *prefix, const char *lib_name); void module_load_qom_one(const char *type); to: bool module_load_one(const char *prefix, const char *name, Error **errp); bool module_load_qom_one(const char *type, Error **err

[PATCH v3 1/3] module: removed unused function argument "mayfail"

2022-09-08 Thread Claudio Fontana
mayfail is always passed as false for every invocation throughout the program. It controls whether to printf or not to printf an error on g_module_open failure. Remove this unused argument. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- i

Re: [PATCH v1 4/8] migration: Implement dirty-limit convergence algo

2022-09-08 Thread Hyman Huang
在 2022/9/8 22:47, Peter Xu 写道: Yong, Your recent two posts all got wrongly cut-off by your mail server for some reason.. Hm, i noticed that, i'll check it. Thanks for reminding. :) -- Best regard Hyman Huang(黄勇)

[PATCH v3 3/3] accel: abort if we fail to load the accelerator plugin

2022-09-08 Thread Claudio Fontana
if QEMU is configured with modules enabled, it is possible that the load of an accelerator module will fail. Abort in this case, relying on module_object_class_by_name to report the specific load error if any. Signed-off-by: Claudio Fontana --- accel/accel-softmmu.c | 8 +++- 1 file changed,

[PATCH v3 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-08 Thread Claudio Fontana
improve error handling during module load, by changing: bool module_load_one(const char *prefix, const char *lib_name); void module_load_qom_one(const char *type); to: bool module_load_one(const char *prefix, const char *name, Error **errp); bool module_load_qom_one(const char *type, Error **err

[PATCH v3 1/3] module: removed unused function argument "mayfail"

2022-09-08 Thread Claudio Fontana
mayfail is always passed as false for every invocation throughout the program. It controls whether to printf or not to printf an error on g_module_open failure. Remove this unused argument. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- i

[PATCH v3 3/3] accel: abort if we fail to load the accelerator plugin

2022-09-08 Thread Claudio Fontana
if QEMU is configured with modules enabled, it is possible that the load of an accelerator module will fail. Abort in this case, relying on module_object_class_by_name to report the specific load error if any. Signed-off-by: Claudio Fontana --- accel/accel-softmmu.c | 8 +++- 1 file changed,

[PATCH v3 0/3] improve error handling for module load

2022-09-08 Thread Claudio Fontana
CHANGELOG: v2 -> v3: * take the file existence check outside of module_load_file, rename module_load_file to module_load_dso, will be called only on an existing file. This will simplify the return value. (Richard) v1 -> v2: * do not treat the display help text any differently and do report

Re: [PATCH v1 4/8] migration: Implement dirty-limit convergence algo

2022-09-08 Thread Peter Xu
Yong, Your recent two posts all got wrongly cut-off by your mail server for some reason.. -- Peter Xu

Re: [PATCH v1 4/8] migration: Implement dirty-limit convergence algo

2022-09-08 Thread Hyman
在 2022/9/7 4:37, Peter Xu 写道: On Fri, Sep 02, 2022 at 01:22:32AM +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Implement dirty-limit convergence algo for live migration, which is kind of like auto-converge algo but using dirty-limit instead of cpu throttle to make migration c

Re: [PATCH v2 2/2] [RfC] expose host-phys-bits to guest

2022-09-08 Thread Michael S. Tsirkin
On Thu, Sep 08, 2022 at 01:31:09PM +0200, Gerd Hoffmann wrote: > Move "host-phys-bits" property from cpu->host_phys_bits to > cpu->env.features[FEAT_KVM_HINTS] (KVM_HINTS_PHYS_ADDRESS_SIZE_DATA_VALID > bit). > > This has the effect that the guest can see whenever host-phys-bits > is turned on or

Re: [PATCH] migrate block dirty bitmap: Fix the block dirty bitmap can't to migration_completion when pending size larger than threshold size : 1、dirty bitmap size big enough (such as 8MB) when bloc

2022-09-08 Thread Markus Armbruster
Your subject line is way too long.

Re: [PATCH 4/7] .gitlab-ci.d/windows.yml: Drop the sed processing in the 64-bit build

2022-09-08 Thread Marc-André Lureau
Hi On Thu, Sep 8, 2022 at 5:33 PM Bin Meng wrote: > From: Bin Meng > > The sed processing of build/config-host.mak seems to be no longer > needed, and there is no such in the 32-bit build too. Drop it. > > Signed-off-by: Bin Meng > --- > > .gitlab-ci.d/windows.yml | 1 - > 1 file changed, 1 d

Re: [PATCH 3/7] scripts/nsis.py: Automatically package required DLLs of QEMU executables

2022-09-08 Thread Marc-André Lureau
Hi (adding Stefan Weil in CC, who currently provides Windows installer) On Thu, Sep 8, 2022 at 5:34 PM Bin Meng wrote: > From: Bin Meng > > At present packaging the required DLLs of QEMU executables is a > manual process, and error prone. > > Actually build/config-host.mak contains a GLIB_BIND

Re: [PATCH 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-08 Thread Claudio Fontana
On 9/8/22 10:11, Richard Henderson wrote: > On 9/6/22 12:55, Claudio Fontana wrote: >> improve error handling during module load, by changing: >> >> bool module_load_one(const char *prefix, const char *lib_name); >> void module_load_qom_one(const char *type); >> >> to: >> >> bool module_load_one(co

Re: [PATCH v3] audio: add help option for -audio and -audiodev

2022-09-08 Thread Claudio Fontana
On 9/8/22 11:39, Paolo Bonzini wrote: > Queued, thanks. > > Paolo > > Thanks. When it comes to programmatic checks about what QEMU supports in terms of audio, is there something that can be done with QMP? I checked the QMP manual at: https://qemu.readthedocs.io/en/latest/interop/qemu-qmp-re

[PATCH] migrate block dirty bitmap: Fix the block dirty bitmap can't to migration_completion when pending size larger than threshold size

2022-09-08 Thread liuhaiwei
From: liuhaiwei 1、dirty bitmap size big enough (such as 8MB) when block size 1T ; 2、we set the migrate speed or the bandwith is small enough(such as 4MB/s) so we set the fake pending size when pending size > threshold size Signed-off-by: liuhaiwei Signed-off-by: liuhaiwei --- migration/block-

Re: [PATCH 2/7] scripts/nsis.py: Fix destination directory name when invoked on Windows

2022-09-08 Thread Marc-André Lureau
On Thu, Sep 8, 2022 at 5:30 PM Bin Meng wrote: > From: Bin Meng > > "make installer" on Windows fails with the following message: > > Traceback (most recent call last): > File "G:\msys64\home\foo\git\qemu\scripts\nsis.py", line 89, in > > main() > File "G:\msys64\home\foo\git\qe

Re: [PATCH 2/2] tpm_emulator: Have swtpm relock storage upon migration fall-back

2022-09-08 Thread Stefan Berger
On 9/8/22 02:04, Marc-André Lureau wrote: Hi On Thu, Sep 8, 2022 at 2:28 AM Stefan Berger wrote: Swtpm may release the lock once the last one of its state blobs has been migrated out. In case of VM migration failure QEMU now needs to notify swtpm that it should again take the lock, which i

Re: [PULL 00/10] QAPI patches patches for 2022-09-07

2022-09-08 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

[PATCH 7/7] .gitlab-ci.d/windows.yml: Test 'make installer' in the CI

2022-09-08 Thread Bin Meng
From: Bin Meng Now that we have supported packaging DLLs automatically, let's add the 'make installer' in the CI and publish the generated installer file as an artifact. Increase the job timeout to 90 minutes to accommodate to it. Signed-off-by: Bin Meng --- .gitlab-ci.d/windows.yml | 27 +++

[PATCH 5/7] block/nfs: Fix 32-bit Windows build

2022-09-08 Thread Bin Meng
From: Bin Meng libnfs.h declares nfs_fstat() as the following for win32: int nfs_fstat(struct nfs_context *nfs, struct nfsfh *nfsfh, struct __stat64 *st); The 'st' parameter should be of type 'struct __stat64'. The codes happen to build successfully for 64-bit Windows, but it

[PATCH 6/7] .gitlab-ci.d/windows.yml: Unify the prerequisite packages

2022-09-08 Thread Bin Meng
From: Bin Meng At present the prerequisite packages for 64-bit and 32-bit builds are slightly different. Let's use the same packages for both. Signed-off-by: Bin Meng --- .gitlab-ci.d/windows.yml | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.d/win

  1   2   3   >