Re: [PATCH 6/8] char: move qemu_openpty_raw from util/ to char/

Hi Paolo On Sat, Feb 26, 2022 at 11:38 AM Paolo Bonzini wrote: > On 2/24/22 18:04, Marc-André Lureau wrote: > > Paolo, > > > > This patch is ok, but in some (new?) circumstances it fails with freebsd > > and reveals that -lutil was missing for kinfo_getproc() in > > util/oslib-posix.c. Please ad

[PATCH] hw/arm/virt: Validate memory size on the first NUMA node

When the memory size on the first NUMA node is less than 128MB, the guest hangs inside EDK2 as the following logs show. /home/gavin/sandbox/qemu.main/build/qemu-system-aarch64 \ -accel kvm -machine virt,gic-version=host \ -cpu host -smp 8,sockets=2,cores=2,threa

Re: [PATCH 0/4] Fix broken PCIe device after migration

Hi, > Well the control is present, isn't it? Can be used to e.g. reset the > device behind the bridge. Well, not right now b/c poweroff ejects the device. Would need a patch like this ... --- a/hw/pci/pcie.c +++ b/hw/pci/pcie.c @@ -755,7 +755,8 @@ void pcie_cap_slot_write_config(PCIDevice *de

Re: [PATCH v2 00/14] vDPA shadow virtqueue

在 2022/2/27 下午9:40, Eugenio Pérez 写道: This series enable shadow virtqueue (SVQ) for vhost-vdpa devices. This is intended as a new method of tracking the memory the devices touch during a migration process: Instead of relay on vhost device's dirty logging capability, SVQ intercepts the VQ datapl

Re: [PATCH v2 11/14] vdpa: Adapt vhost_vdpa_get_vring_base to SVQ

在 2022/2/27 下午9:41, Eugenio Pérez 写道: This is needed to achieve migration, so the destination can restore its index. I suggest to duplicate the comment below here. Thanks Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-vdpa.c | 17 + 1 file changed, 17 insertions(+)

Re: [PATCH 2/4] pcie: update slot power status only is power control is enabled

Hi, > This where I wasn't comfortable with idea of calling random PCIe code > chunks and thought about chaining callbacks so that > pcie_cap_slot_[pre_]plug_cb() would do necessary PCIe steps > and acpi_pcihp_device_[pre_]plug_cb() do ACPI specific things not > intruding on each other, but that

Re: [PATCH v2 10/14] vdpa: Add custom IOTLB translations to SVQ

在 2022/2/27 下午9:41, Eugenio Pérez 写道: Use translations added in VhostIOVATree in SVQ. Only introduce usage here, not allocation and deallocation. As with previous patches, we use the dead code paths of shadow_vqs_enabled to avoid commiting too many changes at once. These are impossible to take

[PULL 6/7] aspeed/smc: Add an address mask on segment registers

Only a limited set of bits are used for decoding the Start and End addresses of the mapping window of a flash device. Signed-off-by: Cédric Le Goater --- include/hw/ssi/aspeed_smc.h | 1 + hw/ssi/aspeed_smc.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/include/hw/s

[PULL 7/7] aspeed/sdmc: Add trace events

This is useful to analyze changes in the U-Boot RAM driver when SDRAM training is performed. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Cédric Le Goater --- hw/misc/aspeed_sdmc.c | 2 ++ hw/misc/trace-events | 4 2 files changed, 6 insertions(+) diff --git a/hw/misc/aspeed_sdmc.c

[PULL 5/7] aspeed: Introduce a create_pca9552() helper

This unifies the way we create the pca9552 devices on the different boards. Suggested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 49 +++-- 1 file changed, 27 insertions(+), 22

[PULL 4/7] aspeed: rainier: Add strap values taken from hardware

From: Joel Stanley When time permits, we should introduce defines for the HW strapping registers to cleanly decode the values. SCU500 = 0x00422016 Disable ARM JTAG trusted world debug: 0x1 Disable ARM JTAG debug: 0x1 VGA Memory Size: 0x1 [16MB] Cortex M3: 0x1 [Disabled] Boot device: 0x

[PULL 2/7] ast2600: Add Secure Boot Controller model

From: Joel Stanley Just a stub that indicates the system has booted in secure boot mode. Used for testing the driver: https://lore.kernel.org/all/20211019080608.283324-1-j...@jms.id.au/ Signed-off-by: Joel Stanley [ clg: - Fixed typo - Adjusted Copyright dates ] Signed-off-by: Cédric L

[PULL 0/7] aspeed queue

tags/pull-aspeed-20220227 for you to fetch changes up to 3671342a38f21316a2bda62e7d607bbaedd60fd8: aspeed/sdmc: Add trace events (2022-02-26 18:40:51 +0100) aspeed queue: * Removal of the swift-bmc machine * New Secure Boot Contro

[PULL 3/7] aspeed: rainier: Add i2c LED devices

From: Joel Stanley This helps quieten booting the current Rainier kernel. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Joel Stanley Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c

[PULL 1/7] arm: Remove swift-bmc machine

From: Joel Stanley It was scheduled for removal in 7.0. Signed-off-by: Joel Stanley Reviewed-by: Cédric Le Goater Signed-off-by: Cédric Le Goater --- docs/about/deprecated.rst | 7 docs/about/removed-features.rst | 5 +++ docs/system/arm/aspeed.rst | 1 - hw/arm/aspeed.c

Re: [PATCH v2 09/14] vhost: Add VhostIOVATree

在 2022/2/27 下午9:41, Eugenio Pérez 写道: This tree is able to look for a translated address from an IOVA address. At first glance it is similar to util/iova-tree. However, SVQ working on devices with limited IOVA space need more capabilities, like allocating IOVA chunks or performing reverse tran

Timer delays in VM

Hi, I am running qemu on an arm64 CentOS host. Inside a ubuntu VM, a process runs a timer created using timer_t: ev.sigev_notify_function = m_callback; ... timer_create(CLOCK_MONOTONIC, &ev, &m_timer_t); This timer sometimes has significant delays. For example, the 50 ms timer can have a callba

Re: [PATCH 8/9] Avocado tests: classify tests based on what it's booted

Acked-by: Pavel Dovgalyuk On 26.02.2022 00:01, Cleber Rosa wrote: This adds some classification to the existing tests, based on the mechanism (and a lot more loosely) on the content of the binary blob. The proposal is to use the "boots" tag, and so far the following values have been defined wi

Re: [PATCH v3 3/4] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

> > >ObjectClass type->name here :) > > > > I see. What about object_resolve_path_type()? It takes a typename > > parameter. It even tells you if the match is ambiguous if you care. > > Yes this is a good suggestion and it will likely work. > You can get rid of your first patch and only make th

Re: [PATCH v2 08/14] util: Add iova_tree_alloc

在 2022/2/27 下午9:41, Eugenio Pérez 写道: This iova tree function allows it to look for a hole in allocated regions and return a totally new translation for a given translated address. It's usage is mainly to allow devices to access qemu address space, remapping guest's one into a new iova space w

Re: [PATCH 4/9] Avocado: bump to version 95.0

On 25/02/2022 22.01, Cleber Rosa wrote: Even though there have been a number of improvements (and some pretty deep internal changes) since Avocado 88.1, only one change should affect "make check-avocado". With the nrunner architecture, test execution happens in parallel by default. But, tests m

Re: [PATCH v2 07/14] vhost: Shadow virtqueue buffers forwarding

在 2022/2/27 下午9:41, Eugenio Pérez 写道: Initial version of shadow virtqueue that actually forward buffers. There is no iommu support at the moment, and that will be addressed in future patches of this series. Since all vhost-vdpa devices use forced IOMMU, this means that SVQ is not usable at this

[PATCH v2 1/2] Replacing CONFIG_VNC_PNG with CONFIG_PNG

Libpng is only detected if VNC is enabled currently. This patch adds a generalised png option in the meson build which is aimed to replace use of CONFIG_VNC_PNG with CONFIG_PNG. Signed-off-by: Kshitij Suri --- meson.build| 10 +- meson_options.txt | 4 ++-- ui/vnc-enc-tight.c |

[PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG.

Currently screendump only supports PPM format, which is un-compressed and not standard. Added a "format" parameter to qemu monitor screendump capabilites to support PNG image capture using libpng. The param was added in QAPI schema of screendump present in ui.json along with png_save() function whi

Re: [PATCH v3 3/4] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

On Mon, Feb 28, 2022 at 3:03 AM Bernhard Beschow wrote: > > Am 27. Februar 2022 18:58:18 UTC schrieb Liav Albani : > > > >On 2/27/22 12:48, Bernhard Beschow wrote: > >> Am 26. Februar 2022 06:30:18 UTC schrieb Liav Albani : > >>> This can allow the guest OS to determine more easily if i8042 contro

RE: [PATCH 3/3] whpx: Added support for breakpoints and stepping

Hi Alex and Peter, It would be great to hear your feedback on handling the WHPX stepping via an added argument to vm_prepare_start(). It is only called from 2 places, so the changes will be minimal. I this works for you, I will gladly send an updated patch. I am also fully open to other sugges

Re: [PATCH] hw/arm/virt: Fix CPU's default NUMA node ID

Hi Igor, On 2/25/22 6:03 PM, Igor Mammedov wrote: On Fri, 25 Feb 2022 16:41:43 +0800 Gavin Shan wrote: On 2/17/22 10:14 AM, Gavin Shan wrote: On 1/26/22 5:14 PM, Igor Mammedov wrote: On Wed, 26 Jan 2022 13:24:10 +0800 Gavin Shan wrote: The default CPU-to-NUMA association is given by mc-

Re: [PATCH v5 06/12] target/riscv: Add support for hpmcounters/hpmevents

On Sat, Feb 19, 2022 at 10:58 AM Atish Patra wrote: > > From: Atish Patra > > With SBI PMU extension, user can use any of the available hpmcounters to > track any perf events based on the value written to mhpmevent csr. > Add read/write functionality for these csrs. > > Reviewed-by: Bin Meng > S

Re: [PATCH v6 5/6] target/riscv: add support for zhinx/zhinxmin

On Fri, Feb 11, 2022 at 2:45 PM Weiwei Li wrote: > > - update extension check REQUIRE_ZHINX_OR_ZFH and > REQUIRE_ZFH_OR_ZFHMIN_OR_ZHINX_OR_ZHINXMIN > - update half float point register read/write > - disable nanbox_h check > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > Revi

Re: [PATCH v6 4/6] target/riscv: add support for zdinx

On Fri, Feb 11, 2022 at 2:45 PM Weiwei Li wrote: > > -- update extension check REQUIRE_ZDINX_OR_D > -- update double float point register read/write > > Co-authored-by: ardxwe > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > Reviewed-by: Richard Henderson Reviewed-by: Alistair

Re: [PATCH v2 06/14] vdpa: adapt vhost_ops callbacks to svq

在 2022/2/27 下午9:41, Eugenio Pérez 写道: First half of the buffers forwarding part, preparing vhost-vdpa callbacks to SVQ to offer it. QEMU cannot enable it at this moment, so this is effectively dead code at the moment, but it helps to reduce patch size. Signed-off-by: Eugenio Pérez --- hw/vi

Re: [PATCH v6 3/6] target/riscv: add support for zfinx

On Fri, Feb 11, 2022 at 2:41 PM Weiwei Li wrote: > > - update extension check REQUIRE_ZFINX_OR_F > - update single float point register read/write > - disable nanbox_s check > > Co-authored-by: ardxwe > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > Reviewed-by: Richard Henders

[PATCH v2 1/2] hw/ssi: Add Ibex SPI device model

From: Wilfred Mallawa Adds the SPI_HOST device model for ibex. The device specification is as per [1]. The model has been tested on opentitan with spi_host unit tests written for TockOS. [1] https://docs.opentitan.org/hw/ip/spi_host/doc/ Signed-off-by: Wilfred Mallawa --- hw/ssi/ibex_spi_host

[PATCH v2 2/2] riscv: opentitan: Connect opentitan SPI Host

From: Wilfred Mallawa Conenct spi host[1/0] to opentitan. Signed-off-by: Wilfred Mallawa --- hw/riscv/opentitan.c | 36 include/hw/riscv/opentitan.h | 12 +++- 2 files changed, 43 insertions(+), 5 deletions(-) diff --git a/hw/riscv/opentita

[PATCH] softmmu/vl: Remove redundant local variable

While there is already a local variable opts in main function scope, no need to define another one with same name in smaller scope. No functional changes. Signed-off-by: Zhenzhong Duan --- softmmu/vl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/softmmu/vl.c b/softmmu

Re: [PATCH v2 04/14] vhost: Add vhost_svq_valid_features to shadow vq

在 2022/2/27 下午9:41, Eugenio Pérez 写道: This allows SVQ to negotiate features with the guest and the device. For the device, SVQ is a driver. While this function bypasses all non-transport features, it needs to disable the features that SVQ does not support when forwarding buffers. This includes

Re: [PATCH v6 11/14] target/riscv: rvk: add support for zksed/zksh extension

在 2022/2/28 上午3:41, Richard Henderson 写道: On 2/27/22 04:25, Weiwei Li wrote:   - add sm3p0, sm3p1, sm4ed and sm4ks instructions Co-authored-by: Ruibo Lu Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang ---   target/riscv/crypto_helper.c    | 49 +   target/riscv

Re: [PATCH v2 03/14] vhost: Add Shadow VirtQueue call forwarding capabilities

在 2022/2/27 下午9:41, Eugenio Pérez 写道: This will make qemu aware of the device used buffers, allowing it to write the guest memory with its contents if needed. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.h | 4 hw/virtio/vhost-shadow-virtqueue.c | 34

Re: [PATCH v6 09/14] target/riscv: rvk: add support for sha512 related instructions for RV32 in zknh extension

在 2022/2/28 上午3:36, Richard Henderson 写道: On 2/27/22 04:25, Weiwei Li wrote:   - add sha512sum0r, sha512sig0l, sha512sum1r, sha512sig1l, sha512sig0h and sha512sig1h instructions Co-authored-by: Zewen Ye Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang ---   target/riscv/crypto_helper

Re: [PATCH v6 08/14] target/riscv: rvk: add support for sha256 related instructions in zknh extension

在 2022/2/28 上午3:21, Richard Henderson 写道: On 2/27/22 04:25, Weiwei Li wrote:   - add sha256sig0, sha256sig1, sha256sum0 and sha256sum1 instructions Co-authored-by: Zewen Ye Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang ---   target/riscv/crypto_helper.c    | 31

Re: [PATCH v6 07/14] target/riscv: rvk: add support for zkne/zknd extension in RV64

在 2022/2/28 上午3:13, Richard Henderson 写道: On 2/27/22 04:25, Weiwei Li wrote:   - add aes64dsm, aes64ds, aes64im, aes64es, aes64esm, aes64ks2, aes64ks1i instructions Co-authored-by: Ruibo Lu Co-authored-by: Zewen Ye Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang ---   target/riscv/

Re: [PATCH v6 06/14] target/riscv: rvk: add support for zknd/zkne extension in RV32

在 2022/2/28 上午3:05, Richard Henderson 写道: On 2/27/22 04:25, Weiwei Li wrote: +#define AES_SHIFROWS_LO(RS1, RS2) ( \ +    (((RS1 >> 24) & 0xFF) << 56) | (((RS2 >> 48) & 0xFF) << 48) | \ +    (((RS2 >> 8) & 0xFF) << 40) | (((RS1 >> 32) & 0xFF) << 32) | \ +    (((RS2 >> 56) & 0xFF) << 24) | (((RS

Re: [PATCH v6 02/14] target/riscv: rvk: add support for zbkb extension

Thanks for your comments. 在 2022/2/28 上午2:47, Richard Henderson 写道: On 2/27/22 04:25, Weiwei Li wrote: +static void gen_packh(TCGv ret, TCGv src1, TCGv src2) +{ +    TCGv t = tcg_temp_new(); + +    tcg_gen_ext8u_tl(t, src2); +    tcg_gen_deposit_tl(ret, src1, t, 8, TARGET_LONG_BITS - 8); +    t

Re: [PATCH v2 02/14] vhost: Add Shadow VirtQueue kick forwarding capabilities

在 2022/2/27 下午9:40, Eugenio Pérez 写道: At this mode no buffer forwarding will be performed in SVQ mode: Qemu will just forward the guest's kicks to the device. Host memory notifiers regions are left out for simplicity, and they will not be addressed in this series. Signed-off-by: Eugenio Pérez

Re: [PATCH v2 00/14] vDPA shadow virtqueue

On Sun, Feb 27, 2022 at 9:42 PM Eugenio Pérez wrote: > > This series enable shadow virtqueue (SVQ) for vhost-vdpa devices. This > is intended as a new method of tracking the memory the devices touch > during a migration process: Instead of relay on vhost device's dirty > logging capability, SVQ in

Re: [RFC PATCH 3/4] hw/ppc: Take nested guest into account when saving timebase

On Fri, Feb 25, 2022 at 01:08:46PM -0300, Fabiano Rosas wrote: > David Gibson writes: > > > On Thu, Feb 24, 2022 at 03:58:16PM -0300, Fabiano Rosas wrote: > >> When saving the guest "timebase" we look to the first_cpu for its > >> tb_offset. If that CPU happens to be running a nested guest at thi

Re: [PATCH v2 2/3] spapr: Add SPAPR_CAP_AIL_MODE_3 for AIL mode 3 support for H_SET_MODE hcall

On Wed, Feb 23, 2022 at 05:42:06PM +1000, Nicholas Piggin wrote: > Excerpts from David Gibson's message of February 17, 2022 10:17 am: > > On Wed, Feb 16, 2022 at 04:39:02PM +1000, Nicholas Piggin wrote: > >> The behaviour of the Address Translation Mode on Interrupt resource is > >> not consistent

Re: [RFC PATCH 1/4] target/ppc: TCG: Migrate tb_offset and decr

On Fri, Feb 25, 2022 at 01:08:10PM -0300, Fabiano Rosas wrote: > David Gibson writes: > > > On Thu, Feb 24, 2022 at 03:58:14PM -0300, Fabiano Rosas wrote: > >> These two were not migrated so the remote end was starting with the > >> decrementer expired. > >> > >> I am seeing less frequent crashe

[PATCH v3 4/4] net: Use bundle mechanism

Signed-off-by: Akihiko Odaki --- configure | 1 + include/net/net.h | 2 +- meson.build | 1 + net/tap.c | 6 +- qemu-options.hx | 4 ++-- 5 files changed, 10 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 80d36a85bc5..63df8f5886e 100755 --- a/

Re: [PATCH] ui/cocoa: Use the standard about panel

Please ignore this. I mistakenly sent a stale patch in my outbox directory. Sorry for bothering, Akihiko Odaki On 2022/02/28 9:57, Akihiko Odaki wrote: This provides standard look and feel for the about panel and reduces code. Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 112 +++---

[PATCH] ui/cocoa: Use the standard about panel

This provides standard look and feel for the about panel and reduces code. Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 112 +++-- 1 file changed, 23 insertions(+), 89 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index a8f1cdaf926..59672fee7

[PATCH v3 3/4] ui/icons: Use bundle mechanism

Signed-off-by: Akihiko Odaki --- configure | 10 ++ meson.build | 3 +-- ui/cocoa.m | 20 +++- ui/gtk.c| 8 +--- ui/sdl2.c | 18 +++--- 5 files changed, 38 insertions(+), 21 deletions(-) diff --git a/configure b/configure index fda1a35cbc0..80d3

[PATCH v3 2/4] datadir: Use bundle mechanism

softmmu/datadir.c had its own implementation to find files in the build tree, but now bundle mechanism provides the unified implementation which works for datadir and the other files. Signed-off-by: Akihiko Odaki --- configure | 2 ++ meson.build | 2 +- softmmu/datadir.c | 35 ++

[PATCH v3 1/4] cutils: Introduce bundle mechanism

Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. It is a general mechanism and can find any files located relative to the installation tree. The build tree must have a new directory, qemu-bu

[PATCH v3 0/4] cutils: Introduce bundle mechanism

Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. It is a general mechanism and can find any files located relative to the installation tree. The build tree must have a new directory, qemu-bu

Re: [PATCH v4] ui/cocoa: Use NSWindow's ability to resize

On 2022/02/27 23:56, Peter Maydell wrote: On Sat, 26 Feb 2022 at 10:41, Akihiko Odaki wrote: This change brings two new features: - The window will be resizable if "Zoom To Fit" is eanbled - The window can be made full screen by clicking full screen button provided by the platform. (The lef

Re: [PATCH] qapi: Belatedly adjust limitations documentation

On 25/2/22 09:45, Markus Armbruster wrote: Commit 57df0dff1a "qapi: Extend -compat to set policy for unstable interfaces" (v6.2.0) took care of covering experimental features, but neglected to adjust a comment suggesting to cover it. Adjust it now. Fixes: 57df0dff1a1f4c846aa74a082bfd595a8a99001

Re: [PATCH] tcg/tci: Use tcg_out_ldst in tcg_out_st

On 26/2/22 02:55, Richard Henderson wrote: The tcg_out_ldst helper will handle out-of-range offsets. We haven't actually encountered any, since we haven't run across the assert within tcg_out_op_rrs, but an out-of-range offset would not be impossible in future. Fixes: 65089889183 ("tcg/tci: Chan

Re: [PATCH v2 9/9] tcg/loongarch64: Support TCG_TARGET_SIGNED_ADDR32

On 27/2/22 03:04, Richard Henderson wrote: All 32-bit LoongArch operations sign-extend the output, so we are easily able to keep TCG_TYPE_I32 values sign-extended in host registers. Cc: WANG Xuerui Signed-off-by: Richard Henderson --- tcg/loongarch64/tcg-target-sa32.h | 2 +- tcg/loongarch

Re: [PATCH v2 7/9] tcg/mips: Support TCG_TARGET_SIGNED_ADDR32

On 27/2/22 03:04, Richard Henderson wrote: All 32-bit mips operations sign-extend the output, so we are easily able to keep TCG_TYPE_I32 values sign-extended in host registers. Cc: Philippe Mathieu-Daudé Cc: Aurelien Jarno Cc: Huacai Chen Cc: Jiaxun Yang Cc: Aleksandar Rikalo Signed-off-by:

Re: [PATCH v2 5/9] linux-user: Support TCG_TARGET_SIGNED_ADDR32

On 27/2/22 03:04, Richard Henderson wrote: When using reserved_va, which is the default for a 64-bit host and a 32-bit guest, set guest_base_signed_addr32 if requested by TCG_TARGET_SIGNED_ADDR32, and the executable layout allows. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson ---

Re: [PATCH v2 00/22] isa: Resolve unneeded IRQ attributes from ISADevice

On 22/2/22 20:34, Bernhard Beschow wrote: v2: The newly QOM'ified devices now report an error to the user in their realize functions if the configured IRQ number is greater than 15. v1: The IRQ attributes of ISADevice are hardcoded to support up to two IRQs per device which creates an artificial

Re: [PATCH v2 04/22] hw/isa/isa-bus: Remove isabus_dev_print()

On 22/2/22 20:34, Bernhard Beschow wrote: All isabus_dev_print() did was to print up to two IRQ numbers per device. This is redundant if the IRQ numbers are present as QOM properties (see e.g. the modified tests/qemu-iotests/172.out). Now that the last devices relying on isabus_dev_print() had t

[PATCH v9 10/11] 9p: darwin: Adjust assumption on virtio-9p-test

The previous test depended on the assumption that P9_DOTL_AT_REMOVEDIR and AT_REMOVEDIR have the same value. While this is true on Linux, it is not true everywhere, and leads to an incorrect test failure on unlink_at, noticed when adding 9p to darwin: Received response 7 (RLERROR) instead of 77 (

[PATCH v9 09/11] 9p: darwin: Implement compatibility for mknodat

From: Keno Fischer Darwin does not support mknodat. However, to avoid race conditions with later setting the permissions, we must avoid using mknod on the full path instead. We could try to fchdir, but that would cause problems if multiple threads try to call mknodat at the same time. However, lu

[PATCH v9 07/11] 9p: darwin: *xattr_nofollow implementations

From: Keno Fischer This implements the darwin equivalent of the functions that were moved to 9p-util(-linux) earlier in this series in the new 9p-util-darwin file. Signed-off-by: Keno Fischer [Michael Roitzsch: - Rebase for NixOS] Signed-off-by: Michael Roitzsch Signed-off-by: Will Cohen ---

[PATCH v9 11/11] 9p: darwin: meson: Allow VirtFS on Darwin

From: Keno Fischer To allow VirtFS on darwin, we need to check that pthread_fchdir_np is available, which has only been available since macOS 10.12. Additionally, virtfs_proxy_helper is disabled on Darwin. This patch series does not currently provide an implementation of the proxy-helper, but th

[PATCH v9 06/11] 9p: darwin: Move XATTR_SIZE_MAX->P9_XATTR_SIZE_MAX

From: Keno Fischer Signed-off-by: Keno Fischer Signed-off-by: Michael Roitzsch Because XATTR_SIZE_MAX is not defined on Darwin, create a cross-platform P9_XATTR_SIZE_MAX instead. [Will Cohen: - Adjust coding style - Lower XATTR_SIZE_MAX to 64k - Add explanatory conte

[PATCH v9 02/11] 9p: Rename 9p-util -> 9p-util-linux

From: Keno Fischer The current file only has the Linux versions of these functions. Rename the file accordingly and update the Makefile to only build it on Linux. A Darwin version of these will follow later in the series. Signed-off-by: Keno Fischer [Michael Roitzsch: - Rebase for NixOS] Signed

[PATCH v9 05/11] 9p: darwin: Ignore O_{NOATIME, DIRECT}

From: Keno Fischer Darwin doesn't have either of these flags. Darwin does have F_NOCACHE, which is similar to O_DIRECT, but has different enough semantics that other projects don't generally map them automatically. In any case, we don't support O_DIRECT on Linux at the moment either. Signed-off-

[PATCH v9 04/11] 9p: darwin: Handle struct dirent differences

From: Keno Fischer On darwin d_seekoff exists, but is optional and does not seem to be commonly used by file systems. Use `telldir` instead to obtain the seek offset and inject it into d_seekoff, and create a qemu_dirent_off helper to call it appropriately when appropriate. Signed-off-by: Keno F

[PATCH v9 08/11] 9p: darwin: Compatibility for f/l*xattr

From: Keno Fischer On darwin `fgetxattr` takes two extra optional arguments, and the l* variants are not defined (in favor of an extra flag to the regular variants. Signed-off-by: Keno Fischer [Michael Roitzsch: - Rebase for NixOS] Signed-off-by: Michael Roitzsch Signed-off-by: Will Cohen ---

[PATCH v9 03/11] 9p: darwin: Handle struct stat(fs) differences

From: Keno Fischer Signed-off-by: Keno Fischer Signed-off-by: Michael Roitzsch [Will Cohen: - Note lack of f_namelen and f_frsize on Darwin - Ensure that tv_sec and tv_nsec are both initialized for Darwin and non-Darwin] Signed-off-by: Will Cohen --- hw/9pfs/9p-pro

[PATCH v9 01/11] 9p: linux: Fix a couple Linux assumptions

From: Keno Fischer - Guard Linux only headers. - Add qemu/statfs.h header to abstract over the which headers are needed for struct statfs - Define `ENOATTR` only if not only defined (it's defined in system headers on Darwin). Signed-off-by: Keno Fischer [Michael Roitzsch: - Rebase for

[PATCH v9 00/11] 9p: Add support for darwin

This is a followup to https://lists.gnu.org/archive/html/qemu-devel/2022-02/msg04391.html, adding 9p server support for Darwin. Since v8, the following changes have been made: Patch 4/11 (9p: darwin: Handle struct dirent differences) - Declare qemu_dirent_off as static to prevent linker error -

Re: [PATCH v2 3/9] accel/tcg: Support TCG_TARGET_SIGNED_ADDR32 for softmmu

On 27/2/22 03:04, Richard Henderson wrote: When TCG_TARGET_SIGNED_ADDR32 is set, adjust the tlb addend to allow the 32-bit guest address to be sign extended within the 64-bit host register instead of zero extended. This will simplify tcg hosts like MIPS, RISC-V, and LoongArch, which naturally si

Re: [PATCH v2 22/22] isa: Remove unused isa_init_irq()

On 22/2/22 20:34, Bernhard Beschow wrote: isa_init_irq() had become a trivial one-line wrapper for isa_get_irq(). The previous commits resolved all usages in favor of isa_get_irq(). isa_init_irq() can therefore be removed. Signed-off-by: Bernhard Beschow --- hw/isa/isa-bus.c | 5 - i

Re: [PATCH v2 06/22] isa: Drop unused attributes from ISADevice

On 22/2/22 20:34, Bernhard Beschow wrote: Now that the last users of ISADevice::isairq[] have been resolved during the previous commits, it can be removed for good. Signed-off-by: Bernhard Beschow --- hw/isa/isa-bus.c | 13 - include/hw/isa/isa.h | 2 -- 2 files changed, 15

Re: [PATCH v2 05/22] hw/ppc/pnv: Determine ns16550's IRQ number from QOM property

On 22/2/22 20:34, Bernhard Beschow wrote: Determine the IRQ number in the same way as for isa-ipmi-bt. This resolves the last usage of ISADevice::isairq[] which allows it to be removed. Signed-off-by: Bernhard Beschow --- hw/ppc/pnv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [PATCH v2 03/22] hw/input/pckbd: QOM'ify IRQ numbers

On 22/2/22 20:34, Bernhard Beschow wrote: Exposing the IRQ numbers as a QOM properties not only allows them to be configurable but also to be printed by standard QOM mechanisms. This allows isabus_dev_print() to be retired eventually. Signed-off-by: Bernhard Beschow --- hw/input/pckbd.c | 26

Re: [PATCH v2 02/22] hw/rtc/m48t59-isa: QOM'ify IRQ number

On 22/2/22 20:34, Bernhard Beschow wrote: Exposing the IRQ number as a QOM property not only allows it to be configurable but also to be printed by standard QOM mechanisms. This allows isabus_dev_print() to be retired eventually. Signed-off-by: Bernhard Beschow --- hw/rtc/m48t59-isa.c | 9 +++

Re: [PATCH v2 01/22] hw/rtc/mc146818rtc: QOM'ify IRQ number

On 22/2/22 20:34, Bernhard Beschow wrote: Exposing the IRQ number as a QOM property not only allows it to be configurable but also to be printed by standard QOM mechanisms. This allows isabus_dev_print() to be retired eventually. Signed-off-by: Bernhard Beschow --- hw/isa/piix4.c

Re: [PATCH 6/7] target/nios2: Special case ipending in rdctl and wrctl

On 27/2/22 19:21, Richard Henderson wrote: It was never correct to be able to write to ipending. Until the rest of the irq code is tidied, the read of ipending will generate an "unnecessary" mask. Signed-off-by: Richard Henderson --- target/nios2/translate.c | 12 1 file changed

Re: [PATCH 7/7] target/nios2: Rewrite interrupt handling

On 27/2/22 19:21, Richard Henderson wrote: Drop irq_pending boolean. Drop helper_check_interrupts. Move checks for irq disabled into nios2_cpu_exec_interrupt. End the TB on writes to ienable, just like to status. Signed-off-by: Richard Henderson --- target/nios2/cpu.h | 1 - target/ni

Re: [PATCH 4/7] target/nios2: Hoist R_ZERO check in rdctl

On 27/2/22 19:21, Richard Henderson wrote: This will avoid having to replicate the check to additional cases. Signed-off-by: Richard Henderson --- target/nios2/translate.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 3/7] target/nios2: Only build mmu.c for system mode

On 27/2/22 19:21, Richard Henderson wrote: We can thus remove an ifdef covering the entire file. Signed-off-by: Richard Henderson --- target/nios2/mmu.c | 3 --- target/nios2/meson.build | 3 +-- 2 files changed, 1 insertion(+), 5 deletions(-) \o/ Reviewed-by: Philippe Mathieu-Daud

Re: [PATCH 2/7] target/nios2: Replace MMU_LOG with tracepoints

On 27/2/22 19:21, Richard Henderson wrote: Signed-off-by: Richard Henderson --- meson.build | 1 + target/nios2/mmu.c| 96 --- target/nios2/trace-events | 10 3 files changed, 39 insertions(+), 68 deletions(-) create mode 100

Re: [PATCH v3 3/4] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

Am 27. Februar 2022 18:58:18 UTC schrieb Liav Albani : > >On 2/27/22 12:48, Bernhard Beschow wrote: >> Am 26. Februar 2022 06:30:18 UTC schrieb Liav Albani : >>> This can allow the guest OS to determine more easily if i8042 controller >>> is present in the system or not, so it doesn't need to do pr

[PATCH] pc: add option to disable PS/2 mouse/keyboard

On some older software like Windows 7 installer, having both a PS/2 mouse and USB mouse results in only one device working property (which might be a different device each boot). While the workaround to not use a USB mouse with such software is valid, it creates an inconsistent experience if the us

Re: [PATCH v6 11/14] target/riscv: rvk: add support for zksed/zksh extension

On 2/27/22 04:25, Weiwei Li wrote: - add sm3p0, sm3p1, sm4ed and sm4ks instructions Co-authored-by: Ruibo Lu Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/crypto_helper.c| 49 + target/riscv/helper.h | 6 +++ target

Re: [PATCH v6 10/14] target/riscv: rvk: add support for sha512 related instructions for RV64 in zknh extension

On 2/27/22 04:25, Weiwei Li wrote: - add sha512sum0, sha512sig0, sha512sum1 and sha512sig1 instructions Co-authored-by: Zewen Ye Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/crypto_helper.c| 31 ++ target/riscv/helper.h

Re: [PATCH v6 09/14] target/riscv: rvk: add support for sha512 related instructions for RV32 in zknh extension

On 2/27/22 04:25, Weiwei Li wrote: - add sha512sum0r, sha512sig0l, sha512sum1r, sha512sig1l, sha512sig0h and sha512sig1h instructions Co-authored-by: Zewen Ye Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/crypto_helper.c| 57 target/

Re: [PATCH v6 08/14] target/riscv: rvk: add support for sha256 related instructions in zknh extension

On 2/27/22 04:25, Weiwei Li wrote: - add sha256sig0, sha256sig1, sha256sum0 and sha256sum1 instructions Co-authored-by: Zewen Ye Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/crypto_helper.c| 31 + target/riscv/helper.h |

Re: [PATCH v6 07/14] target/riscv: rvk: add support for zkne/zknd extension in RV64

On 2/27/22 04:25, Weiwei Li wrote: - add aes64dsm, aes64ds, aes64im, aes64es, aes64esm, aes64ks2, aes64ks1i instructions Co-authored-by: Ruibo Lu Co-authored-by: Zewen Ye Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/crypto_helper.c| 136

Re: [PATCH v6 06/14] target/riscv: rvk: add support for zknd/zkne extension in RV32

On 2/27/22 04:25, Weiwei Li wrote: +#define AES_SHIFROWS_LO(RS1, RS2) ( \ +(((RS1 >> 24) & 0xFF) << 56) | (((RS2 >> 48) & 0xFF) << 48) | \ +(((RS2 >> 8) & 0xFF) << 40) | (((RS1 >> 32) & 0xFF) << 32) | \ +(((RS2 >> 56) & 0xFF) << 24) | (((RS2 >> 16) & 0xFF) << 16) | \ +(((RS1 >> 40

Re: [PATCH v3 1/4] hw/isa: add function to check for existence of device by its type

On 2/27/22 09:27, Ani Sinha wrote: On Sat, 26 Feb 2022, Liav Albani wrote: This function enumerates all attached ISA devices in the machine, and tries to compare a given device type name to the enumerated devices. For example, this can help other code to determine if a i8042 controller exist

Re: [PATCH v3 3/4] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

On 2/27/22 08:56, Ani Sinha wrote: On Sat, 26 Feb 2022, Liav Albani wrote: This can allow the guest OS to determine more easily if i8042 controller is present in the system or not, so it doesn't need to do probing of the controller, but just initialize it immediately, before enumerating the

Re: [PATCH v3 3/4] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

On 2/27/22 12:48, Bernhard Beschow wrote: Am 26. Februar 2022 06:30:18 UTC schrieb Liav Albani : This can allow the guest OS to determine more easily if i8042 controller is present in the system or not, so it doesn't need to do probing of the controller, but just initialize it immediately, bef

Re: [PATCH v6 05/14] crypto: move sm4_sbox from target/arm

On 2/27/22 04:25, Weiwei Li wrote: - share it between target/arm and target/riscv Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- crypto/meson.build | 1 + crypto/sm4.c | 49

Re: [PATCH 2/9] Avocado tests: use logging namespace that is preserved in test logs

On 25/2/22 22:01, Cleber Rosa wrote: Since Avocado 92.0[1], there's no universal preservation of logged content via Python's "logging" APIs into the test log files. This changes were motivated by the fact that doing so is intrusive as it touches on Python's root logger. Test writers are now exp

  1   2   >