Re: [qemu-web PATCH] Fix link to Windows page in Wiki

2021-09-10 Thread Helge Konetzka
Am 10.09.21 um 17:44 schrieb Paolo Bonzini: On 25/08/21 18:43, Helge Konetzka wrote: Furthermore I would like to propose to change the instructions for Native builds with MSYS2 on Wiki Windows page. Please remove the section which copies system binaries to match the expected file names! Ins

Re: [PATCH v4 17/21] LoongArch Linux User Emulation

2021-09-10 Thread Song Gao
Hi, Richard. On 09/10/2021 08:52 PM, Richard Henderson wrote: > On 9/8/21 11:50 AM, Song Gao wrote: >> >> Hi Richard, >> >> On 09/05/2021 06:04 PM, Richard Henderson wrote: +struct sigframe { +    uint32_t sf_ass[4]; /* argument save space for o32 */ >>> >>> Surely there is n

Re: [PATCH v5 1/4] spapr: move NUMA associativity init to machine reset

2021-09-10 Thread David Gibson
On Fri, Sep 10, 2021 at 04:57:14PM -0300, Daniel Henrique Barboza wrote: 65;6402;1c> > > On 9/7/21 6:23 AM, David Gibson wrote: > > On Tue, Sep 07, 2021 at 09:10:13AM +0200, Greg Kurz wrote: > > > On Tue, 7 Sep 2021 10:37:27 +1000 > > > David Gibson wrote: > > > > > > > On Mon, Sep 06, 2021 at

Re: [PATCH] hw/i386/acpi-build: Fix a typo

2021-09-10 Thread Ani Sinha
On Sat, Sep 11, 2021 at 1:03 AM Philippe Mathieu-Daudé wrote: > On 9/10/21 8:54 PM, Volker Rümelin wrote: > >> Fix 'hotplugabble' -> 'hotpluggabble' typo. > > > > I'm convinced that the correct spelling is hotpluggable. Only the > > consonant g is doubled. > > Lol I missed this part, thanks :>

Re: [RFC 00/10] hw/mos6522: VIA timer emulation fixes and improvements

2021-09-10 Thread Finn Thain
On Fri, 10 Sep 2021, Mark Cave-Ayland wrote: > On 01/09/2021 09:06, Mark Cave-Ayland wrote: > > > I'll have a go at some basic timer measurements using your patch to > > see what sort of numbers I get for the latency here. Obviously QEMU > > doesn't guarantee response times but over 20ms does s

Re: [PATCH 1/2] vfio/pci: Fix vfio-pci sub-page MMIO BAR mmaping in live migration

2021-09-10 Thread Alex Williamson
On Fri, 10 Sep 2021 16:33:12 +0800 Kunkun Jiang wrote: > Hi Alex, > > On 2021/9/9 4:45, Alex Williamson wrote: > > On Fri, 3 Sep 2021 17:36:10 +0800 > > Kunkun Jiang wrote: > > > >> We expand MemoryRegions of vfio-pci sub-page MMIO BARs to > >> vfio_pci_write_config to improve IO performance.

Re: [PULL 00/42] bsd-user updates to run hello world

2021-09-10 Thread Philippe Mathieu-Daudé
re available in the Git repository at: > > https://gitlab.com/bsdimp/qemu.git tags/pull-bsd-user-20210910 Well done, chapeau! > for you to fetch changes up to be04f210f954bed8663943a94ece50c2ca410231: > > bsd-user: Update mapping to handle reserved and

Re: simple serial device emulation

2021-09-10 Thread Philippe Mathieu-Daudé
On 9/10/21 9:35 PM, Hinko Kocevar wrote: > I have an emulated MMIO area holding couple of registers that deal with > serial UART. Very simple access to the Tx and Rx registers from the > userspace point of view involves polling for a bit in one register and > then writing another; when there is roo

Re: [PATCH v4 22/33] hostmem-epc: Add the reset interface for EPC backend reset

2021-09-10 Thread Paolo Bonzini
Il ven 10 set 2021, 22:21 Sean Christopherson ha scritto: > > It's also possible that QEMU handles failure, but the kernel does two > > passes; then QEMU can just do two passes. The kernel will overall do > four > > passes, but: > > > > 1) the second (SECS pinned by children in the same vEPC) wo

Re: [PULL 00/42] bsd-user updates to run hello world

2021-09-10 Thread Warner Losh
On Thu, Sep 9, 2021 at 10:31 AM Philippe Mathieu-Daudé wrote: > On 9/9/21 5:12 PM, Warner Losh wrote: > > > > > > On Thu, Sep 9, 2021, 9:01 AM Peter Maydell > > wrote: > > > > On Tue, 7 Sept 2021 at 22:56, > > wrote: > > > > >

Re: [PULL 00/42] bsd-user updates to run hello world

2021-09-10 Thread Warner Losh
On Thu, Sep 9, 2021 at 10:29 AM Philippe Mathieu-Daudé wrote: > On 9/7/21 11:52 PM, i...@bsdimp.com wrote: > > From: Warner Losh > > > > The following changes since commit > f214d8e0150766c31172e16ef4b17674f549d852: > > > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-

[PULL 00/42] bsd-user updates to run hello world

2021-09-10 Thread imp
s/pull-bsd-user-20210910 for you to fetch changes up to be04f210f954bed8663943a94ece50c2ca410231: bsd-user: Update mapping to handle reserved and starting conditions (2021-09-10 14:13:06 -0600) This series of patches gets me to the

[PULL 07/42] bsd-user: move arch specific defines out of elfload.c

2021-09-10 Thread imp
From: Warner Losh Move the architecture specific defines to target_arch_elf.h and delete them from elfload.c. Only retain ifdefs appropriate for i386 and x86_64. Add the copyright/license comments, and guard ifdefs. Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/elfloa

Re: [PATCH v4 22/33] hostmem-epc: Add the reset interface for EPC backend reset

2021-09-10 Thread Sean Christopherson
On Fri, Sep 10, 2021, Paolo Bonzini wrote: > On 10/09/21 19:34, Sean Christopherson wrote: > > On Fri, Sep 10, 2021, Paolo Bonzini wrote: > > > On 10/09/21 17:34, Sean Christopherson wrote: > > > > The only other option that comes to mind is a dedicated ioctl(). > > > > > > If it is not too restri

Re: [PATCH v5 1/4] spapr: move NUMA associativity init to machine reset

2021-09-10 Thread Daniel Henrique Barboza
On 9/7/21 6:23 AM, David Gibson wrote: On Tue, Sep 07, 2021 at 09:10:13AM +0200, Greg Kurz wrote: On Tue, 7 Sep 2021 10:37:27 +1000 David Gibson wrote: On Mon, Sep 06, 2021 at 09:25:24PM -0300, Daniel Henrique Barboza wrote: At this moment we only support one form of NUMA affinity, FORM1.

[PATCH v6 6/6] spapr_numa.c: FORM2 NUMA affinity support

2021-09-10 Thread Daniel Henrique Barboza
The main feature of FORM2 affinity support is the separation of NUMA distances from ibm,associativity information. This allows for a more flexible and straightforward NUMA distance assignment without relying on complex associations between several levels of NUMA via ibm,associativity matches. Anoth

[PATCH v6 3/6] spapr: introduce spapr_numa_associativity_reset()

2021-09-10 Thread Daniel Henrique Barboza
Introducing a new NUMA affinity, FORM2, requires a new mechanism to switch between affinity modes after CAS. Also, we want FORM2 data structures and functions to be completely separated from the existing FORM1 code, allowing us to avoid adding new code that inherits the existing complexity of FORM1

[PATCH v6 5/6] spapr: move FORM1 verifications to post CAS

2021-09-10 Thread Daniel Henrique Barboza
FORM2 NUMA affinity is prepared to deal with empty (memory/cpu less) NUMA nodes. This is used by the DAX KMEM driver to locate a PAPR SCM device that has a different latency than the original NUMA node from the regular memory. FORM2 is also enable to deal with asymmetric NUMA distances gracefully,

[PATCH v6 4/6] spapr_numa.c: parametrize FORM1 macros

2021-09-10 Thread Daniel Henrique Barboza
The next preliminary step to introduce NUMA FORM2 affinity is to make the existing code independent of FORM1 macros and values, i.e. MAX_DISTANCE_REF_POINTS, NUMA_ASSOC_SIZE and VCPU_ASSOC_SIZE. This patch accomplishes that by doing the following: - move the NUMA related macros from spapr.h to spa

[PATCH v6 2/6] spapr_numa.c: scrap 'legacy_numa' concept

2021-09-10 Thread Daniel Henrique Barboza
When first introduced, 'legacy_numa' was a way to refer to guests that either wouldn't be affected by associativity domain calculations, namely the ones with only 1 NUMA node, and pre 5.2 guests that shouldn't be affected by it because it would be an userspace change. Calling these cases 'legacy_nu

[PATCH v6 1/6] spapr_numa.c: split FORM1 code into helpers

2021-09-10 Thread Daniel Henrique Barboza
The upcoming FORM2 NUMA affinity will support asymmetric NUMA topologies and doesn't need be concerned with all the legacy support for older pseries FORM1 guests. We're also not going to calculate associativity domains based on numa distance (via spapr_numa_define_associativity_domains) since the

[PATCH v6 0/6] pSeries FORM2 affinity support

2021-09-10 Thread Daniel Henrique Barboza
Hi, In this version there was significant design changes after the v5 review. Only patches 1 and 5 were present in the last version. changes from v5: - patch order was changed to make all the preliminary work without adding FORM2 code; - FORM1 and FORM2 data now co-exists. Both are being initiali

Re: [PATCH v4 22/33] hostmem-epc: Add the reset interface for EPC backend reset

2021-09-10 Thread Paolo Bonzini
On 10/09/21 19:34, Sean Christopherson wrote: On Fri, Sep 10, 2021, Paolo Bonzini wrote: On 10/09/21 17:34, Sean Christopherson wrote: The only other option that comes to mind is a dedicated ioctl(). If it is not too restrictive to do it for the whole mapping at once, that would be fine. Oo

simple serial device emulation

2021-09-10 Thread Hinko Kocevar
I have an emulated MMIO area holding couple of registers that deal with serial UART. Very simple access to the Tx and Rx registers from the userspace point of view involves polling for a bit in one register and then writing another; when there is room for another character. When the guest app does

Re: [PATCH] hw/i386/acpi-build: Fix a typo

2021-09-10 Thread Philippe Mathieu-Daudé
On 9/10/21 8:54 PM, Volker Rümelin wrote: >> Fix 'hotplugabble' -> 'hotpluggabble' typo. > > I'm convinced that the correct spelling is hotpluggable. Only the > consonant g is doubled. Lol I missed this part, thanks :>

Re: Adding IO memory region to mipssim

2021-09-10 Thread Hinko Kocevar
Got it Phil, thank you very much! I need to educate myself on the subject of TLB and MMU for mips. //hinko On Fri, Sep 10, 2021 at 5:30 PM Philippe Mathieu-Daudé wrote: > On 9/10/21 3:21 PM, Hinko Kocevar wrote: > > I'm trying to add an I/O memory region to mipssim machine to emulate a > > MMIO

Re: Implementing isochronous transfers in hw/hcd-ohci.c

2021-09-10 Thread Programmingkid
> On Sep 10, 2021, at 7:51 AM, BALATON Zoltan wrote: > > On Fri, 10 Sep 2021, Howard Spoelstra wrote: >> On Fri, Sep 10, 2021 at 7:07 AM Gerd Hoffmann wrote: >> >>> On Thu, Sep 09, 2021 at 05:06:17PM -0400, Programmingkid wrote: Hi Gerd, Howard and I were talking about USB au

Re: [PATCH v2 0/3] The HMP/QMP interfaces in Qemu SGX

2021-09-10 Thread Paolo Bonzini
Il ven 10 set 2021, 16:22 Daniel P. Berrangé ha scritto: > > Queued 1-2, thanks. > > I had just posted a bunch of comments on patch 1 ... > Sorry, I had already queued it a few hours earlier and just noticed I hadn't sent out the message. I have some updates to the main series too, so I might j

Re: [PATCH] hw/i386/acpi-build: Fix a typo

2021-09-10 Thread Volker Rümelin
Fix 'hotplugabble' -> 'hotpluggabble' typo. I'm convinced that the correct spelling is hotpluggable. Only the consonant g is doubled. With best regards Volker Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/acpi-build.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH v4 22/33] hostmem-epc: Add the reset interface for EPC backend reset

2021-09-10 Thread Sean Christopherson
On Fri, Sep 10, 2021, Paolo Bonzini wrote: > On 10/09/21 17:34, Sean Christopherson wrote: > > > Yang explained to me (offlist) that this is needed because Windows fails > > > to > > > reboot without it. We would need a way to ask Linux to reinitialize the > > > vEPC, that doesn't involve munmap/

Re: [RFC 00/10] hw/mos6522: VIA timer emulation fixes and improvements

2021-09-10 Thread Mark Cave-Ayland
On 01/09/2021 09:06, Mark Cave-Ayland wrote: I'll have a go at some basic timer measurements using your patch to see what sort of numbers I get for the latency here. Obviously QEMU doesn't guarantee response times but over 20ms does seem high. I was able to spend some time today looking at th

Re: [PATCH v2 1/2] elf2dmp: Check curl_easy_setopt() return value

2021-09-10 Thread Viktor Prutyanov
Hi, On Fri, 10 Sep 2021 19:06:55 +0200 Philippe Mathieu-Daudé wrote: > From: Peter Maydell > > Coverity points out that we aren't checking the return value > from curl_easy_setopt(). > > Fixes: Coverity CID 1458895 > Inspired-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH v2 2/2] elf2dmp: Fail cleanly if PDB file specifies zero block_size

2021-09-10 Thread Viktor Prutyanov
Hi, On Fri, 10 Sep 2021 19:06:56 +0200 Philippe Mathieu-Daudé wrote: > From: Peter Maydell > > Coverity points out that if the PDB file we're trying to read > has a header specifying a block_size of zero then we will > end up trying to divide by zero in pdb_ds_read_file(). > Check for this and

Re: [PATCH v4 22/33] hostmem-epc: Add the reset interface for EPC backend reset

2021-09-10 Thread Paolo Bonzini
On 10/09/21 17:34, Sean Christopherson wrote: Yang explained to me (offlist) that this is needed because Windows fails to reboot without it. We would need a way to ask Linux to reinitialize the vEPC, that doesn't involve munmap/mmap; this could be for example fallocate(FALLOC_FL_ZERO_RANGE). Wh

Re: [PATCH RFC server v2 01/11] vfio-user: build library

2021-09-10 Thread Jag Raman
> On Sep 10, 2021, at 11:20 AM, Philippe Mathieu-Daudé > wrote: > > On 8/27/21 7:53 PM, Jagannathan Raman wrote: >> add the libvfio-user library as a submodule. build it as a cmake >> subproject. >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jaganna

[PATCH v2 2/2] elf2dmp: Fail cleanly if PDB file specifies zero block_size

2021-09-10 Thread Philippe Mathieu-Daudé
From: Peter Maydell Coverity points out that if the PDB file we're trying to read has a header specifying a block_size of zero then we will end up trying to divide by zero in pdb_ds_read_file(). Check for this and fail cleanly instead. Fixes: Coverity CID 1458869 Signed-off-by: Peter Maydell Re

[PATCH v2 0/2] elf2dmp: Fix minor Coverity nits

2021-09-10 Thread Philippe Mathieu-Daudé
This is a respin of Peter Maydell series, with slightly different logic on the first patch. Quoting v1 cover [*]: Coverity complains about a couple of minor issues in elf2dmp: * we weren't checking the return value from curl_easy_setopt() * we might divide by zero if presented with a corru

[PATCH v2 1/2] elf2dmp: Check curl_easy_setopt() return value

2021-09-10 Thread Philippe Mathieu-Daudé
From: Peter Maydell Coverity points out that we aren't checking the return value from curl_easy_setopt(). Fixes: Coverity CID 1458895 Inspired-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- Informal T-b tag on https://lore.kernel.org/qemu-devel/20210909004313.1dadb24e@192.168.1.7/

Re: [PULL 0/6] Vga 20210910 patches

2021-09-10 Thread Peter Maydell
; > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/vga-20210910-pull-request > > for you to fetch changes up to 6335c0b56819a5d1219ea84a11a732d0861542db: > > qxl: fix pre-save logic (2021-09-10 12:23:12 +0200) > > --

Re: [PATCH RFC server v2 08/11] vfio-user: handle PCI BAR accesses

2021-09-10 Thread Jag Raman
> On Sep 9, 2021, at 3:37 AM, Stefan Hajnoczi wrote: > > On Fri, Aug 27, 2021 at 01:53:27PM -0400, Jagannathan Raman wrote: >> +/** >> + * VFU_OBJECT_BAR_HANDLER - macro for defining handlers for PCI BARs. >> + * >> + * To create handler for BAR number 2, VFU_OBJECT_BAR_HANDLER(2) would >> + *

Re: applied? Re: [PATCH v1 0/2] Update NVMM support to recent changes, [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined, [PATCH v1 2/2] Fix nvmm_ram_block_added() function arguments

2021-09-10 Thread Paolo Bonzini
On 07/09/21 18:02, Reinoud Zandijk wrote: ping? Queued, thanks. Paolo On Sun, Aug 29, 2021 at 05:39:07PM +0100, Peter Maydell wrote: On Sun, 29 Aug 2021 at 17:06, Reinoud Zandijk wrote: Hi :) Have these patches been applied? How can I easily check it without manually checking if they ar

Re: [PATCH RFC server v2 06/11] vfio-user: handle PCI config space accesses

2021-09-10 Thread Jag Raman
> On Sep 9, 2021, at 3:27 AM, Stefan Hajnoczi wrote: > > On Fri, Aug 27, 2021 at 01:53:25PM -0400, Jagannathan Raman wrote: >> +static ssize_t vfu_object_cfg_access(vfu_ctx_t *vfu_ctx, char * const buf, >> + size_t count, loff_t offset, >> +

Re: [PATCH 1/2] tests: add migrate-during-backup

2021-09-10 Thread Vladimir Sementsov-Ogievskiy
10.09.2021 17:18, Hanna Reitz wrote: On 10.09.21 13:00, Vladimir Sementsov-Ogievskiy wrote: Add a simple test which tries to run migration during backup. bdrv_inactivate_all() should fail. But due to bug (see next commit with fix) it doesn't, nodes are inactivated and continued backup crashes on

Re: [PATCH 1/4] target/arm: Add TB flag for "MVE insns not predicated"

2021-09-10 Thread Peter Maydell
On Tue, 7 Sept 2021 at 15:11, Richard Henderson wrote: > > * gen_update_fp_context() -- this function gets called for pretty > > much every FP/MVE insn (as part of vfp_access_check), and it > > can in rare cases update the FPSCR.LTPSIZE and the VPR. I guess > > this means we really d

Re: [qemu-web PATCH] Fix link to Windows page in Wiki

2021-09-10 Thread Paolo Bonzini
On 25/08/21 18:43, Helge Konetzka wrote: Furthermore I would like to propose to change the instructions for Native builds with MSYS2 on Wiki Windows page. Please remove the section which copies system binaries to match the expected file names! Instead define variables for configure (gcc-ar a

Re: [qemu-web PATCH] contribute: ask not to submit merge requests

2021-09-10 Thread Peter Maydell
On Fri, 10 Sept 2021 at 16:34, Daniel P. Berrangé wrote: > I think it might be worth leaving a warning here despite adding it > to the main contribute index page, as people might land directly on > this page and not see the other page's warning. > > > Do NOT report security issues (or other bugs,

Re: [qemu-web PATCH 0/6] Small header/footer layout changes

2021-09-10 Thread Paolo Bonzini
On 08/09/21 14:28, Daniel P. Berrangé wrote: I previously sent a large series to more fully re-design the website, especially the front page https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg08205.html Paolo had some feedback on that which I want to take into account but playing with

Re: [PATCH v4 22/33] hostmem-epc: Add the reset interface for EPC backend reset

2021-09-10 Thread Sean Christopherson
On Fri, Sep 10, 2021, Paolo Bonzini wrote: > On 19/07/21 13:21, Yang Zhong wrote: > > +void sgx_memory_backend_reset(HostMemoryBackend *backend, int fd, > > + Error **errp) > > +{ > > +MemoryRegion *mr = &backend->mr; > > + > > +mr->enabled = false; > > + > > +

Re: [qemu-web PATCH] contribute: ask not to submit merge requests

2021-09-10 Thread Daniel P . Berrangé
On Fri, Sep 10, 2021 at 05:29:33PM +0200, Paolo Bonzini wrote: > Currently, the bug reporting page has a paragraph about not sending patches > on the bug tracker, with a link to the patch submission guidelines. > > However, now that the tracker is hosted on Gitlab it is more likely that > prospect

Re: Adding IO memory region to mipssim

2021-09-10 Thread Philippe Mathieu-Daudé
On 9/10/21 3:21 PM, Hinko Kocevar wrote: > I'm trying to add an I/O memory region to mipssim machine to emulate a > MMIO region used by the u-boot loaded as BIOS image. I can confirm that > the machine starts and loads the BIOS, starts execution but hangs due to > unhandled IO access as described b

[qemu-web PATCH] contribute: ask not to submit merge requests

2021-09-10 Thread Paolo Bonzini
Currently, the bug reporting page has a paragraph about not sending patches on the bug tracker, with a link to the patch submission guidelines. However, now that the tracker is hosted on Gitlab it is more likely that prospective contributors will submit a merge request linked to an issue, rather t

Re: [PATCH RFC server v2 01/11] vfio-user: build library

2021-09-10 Thread Philippe Mathieu-Daudé
On 9/8/21 2:25 PM, Stefan Hajnoczi wrote: > On Fri, Aug 27, 2021 at 01:53:20PM -0400, Jagannathan Raman wrote: >> diff --git a/.gitmodules b/.gitmodules >> index 08b1b48..cfeea7c 100644 >> --- a/.gitmodules >> +++ b/.gitmodules >> @@ -64,3 +64,6 @@ >> [submodule "roms/vbootrom"] >> path = ro

Re: [PATCH RFC server v2 01/11] vfio-user: build library

2021-09-10 Thread Philippe Mathieu-Daudé
On 8/27/21 7:53 PM, Jagannathan Raman wrote: > add the libvfio-user library as a submodule. build it as a cmake > subproject. > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > configure| 11 +++ > meson.build

Re: [PULL 0/3] Input 20210910 patches

2021-09-10 Thread Peter Maydell
; > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/input-20210910-pull-request > > for you to fetch changes up to 4e9bddcbaa74e2463f0a79350fea5311c9890982: > > ps2: migration support f

Re: [PATCH v4 23/33] sgx-epc: Add the reset interface for sgx-epc virt device

2021-09-10 Thread Paolo Bonzini
On 19/07/21 13:21, Yang Zhong wrote: +static void sgx_epc_del_subregion(DeviceState *dev) +{ +PCMachineState *pcms = PC_MACHINE(qdev_get_machine()); +SGXEPCState *sgx_epc = &pcms->sgx_epc; +SGXEPCDevice *epc = SGX_EPC(dev); + +/* del subregion and related operations */ +memory

Re: [PATCH v4 22/33] hostmem-epc: Add the reset interface for EPC backend reset

2021-09-10 Thread Paolo Bonzini
On 19/07/21 13:21, Yang Zhong wrote: +void sgx_memory_backend_reset(HostMemoryBackend *backend, int fd, + Error **errp) +{ +MemoryRegion *mr = &backend->mr; + +mr->enabled = false; + +/* destroy the old memory region if it exist */ +if (fd > 0 && mr->d

Re: [PATCH v3 6/6] tests/qapi-schema: Test cases for aliases

2021-09-10 Thread Kevin Wolf
Am 06.09.2021 um 17:28 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > +/* Can still specify the real member name with alias support */ > > +v = visitor_input_test_init(data, "{ 'foo': 42 }"); > > +visit_type_AliasStruct1(v, NULL, &tmp, &error_abort); > > +g_assert_cmpi

Re: [PATCH RFC server v2 04/11] vfio-user: find and init PCI device

2021-09-10 Thread Jag Raman
> On Sep 8, 2021, at 8:43 AM, Stefan Hajnoczi wrote: > > On Fri, Aug 27, 2021 at 01:53:23PM -0400, Jagannathan Raman wrote: >> @@ -96,6 +102,28 @@ static void vfu_object_machine_done(Notifier *notifier, >> void *data) >>strerror(errno)); >> return; >> } >> + >>

[PATCH] hw/nvme: Return error for fused operations

2021-09-10 Thread Pankaj Raghav
Currently, FUSED operations are not supported by QEMU. As per the 1.4 SPEC, controller should abort the command that requested a fused operation with an INVALID FIELD error code if they are not supported. Signed-off-by: Pankaj Raghav --- hw/nvme/ctrl.c | 4 1 file changed, 4 insertions(+)

Re: [PATCH RFC server v2 03/11] vfio-user: instantiate vfio-user context

2021-09-10 Thread Jag Raman
> On Sep 8, 2021, at 8:40 AM, Stefan Hajnoczi wrote: > > On Fri, Aug 27, 2021 at 01:53:22PM -0400, Jagannathan Raman wrote: >> create a context with the vfio-user library to run a PCI device >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jagannathan R

Re: [PATCH] softmmu: fix watchpoint processing in icount mode

2021-09-10 Thread Richard Henderson
On 9/10/21 3:46 PM, David Hildenbrand wrote: On 10.09.21 15:34, Richard Henderson wrote: On 9/10/21 1:15 PM, David Hildenbrand wrote: On 07.09.21 13:30, Pavel Dovgalyuk wrote: Watchpoint processing code restores vCPU state twice: in tb_check_watchpoint and in cpu_loop_exit_restore/cpu_restore_

[PATCH v9 9/9] tests/data/acpi/virt: Update IORT files for ITS

2021-09-10 Thread Shashi Mallela
Updated expected IORT files applicable with latest GICv3 ITS changes. Full diff of new file disassembly: /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20180629 (64-bit version) * Copyright (c) 2000 - 2018 Intel Corporation * * Disassembly of tests/data/acpi/virt/IORT

[PATCH v9 8/9] hw/arm/virt: add ITS support in virt GIC

2021-09-10 Thread Shashi Mallela
Included creation of ITS as part of virt platform GIC initialization. This Emulated ITS model now co-exists with kvm ITS and is enabled in absence of kvm irq kernel support in a platform. Signed-off-by: Shashi Mallela Reviewed-by: Peter Maydell --- hw/arm/virt.c | 29 +++

[PATCH v9 7/9] tests/data/acpi/virt: Add IORT files for ITS

2021-09-10 Thread Shashi Mallela
Added expected IORT files applicable with latest GICv3 ITS changes.Temporarily differences in these files are okay. Signed-off-by: Shashi Mallela Acked-by: Igor Mammedov Reviewed-by: Peter Maydell --- tests/data/acpi/virt/IORT | 0 tests/data/acpi/virt/IORT.memhp

[PATCH v9 6/9] hw/intc: GICv3 redistributor ITS processing

2021-09-10 Thread Shashi Mallela
Implemented lpi processing at redistributor to get lpi config info from lpi configuration table,determine priority,set pending state in lpi pending table and forward the lpi to cpuif.Added logic to invoke redistributor lpi processing with translated LPI which set/clear LPI from ITS device as part o

[PATCH v9 3/9] hw/intc: GICv3 ITS command queue framework

2021-09-10 Thread Shashi Mallela
Added functionality to trigger ITS command queue processing on write to CWRITE register and process each command queue entry to identify the command type and handle commands like MAPD,MAPC,SYNC. Signed-off-by: Shashi Mallela Reviewed-by: Peter Maydell Reviewed-by: Eric Auger Tested-by: Neil Arm

[PATCH v9 4/9] hw/intc: GICv3 ITS Command processing

2021-09-10 Thread Shashi Mallela
Added ITS command queue handling for MAPTI,MAPI commands,handled ITS translation which triggers an LPI via INT command as well as write to GITS_TRANSLATER register,defined enum to differentiate between ITS command interrupt trigger and GITS_TRANSLATER based interrupt trigger. Each of these commands

[PATCH v9 5/9] hw/intc: GICv3 ITS Feature enablement

2021-09-10 Thread Shashi Mallela
Added properties to enable ITS feature and define qemu system address space memory in gicv3 common,setup distributor and redistributor registers to indicate LPI support. Signed-off-by: Shashi Mallela Reviewed-by: Peter Maydell Tested-by: Neil Armstrong --- hw/intc/arm_gicv3_common.c |

[PATCH v9 2/9] hw/intc: GICv3 ITS register definitions added

2021-09-10 Thread Shashi Mallela
Defined descriptors for ITS device table,collection table and ITS command queue entities.Implemented register read/write functions, extract ITS table parameters and command queue parameters,extended gicv3 common to capture qemu address space(which host the ITS table platform memories required for s

[PATCH v9 0/9] GICv3 LPI and ITS feature implementation

2021-09-10 Thread Shashi Mallela
This patchset implements qemu device model for enabling physical LPI support and ITS functionality in GIC as per GICv3 specification. Both flat table and 2 level tables are implemented.The ITS commands for adding/deleting ITS table entries,trigerring LPI interrupts are implemented.Translated LPI in

[PATCH v9 1/9] hw/intc: GICv3 ITS initial framework

2021-09-10 Thread Shashi Mallela
Added register definitions relevant to ITS,implemented overall ITS device framework with stubs for ITS control and translater regions read/write,extended ITS common to handle mmio init between existing kvm device and newer qemu device. Signed-off-by: Shashi Mallela Reviewed-by: Peter Maydell Rev

Re: [PATCH v2] block/mirror: fix NULL pointer dereference in mirror_wait_on_conflicts()

2021-09-10 Thread Hanna Reitz
On 10.09.21 14:45, Stefano Garzarella wrote: In mirror_iteration() we call mirror_wait_on_conflicts() with `self` parameter set to NULL. Starting from commit d44dae1a7c we dereference `self` pointer in mirror_wait_on_conflicts() without checks if it is not NULL. Backtrace: Program terminated

Re: [PATCH v2 0/3] The HMP/QMP interfaces in Qemu SGX

2021-09-10 Thread Daniel P . Berrangé
On Fri, Sep 10, 2021 at 04:15:21PM +0200, Paolo Bonzini wrote: > On 10/09/21 12:22, Yang Zhong wrote: > > This patchset supply HMP/QMP interfaces to monitor and Libvirt, with > > those interfaces, we can check the SGX info from VM side or check > > host SGX capabilities from Libvirt side. > > > >

Re: [PATCH 1/2] tests: add migrate-during-backup

2021-09-10 Thread Hanna Reitz
On 10.09.21 13:00, Vladimir Sementsov-Ogievskiy wrote: Add a simple test which tries to run migration during backup. bdrv_inactivate_all() should fail. But due to bug (see next commit with fix) it doesn't, nodes are inactivated and continued backup crashes on assertion "assert(!(bs->open_flags &

Re: [PATCH 2/2] block: bdrv_inactivate_recurse(): check for permissions and fix crash

2021-09-10 Thread Hanna Reitz
On 10.09.21 13:01, Vladimir Sementsov-Ogievskiy wrote: We must not inactivate child when parent has write permissions on it. Calling .bdrv_inactivate() doesn't help: actually only qcow2 has this handler and it is used to flush caches, not for permission manipulations. I guess we could ask whet

Re: [PATCH v2 0/3] The HMP/QMP interfaces in Qemu SGX

2021-09-10 Thread Paolo Bonzini
On 10/09/21 12:22, Yang Zhong wrote: This patchset supply HMP/QMP interfaces to monitor and Libvirt, with those interfaces, we can check the SGX info from VM side or check host SGX capabilities from Libvirt side. This patchset is splitted from below link(from patch26 to patch30): https://patchew

Re: [PATCH RFC server v2 02/11] vfio-user: define vfio-user object

2021-09-10 Thread Jag Raman
> On Sep 8, 2021, at 8:37 AM, Stefan Hajnoczi wrote: > > On Fri, Aug 27, 2021 at 01:53:21PM -0400, Jagannathan Raman wrote: >> Define vfio-user object which is remote process server for QEMU. Setup >> object initialization functions and properties necessary to instantiate >> the object >> >> S

Re: [PATCH RFC server v2 00/11] vfio-user server in QEMU

2021-09-10 Thread Jag Raman
> On Sep 9, 2021, at 4:17 AM, Stefan Hajnoczi wrote: > > Hi Jag, > I have finished reviewing these patches and left comments. I didn't take > a look at the libvfio-user's implementation. Thank you for you comments, Stefan - we’ll get cracking on them. :) -- Jag > > Stefan

Re: [PATCH v10 03/16] target/riscv: clwz must ignore high bits (use shift-left & changed logic)

2021-09-10 Thread Richard Henderson
On 9/10/21 3:47 PM, Philipp Tomsich wrote: Just wondering regarding the UXL-comment: the clzw instruction will be an illegal encoding for RV32 (the w-form instructions are present on RV64 only), so it should never be encountered in a RV32 instruction stream. Correct. Did you mean that clz (t

Re: [PATCH 1/5] docs/devel: document expectations for QAPI data modelling for QMP

2021-09-10 Thread Daniel P . Berrangé
On Fri, Sep 10, 2021 at 03:45:11PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Sep 09, 2021 at 11:33:20AM +0200, Markus Armbruster wrote: > > [...] > > >> There are many existing long lines in this file, so I'm not flagging > >> yours, except for this one, because

Re: [PATCH v10 03/16] target/riscv: clwz must ignore high bits (use shift-left & changed logic)

2021-09-10 Thread Philipp Tomsich
On Fri, 10 Sept 2021 at 16:40, Richard Henderson < richard.hender...@linaro.org> wrote: > On 9/10/21 3:36 PM, Philipp Tomsich wrote: > > Richard, > > > > Did you have a chance to consider what to do with clzw? > > I would prefer to avoid the extra extension instructions and change the > implementa

Re: [PATCH] softmmu: fix watchpoint processing in icount mode

2021-09-10 Thread David Hildenbrand
On 10.09.21 15:34, Richard Henderson wrote: On 9/10/21 1:15 PM, David Hildenbrand wrote: On 07.09.21 13:30, Pavel Dovgalyuk wrote: Watchpoint processing code restores vCPU state twice: in tb_check_watchpoint and in cpu_loop_exit_restore/cpu_restore_state. Normally it does not affect anything, b

Re: [PATCH v2 1/3] monitor: Add HMP and QMP interfaces

2021-09-10 Thread Daniel P . Berrangé
On Fri, Sep 10, 2021 at 06:22:56PM +0800, Yang Zhong wrote: > The QMP and HMP interfaces can be used by monitor or QMP tools to retrieve > the SGX information from VM side when SGX is enabled on Intel platform. > > Signed-off-by: Yang Zhong > --- > hmp-commands-info.hx | 15 +

Re: [PATCH 1/5] docs/devel: document expectations for QAPI data modelling for QMP

2021-09-10 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Sep 09, 2021 at 11:33:20AM +0200, Markus Armbruster wrote: [...] >> There are many existing long lines in this file, so I'm not flagging >> yours, except for this one, because it increases the maximum. > > This line is at exactly 80 characters so checkstyle

Re: [PATCH v10 03/16] target/riscv: clwz must ignore high bits (use shift-left & changed logic)

2021-09-10 Thread Richard Henderson
On 9/10/21 3:36 PM, Philipp Tomsich wrote: Richard, Did you have a chance to consider what to do with clzw? I would prefer to avoid the extra extension instructions and change the implementation (and would update the commit message to provide more context), but if you insist on setting 'ctx->w

Re: [PATCH v10 03/16] target/riscv: clwz must ignore high bits (use shift-left & changed logic)

2021-09-10 Thread Philipp Tomsich
Richard, Did you have a chance to consider what to do with clzw? I would prefer to avoid the extra extension instructions and change the implementation (and would update the commit message to provide more context), but if you insist on setting 'ctx->w' I'll just have the extra extensions emitted t

Re: [PATCH] softmmu: fix watchpoint processing in icount mode

2021-09-10 Thread Richard Henderson
On 9/10/21 1:15 PM, David Hildenbrand wrote: On 07.09.21 13:30, Pavel Dovgalyuk wrote: Watchpoint processing code restores vCPU state twice: in tb_check_watchpoint and in cpu_loop_exit_restore/cpu_restore_state. Normally it does not affect anything, but in icount mode instruction counter is incr

Re: [PATCH v2] block/mirror: fix NULL pointer dereference in mirror_wait_on_conflicts()

2021-09-10 Thread Vladimir Sementsov-Ogievskiy
10.09.2021 15:45, Stefano Garzarella wrote: In mirror_iteration() we call mirror_wait_on_conflicts() with `self` parameter set to NULL. Starting from commit d44dae1a7c we dereference `self` pointer in mirror_wait_on_conflicts() without checks if it is not NULL. Backtrace: Program terminated

Re: SMMU Stage 2 translation in QEMU

2021-09-10 Thread shashi . mallela
So that would be the driver code running in guest OS because i see tables being setup by arm-smmu driver code in linux,which is similar to what happens with ITS(table base addresses programmed in registers by linux driver). On Fri, 2021-09-10 at 13:54 +0100, Peter Maydell wrote: > On Fri, 10 Sept

[PULL 3/6] ui: Create sync objects and fences only for blobs

2021-09-10 Thread Gerd Hoffmann
From: Vivek Kasireddy Create sync objects and fences only for dmabufs that are blobs. Once a fence is created (after glFlush) and is signalled, graphic_hw_gl_flushed() will be called and virtio-gpu cmd processing will be resumed. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy Message-Id: <20

Adding IO memory region to mipssim

2021-09-10 Thread Hinko Kocevar
I'm trying to add an I/O memory region to mipssim machine to emulate a MMIO region used by the u-boot loaded as BIOS image. I can confirm that the machine starts and loads the BIOS, starts execution but hangs due to unhandled IO access as described below. The region should be at 0xB881, of siz

[PULL 6/6] qxl: fix pre-save logic

2021-09-10 Thread Gerd Hoffmann
Oops. Logic is backwards. Fixes: 39b8a183e2f3 ("qxl: remove assert in qxl_pre_save.") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/610 Resolves: https://bugzilla.redhat.com//show_bug.cgi?id=2002907 Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Reviewed-by: Marc-André L

[PULL 5/6] virtio-gpu: Add gl_flushed callback

2021-09-10 Thread Gerd Hoffmann
From: Vivek Kasireddy Adding this callback provides a way to resume the processing of cmds in fenceq and cmdq that were not processed because the UI was waiting on a fence and blocked cmd processing. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy Message-Id: <2021

[PULL 1/6] ui/gtk: Create a common release_dmabuf helper

2021-09-10 Thread Gerd Hoffmann
From: Vivek Kasireddy Since the texture release mechanism is same for both gtk-egl and gtk-glarea, move the helper from gtk-egl to common gtk code so that it can be shared by both gtk backends. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy Message-Id: <2021090121

[PULL 4/6] ui/gtk-egl: Wait for the draw signal for dmabuf blobs

2021-09-10 Thread Gerd Hoffmann
From: Vivek Kasireddy Instead of immediately drawing and submitting, queue and wait for the draw signal if the dmabuf submitted is a blob. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy Message-Id: <20210901211014.2800391-5-vivek.kasire...@intel.com> Signed-off-by

[PULL 0/6] Vga 20210910 patches

2021-09-10 Thread Gerd Hoffmann
The following changes since commit bd662023e683850c085e98c8ff8297142c2dd9f2: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-20210908' into staging (2021-09-08 11:06:17 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/vga-20210910-pu

[PULL 2/6] ui/egl: Add egl helpers to help with synchronization

2021-09-10 Thread Gerd Hoffmann
From: Vivek Kasireddy These egl helpers would be used for creating and waiting on a sync object. Cc: Gerd Hoffmann Reviewed-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy Message-Id: <20210901211014.2800391-3-vivek.kasire...@intel.com> Signed-off-by: Gerd Hoffmann --- include/ui/console.h

Re: [PULL 0/7] Migration.next patches

2021-09-10 Thread Li, Zhijian
on 2021/9/10 20:55, Philippe Mathieu-Daudé wrote: BTW: Does QEMU provide any mean to set http(s)_proxy to building vm ? Currently, i have to hack the code like: -self.ssh_root_check("pkg install -y %s\n" % " ".join(self.pkgs)) +self.ssh_root_check("setenv HTTP_PROXY http://myp

Re: [PATCH 1/4] target/arm: Add TB flag for "MVE insns not predicated"

2021-09-10 Thread Richard Henderson
On 9/10/21 11:30 AM, Peter Maydell wrote: If gen_lookup_tb() and DISAS_UPDATE_EXIT are the same, maybe we should get rid of gen_lookup_tb() entirely ? Yes, I think we should do just that. r~

Re: [PULL 0/7] Migration.next patches

2021-09-10 Thread Philippe Mathieu-Daudé
On 9/10/21 7:27 AM, lizhij...@fujitsu.com wrote: > On 10/09/2021 13:20, Li Zhijian wrote: >> On 10/09/2021 00:10, Juan Quintela wrote: >>> "Li, Zhijian" wrote: on 2021/9/9 21:42, Peter Maydell wrote: > On Thu, 9 Sept 2021 at 11:36, Juan Quintela wrote: > Fails to build, FreeBSD:

  1   2   >