Re: [PATCH 18/19] target/ppc/pmu_book3s_helper.c: add PM_CMPLU_STALL mock events

2021-08-10 Thread David Gibson
On Tue, Aug 10, 2021 at 04:48:59PM -0300, Daniel Henrique Barboza wrote: > > > On 8/10/21 1:17 AM, David Gibson wrote: > > On Mon, Aug 09, 2021 at 10:10:56AM -0300, Daniel Henrique Barboza wrote: > > > EBB powerpc kernel test 'multi_counter_test' uses PM_CMPLU_STALL events > > > that we do not su

Re: [PATCH 12/19] target/ppc/pmu_book3s_helper.c: enable PMC1 counter negative EBB

2021-08-10 Thread David Gibson
On Tue, Aug 10, 2021 at 05:26:09PM -0300, Daniel Henrique Barboza wrote: > > > On 8/10/21 1:01 AM, David Gibson wrote: > > On Mon, Aug 09, 2021 at 10:10:50AM -0300, Daniel Henrique Barboza wrote: > > > This patch starts the counter negative EBB support by enabling PMC1 > > > counter negative cond

Re: [PATCH v4] failover: unregister ROM on unplug

2021-08-10 Thread Michael S. Tsirkin
On Wed, Jul 21, 2021 at 06:09:05PM +0200, Laurent Vivier wrote: > The intend of failover is to allow to migrate a VM with a VFIO > networking card without disrupting the network operation by switching > to a virtio-net device during the migration. > > This simple change allows to test failover wit

[PULL 7/7] MAINTAINERS: update virtio-gpu entry.

2021-08-10 Thread Gerd Hoffmann
New maintainer wanted. Downgrade status to "Odd Fixes" for now. Signed-off-by: Gerd Hoffmann Message-Id: <20210810083450.2377374-8-kra...@redhat.com> --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 6e86426572a3..6b3697962c1b

Re: [PATCH 13/19] target/ppc/translate: PMU: handle setting of PMCs while running

2021-08-10 Thread David Gibson
On Tue, Aug 10, 2021 at 05:44:18PM -0300, Daniel Henrique Barboza wrote: > > > On 8/10/21 1:06 AM, David Gibson wrote: > > On Mon, Aug 09, 2021 at 10:10:51AM -0300, Daniel Henrique Barboza wrote: > > > The initial PMU support were made under the assumption that the counters > > > would be set bef

[PULL 5/7] MAINTAINERS: update usb entries.

2021-08-10 Thread Gerd Hoffmann
New maintainer wanted. Switch role to "Reviewer" for usb-serial, downgrade status to "Odd Fixes" for everything else. Cc: Samuel Thibault Signed-off-by: Gerd Hoffmann Message-Id: <20210810083450.2377374-6-kra...@redhat.com> --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [PATCH 06/19] target/ppc/pmu_book3s_helper: enable PMC1-PMC4 events

2021-08-10 Thread David Gibson
On Tue, Aug 10, 2021 at 12:03:15PM -0300, Daniel Henrique Barboza wrote: > > > On 8/10/21 12:42 AM, David Gibson wrote: > > On Mon, Aug 09, 2021 at 10:10:44AM -0300, Daniel Henrique Barboza wrote: > > > So far the PMU logic was using PMC5 for instruction counting (linux > > > kernel PM_INST_CMPL)

[PULL 3/7] MAINTAINERS: update audio entry.

2021-08-10 Thread Gerd Hoffmann
New maintainer wanted. Downgrade status to "Odd Fixes" for now. Signed-off-by: Gerd Hoffmann Message-Id: <20210810083450.2377374-4-kra...@redhat.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 79b0148cfc27..5cb402d402ec 100

[PULL 1/7] MAINTAINERS: update edk2 entry.

2021-08-10 Thread Gerd Hoffmann
I want keep an eye on the edk2 things happening in qemu. Cc: Philippe Mathieu-Daudé Signed-off-by: Gerd Hoffmann Message-Id: <20210810083450.2377374-2-kra...@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 694973ed230d..d6c84bd0a98

[PULL 6/7] MAINTAINERS: update virtio-input entry.

2021-08-10 Thread Gerd Hoffmann
New maintainer wanted. Downgrade status to "Odd Fixes" for now. Signed-off-by: Gerd Hoffmann Message-Id: <20210810083450.2377374-7-kra...@redhat.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b84b7e33e4d0..6e86426572a3 100

[PULL 2/7] MAINTAINERS: update sockets entry.

2021-08-10 Thread Gerd Hoffmann
I have not touched the code for years. Make the entry match reality and drop my name. Cc: Daniel P. Berrange Signed-off-by: Gerd Hoffmann Message-Id: <20210810083450.2377374-3-kra...@redhat.com> --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d

[PULL 4/7] MAINTAINERS: update spice entry.

2021-08-10 Thread Gerd Hoffmann
New maintainer wanted. Downgrade status to "Odd Fixes" for now. Signed-off-by: Gerd Hoffmann Message-Id: <20210810083450.2377374-5-kra...@redhat.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5cb402d402ec..33b4fc25e349 100

[PULL 0/7] Maintainers 20210811 patches

2021-08-10 Thread Gerd Hoffmann
The following changes since commit 703e8cd6189cf699c8d5c094bc68b5f3afa6ad71: Update version for v6.1.0-rc3 release (2021-08-10 19:08:09 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/maintainers-20210811-pull-request for you to fetch changes up to a4de5e8a0667

Re: [PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-08-10 Thread Hanna Reitz
On 10.08.21 17:57, Vivek Goyal wrote: On Tue, Aug 10, 2021 at 05:26:15PM +0200, Hanna Reitz wrote: On 10.08.21 17:23, Vivek Goyal wrote: On Tue, Aug 10, 2021 at 10:32:55AM +0200, Hanna Reitz wrote: On 09.08.21 20:41, Vivek Goyal wrote: On Fri, Jul 30, 2021 at 05:01:33PM +0200, Max Reitz wrote

Re: [PATCH v2 1/1] virtio: failover: define the default device to use in case of error

2021-08-10 Thread Laurent Vivier
On 11/08/2021 06:18, Jason Wang wrote: > On Tue, Aug 10, 2021 at 1:14 AM Laurent Vivier wrote: >> >> If the guest driver doesn't support the STANDBY feature, by default >> we keep the virtio-net device and don't hotplug the VFIO device, >> but in some cases, user can prefer to use the VFIO device

Re: [PATCH v2 0/1] virtio: failover: allow to keep the VFIO device rather than the virtio-net one

2021-08-10 Thread Laurent Vivier
On 11/08/2021 06:17, Jason Wang wrote: > On Tue, Aug 10, 2021 at 1:13 AM Laurent Vivier wrote: >> >> v2: use validate_features() to disable the guest driver rather >> than setting vring.num to 0. >> >> With failover, when the guest virtio-net driver doesn't support the >> STANDBY feature, the

Re: [PATCH 3/7] MAINTAINERS: update audio entry.

2021-08-10 Thread clamky
Gerd Hoffmann writes: > On Tue, Aug 10, 2021 at 03:17:43PM +0300, cla...@hotmail.com wrote: >> Gerd Hoffmann writes: >> >> Hell Gerd. >> >> > New maintainer wanted. Downgrade status to "Odd Fixes" for now. >> >> I can try to retake it. > > qemu development happens in public on the qemu-devel

Re: [PATCH 1/2] gitlab: exclude sparc-softmmu and riscv32-softmmu from cross builds

2021-08-10 Thread Philippe Mathieu-Daudé
+Mark/Artyom On 8/10/21 4:06 PM, Daniel P. Berrangé wrote: > We need to cut down compile time by excluding more targets. Both these > targets still have their 64-bit variant enabled, so the loss of coverage > is mitigated to some degree. > > Signed-off-by: Daniel P. Berrangé > --- > .gitlab-ci.

Re: [PATCH 2/2] gitlab: skip many more targets in windows cross builds

2021-08-10 Thread Philippe Mathieu-Daudé
On 8/10/21 4:06 PM, Daniel P. Berrangé wrote: > The windows cross builds still take way too long in gitlab CI, so need > more targets to be skipped. We don't want to hurt coverage of other > cross builds more though, so we let jobs fine tune with a new env > variale $CROSS_SKIP_TARGETS. > > We tak

Re: [PATCH v12] qapi: introduce 'query-x86-cpuid' QMP command.

2021-08-10 Thread Thomas Huth
On 10/08/2021 20.56, Eduardo Habkost wrote: On Sat, Aug 07, 2021 at 04:22:42PM +0200, Markus Armbruster wrote: Is this intended to be a stable interface? Interfaces intended just for debugging usually aren't. I don't think we need to make it a stable interface, but I won't mind if we declare

Re: [PATCH] build: remove redundant 'check-build' make target

2021-08-10 Thread Thomas Huth
On 10/08/2021 18.44, Daniel P. Berrangé wrote: The 'check-build' make target was added as a way to build all the unit test binaries, since the standard 'all' target would not trigger this. Since the switch to meson, however, 'all' will now include the 'test' binaries. As a result, 'check-build'

Re: [PATCH 0/2] gitlab: avoid timeouts in windows cross builds

2021-08-10 Thread Thomas Huth
On 10/08/2021 16.06, Daniel P. Berrangé wrote: The win64 cross build is quite often hitting the job timeout, despite having an elevated timeout of 80 minutes. A typical time is 75-78 minutes in my tests, which leaves little headroom. I'm not inclined to increase the timeout beyond 80 minutes as

Re: [PATCH v3] net/macos: implement vmnet-based netdev

2021-08-10 Thread Jason Wang
在 2021/7/8 下午1:44, Akihiko Odaki 写道: From: Phillip Tennen This patch implements a new netdev device, reachable via -netdev vmnet-macos, that’s backed by macOS’s vmnet framework. The vmnet framework provides native bridging support, and its usage in this patch is intended as a replacement for

Re: [PATCH v2 1/1] virtio: failover: define the default device to use in case of error

2021-08-10 Thread Jason Wang
On Tue, Aug 10, 2021 at 1:14 AM Laurent Vivier wrote: > > If the guest driver doesn't support the STANDBY feature, by default > we keep the virtio-net device and don't hotplug the VFIO device, > but in some cases, user can prefer to use the VFIO device rather > than the virtio-net one. We can't un

Re: [PATCH v2 0/1] virtio: failover: allow to keep the VFIO device rather than the virtio-net one

2021-08-10 Thread Jason Wang
On Tue, Aug 10, 2021 at 1:13 AM Laurent Vivier wrote: > > v2: use validate_features() to disable the guest driver rather > than setting vring.num to 0. > > With failover, when the guest virtio-net driver doesn't support the > STANDBY feature, the primary device is not plugged and only the virt

Re: [PATCH] hw/net: Discard overly fragmented packets

2021-08-10 Thread Jason Wang
在 2021/8/4 上午9:43, Jason Wang 写道: 在 2021/8/3 下午5:51, Philippe Mathieu-Daudé 写道: On 8/3/21 11:33 AM, Thomas Huth wrote: On 05/07/2021 10.40, Philippe Mathieu-Daudé wrote: Our infrastructure can handle fragmented packets up to NET_MAX_FRAG_SG_LIST (64) pieces. This hard limit has been proven

Re: [PATCH 09/10] hw/misc: Add Infineon DPS310 sensor model

2021-08-10 Thread Joel Stanley
On Tue, 10 Aug 2021 at 23:37, Corey Minyard wrote: > > On Mon, Aug 09, 2021 at 03:15:55PM +0200, Cédric Le Goater wrote: > > From: Joel Stanley > > > > This contains some hardcoded register values that were obtained from the > > hardware after reading the temperature. > > > > It does enough to te

Re: [PATCH 10/19] target/ppc: PMU Event-Based exception support

2021-08-10 Thread Richard Henderson
On 8/9/21 3:10 AM, Daniel Henrique Barboza wrote: diff --git a/target/ppc/pmu_book3s_helper.c b/target/ppc/pmu_book3s_helper.c index 91bb82e699..43cc0eb722 100644 --- a/target/ppc/pmu_book3s_helper.c +++ b/target/ppc/pmu_book3s_helper.c @@ -10,12 +10,15 @@ * See the COPYING file in the top-lev

Re: [PATCH 09/19] PPC64/TCG: Implement 'rfebb' instruction

2021-08-10 Thread Richard Henderson
On 8/10/21 9:32 AM, Daniel Henrique Barboza wrote: I'm not sure what is the disastree path. David meant decodetree. See insn32.decode. r~

Re: [PATCH 09/19] PPC64/TCG: Implement 'rfebb' instruction

2021-08-10 Thread Richard Henderson
On 8/9/21 3:10 AM, Daniel Henrique Barboza wrote: +TCGv target = tcg_temp_new(); +TCGv bescr = tcg_temp_new(); + +gen_load_spr(target, SPR_EBBRR); +tcg_gen_mov_tl(cpu_nip, target); You don't need a temporary for target here; just load into cpu_nip directly. +ctx->base.is_j

Re: [PATCH 08/19] target/ppc/pmu_book3s_helper.c: do an actual cycles calculation

2021-08-10 Thread Richard Henderson
On 8/9/21 3:10 AM, Daniel Henrique Barboza wrote: +/* + * Set arbitrarily based on clock-frequency values used in PNV + * and SPAPR code. + */ +#define PPC_CPU_FREQ 10 static uint64_t get_cycles(uint64_t icount_delta) { -/* Placeholder value */ -return icount_delta * 4; +

Re: [PATCH 04/19] target/ppc: PMU Book3s basic insns count for pseries TCG

2021-08-10 Thread Richard Henderson
On 8/9/21 3:10 AM, Daniel Henrique Barboza wrote: The PMCC (PMC Control) bit in the MMCR0 register controls whether the counters PMC5 and PMC6 are being part of the performance monitor facility in a specific time. If PMCC allows it, PMC5 and PMC6 will always be used to measure instructions comple

Re: [PATCH] fuzz: avoid building twice, when running on gitlab

2021-08-10 Thread Coiby Xu
On Tue, Aug 10, 2021 at 07:01:45AM +0200, Philippe Mathieu-Daudé wrote: +Coiby Xu & qemu-block@ Thanks for adding me to the Cc list. On 8/9/21 9:36 PM, Peter Maydell wrote: On Mon, 9 Aug 2021 at 20:30, Alexander Bulekov wrote: On 210809 1506, Alexander Bulekov wrote: On 210809 1925, Pet

Re: [PATCH 03/19] target/ppc: add exclusive user write function for PMU regs

2021-08-10 Thread Richard Henderson
On 8/9/21 5:29 PM, David Gibson wrote: ctx->spr_cb = env->spr_cb; +ctx->spr = env->spr; Eep... with that one line you're copying 8kiB of data into the context structure. That sounds undesirable.. especially since it look like you only check 8 bytes of it. Plus.. TBH, I'm a bit fuzzy

RE: [PATCH v3 1/3] target-arm: cpu64: Add support for Fujitsu A64FX

2021-08-10 Thread ishii.shuuic...@fujitsu.com
Thank you very much for the source review and the patch. We will create a series of V4 patches based on your comments. Best regards. > -Original Message- > From: Andrew Jones > Sent: Tuesday, August 10, 2021 8:41 PM > To: Ishii, Shuuichirou/ > Cc: peter.mayd...@linaro.org; qemu-...@no

Re: [PATCH for 6.2 39/49] bsd-user: Need to reset CPU after creation.

2021-08-10 Thread Richard Henderson
On 8/10/21 12:40 PM, Warner Losh wrote: Slightly amusing that the line was removed in patch 1, because it was ifdefed. Worth folding? Might as well. r~

Re: [PATCH 09/10] hw/misc: Add Infineon DPS310 sensor model

2021-08-10 Thread Corey Minyard
On Mon, Aug 09, 2021 at 03:15:55PM +0200, Cédric Le Goater wrote: > From: Joel Stanley > > This contains some hardcoded register values that were obtained from the > hardware after reading the temperature. > > It does enough to test the Linux kernel driver. The FIFO mode, IRQs and > operation mo

Re: [PATCH for 6.2 37/49] bsd-user: update debugging in mmap.c

2021-08-10 Thread Richard Henderson
On 8/10/21 12:34 PM, Warner Losh wrote: For the to-do list: convert to qemu_log_mask or tracepoints. Will do. Should I create a bsd-user/TODO file with all these in it (or rather, should I upstream the one I've already created)? Could do. Dunno if its easier or not, but we also have a s

[PATCH for-6.1] tcg/i386: Split P_VEXW from P_REXW

2021-08-10 Thread Richard Henderson
We need to be able to represent VEX.W on a 32-bit host, where REX.W will always be zero. Fixes the encoding for VPSLLVQ and VPSRLVQ. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/385 Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c.inc | 13 +++-- 1 file changed, 7 i

Re: [PATCH 06/19] target/ppc/pmu_book3s_helper: enable PMC1-PMC4 events

2021-08-10 Thread Daniel Henrique Barboza
On 8/10/21 12:03 PM, Daniel Henrique Barboza wrote: On 8/10/21 12:42 AM, David Gibson wrote: On Mon, Aug 09, 2021 at 10:10:44AM -0300, Daniel Henrique Barboza wrote: So far the PMU logic was using PMC5 for instruction counting (linux kernel PM_INST_CMPL) and PMC6 to count cycles (PM_CYC).

Re: [PATCH for 6.2 39/49] bsd-user: Need to reset CPU after creation.

2021-08-10 Thread Warner Losh
On Tue, Aug 10, 2021 at 10:32 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/7/21 11:42 AM, Warner Losh wrote: > > From: Warner Losh > > > > Signed-off-by: Warner Losh > > --- > > bsd-user/main.c | 2 ++ > > 1 file changed, 2 insertions(+) > > Reviewed-by: Richard Henderson

Re: [PATCH for 6.2 38/49] bsd-user: Update mapping to handle reserved and starting conditions

2021-08-10 Thread Warner Losh
On Tue, Aug 10, 2021 at 10:27 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/7/21 11:42 AM, Warner Losh wrote: > > From: Warner Losh > > > > Update the reserved base based on what platform we're on, as well as the > > start of the mmap range. Update routines that find va range

Re: [PATCH for 6.2 37/49] bsd-user: update debugging in mmap.c

2021-08-10 Thread Warner Losh
On Tue, Aug 10, 2021 at 10:19 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/7/21 11:42 AM, Warner Losh wrote: > > From: Warner Losh > > > > Update the debugging code for new features and different targets. > > > > Signed-off-by: Mikaël Urankar > > Signed-off-by: Sean Bruno > >

Re: [PATCH for 6.2 35/49] bsd-user: remove error_init

2021-08-10 Thread Warner Losh
On Tue, Aug 10, 2021 at 9:07 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/7/21 11:42 AM, Warner Losh wrote: > > From: Warner Losh > > > > Error reporting isn't used, so gc it until it's used. > > > > Signed-off-by: Warner Losh > > That's not true. At minimum, tcg/ uses Er

Re: [PATCH for 6.2 34/49] bsd-user: Fix initializtion of task state

2021-08-10 Thread Warner Losh
On Tue, Aug 10, 2021 at 9:03 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/7/21 11:42 AM, Warner Losh wrote: > > @@ -459,21 +435,11 @@ int main(int argc, char **argv) > > qemu_log("entry 0x" TARGET_ABI_FMT_lx "\n", info->entry); > > } > > > > -target_

[ANNOUNCE] QEMU 6.1.0-rc3 is now available

2021-08-10 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 6.1 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-6.1.0-rc3.tar.xz http://down

Re: [PATCH 15/19] target/ppc/pmu_book3s_helper: enable counter negative for all PMCs

2021-08-10 Thread Daniel Henrique Barboza
On 8/10/21 1:11 AM, David Gibson wrote: On Mon, Aug 09, 2021 at 10:10:53AM -0300, Daniel Henrique Barboza wrote: All performance monitor counters can trigger a counter negative condition if the proper MMCR0 bits are set. This patch does that by doing the following: - pmc_counter_negative_ena

Re: [PATCH 13/19] target/ppc/translate: PMU: handle setting of PMCs while running

2021-08-10 Thread Daniel Henrique Barboza
On 8/10/21 1:06 AM, David Gibson wrote: On Mon, Aug 09, 2021 at 10:10:51AM -0300, Daniel Henrique Barboza wrote: The initial PMU support were made under the assumption that the counters would be set before running the PMU and read after either freezing the PMU manually or via a performance mo

Re: [PATCH] tests/acceptance: Allow overwrite smp and memory

2021-08-10 Thread Ahmed Abouzied
ping Just pinging about this little patch. Patchew link here: https://patchew.org/QEMU/2021080257.50946-1-em...@aabouzied.com/. Best regards, Ahmed Abouzied On Tue, Aug 3, 2021 at 12:24 AM Ahmed Abouzied wrote: > Removes the hard-coded values in setUp(). Class inheriting from > avocado_qem

Re: [PATCH 12/19] target/ppc/pmu_book3s_helper.c: enable PMC1 counter negative EBB

2021-08-10 Thread Daniel Henrique Barboza
On 8/10/21 1:01 AM, David Gibson wrote: On Mon, Aug 09, 2021 at 10:10:50AM -0300, Daniel Henrique Barboza wrote: This patch starts the counter negative EBB support by enabling PMC1 counter negative condition. A counter negative condition happens when a performance monitor counter reaches the

Re: [PATCH v3 01/13] python/aqmp: Fix wait_closed work-around for python 3.6

2021-08-10 Thread Niteesh G. S.
On Thu, Aug 5, 2021 at 10:58 PM John Snow wrote: > > > On Fri, Jul 30, 2021 at 4:19 PM G S Niteesh Babu > wrote: > >> Before this patch the wait_closed work-around for python 3.6 >> fails during disconnect. >> This is a temproray work around for which might be fixed in the >> future or will be c

Re: [PATCH v14] qapi: introduce 'query-x86-cpuid' QMP command.

2021-08-10 Thread Eduardo Habkost
On Tue, Aug 10, 2021 at 09:51:31AM +0300, Valeriy Vdovin wrote: > From: Valeriy Vdovin > > Introducing new QMP command 'query-x86-cpuid'. This command can be used to > get virtualized cpu model info generated by QEMU during VM initialization in > the form of cpuid representation. > > Diving into

Re: [PATCH 18/19] target/ppc/pmu_book3s_helper.c: add PM_CMPLU_STALL mock events

2021-08-10 Thread Daniel Henrique Barboza
On 8/10/21 1:17 AM, David Gibson wrote: On Mon, Aug 09, 2021 at 10:10:56AM -0300, Daniel Henrique Barboza wrote: EBB powerpc kernel test 'multi_counter_test' uses PM_CMPLU_STALL events that we do not support. These events are related to CPU stalled/wasted cycles while waiting for resources, c

Re: [PULL ppc] powernv queue

2021-08-10 Thread Cédric Le Goater
;>>> The following changes since commit >>>> bccabb3a5d60182645c7749e89f21a9ff307a9eb: >>>> >>>> Update version for v6.1.0-rc2 release (2021-08-04 16:56:14 +0100) >>>> >>>> are available in the Git repository at: >>>> >>>> https://gi

Re: [PATCH 09/19] PPC64/TCG: Implement 'rfebb' instruction

2021-08-10 Thread Daniel Henrique Barboza
On 8/10/21 12:50 AM, David Gibson wrote: On Mon, Aug 09, 2021 at 10:10:47AM -0300, Daniel Henrique Barboza wrote: From: Gustavo Romero An Event-Based Branch (EBB) allows applications to change the NIA when a event-based exception occurs. Event-based exceptions are enabled by setting the Bra

Re: [PATCH-for-6.2] tests/acceptance: Allow overwrite smp and memory

2021-08-10 Thread Philippe Mathieu-Daudé
Subject: "Allow overwrite default smp and memsize command line options"? On 8/10/21 9:18 PM, Philippe Mathieu-Daudé wrote: > On 8/3/21 12:22 AM, Ahmed Abouzied wrote: >> Removes the hard-coded values in setUp(). Class inheriting from >> avocado_qemu.LinuxTest can overwrite the default smp and memo

Re: [PATCH qemu 1/1] docs: how to use gdb with unix sockets

2021-08-10 Thread Philippe Mathieu-Daudé
Yay! Posting from sr.ht works \o/ On 8/10/21 6:04 PM, ~archi42 wrote: > From: Sebastian Meyer > > Signed-off-by: Sebastian Meyer > --- > docs/system/gdb.rst | 24 +++- > 1 file changed, 23 insertions(+), 1 deletion(-) > > diff --git a/docs/system/gdb.rst b/docs/system/gdb.

Re: [PATCH-for-6.2] tests/acceptance: Allow overwrite smp and memory

2021-08-10 Thread Philippe Mathieu-Daudé
On 8/3/21 12:22 AM, Ahmed Abouzied wrote: > Removes the hard-coded values in setUp(). Class inheriting from > avocado_qemu.LinuxTest can overwrite the default smp and memory instead. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/453 > Signed-off-by: Ahmed Abouzied > --- > tests/acc

Re: [PATCH v14] qapi: introduce 'query-x86-cpuid' QMP command.

2021-08-10 Thread Philippe Mathieu-Daudé
On 8/10/21 8:51 AM, Valeriy Vdovin wrote: > From: Valeriy Vdovin > > Introducing new QMP command 'query-x86-cpuid'. This command can be used to > get virtualized cpu model info generated by QEMU during VM initialization in > the form of cpuid representation. > > Diving into more details about vi

Re: [PATCH v12] qapi: introduce 'query-x86-cpuid' QMP command.

2021-08-10 Thread Eduardo Habkost
On Sat, Aug 07, 2021 at 04:22:42PM +0200, Markus Armbruster wrote: > Is this intended to be a stable interface? Interfaces intended just for > debugging usually aren't. I don't think we need to make it a stable interface, but I won't mind if we declare it stable. > > Eduardo, what's your take o

Re: [PATCH v14] qapi: introduce 'query-x86-cpuid' QMP command.

2021-08-10 Thread Eduardo Habkost
On Tue, Aug 10, 2021 at 09:51:31AM +0300, Valeriy Vdovin wrote: > From: Valeriy Vdovin > > Introducing new QMP command 'query-x86-cpuid'. This command can be used to > get virtualized cpu model info generated by QEMU during VM initialization in > the form of cpuid representation. > > Diving into

Re: [PATCH for 6.2 16/49] bsd-user: elfload: simplify bswap a bit.

2021-08-10 Thread Richard Henderson
On 8/7/21 11:42 AM, Warner Losh wrote: @@ -367,9 +383,7 @@ static abi_ulong load_elf_interp(struct elfhdr *interp_elf_ex, last_bss = 0; error = 0; -#ifdef BSWAP_NEEDED bswap_ehdr(interp_elf_ex); -#endif /* First of all, some simple consistency checks */ if ((int

Re: [PATCH v2] fsl-imx6ul: Instantiate SAI1/2/3 and ASRC as unimplemented devices

2021-08-10 Thread Guenter Roeck
On 8/10/21 9:34 AM, Philippe Mathieu-Daudé wrote: On 8/10/21 6:03 PM, Guenter Roeck wrote: Instantiate SAI1/2/3 and ASRC as unimplemented devices to avoid random Linux kernel crashes, such as Unhandled fault: external abort on non-linefetch (0x808) at 0xd1580010^M pgd = (ptrval)^M [d1580010] *p

Re: [CXL volatile MEM] - Qemu command to turn on HMAT and NUMA fails with assertion

2021-08-10 Thread Ben Widawsky
Thanks Dave. Samarth, Easiest is to just use our run_qemu and figure out the diffs (--cmdline will print the qemu commandline): https://github.com/pmem/run_qemu If you're not able to figure it out after that, please let me know. On 21-08-10 17:38:16, Samarth Saxena wrote: > Thanks Dave, > > Th

Re: [PATCH for 6.2 49/49] bsd-user: Add '-0 argv0' option to bsd-user/main.c

2021-08-10 Thread Richard Henderson
On 8/7/21 11:42 AM, Warner Losh wrote: From: Colin Percival Previously it was impossible to emulate a program with a file name different from its argv[0]. With this change, you can run qemu -0 fakename realname args which runs the program "realname" with an argv of "fakename args". Signed

Re: [PATCH for 6.2 48/49] bsd-user: Implement cpu_copy() helper routine

2021-08-10 Thread Richard Henderson
On 8/7/21 11:42 AM, Warner Losh wrote: From: Warner Losh cpu_copy shouldbe called when processes are creating new threads. It copies the current state of the CPU to a new cpu state needed for the new thread. Signed-off-by: Stacey Son Signed-off-by: Warner Losh Signed-off-by: Justin Hibbits ---

Re: [PATCH for 6.2 45/49] bsd-user: Make guest_base an unsigned long

2021-08-10 Thread Warner Losh
On Tue, Aug 10, 2021 at 11:58 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/7/21 11:42 AM, Warner Losh wrote: > > From: Warner Losh > > > > Make the guest_base a plan, uneigned long rather than a uintptr_t. It > > isn't really a pointer. > > NACK: 5ca870b9f6c. It most certai

Re: [PATCH for 6.2 47/49] bsd-user: Implement interlock for atomic operations

2021-08-10 Thread Richard Henderson
On 8/7/21 11:42 AM, Warner Losh wrote: From: Warner Losh Implement the internlock in fork_start() and fork_end() to properly cope with atomic operations and to safely keep state for parent and child processes. Signed-off-by: Stacey Son Signed-off-by: Warner Losh --- bsd-user/main.c | 23 +

Re: [PATCH for 6.2 46/49] bsd-user: move qemu_log to later in the file

2021-08-10 Thread Richard Henderson
On 8/7/21 11:42 AM, Warner Losh wrote: From: Warner Losh Signed-off-by: Warner Losh --- bsd-user/main.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) Acked-by: Richard Henderson r~

Re: [PATCH for 6.2 45/49] bsd-user: Make guest_base an unsigned long

2021-08-10 Thread Richard Henderson
On 8/7/21 11:42 AM, Warner Losh wrote: From: Warner Losh Make the guest_base a plan, uneigned long rather than a uintptr_t. It isn't really a pointer. NACK: 5ca870b9f6c. It most certainly is a host pointer. r~

Re: [PATCH] vl: fix machine option containing underscores

2021-08-10 Thread Paolo Bonzini
On 10/08/21 15:12, Jean-Philippe Brucker wrote: My first take was renaming default_bus_bypass_iommu, since it's the only machine option with underscores, We should do that, since the underscore variant still works and the result is a simple one-line patch. Paolo but then we'd want to rena

[PATCH] fsl-imx7: Instantiate SAI1/2/3 as unimplemented devices

2021-08-10 Thread Guenter Roeck
Instantiate SAI1/2/3 as unimplemented devices to avoid Linux kernel crashes such as the following. Unhandled fault: external abort on non-linefetch (0x808) at 0xd19b pgd = (ptrval) [d19b] *pgd=82711811, *pte=308a0653, *ppte=308a0453 Internal error: : 808 [#1] SMP ARM Modules linked in: CPU

Re: [PATCH for 6.2 44/49] bsd-user: Refactor load_elf_sections and is_target_elf_binary

2021-08-10 Thread Richard Henderson
On 8/7/21 11:42 AM, Warner Losh wrote: @@ -332,86 +329,25 @@ static abi_ulong load_elf_interp(struct elfhdr *interp_elf_ex, */ error = target_mmap(0, INTERP_MAP_SIZE, PROT_NONE, MAP_PRIVATE | MAP_ANON, -1, 0); -if (error == -1) { +if (rbase

Re: [PATCH v3 08/10] virtiofsd: Add inodes_by_handle hash table

2021-08-10 Thread Vivek Goyal
On Tue, Aug 10, 2021 at 04:13:44PM +0200, Hanna Reitz wrote: > On 10.08.21 16:07, Vivek Goyal wrote: > > On Mon, Aug 09, 2021 at 06:47:18PM +0200, Hanna Reitz wrote: > > > On 09.08.21 18:10, Vivek Goyal wrote: > > > > On Fri, Jul 30, 2021 at 05:01:32PM +0200, Max Reitz wrote: > > > > > Currently, l

RE: [CXL volatile MEM] - Qemu command to turn on HMAT and NUMA fails with assertion

2021-08-10 Thread Samarth Saxena
Thanks Dave, The Qemu version is qemu-6.0.50. I am trying to capture the stack and will place it ASAP. Regards, Samarth -Original Message- From: Dr. David Alan Gilbert Sent: Tuesday, August 10, 2021 4:58 PM To: Samarth Saxena ; ben.widaw...@intel.com Cc: qemu-devel@nongnu.org Subject

Re: [PATCH] build: remove redundant 'check-build' make target

2021-08-10 Thread Willian Rampazzo
On Tue, Aug 10, 2021 at 1:44 PM Daniel P. Berrangé wrote: > > The 'check-build' make target was added as a way to build all the unit > test binaries, since the standard 'all' target would not trigger this. > > Since the switch to meson, however, 'all' will now include the 'test' > binaries. As a r

Re: [PATCH for 6.2 43/49] bsd-user: elfload.c style catch up patch

2021-08-10 Thread Richard Henderson
On 8/7/21 11:42 AM, Warner Losh wrote: From: Warner Losh Various style fixes to elfload.c that were too painful to make earlier in this series. Signed-off-by: Warner Losh Sponsored by: Netflix --- bsd-user/elfload.c | 212 ++--- 1 file chang

Re: [PATCH for 6.2 42/49] bsd-user: add stubbed out core dump support

2021-08-10 Thread Richard Henderson
On 8/7/21 11:42 AM, Warner Losh wrote: From: Warner Losh Add a stubbed-out version of the bsd-user fork's core dump support. This allows elfload.c to be almost the same between what's upstream and what's in qemu-project upstream w/o the burden of reviewing the core dump support. Signed-off-by:

[PATCH qemu 0/1] Document how to use gdbserver with unix sockets

2021-08-10 Thread ~archi42
I had some trouble with gdb over unix sockets, and Peter was so nice to help me out with it on IRC. This adds some docs for that, so others might have less trouble: < pm215> yeah, that would be good Feel free to adjust/rephrase/rearrange the patch :) Sebastian Meyer (1): docs: how to use gdb w

[PATCH qemu 1/1] docs: how to use gdb with unix sockets

2021-08-10 Thread ~archi42
From: Sebastian Meyer Signed-off-by: Sebastian Meyer --- docs/system/gdb.rst | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/docs/system/gdb.rst b/docs/system/gdb.rst index 144d083df3..2ff4d6aab5 100644 --- a/docs/system/gdb.rst +++ b/docs/system/gdb

Re: [PATCH v3 06/13] python/aqmp-tui: Added type annotations for aqmp-tui

2021-08-10 Thread Niteesh G. S.
On Fri, Aug 6, 2021 at 1:26 AM John Snow wrote: > > > On Fri, Jul 30, 2021 at 4:19 PM G S Niteesh Babu > wrote: > >> This patch adds type annotations for aqmp-tui using >> the mypy library. >> >> > Awesome, thanks for taking a swing at this. Looks like it wasn't as bad as > I was fearing. > > >>

Re: [PATCH V6 19/27] vfio-pci: cpr part 1 (fd and dma)

2021-08-10 Thread Alex Williamson
On Fri, 6 Aug 2021 14:43:53 -0700 Steve Sistare wrote: > Enable vfio-pci devices to be saved and restored across an exec restart > of qemu. > > At vfio creation time, save the value of vfio container, group, and device > descriptors in cpr state. > > In cpr-save and cpr-exec, suspend the use o

Re: [PATCH V6 18/27] vfio-pci: refactor for cpr

2021-08-10 Thread Alex Williamson
On Fri, 6 Aug 2021 14:43:52 -0700 Steve Sistare wrote: > Export vfio_address_spaces and vfio_listener_skipped_section. > Add optional name arg to vfio_add_kvm_msi_virq. > Refactor vector use into a helper vfio_vector_init. > All for use by cpr in a subsequent patch. No functional change. Why i

Re: [PATCH for 6.2 41/49] bsd-user: Add target_os_user.h to capture the user/kernel structures

2021-08-10 Thread Richard Henderson
On 8/7/21 11:42 AM, Warner Losh wrote: From: Warner Losh This file evolved over the years to capture the user/kernel interfaces, including those that changed over time. Signed-off-by: Stacey Son Signed-off-by: Michal Meloun Signed-off-by: Warner Losh --- bsd-user/freebsd/target_os_user.h | 42

Re: [PATCH for 6.2 40/49] bsd-user: Add target_arch_reg to describe a target's register set

2021-08-10 Thread Richard Henderson
On 8/7/21 11:42 AM, Warner Losh wrote: From: Warner Losh target_reg_t is the normal register. target_fpreg_t is the floating point registers. target_copy_regs copies the registers out of CPU context for things like core dumps. Signed-off-by: Stacey Son Signed-off-by: Warner Losh --- bsd-user/

[PATCH] build: remove redundant 'check-build' make target

2021-08-10 Thread Daniel P . Berrangé
The 'check-build' make target was added as a way to build all the unit test binaries, since the standard 'all' target would not trigger this. Since the switch to meson, however, 'all' will now include the 'test' binaries. As a result, 'check-build' is a no-op: $ make all check-build ..snip

Re: [PATCH v2] fsl-imx6ul: Instantiate SAI1/2/3 and ASRC as unimplemented devices

2021-08-10 Thread Philippe Mathieu-Daudé
On 8/10/21 6:03 PM, Guenter Roeck wrote: > Instantiate SAI1/2/3 and ASRC as unimplemented devices to avoid random > Linux kernel crashes, such as > > Unhandled fault: external abort on non-linefetch (0x808) at 0xd1580010^M > pgd = (ptrval)^M > [d1580010] *pgd=8231b811, *pte=02034653, *ppte=0203445

Re: [PATCH for 6.2 39/49] bsd-user: Need to reset CPU after creation.

2021-08-10 Thread Richard Henderson
On 8/7/21 11:42 AM, Warner Losh wrote: From: Warner Losh Signed-off-by: Warner Losh --- bsd-user/main.c | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Richard Henderson Slightly amusing that the line was removed in patch 1, because it was ifdefed. r~

Re: [PATCH for 6.2 38/49] bsd-user: Update mapping to handle reserved and starting conditions

2021-08-10 Thread Richard Henderson
On 8/7/21 11:42 AM, Warner Losh wrote: From: Warner Losh Update the reserved base based on what platform we're on, as well as the start of the mmap range. Update routines that find va ranges to interact with the reserved ranges as well as properly align the mapping (this is especially important

Re: [PATCH for 6.2 37/49] bsd-user: update debugging in mmap.c

2021-08-10 Thread Richard Henderson
On 8/7/21 11:42 AM, Warner Losh wrote: From: Warner Losh Update the debugging code for new features and different targets. Signed-off-by: Mikaël Urankar Signed-off-by: Sean Bruno Signed-off-by: Kyle Evans Signed-off-by: Warner Losh --- bsd-user/mmap.c | 49 ++--

[PATCH v2] fsl-imx6ul: Instantiate SAI1/2/3 and ASRC as unimplemented devices

2021-08-10 Thread Guenter Roeck
Instantiate SAI1/2/3 and ASRC as unimplemented devices to avoid random Linux kernel crashes, such as Unhandled fault: external abort on non-linefetch (0x808) at 0xd1580010^M pgd = (ptrval)^M [d1580010] *pgd=8231b811, *pte=02034653, *ppte=02034453^M Internal error: : 808 [#1] SMP ARM^M ... [] (regm

Re: [PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-08-10 Thread Vivek Goyal
On Tue, Aug 10, 2021 at 05:26:15PM +0200, Hanna Reitz wrote: > On 10.08.21 17:23, Vivek Goyal wrote: > > On Tue, Aug 10, 2021 at 10:32:55AM +0200, Hanna Reitz wrote: > > > On 09.08.21 20:41, Vivek Goyal wrote: > > > > On Fri, Jul 30, 2021 at 05:01:33PM +0200, Max Reitz wrote: > > > > > When the ino

Re: [PATCH v2] MAINTAINERS: Name and email address change

2021-08-10 Thread Peter Maydell
On Tue, 10 Aug 2021 at 15:06, Hanna Reitz wrote: > > I have changed my name and email address. Update the MAINTAINERS file > to match, and .mailmap in case anyone wants to send me an email because > of some past commit I authored. (As suggested by Philippe, I put the > .mailmap line into the "pr

Re: [PULL ppc] powernv queue

2021-08-10 Thread Peter Maydell
: > >> > >> Update version for v6.1.0-rc2 release (2021-08-04 16:56:14 +0100) > >> > >> are available in the Git repository at: > >> > >> https://github.com/legoater/qemu/ tags/pull-powernv-20210810 > >> > >> for you

Re: [PULL ppc] powernv queue

2021-08-10 Thread Philippe Mathieu-Daudé
gt; are available in the Git repository at: >> >> https://github.com/legoater/qemu/ tags/pull-powernv-20210810 >> >> for you to fetch changes up to 91a6b62df830d51f2b6b2ea00b3c92231d0ba9dc: >> >>

Re: [PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-08-10 Thread Hanna Reitz
On 10.08.21 17:23, Vivek Goyal wrote: On Tue, Aug 10, 2021 at 10:32:55AM +0200, Hanna Reitz wrote: On 09.08.21 20:41, Vivek Goyal wrote: On Fri, Jul 30, 2021 at 05:01:33PM +0200, Max Reitz wrote: When the inode_file_handles option is set, try to generate a file handle for new inodes instead of

Re: [PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-08-10 Thread Vivek Goyal
On Tue, Aug 10, 2021 at 10:32:55AM +0200, Hanna Reitz wrote: > On 09.08.21 20:41, Vivek Goyal wrote: > > On Fri, Jul 30, 2021 at 05:01:33PM +0200, Max Reitz wrote: > > > When the inode_file_handles option is set, try to generate a file handle > > > for new inodes instead of opening an O_PATH FD. >

Re: [PATCH v7 20/33] block/block-copy: make setting progress optional

2021-08-10 Thread Hanna Reitz
On 04.08.21 11:38, Vladimir Sementsov-Ogievskiy wrote: Now block-copy will crash if user don't set progress meter by block_copy_set_progress_meter(). copy-before-write filter will be used in separate of backup job, and it doesn't want any progress meter (for now). So, allow not setting it. Signe

Re: [PATCH v2 20/33] block/block-copy: make setting progress optional

2021-08-10 Thread Hanna Reitz
On 20.05.21 16:21, Vladimir Sementsov-Ogievskiy wrote: Now block-copy will crash if user don't set progress meter by block_copy_set_progress_meter(). copy-before-write filter will be used in separate of backup job, and it doesn't want any progress meter (for now). So, allow not setting it. Signe

Re: [PATCH] vl: fix machine option containing underscores

2021-08-10 Thread Philippe Mathieu-Daudé
+Paolo/Markus On 8/10/21 3:12 PM, Jean-Philippe Brucker wrote: > Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), > keyval_dashify() replaces all underscores with dashes in machine > options. As a result the machine option "default_bus_bypass_iommu", > which was introduced in the sam

  1   2   3   >