On 8/3/21 12:22 AM, Ahmed Abouzied wrote:
> Removes the hard-coded values in setUp(). Class inheriting from
> avocado_qemu.LinuxTest can overwrite the default smp and memory instead.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/453
> Signed-off-by: Ahmed Abouzied <em...@aabouzied.com>
> ---
> tests/acceptance/avocado_qemu/__init__.py | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/acceptance/avocado_qemu/__init__.py
> b/tests/acceptance/avocado_qemu/__init__.py
> index 2c4fef3e14..2639b89c84 100644
> --- a/tests/acceptance/avocado_qemu/__init__.py
> +++ b/tests/acceptance/avocado_qemu/__init__.py
> @@ -441,6 +441,8 @@ class LinuxTest(Test, LinuxSSHMixIn):
> distro = None
> username = 'root'
> password = 'password'
> + smp = '2'
> + memory = '1024'
>
> def _set_distro(self):
> distro_name = self.params.get(
> @@ -471,8 +473,8 @@ def _set_distro(self):
> def setUp(self, ssh_pubkey=None, network_device_type='virtio-net'):
> super(LinuxTest, self).setUp()
> self._set_distro()
> - self.vm.add_args('-smp', '2')
I don't understand why we use 2 as default value, but this is unrelated
to this patch, so:
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> - self.vm.add_args('-m', '1024')
> + self.vm.add_args('-smp', self.smp)
> + self.vm.add_args('-m', self.memory)
> # The following network device allows for SSH connections
> self.vm.add_args('-netdev', 'user,id=vnet,hostfwd=:127.0.0.1:0-:22',
> '-device', '%s,netdev=vnet' % network_device_type)
>
