On 8/7/21 11:42 AM, Warner Losh wrote:
From: Warner Losh<i...@freebsd.org>

target_reg_t is the normal register. target_fpreg_t is the floating
point registers. target_copy_regs copies the registers out of CPU
context for things like core dumps.

Signed-off-by: Stacey Son<s...@freebsd.org>
Signed-off-by: Warner Losh<i...@bsdimp.com>
---
  bsd-user/i386/target_arch_reg.h   | 82 +++++++++++++++++++++++++++
  bsd-user/x86_64/target_arch_reg.h | 92 +++++++++++++++++++++++++++++++
  2 files changed, 174 insertions(+)
  create mode 100644 bsd-user/i386/target_arch_reg.h
  create mode 100644 bsd-user/x86_64/target_arch_reg.h

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

While this mirrors what linux-user does, I've wondered if this wasn't just pointless copying. If a bit of code knows enough about a target to fill in its core dump, why wouldn't it just copy the data straight from CPUArchState instead of using these intermediaries?


r~

Reply via email to