Re: [PATCH] Makefile: ignore long options

2021-07-23 Thread Alexey Neyman
Patch ping... On 7/21/21 9:05 PM, Alexey Neyman wrote: When searching for options like -n in MAKEFLAGS, current code may result in a false positive match when make is invoked with long options like --no-print-directory. This has been observed with certain versions of host make (e.g. 3.82) while

Re: Prefetches in buffer_zero_*

2021-07-23 Thread Joe Mario
On Thu, Jul 22, 2021 at 3:14 PM Dr. David Alan Gilbert wrote: > * Richard Henderson (richard.hender...@linaro.org) wrote: > > On 7/22/21 12:02 AM, Dr. David Alan Gilbert wrote: > > > Hi Richard, > > >I think you were the last person to fiddle with the prefetching > > > in buffer_zero_avx2 and

Re: [PATCH 00/16] Various error handling fixes and cleanups

2021-07-23 Thread Michael S. Tsirkin
On Tue, Jul 20, 2021 at 02:53:52PM +0200, Markus Armbruster wrote: > I doubt the fixes are 6.1 material at this late stage. If you > disagree, let me know. > > Cc: Alex Williamson > Cc: Aravinda Prasad > Cc: Cornelia Huck > Cc: Daniel P. Berrangé > Cc: David Gibson > Cc: Dr. David Alan Gilbe

Re: [PATCH v2 0/9] memory: Sanity checks memory transaction when releasing BQL

2021-07-23 Thread Peter Xu
On Fri, Jul 23, 2021 at 03:34:35PM -0400, Peter Xu wrote: > This is v2 of the series. It was actually got forgotten for months until it > was used to identify another potential issue of bql usage here (besides it > could still be helpful when debugging a previous kvm dirty ring issue in that > ser

Re: [PATCH resend v2 1/5] tpm: mark correct memory region range dirty when clearing RAM

2021-07-23 Thread Peter Xu
On Fri, Jul 23, 2021 at 09:15:43PM +0200, David Hildenbrand wrote: > On 23.07.21 16:52, Peter Xu wrote: > > On Tue, Jul 20, 2021 at 03:03:00PM +0200, David Hildenbrand wrote: > > > @@ -30,11 +30,13 @@ void tpm_ppi_reset(TPMPPI *tpmppi) > > > guest_phys_blocks_init(&guest_phys_blocks); > >

Re: [PATCH resend v2 5/5] softmmu/memory_mapping: optimize for RamDiscardManager sections

2021-07-23 Thread Peter Xu
On Fri, Jul 23, 2021 at 08:56:54PM +0200, David Hildenbrand wrote: > > > > As I've asked this question previously elsewhere, it's more or less also > > related to the design decision of having virtio-mem being able to sparsely > > plugged in such a small granularity rather than making the plug/unp

Re: [PATCH v2 0/6] migration/ram: Optimize for virtio-mem via RamDiscardManager

2021-07-23 Thread Peter Xu
On Fri, Jul 23, 2021 at 08:41:40PM +0200, David Hildenbrand wrote: > On 23.07.21 18:12, Peter Xu wrote: > > On Thu, Jul 22, 2021 at 01:43:41PM +0200, David Hildenbrand wrote: > > > > > a) In precopy code, always clearing all dirty bits from the bitmap > > > > > that > > > > > correspond to di

Re: [PATCH v2 5/6] migration/postcopy: Handle RAMBlocks with a RamDiscardManager on the destination

2021-07-23 Thread Peter Xu
On Fri, Jul 23, 2021 at 09:01:42PM +0200, David Hildenbrand wrote: > It can happen in corner cases and is valid: with the current virtio-mem > spec, guests are allowed to read unplugged memory. This will, for example, > happen on older Linux guests when reading /proc/kcore or (with even older > gue

Re: [PATCH v2] mips/tlb_helper: Add support for 'info tlb' cmd

2021-07-23 Thread Philippe Mathieu-Daudé
Hi, On 7/23/21 11:22 AM, Arkadiy wrote: > From: NDNF > > This adds hmp 'info tlb' command support for the mips platform. > 1k pages are not supported. > > Signed-off-by: Ivanov Arkady > --- > hmp-commands-info.hx | 3 ++- > target/mips/cpu.h| 3 +++ > target/mips/meson.build |

[PATCH v2 3/3] target/arm: Add sve-default-vector-length cpu property

2021-07-23 Thread Richard Henderson
Mirror the behavour of /proc/sys/abi/sve_default_vector_length under the real linux kernel. We have no way of passing along a real default across exec like the kernel can, but this is a decent way of adjusting the startup vector length of a process. Resolves: https://gitlab.com/qemu-project/qemu/

[PATCH v2 0/3] target/arm: Add sve-default-vector-length cpu property

2021-07-23 Thread Richard Henderson
This is intended to resolve #482. Changes for v2: * Split out length bounding fix to new patch. * Use byte units for sve-default-vector-length. * Support undocumented -1 "maximum". * Add documentation. r~ Richard Henderson (3): target/arm: Correctly bound length in sve_zcr_get_valid_

[PATCH v2 1/3] target/arm: Correctly bound length in sve_zcr_get_valid_len

2021-07-23 Thread Richard Henderson
Currently, our only caller is sve_zcr_len_for_el, which has already masked the length extracted from ZCR_ELx, so the masking done here is a nop. But we will shortly have uses from other locations, where the length will be unmasked. Saturate the length to ARM_MAX_VQ instead of truncating to the lo

[PATCH v2 2/3] target/arm: Export aarch64_sve_zcr_get_valid_len

2021-07-23 Thread Richard Henderson
Rename from sve_zcr_get_valid_len and make accessible from outside of helper.c. Signed-off-by: Richard Henderson --- target/arm/internals.h | 10 ++ target/arm/helper.c| 4 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/target/arm/internals.h b/target/arm/inter

[PATCH-for-6.1 v3] block/nvme: Fix VFIO_MAP_DMA failed: No space left on device

2021-07-23 Thread Philippe Mathieu-Daudé
When the NVMe block driver was introduced (see commit bdd6a90a9e5, January 2018), Linux VFIO_IOMMU_MAP_DMA ioctl was only returning -ENOMEM in case of error. The driver was correctly handling the error path to recycle its volatile IOVA mappings. To fix CVE-2019-3882, Linux commit 492855939bdb ("vf

Re: [PULL 0/3] SIGSEGV fixes

2021-07-23 Thread Philippe Mathieu-Daudé
On 7/23/21 9:10 PM, Richard Henderson wrote: > On 7/23/21 8:48 AM, Taylor Simpson wrote: >> I've added the riscv maintainers and Laurent and Alex to the CC list. >> >> Please advise on how to proceed.  Is this a known issue with riscv?  >> Should I try to debug the riscv target or remove the change

[PATCH v2 9/9] memory: Delay the transaction pop() until commit completed

2021-07-23 Thread Peter Xu
This should be functionally the same as before, but this allows the memory_region_transaction_depth to be non-zero during commit, which can help us to do sanity check on misuses. Since at it, fix an indentation issue on the bracket. Signed-off-by: Peter Xu --- softmmu/memory.c | 12 +---

[PATCH v2 7/9] cpus: Introduce qemu_mutex_unlock_iothread_prepare()

2021-07-23 Thread Peter Xu
The prepare function before unlocking BQL. There're only three places that can release the BQL: unlock(), cond_wait() or cond_timedwait(). Signed-off-by: Peter Xu --- softmmu/cpus.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/softmmu/cpus.c b/softmmu/cpus.c index 9131f77f87..6085

[PATCH v2 3/9] memory: Introduce memory_region_transaction_{push|pop}()

2021-07-23 Thread Peter Xu
memory_region_transaction_{begin|commit}() could be too big when finalizing a memory region. E.g., we should never attempt to update address space topology during the finalize() of a memory region. Provide helpers for further use. Signed-off-by: Peter Xu --- softmmu/memory.c | 14 -

[PATCH v2 8/9] memory: Assert on no ongoing memory transaction before release BQL

2021-07-23 Thread Peter Xu
Make sure we don't have any more ongoing memory transaction when releasing the BQL. This will trigger an abort if we misuse the QEMU memory model, e.g., when calling run_on_cpu() during a memory commit. Signed-off-by: Peter Xu --- include/exec/memory-internal.h | 1 + softmmu/cpus.c

[PATCH v2 6/9] cpus: Remove the mutex parameter from do_run_on_cpu()

2021-07-23 Thread Peter Xu
We must use the BQL for do_run_on_cpu() without much choice, it means the parameter is helpless. Remove it. Meanwhile use the newly introduced qemu_cond_wait_iothread() in do_run_on_cpu(). Signed-off-by: Peter Xu --- softmmu/cpus.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-)

[PATCH v2 0/9] memory: Sanity checks memory transaction when releasing BQL

2021-07-23 Thread Peter Xu
This is v2 of the series. It was actually got forgotten for months until it was used to identify another potential issue of bql usage here (besides it could still be helpful when debugging a previous kvm dirty ring issue in that series): https://lore.kernel.org/qemu-devel/ch0pr02mb7898bbd73d0f3f7

[PATCH v2 5/9] cpus: Use qemu_cond_wait_iothread() where proper

2021-07-23 Thread Peter Xu
The helper is introduced but we've still got plenty of places that are directly referencing the qemu_global_mutex itself. Spread the usage. Signed-off-by: Peter Xu --- softmmu/cpus.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/softmmu/cpus.c b/softmmu/cpus.c index

[PATCH v2 4/9] memory: Don't do topology update in memory finalize()

2021-07-23 Thread Peter Xu
Topology update could be wrongly triggered in memory region finalize() if there's bug somewhere else. It'll be a very confusing stack when it happens (e.g., sending KVM ioctl within the RCU thread, and we'll observe it only until it fails!). Instead of that, we use the push()/pop() helper to avoi

[PATCH v2 2/9] cpus: Move do_run_on_cpu into softmmu/cpus.c

2021-07-23 Thread Peter Xu
It's only used by softmmu binaries not linux-user ones. Make it static and drop the definition in the header too. Signed-off-by: Peter Xu --- cpus-common.c | 25 - include/hw/core/cpu.h | 12 softmmu/cpus.c| 26 ++ 3 f

[PATCH v2 1/9] cpus: Export queue work related fields to cpu.h

2021-07-23 Thread Peter Xu
This patch has no functional change, but prepares for moving the function do_run_on_cpu() into softmmu/cpus.c. It does: 1. Move qemu_work_item into hw/core/cpu.h. 2. Export queue_work_on_cpu()/qemu_work_cond. All of them will be used by softmmu/cpus.c later. Signed-off-by: Peter Xu --- cp

Re: [PATCH resend v2 1/5] tpm: mark correct memory region range dirty when clearing RAM

2021-07-23 Thread David Hildenbrand
On 23.07.21 16:52, Peter Xu wrote: On Tue, Jul 20, 2021 at 03:03:00PM +0200, David Hildenbrand wrote: @@ -30,11 +30,13 @@ void tpm_ppi_reset(TPMPPI *tpmppi) guest_phys_blocks_init(&guest_phys_blocks); guest_phys_blocks_append(&guest_phys_blocks); QTAILQ_FOREACH(bloc

Re: [PULL 0/3] SIGSEGV fixes

2021-07-23 Thread Richard Henderson
On 7/23/21 8:48 AM, Taylor Simpson wrote: I've added the riscv maintainers and Laurent and Alex to the CC list. Please advise on how to proceed. Is this a known issue with riscv? Should I try to debug the riscv target or remove the change to linux-test.c from the pull request? Remove the l

Re: [PATCH v2 5/6] migration/postcopy: Handle RAMBlocks with a RamDiscardManager on the destination

2021-07-23 Thread David Hildenbrand
On 23.07.21 20:52, Peter Xu wrote: On Fri, Jul 23, 2021 at 08:36:32PM +0200, David Hildenbrand wrote: +static int postcopy_request_page(MigrationIncomingState *mis, RAMBlock *rb, + ram_addr_t start, uint64_t haddr) +{ +/* + * Discarded pages (via RamDiscar

Re: [PATCH resend v2 5/5] softmmu/memory_mapping: optimize for RamDiscardManager sections

2021-07-23 Thread David Hildenbrand
As I've asked this question previously elsewhere, it's more or less also related to the design decision of having virtio-mem being able to sparsely plugged in such a small granularity rather than making the plug/unplug still continuous within GPA range (so we move page when unplug). Yes, in an

Re: [PATCH v2 5/6] migration/postcopy: Handle RAMBlocks with a RamDiscardManager on the destination

2021-07-23 Thread Peter Xu
On Fri, Jul 23, 2021 at 08:36:32PM +0200, David Hildenbrand wrote: > > > +static int postcopy_request_page(MigrationIncomingState *mis, RAMBlock > > > *rb, > > > + ram_addr_t start, uint64_t haddr) > > > +{ > > > +/* > > > + * Discarded pages (via RamDiscard

RE: [PULL 0/3] SIGSEGV fixes

2021-07-23 Thread Taylor Simpson
I've added the riscv maintainers and Laurent and Alex to the CC list. Please advise on how to proceed. Is this a known issue with riscv? Should I try to debug the riscv target or remove the change to linux-test.c from the pull request? Thanks, Taylor > -Original Message- > From: Pet

Re: [PATCH 2/2] target/arm: Add sve-default-vector-length cpu property

2021-07-23 Thread Richard Henderson
On 7/15/21 11:14 PM, Peter Maydell wrote: +#ifdef CONFIG_USER_ONLY +/* Mirror linux /proc/sys/abi/sve_default_vector_length. */ /proc/sys/abi/sve_default_vector_length wants a vector length in bytes, and it looks like we take a length in bits. I assume that's to match other places where the use

Re: [PATCH v2 0/6] migration/ram: Optimize for virtio-mem via RamDiscardManager

2021-07-23 Thread David Hildenbrand
On 23.07.21 18:12, Peter Xu wrote: On Thu, Jul 22, 2021 at 01:43:41PM +0200, David Hildenbrand wrote: a) In precopy code, always clearing all dirty bits from the bitmap that correspond to discarded range, whenever we update the dirty bitmap. This results in logically unplugged memory t

Re: [PATCH v2 5/6] migration/postcopy: Handle RAMBlocks with a RamDiscardManager on the destination

2021-07-23 Thread David Hildenbrand
+static int postcopy_request_page(MigrationIncomingState *mis, RAMBlock *rb, + ram_addr_t start, uint64_t haddr) +{ +/* + * Discarded pages (via RamDiscardManager) are never migrated. On unlikely + * access, place a zeropage, which will also set the rele

[PATCH v5 3/3] target/ppc: moved store_40x_sler to helper_regs.c

2021-07-23 Thread Lucas Mateus Castro (alqotel)
moved store_40x_sler from mmu_common.c to helper_regs.c as it is a function to store a value in a special purpose register, so moving it to a file focused in special register manipulation is more appropriate. Signed-off-by: Lucas Mateus Castro (alqotel) --- target/ppc/helper_regs.c | 12

[PATCH v5 1/3] target/ppc: divided mmu_helper.c in 2 files

2021-07-23 Thread Lucas Mateus Castro (alqotel)
Divided mmu_helper.c in 2 files, functions inside #ifdef CONFIG_SOFTMMU stayed in mmu_helper.c, other functions moved to mmu_common.c. Updated meson.build to compile mmu_common.c and only compile mmu_helper.c when CONFIG_TCG is set. Moved function declarations, #define and structs used by both file

[PATCH v5 0/3] target/ppc: MMU clean up

2021-07-23 Thread Lucas Mateus Castro (alqotel)
This patch series aims to clean up some of the code mmu_helper.c, including removing the #includes inside ifdef. This version of the patch has been rebased on the current ppc-for-6.2 branch as adapted accordingly. v4: Moved functions declarations from cpu.h to internal.h when possible. v5: Chang

[PATCH v5 2/3] target/ppc: moved ppc_store_sdr1 to mmu_common.c

2021-07-23 Thread Lucas Mateus Castro (alqotel)
ppc_store_sdr1 was at first in mmu_helper.c and was moved as part the patches to enable the disable-tcg option, now it's being moved back to a file that will be compiled with that option Signed-off-by: Lucas Mateus Castro (alqotel) --- target/ppc/cpu.c| 28 t

Re: [PULL for 6.1-rc1 00/28] doc, metadata, plugin and testing updates

2021-07-23 Thread Philippe Mathieu-Daudé
On 7/23/21 7:03 PM, Alex Bennée wrote: > I realised I'm on holiday next week so I thought I'd better send this now. > > The following changes since commit a146af86c8247f41b641783428b95ee71eb0e43f: > > Merge remote-tracking branch > 'remotes/kraxel/tags/vga-20

[PULL 28/28] gitlab-ci: Extract OpenSBI job rules to reusable section

2021-07-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé All jobs depending on 'docker-opensbi' job must use at most all the rules that triggers it. The simplest way to ensure that is to always use the same rules. Extract all the rules to a reusable section, and include this section (with the 'extends' keyword) in both 'doc

[PULL 18/28] contrib/gitdm: add a new interns group-map for GSoC/Outreachy work

2021-07-23 Thread Alex Bennée
It makes sense to put our various interns in a group so we can see the overall impact of GSoC and Outreachy on the project. Signed-off-by: Alex Bennée Reviewed-by: Mahmoud Mandour Cc: Ahmed Karaman Cc: César Belley Message-Id: <20210720232703.10650-19-alex.ben...@linaro.org> diff --git a/cont

[PULL 25/28] tests/tcg/configure.sh: add handling for assembler only builds

2021-07-23 Thread Alex Bennée
Up until this point we only handled local compilers or assumed we had everything in the container. This falls down when we are building QEMU inside the container. This special handling only affects tricore for now but I put it in a case just in case we add any other "special" targets. Setting CROS

[PULL 27/28] gitlab-ci: Remove the second superfluous macos task

2021-07-23 Thread Alex Bennée
From: Thomas Huth While there might have been bigger differnces between the -base and the -xcode images in the beginning, they almost vanished in the current builds, e.g. when comparing the output of the "configure" step after cleaning up the differences due to temporary path names, I only get:

[PULL 17/28] contrib/gitdm: add an explicit academic entry for BU

2021-07-23 Thread Alex Bennée
For some reason Alexander's contributions were not getting grouped from the plain "edu" mapping. Signed-off-by: Alex Bennée Reviewed-by: Alexander Bulekov Message-Id: <20210720232703.10650-18-alex.ben...@linaro.org> diff --git a/contrib/gitdm/group-map-academics b/contrib/gitdm/group-map-acade

[PULL 24/28] plugins: Fix physical address calculation for IO regions

2021-07-23 Thread Alex Bennée
From: Aaron Lindsay The address calculation for IO regions introduced by commit 787148bf928a54b5cc86f5b434f9399e9737679c Author: Aaron Lindsay plugins: Expose physical addresses instead of device offsets is not always accurate. Use the more correct MemoryRegionSection.offset_within_address

[PULL 16/28] contrib/gitdm: add group-map for Netflix

2021-07-23 Thread Alex Bennée
Warner confirmed he works for Netflix on IRC. Signed-off-by: Alex Bennée Reviewed-by: Warner Losh Message-Id: <20210720232703.10650-17-alex.ben...@linaro.org> diff --git a/contrib/gitdm/group-map-netflix b/contrib/gitdm/group-map-netflix new file mode 100644 index 00..468f95dcb2 --- /de

[PULL 22/28] plugins/cache: limited the scope of a mutex lock

2021-07-23 Thread Alex Bennée
From: Mahmoud Mandour It's not necessary to lock the address translation portion of the vcpu_mem_access callback. Signed-off-by: Mahmoud Mandour Signed-off-by: Alex Bennée Reviewed-by: Alex Bennée Message-Id: <20210714172151.8494-3-ma.mando...@gmail.com> Message-Id: <20210720232703.10650-23-a

[PULL 12/28] contrib/gitdm: add domain-map/group-map for Wind River

2021-07-23 Thread Alex Bennée
As per discussion at: http://patchwork.ozlabs.org/project/qemu-devel/patch/20201004180443.2035359-19-f4...@amsat.org/ I've added Bin's personal email as an individual contributor. Signed-off-by: Alex Bennée Acked-by: Bin Meng Cc: Ruimei Yan Cc: Xuzhou Cheng Message-Id: <20210720232703.1065

[PULL 15/28] contrib/gitdm: add domain-map for NVIDIA

2021-07-23 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Kirti Wankhede Cc: Yishai Hadas Message-Id: <20210720232703.10650-16-alex.ben...@linaro.org> diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index e42861cd11..2800d9f986 100644 --- a/contrib/gitdm/domain-map +++ b/contrib/gitdm/domain-map

[PULL 11/28] contrib/gitdm: add domain-map for Eldorado

2021-07-23 Thread Alex Bennée
Luis acked on IRC: #qemu@znc-oftc_2021-07-13.txt:[15:00:02] stsquad: "eldorado.org.br Eldorado" is fine Signed-off-by: Alex Bennée Acked-by: Luis Pires Message-Id: <20210720232703.10650-12-alex.ben...@linaro.org> diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index beeb24

[PULL 13/28] contrib/gitdm: un-ironically add a mapping for LWN

2021-07-23 Thread Alex Bennée
I think this mainly comes from kernel-doc stuff imported into the QEMU tree. Signed-off-by: Alex Bennée Cc: Jonathan Corbet Message-Id: <20210720232703.10650-14-alex.ben...@linaro.org> diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index 27b8fbdf8a..5ac8288716 100644 --- a/con

[PULL 14/28] contrib/gitdm: add domain-map for Crudebyte

2021-07-23 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Christian Schoenebeck Message-Id: <20210720232703.10650-15-alex.ben...@linaro.org> diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index 5ac8288716..e42861cd11 100644 --- a/contrib/gitdm/domain-map +++ b/contrib/gitdm/domain-map @@ -9,6 +9

[PULL 08/28] contrib/gitdm: add a group mapping for robot scanners

2021-07-23 Thread Alex Bennée
This mostly affects Reported-by: tags Signed-off-by: Alex Bennée Message-Id: <20210720232703.10650-9-alex.ben...@linaro.org> diff --git a/contrib/gitdm/group-map-robots b/contrib/gitdm/group-map-robots new file mode 100644 index 00..ffd956c2eb --- /dev/null +++ b/contrib/gitdm/group-map-

[PULL 26/28] gitlab: enable a very minimal build with the tricore container

2021-07-23 Thread Alex Bennée
Rather than base of the shared Debian 10 container which would require us to bring in even more dependencies just bring in what is needed for building tricore-softmmu in GitLab. We don't even remove the container from the DOCKER_PARTIAL_IMAGES lest we cause more confusion. Signed-off-by: Alex Benn

[PULL 23/28] plugins/cache: Fixed "function decl. is not a prototype" warnings

2021-07-23 Thread Alex Bennée
From: Mahmoud Mandour Signed-off-by: Mahmoud Mandour Signed-off-by: Alex Bennée Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210714172151.8494-7-ma.mando...@gmail.com> Message-Id: <20210720232703.10650-24-alex.ben...@linaro.org> diff --git a/contrib/plugins/cac

[PULL 21/28] plugins/cache: Fixed a bug with destroying FIFO metadata

2021-07-23 Thread Alex Bennée
From: Mahmoud Mandour This manifests itself when associativity degree is greater than the number of sets and FIFO is used, otherwise it's also a memory leak whenever FIFO was used. Signed-off-by: Mahmoud Mandour Signed-off-by: Alex Bennée Reviewed-by: Alex Bennée Message-Id: <20210714172151.8

[PULL 07/28] contrib/gitdm: add domain-map for MontaVista

2021-07-23 Thread Alex Bennée
Signed-off-by: Alex Bennée Acked-by: Corey Minyard Message-Id: <20210720232703.10650-8-alex.ben...@linaro.org> diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index 0074da618f..efbbb15643 100644 --- a/contrib/gitdm/domain-map +++ b/contrib/gitdm/domain-map @@ -18,6 +18,7 @@ igal

[PULL 19/28] contrib/gitdm: add more individual contributor entries.

2021-07-23 Thread Alex Bennée
Also ensure Li's canonical gmail address is used. Signed-off-by: Alex Bennée Acked-by: Li Qiang Acked-by: Chetan Pant Acked-by: Akihiko Odaki Message-Id: <20210720232703.10650-20-alex.ben...@linaro.org> diff --git a/contrib/gitdm/aliases b/contrib/gitdm/aliases index c6ed215e68..4792413ce7 10

[PULL 20/28] tcg/plugins: implement a qemu_plugin_user_exit helper

2021-07-23 Thread Alex Bennée
In user-mode emulation there is a small race between preexit_cleanup and exit_group() which means we may end up calling instrumented instructions before the kernel reaps child threads. To solve this we implement a new helper which ensures the callbacks are flushed along with any translations before

[PULL 02/28] docs: collect the disparate device emulation docs into one section

2021-07-23 Thread Alex Bennée
While we are at it add a brief preamble that explains some of the common concepts in QEMU's device emulation which will hopefully lead to less confusing about our dizzying command line options. Signed-off-by: Alex Bennée Reviewed-by: Markus Armbruster Cc: Paolo Bonzini Cc: Daniel P. Berrangé C

[PULL 06/28] .mailmap: fix up some broken commit authors

2021-07-23 Thread Alex Bennée
Fixes: 49a6f3bffb ("target/arm: Correct the encoding of MDCCSR_EL0 and DBGDSCRint") Fixes: 5a07192a04 ("target/i386: Fix handling of k_gs_base register in 32-bit mode in gdbstub") Signed-off-by: Alex Bennée Cc: Nick Hudson Cc: Marek Dolata Message-Id: <20210720232703.10650-7-alex.ben...@linaro

[PULL 05/28] contrib/gitdm: add some new aliases to fix up commits

2021-07-23 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Cc: Yuval Shaia Message-Id: <20210720232703.10650-6-alex.ben...@linaro.org> diff --git a/contrib/gitdm/aliases b/contrib/gitdm/aliases index c1e744312f..c6ed215e68 100644 --- a/contrib/gitdm/aliases +++ b/contrib/gitdm/aliases @@ -31,6 +

[PULL 10/28] contrib/gitdm: add domain-map/group-map mappings for Samsung

2021-07-23 Thread Alex Bennée
Minwoo's work from their personal address are treated as personal contributions. Signed-off-by: Alex Bennée Acked-by: Klaus Jensen Cc: Gollu Appalanaidu Cc: Minwoo Im Message-Id: <20210720232703.10650-11-alex.ben...@linaro.org> diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map

[PULL for 6.1-rc1 00/28] doc, metadata, plugin and testing updates

2021-07-23 Thread Alex Bennée
I realised I'm on holiday next week so I thought I'd better send this now. The following changes since commit a146af86c8247f41b641783428b95ee71eb0e43f: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20210723-pull-request' into staging (2021-07-23 12:16:12 +0100)

[PULL 04/28] configure: remove needless if leg

2021-07-23 Thread Alex Bennée
It was pointed out in review of the previous patch that the if leg isn't needed as the for loop will not enter on an empty $device_archs. Fixes: d1d5e9eefd ("configure: allow the selection of alternate config in the build") Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <

[PULL 03/28] docs: add a section on the generalities of vhost-user

2021-07-23 Thread Alex Bennée
While we do mention some of this stuff in the various daemons and manuals the subtleties of the socket and memory sharing are sometimes missed. This document attempts to give some background on vhost-user daemons in general terms. Signed-off-by: Alex Bennée Reviewed-by: Stefan Hajnoczi Message-I

[PULL 01/28] gitignore: Update with some filetypes

2021-07-23 Thread Alex Bennée
From: Viresh Kumar Update .gitignore to ignore .swp and .patch files. Signed-off-by: Viresh Kumar Signed-off-by: Alex Bennée Reviewed-by: Alex Bennée Message-Id: <79262dbe1f7888eb02e1911501eebafa6f2f6400.1616583806.git.viresh.ku...@linaro.org> Message-Id: <20210720232703.10650-2-alex.ben...@

[PULL 09/28] gitdm.config: sort the corporate GroupMap entries

2021-07-23 Thread Alex Bennée
Lets try and keep them that way. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210720232703.10650-10-alex.ben...@linaro.org> diff --git a/gitdm.config b/gitdm.config index 7378238c20..a3542d2fc7 100644 --- a/gitdm.config +++ b/gitdm.config @@ -28,15 +28,15 @@ Ema

Re: [PATCH v2] nbd/server: Add --selinux-label option

2021-07-23 Thread Daniel P . Berrangé
On Fri, Jul 23, 2021 at 06:18:55PM +0200, Kevin Wolf wrote: > Am 23.07.2021 um 12:33 hat Richard W.M. Jones geschrieben: > > Under SELinux, Unix domain sockets have two labels. One is on the > > disk and can be set with commands such as chcon(1). There is a > > different label stored in memory (c

Re: [PATCH v2 6/6] migration/ram: Handle RAMBlocks with a RamDiscardManager on background snapshots

2021-07-23 Thread Peter Xu
On Wed, Jul 21, 2021 at 11:27:59AM +0200, David Hildenbrand wrote: > We already don't ever migrate memory that corresponds to discarded ranges > as managed by a RamDiscardManager responsible for the mapped memory region > of the RAMBlock. > > virtio-mem uses this mechanism to logically unplug part

Re: [PATCH v2 2/6] virtio-mem: Implement replay_discarded RamDiscardManager callback

2021-07-23 Thread Peter Xu
On Wed, Jul 21, 2021 at 11:27:55AM +0200, David Hildenbrand wrote: > Implement it similar to the replay_populated callback. > > Signed-off-by: David Hildenbrand Acked-by: Peter Xu -- Peter Xu

Re: [PATCH v2] nbd/server: Add --selinux-label option

2021-07-23 Thread Richard W.M. Jones
On Fri, Jul 23, 2021 at 06:18:55PM +0200, Kevin Wolf wrote: > Am 23.07.2021 um 12:33 hat Richard W.M. Jones geschrieben: > > Under SELinux, Unix domain sockets have two labels. One is on the > > disk and can be set with commands such as chcon(1). There is a > > different label stored in memory (c

Re: [PATCH v2 4/6] virtio-mem: Drop precopy notifier

2021-07-23 Thread Peter Xu
On Wed, Jul 21, 2021 at 11:27:57AM +0200, David Hildenbrand wrote: > Migration code now properly handles RAMBlocks which are indirectly managed > by a RamDiscardManager. No need for manual handling via the free page > optimization interface, let's get rid of it. > > Acked-by: Michael S. Tsirkin >

Re: [PATCH v2 1/6] memory: Introduce replay_discarded callback for RamDiscardManager

2021-07-23 Thread Peter Xu
On Wed, Jul 21, 2021 at 11:27:54AM +0200, David Hildenbrand wrote: > Introduce replay_discarded callback similar to our existing > replay_populated callback, to be used my migration code to never migrate > discarded memory. > > Signed-off-by: David Hildenbrand Acked-by: Peter Xu -- Peter Xu

Re: [PATCH v2 5/6] migration/postcopy: Handle RAMBlocks with a RamDiscardManager on the destination

2021-07-23 Thread Peter Xu
On Wed, Jul 21, 2021 at 11:27:58AM +0200, David Hildenbrand wrote: > Currently, when someone (i.e., the VM) accesses discarded parts inside a > RAMBlock with a RamDiscardManager managing the corresponding mapped memory > region, postcopy will request migration of the corresponding page from the > s

Re: [PATCH v5 00/10] acpi: Error Record Serialization Table, ERST, support for QEMU

2021-07-23 Thread Eric DeVolder
Igor, Pending your responses to a few questions, I have v6 ready to go. Thanks, eric On 7/20/21 9:57 AM, Igor Mammedov wrote: On Wed, 30 Jun 2021 15:07:11 -0400 Eric DeVolder wrote: = I believe I have corrected for all feedback on v4, but with responses to certain

[PATCH for-6.1 5/6] hw/intc/armv7m_nvic: Correct size of ICSR.VECTPENDING

2021-07-23 Thread Peter Maydell
The VECTPENDING field in the ICSR is 9 bits wide, in bits [20:12] of the register. We were incorrectly masking it to 8 bits, so it would report the wrong value if the pending exception was greater than 256. Fix the bug. Signed-off-by: Peter Maydell --- hw/intc/armv7m_nvic.c | 2 +- 1 file chang

[PATCH for-6.1 3/6] target/arm: Report M-profile alignment faults correctly to the guest

2021-07-23 Thread Peter Maydell
For M-profile, we weren't reporting alignment faults triggered by the generic TCG code correctly to the guest. These get passed into arm_v7m_cpu_do_interrupt() as an EXCP_DATA_ABORT with an A-profile style exception.fsr value of 1. We didn't check for this, and so they fell through into the defau

[PATCH for-6.1 4/6] hw/intc/armv7m_nvic: ISCR.ISRPENDING is set for non-enabled pending interrupts

2021-07-23 Thread Peter Maydell
The ISCR.ISRPENDING bit is set when an external interrupt is pending. This is true whether that external interrupt is enabled or not. This means that we can't use 's->vectpending == 0' as a shortcut to "ISRPENDING is zero", because s->vectpending indicates only the highest priority pending enabled

[PATCH for-6.1 2/6] target/arm: Add missing 'return's after calling v7m_exception_taken()

2021-07-23 Thread Peter Maydell
In do_v7m_exception_exit(), we perform various checks as part of performing the exception return. If one of these checks fails, the architecture requires that we take an appropriate exception on the existing stackframe. We implement this by calling v7m_exception_taken() to set up to take the new

[PATCH for-6.1 0/6] arm: Fix a handful of M-profile bugs

2021-07-23 Thread Peter Maydell
This patchset fixes a handful of minor M-profile bugs: * The low 2 bits of SP should not be writeable (they are always 0) * Missing 'return' statements for some "tail chain to another exception after detecting an error during exception return" cases * Alignment faults were being incorrectly r

[PATCH for-6.1 1/6] target/arm: Enforce that M-profile SP low 2 bits are always zero

2021-07-23 Thread Peter Maydell
For M-profile, unlike A-profile, the low 2 bits of SP are defined to be RES0H, which is to say that they must be hardwired to zero so that guest attempts to write non-zero values to them are ignored. Implement this behaviour by masking out the low bits: * for writes to r13 by the gdbstub * for w

[PATCH for-6.1 6/6] hw/intc/armv7m_nvic: for v8.1M VECTPENDING hides S exceptions from NS

2021-07-23 Thread Peter Maydell
In Arm v8.1M the VECTPENDING field in the ICSR has new behaviour: if the register is accessed NonSecure and the highest priority pending enabled exception (that would be returned in the VECTPENDING field) targets Secure, then the VECTPENDING field must read 1 rather than the exception number of the

Re: [PATCH v2] nbd/server: Add --selinux-label option

2021-07-23 Thread Kevin Wolf
Am 23.07.2021 um 12:33 hat Richard W.M. Jones geschrieben: > Under SELinux, Unix domain sockets have two labels. One is on the > disk and can be set with commands such as chcon(1). There is a > different label stored in memory (called the process label). This can > only be set by the process cre

Re: [PATCH v2 0/6] migration/ram: Optimize for virtio-mem via RamDiscardManager

2021-07-23 Thread Peter Xu
On Thu, Jul 22, 2021 at 01:43:41PM +0200, David Hildenbrand wrote: > > > a) In precopy code, always clearing all dirty bits from the bitmap that > > > correspond to discarded range, whenever we update the dirty bitmap. > > > This > > > results in logically unplugged memory to never get mig

Re: [PULL 0/2] QAPI/QOM bugfix for QEMU 6.1

2021-07-23 Thread Paolo Bonzini
On 23/07/21 17:52, Peter Maydell wrote: On Fri, 23 Jul 2021 at 11:04, Paolo Bonzini wrote: The following changes since commit 143c2e0432859826c9e8d5b2baa307355f1a5332: Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2021-07-19' into staging (2021-07-19 19:06:05 +0100) are

Re: [PATCH 0/3] MAINTAINERS: "Host Memory Backends" and "Memory API" updates

2021-07-23 Thread Paolo Bonzini
On 23/07/21 12:05, David Hildenbrand wrote: Some maintainer and file updates for "Host Memory Backends" and "Memory API". David Hildenbrand (3): MAINTAINERS: Replace Eduardo as "Host Memory Backends" maintainer MAINTAINERS: Add Peter Xu and myself as co-maintainer of "Memory API" MAINTA

Re: [PULL 0/2] QAPI/QOM bugfix for QEMU 6.1

2021-07-23 Thread Peter Maydell
On Fri, 23 Jul 2021 at 11:04, Paolo Bonzini wrote: > > The following changes since commit 143c2e0432859826c9e8d5b2baa307355f1a5332: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2021-07-19' > into staging (2021-07-19 19:06:05 +0100) > > are available in the Git repository a

Re: [PATCH] nbd/server: Suppress Broken pipe errors on abrupt disconnection

2021-07-23 Thread Eric Blake
On Thu, Jul 22, 2021 at 11:45:52AM +0100, Richard W.M. Jones wrote: > $ rm -f /tmp/sock /tmp/pid > $ qemu-img create -f qcow2 /tmp/disk.qcow2 1M > $ qemu-nbd -t --format=qcow2 --socket=/tmp/sock --pid-file=/tmp/pid > /tmp/disk.qcow2 & > $ nbdsh -u 'nbd+unix:///?socket=/tmp/sock' -c 'h.get_size()'

Re: [PATCH v2 1/1] modules: Improve error message when module is not found

2021-07-23 Thread Jose R. Ziviani
On Fri, Jul 23, 2021 at 05:27:25PM +0200, Claudio Fontana wrote: > On 7/23/21 4:36 PM, Jose R. Ziviani wrote: > > On Fri, Jul 23, 2021 at 04:02:26PM +0200, Claudio Fontana wrote: > >> On 7/23/21 3:50 PM, Jose R. Ziviani wrote: > >>> On Fri, Jul 23, 2021 at 11:41:19AM +0200, Claudio Fontana wrote: >

Re: [PATCH resend v2 5/5] softmmu/memory_mapping: optimize for RamDiscardManager sections

2021-07-23 Thread Peter Xu
On Tue, Jul 20, 2021 at 03:03:04PM +0200, David Hildenbrand wrote: > virtio-mem logically plugs/unplugs memory within a sparse memory region > and notifies via the RamDiscardManager interface when parts become > plugged (populated) or unplugged (discarded). > > Currently, we end up (via the two us

Re: [PATCH v2 1/1] modules: Improve error message when module is not found

2021-07-23 Thread Claudio Fontana
On 7/23/21 4:36 PM, Jose R. Ziviani wrote: > On Fri, Jul 23, 2021 at 04:02:26PM +0200, Claudio Fontana wrote: >> On 7/23/21 3:50 PM, Jose R. Ziviani wrote: >>> On Fri, Jul 23, 2021 at 11:41:19AM +0200, Claudio Fontana wrote: On 7/23/21 12:09 AM, Jose R. Ziviani wrote: > When a module is no

Re: [PATCH resend v2 4/5] softmmu/memory_mapping: factor out adding physical memory ranges

2021-07-23 Thread Peter Xu
On Tue, Jul 20, 2021 at 03:03:03PM +0200, David Hildenbrand wrote: > Let's factor out adding a MemoryRegionSection to the list, to be reused in > RamDiscardManager context next. > > Cc: Marc-André Lureau > Cc: Paolo Bonzini > Cc: "Michael S. Tsirkin" > Cc: Eduardo Habkost > Cc: Alex Williamson

Re: [PATCH resend v2 3/5] softmmu/memory_mapping: never merge ranges accross memory regions

2021-07-23 Thread Peter Xu
On Tue, Jul 20, 2021 at 03:03:02PM +0200, David Hildenbrand wrote: > Let's make sure to not merge when different memory regions are involved. > Unlikely, but theoretically possible. > > Cc: Marc-André Lureau > Cc: Paolo Bonzini > Cc: "Michael S. Tsirkin" > Cc: Eduardo Habkost > Cc: Alex Willia

Re: virtio-gpu: Mapping blob resources

2021-07-23 Thread Antonio Caggiano
Awesome, thanks! I already cherry-picked that commit. :D I am experimenting with memory regions now. So, I created a ram subregion, did I use the right type for the task? I added it to the gpu hostmem at the offset specified by the map command. I enabled the subregion, and then I used subreg

Re: [PATCH resend v2 1/5] tpm: mark correct memory region range dirty when clearing RAM

2021-07-23 Thread Peter Xu
On Tue, Jul 20, 2021 at 03:03:00PM +0200, David Hildenbrand wrote: > @@ -30,11 +30,13 @@ void tpm_ppi_reset(TPMPPI *tpmppi) > guest_phys_blocks_init(&guest_phys_blocks); > guest_phys_blocks_append(&guest_phys_blocks); > QTAILQ_FOREACH(block, &guest_phys_blocks.head, next)

[PATCH 2/2] configure: Fix excessive error detection when handling --cross-cc-FOO

2021-07-23 Thread Greg Kurz
Passing a --cross-cc-cflags-* option with a value that contains a '=' causes configure to exit: $ ./configure --cross-cc-cflags-arm='-DFOO=bar' ERROR: Passed bad --cross-cc-FOO option This is an annoying limitation since '=' is frequently found in CFLAGS. This is caused by this line in the CC o

[PATCH 1/2] configure: Fix trivial typo in --cross-cc-cflags-FOO

2021-07-23 Thread Greg Kurz
The 'flags' wording is used in several places instead of 'cflags'. $ git grep cross-cc-flags configure: --cross-cc-cflags-*) cc_arch=${opt#--cross-cc-flags-}; cc_arch=${cc_arch%%=*} configure: --cross-cc-flags-ARCH= use compiler flags when building ARCH guest tests docs/devel/testing.rst:The

[PATCH 0/2] configure: Fixes for --cross-cc-FOO

2021-07-23 Thread Greg Kurz
This series fixes some issues I've hit while trying to compile TCG checks with a cross-compiler, as an alternative to using docker. This isn't a regression in QEMU 6.1: the issues have been around since they got merged in QEMU 3.0. Hence clearly QEMU 6.2 material. Greg Kurz (2): configure: Fix

Re: [PATCH v2 1/1] modules: Improve error message when module is not found

2021-07-23 Thread Jose R. Ziviani
On Fri, Jul 23, 2021 at 04:02:26PM +0200, Claudio Fontana wrote: > On 7/23/21 3:50 PM, Jose R. Ziviani wrote: > > On Fri, Jul 23, 2021 at 11:41:19AM +0200, Claudio Fontana wrote: > >> On 7/23/21 12:09 AM, Jose R. Ziviani wrote: > >>> When a module is not found, specially accelerators, QEMU displays

  1   2   3   >