Re: [RFC PATCH 8/8] target/i386: Move X86XSaveArea into TCG

2021-07-06 Thread Paolo Bonzini
Migration from KVM to TCG is broken anyway. The changing offsets do break migration of a KVM guest from Intel to AMD or vice versa, because of the difference in CPUID. That however is not changed by this patch. Paolo Il mer 7 lug 2021, 03:09 Richard Henderson ha scritto: > On 7/5/21 3:46 AM, Da

Re: [PATCH] Fix libdaxctl option

2021-07-06 Thread Thomas Huth
On 07/07/2021 08.31, Miroslav Rezanina wrote: For some reason, libdaxctl option setting was set to work in an opposite way (--enable-libdaxctl disabled it and vice versa). Fixing this so configuration works properly. Signed-off-by: Miroslav Rezanina --- configure | 4 ++-- 1 file changed, 2

[PATCH] Fix libdaxctl option

2021-07-06 Thread Miroslav Rezanina
For some reason, libdaxctl option setting was set to work in an opposite way (--enable-libdaxctl disabled it and vice versa). Fixing this so configuration works properly. Signed-off-by: Miroslav Rezanina --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config

[PATCH v1] block/raw-format: implement .bdrv_get_specific_info handler

2021-07-06 Thread Or Ozeri
When using the raw format, allow exposing specific info by the underlying storage. In particular, this will enable RBD images using the raw format to indicate a LUKS2 encrypted image in the output of qemu-img info. Signed-off-by: Or Ozeri --- block/raw-format.c | 7 +++ 1 file changed, 7 in

Re: pipe2 & configure script

2021-07-06 Thread Thomas Huth
On 07/07/2021 05.24, Richard Zak wrote: What conditions are required for "#define CONFIG_PIPE2" to be set in build/config-host.h? It prevents building for Haiku as pipe2() doesn't exist. I didn't see anything in the configure script regarding pipe2. I also updated my code to the latest in the r

Re: [PATCH v1 32/39] contrib/plugins: enable -Wall for building plugins

2021-07-06 Thread Thomas Huth
On 06/07/2021 16.58, Alex Bennée wrote: Lets spot the obvious errors. Signed-off-by: Alex Bennée --- contrib/plugins/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/plugins/Makefile b/contrib/plugins/Makefile index b9d7935e5e..17e6e2ec4f 100644 --- a/cont

Re: [PATCH v1 31/39] tcg/plugins: enable by default for TCG builds

2021-07-06 Thread Thomas Huth
On 06/07/2021 16.58, Alex Bennée wrote: Aside from a minor bloat to file size the ability to have TCG plugins has no real impact on performance unless a plugin is actively loaded. Even then the libempty.so plugin shows only a minor degradation in performance caused by the extra book keeping the T

[Bug 1888303] Re: Intermittent buggines with user mode emulation of x86-64 on aarch64

2021-07-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888303 Title: Intermitten

[Bug 1888417] Re: Latest QEMU git build on Arch linux causes PCI Passthrough host to hang on guest reboot.

2021-07-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888417 Title: Latest QEMU

[Bug 1888964] Re: Segfault using GTK display with dmabuf (iGVT-g) on Wayland

2021-07-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888964 Title: Segfault us

[Bug 1889421] Re: VVFAT is not writable from Windows NT 3.5, 3.51 and 4.0

2021-07-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1889421 Title: VVFAT is no

[Bug 1889033] Re: qemu-img permission denied on vmdk creation on CIFS share

2021-07-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1889033 Title: qemu-img pe

[Bug 1889945] Re: virtiofsd exits when iommu_platform is enabled after virtiofs driver is loaded

2021-07-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1889945 Title: virtiofsd e

[Bug 1888467] Re: qemu-img http convert bug

2021-07-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888467 Title: qemu-img ht

[Bug 1889943] Re: Improper TCP/IP packet splitting on e1000e/vmxnet3

2021-07-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1889943 Title: Improper TC

Re: [PATCH v1 30/39] configure: stop user enabling plugins on Windows for now

2021-07-06 Thread Thomas Huth
On 06/07/2021 16.58, Alex Bennée wrote: There are some patches on the list that enable plugins on Windows but they still need some changes to be ready: https://patchew.org/QEMU/20201013002806.1447-1-luoyongg...@gmail.com/ In the meantime lets stop the user from being able to configure the su

Re: [PATCH v1 29/39] configure: don't allow plugins to be enabled for a non-TCG build

2021-07-06 Thread Thomas Huth
On 06/07/2021 16.58, Alex Bennée wrote: Signed-off-by: Alex Bennée --- configure | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 650d9c0735..44a487e090 100755 --- a/configure +++ b/configure @@ -1098,6 +1098,7 @@ for opt do --enable-ca

[PATCH] tcg: Move tb_phys_invalidate_count to tb_ctx (#457)

2021-07-06 Thread Richard Henderson
We can call do_tb_phys_invalidate from an iocontext, which has no per-thread tcg_ctx. Move this to tb_ctx, which is global. The actual update still takes place with a lock held, so only an atomic set is required, not an atomic increment. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/457

Re: [PATCH] docs: Add '-device intel-iommu' entry

2021-07-06 Thread Jason Wang
在 2021/6/12 上午2:55, Peter Xu 写道: The parameters of intel-iommu device are non-trivial to understand. Add an entry for it so that people can reference to it when using. There're actually a few more options there, but I hide them explicitly because they shouldn't be used by normal QEMU users.

Re: [PATCH] docs/nvdimm: update doc

2021-07-06 Thread lizhij...@fujitsu.com
ping... On 11/06/2021 11:41, Li Zhijian wrote: > The prompt was updated since def835f0da ('hostmem: Don't report pmem > attribute if unsupported') > > Signed-off-by: Li Zhijian > --- > docs/nvdimm.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/docs/nvdimm.txt

pipe2 & configure script

2021-07-06 Thread Richard Zak
What conditions are required for "#define CONFIG_PIPE2" to be set in build/config-host.h? It prevents building for Haiku as pipe2() doesn't exist. I didn't see anything in the configure script regarding pipe2. I also updated my code to the latest in the repository and this issue just popped up. --

Re: [PATCH 2/2] tcg: Bake tb_destroy() into tcg_region_tree

2021-07-06 Thread Liren Wei
On 7/7/21 8:34 AM, Richard Henderson wrote: On 7/4/21 7:31 AM, Liren Wei wrote: -static gint tb_tc_cmp(gconstpointer ap, gconstpointer bp) +static gint tb_tc_cmp(gconstpointer ap, gconstpointer bp, gpointer _) Using _ here as the variable name isn't ideal.  I guess if this were c++ we would a

Re: [PATCH 1/2] qapi/run-state: Add a new shutdown cause 'migration-completed'

2021-07-06 Thread Kunkun Jiang
On 2021/7/6 18:27, Dr. David Alan Gilbert wrote: * Kunkun Jiang (jiangkun...@huawei.com) wrote: Hi Daniel, On 2021/7/5 20:48, Daniel P. Berrangé wrote: On Mon, Jul 05, 2021 at 08:36:52PM +0800, Kunkun Jiang wrote: In the current version, the source QEMU process does not automatic exit after a

[PATCH v6 10/10] tests/data/acpi/virt: Update IORT files for ITS

2021-07-06 Thread Shashi Mallela
Updated expected IORT files applicable with latest GICv3 ITS changes. Full diff of new file disassembly: /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20180629 (64-bit version) * Copyright (c) 2000 - 2018 Intel Corporation * * Disassembly of tests/data/acpi/virt/IORT

[PATCH v6 08/10] tests/data/acpi/virt: Add IORT files for ITS

2021-07-06 Thread Shashi Mallela
Added expected IORT files applicable with latest GICv3 ITS changes.Temporarily differences in these files are okay. Signed-off-by: Shashi Mallela --- tests/data/acpi/virt/IORT | 0 tests/data/acpi/virt/IORT.memhp | 0 tests/data/acpi/virt/IORT.numamem | 0

[PATCH v6 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-07-06 Thread Shashi Mallela
Included creation of ITS as part of SBSA platform GIC initialization. Signed-off-by: Shashi Mallela --- hw/arm/sbsa-ref.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index 43c19b4923..3d9c073636 100644 ---

[PATCH v6 06/10] hw/intc: GICv3 redistributor ITS processing

2021-07-06 Thread Shashi Mallela
Implemented lpi processing at redistributor to get lpi config info from lpi configuration table,determine priority,set pending state in lpi pending table and forward the lpi to cpuif.Added logic to invoke redistributor lpi processing with translated LPI which set/clear LPI from ITS device as part o

[PATCH v6 05/10] hw/intc: GICv3 ITS Feature enablement

2021-07-06 Thread Shashi Mallela
Added properties to enable ITS feature and define qemu system address space memory in gicv3 common,setup distributor and redistributor registers to indicate LPI support. Signed-off-by: Shashi Mallela Reviewed-by: Peter Maydell --- hw/intc/arm_gicv3_common.c | 12 hw/intc/ar

[PATCH v6 01/10] hw/intc: GICv3 ITS initial framework

2021-07-06 Thread Shashi Mallela
Added register definitions relevant to ITS,implemented overall ITS device framework with stubs for ITS control and translater regions read/write,extended ITS common to handle mmio init between existing kvm device and newer qemu device. Signed-off-by: Shashi Mallela Reviewed-by: Peter Maydell ---

[PATCH v6 03/10] hw/intc: GICv3 ITS command queue framework

2021-07-06 Thread Shashi Mallela
Added functionality to trigger ITS command queue processing on write to CWRITE register and process each command queue entry to identify the command type and handle commands like MAPD,MAPC,SYNC. Signed-off-by: Shashi Mallela Reviewed-by: Peter Maydell Reviewed-by: Eric Auger --- hw/intc/arm_gi

[PATCH v6 04/10] hw/intc: GICv3 ITS Command processing

2021-07-06 Thread Shashi Mallela
Added ITS command queue handling for MAPTI,MAPI commands,handled ITS translation which triggers an LPI via INT command as well as write to GITS_TRANSLATER register,defined enum to differentiate between ITS command interrupt trigger and GITS_TRANSLATER based interrupt trigger. Each of these commands

[PATCH v6 09/10] hw/arm/virt: add ITS support in virt GIC

2021-07-06 Thread Shashi Mallela
Included creation of ITS as part of virt platform GIC initialization. This Emulated ITS model now co-exists with kvm ITS and is enabled in absence of kvm irq kernel support in a platform. Signed-off-by: Shashi Mallela Reviewed-by: Peter Maydell --- hw/arm/virt.c | 28 +++

[PATCH v6 00/10] GICv3 LPI and ITS feature implementation

2021-07-06 Thread Shashi Mallela
This patchset implements qemu device model for enabling physical LPI support and ITS functionality in GIC as per GICv3 specification. Both flat table and 2 level tables are implemented.The ITS commands for adding/deleting ITS table entries,trigerring LPI interrupts are implemented.Translated LPI in

[PATCH v6 02/10] hw/intc: GICv3 ITS register definitions added

2021-07-06 Thread Shashi Mallela
Defined descriptors for ITS device table,collection table and ITS command queue entities.Implemented register read/write functions, extract ITS table parameters and command queue parameters,extended gicv3 common to capture qemu address space(which host the ITS table platform memories required for s

Re: [PATCH 12/12] linux-user: Extract target errno related functions to 'target_errno.h'

2021-07-06 Thread Richard Henderson
On 7/4/21 11:37 AM, Philippe Mathieu-Daudé wrote: Extract target errno related functions to a new 'target_errno.h' header, so we can do the host <-> target errno conversion out of the big syscall.c (which is already 13k LoC). Signed-off-by: Philippe Mathieu-Daudé --- linux-user/target_errno.h

Re: [PATCH v5 01/10] hw/intc: GICv3 ITS initial framework

2021-07-06 Thread shashi . mallela
On Mon, 2021-07-05 at 19:58 +0100, Peter Maydell wrote: > On Mon, 5 Jul 2021 at 18:04, wrote: > > On Mon, 2021-07-05 at 17:25 +0100, Peter Maydell wrote: > > > On Mon, 5 Jul 2021 at 16:55, wrote: > > > > On Mon, 2021-07-05 at 15:58 +0100, Peter Maydell wrote: > > > > > On Wed, 30 Jun 2021 at 16:3

Re: [PATCH v5 04/10] hw/intc: GICv3 ITS Command processing

2021-07-06 Thread shashi . mallela
On Tue, 2021-07-06 at 14:27 +0100, Peter Maydell wrote: > On Tue, 6 Jul 2021 at 13:46, wrote: > > On Tue, 2021-07-06 at 10:19 +0100, Peter Maydell wrote: > > > On Tue, 6 Jul 2021 at 04:25, wrote: > > > > > > But the pseudocode for MAPTI does not say anywhere that we should > > > be checking the

Re: [PATCH v5 01/10] hw/intc: GICv3 ITS initial framework

2021-07-06 Thread shashi . mallela
On Tue, 2021-07-06 at 09:44 +0200, Eric Auger wrote: > Hi, > > On 6/30/21 5:31 PM, Shashi Mallela wrote: > > Added register definitions relevant to ITS,implemented overall > > ITS device framework with stubs for ITS control and translater > > regions read/write,extended ITS common to handle mmio i

Re: [PATCH v5 04/10] hw/intc: GICv3 ITS Command processing

2021-07-06 Thread shashi . mallela
On Tue, 2021-07-06 at 11:27 +0200, Eric Auger wrote: > Hi, > > On 7/5/21 4:07 PM, Peter Maydell wrote: > > On Wed, 30 Jun 2021 at 16:32, Shashi Mallela < > > shashi.mall...@linaro.org> wrote: > > > Added ITS command queue handling for MAPTI,MAPI commands,handled > > > ITS > > > translation which t

Re: [PATCH 05/12] linux-user: Extract target errno to 'target_errno_defs.h'

2021-07-06 Thread Richard Henderson
On 7/4/21 11:37 AM, Philippe Mathieu-Daudé wrote: We want to access the target errno indepently of the rest of the linux-user code. Extract it to a new target-specific header: 'target_errno_defs.h'. Signed-off-by: Philippe Mathieu-Daudé --- linux-user/aarch64/target_errno_defs.h| 6 ++

Re: [PATCH 06/12] linux-user/alpha: Remove hardcoded tabs (code style)

2021-07-06 Thread Richard Henderson
On 7/4/21 11:37 AM, Philippe Mathieu-Daudé wrote: We are going to move this code, fix its style first. Signed-off-by: Philippe Mathieu-Daudé --- Patch trivial to review using 'git-diff --ignore-all-space' --- linux-user/alpha/target_syscall.h | 196 +++--- 1 file chang

Re: [PATCH 03/12] linux-user/mips: Handle TARGET_EWOULDBLOCK as TARGET_EAGAIN

2021-07-06 Thread Richard Henderson
On 7/4/21 11:37 AM, Philippe Mathieu-Daudé wrote: Linux kernel defines EWOULDBLOCK as EAGAIN (since before v2.6.12-rc2). Signed-off-by: Philippe Mathieu-Daudé --- linux-user/mips/target_syscall.h | 2 ++ linux-user/mips64/target_syscall.h | 2 ++ 2 files changed, 4 insertions(+) Reviewed

Re: [PATCH 02/12] linux-user/hppa: Handle TARGET_EWOULDBLOCK as TARGET_EAGAIN

2021-07-06 Thread Richard Henderson
On 7/4/21 11:37 AM, Philippe Mathieu-Daudé wrote: Linux kernel defines EWOULDBLOCK as EAGAIN (since before v2.6.12-rc2). Signed-off-by: Philippe Mathieu-Daudé --- linux-user/hppa/target_syscall.h | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH 01/12] linux-user/alpha: Handle TARGET_EWOULDBLOCK as TARGET_EAGAIN

2021-07-06 Thread Richard Henderson
On 7/4/21 11:37 AM, Philippe Mathieu-Daudé wrote: Linux kernel defines EWOULDBLOCK as EAGAIN (since before v2.6.12-rc2). Signed-off-by: Philippe Mathieu-Daudé --- linux-user/alpha/target_syscall.h | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH 09/11] hw/gpio/pl061: Convert to 3-phase reset and assert GPIO lines correctly on reset

2021-07-06 Thread Richard Henderson
On 7/2/21 3:40 AM, Peter Maydell wrote: The PL061 comes out of reset with all its lines configured as input, which means they might need to be pulled to 0 or 1 depending on the 'pullups' and 'pulldowns' properties. Currently we do not assert these lines on reset; they will only be set whenever t

Re: [PATCH 08/11] hw/arm/virt: Make PL061 GPIO lines pulled low, not high

2021-07-06 Thread Richard Henderson
On 7/2/21 3:40 AM, Peter Maydell wrote: For the virt board we have two PL061 devices -- one for NonSecure which is inputs only, and one for Secure which is outputs only. For the former, we don't care whether its outputs are pulled low or high when the line is configured as an input, because we do

Re: [PATCH 07/11] hw/gpio/pl061: Make pullup/pulldown of outputs configurable

2021-07-06 Thread Richard Henderson
On 7/2/21 3:40 AM, Peter Maydell wrote: The PL061 GPIO does not itself include pullup or pulldown resistors to set the value of a GPIO line treated as an output when it is configured as an input (ie when the PL061 itself is not driving it). In real hardware it is up to the board to add suitable p

Re: [RFC PATCH 6/6] dp8393x: Rewrite dp8393x_get() / dp8393x_put()

2021-07-06 Thread Finn Thain
On Mon, 5 Jul 2021, Mark Cave-Ayland wrote: > On 05/07/2021 02:36, Finn Thain wrote: > > > > Unfortunately I don't have a test mips64el image available to see if > > > this combination works for Linux. Phil, do you have a suitable test > > > kernel and rootfs image available to allow this to be

Re: [PATCH 06/11] hw/gpio/pl061: Honour Luminary PL061 PUR and PDR registers

2021-07-06 Thread Richard Henderson
On 7/2/21 3:40 AM, Peter Maydell wrote: The Luminary variant of the PL061 has registers GPIOPUR and GPIOPDR which lets the guest configure whether the GPIO lines are pull-up, pull-down, or truly floating. Instead of assuming all lines are pulled high, honour the PUR and PDR registers. For the pl

Re: [PATCH 05/11] hw/gpio/pl061: Document the interface of this device

2021-07-06 Thread Richard Henderson
On 7/2/21 3:40 AM, Peter Maydell wrote: Add a comment documenting the "QEMU interface" of this device: which MMIO regions, IRQ lines, GPIO lines, etc it exposes. Signed-off-by: Peter Maydell --- hw/gpio/pl061.c | 7 +++ 1 file changed, 7 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH 04/11] hw/gpio/pl061: Add tracepoints for register read and write

2021-07-06 Thread Richard Henderson
On 7/2/21 3:40 AM, Peter Maydell wrote: Add tracepoints for reads and writes to the PL061 registers. This requires restructuring pl061_read() to only return after the tracepoint, rather than having lots of early-returns. Signed-off-by: Peter Maydell --- hw/gpio/pl061.c | 70 ++

Re: [PATCH 03/11] hw/gpio/pl061: Clean up read/write offset handling logic

2021-07-06 Thread Richard Henderson
On 7/2/21 4:45 AM, Peter Maydell wrote: On Fri, 2 Jul 2021 at 12:02, Philippe Mathieu-Daudé wrote: Hi Peter, On 7/2/21 12:40 PM, Peter Maydell wrote: Currently the pl061_read() and pl061_write() functions handle offsets using a combination of three if() statements and a switch(). Clean this

Re: [PATCH 03/11] hw/gpio/pl061: Clean up read/write offset handling logic

2021-07-06 Thread Richard Henderson
On 7/2/21 3:40 AM, Peter Maydell wrote: +case 0x52c ... 0xfcc: /* Reserved */ +goto bad_offset; Any reason to not just use default for these? Otherwise, Reviewed-by: Richard Henderson r~

Re: [PATCH 02/11] hw/gpio/pl061: Convert DPRINTF to tracepoints

2021-07-06 Thread Richard Henderson
On 7/2/21 3:40 AM, Peter Maydell wrote: Convert the use of the DPRINTF debug macro in the PL061 model to use tracepoints. Signed-off-by: Peter Maydell --- hw/gpio/pl061.c | 27 +-- hw/gpio/trace-events | 6 ++ 2 files changed, 15 insertions(+), 18 deletions(

Re: [RFC PATCH 8/8] target/i386: Move X86XSaveArea into TCG

2021-07-06 Thread Richard Henderson
On 7/5/21 3:46 AM, David Edmondson wrote: Given that TCG is now the only consumer of X86XSaveArea, move the structure definition and associated offset declarations and checks to a TCG specific header. Signed-off-by: David Edmondson --- target/i386/cpu.h| 57 ---

Re: [PATCH] tests/acceptance: Test NetBSD 5.1 on the Jazz Magnum machine

2021-07-06 Thread Finn Thain
On Mon, 5 Jul 2021, Philippe Mathieu-Daudé wrote: > On 7/5/21 2:58 AM, Finn Thain wrote: > > On Mon, 5 Jul 2021, Philippe Mathieu-Daudé wrote: > > > >> Test NetBSD 5.1 on the Jazz Magnum machine. As the firmware is not > >> redistributable, it has to be extracted from the floppy configuration > >

Re: [PATCH v5 0/2] Clean up MMU translation

2021-07-06 Thread David Gibson
On Tue, Jul 06, 2021 at 12:03:14PM -0300, Bruno Larsen (billionai) wrote: > This is the final change relating to mmu_idx permission checking, > correcting a technical hiccup on how it was handled beforehand. > It also introduces a common header to be used by all BookS MMUs to help > with common cod

[PATCH v4 3/3] memory_hotplug.c: send DEVICE_UNPLUG_ERROR in acpi_memory_hotplug_write()

2021-07-06 Thread Daniel Henrique Barboza
MEM_UNPLUG_ERROR is deprecated since the introduction of DEVICE_UNPLUG_ERROR. Keep emitting both while the deprecation of MEM_UNPLUG_ERROR is pending. CC: Michael S. Tsirkin CC: Igor Mammedov Reviewed-by: David Gibson Signed-off-by: Daniel Henrique Barboza --- hw/acpi/memory_hotplug.c | 13 ++

[PATCH v4 2/3] spapr: use DEVICE_UNPLUG_ERROR to report unplug errors

2021-07-06 Thread Daniel Henrique Barboza
Linux Kernel 5.12 is now unisolating CPU DRCs in the device_removal error path, signalling that the hotunplug process wasn't successful. This allow us to send a DEVICE_UNPLUG_ERROR in drc_unisolate_logical() to signal this error to the management layer. We also have another error path in spapr_mem

Re: [PATCH 2/2] tcg: Bake tb_destroy() into tcg_region_tree

2021-07-06 Thread Richard Henderson
On 7/4/21 7:31 AM, Liren Wei wrote: -static gint tb_tc_cmp(gconstpointer ap, gconstpointer bp) +static gint tb_tc_cmp(gconstpointer ap, gconstpointer bp, gpointer _) Using _ here as the variable name isn't ideal. I guess if this were c++ we would actually omit the name, which is kinda the sam

[PATCH v4 1/3] qapi/qdev.json: add DEVICE_UNPLUG_ERROR QAPI event

2021-07-06 Thread Daniel Henrique Barboza
At this moment we only provide one event to report a hotunplug error, MEM_UNPLUG_ERROR. As of Linux kernel 5.12 and QEMU 6.0.0, the pseries machine is now able to report unplug errors for other device types, such as CPUs. Instead of creating a (device_type)_UNPLUG_ERROR for each new device, create

[PATCH v4 0/3] DEVICE_UNPLUG_ERROR QAPI event

2021-07-06 Thread Daniel Henrique Barboza
Hi, This new version is rebased with current master (9aef0954195cc), hopefully an adequate format of patch 1, and David's R-b on all patches. changes from v3: - patch 1: * fixed format - all patches: * rebased with master * added David's R-b - v3 link: https://lists.gnu.org/archive/html/qem

Re: [PATCH v3 1/3] qapi/qdev.json: add DEVICE_UNPLUG_ERROR QAPI event

2021-07-06 Thread Daniel Henrique Barboza
On 7/5/21 1:52 AM, David Gibson wrote: On Mon, Jun 21, 2021 at 05:59:05PM -0300, Daniel Henrique Barboza wrote: At this moment we only provide one event to report a hotunplug error, MEM_UNPLUG_ERROR. As of Linux kernel 5.12 and QEMU 6.0.0, the pseries machine is now able to report unplug erro

Re: [PATCH v2] tcg: Avoid including 'trace-tcg.h' in target translate.c

2021-07-06 Thread Richard Henderson
On 6/28/21 10:09 PM, Philippe Mathieu-Daudé wrote: The root trace-events only declares a single TCG event: $ git grep -w tcg trace-events trace-events:115:# tcg/tcg-op.c trace-events:137:vcpu tcg guest_mem_before(TCGv vaddr, uint16_t info) "info=%d", "vaddr=0x%016"PRIx64" info=%d" and

[PATCH] tcg: Add separator in INDEX_op_call dump

2021-07-06 Thread Richard Henderson
We lost the ',' following the called function name. Fixes: 3e92aa34434 Signed-off-by: Richard Henderson --- tcg/tcg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 5150ed700e..4dd4084419 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -1849,7 +1849,7 @

[PATCH 2/2] ui/gtk-egl: blitting partial guest fb to the proper scanout surface

2021-07-06 Thread Dongwon Kim
eb_fb_blit needs more parameters which describe x and y offsets and width and height of the actual scanout to specify the size and cordination of partial image to blit in the guest fb in case the guest fb contains multiple display outputs. Signed-off-by: Dongwon Kim --- hw/display/virtio-gpu-udm

[PATCH 1/2] virtio-gpu: splitting one extended mode guest fb into n-scanouts

2021-07-06 Thread Dongwon Kim
When guest is running Linux/X11 with extended multiple displays mode enabled, the guest shares one scanout resource each time containing whole surface rather than sharing individual display output separately. This extended frame is properly splited and rendered on the corresponding scanout surfaces

[PATCH v2 36/36] linux-user/xtensa: Implement setup_sigtramp

2021-07-06 Thread Richard Henderson
Create and record the rt signal trampoline. Use it when the guest does not use SA_RESTORER. Reviewed-by: Max Filippov Signed-off-by: Richard Henderson --- linux-user/xtensa/target_signal.h | 2 ++ linux-user/xtensa/signal.c| 50 ++- 2 files changed, 32 inser

[PATCH v2 32/36] linux-user/riscv: Add vdso and use it for sigreturn

2021-07-06 Thread Richard Henderson
Building the vdso itself is not actually wired up to anything, since we require a cross-compiler. Just check in those files for now. This fixes a bug wrt libgcc fallback unwinding. It expects the stack pointer to point to the siginfo_t, whereas we had inexplicably placed our private signal tramp

Re: [PATCH 1/2] accel/tcg: Hoist tcg_tb_insert() up above tb_link_page()

2021-07-06 Thread Richard Henderson
On 7/4/21 7:31 AM, Liren Wei wrote: TranslationBlocks not inserted into the corresponding region tree shall be regarded as partially initialized objects, and needs to be finalized first before inserting into QHT. Signed-off-by: Liren Wei --- accel/tcg/translate-all.c | 9 - 1 file cha

[PATCH v2 35/36] linux-user/sparc: Implement setup_sigtramp

2021-07-06 Thread Richard Henderson
Create and record the two signal trampolines. Use them when the guest does not use SA_RESTORER. Cc: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/sparc/target_signal.h | 4 linux-user/sparc/signal.c| 32 ++

[PATCH v2 25/36] linux-user/microblaze: Implement setup_sigtramp

2021-07-06 Thread Richard Henderson
Create and record the rt signal trampoline. Cc: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/microblaze/target_signal.h | 2 ++ linux-user/microblaze/signal.c| 24 +--- 2 files changed, 19 insertions(+), 7 de

[PATCH v2 30/36] target/ppc: Simplify encode_trampoline

2021-07-06 Thread Richard Henderson
The sigret parameter is never 0, and even if it was the encoding of the LI instruction would still work. Reported-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/ppc/signal.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/linux-user/ppc/signal.c b/li

[PATCH v2 28/36] linux-user/nios2: Document non-use of setup_sigtramp

2021-07-06 Thread Richard Henderson
Cc: Chris Wulff Cc: Marek Vasut Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/nios2/target_signal.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/nios2/target_signal.h b/linux-user/nios2/target_signal.h index aebf749f12..fe266c4c51 1006

Re: [PATCH 1/4] dp8393x: don't force 32-bit register access

2021-07-06 Thread Finn Thain
On Mon, 5 Jul 2021, Mark Cave-Ayland wrote: > Commit 3fe9a838ec "dp8393x: Always use 32-bit accesses" set > .impl.min_access_size > and .impl.max_access_size to 4 to try and fix the Linux jazzsonic driver > which uses > 32-bit accesses. > > The problem with forcing the register access to 32-bit

[PATCH v2 31/36] linux-user/ppc: Implement setup_sigtramp

2021-07-06 Thread Richard Henderson
Create and record the two signal trampolines. Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson --- linux-user/ppc/target_signal.h | 2 ++ linux-user/ppc/signal.c| 34 ++ 2 files changed, 20 insertions(+), 16 deletions(-) diff --git a/linux-user/p

[PATCH v2 33/36] linux-user/s390x: Implement setup_sigtramp

2021-07-06 Thread Richard Henderson
Create and record the two signal trampolines. Use them when the guest does not use SA_RESTORER. Cc: qemu-s3...@nongnu.org Tested-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/s390x/target_signal.h | 2 ++ linux-user/s390x/signal.c|

[PATCH v2 34/36] linux-user/sh4: Implement setup_sigtramp

2021-07-06 Thread Richard Henderson
Create and record the two signal trampolines. Use them when the guest does not use SA_RESTORER. Cc: Yoshinori Sato Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/sh4/target_signal.h | 2 ++ linux-user/sh4/signal.c| 40 +++---

[PATCH v2 23/36] linux-user/x86_64: Add vdso

2021-07-06 Thread Richard Henderson
Building the vdso itself is not actually wired up to anything, since we require a cross-compiler. Just check in that file for now. Signed-off-by: Richard Henderson --- linux-user/elfload.c| 4 +- linux-user/x86_64/Makefile.vdso | 5 ++ linux-user/x86_64/meson.build | 6 ++ l

[PATCH v2 24/36] linux-user/m68k: Implement setup_sigtramp

2021-07-06 Thread Richard Henderson
Create and record the two signal trampolines. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/m68k/target_signal.h | 2 ++ linux-user/m68k/signal.c| 47 +++-- 2 files changed, 24 insertions(+), 25 deletions(-) diff --git

[PATCH v2 26/36] linux-user/mips: Tidy install_sigtramp

2021-07-06 Thread Richard Henderson
The return value is constant 0, and unused as well -- change to void. Drop inline marker. Change tramp type to uint32_t* for clarity. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/mips/signal.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) dif

[PATCH v2 29/36] linux-user/openrisc: Implement setup_sigtramp

2021-07-06 Thread Richard Henderson
Create and record the rt signal trampoline. Reviewed-by: Stafford Horne Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/openrisc/target_signal.h | 2 ++ linux-user/openrisc/signal.c| 24 2 files changed, 18 insertions(+), 8

[PATCH v2 18/36] linux-user/cris: Implement setup_sigtramp

2021-07-06 Thread Richard Henderson
Split out setup_sigreturn so that we can continue to initialize the words on the stack, as documented. However, use the off-stack trampoline. Cc: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/cris/target_signal.h | 2 ++ linux-user/cris/

[PATCH v2 27/36] linux-user/mips: Implement setup_sigtramp

2021-07-06 Thread Richard Henderson
Create and record the two signal trampolines. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/mips/target_signal.h | 1 + linux-user/mips64/target_signal.h | 2 ++ linux-user/mips/signal.c | 34 ++- 3 files changed, 27

[PATCH v2 22/36] linux-user/i386: Add vdso and use it for sigreturn

2021-07-06 Thread Richard Henderson
Building the vdso itself is not actually wired up to anything, since we require a cross-compiler. Just check in that file for now. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 16 +++- linux-user/i386/signal.c | 39 - linux-user/i386/Makefile.vdso | 5 ++

[PATCH v2 10/36] linux-user: Load vdso image if available

2021-07-06 Thread Richard Henderson
The vdso image will be pre-processed into a C data array, with a simple list of relocations to perform, and identifying the location of signal trampolines. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 80 +++- 1 file changed, 72 insertions(+

[PATCH v2 15/36] target/arm: Add isar_feature_aa32_a32

2021-07-06 Thread Richard Henderson
Add a probe for whether A32 mode is supported. Fill in the field for the pre-v5 cpus. Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson --- target/arm/cpu.h | 5 + target/arm/cpu_tcg.c | 7 +++ 2 files changed, 12 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h

[PATCH v2 21/36] linux-user/x86_64: Raise SIGSEGV if SA_RESTORER not set

2021-07-06 Thread Richard Henderson
This has been a fixme for some time. The effect of returning -EFAULT from the kernel code is to raise SIGSEGV. Signed-off-by: Richard Henderson --- linux-user/i386/signal.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/linux-user/i386/signal.c b/linux-user/i386

[PATCH v2 08/36] linux-user: Replace bprm->fd with bprm->src.fd

2021-07-06 Thread Richard Henderson
There are only a couple of uses of bprm->fd remaining. Migrate to the other field. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/qemu.h | 1 - linux-user/flatload.c | 8 linux-user/linuxload.c | 5 ++--- 3 files changed, 6 insertions(+), 8 de

[PATCH v2 20/36] linux-user/hppa: Add vdso and use it for rt_sigreturn

2021-07-06 Thread Richard Henderson
Building the vdso itself is not actually wired up to anything, since we require a cross-compiler. Just check in that file for now. Drop the now-unused 9 trampoline words, and describe the frame without the trampoline in __kernel_rt_sigreturn. Signed-off-by: Richard Henderson --- linux-user/elf

[PATCH v2 14/36] linux-user/arm: Drop "_v2" from symbols in signal.c

2021-07-06 Thread Richard Henderson
Since we no longer support "v1", there's no need to distinguish "v2". Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson --- linux-user/arm/signal.c | 155 +--- 1 file changed, 65 insertions(+), 90 deletions(-) diff --git a/linux-user/arm/signal.c b/lin

[PATCH v2 13/36] linux-user/arm: Drop v1 signal frames

2021-07-06 Thread Richard Henderson
Version 2 signal frames are used from 2.6.12. Since cbc14e6f286, we have set UNAME_MINIMUM_RELEASE to 2.6.32, which means that version 1 signal frames are never used. Cc: qemu-...@nongnu.org Suggested-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/arm/signal.c | 220 +

[PATCH v2 19/36] linux-user/hexagon: Implement setup_sigtramp

2021-07-06 Thread Richard Henderson
Continue to initialize the words on the stack, as documented. However, use the off-stack trampoline. Cc: Taylor Simpson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/hexagon/target_signal.h | 2 ++ linux-user/hexagon/signal.c| 19 +

[PATCH v2 03/36] linux-user: Introduce imgsrc_read, imgsrc_read_alloc

2021-07-06 Thread Richard Henderson
Introduced and initialized, but not yet really used. These will tidy the current tests vs BPRM_BUF_SIZE. Signed-off-by: Richard Henderson --- linux-user/qemu.h | 50 ++ linux-user/linuxload.c | 46 ++ 2 files change

[PATCH v2 16/36] linux-user/arm: Add vdso and use it for rt_sigreturn

2021-07-06 Thread Richard Henderson
Building of the vdsos are not actually wired up to anything, since we require a cross-compiler. Just check in the files for now. The thumb vdso will only be used for m-profile, as all of our a-profile cpus support arm mode. Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson --- linux-use

[PATCH v2 06/36] linux-user: Use ImageSource in load_elf_image

2021-07-06 Thread Richard Henderson
Change parse_elf_properties as well, as the bprm_buf argument ties the two functions closely. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 124 --- 1 file changed, 47 insertions(+), 77 deletions(-) diff --git a/linux-user/elfload.c b/linux-

[PATCH v2 12/36] linux-user/aarch64: Add vdso and use it for rt_sigreturn

2021-07-06 Thread Richard Henderson
Building of the vdsos are not actually wired up to anything, since we require a cross-compiler. Just check in the files for now. Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson --- linux-user/aarch64/signal.c | 17 ++- linux-user/elfload.c | 4 ++ linux-user/aar

[PATCH v2 05/36] linux-user: Do not clobber bprm_buf swapping ehdr

2021-07-06 Thread Richard Henderson
Rearrange the allocation of storage for ehdr between load_elf_image and load_elf_binary. The same set of copies are done, but we don't modify bprm_buf, which will be important later. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/elfload.c | 25

[PATCH v2 09/36] linux-user: Introduce imgsrc_mmap

2021-07-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/qemu.h | 11 +++ linux-user/elfload.c | 4 ++-- linux-user/linuxload.c | 44 ++ 3 files changed, 57 insertions(+), 2 deletions(-) diff --git a/linux-user/qemu.h b/linux-user/qemu.h index dafaa

[PATCH v2 17/36] linux-user/alpha: Implement setup_sigtramp

2021-07-06 Thread Richard Henderson
Create and record the two signal trampolines. Use them when the guest does not use ka_restorer. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/alpha/target_signal.h | 1 + linux-user/alpha/signal.c| 34 +++- 2 files chang

  1   2   3   4   5   >