On 06/07/2021 16.58, Alex Bennée wrote:
Lets spot the obvious errors.
Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
---
contrib/plugins/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/plugins/Makefile b/contrib/plugins/Makefile
index b9d7935e5e..17e6e2ec4f 100644
--- a/contrib/plugins/Makefile
+++ b/contrib/plugins/Makefile
@@ -24,7 +24,7 @@ SONAMES := $(addsuffix .so,$(addprefix lib,$(NAMES)))
# The main QEMU uses Glib extensively so it's perfectly fine to use it
# in plugins (which many example do).
CFLAGS = $(GLIB_CFLAGS)
-CFLAGS += -fPIC
+CFLAGS += -fPIC -Wall
In pc-bios/s390-ccw/Makefile we're using:
-Wall $(filter -W%, $(QEMU_CFLAGS))
to also get the other warning options from config-host.mak. You might want
to consider to do that here, too.
Anyway:
Reviewed-by: Thomas Huth <th...@redhat.com>
