Re: [PATCH v2 1/1] hw/block/m25p80: Fix Numonyx fast read dummy cycle count

On 10/29/20 12:15 AM, Joe Komlodi wrote: > Hi Philippe, > > Comments marked inline with [Joe] > > -Original Message- > From: Philippe Mathieu-Daudé On Behalf Of > Philippe Mathieu-Daudé > Sent: Wednesday, October 28, 2020 2:27 AM > To: Joe Komlodi ; qemu-devel@nongnu.org > Cc: Francisco

[PATCH v1] docs/devel: Add VFIO device migration documentation

Document interfaces used for VFIO device migration. Added flow of state changes during live migration with VFIO device. Signed-off-by: Kirti Wankhede --- MAINTAINERS | 1 + docs/devel/vfio-migration.rst | 119 ++ 2 files changed, 120 in

Re: [PATCH 0/4] kvm: Add a --enable-debug-kvm option to configure

On 2020/10/28 15:44, Paolo Bonzini wrote: > On 28/10/20 08:11, AlexChen wrote: >> The current 'DEBUG_KVM' macro is defined in many files, and turning on >> the debug switch requires code modification, which is very inconvenient, >> so this series add an option to configure to support the definition

RE: [PATCH 3/9] accel/tcg/user-exec: silence the compiler warnings

> -Original Message- > From: Richard Henderson [mailto:richard.hender...@linaro.org] > Sent: Wednesday, October 28, 2020 11:38 PM > To: Thomas Huth ; Chenqun (kuhn) > ; qemu-devel@nongnu.org; > qemu-triv...@nongnu.org > Cc: Zhanghailiang ; Riku Voipio > ; Paolo Bonzini ; ganqixin > ; Euler

[Bug 1901981] [NEW] assert issue locates in hw/usb/dev-storage.c:248: usb_msd_send_status

Public bug reported: Hello, I found an assertion failure through hw/usb/dev-storage.c. This was found in latest version 5.1.0. qemu-system-x86_64: hw/usb/dev-storage.c:248: usb_msd_send_status: Assertion `s->csw.sig == cpu_to_le32(0x53425355)' failed. [1]29544 abort sudo -e

[PATCH V2] vhost-user-blk/scsi: Fix broken error handling for socket call

When socket() fails, it returns -1, 0 is the normal return value and should not return error. Reported-by: Euler Robot Signed-off-by: AlexChen --- contrib/vhost-user-blk/vhost-user-blk.c | 2 +- contrib/vhost-user-scsi/vhost-user-scsi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-

Re: [PATCH] vhost-user-blk: Fix two resource leaks

On 2020/10/28 23:40, Raphael Norwitz wrote: > The change looks good but I'm not sure I'd call it resource leak in > either case since the failure case kills vhost-user-blk/scsi. In the > commit message maybe rather say "vhost-user-blk/scsi: fix broken error > handling for socket call"? > Thanks fo

RE: [PATCH 6/9] target/sparc/win_helper: silence the compiler warnings

> -Original Message- > From: Philippe Mathieu-Daudé [mailto:philippe.mathieu.da...@gmail.com] > On Behalf Of Philippe Mathieu-Daudé > Sent: Wednesday, October 28, 2020 5:51 PM > To: Chenqun (kuhn) ; qemu-devel@nongnu.org; > qemu-triv...@nongnu.org > Cc: Zhanghailiang ; Mark Cave-Ayland > ;

RE: [PATCH 1/9] target/i386: silence the compiler warnings in gen_shiftd_rm_T1

> -Original Message- > From: Thomas Huth [mailto:th...@redhat.com] > Sent: Thursday, October 29, 2020 12:52 AM > To: Richard Henderson ; Chenqun (kuhn) > ; qemu-devel@nongnu.org; > qemu-triv...@nongnu.org > Cc: Eduardo Habkost ; Zhanghailiang > ; ganqixin ; Euler > Robot ; Paolo Bonzini ; >

Re: [PATCH V2 00/14] fix some comment spelling errors

Thank you very much. But I don't know how to do that. Can you help me? By the way, this series of patches have been reviewed and four of them have been applied. Can you help me to apply the rest? On 2020/10/20 14:42, Philippe Mathieu-Daudé wrote: > You forgot to Cc qemu-devel@. > > (See https:/

Re: [PATCH v3 7/7] block: check availablity for preadv/pwritev on mac

If built with Xcode 11 (or below), a compile time error will occur due to symbol not found. (QEMU's ./configure detects this and doesn't enable it) If built with Xcode 12 without the checks, a runtime error will occur. -j On Wed, Oct 28, 2020 at 5:23 AM Stefan Hajnoczi wrote: > > On Tue, Oct 27,

Re: [PATCH v3 6/7] tcg: implement JIT for iOS and Apple Silicon

Will fix the typo in the commit message. Re: "reverse engineered functions", Apple does not provide any documentation on their extensions to ARM architecture. APRR is one such proprietary feature that is controlled by MRS/MSR writes to an undocumented system register. We reverse engineered the fun

Re: [PATCH v3 4/7] coroutine: add libucontext as external library

Mirroring the repo by QEMU is fine and preferred. Not sure if anything is required from my end there. slirp_opt slipped in from a rebase and should not be there, will fix. -j On Wed, Oct 28, 2020 at 4:48 AM Stefan Hajnoczi wrote: > > On Tue, Oct 27, 2020 at 08:06:58PM -0700, Joelle van Dyne wro

Re: [PATCH v3 3/7] qemu: add support for iOS host

On Wed, Oct 28, 2020 at 4:39 AM Stefan Hajnoczi wrote: > > On Tue, Oct 27, 2020 at 08:06:57PM -0700, Joelle van Dyne wrote: > > This introduces support for building for iOS hosts. When the correct Xcode > > toolchain is used, iOS host will be detected automatically. > > > > block: disable features

Re: [PATCH v3 1/7] configure: option to disable host block devices

On Wed, Oct 28, 2020 at 4:22 AM Stefan Hajnoczi wrote: > > On Tue, Oct 27, 2020 at 08:06:55PM -0700, Joelle van Dyne wrote: > > Some hosts (iOS) have a sandboxed filesystem and do not provide low-level > > APIs for interfacing with host block devices. > > > > Signed-off-by: Joelle van Dyne > > --

Re: [PATCH 8/9] target/ppc: silence the compiler warnings

On Wed, Oct 28, 2020 at 04:06:03PM +0100, Thomas Huth wrote: > On 28/10/2020 10.56, Philippe Mathieu-Daudé wrote: > > On 10/28/20 5:18 AM, Chen Qun wrote: > >> When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed > >> warning: > >> target/ppc/mmu_helper.c: In function ‘dump_mmu’: >

Re: [PATCH 7/9] ppc: silence the compiler warnings

On Wed, Oct 28, 2020 at 03:42:31PM +0100, Thomas Huth wrote: > On 28/10/2020 05.29, David Gibson wrote: > > On Wed, Oct 28, 2020 at 12:18:17PM +0800, Chen Qun wrote: > >> When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed > >> warning: > >> hw/ppc/ppc.c: In function ‘ppc6xx_set_i

Re: [PATCH v3 15/15] python/qemu: add qemu package itself to pipenv

On 10/28/20 6:59 PM, Cleber Rosa wrote: On Tue, Oct 20, 2020 at 03:35:55PM -0400, John Snow wrote: This adds the python qemu packages themselves to the pipenv manifest. 'pipenv sync' will create a virtual environment sufficient to use the SDK. 'pipenv sync --dev' will create a virtual environmen

Re: [PATCH v3 14/15] python/qemu: add isort to pipenv

On 10/28/20 6:46 PM, Cleber Rosa wrote: On Tue, Oct 20, 2020 at 03:35:54PM -0400, John Snow wrote: isort 5.0.0 through 5.0.4 has a bug that causes it to misinterpret certain "from ..." clauses that are not related to imports. Require 5.0.5 or greater. isort can be run with 'isort -c qemu' from

Re: [PATCH v3 08/15] python: add pylint to pipenv

On 10/28/20 6:38 PM, Cleber Rosa wrote: On Tue, Oct 20, 2020 at 03:35:48PM -0400, John Snow wrote: We are specifying >= pylint 2.6.x for two reasons: 1. For setup.cfg support, added in pylint 2.5.x 2. To clarify that we are using a version that has incompatibly dropped bad-whitespace checks. S

Re: [PATCH v3 06/15] python: add pylint import exceptions

On 10/28/20 6:24 PM, Cleber Rosa wrote: On Tue, Oct 20, 2020 at 03:35:46PM -0400, John Snow wrote: Pylint 2.5.x and 2.6.x have regressions that make import checking inconsistent, see: https: //github.com/PyCQA/pylint/issues/3609 https: //github.com/PyCQA/pylint/issues/3624 https: //github.com/P

Re: [PATCH v3 04/15] python: add directory structure README.rst files

On 10/28/20 6:05 PM, Cleber Rosa wrote: On Tue, Oct 20, 2020 at 03:35:44PM -0400, John Snow wrote: Add short readmes to python/, python/qemu/, python/qemu/machine, and python/qemu/machine that explain the directory hierarchy. These readmes are visible when browsing the source on e.g. gitlab/gith

[Bug 1897194] Re: Test failure in test-crypto-secret.c

> systemd-nspawn containers don't have CAP_SYS_ADMIN Above statement is utter bollocks. Please ignore.. I finally got to the bottom of all this and now have the test suite passing. - don't use `--disable-keyring', it's busted - systemd-nspawn containers need to be configured with additional ca

RE: [PATCH v2 1/1] hw/block/m25p80: Fix Numonyx fast read dummy cycle count

Hi Philippe, Comments marked inline with [Joe] -Original Message- From: Philippe Mathieu-Daudé On Behalf Of Philippe Mathieu-Daudé Sent: Wednesday, October 28, 2020 2:27 AM To: Joe Komlodi ; qemu-devel@nongnu.org Cc: Francisco Eduardo Iglesias ; kw...@redhat.com; alist...@alistair23.me

Re: [PATCH v3 15/15] python/qemu: add qemu package itself to pipenv

On Tue, Oct 20, 2020 at 03:35:55PM -0400, John Snow wrote: > This adds the python qemu packages themselves to the pipenv manifest. > 'pipenv sync' will create a virtual environment sufficient to use the SDK. > 'pipenv sync --dev' will create a virtual environment sufficient to use > and test the SD

Re: [PATCH v3 13/15] python: move .isort.cfg into setup.cfg

On Tue, Oct 20, 2020 at 03:35:53PM -0400, John Snow wrote: > Signed-off-by: John Snow > --- Reviewed-by: Cleber Rosa signature.asc Description: PGP signature

Re: [PATCH v3 12/15] python: add mypy to pipenv

On Tue, Oct 20, 2020 at 03:35:52PM -0400, John Snow wrote: > 0.730 appears to be about the oldest version that works with the > features we want, including nice human readable output (to make sure > iotest 297 passes), and type-parameterized Popen generics. > > 0.770, however, supports adding 'str

Re: [PATCH v3 14/15] python/qemu: add isort to pipenv

On Tue, Oct 20, 2020 at 03:35:54PM -0400, John Snow wrote: > isort 5.0.0 through 5.0.4 has a bug that causes it to misinterpret > certain "from ..." clauses that are not related to imports. > > Require 5.0.5 or greater. > > isort can be run with 'isort -c qemu' from the python root. > > Signed-o

Re: [PATCH v3 11/15] python: move mypy.ini into setup.cfg

On Tue, Oct 20, 2020 at 03:35:51PM -0400, John Snow wrote: > mypy supports reading its configuration values from a central project > configuration file; do so. > > Signed-off-by: John Snow > --- Reviewed-by: Cleber Rosa signature.asc Description: PGP signature

Re: [PATCH v3 10/15] python: Add flake8 to pipenv

On Tue, Oct 20, 2020 at 03:35:50PM -0400, John Snow wrote: > flake8 3.5.x does not support the --extend-ignore syntax used in the > .flake8 file to gracefully extend default ignores, so 3.6.x is our > minimum requirement. There is no known upper bound. > > flake8 can be run from the python/ direct

Re: [PATCH v3 09/15] python: move flake8 config to setup.cfg

On Tue, Oct 20, 2020 at 03:35:49PM -0400, John Snow wrote: > Update the comment concerning the flake8 exception to match commit > 42c0dd12, whose commit message stated: > > A note on the flake8 exception: flake8 will warn on *any* bare except, > but pylint's is context-aware and will suppress the

Re: [PATCH v3 08/15] python: add pylint to pipenv

On Tue, Oct 20, 2020 at 03:35:48PM -0400, John Snow wrote: > We are specifying >= pylint 2.6.x for two reasons: > > 1. For setup.cfg support, added in pylint 2.5.x > 2. To clarify that we are using a version that has incompatibly dropped > bad-whitespace checks. > > Signed-off-by: John Snow > --

Re: [PATCH v3 07/15] python: move pylintrc into setup.cfg

On Tue, Oct 20, 2020 at 03:35:47PM -0400, John Snow wrote: > Delete the empty settings now that it's sharing a home with settings for > other tools. > > pylint can now be run from this folder as "pylint qemu". > Signed-off-by: John Snow > --- Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa s

Re: [PATCH v3 06/15] python: add pylint import exceptions

On Tue, Oct 20, 2020 at 03:35:46PM -0400, John Snow wrote: > Pylint 2.5.x and 2.6.x have regressions that make import checking > inconsistent, see: > > https: //github.com/PyCQA/pylint/issues/3609 > https: //github.com/PyCQA/pylint/issues/3624 > https: //github.com/PyCQA/pylint/issues/3651 > Are

Re: [PATCH v3 05/15] python: Add pipenv support

On Tue, Oct 20, 2020 at 03:35:45PM -0400, John Snow wrote: > pipenv is a tool used for managing virtual environments with pinned, > explicit dependencies. It is used for precisely recreating python > virtual environments. > > pipenv uses two files to do this: > > (1) Pipfile, which is similar in

Re: [PATCH v3 04/15] python: add directory structure README.rst files

On Tue, Oct 20, 2020 at 03:35:44PM -0400, John Snow wrote: > Add short readmes to python/, python/qemu/, python/qemu/machine, and > python/qemu/machine that explain the directory hierarchy. These readmes > are visible when browsing the source on e.g. gitlab/github and are > designed to help new dev

[PATCH] linux-user/mmap.c: check range of mremap result in target address space

If mremap succeeds, an additional check is performed to ensure that the new address range fits into the target address space. This check was previously perfomed in host address space, with the upper bound fixed to abi_ulong. This patch replaces the static check with a call to `guest_range_valid`,

[PATCH] semihosting: Merge semihosting console init functions to fix READC

Commit 619985e937 (semihosting: defer connect_chardevs a little more to use serialx) moved the call to qemu_semihosting_connect_chardevs until after all of the serial devices were initialized to make semihosting console configuration easier. This change broke semihosting console input as the call

Re: [PATCH v2 1/5] target/riscv: Add a virtualised MMU Mode

On 10/28/20 1:51 PM, Alistair Francis wrote: >>> diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c >>> index 3eb3a034db..453e4c6d8a 100644 >>> --- a/target/riscv/cpu_helper.c >>> +++ b/target/riscv/cpu_helper.c >>> @@ -30,6 +30,10 @@ int riscv_cpu_mmu_index(CPURISCVState *env, bool

[PATCH] Add int128_or to include/qemu/int128.h

Discovered the need when working on Hexagon target https://www.mail-archive.com/qemu-devel@nongnu.org/msg733818.html Useful as a standalone patch Signed-off-by: Taylor Simpson --- include/qemu/int128.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/qemu/int128.h b/includ

Re: [PATCH] meson.build: fix building of Xen support for aarch64

On Wed, 28 Oct 2020, Alex Bennée wrote: > Xen is supported on aarch64 although weirdly using the i386-softmmu > model. Checking based on the host CPU meant we never enabled Xen > support. It would be nice to enable CONFIG_XEN for aarch64-softmmu to > make it not seem weird but that will require fur

Re: [PATCH v2 1/5] target/riscv: Add a virtualised MMU Mode

On Wed, Oct 28, 2020 at 8:13 AM Richard Henderson wrote: > > On 10/28/20 7:42 AM, Alistair Francis wrote: > > Add a new MMU mode that includes the current virt mode. > > > > Signed-off-by: Alistair Francis > > --- > > target/riscv/cpu-param.h | 10 +- > > target/riscv/cpu.h| 4

Re: [PATCH] hw/timer/renesas_tmr.c cleanup read operation.

On 11/07/2020 17.42, Yoshinori Sato wrote: > Cleanup read operation. > This module different return of access size. The last sentence is hard to read, could you maybe rephrase it? > -case A_TCORB: > -if (size == 1) { > +case A_TCORB: > return tmr->tcorb[ch]; > -

Re: [PATCH] MAINTAINERS: update my email address

On 27/10/2020 07.02, Michael Roth wrote: > I've recently switched employers and the current email address is out > of date. > > Signed-off-by: Michael Roth > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ef6f5c73

Re: [PATCH v2 00/10] hw/riscv: microchip_pfsoc: Support factory HSS boot out of the box

On Tue, Oct 27, 2020 at 10:31 PM Bin Meng wrote: > > From: Bin Meng > > At present the DDR memory controller is not modeled, hence the factory > HSS firmware does not boot out of the box on QEMU. A modified HSS is > required per the instructions on [1]. > > This series adds the missing DDR memory

Re: [PULL 00/12] qemu-ga patch queue for soft-freeze

On Tue, 27 Oct 2020 at 05:53, Michael Roth wrote: > > The following changes since commit a46e72710566eea0f90f9c673a0f02da0064acce: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20201026' into > staging (2020-10-26 14:50:03 +) > > are available in the Git repository at: > > g

Re: [RFC PATCH] hw/arm/virt: use sbsa-ec for reboot and poweroff in secure mode

On Wed, 28 Oct 2020 at 08:59, Maxim Uvarov wrote: > > If we're emulating EL3 then the EL3 guest firmware is responsible for > providing the PSCI ABI, including reboot, core power down, etc. > sbsa-ref machine has an embedded controller to do reboot, poweroff. Machine > virt,secure=on can reuse thi

Re: [PATCH v3 02/15] python: add qemu package installer

On 10/28/20 3:49 PM, Cleber Rosa wrote: On Tue, Oct 20, 2020 at 03:35:42PM -0400, John Snow wrote: Add setup.cfg and setup.py, necessary for installing a package via pip. Add a rst document explaining the basics of what this package is for and who to contact for more information. This document w

Re: [PATCH v3 02/15] python: add qemu package installer

On 10/28/20 3:46 PM, Cleber Rosa wrote: On Wed, Oct 28, 2020 at 01:02:52PM -0400, John Snow wrote: On 10/28/20 11:10 AM, Cleber Rosa wrote: +mirror `_, but +contributions must be sent to the list for inclusion. IMO it's not clear if this branch/mir

Re: [PATCH 05/11] target/arm: Add read/write_neon_element32

On 10/27/20 8:26 PM, Richard Henderson wrote: > @@ -3871,24 +3923,26 @@ static bool trans_VTRN(DisasContext *s, arg_2misc *a) > return true; > } > > -if (a->size == 2) { > +tmp = tcg_temp_new_i32(); > +tmp2 = tcg_temp_new_i32(); > +if (a->size == MO_32) { ... >

Re: [PATCH 2/9] hw/intc/arm_gicv3_kvm: silence the compiler warnings

On Wed, 28 Oct 2020 at 04:19, Chen Qun wrote: > > When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: > hw/intc/arm_gicv3_kvm.c: In function ‘kvm_arm_gicv3_put’: > hw/intc/arm_gicv3_kvm.c:484:13: warning: this statement may fall through > [-Wimplicit-fallthrough=] >

Re: [PATCH 9/9] hw/timer/renesas_tmr: silence the compiler warnings

On Wed, 28 Oct 2020 at 15:07, Thomas Huth wrote: > > On 28/10/2020 10.59, Philippe Mathieu-Daudé wrote: > > On 10/28/20 5:18 AM, Chen Qun wrote: > >> When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed > >> warning: > >> ../hw/timer/renesas_tmr.c: In function ‘tmr_read’: > >> ../

Re: [PATCH 00/11] target/arm: Fix neon reg offsets

On Wed, 28 Oct 2020 at 03:27, Richard Henderson wrote: > > Much of the existing usage of neon_reg_offset is broken for > big-endian hosts, as it computes the offset of the first > 32-bit unit, not the offset of the entire vector register. > > Fix this by separating out the different usages. Make

Re: [PATCH v3 03/15] python: add VERSION file

On 10/28/20 3:51 PM, Cleber Rosa wrote: On Tue, Oct 20, 2020 at 03:35:43PM -0400, John Snow wrote: Python infrastructure as it exists today is not capable reliably of single-sourcing a package version from a parent directory. The authors of pip are working to correct this, but as of today this i

Re: [PULL 0/8] Renesas patches for 2020-10-27

On Mon, 26 Oct 2020 at 23:32, Philippe Mathieu-Daudé wrote: > > The following changes since commit 1dc887329a10903940501b43e8c0cc67af7c06d5: > > Merge remote-tracking branch 'remotes/philmd-gitlab/tags/sd-next-20201026' = > into staging (2020-10-26 17:19:26 +) > > are available in the Git re

Re: [PATCH v3 01/15] python: create qemu packages

On 10/28/20 12:39 PM, Cleber Rosa wrote: On Wed, Oct 28, 2020 at 11:21:19AM -0400, John Snow wrote: On 10/28/20 10:46 AM, Cleber Rosa wrote: On Tue, Oct 20, 2020 at 03:35:41PM -0400, John Snow wrote: move python/qemu/*.py to python/qemu/[machine, qmp]/*.py and update import directives across t

Re: [PATCH v3 03/15] python: add VERSION file

On Tue, Oct 20, 2020 at 03:35:43PM -0400, John Snow wrote: > Python infrastructure as it exists today is not capable reliably of > single-sourcing a package version from a parent directory. The authors > of pip are working to correct this, but as of today this is not possible > to my knowledge. >

Re: [PATCH 2/2] target/arm: Fix VUDOT/VSDOT (scalar) on big-endian hosts

On 10/28/20 8:17 PM, Peter Maydell wrote: > The helper functions for performing the udot/sdot operations against > a scalar were not using an address-swizzling macro when converting > the index of the scalar element into a pointer into the vm array. > This had no effect on little-endian hosts but m

Re: [PATCH v3 02/15] python: add qemu package installer

On Tue, Oct 20, 2020 at 03:35:42PM -0400, John Snow wrote: > Add setup.cfg and setup.py, necessary for installing a package via > pip. Add a rst document explaining the basics of what this package is > for and who to contact for more information. This document will be used > as the landing page for

Re: [PATCH v3 02/15] python: add qemu package installer

On Wed, Oct 28, 2020 at 01:02:52PM -0400, John Snow wrote: > On 10/28/20 11:10 AM, Cleber Rosa wrote: > > > +mirror `_, but > > > +contributions must be sent to the list for inclusion. > > > > IMO it's not clear if this branch/mirror is your development

Re: [PATCH 1/2] target/arm: Fix float16 pairwise Neon ops on big-endian hosts

On 10/28/20 8:17 PM, Peter Maydell wrote: > In the neon_padd/pmax/pmin helpers for float16, a cut-and-paste error > meant we were using the H4() address swizzler macro rather than the > H2() which is required for 2-byte data. This had no effect on > little-endian hosts but meant we put the result

Re: [PATCH 0/2] Fix some Neon insns on big-endian hosts

On 10/28/20 12:17 PM, Peter Maydell wrote: > Peter Maydell (2): > target/arm: Fix float16 pairwise Neon ops on big-endian hosts > target/arm: Fix VUDOT/VSDOT (scalar) on big-endian hosts Reviewed-by: Richard Henderson r~

Re: [PATCH 00/11] target/arm: Fix neon reg offsets

On 10/28/20 9:48 AM, Peter Maydell wrote: > I haven't reviewed this yet but it fixes a lot of the > problems I saw in my risu run on an s390x box, and I > don't see any regressions on x86-64. However these still > fail on s390x compared to an x86-64 host: > > insn_VPADD_float_f16.risu.bin FAIL > i

Re: [PATCH 04/29] vl: remove bogus check

On Tue, 27 Oct 2020 14:21:19 -0400 Paolo Bonzini wrote: > There is no reason to prevent -preconfig -daemonize. Of course if > no monitor is defined there will be no way to start the VM, > but that is a user error. looking some more at the current code, this piece is currently somewhat broken, s

[PATCH-for-5.2] hw/rx/rx-gdbsim: Fix memory leak

As load_device_tree() returns allocated memory, we need to free it. Cc: Yoshinori Sato Fixes: bda19d7bb56 ("hw/rx: Add RX GDB simulator") Reported-by: Coverity (CID 1432307: RESOURCE_LEAK) Signed-off-by: Philippe Mathieu-Daudé --- Peter mentioned this issue almost 2 months ago: https://www.mail-

[PATCH 0/2] Fix some Neon insns on big-endian hosts

This patchseries fixes a couple of places where the vector helpers we use for Neon insns were missing uses of the address-swizzling macros H1(), H2() or H4(). This is harmless on little-endian hosts but causes the wrong results to be generated on big-endian hosts. The affected insns are VUDOT(scala

[PATCH 2/2] target/arm: Fix VUDOT/VSDOT (scalar) on big-endian hosts

The helper functions for performing the udot/sdot operations against a scalar were not using an address-swizzling macro when converting the index of the scalar element into a pointer into the vm array. This had no effect on little-endian hosts but meant we generated incorrect results on big-endian

[PATCH 1/2] target/arm: Fix float16 pairwise Neon ops on big-endian hosts

In the neon_padd/pmax/pmin helpers for float16, a cut-and-paste error meant we were using the H4() address swizzler macro rather than the H2() which is required for 2-byte data. This had no effect on little-endian hosts but meant we put the result data into the destination Dreg in the wrong order

Re: [PATCH 1/4] semihosting: Move ARM semihosting code to shared directories

Alex Bennée writes: > specific_ss.add(when: 'CONFIG_ARM_STYLE_SEMIHOSTING', > if_true: files ('common-semi.c')) I've sent another version of the series using this plan. It does look a bit nicer as the only changes required when adding support to another target is to place thi

Re: [PATCH 0/4] Add RISC-V semihosting support

Patchew URL: https://patchew.org/QEMU/20201028185722.2783532-1-kei...@keithp.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201028185722.2783532-1-kei...@keithp.com Subject: [PATCH 0/4] Add RISC-V semihosting su

[PATCH 4/4] riscv: Add semihosting support [v11]

Adapt the arm semihosting support code for RISCV. This implementation is based on the standard for RISC-V semihosting version 0.2 as documented in https://github.com/riscv/riscv-semihosting-spec/releases/tag/0.2 Signed-off-by: Keith Packard --- v2: Update PC after exception is handl

[PATCH 2/4] semihosting: Change common-semi API to be architecture-independent

The public API is now defined in hw/semihosting/common-semi.h. do_common_semihosting takes CPUState * instead of CPUARMState *. All internal functions have been renamed common_semi_ instead of arm_semi_ or arm_. Aside from the API change, there are no functional changes in this patch. Signed-off-b

[PATCH 3/4] semihosting: Change internal common-semi interfaces to use CPUState *

This makes all of the internal interfaces architecture-independent and renames the internal functions to use the 'common_semi' prefix instead of 'arm' or 'arm_semi'. To do this, some new architecture-specific internal helper functions were created: static inline target_ulong common_semi_a

[PATCH 0/4] Add RISC-V semihosting support

This series adapts the existing ARM semihosting code to be target-independent, and then uses that to provide semihosting support for RISC-V targets.

[PATCH 1/4] semihosting: Move ARM semihosting code to shared directories [v3]

This commit renames two files which provide ARM semihosting support so that they can be shared by other architectures: 1. target/arm/arm-semi.c -> hw/semihosting/common-semi.c 2. linux-user/arm/semihost.c -> linux-user/semihost.c The build system was modified use a new config variable, CONF

Re: [PATCH v2 3/6] configure: add option to enable LTO

On 10/28/2020 5:35 AM, Alex Bennée wrote: Breakage in both system and linux-user emulation probably points at something in the instruction decode being broken. Shame we don't have a working risu setup for sparc64 to give the instruction handling a proper work out. This is what I'm thinking too.

[PATCH v9 7/8] MAINTAINERS: Add myself as maintainer for yank feature

I'll maintain this for now as the colo usecase is the first user of this functionality. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ef6f5c7399..59

[PATCH v9 5/8] io/channel-tls.c: make qio_channel_tls_shutdown thread-safe

Make qio_channel_tls_shutdown thread-safe by using atomics when accessing tioc->shutdown. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé --- io/channel-tls.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/io/channel-tls.c b/io/c

[PATCH v9 6/8] io: Document qmp oob suitability of qio_channel_shutdown and io_shutdown

Migration and yank code assume that qio_channel_shutdown is thread -safe and can be called from qmp oob handler. Document this after checking the code. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé --- include/io/channel.h | 5 - 1 file changed, 4 in

[PATCH v9 4/8] migration: Add yank feature

Register yank functions on sockets to shut them down. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Acked-by: Dr. David Alan Gilbert --- migration/channel.c | 13 + migration/migration.c | 25 + migration/multifd.c | 10 ++

[PATCH v9 3/8] chardev/char-socket.c: Add yank feature

Register a yank function to shutdown the socket on yank. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi --- chardev/char-socket.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 95e45812d5..5947c

[PATCH v9 8/8] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test

A connecting chardev object has an additional reference by the connecting thread, so if the chardev is still connecting by the end of the test, then the chardev object won't be freed. This in turn means that the yank instance won't be unregistered and when running the next test-case yank_register_i

[PATCH v9 2/8] block/nbd.c: Add yank feature

Register a yank function which shuts down the socket and sets s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an error occured. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi --- block/nbd.c | 154 +++- 1 file changed, 93 inser

[PATCH v9 1/8] Introduce yank feature

The yank feature allows to recover from hanging qemu by "yanking" at various parts. Other qemu systems can register themselves and multiple yank functions. Then all yank functions for selected instances can be called by the 'yank' out-of-band qmp command. Available instances can be queried by a 'qu

[PATCH v9 0/8] Introduce 'yank' oob qmp command to recover from hanging qemu

Hello Everyone, I finally found time again to work on this, so here is v9 with the new qmp api. We still need ACKs from NBD and chardev maintainers. Changes: v9: -rebase onto master -implemented new qmp api as proposed by Markus v8: -add Reviewed-by and Acked-by tags -rebase onto master -m

Re: [PATCH 1/5] python: add pytest and tests

On 10/28/20 10:54 AM, Thomas Huth wrote: On 28/10/2020 14.23, John Snow wrote: On 10/28/20 2:19 AM, Thomas Huth wrote: On 27/10/2020 23.38, John Snow wrote: Try using pytest to manage our various tests; even though right now they're only invoking binaries and not really running any python-nati

Re: [PATCH 4/5] python: add .gitignore

On 10/28/20 4:13 AM, Thomas Huth wrote: On 27/10/2020 23.38, John Snow wrote: Ignore build and package output (build, dist, qemu.egg-info); effectively these are "in-tree" builds of a kind. Since we recently moved away from in-tree builds, could these also be made out-of-tree only? Thomas

Re: [PATCH 00/11] target/arm: Fix neon reg offsets

On Wed, 28 Oct 2020 at 16:48, Peter Maydell wrote: > > On Wed, 28 Oct 2020 at 03:27, Richard Henderson > wrote: > > > > Much of the existing usage of neon_reg_offset is broken for > > big-endian hosts, as it computes the offset of the first > > 32-bit unit, not the offset of the entire vector reg

Re: [PATCH 13/25] block/nvme: Introduce Completion Queue definitions

On 10/28/20 4:16 PM, Stefan Hajnoczi wrote: > On Tue, Oct 27, 2020 at 02:55:35PM +0100, Philippe Mathieu-Daudé wrote: >> Rename Submission Queue flags with 'Sq' and introduce >> Completion Queue flag definitions. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> include/block/nvme.h | 17 ++

Re: [PATCH v2 3/6] configure: add option to enable LTO

If LTO is enabled with the wrong linker/ar: - with the checks, it will exit at configure with an error. I can change this in a warning and disabling LTO if preferred. - without the checks compilation will fail If LTO is enabled with the wrong compiler (e.g. old gcc), you may get a bunch of war

Re: [PATCH 00/25] block/nvme: Fix Aarch64 host

Hi Philippe, On 10/27/20 2:55 PM, Philippe Mathieu-Daudé wrote: > Add a bit of tracing, clean around to finally fix few bugs. > In particular, restore NVMe on Aarch64 host. > > Eric Auger (4): > block/nvme: Change size and alignment of IDENTIFY response buffer > block/nvme: Change size and al

Re: [PATCH] pci: Refuse to hotplug PCI Devices when the Guest OS is not ready

On Wed, Oct 28, 2020 at 04:39:45PM +0100, Igor Mammedov wrote: > On Wed, 28 Oct 2020 14:31:35 +1100 > David Gibson wrote: > > > On Tue, 27 Oct 2020 13:54:26 +0100 > > Igor Mammedov wrote: > > > > > On Tue, 27 Oct 2020 07:26:44 -0400 > > > "Michael S. Tsirkin" wrote: > > > > > > [...] > > >

[PATCH] meson.build: fix building of Xen support for aarch64

Xen is supported on aarch64 although weirdly using the i386-softmmu model. Checking based on the host CPU meant we never enabled Xen support. It would be nice to enable CONFIG_XEN for aarch64-softmmu to make it not seem weird but that will require further build surgery. Signed-off-by: Alex Bennée

Re: [PATCH 04/29] vl: remove bogus check

On Wed, Oct 28, 2020 at 05:48:57PM +0100, Igor Mammedov wrote: > On Tue, 27 Oct 2020 14:21:19 -0400 > Paolo Bonzini wrote: > > > There is no reason to prevent -preconfig -daemonize. Of course if > > no monitor is defined there will be no way to start the VM, > > but that is a user error. > > it

Re: [PATCH 1/9] target/i386: silence the compiler warnings in gen_shiftd_rm_T1

On 28/10/2020 16.31, Richard Henderson wrote: > On 10/28/20 5:57 AM, Thomas Huth wrote: >> On 28/10/2020 05.18, Chen Qun wrote: >>> The current "#ifdef TARGET_X86_64" statement affects >>> the compiler's determination of fall through. >>> >>> When using -Wimplicit-fallthrough in our CFLAGS, the com

Re: [PATCH v2] xen: rework pci_piix3_xen_ide_unplug

On Tue, Oct 27, 2020 at 01:33:32PM -0400, John Snow wrote: > On 10/27/20 11:40 AM, Anthony PERARD wrote: > > From: Anthony PERARD > > > > This is to allow IDE disks to be unplugged when adding to QEMU via: > > -drive file=/root/disk_file,if=none,id=ide-disk0,format=raw > > -device ide-h

Re: [PATCH 04/29] vl: remove bogus check

On Tue, 27 Oct 2020 14:21:19 -0400 Paolo Bonzini wrote: > There is no reason to prevent -preconfig -daemonize. Of course if > no monitor is defined there will be no way to start the VM, > but that is a user error. it was related to how libvirt starts QEMU but I don't recall why anymore, CCing D

[PULL v2 32/32] vfio: fix incorrect print type

From: Zhengui li The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li Signed-off-by: Alex Williamson --- hw/vfio/common.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vfio/common.c b/h

[PULL v2 29/32] vfio: Add routine for finding VFIO_DEVICE_GET_INFO capabilities

From: Matthew Rosato Now that VFIO_DEVICE_GET_INFO supports capability chains, add a helper function to find specific capabilities in the chain. Signed-off-by: Matthew Rosato Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- hw/vfio/common.c | 10 ++ includ

[PULL v2 28/32] s390x/pci: use a PCI Function structure

From: Pierre Morel We use a ClpRspQueryPci structure to hold the information related to a zPCI Function. This allows us to be ready to support different zPCI functions and to retrieve the zPCI function information from the host. Signed-off-by: Pierre Morel Signed-off-by: Matthew Rosato Review

  1   2   3   4   >