On Tue, Oct 27, 2020 at 01:33:32PM -0400, John Snow wrote: > On 10/27/20 11:40 AM, Anthony PERARD wrote: > > From: Anthony PERARD <anthony.per...@citrix.com> > > > > This is to allow IDE disks to be unplugged when adding to QEMU via: > > -drive file=/root/disk_file,if=none,id=ide-disk0,format=raw > > -device ide-hd,drive=ide-disk0,bus=ide.0,unit=0 > > > > as the current code only works for disk added with: > > -drive file=/root/disk_file,if=ide,index=0,media=disk,format=raw > > > > Since the code already have the IDE controller as `dev`, we don't need > > to use the legacy DriveInfo to find all the drive we want to unplug. > > We can simply use `blk` from the controller, as it kind of was already > > assume to be the same, by setting it to NULL. > > > > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> > > Acked-by: John Snow <js...@redhat.com> > > Do you need me to send a PR for this?
No, that's fine, I can do the PR since it's all xen code. Thanks, -- Anthony PERARD
